Improve overall structure #5

New Issue

EpicKnarvik97 · 2022-02-18T17:15:39+01:00

EpicKnarvik97 commented

2022-02-18 17:15:39 +01:00

A better structure would be to make the id into something that the player uses to identify the paid sign. The actual text to match would be specified in a "condition". A paid sign can have one condition for each line on the sign (#2). The required permission (#4) would be specified when creating the paid sign.

I'm not sure if case and color sensitivity should be specified for the condition or for the paid sign. Perhaps both.

Need to make matching just use a .matches method. One method that checks for if a sign matches a paid sign's conditions, one method that's used to see if two paid signs have identical conditions, and one to notify about similarities.

A better structure would be to make the id into something that the player uses to identify the paid sign. The actual text to match would be specified in a "condition". A paid sign can have one condition for each line on the sign (#2). The required permission (#4) would be specified when creating the paid sign. I'm not sure if case and color sensitivity should be specified for the condition or for the paid sign. Perhaps both. Need to make matching just use a .matches method. One method that checks for if a sign matches a paid sign's conditions, one method that's used to see if two paid signs have identical conditions, and one to notify about similarities.

EpicKnarvik97 added the

enhancement

label 2022-02-18 17:15:39 +01:00

EpicKnarvik97 referenced this issue from a commit

2022-02-18 19:39:29 +01:00

Rewrites a bunch of code to improve the structure as specified in #5, #4, #2, #1

EpicKnarvik97 commented

2022-02-27 15:51:45 +01:00

Fixed

EpicKnarvik97 closed this issue

2022-02-27 15:51:45 +01:00

Sign in to join this conversation.