TfT_02
6f9a57751e
We can't schedule tasks in onDisable()
2013-11-01 17:39:03 +01:00
GJ
2e1c585005
Fix issue with updating players that are offline.
2013-11-01 12:38:40 -04:00
GJ
811626e67b
Cleanup.
2013-11-01 11:54:51 -04:00
TfT_02
cdfd81a67a
Cleanup ZipLibrary class
2013-11-01 16:44:03 +01:00
TfT_02
408b8b2107
Added automatic cleanup of backups folder
...
By default mcMMO keeps the following files:
* All files from the last 24 hours
* Daily backups of the past week
* Weekly backups of the past months
Adds #1574
2013-11-01 16:43:56 +01:00
GJ
6d5f3a52f4
Don't process chat if the mcMMOPlayer is null.
...
The player should ALWAYS be online when chatting, but depending on
external plugins and applications, this is not always properly
implemented. Fixes #1578
2013-11-01 09:30:10 -04:00
GJ
2cdf08de9f
Allow offline players for chat events.
...
This fixes issues with plugins or applications that rely on JSONAPI to
chat. Fixes #1578
2013-11-01 09:12:06 -04:00
GJ
71141a0f8d
Minimum quantity should default to 2.
...
Fixes #1581
2013-11-01 08:22:14 -04:00
TfT_02
bded936af5
Cleanup our imports
2013-10-31 22:30:05 +01:00
GJ
caaac232d7
Cleanup CombatUtils.
...
Opting to stick with the if-else rather than the switch statement,
because I think it's slightly easier to read.
2013-10-31 15:03:06 -04:00
GJ
a9d51dad34
Clean up Smelting checks.
...
Now uses recipes to check if an item is the result of smelting.
2013-10-31 14:29:06 -04:00
GJ
88296da0af
Removed MCPC+ workaround.
...
This has been fixed by MCPC+ starting with build 112.
Addresses #1549
2013-10-31 13:28:54 -04:00
GJ
de3c4f8fd7
Smelting now works with custom ores.
...
Also fixed exploit where smelting XP could be awarded for some
non-smeltable materials.
2013-10-31 13:25:06 -04:00
GJ
1785bab504
Fix bug with Salvage config value.
...
After our renames and updates, Salvage was not reading the config value
for the anvil material properly.
2013-10-31 09:09:52 -04:00
GJ
41da32cd1b
Added options to disable various sound effects.
...
Fixes #1577
2013-10-31 09:03:29 -04:00
GJ
93d586592e
Move these checks up.
...
These checks need to happen sooner because they may impact config
loading, specifically the MCPC+ check.
Fixes #1549
2013-10-31 08:15:30 -04:00
Glitchfinder
d6c6c75157
Experience is occasionally zero or cast to zero.
...
Fixes #1575 and fixes #1576
2013-10-30 15:49:47 -07:00
GJ
4889769522
Workaround MCPC+ shortcomings for now.
...
Fixes #1549
2013-10-30 15:33:37 -04:00
GJ
fd9154e009
Fixed bug with toggle commands not properly displaying the success message.
2013-10-29 11:45:27 -04:00
GJ
97b9214d6e
Wrap these inside McMMOPlayer for easier access.
2013-10-29 11:02:57 -04:00
GJ
a8d1376533
More minor cleanup.
2013-10-29 10:01:30 -04:00
GJ
3be443c63c
Cleanup some XP functions, remove unused scoreboard values, minor refactoring.
2013-10-29 09:49:41 -04:00
GJ
cc2c9eb21d
Move this to the skill itself.
2013-10-28 16:32:40 -04:00
GJ
9b3ae5c729
These belong in their managers, not in McMMOPlayer
2013-10-28 16:14:52 -04:00
GJ
ccb7fc5886
Remove, don't just comment out.
2013-10-28 16:04:55 -04:00
GJ
60d69e3cc4
Create wrapper to handle all PTP data.
2013-10-28 15:49:48 -04:00
riking
f64f62492f
Reinstate static color list, clarify intent
2013-10-28 12:47:25 -07:00
GJ
3fe936306b
Oops.
2013-10-28 15:19:47 -04:00
GJ
c79f8043ad
Use proper functions where they exist, and move functions to better locations.
2013-10-28 15:12:24 -04:00
GJ
8369ae4616
Don't use a class variable here.
2013-10-28 14:14:20 -04:00
GJ
62e03a4ef5
Black is hard to read.
2013-10-28 13:58:34 -04:00
GJ
9ef3c721df
Formatting cleanup from the scoreboard update. Also handle skill permissions differently.
2013-10-28 13:04:46 -04:00
TfT_02
f55039ac6b
Earn XP when using Shake
...
Adds #1564
2013-10-28 17:38:03 +01:00
TfT_02
be792a1052
Fix exploitPrevention() and add Javadocs
2013-10-28 15:39:47 +01:00
GJ
c612036db3
Don't try to find a treasure if there aren't any.
...
Fixes #1572
2013-10-28 08:52:55 -04:00
GJ
ad4ee6f402
Cleanup exploit prevention method.
2013-10-28 08:17:06 -04:00
TfT_02
49a5bd2ba6
We can move this check to exploitPrevention()
2013-10-26 00:50:31 +02:00
GJ
134e0db2e9
Cleanup more of Riking's mess.
2013-10-25 17:07:56 -04:00
GJ
b3415ee2f4
Cleanup some of Riking's mess.
2013-10-25 17:05:36 -04:00
TfT_02
14175a6dfd
Don't complain about missing Guide strings
2013-10-25 22:16:18 +02:00
TfT_02
7b3fb46a9a
Improved AFK Acrobatics prevention mechanism
2013-10-25 22:02:39 +02:00
riking
17b7a9bf10
Add message to /mcscoreboard time [n]
2013-10-25 11:41:21 -07:00
riking
bd611ee11c
Add message to /mcscoreboard keep when a board is not shown
2013-10-25 11:39:24 -07:00
riking
c6ca65f5c9
Create a utility method in SkillUtils to easily check ability cooldowns
2013-10-25 09:49:02 -07:00
riking
95f15e68fe
New and Improved Scoreboard System
...
- Scoreboards now AUTO-UPDATE
- Scoreboards now COME IN COLOR
- If you want, they can come in EVERY COLOR (Config setting)
- Scoreboards can be displayed alongside chat output!
- Prevention of denial of service to SQL via spamming /mctop using a cooldown
- Added /mccooldown command to show cooldowns for all available skills
2013-10-25 09:49:02 -07:00
TfT_02
89dabaeb43
Hook location cleanup
2013-10-24 23:14:23 +02:00
TfT_02
c2e100b1e3
Use hook location in Master Angler
2013-10-24 21:19:24 +02:00
GJ
9f33c6cef1
Use addUnsafeEnchantment instead of addEnchantment
...
Since the enchantment was already present on the item, there's no need to check if it's valid. This also avoids any errors that may occur when trying to repair an item with non-standard enchants.
Fixes #1561
2013-10-22 09:57:13 -04:00
GJ
bc51505150
More cleanup.
2013-10-21 08:31:35 -04:00
TfT_02
e0599a0dea
Subtract XP with Hardcore mode
...
Adds #1529
2013-10-20 20:02:16 +02:00
TfT_02
d410251595
Changed kraken default behavior
...
It will no longer broadcast chat messages globally by default, as well as strike lightning on it's target. Instead it will spawn explosion effects.
2013-10-20 17:04:50 +02:00
TfT_02
810c74dc2a
Fixed bug which prevented players from leveling up
...
Any affected players will get their levels back when they gain some
more XP in that particular skill.
2013-10-19 14:08:04 +02:00
TfT_02
100f2c7e56
Added a warning message if the server is running NoCheatPlus without CompatNoCheatPlus
2013-10-19 00:27:07 +02:00
TfT_02
b100b7bcc7
Gravity's Updater version 2.0
2013-10-18 16:58:12 +02:00
TfT_02
f4ff8518c2
Cleanup progress feedback
2013-10-18 16:43:37 +02:00
riking
dbd27b641e
Give periodic status messages to the console in conversion
2013-10-18 16:40:44 +02:00
TfT_02
4a428a47af
Fix bug with HolidayManager and some cleanup
2013-10-18 16:24:01 +02:00
GJ
68c4b99d1b
Oops.
2013-10-18 10:16:51 -04:00
GJ
f282891d0a
More info for armor errors.
2013-10-18 10:15:23 -04:00
GJ
7f4e3fedb3
Need different methods for mod files and regular files.
2013-10-18 10:12:55 -04:00
GJ
2042e0cdbd
How did I not realize this would loop forever...
2013-10-18 10:02:11 -04:00
GJ
2662fee9fb
ACTUALLY use the proper path.
2013-10-18 10:02:10 -04:00
TfT_02
e8e2dcff46
-levelsChanged instead of - levelsChanged
2013-10-18 15:26:15 +02:00
TfT_02
3b09012b35
Also use getServer() here as well
2013-10-18 15:26:14 +02:00
GJ
a774733af4
Use proper path
2013-10-18 09:23:10 -04:00
GJ
b8c1f868f5
Event updates
2013-10-18 08:54:06 -04:00
GJ
3f56a8fbcf
Importing Bukkit.java is bad, always use getServer() instead
2013-10-18 08:54:05 -04:00
Bestle
d8e86d0fc7
Fix logic error in fireworkParticleShower
...
If a player is inside a vehicle, the y position of the spawned firework should be modified, not the x
2013-10-18 12:59:21 +01:00
TfT_02
e125700b43
Fixed Fishing ability "Shake"
2013-10-18 12:25:49 +02:00
Bestle
4bc446e306
Add missing ignoreCancelled checks
...
If a plugin cancels a piston retract or extend event, mcMMO still considers that block or blocks to have moved.
This allow players to gain xp and double drops from blocks that they shouldn't. Checking for cancelled events fixes this.
2013-10-17 21:05:29 +01:00
riking
b4f4de4628
Get all logs in Tree Feller, and optimize performance
...
Tree Feller has been shown, both anecdotally and with timings, to put a strain on the server, and therefore is worthy of the effort of optimization.
Prior to this change, on jungle trees, Tree Feller would take around 20-40 milliseconds to process a Jungle Tree after the JIT kicked in, and around 15-25 milliseconds for a normal tree.
Additionally, logs would be left up in the air for jungle trees.
After this change, Tree Feller takes 2-5 milliseconds on normal trees, and 10-15 milliseconds on jungle trees, and no logs are left up in the air.
2013-10-16 00:59:11 +02:00
TfT_02
b9c652ef2b
This check shouldn't be inverted
...
Fixes #1545
2013-10-16 00:57:56 +02:00
GJ
bf4e8d43ea
Because the entity that exploded might be null (or might not be TNT)
2013-10-15 13:10:29 -04:00
GJ
468fbdab56
SkillUtils cleanup, EventUtils creation
...
Move some functions in SkillUtils to more relevant locations.
Begin work on utility class to handle all event calls.
2013-10-15 13:03:33 -04:00
GJ
309dfd50cd
Revert change to smoke particle handling
...
Have to do it this way, because not all block directions are valid for
smoke
2013-10-15 08:38:59 -04:00
riking
44e3e4d1e1
Localize several command results
...
Also don't nullcheck the null-guarded mcMMOPlayer in PartyManager
2013-10-14 20:48:36 +02:00
riking
476f426590
Remove RepairableManagerFactory until we actually need it
...
Let's hold off on the factory pattern until we actually offer choices.
2013-10-14 20:48:35 +02:00
riking
766f1f4127
Oh! So that's why it's never used here
2013-10-14 20:48:35 +02:00
riking
b3cf9bf839
When an error occurs updating the leaderboards, print out the current player name if possible
2013-10-14 09:53:42 -07:00
GJ
056f7cc93b
Nicer handling of some particle effect code.
2013-10-14 11:29:25 -04:00
TfT_02
741f629ab8
Don't spawn fireworks under a boat (for real this time)
...
Fixes #1534
2013-10-14 17:07:15 +02:00
TfT_02
dd64c4008b
Account for Master Angler config values in /fishing
...
Fixes #1537
2013-10-14 16:28:48 +02:00
TfT_02
3a5de8e2ce
This should be on LOWEST
2013-10-14 09:28:16 +02:00
TfT_02
2d78c0738d
Color party leader names only once
2013-10-12 20:50:42 +02:00
TfT_02
67e9d9c535
Fishing TNT traps should not destroy blocks
2013-10-12 03:30:10 +02:00
TfT_02
800786111c
Fix apostrophe issues
...
Fixes #1523
2013-10-12 02:41:13 +02:00
TfT_02
ed8197bd50
Remove level based bonus from Master Angler
...
Let's try this another way, instead of removing this passive ability all togheter I think it would be nice to keep the boat/biome catch rate boost. The level based boost was out of hand and counter-intuitive as it made leveling easier on high skill levels.
2013-10-12 02:41:13 +02:00
TfT_02
82f8c4ce36
Fishing Treasure Hunter overhaul
2013-10-12 02:41:13 +02:00
TfT_02
b1cf7d0348
Fire FakeBlockBreakEvent when using Hylian Luck
...
Fixes #1528
2013-10-11 23:47:42 +02:00
TfT_02
49cbaad47f
Clean up advanced.yml comments and keys
2013-10-11 16:22:30 +02:00
TfT_02
1d96ed72dc
Move Acrobatics XP settings to experience.yml
2013-10-11 15:18:57 +02:00
TfT_02
ec378d046f
Reformat advanced.yml making the keys consistent
2013-10-11 15:18:56 +02:00
GJ
a25dc24c6c
No reason to have this many functions...
2013-10-11 15:18:56 +02:00
TfT_02
68eb51a3d0
Removed Shake_UnlockLevel config option
...
because it is no longer needed.
2013-10-11 15:18:56 +02:00
TfT_02
2eda3a9c83
Add extra tiers! Every ability now has 8 tiers
2013-10-11 15:18:55 +02:00
GJ
ad8e200a84
Make sure we update the blocks config after this too.
2013-10-09 11:45:49 -04:00
GJ
0c83bf2a80
Improve our drop handling.
2013-10-09 11:44:45 -04:00
GJ
6eaec5ffab
We don't need this anymore.
2013-10-09 10:27:06 -04:00
GJ
8a2c5fb051
Check 0 first.
2013-10-09 10:26:51 -04:00
GJ
9485869014
Move these functions to SkillType.
2013-10-09 09:20:32 -04:00
GJ
e1bf55b077
Backup old mod configs & replace with new.
2013-10-08 13:10:09 -04:00
GJ
81140824e4
Backup and replace updated treasures.yml file.
2013-10-07 13:09:46 -04:00
GJ
d5545de81f
Backup & replace the repair config files that have been updated.
2013-10-07 13:04:36 -04:00
GJ
8632baed27
No reason to handle this ourselves, Bukkit does it for us.
2013-10-07 11:54:23 -04:00
GJ
9aaea7e44f
Fix old files if they exist.
2013-10-07 10:43:22 -04:00
GJ
c2f8f4d016
User data is now saved in flatfile, not FlatFileStuff
2013-10-07 10:33:14 -04:00
GJ
5131e74349
Save mod config files to "mods" rather than "ModConfigs", mirror directory structure inside the jar file.
2013-10-07 10:32:40 -04:00
GJ
3927427b5b
Refactor all our repairable stuff into a special package.
2013-10-07 10:23:04 -04:00
TfT_02
4aef4c63fc
Split the locale skill guides into seperate sections
...
This will make it easier for translators to keep up with translating our skill guides. Closes #560
2013-10-07 16:05:11 +02:00
GJ
fb4777e7f0
Added XP boost to Acrobatics when wearing Boots of Feather Falling.
...
Adds #1098
2013-10-07 09:53:32 -04:00
GJ
d8f3a54f9b
Compiler throws warnings all over the place about our close methods, this one is no different.
2013-10-07 07:56:13 -04:00
GJ
de964a3a60
This naming bothers me.
2013-10-07 07:53:42 -04:00
t00thpick1
ce3bc07aa8
Reasonably sure this needs to be this way
2013-10-06 17:46:45 -04:00
TfT_02
5a6bb363cf
Don't spawn fireworks under the player if they're in a vehicle
2013-10-06 12:08:22 +02:00
TfT_02
3f9c98d72e
Update changelog & minor formatting fixes
2013-10-06 10:25:28 +02:00
riking
96b54387fe
SQL database - split loadProfile to have retry flag
...
Instead of assuming that newUser() worked as intended, we cycle back around into the method.
This also removes the possibility of infinite loops from the writeMissingRows() code path.
2013-10-06 10:09:09 +02:00
riking
70eb67dd6a
Flatfile loadProfile - place newUser() inside of try block
...
This fixes incorrect behavior in the edge-case where an IOException occurs when reading (but not writing) the flatfile database.
2013-10-06 10:09:09 +02:00
riking
77f9f40065
Do not save an un-loaded PlayerProfile
2013-10-06 10:09:09 +02:00
riking
14ae1a69c4
Attempt clean recovery from an unloaded PlayerProfile
...
This change should cause McMMOPlayer to create a graceful recovery when the database is temporarily unavailable.
When a McMMOPlayer is constructed and recieves an unloaded PlayerProfile, it schedules a task to re-attempt profile retrieval. This task can run for a maximum of 5 seconds, after which a second warning is printed indicating that it has given up (and a message given to the user).
2013-10-06 10:09:09 +02:00
riking
c9858dfd49
Do not mark a PlayerProfile as clean if it failed to save
...
DatabaseManager.saveUser() now returns a success value, which is used by PlayerProfile to determine whether or not it should be considered clean.
2013-10-06 10:09:09 +02:00
riking
f75fe3cc89
Potential fix for loss of data due to SQL connection dropping
...
The idea behind this change is to send a ping every hour, which is shorter than the driver's 'dead connection' threshold of 8 hours.
As a side effect, this also will fix a subset of the situations where the MySQL server is restarted.
2013-10-06 10:09:08 +02:00
TfT_02
c19ccbccac
Use only 1 extra durability by default, instead of 2
2013-10-06 10:08:06 +02:00
TfT_02
2f90e533a5
Improve validation messages of treasures.yml
2013-10-06 09:51:33 +02:00
Kane York
0cd0919447
/mcconvert: Fix mismatched type in list.remove() call
...
The databaseTypes collection is a List<String>, so attempting to remove a DatabaseType object will have no effect.
2013-10-05 14:07:06 -07:00
TfT_02
e8b886fcc6
This check somehow got removed
2013-10-05 01:18:51 +02:00
GJ
b8e937a234
ALWAYS remove pots broken by swords.
2013-10-04 13:16:41 -04:00
GJ
eb2e0d3abf
Fixed Hylian Luck not working at all.
...
Fixes #1508
2013-10-04 10:27:18 -04:00
GJ
3365da7f8d
MCPC+ checks, notify server owners that they're missing out.
2013-10-04 09:50:49 -04:00
TfT_02
a0e37a4a09
I forgot to invert this check
2013-10-03 22:04:39 +02:00
GJ
5541c15753
Try/catch was stupid.
2013-10-02 09:07:30 -04:00
GJ
f87110749e
ACTUALLY fix the NPE here.
2013-10-02 09:03:09 -04:00
GJ
a0ef0d5708
Check vanilla's maxDurability here as well, just to be safe.
...
Fixes #1504
2013-10-02 08:56:48 -04:00
TfT_02
2e2abcd645
Handle this nicer
2013-10-02 10:42:06 +02:00
TfT_02
6baf820afa
Cleanup and formatting
2013-10-01 22:14:29 +02:00
Kane York
288287badf
Add holiday celebration for the console
2013-10-01 22:06:51 +02:00
GJ
7c9356955e
ACTUALLY handle SQL passwords (or other fields) with '#' in them properly.
2013-09-30 16:17:44 -04:00
GJ
57541ec233
This can never be null, and there's no reason to pass that as a variable.
2013-09-30 14:19:07 -04:00
TfT_02
9c6d1ce020
Fixing these infinite recursing methods
...
Oops, that was silly. Thanks @t00thpick1
2013-09-30 19:38:22 +02:00
TfT_02
c72ead9d0a
Prevent breaking other plugins who use this API
2013-09-30 19:03:44 +02:00
TfT_02
eb589b6e78
Renamed some config options in the Commands section.
...
The following keys have been renamed:
* General => Generic
* p => partychat
* a => adminchat
2013-09-30 15:43:37 +02:00
GJ
98e5e53fda
Ignore "#" in SQL passwords.
2013-09-30 08:36:32 -04:00
TfT_02
00918fbdc1
Change this back, getPlayerExact() is faster
2013-09-30 14:04:34 +02:00
TfT_02
5ad0f2c624
Do a little bit of localebending
2013-09-30 11:32:35 +02:00
TfT_02
babb9baa2b
Handle joining disbanded parties properly
2013-09-30 11:22:15 +02:00
TfT_02
45143836e5
Fixed /party kick
...
Fixes #1499
2013-09-30 10:39:33 +02:00
TfT_02
ceacd7dc52
Fixed /party disband
2013-09-30 10:39:14 +02:00
TfT_02
6eb255632f
Clean this up a little bit
2013-09-30 10:24:36 +02:00
TfT_02
3a37d0e092
Fixing an error due to confusingly named check
...
Refactored healthBarEnabled to healthBarPluginEnabled to avoid this
from happening again.
2013-09-29 23:57:13 +02:00
TfT_02
4c7fb1854d
addRawXP should use float instead of int
2013-09-29 15:48:11 +02:00
TfT_02
763cff6898
Fixed a bug where Repair wasn't asking for confirmation
2013-09-28 19:46:47 +02:00