EpicKnarvik97/mcMMO
1
0
Fork 0
mirror of https://github.com/mcMMO-Dev/mcMMO.git synced 2025-07-21 14:54:44 +02:00
Code Issues Projects Releases Wiki Activity

Add some unit tests for new RNG dice rolls

Browse Source
This commit is contained in:
nossr50
2022-12-11 15:38:04 -08:00
parent b077d9e0fb
commit 05c86f1125
4 changed files with 83 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/com/gmail/nossr50/util/random/RandomChanceUtil.java
View File

@ -4,12 +4,11 @@ import com.gmail.nossr50.datatypes.skills.SubSkillType;
import com.gmail.nossr50.util.skills.SkillUtils;
import org.bukkit.entity.Player;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.VisibleForTesting;
import java.text.DecimalFormat;
import java.util.concurrent.ThreadLocalRandom;
//TODO: Normalize chance values
//TODO: Update calls to this class and its members
public class RandomChanceUtil {
public static final @NotNull DecimalFormat percent = new DecimalFormat("##0.00%");
public static final double LUCKY_MODIFIER = 1.333D;
@ -43,8 +42,9 @@ public class RandomChanceUtil {
* @param probabilityValue probability value
* @return true for succeeding, false for failing
*/
private static boolean isSuccessfulRoll(double probabilityValue) {
return probabilityValue >= ThreadLocalRandom.current().nextDouble(1.0D);
@VisibleForTesting
static boolean isSuccessfulRoll(double probabilityValue) {
return probabilityValue >= ThreadLocalRandom.current().nextDouble(100D);
}
/**
@ -52,7 +52,7 @@ public class RandomChanceUtil {
*
* @param player target player
* @param subSkillType target subskill
* @param isLucky whether or not to apply luck modifiers
* @param isLucky whether to apply luck modifiers
*
* @return "percentage" representation of success
*/