Vehicle teleportation needs to be fixed #1
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: EpicKnarvik97/Stargate#1
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Vehicle teleportation is currently kind of buggy and weird. One problem is that the VehicleMoveEvent works fine to detect minecarts, but does not detect pigs and horses. One way to fix this is to detect these on the player telportation event, but then we need to avoid triggering this twice when the user teleports using a minecart.
There's also some problems placing the player back on the vehicle. With minecarts, it only seems to work properly if the minecart is destroyed, then recreated. With horses, it's awful to fully recreate a horse, so there needs to be a way of making this work by just teleporting the vehicle and then putting the player on top.
There seems to be a weird bug when putting the player back on a living vehicle. While testing on a pig, the carrot on a stick seems to rotate the pig, but the player can move freely. When clicking shift, the player is teleported back to the pig. It seems this might be a bug in Paper or Minecraft. It's present in 1.16.5-503.
I was able to make horse and pig teleportation work, at the cost of minecart teleportation in some cases. Back to debugging I guess...
The minecart teleportation has been fixed, but the player isn't always rotated forwards, which is quite annoying.
Horses sometimes decide to glitch out, causing the player to get stuck where it cannot move the camera left and right, only up and down. The player cannot dismount the horse. Leaving and joining again seems to fix the problem. Usually when this occurs, the player is facing right or left from the portal exit.
Edit: Horse is invisible, but can be heard.