Vehicle teleportation needs to be fixed #1

New Issue

EpicKnarvik97 · 2021-02-20T15:11:16+01:00

EpicKnarvik97 commented

2021-02-20 15:11:16 +01:00

Vehicle teleportation is currently kind of buggy and weird. One problem is that the VehicleMoveEvent works fine to detect minecarts, but does not detect pigs and horses. One way to fix this is to detect these on the player telportation event, but then we need to avoid triggering this twice when the user teleports using a minecart.

There's also some problems placing the player back on the vehicle. With minecarts, it only seems to work properly if the minecart is destroyed, then recreated. With horses, it's awful to fully recreate a horse, so there needs to be a way of making this work by just teleporting the vehicle and then putting the player on top.

Vehicle teleportation is currently kind of buggy and weird. One problem is that the VehicleMoveEvent works fine to detect minecarts, but does not detect pigs and horses. One way to fix this is to detect these on the player telportation event, but then we need to avoid triggering this twice when the user teleports using a minecart. There's also some problems placing the player back on the vehicle. With minecarts, it only seems to work properly if the minecart is destroyed, then recreated. With horses, it's awful to fully recreate a horse, so there needs to be a way of making this work by just teleporting the vehicle and then putting the player on top.

EpicKnarvik97 added the

bug

label 2021-02-20 15:11:16 +01:00

EpicKnarvik97 commented

2021-02-27 18:33:01 +01:00

There seems to be a weird bug when putting the player back on a living vehicle. While testing on a pig, the carrot on a stick seems to rotate the pig, but the player can move freely. When clicking shift, the player is teleported back to the pig. It seems this might be a bug in Paper or Minecraft. It's present in 1.16.5-503.

EpicKnarvik97 commented

2021-09-10 21:34:20 +02:00

I was able to make horse and pig teleportation work, at the cost of minecart teleportation in some cases. Back to debugging I guess...

EpicKnarvik97 commented

2021-09-10 23:41:40 +02:00

The minecart teleportation has been fixed, but the player isn't always rotated forwards, which is quite annoying.

EpicKnarvik97 commented

2021-09-12 04:05:07 +02:00

Horses sometimes decide to glitch out, causing the player to get stuck where it cannot move the camera left and right, only up and down. The player cannot dismount the horse. Leaving and joining again seems to fix the problem. Usually when this occurs, the player is facing right or left from the portal exit.
Edit: Horse is invisible, but can be heard.

Horses sometimes decide to glitch out, causing the player to get stuck where it cannot move the camera left and right, only up and down. The player cannot dismount the horse. Leaving and joining again seems to fix the problem. Usually when this occurs, the player is facing right or left from the portal exit. Edit: Horse is invisible, but can be heard.

EpicKnarvik97 referenced this issue from a commit

2021-10-10 17:15:12 +02:00

Adds some small changes which seem to completely fix all horse teleportation bugs. Fixes #1

EpicKnarvik97 closed this issue

2021-10-10 17:15:12 +02:00

Sign in to join this conversation.