Change order in UPlayer.detachId to avoid NPE.
This commit is contained in:
		| @@ -42,16 +42,19 @@ public class UPlayerColl extends SenderColl<UPlayer> | ||||
| 	@Override | ||||
| 	public UPlayer detachId(Object oid) | ||||
| 	{ | ||||
| 		UPlayer ret = super.detachId(oid); | ||||
| 		UPlayer ret = this.get(oid); | ||||
| 		if (ret == null) return null; | ||||
| 		 | ||||
| 		// If inited ... | ||||
| 		if (!this.inited()) return ret; | ||||
| 		 | ||||
| 		// ... update the index. | ||||
| 		Faction faction = ret.getFaction(); | ||||
| 		faction.uplayers.remove(ret); | ||||
| 		if (this.inited()) | ||||
| 		{ | ||||
| 			// ... update the index. | ||||
| 			Faction faction = ret.getFaction(); | ||||
| 			faction.uplayers.remove(ret); | ||||
| 		} | ||||
| 		 | ||||
| 		super.detachId(oid); | ||||
| 	 | ||||
| 		return ret; | ||||
| 	} | ||||
| 	 | ||||
|   | ||||
| @@ -138,6 +138,7 @@ public class FactionsListenerEcon implements Listener | ||||
| 		} | ||||
| 		else if (event.getReason() == MembershipChangeReason.LEAVE) | ||||
| 		{ | ||||
| 			// TODO: NPE once occurred on line below. | ||||
| 			cost = UConf.get(event.getSender()).econCostLeave; | ||||
| 			desc = "leave a faction"; | ||||
| 		} | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 
				 Olof Larsson
					Olof Larsson