From b33f514dcab03a3f3fccf4781061380134987fba Mon Sep 17 00:00:00 2001 From: EpicKnarvik97 Date: Tue, 23 Apr 2024 14:42:53 +0200 Subject: [PATCH] Prevents a permission error message when not trying to edit a sign --- .../listener/SignClickListener.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/java/net/knarcraft/placeholdersigns/listener/SignClickListener.java b/src/main/java/net/knarcraft/placeholdersigns/listener/SignClickListener.java index 5b88ae5..9e1da49 100644 --- a/src/main/java/net/knarcraft/placeholdersigns/listener/SignClickListener.java +++ b/src/main/java/net/knarcraft/placeholdersigns/listener/SignClickListener.java @@ -59,15 +59,15 @@ public class SignClickListener implements Listener { return; } - if (sign.isWaxed() && !player.hasPermission("placeholdersigns.edit.bypass-waxed")) { - PlaceholderSigns.getInstance().getStringFormatter().displayErrorMessage(player, - PlaceholderSignMessage.ERROR_WAXED_NO_PERMISSION); - return; - } - // Check if the player has run the /editSign command SignLineChangeRequest request = requestHandler.getSignChangeRequest(player); if (request != null) { + if (sign.isWaxed() && !player.hasPermission("placeholdersigns.edit.bypass-waxed")) { + PlaceholderSigns.getInstance().getStringFormatter().displayErrorMessage(player, + PlaceholderSignMessage.ERROR_WAXED_NO_PERMISSION); + return; + } + SignSide standingOn = sign.getTargetSide(player); Side side = sign.getSide(Side.FRONT).equals(standingOn) ? Side.FRONT : Side.BACK; doSignChange(sign, request, event, player, side); @@ -90,7 +90,7 @@ public class SignClickListener implements Listener { getSignText(front.getLines(), raw); String backLines = showPlaceholders ? getPlaceholderSignText(location, back, Side.BACK, raw) : getSignText(back.getLines(), raw); - + StringFormatter stringFormatter = PlaceholderSigns.getInstance().getStringFormatter(); StringReplacer replacer = new StringReplacer(stringFormatter.getUnformattedColoredMessage( PlaceholderSignMessage.SUCCESS_SIGN_CONTENTS));