diff --git a/README.MD b/README.MD index 509f9e1..a9be3ae 100644 --- a/README.MD +++ b/README.MD @@ -11,4 +11,18 @@ can be heard further away. ## Dependencies -- Citizens \ No newline at end of file +- Citizens + +## Important to note + +There are limitations connected to directly playing media using playSound: + +- There is no way to really know what is playing for a player. The best one can do is track any time a song is played + outside the global cycle. +- When a new player joins there are only two ways to make the music play for the player: Either play immediately, and + cut the song short once the playlist switches songs, or play nothing until the playlist switches songs. None of these + are ideal. +- Songs are really only identified by the category and the song id. Stopping the song for one minstrel will also stop + the song if played by any other minstrels at the same time. As songs are only stopped if a song has been played for a + player outside the global cycle, it shouldn't be too much of a problem, but if several minstrels play the same song, + there may be silent minstrels until the next song plays. \ No newline at end of file diff --git a/src/main/java/net/knarcraft/minstrel/command/MinstrelCommand.java b/src/main/java/net/knarcraft/minstrel/command/MinstrelCommand.java index e19a5e0..939497d 100644 --- a/src/main/java/net/knarcraft/minstrel/command/MinstrelCommand.java +++ b/src/main/java/net/knarcraft/minstrel/command/MinstrelCommand.java @@ -36,6 +36,8 @@ public class MinstrelCommand implements CommandExecutor { case "volume": return updateVolume(minstrelTrait, args.length > 1 ? args[1] : null, sender); } + //TODO: Add another argument for volume and pitch for whether to immediately change the volume by restarting the playlist + /* Sub-commands: AddSong category identifier duration (remember to run play again) RemoveSong index