From f2328ecfa3391fd94e5be32893026cc00833a15a Mon Sep 17 00:00:00 2001 From: EpicKnarvik97 Date: Sat, 6 Apr 2024 21:45:19 +0200 Subject: [PATCH] Improves some wording --- README.md | 4 ++-- .../minigames/placeholder/RecordExpansion.java | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 2331435..46164f8 100644 --- a/README.md +++ b/README.md @@ -283,7 +283,7 @@ Player records can be displayed on a leaderboard by using PlaceholderAPI. If you leaderboard, you can use the [Placeholder Signs](https://git.knarcraft.net/EpicKnarvik97/PlaceholderSigns) plugin. The format for the built-in placeholders is as follows: -`%gameMode_record_recordType_gameModeType_identifierType_identifier_recordPlacing_infoType%` +`%gameMode_record_recordType_gameModeType_identifierType_identifier_recordPosition_infoType%` | Variable | Values | Description | |----------------|-----------------------------|------------------------------------------------------------------------------------------------------------------------------------| @@ -293,7 +293,7 @@ format for the built-in placeholders is as follows: | gameModeType | default / inverted / random | Selects the game-mode to get the record for. | | identifierType | arena / group | The type of thing the following identifier points to (an arena or an arena group). | | identifier | ? | An identifier (the name or UUID) for an arena or a group (whichever was chosen as identifierType). | -| recordPlacing | 1 / 2 / 3 / ... | The position of the record to get (1 = first place, 2 = second place, etc.). | +| recordPosition | 1 / 2 / 3 / ... | The position of the record to get (1 = first place, 2 = second place, etc.). | | infoType | player / value / combined | The type of info to get. Player gets the player name, Value gets the value of the achieved record. Combined gets "Player: Record". | ## Notes about material tags diff --git a/src/main/java/net/knarcraft/minigames/placeholder/RecordExpansion.java b/src/main/java/net/knarcraft/minigames/placeholder/RecordExpansion.java index 1f9a3ac..c14965d 100644 --- a/src/main/java/net/knarcraft/minigames/placeholder/RecordExpansion.java +++ b/src/main/java/net/knarcraft/minigames/placeholder/RecordExpansion.java @@ -120,7 +120,7 @@ public abstract class RecordExpansion extends PlaceholderExpansion { * @param identifier

The identifier (name/uuid) selecting the group

* @param gameMode

The game-mode to get a record for

* @param recordType

The type of record to get

- * @param recordNumber

The placing of the record to get (1st place, 2nd place, etc.)

+ * @param recordNumber

The position of the record to get (1st place, 2nd place, etc.)

* @param infoType

The type of info (player, value, combined) to get

* @return

The selected information about the record, or null if not found

*/ @@ -158,7 +158,7 @@ public abstract class RecordExpansion extends PlaceholderExpansion { * * @param group

The group to get the record from

* @param gameMode

The game-mode to get the record from

- * @param recordNumber

The placing of the record to get (1st place, 2nd place, etc.)

+ * @param recordNumber

The position of the record to get (1st place, 2nd place, etc.)

* @param arenaHandler

The handler to get arenas from

* @return

The record, or null if not found

*/ @@ -174,7 +174,7 @@ public abstract class RecordExpansion extends PlaceholderExpansion { * * @param group

The group to get the record from

* @param gameMode

The game-mode to get the record from

- * @param recordNumber

The placing of the record to get (1st place, 2nd place, etc.)

+ * @param recordNumber

The position of the record to get (1st place, 2nd place, etc.)

* @param arenaHandler

The handler to get arenas from

* @return

The record, or null if not found

*/ @@ -191,7 +191,7 @@ public abstract class RecordExpansion extends PlaceholderExpansion { * @param group

The group to get the record for

* @param gameMode

The game-mode to get the record for

* @param recordType

The type of record to get

- * @param recordNumber

The placing of the record to get (1st place, 2nd place, etc.)

+ * @param recordNumber

The position of the record to get (1st place, 2nd place, etc.)

* @param caches

The caches to use for looking for and saving the record

* @param recordProvider

The provider of records if the cache cannot provide the record

* @param

The type of the provided records

@@ -240,7 +240,7 @@ public abstract class RecordExpansion extends PlaceholderExpansion { * @param identifier

The identifier (name/uuid) selecting the arena

* @param gameMode

The game-mode to get a record for

* @param recordType

The type of record to get

- * @param recordNumber

The placing of the record to get (1st place, 2nd place, etc.)

+ * @param recordNumber

The position of the record to get (1st place, 2nd place, etc.)

* @param infoType

The type of info (player, value, combined) to get

* @return

The selected information about the record, or null if not found

*/ @@ -275,7 +275,7 @@ public abstract class RecordExpansion extends PlaceholderExpansion { * * @param recordsRegistry

The records registry to get the record from

* @param recordType

The type of record to get

- * @param recordNumber

The placing of the record to get (1st place, 2nd place, etc.)

+ * @param recordNumber

The position of the record to get (1st place, 2nd place, etc.)

* @return

The record, or null if not found

*/ private @Nullable ArenaRecord getRecord(@NotNull ArenaRecordsRegistry recordsRegistry,