KnarCraft/FFmpegConvert
KnarCraft/FFmpegConvert
1
0
Fork 0
Code Issues 4 Pull Requests Releases Wiki Activity

Fixes a bug in the getMatching method causing the input list to lose all matching elements
All checks were successful
KnarCraft/FFmpegConvert/pipeline/head This commit looks good
Details

Browse Source
This commit is contained in:
Kristian Knarvik 2020-05-09 01:50:42 +02:00
parent f4afb63f32
commit 7f479fd760
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/net/knarcraft/ffmpegconverter/converter/AudioConverter.java
View File

@ -13,19 +13,19 @@ import java.util.List;
* A converter for converting audio files * A converter for converting audio files
*/ */
public class AudioConverter extends AbstractConverter { public class AudioConverter extends AbstractConverter {
private final String newExt; private final String newExtension;
/** /**
* Instantiates a new audio converter * Instantiates a new audio converter
* *
* @param ffprobePath <p>Path/command to ffprobe.</p> * @param ffprobePath <p>Path/command to ffprobe.</p>
* @param ffmpegPath <p>Path/command to ffmpeg.</p> * @param ffmpegPath <p>Path/command to ffmpeg.</p>
* @param newExt <p>The extension of the new file.</p> * @param newExtension <p>The extension of the new file.</p>
*/ */
public AudioConverter(String ffprobePath, String ffmpegPath, String newExt) { public AudioConverter(String ffprobePath, String ffmpegPath, String newExtension) {
this.ffprobePath = ffprobePath; this.ffprobePath = ffprobePath;
this.ffmpegPath = ffmpegPath; this.ffmpegPath = ffmpegPath;
this.newExt = newExt; this.newExtension = newExtension;
} }
/** /**
@ -76,6 +76,6 @@ public class AudioConverter extends AbstractConverter {
@Override @Override
public void convert(File file) throws IOException { public void convert(File file) throws IOException {
processFile(file.getParentFile(), file, newExt); processFile(file.getParentFile(), file, newExtension);
} }
} }

1
src/main/java/net/knarcraft/ffmpegconverter/utility/ListUtil.java
View File

@ -40,6 +40,7 @@ public final class ListUtil {
* @return <p>A new list containing all matching elements.</p> * @return <p>A new list containing all matching elements.</p>
*/ */
static <T> List<T> getMatching(List<T> list, Predicate<T> predicate) { static <T> List<T> getMatching(List<T> list, Predicate<T> predicate) {
list = new ArrayList<>(list);
List<T> copy = new ArrayList<>(list); List<T> copy = new ArrayList<>(list);
list.removeIf(predicate); list.removeIf(predicate);
copy.removeAll(list); copy.removeAll(list);