diff --git a/Changelog.txt b/Changelog.txt index 179413b77..200713edd 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -9,6 +9,7 @@ Key: Version 1.4.08-dev + Added the possibility to gain experience when using Fishing "Shake" + = Fixed bug with toggle commands not properly displaying the success message. = Fixed IllegalArgumentException caused by an empty Fishing treasure category Version 1.4.07 diff --git a/src/main/java/com/gmail/nossr50/commands/McabilityCommand.java b/src/main/java/com/gmail/nossr50/commands/McabilityCommand.java index 57f7e47fe..db49a6193 100644 --- a/src/main/java/com/gmail/nossr50/commands/McabilityCommand.java +++ b/src/main/java/com/gmail/nossr50/commands/McabilityCommand.java @@ -2,6 +2,7 @@ package com.gmail.nossr50.commands; import org.bukkit.command.CommandSender; +import com.gmail.nossr50.datatypes.player.McMMOPlayer; import com.gmail.nossr50.locale.LocaleLoader; import com.gmail.nossr50.util.Permissions; @@ -17,13 +18,13 @@ public class McabilityCommand extends ToggleCommand { } @Override - protected void applyCommandAction() { - player.sendMessage(LocaleLoader.getString("Commands.Ability." + (mcMMOPlayer.getAbilityUse() ? "Off" : "On"))); + protected void applyCommandAction(McMMOPlayer mcMMOPlayer) { + mcMMOPlayer.getPlayer().sendMessage(LocaleLoader.getString("Commands.Ability." + (mcMMOPlayer.getAbilityUse() ? "Off" : "On"))); mcMMOPlayer.toggleAbilityUse(); } @Override - protected void sendSuccessMessage(CommandSender sender) { - sender.sendMessage(LocaleLoader.getString("Commands.Ability.Toggle")); + protected void sendSuccessMessage(CommandSender sender, String playerName) { + sender.sendMessage(LocaleLoader.getString("Commands.Ability.Toggle", playerName)); } } diff --git a/src/main/java/com/gmail/nossr50/commands/McgodCommand.java b/src/main/java/com/gmail/nossr50/commands/McgodCommand.java index 0a6710e23..64749b8f4 100644 --- a/src/main/java/com/gmail/nossr50/commands/McgodCommand.java +++ b/src/main/java/com/gmail/nossr50/commands/McgodCommand.java @@ -2,6 +2,7 @@ package com.gmail.nossr50.commands; import org.bukkit.command.CommandSender; +import com.gmail.nossr50.datatypes.player.McMMOPlayer; import com.gmail.nossr50.locale.LocaleLoader; import com.gmail.nossr50.util.Permissions; @@ -17,13 +18,13 @@ public class McgodCommand extends ToggleCommand { } @Override - protected void applyCommandAction() { - player.sendMessage(LocaleLoader.getString("Commands.GodMode." + (mcMMOPlayer.getGodMode() ? "Disabled" : "Enabled"))); + protected void applyCommandAction(McMMOPlayer mcMMOPlayer) { + mcMMOPlayer.getPlayer().sendMessage(LocaleLoader.getString("Commands.GodMode." + (mcMMOPlayer.getGodMode() ? "Disabled" : "Enabled"))); mcMMOPlayer.toggleGodMode(); } @Override - protected void sendSuccessMessage(CommandSender sender) { - sender.sendMessage(LocaleLoader.getString("Commands.GodMode.Success")); + protected void sendSuccessMessage(CommandSender sender, String playerName) { + sender.sendMessage(LocaleLoader.getString("Commands.GodMode.Toggle", playerName)); } } diff --git a/src/main/java/com/gmail/nossr50/commands/McrefreshCommand.java b/src/main/java/com/gmail/nossr50/commands/McrefreshCommand.java index 64bbe4670..bdd1c50b8 100644 --- a/src/main/java/com/gmail/nossr50/commands/McrefreshCommand.java +++ b/src/main/java/com/gmail/nossr50/commands/McrefreshCommand.java @@ -2,6 +2,7 @@ package com.gmail.nossr50.commands; import org.bukkit.command.CommandSender; +import com.gmail.nossr50.datatypes.player.McMMOPlayer; import com.gmail.nossr50.locale.LocaleLoader; import com.gmail.nossr50.util.Permissions; @@ -17,17 +18,17 @@ public class McrefreshCommand extends ToggleCommand { } @Override - protected void applyCommandAction() { + protected void applyCommandAction(McMMOPlayer mcMMOPlayer) { mcMMOPlayer.setRecentlyHurt(0); mcMMOPlayer.resetCooldowns(); mcMMOPlayer.resetToolPrepMode(); mcMMOPlayer.resetAbilityMode(); - player.sendMessage(LocaleLoader.getString("Ability.Generic.Refresh")); + mcMMOPlayer.getPlayer().sendMessage(LocaleLoader.getString("Ability.Generic.Refresh")); } @Override - protected void sendSuccessMessage(CommandSender sender) { - sender.sendMessage(LocaleLoader.getString("Commands.mcrefresh.Success", player.getName())); + protected void sendSuccessMessage(CommandSender sender, String playerName) { + sender.sendMessage(LocaleLoader.getString("Commands.mcrefresh.Success", playerName)); } } diff --git a/src/main/java/com/gmail/nossr50/commands/ToggleCommand.java b/src/main/java/com/gmail/nossr50/commands/ToggleCommand.java index d2281eb6b..dbd80842d 100644 --- a/src/main/java/com/gmail/nossr50/commands/ToggleCommand.java +++ b/src/main/java/com/gmail/nossr50/commands/ToggleCommand.java @@ -7,7 +7,6 @@ import java.util.Set; import org.bukkit.command.Command; import org.bukkit.command.CommandSender; import org.bukkit.command.TabExecutor; -import org.bukkit.entity.Player; import org.bukkit.util.StringUtil; import com.gmail.nossr50.datatypes.player.McMMOPlayer; @@ -18,9 +17,6 @@ import com.gmail.nossr50.util.player.UserManager; import com.google.common.collect.ImmutableList; public abstract class ToggleCommand implements TabExecutor { - protected McMMOPlayer mcMMOPlayer; - protected Player player; - @Override public boolean onCommand(CommandSender sender, Command command, String label, String[] args) { switch (args.length) { @@ -34,10 +30,7 @@ public abstract class ToggleCommand implements TabExecutor { return true; } - player = (Player) sender; - mcMMOPlayer = UserManager.getPlayer(player); - - applyCommandAction(); + applyCommandAction(UserManager.getPlayer(sender.getName())); return true; case 1: @@ -47,20 +40,18 @@ public abstract class ToggleCommand implements TabExecutor { } String playerName = Misc.getMatchedPlayerName(args[0]); - mcMMOPlayer = UserManager.getPlayer(playerName); + McMMOPlayer mcMMOPlayer = UserManager.getPlayer(playerName); if (!CommandUtils.checkPlayerExistence(sender, playerName, mcMMOPlayer)) { return true; } - player = mcMMOPlayer.getPlayer(); - - if (CommandUtils.isOffline(sender, player)) { + if (CommandUtils.isOffline(sender, mcMMOPlayer.getPlayer())) { return true; } - applyCommandAction(); - sendSuccessMessage(sender); + applyCommandAction(mcMMOPlayer); + sendSuccessMessage(sender, playerName); return true; default: @@ -81,6 +72,6 @@ public abstract class ToggleCommand implements TabExecutor { protected abstract boolean hasOtherPermission(CommandSender sender); protected abstract boolean hasSelfPermission(CommandSender sender); - protected abstract void applyCommandAction(); - protected abstract void sendSuccessMessage(CommandSender sender); + protected abstract void applyCommandAction(McMMOPlayer mcMMOPlayer); + protected abstract void sendSuccessMessage(CommandSender sender, String playerName); }