EpicKnarvik97/mcMMO
EpicKnarvik97/mcMMO
1
0
Fork 0
mirror of https://github.com/mcMMO-Dev/mcMMO.git synced 2024-11-22 05:06:45 +01:00
Code Issues Projects Releases Wiki Activity

Fix parties at level cap gaining XP and thus spamming messages

Browse Source 
Fixes #4686
This commit is contained in:
nossr50 2021-12-27 11:22:16 -08:00
parent dd550feb65
commit ef714f98c9
4 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Changelog.txt
View File

@ -1,4 +1,6 @@
Version 2.1.207 Version 2.1.207
Fixed an IndexOutOfBounds exception with our BlockTracker
Fixed a bug where leveling up a party at level cap would spam the chat with messages
Temporarily rolling required Java version back to 16 Temporarily rolling required Java version back to 16
Added unicode (UTF-8) support to locale files (no more UTF-16 codes needed) Added unicode (UTF-8) support to locale files (no more UTF-16 codes needed)
Added locale key 'Scoreboard.Disabled' to en_US Added locale key 'Scoreboard.Disabled' to en_US

4
src/main/java/com/gmail/nossr50/datatypes/party/Party.java
View File

@ -252,10 +252,10 @@ public class Party {
SoundManager.sendSound(leader, leader.getLocation(), SoundType.LEVEL_UP); SoundManager.sendSound(leader, leader.getLocation(), SoundType.LEVEL_UP);
} }
} }
return; } else {
PartyManager.informPartyMembersLevelUp(this, levelsGained, getLevel());
} }
PartyManager.informPartyMembersLevelUp(this, levelsGained, getLevel());
} }
public boolean hasReachedLevelCap() { public boolean hasReachedLevelCap() {

2
src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java
View File

@ -642,7 +642,7 @@ public class McMMOPlayer implements Identified {
applyXpGain(skill, modifyXpGain(skill, xp), xpGainReason, xpGainSource); applyXpGain(skill, modifyXpGain(skill, xp), xpGainReason, xpGainSource);
if (party == null) { if (party == null || party.hasReachedLevelCap()) {
return; return;
} }

1
src/main/java/com/gmail/nossr50/util/EventUtils.java
View File

@ -370,7 +370,6 @@ public final class EventUtils {
boolean isCancelled = event.isCancelled(); boolean isCancelled = event.isCancelled();
if (isCancelled) { if (isCancelled) {
party.setLevel(party.getLevel() + levelsChanged); party.setLevel(party.getLevel() + levelsChanged);
party.addXp(xpRemoved); party.addXp(xpRemoved);
} }