EpicKnarvik97/mcMMO
EpicKnarvik97/mcMMO
1
0
Fork 0
mirror of https://github.com/mcMMO-Dev/mcMMO.git synced 2024-10-16 09:03:38 +02:00
Code Issues Projects Releases Wiki Activity

2.1.146

Browse Source
This commit is contained in:
nossr50 2020-09-25 11:01:47 -07:00
parent 6f99940540
commit adbcf11c15
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
Changelog.txt
View File

@ -1,9 +1,38 @@
Version 2.1.146
JSON Text components are now done through 'adventure' library by Kyori, this should help reduce player disconnects from messages due to an unfixed Spigot bug.
A bug where players would disconnect from mcMMO messages has been fixed (thanks kashike / read notes)
It should be noted this was NOT an mcMMO bug, but a bug within Spigot since Spigot 1.16
A dupe exploit has been fixed
Improvements were made to tracking player placed blocks in mcMMO
Players no longer lose levels below the level threshold in hardcore mode
Hardcore now only applies penalties to levels above threshold
NOTES:
Shout out to Kashike
If you guys are looking to hire someone of exceptional quality for a Java project, Kashike is a skilled developer who I respect and he makes a living off free lance right now. Try contacting him if you do!
Kashike is a developer on the mcMMO team, however after I recruited him had a lot of life stuff come at him and hasn't had a chance to contribute until now!
JSON is used by Minecraft for a lot of stuff, in this case the JSON mcMMO made use of was related to displaying text in chat or displaying text on the clients screen in other places such as the action bar, there's been a bad bug in Spigot since 1.16 that would disconnect players some of the time when sending JSON components.
mcMMO makes heavy use of these components, so since spigot has yet to fix the bug I decided we needed a work around for the time being.
The library named 'adventure' is developed by the Kyori organization, which is Kashike's baby.
Kashike is a very talented and skilled developer and he did the work on this patch to solve this issue.
This is a link to an bug report I did on this bug on Spigot's issue tracker, it is my understanding they have yet to find a way to reliably reproduce this bug.
If you have any information please post about it in this thread.
https://hub.spigotmc.org/jira/browse/SPIGOT-6056
Although mcMMO solved this issue by switching to Kyori's Adventure library for sending JSON Components, most Spigot plugins have not implemented a work around like this and will continue to make players disconnect until it is solved within Spigot.
Hardcore changes
If you set a level threshold of 100 and player with 150 levels dies, they should never lose more than 50 levels as the first 100 are considered part of the threshold.
Prior to this change in this exact same scenario a player could be penalized and be put below the threshold.
Shout out to HexedHero for reporting the dupe exploit and providing a demonstration of how to replicate it
Tridents & Crossbows update
It is still being worked on but it won't make a September release.
October is the new target release but I am terrible with estimates so take it with a grain of salt!
Version 2.1.145
Reverted 'Changed one of the PlayerInteractEvent listeners to ignore cancelled events' from 2.1.144

2
pom.xml
View File

@ -2,7 +2,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.gmail.nossr50.mcMMO</groupId>
<artifactId>mcMMO</artifactId>
<version>2.1.146-SNAPSHOT</version>
<version>2.1.146</version>
<name>mcMMO</name>
<url>https://github.com/mcMMO-Dev/mcMMO</url>
<scm>