Made xp sharing less ugly by reworking McMMOPlayer xp methods

Notable consequence: checkXP and addLevel in ExperienceAPI are no longer
needed and became deprecated

src/main/java/com/gmail/nossr50/skills/acrobatics/DodgeEventHandler.java

@@ -46,7 +46,7 @@ public class DodgeEventHandler extends AcrobaticsEventHandler {
         McMMOPlayer mcMMOPlayer = manager.getMcMMOPlayer();
 
         if (System.currentTimeMillis() >= mcMMOPlayer.getProfile().getRespawnATS() + Misc.PLAYER_RESPAWN_COOLDOWN_SECONDS) {
-            manager.getMcMMOPlayer().addXp(SkillType.ACROBATICS, xp);
+            manager.getMcMMOPlayer().beginXpGain(SkillType.ACROBATICS, xp);
         }
     }
 }

src/main/java/com/gmail/nossr50/skills/acrobatics/RollEventHandler.java

@@ -69,7 +69,7 @@ public class RollEventHandler extends AcrobaticsEventHandler {
 
     @Override
     protected void processXpGain(int xp) {
-        manager.getMcMMOPlayer().addXp(SkillType.ACROBATICS, xp);
+        manager.getMcMMOPlayer().beginXpGain(SkillType.ACROBATICS, xp);
     }
 
     /**

src/main/java/com/gmail/nossr50/skills/archery/ArcheryManager.java

@@ -34,7 +34,7 @@ public class ArcheryManager extends SkillManager {
         }
 
         int bonusXp = (int) (squaredDistance * Archery.distanceXpModifer);
-        mcMMOPlayer.addXp(SkillType.ARCHERY, bonusXp);
+        mcMMOPlayer.beginXpGain(SkillType.ARCHERY, bonusXp);
     }
 
     /**

src/main/java/com/gmail/nossr50/skills/excavation/Excavation.java

@@ -119,7 +119,7 @@ public class Excavation {
             }
         }
 
-        mcMMOPlayer.addXp(SkillType.EXCAVATION, xp);
+        mcMMOPlayer.beginXpGain(SkillType.EXCAVATION, xp);
     }
 
     /**

src/main/java/com/gmail/nossr50/skills/fishing/Fishing.java

@@ -128,7 +128,7 @@ public final class Fishing {
             caught.setItemStack(treasureDrop);
         }
 
-        mcMMOPlayer.addXp(SkillType.FISHING, Config.getInstance().getFishingBaseXP() + treasureXp);
+        mcMMOPlayer.beginXpGain(SkillType.FISHING, Config.getInstance().getFishingBaseXP() + treasureXp);
         event.setExpToDrop(event.getExpToDrop() * getVanillaXpMultiplier(skillLevel));
     }
 

src/main/java/com/gmail/nossr50/skills/herbalism/Herbalism.java

@@ -212,7 +212,7 @@ public class Herbalism {
             }
         }
 
-        mcMMOPlayer.addXp(SkillType.HERBALISM, xp);
+        mcMMOPlayer.beginXpGain(SkillType.HERBALISM, xp);
     }
 
     /**

src/main/java/com/gmail/nossr50/skills/mining/Mining.java

@@ -104,7 +104,7 @@ public class Mining {
             break;
         }
 
-        mcMMOPlayer.addXp(SkillType.MINING, xp);
+        mcMMOPlayer.beginXpGain(SkillType.MINING, xp);
     }
 
     /**

src/main/java/com/gmail/nossr50/skills/repair/Repair.java

@@ -48,7 +48,7 @@ public class Repair {
         Player player = mcMMOPlayer.getPlayer();
 
         player.playSound(player.getLocation(), Sound.ANVIL_USE, Misc.ANVIL_USE_VOLUME, Misc.ANVIL_USE_PITCH);
-        mcMMOPlayer.addXp(SkillType.REPAIR, dif * 10);
+        mcMMOPlayer.beginXpGain(SkillType.REPAIR, dif * 10);
     }
 
     /**

src/main/java/com/gmail/nossr50/skills/runnables/CombatXpGiver.java

@@ -35,6 +35,6 @@ public class CombatXpGiver implements Runnable {
             damage += health;
         }
 
-        mcMMOPlayer.addXp(skillType, (int) (damage * baseXp));
+        mcMMOPlayer.beginXpGain(skillType, (int) (damage * baseXp));
     }
 }

src/main/java/com/gmail/nossr50/skills/smelting/SmeltResourceEventHandler.java

@@ -68,11 +68,11 @@ public class SmeltResourceEventHandler {
         Player player = mcMMOPlayer.getPlayer();
 
         if (Permissions.mining(player)) {
-            mcMMOPlayer.addXp(SkillType.MINING, xp / 2);
+            mcMMOPlayer.beginXpGain(SkillType.MINING, xp / 2);
         }
 
         if (Permissions.repair(player)) {
-            mcMMOPlayer.addXp(SkillType.REPAIR, xp / 2);
+            mcMMOPlayer.beginXpGain(SkillType.REPAIR, xp / 2);
         }
     }
 

src/main/java/com/gmail/nossr50/skills/taming/TamingManager.java

@@ -33,11 +33,11 @@ public class TamingManager extends SkillManager {
 
         switch (event.getEntityType()) {
         case WOLF:
-            mcMMOPlayer.addXp(SkillType.TAMING, Taming.wolfXp);
+            mcMMOPlayer.beginXpGain(SkillType.TAMING, Taming.wolfXp);
             break;
 
         case OCELOT:
-            mcMMOPlayer.addXp(SkillType.TAMING, Taming.ocelotXp);
+            mcMMOPlayer.beginXpGain(SkillType.TAMING, Taming.ocelotXp);
             break;
 
         default:

src/main/java/com/gmail/nossr50/skills/woodcutting/TreeFeller.java

@@ -220,6 +220,6 @@ public final class TreeFeller {
             block.setType(Material.AIR);
         }
 
-        mcMMOPlayer.addXp(SkillType.WOODCUTTING, xp);
+        mcMMOPlayer.beginXpGain(SkillType.WOODCUTTING, xp);
     }
 }

src/main/java/com/gmail/nossr50/skills/woodcutting/Woodcutting.java

@@ -80,7 +80,7 @@ public final class Woodcutting {
             checkForDoubleDrop(mcMMOPlayer, block);
         }
 
-        mcMMOPlayer.addXp(SkillType.WOODCUTTING, xp);
+        mcMMOPlayer.beginXpGain(SkillType.WOODCUTTING, xp);
     }
 
     /**