EpicKnarvik97/mcMMO
EpicKnarvik97/mcMMO
1
0
Fork 0
mirror of https://github.com/mcMMO-Dev/mcMMO.git synced 2024-11-26 23:26:45 +01:00
Code Issues Projects Releases Wiki Activity

Fixed some issues with static access

Browse Source
This commit is contained in:
Grant 2012-12-24 16:17:19 -05:00
parent f7ea25be61
commit 6b3bde585d
11 changed files with 43 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.txt
View File

@ -11,6 +11,7 @@ Version 1.3.13
+ Added Craftbukkit 1.4.6 compatibility + Added Craftbukkit 1.4.6 compatibility
= Fixed issue with missing default cases from several switch/case statements = Fixed issue with missing default cases from several switch/case statements
= Fixed issue with Mining using actual skill level rather than max skill level = Fixed issue with Mining using actual skill level rather than max skill level
= Fixed some issues with static access
! GJ stopped being a lazy slacker and got stuff done ! GJ stopped being a lazy slacker and got stuff done
- Removed dead code relating to null profiles - Removed dead code relating to null profiles
- Removed unused imports - Removed unused imports

24
src/main/java/com/gmail/nossr50/listeners/BlockListener.java
View File

@ -62,17 +62,17 @@ public class BlockListener implements Listener {
Block futureEmptyBlock = event.getBlock().getRelative(direction); Block futureEmptyBlock = event.getBlock().getRelative(direction);
for (Block b : blocks) { for (Block b : blocks) {
if (mcMMO.p.placeStore.isTrue(b)) { if (mcMMO.placeStore.isTrue(b)) {
b.getRelative(direction).setMetadata("pistonTrack", new FixedMetadataValue(plugin, true)); b.getRelative(direction).setMetadata("pistonTrack", new FixedMetadataValue(plugin, true));
if (b.equals(futureEmptyBlock)) { if (b.equals(futureEmptyBlock)) {
mcMMO.p.placeStore.setFalse(b); mcMMO.placeStore.setFalse(b);
} }
} }
} }
for (Block b : blocks) { for (Block b : blocks) {
if (b.getRelative(direction).hasMetadata("pistonTrack")) { if (b.getRelative(direction).hasMetadata("pistonTrack")) {
mcMMO.p.placeStore.setTrue(b.getRelative(direction)); mcMMO.placeStore.setTrue(b.getRelative(direction));
b.getRelative(direction).removeMetadata("pistonTrack", plugin); b.getRelative(direction).removeMetadata("pistonTrack", plugin);
} }
} }
@ -95,7 +95,7 @@ public class BlockListener implements Listener {
Block fallenBlock = event.getBlock().getRelative(BlockFace.UP); Block fallenBlock = event.getBlock().getRelative(BlockFace.UP);
if (fallenBlock.getType() == type) { if (fallenBlock.getType() == type) {
mcMMO.p.placeStore.setTrue(fallenBlock); mcMMO.placeStore.setTrue(fallenBlock);
} }
} }
} }
@ -138,7 +138,7 @@ public class BlockListener implements Listener {
} }
else { else {
Block newLocation = block.getRelative(0, y + 1, 0); Block newLocation = block.getRelative(0, y + 1, 0);
mcMMO.p.placeStore.setTrue(newLocation); mcMMO.placeStore.setTrue(newLocation);
break; break;
} }
} }
@ -147,7 +147,7 @@ public class BlockListener implements Listener {
/* Check if the blocks placed should be monitored so they do not give out XP in the future */ /* Check if the blocks placed should be monitored so they do not give out XP in the future */
if (BlockChecks.shouldBeWatched(block)) { if (BlockChecks.shouldBeWatched(block)) {
if (!((type == Material.SAND || type == Material.GRAVEL) && block.getRelative(BlockFace.DOWN).getType() == Material.AIR)) { //Don't wanna track sand that's gonna fall. if (!((type == Material.SAND || type == Material.GRAVEL) && block.getRelative(BlockFace.DOWN).getType() == Material.AIR)) { //Don't wanna track sand that's gonna fall.
mcMMO.p.placeStore.setTrue(block); mcMMO.placeStore.setTrue(block);
} }
} }
@ -232,7 +232,7 @@ public class BlockListener implements Listener {
} }
/* EXCAVATION */ /* EXCAVATION */
else if (BlockChecks.canBeGigaDrillBroken(block) && permInstance.excavation(player) && !mcMMO.p.placeStore.isTrue(block)) { else if (BlockChecks.canBeGigaDrillBroken(block) && permInstance.excavation(player) && !mcMMO.placeStore.isTrue(block)) {
if (configInstance.getExcavationRequiresTool()) { if (configInstance.getExcavationRequiresTool()) {
if (ItemChecks.isShovel(inHand)) { if (ItemChecks.isShovel(inHand)) {
Excavation.excavationProcCheck(block, player); Excavation.excavationProcCheck(block, player);
@ -245,7 +245,7 @@ public class BlockListener implements Listener {
//Remove metadata when broken //Remove metadata when broken
if (BlockChecks.shouldBeWatched(block)) { if (BlockChecks.shouldBeWatched(block)) {
mcMMO.p.placeStore.setFalse(block); mcMMO.placeStore.setFalse(block);
} }
//Remove metadata from fallen sand/gravel //Remove metadata from fallen sand/gravel
@ -256,11 +256,11 @@ public class BlockListener implements Listener {
Block relative = block.getRelative(0, y, 0); Block relative = block.getRelative(0, y, 0);
Material relativeType = relative.getType(); Material relativeType = relative.getType();
if ((relativeType == Material.SAND || relativeType == Material.GRAVEL) && mcMMO.p.placeStore.isTrue(relative)) { if ((relativeType == Material.SAND || relativeType == Material.GRAVEL) && mcMMO.placeStore.isTrue(relative)) {
mcMMO.p.placeStore.setFalse(relative); mcMMO.placeStore.setFalse(relative);
} }
else if (!BlockChecks.shouldBeWatched(relative) && mcMMO.p.placeStore.isTrue(relative)){ else if (!BlockChecks.shouldBeWatched(relative) && mcMMO.placeStore.isTrue(relative)){
mcMMO.p.placeStore.setFalse(relative); mcMMO.placeStore.setFalse(relative);
} }
else { else {
break; break;

6
src/main/java/com/gmail/nossr50/listeners/WorldListener.java
View File

@ -34,16 +34,16 @@ public class WorldListener implements Listener {
@EventHandler @EventHandler
public void onWorldUnload(WorldUnloadEvent event) { public void onWorldUnload(WorldUnloadEvent event) {
mcMMO.p.placeStore.unloadWorld(event.getWorld()); mcMMO.placeStore.unloadWorld(event.getWorld());
} }
@EventHandler @EventHandler
public void onWorldSave(WorldSaveEvent event) { public void onWorldSave(WorldSaveEvent event) {
mcMMO.p.placeStore.saveWorld(event.getWorld()); mcMMO.placeStore.saveWorld(event.getWorld());
} }
@EventHandler @EventHandler
public void onChunkUnload(ChunkUnloadEvent event) { public void onChunkUnload(ChunkUnloadEvent event) {
mcMMO.p.placeStore.chunkUnloaded(event.getChunk().getX(), event.getChunk().getZ(), event.getWorld()); mcMMO.placeStore.chunkUnloaded(event.getChunk().getX(), event.getChunk().getZ(), event.getWorld());
} }
} }

4
src/main/java/com/gmail/nossr50/runnables/ChunkletUnloader.java
View File

@ -42,10 +42,10 @@ public class ChunkletUnloader implements Runnable {
//Chunklets are unloaded only if their chunk has been unloaded for minimumInactiveTime //Chunklets are unloaded only if their chunk has been unloaded for minimumInactiveTime
if (inactiveTime >= minimumInactiveTime) { if (inactiveTime >= minimumInactiveTime) {
if(mcMMO.p.placeStore == null) if(mcMMO.placeStore == null)
continue; continue;
mcMMO.p.placeStore.unloadChunk(chunk.getX(), chunk.getZ(), chunk.getWorld()); mcMMO.placeStore.unloadChunk(chunk.getX(), chunk.getZ(), chunk.getWorld());
it.remove(); it.remove();
continue; continue;
} }

6
src/main/java/com/gmail/nossr50/runnables/StickyPistonTracker.java
View File

@ -17,11 +17,11 @@ public class StickyPistonTracker implements Runnable {
public void run() { public void run() {
Block originalBlock = event.getRetractLocation().getBlock(); Block originalBlock = event.getRetractLocation().getBlock();
if (originalBlock.getType() == Material.AIR && mcMMO.p.placeStore.isTrue(originalBlock)) { if (originalBlock.getType() == Material.AIR && mcMMO.placeStore.isTrue(originalBlock)) {
Block newBlock = originalBlock.getRelative(event.getDirection().getOppositeFace()); Block newBlock = originalBlock.getRelative(event.getDirection().getOppositeFace());
mcMMO.p.placeStore.setFalse(originalBlock); mcMMO.placeStore.setFalse(originalBlock);
mcMMO.p.placeStore.setTrue(newBlock); mcMMO.placeStore.setTrue(newBlock);
} }
} }
} }

2
src/main/java/com/gmail/nossr50/runnables/blockstoreconversion/BlockStoreConversionZDirectory.java
View File

@ -36,7 +36,7 @@ public class BlockStoreConversionZDirectory implements Runnable {
this.world = world; this.world = world;
this.scheduler = mcMMO.p.getServer().getScheduler(); this.scheduler = mcMMO.p.getServer().getScheduler();
this.manager = new HashChunkletManager(); this.manager = new HashChunkletManager();
this.newManager = (HashChunkManager) mcMMO.p.placeStore; this.newManager = (HashChunkManager) mcMMO.placeStore;
this.dataDir = dataDir; this.dataDir = dataDir;
this.xDir = xDir; this.xDir = xDir;

4
src/main/java/com/gmail/nossr50/skills/gathering/BlastMining.java
View File

@ -62,7 +62,7 @@ public class BlastMining {
blocksDropped.add(temp); blocksDropped.add(temp);
Mining.miningDrops(temp); Mining.miningDrops(temp);
if (!mcMMO.p.placeStore.isTrue(temp)) { if (!mcMMO.placeStore.isTrue(temp)) {
for (int i = 1 ; i < extraDrops ; i++) { for (int i = 1 ; i < extraDrops ; i++) {
blocksDropped.add(temp); blocksDropped.add(temp);
Mining.miningDrops(temp); Mining.miningDrops(temp);
@ -172,7 +172,7 @@ public class BlastMining {
} }
for (Block block : xp) { for (Block block : xp) {
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
Mining.miningXP(player, block); Mining.miningXP(player, block);
} }
} }

2
src/main/java/com/gmail/nossr50/skills/gathering/Excavation.java
View File

@ -130,7 +130,7 @@ public class Excavation {
Skills.abilityDurabilityLoss(player.getItemInHand(), Config.getInstance().getAbilityToolDamage()); Skills.abilityDurabilityLoss(player.getItemInHand(), Config.getInstance().getAbilityToolDamage());
if (!mcMMO.p.placeStore.isTrue(block) && !Misc.blockBreakSimulate(block, player, true)) { if (!mcMMO.placeStore.isTrue(block) && !Misc.blockBreakSimulate(block, player, true)) {
FakePlayerAnimationEvent armswing = new FakePlayerAnimationEvent(player); FakePlayerAnimationEvent armswing = new FakePlayerAnimationEvent(player);
mcMMO.p.getServer().getPluginManager().callEvent(armswing); mcMMO.p.getServer().getPluginManager().callEvent(armswing);

18
src/main/java/com/gmail/nossr50/skills/gathering/Herbalism.java
View File

@ -63,7 +63,7 @@ public class Herbalism {
else if (Config.getInstance().getHerbalismGreenThumbCobbleToMossy() && type == Material.COBBLESTONE) { else if (Config.getInstance().getHerbalismGreenThumbCobbleToMossy() && type == Material.COBBLESTONE) {
block.setType(Material.MOSSY_COBBLESTONE); block.setType(Material.MOSSY_COBBLESTONE);
// Don't award double drops to mossified cobblestone // Don't award double drops to mossified cobblestone
mcMMO.p.placeStore.setTrue(block); mcMMO.placeStore.setTrue(block);
} }
else if (Config.getInstance().getHerbalismGreenThumbCobbleWallToMossyWall() && type == Material.COBBLE_WALL) { else if (Config.getInstance().getHerbalismGreenThumbCobbleWallToMossyWall() && type == Material.COBBLE_WALL) {
block.setData((byte) 1); block.setData((byte) 1);
@ -109,7 +109,7 @@ public class Herbalism {
switch (type) { switch (type) {
case BROWN_MUSHROOM: case BROWN_MUSHROOM:
case RED_MUSHROOM: case RED_MUSHROOM:
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
mat = Material.getMaterial(id); mat = Material.getMaterial(id);
xp = Config.getInstance().getHerbalismXPMushrooms(); xp = Config.getInstance().getHerbalismXPMushrooms();
} }
@ -120,7 +120,7 @@ public class Herbalism {
Block b = block.getRelative(0, y, 0); Block b = block.getRelative(0, y, 0);
if (b.getType().equals(Material.CACTUS)) { if (b.getType().equals(Material.CACTUS)) {
mat = Material.CACTUS; mat = Material.CACTUS;
if (!mcMMO.p.placeStore.isTrue(b)) { if (!mcMMO.placeStore.isTrue(b)) {
if (herbLevel > MAX_BONUS_LEVEL || random.nextInt(randomChance) <= herbLevel) { if (herbLevel > MAX_BONUS_LEVEL || random.nextInt(randomChance) <= herbLevel) {
catciDrops++; catciDrops++;
} }
@ -142,7 +142,7 @@ public class Herbalism {
break; break;
case MELON_BLOCK: case MELON_BLOCK:
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
mat = Material.MELON; mat = Material.MELON;
xp = Config.getInstance().getHerbalismXPMelon(); xp = Config.getInstance().getHerbalismXPMelon();
} }
@ -161,7 +161,7 @@ public class Herbalism {
case PUMPKIN: case PUMPKIN:
case JACK_O_LANTERN: case JACK_O_LANTERN:
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
mat = Material.getMaterial(id); mat = Material.getMaterial(id);
xp = Config.getInstance().getHerbalismXPPumpkin(); xp = Config.getInstance().getHerbalismXPPumpkin();
} }
@ -169,7 +169,7 @@ public class Herbalism {
case RED_ROSE: case RED_ROSE:
case YELLOW_FLOWER: case YELLOW_FLOWER:
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
mat = Material.getMaterial(id); mat = Material.getMaterial(id);
xp = Config.getInstance().getHerbalismXPFlowers(); xp = Config.getInstance().getHerbalismXPFlowers();
} }
@ -180,7 +180,7 @@ public class Herbalism {
Block b = block.getRelative(0, y, 0); Block b = block.getRelative(0, y, 0);
if (b.getType().equals(Material.SUGAR_CANE_BLOCK)) { if (b.getType().equals(Material.SUGAR_CANE_BLOCK)) {
mat = Material.SUGAR_CANE; mat = Material.SUGAR_CANE;
if (!mcMMO.p.placeStore.isTrue(b)) { if (!mcMMO.placeStore.isTrue(b)) {
if (herbLevel > MAX_BONUS_LEVEL || random.nextInt(randomChance) <= herbLevel) { if (herbLevel > MAX_BONUS_LEVEL || random.nextInt(randomChance) <= herbLevel) {
caneDrops++; caneDrops++;
} }
@ -191,14 +191,14 @@ public class Herbalism {
break; break;
case VINE: case VINE:
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
mat = type; mat = type;
xp = Config.getInstance().getHerbalismXPVines(); xp = Config.getInstance().getHerbalismXPVines();
} }
break; break;
case WATER_LILY: case WATER_LILY:
if (!mcMMO.p.placeStore.isTrue(block)) { if (!mcMMO.placeStore.isTrue(block)) {
mat = type; mat = type;
xp = Config.getInstance().getHerbalismXPLilyPads(); xp = Config.getInstance().getHerbalismXPLilyPads();
} }

6
src/main/java/com/gmail/nossr50/skills/gathering/Mining.java
View File

@ -316,7 +316,7 @@ public class Mining {
* @param block The block being broken * @param block The block being broken
*/ */
public static void miningBlockCheck(Player player, Block block) { public static void miningBlockCheck(Player player, Block block) {
if (mcMMO.p.placeStore.isTrue(block)) { if (mcMMO.placeStore.isTrue(block)) {
return; return;
} }
@ -362,7 +362,7 @@ public class Mining {
return; return;
} }
if (mcMMO.p.placeStore.isTrue(block) || Misc.blockBreakSimulate(block, player, true)) { if (mcMMO.placeStore.isTrue(block) || Misc.blockBreakSimulate(block, player, true)) {
return; return;
} }
@ -408,7 +408,7 @@ public class Mining {
case NETHERRACK: case NETHERRACK:
case SANDSTONE: case SANDSTONE:
case STONE: case STONE:
if (mcMMO.p.placeStore.isTrue(block) || Misc.blockBreakSimulate(block, player, true)) { if (mcMMO.placeStore.isTrue(block) || Misc.blockBreakSimulate(block, player, true)) {
return; return;
} }

12
src/main/java/com/gmail/nossr50/skills/gathering/WoodCutting.java
View File

@ -109,7 +109,7 @@ public class WoodCutting {
CustomBlock block = ModChecks.getCustomBlock(x); CustomBlock block = ModChecks.getCustomBlock(x);
item = block.getItemDrop(); item = block.getItemDrop();
if (!mcMMO.p.placeStore.isTrue(x)) { if (!mcMMO.placeStore.isTrue(x)) {
WoodCutting.woodCuttingProcCheck(player, x); WoodCutting.woodCuttingProcCheck(player, x);
xp = block.getXpGain(); xp = block.getXpGain();
} }
@ -169,7 +169,7 @@ public class WoodCutting {
break; break;
} }
if (!mcMMO.p.placeStore.isTrue(x)) { if (!mcMMO.placeStore.isTrue(x)) {
WoodCutting.woodCuttingProcCheck(player, x); WoodCutting.woodCuttingProcCheck(player, x);
switch (species) { switch (species) {
@ -245,7 +245,7 @@ public class WoodCutting {
Block zNegative = currentBlock.getRelative(0, 0, -1); Block zNegative = currentBlock.getRelative(0, 0, -1);
Block yPositive = currentBlock.getRelative(0, 1, 0); Block yPositive = currentBlock.getRelative(0, 1, 0);
if (!mcMMO.p.placeStore.isTrue(currentBlock)) { if (!mcMMO.placeStore.isTrue(currentBlock)) {
if (!isTooAggressive(currentBlock, xPositive) && BlockChecks.treeFellerCompatible(xPositive) && !toBeFelled.contains(xPositive)) { if (!isTooAggressive(currentBlock, xPositive) && BlockChecks.treeFellerCompatible(xPositive) && !toBeFelled.contains(xPositive)) {
processTreeFelling(xPositive, toBeFelled); processTreeFelling(xPositive, toBeFelled);
} }
@ -277,7 +277,7 @@ public class WoodCutting {
Block corner3 = currentBlock.getRelative(-1, 0, 1); Block corner3 = currentBlock.getRelative(-1, 0, 1);
Block corner4 = currentBlock.getRelative(-1, 0, -1); Block corner4 = currentBlock.getRelative(-1, 0, -1);
if (!mcMMO.p.placeStore.isTrue(currentBlock)) { if (!mcMMO.placeStore.isTrue(currentBlock)) {
if (!isTooAggressive(currentBlock, corner1) && BlockChecks.treeFellerCompatible(corner1) && !toBeFelled.contains(corner1)) { if (!isTooAggressive(currentBlock, corner1) && BlockChecks.treeFellerCompatible(corner1) && !toBeFelled.contains(corner1)) {
processTreeFelling(corner1, toBeFelled); processTreeFelling(corner1, toBeFelled);
} }
@ -297,7 +297,7 @@ public class WoodCutting {
} }
if (BlockChecks.treeFellerCompatible(yPositive)) { if (BlockChecks.treeFellerCompatible(yPositive)) {
if(!mcMMO.p.placeStore.isTrue(currentBlock) && !toBeFelled.contains(yPositive)) { if(!mcMMO.placeStore.isTrue(currentBlock) && !toBeFelled.contains(yPositive)) {
processTreeFelling(yPositive, toBeFelled); processTreeFelling(yPositive, toBeFelled);
} }
} }
@ -421,7 +421,7 @@ public class WoodCutting {
PlayerProfile profile = Users.getProfile(player); PlayerProfile profile = Users.getProfile(player);
int xp = 0; int xp = 0;
if (mcMMO.p.placeStore.isTrue(block)) { if (mcMMO.placeStore.isTrue(block)) {
return; return;
} }