Remove inactive entities from the arrow tracker

src/main/java/com/gmail/nossr50/skills/archery/Archery.java

@@ -1,11 +1,11 @@
 package com.gmail.nossr50.skills.archery;
 
-import java.util.HashMap;
+import java.util.ArrayList;
-import java.util.Map;
+import java.util.Iterator;
+import java.util.List;
 import java.util.Random;
 
 import org.bukkit.Material;
-import org.bukkit.entity.Entity;
 import org.bukkit.entity.LivingEntity;
 import org.bukkit.inventory.ItemStack;
 
@@ -13,7 +13,7 @@ import com.gmail.nossr50.util.Misc;
 
 public class Archery {
     private static Random random = new Random();
-    private static Map<LivingEntity, Integer> arrowTracker = new HashMap<LivingEntity, Integer>();
+    private static List<TrackedEntity> trackedEntities = new ArrayList<TrackedEntity>();
 
     public static final int ARROW_TRACKING_MAX_BONUS_LEVEL = 1000;
 
@@ -25,15 +25,33 @@ public class Archery {
     public static final int DAZE_MODIFIER = 4;
 
     protected static boolean arrowTrackerContains(LivingEntity livingEntity) {
-        return arrowTracker.containsKey(livingEntity);
+        for (TrackedEntity trackedEntity : trackedEntities) {
+            if (trackedEntity.getLivingEntity() == livingEntity) {
+                return true;
+            }
+        }
+
+        return false;
     }
 
     protected static void incrementTrackerValue(LivingEntity livingEntity) {
-        arrowTracker.put(livingEntity, arrowTracker.get(livingEntity) + 1);
+        for (TrackedEntity trackedEntity : trackedEntities) {
+            if (trackedEntity.getLivingEntity() == livingEntity) {
+                trackedEntity.incrementArrowCount();
+                return;
+            }
+        }
     }
 
     protected static void addToTracker(LivingEntity livingEntity) {
-        arrowTracker.put(livingEntity, 1);
+        TrackedEntity trackedEntity = new TrackedEntity(livingEntity);
+
+        trackedEntity.incrementArrowCount();
+        trackedEntities.add(trackedEntity);
+    }
+
+    protected static void removeFromTracker(TrackedEntity trackedEntity) {
+        trackedEntities.remove(trackedEntity);
     }
 
     /**
@@ -41,11 +59,15 @@ public class Archery {
      *
      * @param entity The entity hit by the arrows
      */
-    public static void arrowRetrievalCheck(Entity entity) {
+    public static void arrowRetrievalCheck(LivingEntity livingEntity) {
-        Integer quantity = arrowTracker.remove(entity);
+        for (Iterator<TrackedEntity> it = trackedEntities.iterator() ; it.hasNext() ; ) {
+            TrackedEntity trackedEntity = it.next();
 
-        if (quantity != null) {
+            if (trackedEntity.getLivingEntity() == livingEntity) {
-            Misc.dropItems(entity.getLocation(), new ItemStack(Material.ARROW), quantity);
+                Misc.dropItems(livingEntity.getLocation(), new ItemStack(Material.ARROW), trackedEntity.getArrowCount());
+                it.remove();
+                return;
+            }
         }
     }
 

src/main/java/com/gmail/nossr50/skills/archery/TrackedEntity.java

@@ -0,0 +1,60 @@
+package com.gmail.nossr50.skills.archery;
+
+import org.bukkit.Bukkit;
+import org.bukkit.entity.LivingEntity;
+
+import com.gmail.nossr50.mcMMO;
+
+public class TrackedEntity {
+    private LivingEntity livingEntity;
+    private int arrowCount;
+    private int previousTicksLived;
+
+    public TrackedEntity(LivingEntity livingEntity) {
+        this.livingEntity = livingEntity;
+
+        //Check if the entity is still active every 10 minutes
+        Bukkit.getScheduler().scheduleSyncRepeatingTask(mcMMO.p, new CheckTrackedEntityExistence(this), 12000, 12000);
+    }
+
+    //LivingEntity.isDead() isn't a reliable way to know if an entity is still active
+    //This method must not be called more than once per server tick
+    public boolean isActive() {
+        int currentTicksLived = livingEntity.getTicksLived();
+
+        if (currentTicksLived == previousTicksLived) {
+            return false;
+        }
+        else {
+            previousTicksLived = currentTicksLived;
+            return true;
+        }
+    }
+
+    public LivingEntity getLivingEntity() {
+        return livingEntity;
+    }
+
+    public int getArrowCount() {
+        return arrowCount;
+    }
+
+    public void incrementArrowCount() {
+        arrowCount++;
+    }
+
+    private class CheckTrackedEntityExistence implements Runnable {
+        private TrackedEntity trackedEntity;
+
+        public CheckTrackedEntityExistence(TrackedEntity trackedEntity) {
+            this.trackedEntity = trackedEntity;
+        }
+
+        @Override
+        public void run() {
+            if (!trackedEntity.isActive()) {
+                Archery.removeFromTracker(trackedEntity);
+            }
+        }
+    }
+}