From 605535ed60e1a5c750aaa3e83ab87e203378a7ec Mon Sep 17 00:00:00 2001 From: Josh Date: Thu, 6 Dec 2018 22:05:55 -0500 Subject: [PATCH] fix memory leak (#3631) on servers with lots of spawner farms this metadata won't get GC'd unless removed, line 436 its added but never removed as far as I can tell --- src/main/java/com/gmail/nossr50/listeners/EntityListener.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/main/java/com/gmail/nossr50/listeners/EntityListener.java b/src/main/java/com/gmail/nossr50/listeners/EntityListener.java index fb29207fc..09e41bc88 100644 --- a/src/main/java/com/gmail/nossr50/listeners/EntityListener.java +++ b/src/main/java/com/gmail/nossr50/listeners/EntityListener.java @@ -395,6 +395,10 @@ public class EntityListener implements Listener { entity.setCustomNameVisible(entity.getMetadata(mcMMO.customVisibleKey).get(0).asBoolean()); entity.removeMetadata(mcMMO.customVisibleKey, plugin); } + + if (entity.hasMetadata(mcMMO.entityMetadataKey)) { + entity.removeMetadata(mcMMO.entityMetadataKey, plugin); + } } /**