From 406a7ba69478603103ec5715800c7c251fb8c685 Mon Sep 17 00:00:00 2001 From: nossr50 Date: Mon, 4 Nov 2024 19:05:41 -0800 Subject: [PATCH] 2.2.024 --- Changelog.txt | 7 ++++--- pom.xml | 2 +- .../gmail/nossr50/skills/excavation/ExcavationManager.java | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Changelog.txt b/Changelog.txt index a4ac4421a..bdf8cffa2 100644 --- a/Changelog.txt +++ b/Changelog.txt @@ -1,11 +1,12 @@ Version 2.2.024 - Fixed a bug where Giga Drill breaker was giving out more loot than intended + Fixed errors when Fishing or using Shake ability Significant optimizations made to reading new chunks for mcMMO Significant optimizations to most block interactions in mcMMO code + Fixed a horrendous edge case where Tree Feller could cause a lot of lag Notes: - Got a bit carried away and started to optimize stuff. - I was able to make Tree Feller way faster with optimizations in this update, I tested with a custom gigantic tree that had over 200,000 blocks felled (huge) and it only took 4 seconds total, in the previous version of mcMMO this would take over 2-3 minutes. + Part of this update focused on optimization, there's improvements of around 30% in CPU time for most code involving block interactions in mcMMO, which happens to be most code in mcMMO. + One of the optimizations made in this update removes an edge case where Tree Feller could cause a lot of lag, but the optimizations really are across the board in regards to any abilities that interact with blocks. Version 2.2.023 Compatibility with Minecraft 1.21.3 diff --git a/pom.xml b/pom.xml index 8ff1c5106..107c07487 100644 --- a/pom.xml +++ b/pom.xml @@ -2,7 +2,7 @@ 4.0.0 com.gmail.nossr50.mcMMO mcMMO - 2.2.024-SNAPSHOT + 2.2.024 mcMMO https://github.com/mcMMO-Dev/mcMMO diff --git a/src/main/java/com/gmail/nossr50/skills/excavation/ExcavationManager.java b/src/main/java/com/gmail/nossr50/skills/excavation/ExcavationManager.java index c880bdc83..6a164c636 100644 --- a/src/main/java/com/gmail/nossr50/skills/excavation/ExcavationManager.java +++ b/src/main/java/com/gmail/nossr50/skills/excavation/ExcavationManager.java @@ -42,7 +42,6 @@ public class ExcavationManager extends SkillManager { excavationBlockCheck(blockState.getBlock()); } - public void excavationBlockCheck(Block block) { int xp = ExperienceConfig.getInstance().getXp(PrimarySkillType.EXCAVATION, block.getType()); requireNonNull(block, "excavationBlockCheck: block cannot be null"); @@ -135,6 +134,7 @@ public class ExcavationManager extends SkillManager { */ public void gigaDrillBreaker(Block block) { excavationBlockCheck(block); + excavationBlockCheck(block); SkillUtils.handleDurabilityChange(getPlayer().getInventory().getItemInMainHand(), mcMMO.p.getGeneralConfig().getAbilityToolDamage());