From 317dc814a4481dc7536ae57e854c6a87584e8ca9 Mon Sep 17 00:00:00 2001 From: nossr50 Date: Tue, 23 Mar 2021 13:20:55 -0700 Subject: [PATCH] Add comment about power level cap issue --- .../java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java b/src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java index fb68f24ea..6921ad78a 100644 --- a/src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java +++ b/src/main/java/com/gmail/nossr50/datatypes/player/McMMOPlayer.java @@ -775,7 +775,9 @@ public class McMMOPlayer implements Identified { * @return Modified experience */ private float modifyXpGain(PrimarySkillType primarySkillType, float xp) { - if ((primarySkillType.getMaxLevel() <= getSkillLevel(primarySkillType)) || (Config.getInstance().getPowerLevelCap() <= getPowerLevel())) { + //TODO: A rare situation can occur where the default Power Level cap can prevent a player with one skill edited to something silly like Integer.MAX_VALUE from gaining XP in any skill, we may need to represent power level with another data type + if ((primarySkillType.getMaxLevel() <= getSkillLevel(primarySkillType)) + || (Config.getInstance().getPowerLevelCap() <= getPowerLevel())) { return 0; }