From 00131bb4123918f417b52144d11deb045fe87370 Mon Sep 17 00:00:00 2001
From: nossr50 <nossr50@gmail.com>
Date: Fri, 31 May 2019 18:42:23 -0700
Subject: [PATCH] DamageProperty for skills

---
 .../skills/axes/ConfigAxesCriticalStrikes.java |  5 ++---
 .../skills/properties/DamageProperty.java      | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 3 deletions(-)
 create mode 100644 src/main/java/com/gmail/nossr50/datatypes/skills/properties/DamageProperty.java

diff --git a/src/main/java/com/gmail/nossr50/config/hocon/skills/axes/ConfigAxesCriticalStrikes.java b/src/main/java/com/gmail/nossr50/config/hocon/skills/axes/ConfigAxesCriticalStrikes.java
index becb5da73..6b48b9364 100644
--- a/src/main/java/com/gmail/nossr50/config/hocon/skills/axes/ConfigAxesCriticalStrikes.java
+++ b/src/main/java/com/gmail/nossr50/config/hocon/skills/axes/ConfigAxesCriticalStrikes.java
@@ -14,9 +14,6 @@ public class ConfigAxesCriticalStrikes {
                     # ChanceMax: Maximum chance of causing a critical hit when on <MaxBonusLevel> or higher
                     # MaxBonusLevel: Level where <ChanceMax> of causing critical hits is reached
                     ChanceMax: 37.50
-                    MaxBonusLevel:
-                        Standard: 100
-                        RetroMode: 1000
                     # Damage modifier of critical hits for PVP / PVE, when causing a critical hit the damage gets multiplied by the modifier
                     PVP_Modifier: 1.5
                     PVE_Modifier: 2.0
@@ -29,4 +26,6 @@ public class ConfigAxesCriticalStrikes {
     @Setting(value = "Maximum-Level", comment = "This is the level at which full benefits for this skill will be reached." +
             "\nProperties of this skill may or may not scale with level, but those that do will gradually increase until max level is achieved.")
     AbstractMaximumProgressionLevel maximumProgressionLevel = new AbstractMaximumProgressionLevel(SubSkillType.AXES_CRITICAL_STRIKES, 100, 1000);
+
+
 }
diff --git a/src/main/java/com/gmail/nossr50/datatypes/skills/properties/DamageProperty.java b/src/main/java/com/gmail/nossr50/datatypes/skills/properties/DamageProperty.java
new file mode 100644
index 000000000..eb1313e44
--- /dev/null
+++ b/src/main/java/com/gmail/nossr50/datatypes/skills/properties/DamageProperty.java
@@ -0,0 +1,18 @@
+package com.gmail.nossr50.datatypes.skills.properties;
+
+/**
+ * Represents a skill property relating to damage
+ */
+public interface DamageProperty {
+    /**
+     * Get the damage modifier property of this skill for PVE interactions
+     * @return the PVE modifier for this skill
+     */
+    double getPVEModifier();
+
+    /**
+     * Get the damage modifier property of this skill for PVP interactions
+     * @return the PVP modifier for this skill
+     */
+    double getPVPModifier();
+}