From 054049881820a6c1ca1ff4b7fdc2d21aed93b038 Mon Sep 17 00:00:00 2001
From: EpicKnarvik97 <kristian.knarvik@knett.no>
Date: Sun, 7 Nov 2021 04:04:14 +0100
Subject: [PATCH] Moves the drawing of unregistered signs to the portal sign
 drawer

---
 .../stargate/portal/PortalRegistry.java       | 13 +----
 .../stargate/portal/PortalSignDrawer.java     | 54 ++++++++++++++++---
 2 files changed, 48 insertions(+), 19 deletions(-)

diff --git a/src/main/java/net/knarcraft/stargate/portal/PortalRegistry.java b/src/main/java/net/knarcraft/stargate/portal/PortalRegistry.java
index f463430..60b705a 100644
--- a/src/main/java/net/knarcraft/stargate/portal/PortalRegistry.java
+++ b/src/main/java/net/knarcraft/stargate/portal/PortalRegistry.java
@@ -4,8 +4,6 @@ import net.knarcraft.stargate.Stargate;
 import net.knarcraft.stargate.container.BlockLocation;
 import net.knarcraft.stargate.utility.PortalFileHelper;
 import org.bukkit.World;
-import org.bukkit.block.Sign;
-import org.bukkit.block.data.type.WallSign;
 
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -220,15 +218,8 @@ public class PortalRegistry {
             }
         }
 
-        //Clear sign data
-        if (portal.getSignLocation().getBlock().getBlockData() instanceof WallSign) {
-            Sign sign = (Sign) portal.getSignLocation().getBlock().getState();
-            sign.setLine(0, portal.getName());
-            sign.setLine(1, "");
-            sign.setLine(2, "");
-            sign.setLine(3, "");
-            sign.update();
-        }
+        //Mark the portal's sign as unregistered
+        new PortalSignDrawer(portal).drawUnregisteredSign();
 
         PortalFileHelper.saveAllPortals(portal.getWorld());
         portal.setRegistered(false);
diff --git a/src/main/java/net/knarcraft/stargate/portal/PortalSignDrawer.java b/src/main/java/net/knarcraft/stargate/portal/PortalSignDrawer.java
index b4117c3..375b067 100644
--- a/src/main/java/net/knarcraft/stargate/portal/PortalSignDrawer.java
+++ b/src/main/java/net/knarcraft/stargate/portal/PortalSignDrawer.java
@@ -46,16 +46,29 @@ public class PortalSignDrawer {
      * Draws the sign of the portal this sign drawer is responsible for
      */
     public void drawSign() {
+        Sign sign = getSign();
+        if (sign == null) {
+            return;
+        }
+
+        drawSign(sign);
+    }
+
+    /**
+     * Gets the sign for this sign drawer's portal
+     * 
+     * @return <p>The sign of this sign drawer's portal</p>
+     */
+    private Sign getSign() {
         Block signBlock = portal.getSignLocation().getBlock();
         BlockState state = signBlock.getState();
         if (!(state instanceof Sign sign)) {
             Stargate.logWarning("Sign block is not a Sign object");
             Stargate.debug("Portal::drawSign", String.format("Block: %s @ %s", signBlock.getType(),
                     signBlock.getLocation()));
-            return;
+            return null;
         }
-
-        drawSign(sign);
+        return sign;
     }
 
     /**
@@ -65,9 +78,7 @@ public class PortalSignDrawer {
      */
     private void drawSign(Sign sign) {
         //Clear sign
-        for (int index = 0; index <= 3; index++) {
-            sign.setLine(index, "");
-        }
+        clearSign(sign);
         setLine(sign, 0, highlightColor + "-" + mainColor +
                 portal.getName() + highlightColor + "-");
 
@@ -90,6 +101,31 @@ public class PortalSignDrawer {
         sign.update();
     }
 
+    /**
+     * Clears all lines of a sign, but does not update the sign
+     * 
+     * @param sign <p>The sign to clear</p>
+     */
+    private void clearSign(Sign sign) {
+        for (int index = 0; index <= 3; index++) {
+            sign.setLine(index, "");
+        }
+    }
+
+    /**
+     * Marks this sign drawer's portal as unregistered
+     */
+    public void drawUnregisteredSign() {
+        Sign sign = getSign();
+        if (sign == null) {
+            return;
+        }
+        clearSign(sign);
+        sign.setLine(0, portal.getName());
+        sign.setLine(3, errorColor + Stargate.getString("signInvalidGate"));
+        sign.update();
+    }
+
     /**
      * Draws a sign with choose-able network locations
      *
@@ -175,7 +211,7 @@ public class PortalSignDrawer {
     }
 
     /**
-     * Draws a bungee sign
+     * Draws the sign of a BungeeCord portal
      *
      * @param sign <p>The sign to re-draw</p>
      */
@@ -186,8 +222,10 @@ public class PortalSignDrawer {
     }
 
     /**
-     * Draws an inactive sign
+     * Draws the sign of an in-active portal
      *
+     * <p>The sign for an in-active portal should display the right-click prompt and the network.</p>
+     * 
      * @param sign <p>The sign to re-draw</p>
      */
     private void drawInactiveSign(Sign sign) {