Clean gradle target directory

Add some 1.9 blocks to chest content with schematic paste
Restructure tileentity placement from schematic (will soon add signs
etc)
Prepare for release 3.3.3

.github/ISSUE_TEMPLATE.md

@@ -1,12 +1,12 @@
-# Bug report template (clear for feature request)
+# Bug report template (Follow this template unless you are making a feature request.)
 **Debug paste link**:
 
 **Description of the problem:**
 
 **How to replicate**:
 
-Make sure you've completed the following steps (put X inside of brackets):
+Make sure you've completed the following steps (put an X between of brackets):
-- [ ] Include `/plot debugpaste`
+- [] Include `/plot debugpaste`
-- [ ] Made sure there aren't duplicates of this report [(Use Search)](https://github.com/IntellectualSites/PlotSquared/issues)
+- [] Made sure there aren't duplicates of this report [(Use Search)](https://github.com/IntellectualSites/PlotSquared/issues)
-- [ ] Made sure you're using an updated version of PlotSquared
+- [] Made sure you're using an updated version of PlotSquared
-- [ ] Made sure the bug/error isn't caused by any other plugin
+- [] Made sure the bug/error isn't caused by any other plugin

Bukkit/build.gradle

@@ -1,6 +1,7 @@
 dependencies {
     compile project(':Core')
     compile 'org.bukkit:bukkit:1.9-R0.1-SNAPSHOT'
+    compile 'org.mcstats.bukkit:metrics:R7'
     compile 'net.milkbowl.vault:VaultAPI:1.5'
 }
 
@@ -23,7 +24,9 @@ jar.enabled = false
 shadowJar {
     dependencies {
         include(dependency(':Core'))
+        include(dependency('org.mcstats.bukkit:metrics:R7'))
     }
+    relocate 'org.mcstats', 'com.plotsquared.stats'
     archiveName = "${parent.name}-${project.name}-${parent.version}.jar"
     destinationDir = file '../target'
 }

Bukkit/src/main/java/com/intellectualcrafters/plot/api/PlotAPI.java

@@ -1,29 +1,7 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
-
 package com.intellectualcrafters.plot.api;
 
 import com.intellectualcrafters.configuration.file.YamlConfiguration;
 import com.intellectualcrafters.plot.PS;
-import com.intellectualcrafters.plot.commands.MainCommand;
 import com.intellectualcrafters.plot.commands.SubCommand;
 import com.intellectualcrafters.plot.config.C;
 import com.intellectualcrafters.plot.flag.AbstractFlag;
@@ -53,45 +31,58 @@ import java.util.Set;
 import java.util.UUID;
 
 /**
- * PlotSquared API
+ * PlotSquared API.
- *
+ * <br>
-
+ * <br>
-
+ * Useful classes:<br>
- * @version API 2.0
+ * @see BukkitUtil
- *
+ * @see PlotPlayer
+ * @see Plot
+ * @see com.intellectualcrafters.plot.object.Location
+ * @see PlotArea
+ * @see PS
+ * @version 3.3.3
+>>>>>>> origin/master
  */
-
 public class PlotAPI {
-    
+
     /**
-     * Permission that allows for admin access, this permission node will allow the player to use any part of the
+     * Permission that allows for admin access, this permission node will allow
-     * plugin, without limitations.
+     * the player to use any part of the plugin, without limitations.
-     * @deprecated Use C.PERMISSION_ADMIN.s() instead
+     * @deprecated Use C.PERMISSION_ADMIN instead
      */
     @Deprecated
     public static final String ADMIN_PERMISSION = C.PERMISSION_ADMIN.s();
-    
+
     /**
-     * @deprecated Use new PlotAPI() instead
+     * Deprecated, does nothing.
+     * @param plugin not needed
+     * @deprecated Not needed
      */
     @Deprecated
-    public PlotAPI(final JavaPlugin plugin) {}
+    public PlotAPI(JavaPlugin plugin) {
-    
+    }
+
     /**
-     * @see PS
+     * Default Constructor that does nothing.
-     *
-     * @deprecated Use this class if you just want to do a few simple things.<br>
-     *  - It will remain stable for future versions of the plugin
-     *  - The PlotPlayer and Plot class should be considered relatively safe
-     *  - For more advanced/intensive tasks you should consider using other classes
      *
+     * @deprecated Use this class if you just want to do a few simple things
+     *      <ul>
+     *          <li>It will remain stable for future versions
+     *              of the plugin</li>
+     *          <li>The PlotPlayer and Plot class should be considered
+     *              relatively safe</li>
+     *          <li>For more advanced/intensive tasks you should consider
+     *              using other classes</li>
+     *      </ul>
      *
      */
     @Deprecated
-    public PlotAPI() {}
+    public PlotAPI() {
-    
+    }
+
     /**
-     * Get all plots
+     * Get all plots.
      *
      * @return all plots
      *
@@ -100,29 +91,30 @@ public class PlotAPI {
     public Set<Plot> getAllPlots() {
         return PS.get().getPlots();
     }
-    
+
     /**
-     * Return all plots for a player
+     * Return all plots for a player.
      *
      * @param player Player, whose plots to search for
      *
      * @return all plots that a player owns
      */
-    public Set<Plot> getPlayerPlots(final Player player) {
+    public Set<Plot> getPlayerPlots(Player player) {
         return PS.get().getPlots(BukkitUtil.getPlayer(player));
     }
-    
+
     /**
-     * Add a plot world
+     * Add a plot world.
      *
      * @param plotArea Plot World Object
      * @see PS#addPlotArea(PlotArea)
      */
-    public void addPlotArea(final PlotArea plotArea) {
+    public void addPlotArea(PlotArea plotArea) {
         PS.get().addPlotArea(plotArea);
     }
-    
+
     /**
+     * Returns the PlotSquared configurations file.
      * @return main configuration
      *
      * @see PS#config
@@ -130,8 +122,9 @@ public class PlotAPI {
     public YamlConfiguration getConfig() {
         return PS.get().config;
     }
-    
+
     /**
+     * Get the PlotSquared storage file.
      * @return storage configuration
      *
      * @see PS#storage
@@ -139,10 +132,9 @@ public class PlotAPI {
     public YamlConfiguration getStorage() {
         return PS.get().storage;
     }
-    
+
     /**
-     * Get the main class for this plugin <br> - Contains a lot of fields and methods - not very well organized <br>
+     * Get the main class for this plugin. Only use this if you really need it.
-     * Only use this if you really need it
      *
      * @return PlotSquared PlotSquared Main Class
      *
@@ -151,14 +143,16 @@ public class PlotAPI {
     public PS getMain() {
         return PS.get();
     }
-    
+
     /**
-     * ChunkManager class contains several useful methods<br>
+     * ChunkManager class contains several useful methods.
-     *  - Chunk deletion<br>
+     * <ul>
-     *  - Moving or copying regions<br>
+     *     <li>Chunk deletion</li>
-     *  - plot swapping<br>
+     *     <li>Moving or copying regions</li>
-     *  - Entity tracking<br>
+     *     <li>Plot swapping</li>
-     *  - region regeneration<br>
+     *     <li>Entity Tracking</li>
+     *     <li>Region Regeneration</li>
+     * </ul>
      *
      * @return ChunkManager
      *
@@ -175,9 +169,10 @@ public class PlotAPI {
     public SetQueue getSetQueue() {
         return SetQueue.IMP;
     }
-    
+
     /**
-     * UUIDWrapper class has basic methods for getting UUIDS (it's recommended to use the UUIDHandler class instead)
+     * UUIDWrapper class has basic methods for getting UUIDS. It's recommended
+     * to use the UUIDHandler class instead.
      *
      * @return UUIDWrapper
      *
@@ -186,54 +181,53 @@ public class PlotAPI {
     public UUIDWrapper getUUIDWrapper() {
         return UUIDHandler.getUUIDWrapper();
     }
-    
+
     /**
      * Do not use this. Instead use FlagManager.[method] in your code.
      *  - Flag related stuff
      *
      * @return FlagManager
      *
-     * @see com.intellectualcrafters.plot.flag.FlagManager
+     * @deprecated Use {@link FlagManager} directly
      */
     @Deprecated
     public FlagManager getFlagManager() {
         return new FlagManager();
     }
-    
+
     /**
      * Do not use this. Instead use MainUtil.[method] in your code.
-     *  - Basic plot management stuff
      *
      * @return MainUtil
-     *
+     * @deprecated Use {@link MainUtil} directly
-     * @see MainUtil
      */
     @Deprecated
     public MainUtil getMainUtil() {
         return new MainUtil();
     }
-    
+
     /**
      * Do not use this. Instead use C.PERMISSION_[method] in your code.
-     *  - Basic permission management stuff
      *
      * @return Array of strings
      *
      * @see com.intellectualcrafters.plot.util.Permissions
+     * @deprecated Use {@link C} to list all the permissions
      */
     @Deprecated
     public String[] getPermissions() {
-        final ArrayList<String> perms = new ArrayList<>();
+        ArrayList<String> perms = new ArrayList<>();
-        for (final C c : C.values()) {
+        for (C c : C.values()) {
-            if ("static.permissions".equals(c.getCat())) {
+            if ("static.permissions".equals(c.getCategory())) {
                 perms.add(c.s());
             }
         }
         return perms.toArray(new String[perms.size()]);
     }
-    
+
     /**
-     * SchematicHandler class contains methods related to pasting, reading and writing schematics
+     * SchematicHandler class contains methods related to pasting, reading
+     * and writing schematics.
      *
      * @return SchematicHandler
      *
@@ -242,21 +236,21 @@ public class PlotAPI {
     public SchematicHandler getSchematicHandler() {
         return SchematicHandler.manager;
     }
-    
+
     /**
      * Use C.[caption] instead
      *
      * @return C
-     *
+     * @deprecated Use {@link C}
-     * @see com.intellectualcrafters.plot.config.C
      */
     @Deprecated
     public C[] getCaptions() {
         return C.values();
     }
-    
+
     /**
-     * Get the plot manager for a world. - Most of these methods can be accessed through the MainUtil
+     * Get the plot manager for a world. Most of these methods can be accessed
+     * through the MainUtil.
      *
      * @param world Which manager to get
      *
@@ -266,13 +260,18 @@ public class PlotAPI {
      * @see PS#getPlotManager(Plot)
      */
     @Deprecated
-    public PlotManager getPlotManager(final World world) {
+    public PlotManager getPlotManager(World world) {
         if (world == null) {
             return null;
         }
         return getPlotManager(world.getName());
     }
-    
+
+    /**
+     * Get a list of PlotAreas in the world.
+     * @param world The world to check for plot areas
+     * @return A set of PlotAreas
+     */
     public Set<PlotArea> getPlotAreas(World world) {
         if (world == null) {
             return new HashSet<>();
@@ -281,10 +280,10 @@ public class PlotAPI {
     }
 
     /**
-     * Get the plot manager for a world. - Contains useful low level methods for plot merging, clearing, and
+     * Get the plot manager for a world. Contains useful low level methods for
-     * tessellation
+     * plot merging, clearing, and tessellation.
      *
-     * @param world
+     * @param world The world
      *
      * @return PlotManager
      *
@@ -292,7 +291,7 @@ public class PlotAPI {
      * @see com.intellectualcrafters.plot.object.PlotManager
      */
     @Deprecated
-    public PlotManager getPlotManager(final String world) {
+    public PlotManager getPlotManager(String world) {
         Set<PlotArea> areas = PS.get().getPlotAreas(world);
         switch (areas.size()) {
             case 0:
@@ -304,38 +303,39 @@ public class PlotAPI {
                 return null;
         }
     }
-    
+
     /**
-     * Get the settings for a world (settings bundled in PlotArea class) - You will need to downcast for the specific
+     * Get the settings for a world (settings bundled in PlotArea class). You
-     * settings a Generator has. e.g. DefaultPlotWorld class implements PlotArea
+     * will need to downcast for the specific settings a Generator has. e.g.
+     * DefaultPlotWorld class implements PlotArea
      *
-     * @param world (to get settings of)
+     * @param world The World
      *
-     * @return PlotArea class for that world ! will return null if not a plot world world
+     * @return The {@link PlotArea} for the world or null if not in plotworld
      *
      * @see #getPlotAreas(World)
      * @see com.intellectualcrafters.plot.object.PlotArea
      */
     @Deprecated
-    public PlotArea getWorldSettings(final World world) {
+    public PlotArea getWorldSettings(World world) {
         if (world == null) {
             return null;
         }
         return getWorldSettings(world.getName());
     }
-    
+
     /**
-     * Get the settings for a world (settings bundled in PlotArea class)
+     * Get the settings for a world.
      *
-     * @param world (to get settings of)
+     * @param world The world
      *
-     * @return PlotArea class for that world ! will return null if not a plot world world
+     * @return The {@link PlotArea} for the world or null if not in plotworld
      *
      * @see PS#getPlotArea(String, String)
      * @see com.intellectualcrafters.plot.object.PlotArea
      */
     @Deprecated
-    public PlotArea getWorldSettings(final String world) {
+    public PlotArea getWorldSettings(String world) {
         if (world == null) {
             return null;
         }
@@ -350,69 +350,68 @@ public class PlotAPI {
                 return null;
         }
     }
-    
+
     /**
      * Send a message to a player.
      *
      * @param player Player that will receive the message
-     * @param c      (Caption)
+     * @param caption Caption
      *
      * @see MainUtil#sendMessage(PlotPlayer, C, String...)
-     * com.intellectualcrafters.plot.config.C, String...)
      */
-    public void sendMessage(final Player player, final C c) {
+    public void sendMessage(Player player, C caption) {
-        MainUtil.sendMessage(BukkitUtil.getPlayer(player), c);
+        MainUtil.sendMessage(BukkitUtil.getPlayer(player), caption);
     }
-    
+
     /**
-     * Send a message to a player. - Supports color codes
+     * Send a message to a player. Supports color codes.
      *
      * @param player Player that will receive the message
      * @param string The message
      *
      * @see MainUtil#sendMessage(PlotPlayer, String)
      */
-    public void sendMessage(final Player player, final String string) {
+    public void sendMessage(Player player, String string) {
         MainUtil.sendMessage(BukkitUtil.getPlayer(player), string);
     }
-    
+
     /**
-     * Send a message to the console. - Supports color codes
+     * Send a message to the console. Supports color codes.
      *
-     * @param msg Message that should be sent to the console
+     * @param message Message that should be sent to the console
      *
      * @see MainUtil#sendConsoleMessage(C, String...)
      */
-    public void sendConsoleMessage(final String msg) {
+    public void sendConsoleMessage(String message) {
-        PS.log(msg);
+        PS.log(message);
     }
-    
+
     /**
-     * Send a message to the console
+     * Send a message to the console.
      *
-     * @param c (Caption)
+     * @param caption The caption
      *
      * @see #sendConsoleMessage(String)
      * @see com.intellectualcrafters.plot.config.C
      */
-    public void sendConsoleMessage(final C c) {
+    public void sendConsoleMessage(C caption) {
-        sendConsoleMessage(c.s());
+        sendConsoleMessage(caption.s());
     }
-    
+
     /**
-     * Register a flag for use in plots
+     * Register a flag for use in plots.
      *
      * @param flag Flag that should be registered
      *
      * @see com.intellectualcrafters.plot.flag.FlagManager#addFlag(com.intellectualcrafters.plot.flag.AbstractFlag)
      * @see com.intellectualcrafters.plot.flag.AbstractFlag
      */
-    public void addFlag(final AbstractFlag flag) {
+    public void addFlag(AbstractFlag flag) {
         FlagManager.addFlag(flag);
     }
-    
+
     /**
-     * get all the currently registered flags
+     * get all the currently registered flags.
      *
      * @return array of Flag[]
      *
@@ -422,20 +421,20 @@ public class PlotAPI {
     public AbstractFlag[] getFlags() {
         return FlagManager.getFlags().toArray(new AbstractFlag[FlagManager.getFlags().size()]);
     }
-    
+
     /**
-     * Get a plot based on the ID
+     * Get a plot based on the ID.
      *
      * @param world World in which the plot is located
-     * @param x     Plot Location X Co-ord
+     * @param x The PlotID x coordinate
-     * @param z     Plot Location Z Co-ord
+     * @param z The PlotID y coordinate
      *
      * @return plot, null if ID is wrong
      *
      * @see PlotArea#getPlot(PlotId)
      */
     @Deprecated
-    public Plot getPlot(final World world, final int x, final int z) {
+    public Plot getPlot(World world, int x, int z) {
         if (world == null) {
             return null;
         }
@@ -445,25 +444,25 @@ public class PlotAPI {
         }
         return area.getPlot(new PlotId(x, z));
     }
-    
+
     /**
-     * Get a plot based on the location
+     * Get a plot based on the location.
      *
-     * @param l The location that you want to to retrieve the plot from
+     * @param location The location to retrieve the plot from
      *
-     * @return plot if found, otherwise it creates a temporary plot-
+     * @return plot if found, otherwise it creates a temporary plot
      *
      * @see Plot
      */
-    public Plot getPlot(final Location l) {
+    public Plot getPlot(Location location) {
-        if (l == null) {
+        if (location == null) {
             return null;
         }
-        return BukkitUtil.getLocation(l).getPlot();
+        return BukkitUtil.getLocation(location).getPlot();
     }
-    
+
     /**
-     * Get a plot based on the player location
+     * Get a plot based on the player location.
      *
      * @param player Get the current plot for the player location
      *
@@ -472,50 +471,50 @@ public class PlotAPI {
      * @see #getPlot(org.bukkit.Location)
      * @see Plot
      */
-    public Plot getPlot(final Player player) {
+    public Plot getPlot(Player player) {
         return this.getPlot(player.getLocation());
     }
-    
+
     /**
-     * Check whether or not a player has a plot
+     * Check whether or not a player has a plot.
      *
      * @param player Player that you want to check for
-     *
+     * @param world The world to check
      * @return true if player has a plot, false if not.
      *
      * @see #getPlots(World, Player, boolean)
      */
     @Deprecated
-    public boolean hasPlot(final World world, final Player player) {
+    public boolean hasPlot(World world, Player player) {
-        return getPlots(world, player, true) != null && getPlots(world, player, true).length > 0;
+        return getPlots(world, player, true).length > 0;
     }
-    
+
     /**
-     * Get all plots for the player
+     * Get all plots for the player.
      *
-     * @param plr        to search for
+     * @param world The world to retrieve plots from
-     * @param just_owner should we just search for owner? Or with rights?
+     * @param player The player to search for
+     * @param justOwner should we just search for owner? Or with rights?
+     * @return An array of plots for the player
      */
     @Deprecated
-    public Plot[] getPlots(final World world, final Player plr, final boolean just_owner) {
+    public Plot[] getPlots(World world, Player player, boolean justOwner) {
-        final ArrayList<Plot> pPlots = new ArrayList<>();
+        ArrayList<Plot> pPlots = new ArrayList<>();
-        UUID uuid = BukkitUtil.getPlayer(plr).getUUID();
+        UUID uuid = BukkitUtil.getPlayer(player).getUUID();
-        for (final Plot plot : PS.get().getPlots(world.getName())) {
+        for (Plot plot : PS.get().getPlots(world.getName())) {
-            if (just_owner) {
+            if (justOwner) {
                 if (plot.hasOwner() && plot.isOwner(uuid)) {
                     pPlots.add(plot);
                 }
-            } else {
+            } else if (plot.isAdded(uuid)) {
-                if (plot.isAdded(uuid)) {
+                pPlots.add(plot);
-                    pPlots.add(plot);
-                }
             }
         }
         return pPlots.toArray(new Plot[pPlots.size()]);
     }
-    
+
     /**
-     * Get all plots for the world
+     * Get all plots for the world.
      *
      * @param world to get plots of
      *
@@ -525,16 +524,16 @@ public class PlotAPI {
      * @see Plot
      */
     @Deprecated
-    public Plot[] getPlots(final World world) {
+    public Plot[] getPlots(World world) {
         if (world == null) {
             return new Plot[0];
         }
         Collection<Plot> plots = PS.get().getPlots(world.getName());
         return plots.toArray(new Plot[plots.size()]);
     }
-    
+
     /**
-     * Get all plot worlds
+     * Get all plot worlds.
      *
      * @return World[] - array of plot worlds
      *
@@ -544,25 +543,25 @@ public class PlotAPI {
         Set<String> plotWorldStrings = PS.get().getPlotWorldStrings();
         return plotWorldStrings.toArray(new String[plotWorldStrings.size()]);
     }
-    
+
     /**
-     * Get if plot world
+     * Get if plotworld.
      *
-     * @param world (to check if plot world)
+     * @param world The world to check
      *
      * @return boolean (if plot world or not)
      *
      * @see PS#hasPlotArea(String)
      */
     @Deprecated
-    public boolean isPlotWorld(final World world) {
+    public boolean isPlotWorld(World world) {
         return PS.get().hasPlotArea(world.getName());
     }
-    
+
     /**
-     * Get plot locations
+     * Get plot locations.
      *
-     * @param p Plot that you want to get the locations for
+     * @param plot Plot to get the locations for
      *
      * @return [0] = bottomLc, [1] = topLoc, [2] = home
      *
@@ -571,27 +570,30 @@ public class PlotAPI {
      * @see Plot
      */
     @Deprecated
-    public Location[] getLocations(final Plot p) {
+    public Location[] getLocations(Plot plot) {
-        return new Location[] { BukkitUtil.getLocation(p.getBottom()), BukkitUtil.getLocation(p.getTop()), BukkitUtil.getLocation(p.getHome()) };
+        Location bukkitBottom = BukkitUtil.getLocation(plot.getCorners()[0]);
+        Location bukkitTop = BukkitUtil.getLocation(plot.getCorners()[1]);
+        Location bukkitHome = BukkitUtil.getLocation(plot.getHome());
+        return new Location[]{bukkitBottom, bukkitTop, bukkitHome};
     }
-    
+
     /**
-     * Get home location
+     * Get home location.
      *
-     * @param p Plot that you want to get the location for
+     * @param plot Plot that you want to get the location for
      *
      * @return plot bottom location
      *
      * @see Plot
      */
-    public Location getHomeLocation(final Plot p) {
+    public Location getHomeLocation(Plot plot) {
-        return BukkitUtil.getLocation(p.getHome());
+        return BukkitUtil.getLocation(plot.getHome());
     }
-    
+
     /**
-     * Get Bottom Location (min, min, min)
+     * Get Bottom Location (min, min, min).
      *
-     * @param p Plot that you want to get the location for
+     * @param plot Plot that you want to get the location for
      *
      * @return plot bottom location
      *
@@ -600,55 +602,51 @@ public class PlotAPI {
      * @see Plot
      */
     @Deprecated
-    public Location getBottomLocation(final Plot p) {
+    public Location getBottomLocation(Plot plot) {
-        return BukkitUtil.getLocation(p.getBottom());
+        return BukkitUtil.getLocation(plot.getBottom());
     }
-    
+
     /**
-     * Get Top Location (max, max, max)
+     * Get Top Location (max, max, max).
      *
-     * @param p Plot that you want to get the location for
+     * @param plot Plot that you want to get the location for
      *
      * @return plot top location
-     * 
+     *
      * @deprecated As merged plots may not have a rectangular shape
      *
      * @see Plot
      */
     @Deprecated
-    public Location getTopLocation(final Plot p) {
+    public Location getTopLocation(Plot plot) {
-        return BukkitUtil.getLocation(p.getTop());
+        return BukkitUtil.getLocation(plot.getTop());
     }
-    
+
     /**
-     * Check whether or not a player is in a plot
+     * Check whether or not a player is in a plot.
      *
      * @param player who we're checking for
      *
      * @return true if the player is in a plot, false if not-
      *
      */
-    public boolean isInPlot(final Player player) {
+    public boolean isInPlot(Player player) {
         return getPlot(player) != null;
     }
-    
+
     /**
-     * Register a subcommand
+     * Register a subcommand.
-     *
+     * @deprecated Command registration is done on object creation
      * @param c SubCommand, that we want to register
-     *
      * @see com.intellectualcrafters.plot.commands.SubCommand
      */
-    public void registerCommand(final SubCommand c) {
+    @Deprecated
-        if (c.getCommand() != null) {
+    public void registerCommand(SubCommand c) {
-            MainCommand.getInstance().addCommand(c);
+        PS.debug("SubCommands are now registered on creation");
-        } else {
-            MainCommand.getInstance().createCommand(c);
-        }
     }
-    
+
     /**
-     * Get the PlotSquared class
+     * Get the PlotSquared class.
      *
      * @return PlotSquared Class
      *
@@ -657,9 +655,9 @@ public class PlotAPI {
     public PS getPlotSquared() {
         return PS.get();
     }
-    
+
     /**
-     * Get the player plot count
+     * Get the player plot count.
      *
      * @param world  Specify the world we want to select the plots from
      * @param player Player, for whom we're getting the plot count
@@ -667,15 +665,15 @@ public class PlotAPI {
      * @return the number of plots the player has
      *
      */
-    public int getPlayerPlotCount(final World world, final Player player) {
+    public int getPlayerPlotCount(World world, Player player) {
         if (world == null) {
             return 0;
         }
         return BukkitUtil.getPlayer(player).getPlotCount(world.getName());
     }
-    
+
     /**
-     * Get a collection containing the players plots
+     * Get a collection containing the players plots.
      *
      * @param world  Specify the world we want to select the plots from
      * @param player Player, for whom we're getting the plots
@@ -686,73 +684,77 @@ public class PlotAPI {
      *
      * @see Plot
      */
-    public Set<Plot> getPlayerPlots(final World world, final Player player) {
+    public Set<Plot> getPlayerPlots(World world, Player player) {
         if (world == null) {
             return new HashSet<>();
         }
         return BukkitUtil.getPlayer(player).getPlots(world.getName());
     }
-    
+
     /**
-     * Get the numbers of plots, which the player is able to build in
+     * Get the numbers of plots, which the player is able to build in.
      *
-     * @param player Player, for whom we're getting the plots (trusted, member and owner)
+     * @param player Player, for whom we're getting the plots
      *
      * @return the number of allowed plots
      *
      */
-    public int getAllowedPlots(final Player player) {
+    public int getAllowedPlots(Player player) {
-        final PlotPlayer pp = BukkitUtil.getPlayer(player);
+        PlotPlayer pp = BukkitUtil.getPlayer(player);
         return pp.getAllowedPlots();
     }
-    
+
     /**
-     * Get the PlotPlayer for a player<br>
+     * Get the PlotPlayer for a player. The PlotPlayer is usually cached and
-     *  - The PlotPlayer is usually cached and will provide useful functions relating to players
+     * will provide useful functions relating to players.
      *
      * @see PlotPlayer#wrap(Object)
      *
-     * @param player
+     * @param player The player to wrap
-     * @return
+     * @return A PlotPlayer
      */
-    public PlotPlayer wrapPlayer(final Player player) {
+    public PlotPlayer wrapPlayer(Player player) {
         return PlotPlayer.wrap(player);
     }
-    
+
     /**
-     * Get the PlotPlayer for a UUID (Please note that PlotSquared can be configured to provide different UUIDs than bukkit)
+     * Get the PlotPlayer for a UUID.
+     *
+     * <p><i>Please note that PlotSquared can be configured to provide
+     * different UUIDs than bukkit</i></p>
      *
      * @see PlotPlayer#wrap(Object)
      *
-     * @param uuid
+     * @param uuid The uuid of the player to wrap
-     * @return
+     * @return A PlotPlayer
      */
-    public PlotPlayer wrapPlayer(final UUID uuid) {
+    public PlotPlayer wrapPlayer(UUID uuid) {
         return PlotPlayer.wrap(uuid);
     }
-    
+
     /**
-     * Get the PlotPlayer for a username
+     * Get the PlotPlayer for a username.
      *
      * @see PlotPlayer#wrap(Object)
      *
-     * @param player
+     * @param player The player to wrap
-     * @return
+     * @return The PlotPlayer
      */
-    public PlotPlayer wrapPlayer(final String player) {
+    public PlotPlayer wrapPlayer(String player) {
         return PlotPlayer.wrap(player);
     }
-    
+
     /**
-     * Get the PlotPlayer for an offline player<br>
+     * Get the PlotPlayer for an offline player.
-     * Note that this will work if the player is offline, however not all functionality will work
+     * <p>Note that this will work if the player is offline, however not all
+     * functionality will work</p>
      *
      * @see PlotPlayer#wrap(Object)
      *
-     * @param player
+     * @param player The player to wrap
-     * @return
+     * @return The PlotPlayer
      */
-    public PlotPlayer wrapPlayer(final OfflinePlayer player) {
+    public PlotPlayer wrapPlayer(OfflinePlayer player) {
         return PlotPlayer.wrap(player);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/BukkitMain.java

@@ -3,7 +3,6 @@ package com.plotsquared.bukkit;
 import com.intellectualcrafters.configuration.ConfigurationSection;
 import com.intellectualcrafters.plot.IPlotMain;
 import com.intellectualcrafters.plot.PS;
-import com.intellectualcrafters.plot.commands.MainCommand;
 import com.intellectualcrafters.plot.config.C;
 import com.intellectualcrafters.plot.config.ConfigurationNode;
 import com.intellectualcrafters.plot.config.Settings;
@@ -12,26 +11,79 @@ import com.intellectualcrafters.plot.generator.GeneratorWrapper;
 import com.intellectualcrafters.plot.generator.HybridGen;
 import com.intellectualcrafters.plot.generator.HybridUtils;
 import com.intellectualcrafters.plot.generator.IndependentPlotGenerator;
-import com.intellectualcrafters.plot.object.*;
+import com.intellectualcrafters.plot.object.Plot;
-import com.intellectualcrafters.plot.util.*;
+import com.intellectualcrafters.plot.object.PlotArea;
+import com.intellectualcrafters.plot.object.PlotPlayer;
+import com.intellectualcrafters.plot.object.RunnableVal;
+import com.intellectualcrafters.plot.object.SetupObject;
+import com.intellectualcrafters.plot.util.AbstractTitle;
+import com.intellectualcrafters.plot.util.ChatManager;
+import com.intellectualcrafters.plot.util.ChunkManager;
+import com.intellectualcrafters.plot.util.ConsoleColors;
+import com.intellectualcrafters.plot.util.EconHandler;
+import com.intellectualcrafters.plot.util.EventUtil;
+import com.intellectualcrafters.plot.util.InventoryUtil;
+import com.intellectualcrafters.plot.util.MainUtil;
+import com.intellectualcrafters.plot.util.PlotQueue;
+import com.intellectualcrafters.plot.util.SchematicHandler;
+import com.intellectualcrafters.plot.util.SetupUtils;
+import com.intellectualcrafters.plot.util.StringMan;
+import com.intellectualcrafters.plot.util.TaskManager;
+import com.intellectualcrafters.plot.util.UUIDHandler;
+import com.intellectualcrafters.plot.util.UUIDHandlerImplementation;
+import com.intellectualcrafters.plot.util.WorldUtil;
 import com.intellectualcrafters.plot.uuid.UUIDWrapper;
-import com.plotsquared.bukkit.commands.DebugUUID;
 import com.plotsquared.bukkit.database.plotme.ClassicPlotMeConnector;
 import com.plotsquared.bukkit.database.plotme.LikePlotMeConverter;
 import com.plotsquared.bukkit.database.plotme.PlotMeConnector_017;
 import com.plotsquared.bukkit.generator.BukkitPlotGenerator;
-import com.plotsquared.bukkit.listeners.*;
+import com.plotsquared.bukkit.listeners.ChunkListener;
+import com.plotsquared.bukkit.listeners.ForceFieldListener;
+import com.plotsquared.bukkit.listeners.PlayerEvents;
+import com.plotsquared.bukkit.listeners.PlayerEvents183;
+import com.plotsquared.bukkit.listeners.PlayerEvents_1_8;
+import com.plotsquared.bukkit.listeners.PlayerEvents_1_9;
+import com.plotsquared.bukkit.listeners.PlotPlusListener;
+import com.plotsquared.bukkit.listeners.WorldEvents;
 import com.plotsquared.bukkit.listeners.worldedit.WEListener;
-import com.plotsquared.bukkit.titles.DefaultTitle;
+import com.plotsquared.bukkit.titles.DefaultTitle_19;
-import com.plotsquared.bukkit.util.*;
+import com.plotsquared.bukkit.util.BukkitChatManager;
+import com.plotsquared.bukkit.util.BukkitChunkManager;
+import com.plotsquared.bukkit.util.BukkitCommand;
+import com.plotsquared.bukkit.util.BukkitEconHandler;
+import com.plotsquared.bukkit.util.BukkitEventUtil;
+import com.plotsquared.bukkit.util.BukkitHybridUtils;
+import com.plotsquared.bukkit.util.BukkitInventoryUtil;
+import com.plotsquared.bukkit.util.BukkitPlainChatManager;
+import com.plotsquared.bukkit.util.BukkitSchematicHandler;
+import com.plotsquared.bukkit.util.BukkitSetupUtils;
+import com.plotsquared.bukkit.util.BukkitTaskManager;
+import com.plotsquared.bukkit.util.BukkitUtil;
+import com.plotsquared.bukkit.util.Metrics;
+import com.plotsquared.bukkit.util.SendChunk;
+import com.plotsquared.bukkit.util.SetGenCB;
 import com.plotsquared.bukkit.util.block.FastQueue_1_7;
 import com.plotsquared.bukkit.util.block.FastQueue_1_8;
 import com.plotsquared.bukkit.util.block.FastQueue_1_8_3;
+import com.plotsquared.bukkit.util.block.FastQueue_1_9;
 import com.plotsquared.bukkit.util.block.SlowQueue;
-import com.plotsquared.bukkit.uuid.*;
+import com.plotsquared.bukkit.uuid.DefaultUUIDWrapper;
+import com.plotsquared.bukkit.uuid.FileUUIDHandler;
+import com.plotsquared.bukkit.uuid.LowerOfflineUUIDWrapper;
+import com.plotsquared.bukkit.uuid.OfflineUUIDWrapper;
+import com.plotsquared.bukkit.uuid.SQLUUIDHandler;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
-import org.bukkit.*;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+import java.util.UUID;
+import org.bukkit.Bukkit;
+import org.bukkit.ChatColor;
 import org.bukkit.Location;
+import org.bukkit.OfflinePlayer;
+import org.bukkit.World;
 import org.bukkit.command.PluginCommand;
 import org.bukkit.entity.Entity;
 import org.bukkit.entity.Player;
@@ -41,29 +93,23 @@ import org.bukkit.metadata.MetadataValue;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.plugin.java.JavaPlugin;
 
-import java.io.File;
-import java.io.IOException;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
-import java.util.*;
-
 public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
-    
+
     public static BukkitMain THIS;
     public static WorldEditPlugin worldEdit;
-    
+
     private int[] version;
-    
+
     @Override
     public int[] getServerVersion() {
-        if (version == null) {
+        if (this.version == null) {
             try {
-                version = new int[3];
+                this.version = new int[3];
-                final String[] split = Bukkit.getBukkitVersion().split("-")[0].split("\\.");
+                String[] split = Bukkit.getBukkitVersion().split("-")[0].split("\\.");
-                version[0] = Integer.parseInt(split[0]);
+                this.version[0] = Integer.parseInt(split[0]);
-                version[1] = Integer.parseInt(split[1]);
+                this.version[1] = Integer.parseInt(split[1]);
                 if (split.length == 3) {
-                    version[2] = Integer.parseInt(split[2]);
+                    this.version[2] = Integer.parseInt(split[2]);
                 }
             } catch (NumberFormatException e) {
                 e.printStackTrace();
@@ -72,81 +118,83 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                 return new int[]{Integer.MAX_VALUE, 0, 0};
             }
         }
-        return version;
+        return this.version;
     }
-    
+
     @Override
     public void onEnable() {
-        THIS = this;
+        BukkitMain.THIS = this;
         new PS(this, "Bukkit");
     }
-    
+
     @Override
     public void onDisable() {
         PS.get().disable();
         Bukkit.getScheduler().cancelTasks(this);
-        THIS = null;
+        BukkitMain.THIS = null;
     }
-    
+
     @Override
     public void log(String message) {
-        if (message == null) {
+        if (BukkitMain.THIS != null) {
-            return;
-        }
-        if ((THIS != null) && (Bukkit.getServer().getConsoleSender() != null)) {
             try {
                 message = C.color(message);
                 if (!Settings.CONSOLE_COLOR) {
                     message = ChatColor.stripColor(message);
                 }
-                Bukkit.getServer().getConsoleSender().sendMessage(message);
+                this.getServer().getConsoleSender().sendMessage(message);
                 return;
-            } catch (final Throwable e) {}
+            } catch (Throwable ignored) {
+                //ignored
+            }
         }
         System.out.println(ConsoleColors.fromString(message));
     }
-    
+
     @Override
     public void disable() {
-        if (THIS != null) {
+        if (BukkitMain.THIS != null) {
             onDisable();
         }
     }
-    
+
     @Override
     public int[] getPluginVersion() {
-        final String[] split = getDescription().getVersion().split("\\.");
+        String version = getDescription().getVersion();
-        return new int[] { Integer.parseInt(split[0]), Integer.parseInt(split[1]), Integer.parseInt(split[2]) };
+        if (version.contains("-SNAPSHOT")) {
+            version = version.split("-SNAPSHOT")[0];
+        }
+        String[] split = version.split("\\.");
+        return new int[]{Integer.parseInt(split[0]), Integer.parseInt(split[1]), Integer.parseInt(split[2])};
     }
-    
+
     @Override
     public void registerCommands() {
-        final BukkitCommand bcmd = new BukkitCommand();
+        BukkitCommand bukkitCommand = new BukkitCommand();
-        final PluginCommand plotCommand = getCommand("plots");
+        PluginCommand plotCommand = getCommand("plots");
-        plotCommand.setExecutor(bcmd);
+        plotCommand.setExecutor(bukkitCommand);
         plotCommand.setAliases(Arrays.asList("p", "ps", "plotme", "plot"));
-        plotCommand.setTabCompleter(bcmd);
+        plotCommand.setTabCompleter(bukkitCommand);
-        MainCommand.getInstance().addCommand(new DebugUUID());
     }
-    
+
     @Override
     public File getDirectory() {
         return getDataFolder();
     }
-    
+
     @Override
     public File getWorldContainer() {
         return Bukkit.getWorldContainer();
     }
-    
+
     @Override
     public TaskManager getTaskManager() {
         return new BukkitTaskManager();
     }
-    
+
     @Override
     public void runEntityTask() {
-        log(C.PREFIX.s() + "KillAllEntities started.");
+        log(C.PREFIX + "KillAllEntities started.");
         TaskManager.runTaskRepeat(new Runnable() {
             @Override
             public void run() {
@@ -159,15 +207,16 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                                 return;
                             }
                             List<Entity> entities = world.getEntities();
-                            Iterator<Entity> iter = entities.iterator();
+                            Iterator<Entity> iterator = entities.iterator();
-                            while (iter.hasNext()) {
+                            while (iterator.hasNext()) {
-                                Entity entity = iter.next();
+                                Entity entity = iterator.next();
                                 switch (entity.getType()) {
                                     case EGG:
                                     case ENDER_CRYSTAL:
                                     case COMPLEX_PART:
                                     case FISHING_HOOK:
                                     case ENDER_SIGNAL:
+                                    case AREA_EFFECT_CLOUD:
                                     case EXPERIENCE_ORB:
                                     case LEASH_HITCH:
                                     case FIREWORK:
@@ -175,23 +224,23 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                                     case LIGHTNING:
                                     case WITHER_SKULL:
                                     case UNKNOWN:
-                                    case PLAYER: {
+                                    case PLAYER:
-                                        // non moving / unremovable
+                                        // non moving / unmovable
                                         continue;
-                                    }
                                     case THROWN_EXP_BOTTLE:
                                     case SPLASH_POTION:
                                     case SNOWBALL:
+                                    case SHULKER_BULLET:
+                                    case SPECTRAL_ARROW:
+                                    case TIPPED_ARROW:
                                     case ENDER_PEARL:
-                                    case ARROW: {
+                                    case ARROW:
                                         // managed elsewhere | projectile
                                         continue;
-                                    }
                                     case ARMOR_STAND:
                                     case ITEM_FRAME:
-                                    case PAINTING: {
+                                    case PAINTING:
                                         // TEMPORARILY CLASSIFY AS VEHICLE
-                                    }
                                     case MINECART:
                                     case MINECART_CHEST:
                                     case MINECART_COMMAND:
@@ -203,11 +252,11 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                                         if (!Settings.KILL_ROAD_VEHICLES) {
                                             continue;
                                         }
-                                        com.intellectualcrafters.plot.object.Location loc = BukkitUtil.getLocation(entity.getLocation());
+                                        com.intellectualcrafters.plot.object.Location location = BukkitUtil.getLocation(entity.getLocation());
-                                        Plot plot = loc.getPlot();
+                                        Plot plot = location.getPlot();
                                         if (plot == null) {
-                                            if (loc.isPlotArea()) {
+                                            if (location.isPlotArea()) {
-                                                iter.remove();
+                                                iterator.remove();
                                                 entity.remove();
                                             }
                                             continue;
@@ -218,22 +267,21 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                                         }
                                         Plot origin = (Plot) meta.get(0).value();
                                         if (!plot.equals(origin.getBasePlot(false))) {
-                                            iter.remove();
+                                            iterator.remove();
                                             entity.remove();
                                         }
                                         continue;
                                     }
                                     case SMALL_FIREBALL:
                                     case FIREBALL:
-                                    case DROPPED_ITEM: {
+                                    case DRAGON_FIREBALL:
+                                    case DROPPED_ITEM:
                                         // dropped item
                                         continue;
-                                    }
                                     case PRIMED_TNT:
-                                    case FALLING_BLOCK: {
+                                    case FALLING_BLOCK:
                                         // managed elsewhere
                                         continue;
-                                    }
                                     case BAT:
                                     case BLAZE:
                                     case CAVE_SPIDER:
@@ -266,24 +314,22 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                                     case WITHER:
                                     case WOLF:
                                     case ZOMBIE:
-                                    default: {
+                                    case SHULKER:
+                                    default:
                                         if (!Settings.KILL_ROAD_MOBS) {
                                             continue;
                                         }
-                                        final Location loc = entity.getLocation();
+                                        Location location = entity.getLocation();
-                                        if (BukkitUtil.getLocation(loc).isPlotRoad()) {
+                                        if (BukkitUtil.getLocation(location).isPlotRoad()) {
-                                            final Entity passenger = entity.getPassenger();
+                                            Entity passenger = entity.getPassenger();
-                                            if (!(passenger instanceof Player)) {
+                                            if (!(passenger instanceof Player) && entity.getMetadata("keep").isEmpty()) {
-                                                if (entity.getMetadata("keep").isEmpty()) {
+                                                iterator.remove();
-                                                    iter.remove();
+                                                entity.remove();
-                                                    entity.remove();
-                                                }
                                             }
                                         }
-                                    }
                                 }
                             }
-                        } catch (final Throwable e) {
+                        } catch (Throwable e) {
                             e.printStackTrace();
                         }
                     }
@@ -291,81 +337,87 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
             }
         }, 20);
     }
-    
+
     @Override
-    final public ChunkGenerator getDefaultWorldGenerator(final String world, final String id) {
+    public final ChunkGenerator getDefaultWorldGenerator(String world, String id) {
-        final HybridGen result = new HybridGen();
+        HybridGen result = new HybridGen();
         if (!PS.get().setupPlotWorld(world, id, result)) {
             return null;
         }
         return (ChunkGenerator) result.specify();
     }
-    
+
     @Override
     public void registerPlayerEvents() {
-        getServer().getPluginManager().registerEvents(new PlayerEvents(), this);
+        PlayerEvents main = new PlayerEvents();
+        getServer().getPluginManager().registerEvents(main, this);
         if (PS.get().checkVersion(getServerVersion(), 1, 8, 0)) {
             getServer().getPluginManager().registerEvents(new PlayerEvents_1_8(), this);
         }
         if (PS.get().checkVersion(getServerVersion(), 1, 8, 3)) {
-            getServer().getPluginManager().registerEvents(new PlayerEvents_1_8_3(), this);
+            getServer().getPluginManager().registerEvents(new PlayerEvents183(), this);
+        }
+        if (PS.get().checkVersion(getServerVersion(), 1, 9, 0)) {
+            getServer().getPluginManager().registerEvents(new PlayerEvents_1_9(main), this);
         }
     }
-    
+
     @Override
     public void registerInventoryEvents() {
         // Part of PlayerEvents - can be moved if necessary
     }
-    
+
     @Override
     public void registerPlotPlusEvents() {
         PlotPlusListener.startRunnable(this);
         getServer().getPluginManager().registerEvents(new PlotPlusListener(), this);
     }
-    
+
     @Override
     public void registerForceFieldEvents() {
         getServer().getPluginManager().registerEvents(new ForceFieldListener(), this);
     }
-    
+
     @Override
     public boolean initWorldEdit() {
         if (getServer().getPluginManager().getPlugin("WorldEdit") != null) {
-            BukkitMain.worldEdit = (WorldEditPlugin) getServer().getPluginManager().getPlugin("WorldEdit");
+            worldEdit = (WorldEditPlugin) getServer().getPluginManager().getPlugin("WorldEdit");
-            final String version = BukkitMain.worldEdit.getDescription().getVersion();
+            getServer().getPluginManager().registerEvents(new WEListener(), this);
-            if ((version != null) && version.startsWith("5.")) {
+            return true;
-                log("&cThis version of WorldEdit does not support PlotSquared.");
-                log("&cPlease use WorldEdit 6+ for masking support");
-                log("&c - http://builds.enginehub.org/job/worldedit");
-            } else {
-                getServer().getPluginManager().registerEvents(new WEListener(), this);
-                return true;
-            }
         }
         return false;
     }
-    
+
     @Override
     public EconHandler getEconomyHandler() {
         try {
-            final BukkitEconHandler econ = new BukkitEconHandler();
+            BukkitEconHandler econ = new BukkitEconHandler();
             if (econ.init()) {
                 return econ;
             }
-        } catch (final Throwable ignored) {
+        } catch (Throwable ignored) {
+            PS.debug("No economy detected!");
         }
         return null;
     }
-    
+
     @Override
     public PlotQueue initPlotQueue() {
         try {
             new SendChunk();
             MainUtil.canSendChunk = true;
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
             MainUtil.canSendChunk = false;
         }
+        if (PS.get().checkVersion(getServerVersion(), 1, 9, 0)) {
+            try {
+                return new FastQueue_1_9();
+            } catch (Throwable e) {
+                e.printStackTrace();
+                return new SlowQueue();
+            }
+        }
         if (PS.get().checkVersion(getServerVersion(), 1, 8, 0)) {
             try {
                 return new FastQueue_1_8_3();
@@ -386,12 +438,12 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
             return new SlowQueue();
         }
     }
-    
+
     @Override
     public WorldUtil initWorldUtil() {
         return new BukkitUtil();
     }
-    
+
     @Override
     public boolean initPlotMeConverter() {
         TaskManager.runTaskLaterAsync(new Runnable() {
@@ -408,17 +460,17 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
                 }
             }
         }, 20);
-        return (Bukkit.getPluginManager().getPlugin("PlotMe") != null) || (Bukkit.getPluginManager().getPlugin("AthionPlots") != null);
+        return Bukkit.getPluginManager().getPlugin("PlotMe") != null || Bukkit.getPluginManager().getPlugin("AthionPlots") != null;
     }
-    
+
     @Override
-    public GeneratorWrapper<?> getGenerator(final String world, final String name) {
+    public GeneratorWrapper<?> getGenerator(String world, String name) {
         if (name == null) {
             return null;
         }
-        final Plugin gen_plugin = Bukkit.getPluginManager().getPlugin(name);
+        Plugin genPlugin = Bukkit.getPluginManager().getPlugin(name);
-        if ((gen_plugin != null) && gen_plugin.isEnabled()) {
+        if (genPlugin != null && genPlugin.isEnabled()) {
-            ChunkGenerator gen = gen_plugin.getDefaultWorldGenerator(world, "");
+            ChunkGenerator gen = genPlugin.getDefaultWorldGenerator(world, "");
             if (gen instanceof GeneratorWrapper<?>) {
                 return (GeneratorWrapper<?>) gen;
             }
@@ -427,199 +479,172 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
             return new BukkitPlotGenerator(new HybridGen());
         }
     }
-    
+
     @Override
     public HybridUtils initHybridUtils() {
         return new BukkitHybridUtils();
     }
-    
+
     @Override
     public SetupUtils initSetupUtils() {
         return new BukkitSetupUtils();
     }
-    
+
     @Override
     public UUIDHandlerImplementation initUUIDHandler() {
-        final boolean checkVersion = PS.get().checkVersion(getServerVersion(), 1, 7, 6);
+        boolean checkVersion = PS.get().checkVersion(getServerVersion(), 1, 7, 6);
         UUIDWrapper wrapper;
         if (Settings.OFFLINE_MODE) {
             if (Settings.UUID_LOWERCASE) {
-                wrapper = (new LowerOfflineUUIDWrapper());
+                wrapper = new LowerOfflineUUIDWrapper();
             } else {
-                wrapper = (new OfflineUUIDWrapper());
+                wrapper = new OfflineUUIDWrapper();
             }
             Settings.OFFLINE_MODE = true;
         } else if (checkVersion) {
-            wrapper = (new DefaultUUIDWrapper());
+            wrapper = new DefaultUUIDWrapper();
             Settings.OFFLINE_MODE = false;
         } else {
             if (Settings.UUID_LOWERCASE) {
-                wrapper = (new LowerOfflineUUIDWrapper());
+                wrapper = new LowerOfflineUUIDWrapper();
             } else {
-                wrapper = (new OfflineUUIDWrapper());
+                wrapper = new OfflineUUIDWrapper();
             }
             Settings.OFFLINE_MODE = true;
         }
         if (!checkVersion) {
-            log(C.PREFIX.s() + " &c[WARN] Titles are disabled - please update your version of Bukkit to support this feature.");
+            log(C.PREFIX + " &c[WARN] Titles are disabled - please update your version of Bukkit to support this feature.");
             Settings.TITLES = false;
             FlagManager.removeFlag(FlagManager.getFlag("titles"));
         } else {
-            AbstractTitle.TITLE_CLASS = new DefaultTitle();
+            AbstractTitle.TITLE_CLASS = new DefaultTitle_19();
             if (wrapper instanceof DefaultUUIDWrapper || wrapper.getClass() == OfflineUUIDWrapper.class && !Bukkit.getOnlineMode()) {
                 Settings.TWIN_MODE_UUID = true;
             }
         }
         if (Settings.OFFLINE_MODE) {
-            log(C.PREFIX.s() + " &6PlotSquared is using Offline Mode UUIDs either because of user preference, or because you are using an old version of Bukkit");
+            log(C.PREFIX
+                    + " &6PlotSquared is using Offline Mode UUIDs either because of user preference, or because you are using an old version of "
+                    + "Bukkit");
         } else {
-            log(C.PREFIX.s() + " &6PlotSquared is using online UUIDs");
+            log(C.PREFIX + " &6PlotSquared is using online UUIDs");
+        }
+        if (Settings.USE_SQLUUIDHANDLER) {
+            return new SQLUUIDHandler(wrapper);
+        } else {
+            return new FileUUIDHandler(wrapper);
         }
-        return Settings.USE_SQLUUIDHANDLER ? new SQLUUIDHandler(wrapper) : new FileUUIDHandler(wrapper);
     }
-    
+
     @Override
     public ChunkManager initChunkManager() {
         return new BukkitChunkManager();
     }
-    
+
     @Override
     public EventUtil initEventUtil() {
         return new BukkitEventUtil();
     }
-    
+
     @Override
-    public void unregister(final PlotPlayer player) {
+    public void unregister(PlotPlayer player) {
         BukkitUtil.removePlayer(player.getName());
     }
-    
+
     @Override
     public void registerChunkProcessor() {
         getServer().getPluginManager().registerEvents(new ChunkListener(), this);
     }
-    
+
     @Override
     public void registerWorldEvents() {
         getServer().getPluginManager().registerEvents(new WorldEvents(), this);
     }
-    
+
     @Override
     public InventoryUtil initInventoryUtil() {
         return new BukkitInventoryUtil();
     }
-    
+
     @Override
     public String getServerName() {
         return Bukkit.getServerName();
     }
-    
+
     @Override
     public void startMetrics() {
-        try {
+        Metrics metrics = new Metrics(this);
-            final Metrics metrics = new Metrics(this);
+        metrics.start();
-            metrics.start();
+        log(C.PREFIX + "&6Metrics enabled.");
-            log(C.PREFIX.s() + "&6Metrics enabled.");
-        } catch (IOException e) {
-            log(C.PREFIX.s() + "&cFailed to load up metrics.");
-        }
     }
-    
+
     @Override
-    public void setGenerator(final String worldname) {
+    public void setGenerator(String worldName) {
-        World world = BukkitUtil.getWorld(worldname);
+        World world = BukkitUtil.getWorld(worldName);
         if (world == null) {
             // create world
-            final ConfigurationSection worldConfig = PS.get().config.getConfigurationSection("worlds." + worldname);
+            ConfigurationSection worldConfig = PS.get().config.getConfigurationSection("worlds." + worldName);
-            String manager = worldConfig.getString("generator.plugin");
+            String manager = worldConfig.getString("generator.plugin", "PlotSquared");
-            if (manager == null) {
+            SetupObject setup = new SetupObject();
-                manager = "PlotSquared";
-            }
-            String generator = worldConfig.getString("generator.init");
-            if (generator == null) {
-                generator = manager;
-            }
-            
-            final int type = worldConfig.getInt("generator.type");
-            final int terrain = worldConfig.getInt("generator.terrain");
-            final SetupObject setup = new SetupObject();
             setup.plotManager = manager;
-            setup.setupGenerator = generator;
+            setup.setupGenerator = worldConfig.getString("generator.init", manager);
-            setup.type = type;
+            setup.type = worldConfig.getInt("generator.type");
-            setup.terrain = terrain;
+            setup.terrain = worldConfig.getInt("generator.terrain");
             setup.step = new ConfigurationNode[0];
-            setup.world = worldname;
+            setup.world = worldName;
             SetupUtils.manager.setupWorld(setup);
         } else {
             try {
-                if (!PS.get().hasPlotArea(worldname)) {
+                if (!PS.get().hasPlotArea(worldName)) {
-                    SetGenCB.setGenerator(BukkitUtil.getWorld(worldname));
+                    SetGenCB.setGenerator(BukkitUtil.getWorld(worldName));
                 }
-            } catch (final Exception e) {
+            } catch (Exception e) {
                 log("Failed to reload world: " + world);
                 Bukkit.getServer().unloadWorld(world, false);
             }
         }
-        world = Bukkit.getWorld(worldname);
+        world = Bukkit.getWorld(worldName);
-        final ChunkGenerator gen = world.getGenerator();
+        ChunkGenerator gen = world.getGenerator();
         if (gen instanceof BukkitPlotGenerator) {
-            PS.get().loadWorld(worldname, (BukkitPlotGenerator) gen);
+            PS.get().loadWorld(worldName, (BukkitPlotGenerator) gen);
         } else if (gen != null) {
-            PS.get().loadWorld(worldname, new BukkitPlotGenerator(worldname, gen));
+            PS.get().loadWorld(worldName, new BukkitPlotGenerator(worldName, gen));
-        } else {
+        } else if (PS.get().config.contains("worlds." + worldName)) {
-            if (PS.get().config.contains("worlds." + worldname)) {
+            PS.get().loadWorld(worldName, null);
-                PS.get().loadWorld(worldname, null);
-            }
         }
     }
-    
+
     @Override
     public SchematicHandler initSchematicHandler() {
         return new BukkitSchematicHandler();
     }
-    
+
     @Override
     public AbstractTitle initTitleManager() {
         // Already initialized in UUID handler
         return AbstractTitle.TITLE_CLASS;
     }
-    
+
     @Override
-    public PlotPlayer wrapPlayer(final Object obj) {
+    public PlotPlayer wrapPlayer(Object player) {
-        if (obj instanceof Player) {
+        if (player instanceof Player) {
-            return BukkitUtil.getPlayer((Player) obj);
+            return BukkitUtil.getPlayer((Player) player);
-        } else if (obj instanceof OfflinePlayer) {
+        } else if (player instanceof OfflinePlayer) {
-            return BukkitUtil.getPlayer((OfflinePlayer) obj);
+            return BukkitUtil.getPlayer((OfflinePlayer) player);
-        } else if (obj instanceof String) {
+        } else if (player instanceof String) {
-            return UUIDHandler.getPlayer((String) obj);
+            return UUIDHandler.getPlayer((String) player);
-        } else if (obj instanceof UUID) {
+        } else if (player instanceof UUID) {
-            return UUIDHandler.getPlayer((UUID) obj);
+            return UUIDHandler.getPlayer((UUID) player);
         }
         return null;
     }
-    
+
     @Override
     public String getNMSPackage() {
-        final Server server = Bukkit.getServer();
+        String name = Bukkit.getServer().getClass().getPackage().getName();
-        final Class<?> bukkitServerClass = server.getClass();
+        return name.substring(name.lastIndexOf('.') + 1);
-        String[] pas = bukkitServerClass.getName().split("\\.");
-        if (pas.length == 5) {
-            return pas[3];
-        }
-        try {
-            final Method getHandle = bukkitServerClass.getDeclaredMethod("getHandle");
-            final Object handle = getHandle.invoke(server);
-            final Class handleServerClass = handle.getClass();
-            pas = handleServerClass.getName().split("\\.");
-            if (pas.length == 5) {
-                return pas[3];
-            }
-        } catch (IllegalAccessException | InvocationTargetException | SecurityException | NoSuchMethodException | IllegalArgumentException e) {
-            e.printStackTrace();
-        }
-        PS.debug("Unknown NMS package: " + StringMan.getString(pas));
-        return "1_8_R3";
     }
-    
+
     @Override
     public ChatManager<?> initChatManager() {
         if (Settings.FANCY_CHAT) {
@@ -628,12 +653,12 @@ public class BukkitMain extends JavaPlugin implements Listener, IPlotMain {
             return new BukkitPlainChatManager();
         }
     }
-    
+
     @Override
     public GeneratorWrapper<?> wrapPlotGenerator(IndependentPlotGenerator generator) {
         return new BukkitPlotGenerator(generator);
     }
-    
+
     @Override
     public List<String> getPluginIds() {
         ArrayList<String> names = new ArrayList<>();

Bukkit/src/main/java/com/plotsquared/bukkit/chat/ArrayWrapper.java

@@ -1,11 +1,11 @@
 package com.plotsquared.bukkit.chat;
 
+import org.apache.commons.lang.Validate;
+
 import java.lang.reflect.Array;
 import java.util.Arrays;
 import java.util.Collection;
 
-import org.apache.commons.lang.Validate;
-
 /**
  * Represents a wrapper around an array class of an arbitrary reference type,
  * which properly implements "value" hash code and equality functions.
@@ -17,57 +17,17 @@ import org.apache.commons.lang.Validate;
  * @see Arrays
  */
 public final class ArrayWrapper<E> {
-    
+
+    private E[] array;
+
     /**
      * Creates an array wrapper with some elements.
      * @param elements The elements of the array.
      */
-    public ArrayWrapper(final E... elements) {
+    public ArrayWrapper(E... elements) {
         setArray(elements);
     }
-    
+
-    private E[] _array;
-    
-    /**
-     * Retrieves a reference to the wrapped array instance.
-     * @return The array wrapped by this instance.
-     */
-    public E[] getArray() {
-        return _array;
-    }
-    
-    /**
-     * Set this wrapper to wrap a new array instance.
-     * @param array The new wrapped array.
-     */
-    public void setArray(final E[] array) {
-        Validate.notNull(array, "The array must not be null.");
-        _array = array;
-    }
-    
-    /**
-     * Determines if this object has a value equivalent to another object.
-     * @see Arrays#equals(Object[], Object[])
-     */
-    @SuppressWarnings("rawtypes")
-    @Override
-    public boolean equals(final Object other) {
-        if (!(other instanceof ArrayWrapper)) {
-            return false;
-        }
-        return Arrays.equals(_array, ((ArrayWrapper) other)._array);
-    }
-    
-    /**
-     * Gets the hash code represented by this objects value.
-     * @see Arrays#hashCode(Object[])
-     * @return This object's hash code.
-     */
-    @Override
-    public int hashCode() {
-        return Arrays.hashCode(_array);
-    }
-    
     /**
      * Converts an iterable element collection to an array of elements.
      * The iteration order of the specified object will be used as the array element order.
@@ -76,28 +36,66 @@ public final class ArrayWrapper<E> {
      * @return An array of elements in the specified iterable.
      */
     @SuppressWarnings("unchecked")
-    public static <T> T[] toArray(final Iterable<? extends T> list, final Class<T> c) {
+    public static <T> T[] toArray(Iterable<? extends T> list, Class<T> c) {
         int size = -1;
         if (list instanceof Collection<?>) {
-            @SuppressWarnings("rawtypes")
+            @SuppressWarnings("rawtypes") Collection coll = (Collection) list;
-            final Collection coll = (Collection) list;
             size = coll.size();
         }
-        
+
         if (size < 0) {
             size = 0;
             // Ugly hack: Count it ourselves
-            for (@SuppressWarnings("unused")
+            for (@SuppressWarnings("unused") T element : list) {
-            final T element : list) {
                 size++;
             }
         }
-        
+
-        final T[] result = (T[]) Array.newInstance(c, size);
+        T[] result = (T[]) Array.newInstance(c, size);
         int i = 0;
-        for (final T element : list) { // Assumes iteration order is consistent
+        for (T element : list) { // Assumes iteration order is consistent
             result[i++] = element; // Assign array element at index THEN increment counter
         }
         return result;
     }
+
+    /**
+     * Retrieves a reference to the wrapped array instance.
+     * @return The array wrapped by this instance.
+     */
+    public E[] getArray() {
+        return this.array;
+    }
+
+    /**
+     * Set this wrapper to wrap a new array instance.
+     * @param array The new wrapped array.
+     */
+    public void setArray(E[] array) {
+        Validate.notNull(array, "The array must not be null.");
+        this.array = array;
+    }
+
+    /**
+     * Determines if this object has a value equivalent to another object.
+     * @see Arrays#equals(Object[], Object[])
+     */
+    @SuppressWarnings("rawtypes")
+    @Override
+    public boolean equals(Object other) {
+        if (!(other instanceof ArrayWrapper)) {
+            return false;
+        }
+        return Arrays.equals(this.array, ((ArrayWrapper) other).array);
+    }
+
+    /**
+     * Gets the hash code represented by this objects value.
+     * @see Arrays#hashCode(Object[])
+     * @return This object's hash code.
+     */
+    @Override
+    public int hashCode() {
+        return Arrays.hashCode(this.array);
+    }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/chat/JsonRepresentedObject.java

@@ -1,19 +1,19 @@
 package com.plotsquared.bukkit.chat;
 
-import java.io.IOException;
-
 import com.google.gson.stream.JsonWriter;
 
+import java.io.IOException;
+
 /**
  * Represents an object that can be serialized to a JSON writer instance.
  */
 interface JsonRepresentedObject {
-    
+
     /**
      * Writes the JSON representation of this object to the specified writer.
      * @param writer The JSON writer which will receive the object.
      * @throws IOException If an error occurs writing to the stream.
      */
-    void writeJson(final JsonWriter writer) throws IOException;
+    void writeJson(JsonWriter writer) throws IOException;
-    
+
 }

Bukkit/src/main/java/com/plotsquared/bukkit/chat/JsonString.java

@@ -1,47 +1,47 @@
 package com.plotsquared.bukkit.chat;
 
+import com.google.gson.stream.JsonWriter;
+import com.intellectualcrafters.configuration.serialization.ConfigurationSerializable;
+
 import java.io.IOException;
 import java.util.HashMap;
 import java.util.Map;
 
-import com.google.gson.stream.JsonWriter;
-import com.intellectualcrafters.configuration.serialization.ConfigurationSerializable;
-
 /**
  * Represents a JSON string value.
  * Writes by this object will not write name values nor begin/end objects in the JSON stream.
  * All writes merely write the represented string value.
  */
 final class JsonString implements JsonRepresentedObject, ConfigurationSerializable {
-    
+
-    private final String _value;
+    private final String value;
-    
+
-    public JsonString(final CharSequence value) {
+    public JsonString(CharSequence value) {
-        _value = value == null ? null : value.toString();
+        this.value = value == null ? null : value.toString();
     }
-    
+
-    @Override
+    public static JsonString deserialize(Map<String, Object> map) {
-    public void writeJson(final JsonWriter writer) throws IOException {
-        writer.value(getValue());
-    }
-    
-    public String getValue() {
-        return _value;
-    }
-    
-    @Override
-    public Map<String, Object> serialize() {
-        final HashMap<String, Object> theSingleValue = new HashMap<String, Object>();
-        theSingleValue.put("stringValue", _value);
-        return theSingleValue;
-    }
-    
-    public static JsonString deserialize(final Map<String, Object> map) {
         return new JsonString(map.get("stringValue").toString());
     }
-    
+
+    @Override
+    public void writeJson(JsonWriter writer) throws IOException {
+        writer.value(getValue());
+    }
+
+    public String getValue() {
+        return this.value;
+    }
+
+    @Override
+    public Map<String, Object> serialize() {
+        HashMap<String, Object> theSingleValue = new HashMap<>();
+        theSingleValue.put("stringValue", this.value);
+        return theSingleValue;
+    }
+
     @Override
     public String toString() {
-        return _value;
+        return this.value;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/chat/MessagePart.java

@@ -22,8 +22,8 @@ final class MessagePart implements JsonRepresentedObject, ConfigurationSerializa
     static final BiMap<ChatColor, String> stylesToNames;
 
     static {
-        final ImmutableBiMap.Builder<ChatColor, String> builder = ImmutableBiMap.builder();
+        ImmutableBiMap.Builder<ChatColor, String> builder = ImmutableBiMap.builder();
-        for (final ChatColor style : ChatColor.values()) {
+        for (ChatColor style : ChatColor.values()) {
             if (!style.isFormat()) {
                 continue;
             }
@@ -51,24 +51,24 @@ final class MessagePart implements JsonRepresentedObject, ConfigurationSerializa
     }
 
     ChatColor color = ChatColor.WHITE;
-    ArrayList<ChatColor> styles = new ArrayList<ChatColor>();
+    ArrayList<ChatColor> styles = new ArrayList<>();
     String clickActionName = null, clickActionData = null, hoverActionName = null;
     JsonRepresentedObject hoverActionData = null;
     TextualComponent text = null;
     String insertionData = null;
-    ArrayList<JsonRepresentedObject> translationReplacements = new ArrayList<JsonRepresentedObject>();
+    ArrayList<JsonRepresentedObject> translationReplacements = new ArrayList<>();
-    
+
-    MessagePart(final TextualComponent text) {
+    MessagePart(TextualComponent text) {
         this.text = text;
     }
-    
+
     MessagePart() {
-        text = null;
+        this.text = null;
     }
 
     @SuppressWarnings("unchecked")
-    public static MessagePart deserialize(final Map<String, Object> serialized) {
+    public static MessagePart deserialize(Map<String, Object> serialized) {
-        final MessagePart part = new MessagePart((TextualComponent) serialized.get("text"));
+        MessagePart part = new MessagePart((TextualComponent) serialized.get("text"));
         part.styles = (ArrayList<ChatColor>) serialized.get("styles");
         part.color = ChatColor.getByChar(serialized.get("color").toString());
         part.hoverActionName = (String) serialized.get("hoverActionName");
@@ -81,70 +81,71 @@ final class MessagePart implements JsonRepresentedObject, ConfigurationSerializa
     }
 
     boolean hasText() {
-        return text != null;
+        return this.text != null;
     }
-    
+
     @Override
     @SuppressWarnings("unchecked")
     public MessagePart clone() throws CloneNotSupportedException {
-        final MessagePart obj = (MessagePart) super.clone();
+        MessagePart obj = (MessagePart) super.clone();
-        obj.styles = (ArrayList<ChatColor>) styles.clone();
+        obj.styles = (ArrayList<ChatColor>) this.styles.clone();
-        if (hoverActionData instanceof JsonString) {
+        if (this.hoverActionData instanceof JsonString) {
-            obj.hoverActionData = new JsonString(((JsonString) hoverActionData).getValue());
+            obj.hoverActionData = new JsonString(((JsonString) this.hoverActionData).getValue());
-        } else if (hoverActionData instanceof FancyMessage) {
+        } else if (this.hoverActionData instanceof FancyMessage) {
-            obj.hoverActionData = ((FancyMessage) hoverActionData).clone();
+            obj.hoverActionData = ((FancyMessage) this.hoverActionData).clone();
         }
-        obj.translationReplacements = (ArrayList<JsonRepresentedObject>) translationReplacements.clone();
+        obj.translationReplacements = (ArrayList<JsonRepresentedObject>) this.translationReplacements.clone();
         return obj;
 
     }
-    
+
     @Override
-    public void writeJson(final JsonWriter json) {
+    public void writeJson(JsonWriter json) {
         try {
             json.beginObject();
-            text.writeJson(json);
+            this.text.writeJson(json);
-            json.name("color").value(color.name().toLowerCase());
+            json.name("color").value(this.color.name().toLowerCase());
-            for (final ChatColor style : styles) {
+            for (ChatColor style : this.styles) {
                 json.name(stylesToNames.get(style)).value(true);
             }
-            if ((clickActionName != null) && (clickActionData != null)) {
+            if ((this.clickActionName != null) && (this.clickActionData != null)) {
-                json.name("clickEvent").beginObject().name("action").value(clickActionName).name("value").value(clickActionData).endObject();
+                json.name("clickEvent").beginObject().name("action").value(this.clickActionName).name("value").value(this.clickActionData)
+                        .endObject();
             }
-            if ((hoverActionName != null) && (hoverActionData != null)) {
+            if ((this.hoverActionName != null) && (this.hoverActionData != null)) {
-                json.name("hoverEvent").beginObject().name("action").value(hoverActionName).name("value");
+                json.name("hoverEvent").beginObject().name("action").value(this.hoverActionName).name("value");
-                hoverActionData.writeJson(json);
+                this.hoverActionData.writeJson(json);
                 json.endObject();
             }
-            if (insertionData != null) {
+            if (this.insertionData != null) {
-                json.name("insertion").value(insertionData);
+                json.name("insertion").value(this.insertionData);
             }
-            if ((!translationReplacements.isEmpty()) && (text != null) && TextualComponent.isTranslatableText(text)) {
+            if (!this.translationReplacements.isEmpty() && (this.text != null) && TextualComponent.isTranslatableText(this.text)) {
                 json.name("with").beginArray();
-                for (final JsonRepresentedObject obj : translationReplacements) {
+                for (JsonRepresentedObject obj : this.translationReplacements) {
                     obj.writeJson(json);
                 }
                 json.endArray();
             }
             json.endObject();
-        } catch (final IOException e) {
+        } catch (IOException e) {
             Bukkit.getLogger().log(Level.WARNING, "A problem occurred during writing of JSON string", e);
         }
     }
-    
+
     @Override
     public Map<String, Object> serialize() {
-        final HashMap<String, Object> map = new HashMap<String, Object>();
+        HashMap<String, Object> map = new HashMap<>();
-        map.put("text", text);
+        map.put("text", this.text);
-        map.put("styles", styles);
+        map.put("styles", this.styles);
-        map.put("color", color.getChar());
+        map.put("color", this.color.getChar());
-        map.put("hoverActionName", hoverActionName);
+        map.put("hoverActionName", this.hoverActionName);
-        map.put("hoverActionData", hoverActionData);
+        map.put("hoverActionData", this.hoverActionData);
-        map.put("clickActionName", clickActionName);
+        map.put("clickActionName", this.clickActionName);
-        map.put("clickActionData", clickActionData);
+        map.put("clickActionData", this.clickActionData);
-        map.put("insertion", insertionData);
+        map.put("insertion", this.insertionData);
-        map.put("translationReplacements", translationReplacements);
+        map.put("translationReplacements", this.translationReplacements);
         return map;
     }
-    
+
 }

Bukkit/src/main/java/com/plotsquared/bukkit/chat/Reflection.java

@@ -1,6 +1,6 @@
 package com.plotsquared.bukkit.chat;
 
-import org.bukkit.Bukkit;
+import com.intellectualcrafters.plot.PS;
 
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
@@ -29,42 +29,29 @@ public final class Reflection {
      * The map maps [types to maps of [method names to maps of [parameter types to method instances]]].
      */
     private static final Map<Class<?>, Map<String, Map<ArrayWrapper<Class<?>>, Method>>> _loadedMethods = new HashMap<>();
-    private static String _versionString;
 
-    private Reflection() {
-
-    }
-    
     /**
      * Gets the version string from the package name of the CraftBukkit server implementation.
      * This is needed to bypass the JAR package name changing on each update.
      * @return The version string of the OBC and NMS packages, <em>including the trailing dot</em>.
      */
-    public synchronized static String getVersion() {
+    public static synchronized String getVersion() {
-        if (_versionString == null) {
+        return PS.get().IMP.getNMSPackage();
-            if (Bukkit.getServer() == null) {
-                // The server hasn't started, static initializer call?
-                return null;
-            }
-            final String name = Bukkit.getServer().getClass().getPackage().getName();
-            _versionString = name.substring(name.lastIndexOf('.') + 1) + ".";
-        }
-
-        return _versionString;
     }
-    
+
     /**
      * Gets a {@link Class} object representing a type contained within the {@code net.minecraft.server} versioned package.
-     * The class instances returned by this method are cached, such that no lookup will be done twice (unless multiple threads are accessing this method simultaneously).
+     * The class instances returned by this method are cached, such that no lookup will be done twice (unless multiple threads are accessing this
+     * method simultaneously).
      * @param className The name of the class, excluding the package, within NMS.
      * @return The class instance representing the specified NMS class, or {@code null} if it could not be loaded.
      */
-    public synchronized static Class<?> getNMSClass(final String className) {
+    public static synchronized Class<?> getNMSClass(String className) {
         if (_loadedNMSClasses.containsKey(className)) {
             return _loadedNMSClasses.get(className);
         }
 
-        final String fullName = "net.minecraft.server." + getVersion() + className;
+        String fullName = "net.minecraft.server." + getVersion() + "." + className;
         Class<?> clazz;
         try {
             clazz = Class.forName(fullName);
@@ -76,7 +63,7 @@ public final class Reflection {
         _loadedNMSClasses.put(className, clazz);
         return clazz;
     }
-    
+
     /**
      * Gets a {@link Class} object representing a type contained within the {@code org.bukkit.craftbukkit} versioned package.
      * The class instances returned by this method are cached, such that no lookup will be done twice (unless multiple threads are accessing this
@@ -85,12 +72,12 @@ public final class Reflection {
      * .CraftItemStack}.
      * @return The class instance representing the specified OBC class, or {@code null} if it could not be loaded.
      */
-    public synchronized static Class<?> getOBCClass(final String className) {
+    public static synchronized Class<?> getOBCClass(String className) {
         if (_loadedOBCClasses.containsKey(className)) {
             return _loadedOBCClasses.get(className);
         }
 
-        final String fullName = "org.bukkit.craftbukkit." + getVersion() + className;
+        String fullName = "org.bukkit.craftbukkit." + getVersion() + "." + className;
         Class<?> clazz;
         try {
             clazz = Class.forName(fullName);
@@ -102,7 +89,7 @@ public final class Reflection {
         _loadedOBCClasses.put(className, clazz);
         return clazz;
     }
-    
+
     /**
      * Attempts to get the NMS handle of a CraftBukkit object.
      * <p>
@@ -112,25 +99,20 @@ public final class Reflection {
      * @param obj The object for which to retrieve an NMS handle.
      * @return The NMS handle of the specified object, or {@code null} if it could not be retrieved using {@code getHandle()}.
      */
-    public synchronized static Object getHandle(final Object obj) {
+    public static synchronized Object getHandle(Object obj) {
         try {
             return getMethod(obj.getClass(), "getHandle").invoke(obj);
-        } catch (IllegalAccessException e) {
+        } catch (IllegalAccessException | InvocationTargetException | IllegalArgumentException e) {
-            e.printStackTrace();
-            return null;
-        } catch (IllegalArgumentException e) {
-            e.printStackTrace();
-            return null;
-        } catch (InvocationTargetException e) {
             e.printStackTrace();
             return null;
         }
     }
-    
+
     /**
      * Retrieves a {@link Field} instance declared by the specified class with the specified name.
-     * Java access modifiers are ignored during this retrieval. No guarantee is made as to whether the field
+     * Java access modifiers are ignored during this retrieval.
-     * returned will be an instance or static field.
+     * No guarantee is made as to whether the field returned will be an
+     * instance or static field.
      * <p>
      * A global caching mechanism within this class is used to store fields. Combined with synchronization, this guarantees that
      * no field will be reflectively looked up twice.
@@ -145,7 +127,7 @@ public final class Reflection {
      * @return A field object with the specified name declared by the specified class.
      * @see Class#getDeclaredField(String)
      */
-    public synchronized static Field getField(final Class<?> clazz, final String name) {
+    public static synchronized Field getField(Class<?> clazz, String name) {
         Map<String, Field> loaded;
         if (!_loadedFields.containsKey(clazz)) {
             loaded = new HashMap<>();
@@ -158,17 +140,11 @@ public final class Reflection {
             return loaded.get(name);
         }
         try {
-            final Field field = clazz.getDeclaredField(name);
+            Field field = clazz.getDeclaredField(name);
             field.setAccessible(true);
             loaded.put(name, field);
             return field;
-        } catch (NoSuchFieldException e) {
+        } catch (NoSuchFieldException | SecurityException e) {
-            // Error loading
-            e.printStackTrace();
-            // Cache field as not existing
-            loaded.put(name, null);
-            return null;
-        } catch (SecurityException e) {
             // Error loading
             e.printStackTrace();
             // Cache field as not existing
@@ -176,7 +152,7 @@ public final class Reflection {
             return null;
         }
     }
-    
+
     /**
      * Retrieves a {@link Method} instance declared by the specified class with the specified name and argument types.
      * Java access modifiers are ignored during this retrieval. No guarantee is made as to whether the field
@@ -186,9 +162,11 @@ public final class Reflection {
      * no method will be reflectively looked up twice.
      * </p>
      * <p>
-     * If a method is deemed suitable for return, {@link Method#setAccessible(boolean) setAccessible} will be invoked with an argument of {@code true} before it is returned.
+     * If a method is deemed suitable for return, {@link Method#setAccessible(boolean) setAccessible} will be invoked with an argument of {@code
+     * true} before it is returned.
      * This ensures that callers do not have to check or worry about Java access modifiers when dealing with the returned instance.
      * </p>
+     *
      * <p>
      * This method does <em>not</em> search superclasses of the specified type for methods with the specified signature.
      * Callers wishing this behavior should use {@link Class#getDeclaredMethod(String, Class...)}.
@@ -197,23 +175,23 @@ public final class Reflection {
      * @param args The formal argument types of the method.
      * @return A method object with the specified name declared by the specified class.
      */
-    public synchronized static Method getMethod(final Class<?> clazz, final String name, final Class<?>... args) {
+    public static synchronized Method getMethod(Class<?> clazz, String name, Class<?>... args) {
         if (!_loadedMethods.containsKey(clazz)) {
             _loadedMethods.put(clazz, new HashMap<String, Map<ArrayWrapper<Class<?>>, Method>>());
         }
-        
+
-        final Map<String, Map<ArrayWrapper<Class<?>>, Method>> loadedMethodNames = _loadedMethods.get(clazz);
+        Map<String, Map<ArrayWrapper<Class<?>>, Method>> loadedMethodNames = _loadedMethods.get(clazz);
         if (!loadedMethodNames.containsKey(name)) {
             loadedMethodNames.put(name, new HashMap<ArrayWrapper<Class<?>>, Method>());
         }
-        
+
-        final Map<ArrayWrapper<Class<?>>, Method> loadedSignatures = loadedMethodNames.get(name);
+        Map<ArrayWrapper<Class<?>>, Method> loadedSignatures = loadedMethodNames.get(name);
-        final ArrayWrapper<Class<?>> wrappedArg = new ArrayWrapper<>(args);
+        ArrayWrapper<Class<?>> wrappedArg = new ArrayWrapper<>(args);
         if (loadedSignatures.containsKey(wrappedArg)) {
             return loadedSignatures.get(wrappedArg);
         }
-        
+
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
             if (m.getName().equals(name) && Arrays.equals(args, m.getParameterTypes())) {
                 m.setAccessible(true);
                 loadedSignatures.put(wrappedArg, m);
@@ -223,5 +201,5 @@ public final class Reflection {
         loadedSignatures.put(wrappedArg, null);
         return null;
     }
-    
+
 }

Bukkit/src/main/java/com/plotsquared/bukkit/chat/TextualComponent.java

@@ -23,6 +23,107 @@ public abstract class TextualComponent implements Cloneable {
         ConfigurationSerialization.registerClass(TextualComponent.ComplexTextTypeComponent.class);
     }
 
+    static TextualComponent deserialize(Map<String, Object> map) {
+        if (map.containsKey("key") && (map.size() == 2) && map.containsKey("value")) {
+            // Arbitrary text component
+            return ArbitraryTextTypeComponent.deserialize(map);
+        } else if ((map.size() >= 2) && map.containsKey("key") && !map.containsKey("value") /* It contains keys that START WITH value */) {
+            // Complex JSON object
+            return ComplexTextTypeComponent.deserialize(map);
+        }
+
+        return null;
+    }
+
+    static boolean isTextKey(String key) {
+        return key.equals("translate") || key.equals("text") || key.equals("score") || key.equals("selector");
+    }
+
+    static boolean isTranslatableText(TextualComponent component) {
+        return (component instanceof ComplexTextTypeComponent) && component.getKey().equals("translate");
+    }
+
+    /**
+     * Create a textual component representing a string literal.
+     * This is the default type of textual component when a single string literal is given to a method.
+     * @param textValue The text which will be represented.
+     * @return The text component representing the specified literal text.
+     */
+    public static TextualComponent rawText(String textValue) {
+        return new ArbitraryTextTypeComponent("text", textValue);
+    }
+
+    /**
+     * Create a textual component representing a localized string.
+     * The client will see this text component as their localized version of the specified string <em>key</em>, which can be overridden by a
+     * resource pack.
+     * <p>
+     * If the specified translation key is not present on the client resource pack, the translation key will be displayed as a string literal to
+     * the client.
+     * </p>
+     * @param translateKey The string key which maps to localized text.
+     * @return The text component representing the specified localized text.
+     */
+    public static TextualComponent localizedText(String translateKey) {
+        return new ArbitraryTextTypeComponent("translate", translateKey);
+    }
+
+    private static void throwUnsupportedSnapshot() {
+        throw new UnsupportedOperationException("This feature is only supported in snapshot releases.");
+    }
+
+    /**
+     * Create a textual component representing a scoreboard value.
+     * The client will see their own score for the specified objective as the text represented by this component.
+     * <p>
+     * <b>This method is currently guaranteed to throw an {@code UnsupportedOperationException} as it is only supported on snapshot clients.</b>
+     * </p>
+     * @param scoreboardObjective The name of the objective for which to display the score.
+     * @return The text component representing the specified scoreboard score (for the viewing player), or {@code null} if an error occurs during
+     * JSON serialization.
+     */
+    public static TextualComponent objectiveScore(String scoreboardObjective) {
+        return objectiveScore("*", scoreboardObjective);
+    }
+
+    /**
+     * Create a textual component representing a scoreboard value.
+     * The client will see the score of the specified player for the specified objective as the text represented by this component.
+     * <p>
+     * <b>This method is currently guaranteed to throw an {@code UnsupportedOperationException} as it is only supported on snapshot clients.</b>
+     * </p>
+     * @param playerName The name of the player whos score will be shown. If this string represents the single-character sequence "*", the viewing
+     * player's score will be displayed.
+     * Standard minecraft selectors (@a, @p, etc) are <em>not</em> supported.
+     * @param scoreboardObjective The name of the objective for which to display the score.
+     * @return The text component representing the specified scoreboard score for the specified player, or {@code null} if an error occurs during
+     * JSON serialization.
+     */
+    public static TextualComponent objectiveScore(String playerName, String scoreboardObjective) {
+        throwUnsupportedSnapshot(); // Remove this line when the feature is released to non-snapshot versions, in addition to updating ALL THE
+        // OVERLOADS documentation accordingly
+
+        return new ComplexTextTypeComponent("score",
+                ImmutableMap.<String, String>builder().put("name", playerName).put("objective", scoreboardObjective).build());
+    }
+
+    /**
+     * Create a textual component representing a player name, retrievable by using a standard minecraft selector.
+     * The client will see the players or entities captured by the specified selector as the text represented by this component.
+     * <p>
+     * <b>This method is currently guaranteed to throw an {@code UnsupportedOperationException} as it is only supported on snapshot clients.</b>
+     * </p>
+     * @param selector The minecraft player or entity selector which will capture the entities whose string representations will be displayed in
+     * the place of this text component.
+     * @return The text component representing the name of the entities captured by the selector.
+     */
+    public static TextualComponent selector(String selector) {
+        throwUnsupportedSnapshot(); // Remove this line when the feature is released to non-snapshot versions, in addition to updating ALL THE
+        // OVERLOADS documentation accordingly
+
+        return new ArbitraryTextTypeComponent("selector", selector);
+    }
+
     @Override
     public String toString() {
         return getReadableString();
@@ -51,27 +152,7 @@ public abstract class TextualComponent implements Cloneable {
      * @param writer The object to which to write the JSON data.
      * @throws IOException If an error occurs while writing to the stream.
      */
-    public abstract void writeJson(final JsonWriter writer) throws IOException;
+    public abstract void writeJson(JsonWriter writer) throws IOException;
-
-    static TextualComponent deserialize(final Map<String, Object> map) {
-        if (map.containsKey("key") && (map.size() == 2) && map.containsKey("value")) {
-            // Arbitrary text component
-            return ArbitraryTextTypeComponent.deserialize(map);
-        } else if ((map.size() >= 2) && map.containsKey("key") && !map.containsKey("value") /* It contains keys that START WITH value */) {
-            // Complex JSON object
-            return ComplexTextTypeComponent.deserialize(map);
-        }
-
-        return null;
-    }
-
-    static boolean isTextKey(final String key) {
-        return key.equals("translate") || key.equals("text") || key.equals("score") || key.equals("selector");
-    }
-
-    static boolean isTranslatableText(final TextualComponent component) {
-        return (component instanceof ComplexTextTypeComponent) && ((ComplexTextTypeComponent) component).getKey().equals("translate");
-    }
 
     /**
      * Internal class used to represent all types of text components.
@@ -79,33 +160,37 @@ public abstract class TextualComponent implements Cloneable {
      */
     private static final class ArbitraryTextTypeComponent extends TextualComponent implements ConfigurationSerializable {
 
-        public ArbitraryTextTypeComponent(final String key, final String value) {
+        private String _key;
+        private String _value;
+
+        public ArbitraryTextTypeComponent(String key, String value) {
             setKey(key);
             setValue(value);
         }
 
-        @Override
+        public static ArbitraryTextTypeComponent deserialize(Map<String, Object> map) {
-        public String getKey() {
+            return new ArbitraryTextTypeComponent(map.get("key").toString(), map.get("value").toString());
-            return _key;
         }
 
-        public void setKey(final String key) {
+        @Override
+        public String getKey() {
+            return this._key;
+        }
+
+        public void setKey(String key) {
             Preconditions.checkArgument((key != null) && !key.isEmpty(), "The key must be specified.");
-            _key = key;
+            this._key = key;
         }
 
         public String getValue() {
-            return _value;
+            return this._value;
         }
 
-        public void setValue(final String value) {
+        public void setValue(String value) {
             Preconditions.checkArgument(value != null, "The value must be specified.");
-            _value = value;
+            this._value = value;
         }
 
-        private String _key;
-        private String _value;
-
         @Override
         public TextualComponent clone() throws CloneNotSupportedException {
             // Since this is a private and final class, we can just reinstantiate this class instead of casting super.clone
@@ -113,7 +198,7 @@ public abstract class TextualComponent implements Cloneable {
         }
 
         @Override
-        public void writeJson(final JsonWriter writer) throws IOException {
+        public void writeJson(JsonWriter writer) throws IOException {
             writer.name(getKey()).value(getValue());
         }
 
@@ -128,10 +213,6 @@ public abstract class TextualComponent implements Cloneable {
             };
         }
 
-        public static ArbitraryTextTypeComponent deserialize(final Map<String, Object> map) {
-            return new ArbitraryTextTypeComponent(map.get("key").toString(), map.get("value").toString());
-        }
-
         @Override
         public String getReadableString() {
             return getValue();
@@ -144,33 +225,46 @@ public abstract class TextualComponent implements Cloneable {
      */
     private static final class ComplexTextTypeComponent extends TextualComponent implements ConfigurationSerializable {
 
-        public ComplexTextTypeComponent(final String key, final Map<String, String> values) {
+        private String _key;
+        private Map<String, String> _value;
+
+        public ComplexTextTypeComponent(String key, Map<String, String> values) {
             setKey(key);
             setValue(values);
         }
 
-        @Override
+        public static ComplexTextTypeComponent deserialize(Map<String, Object> map) {
-        public String getKey() {
+            String key = null;
-            return _key;
+            Map<String, String> value = new HashMap<String, String>();
+            for (Map.Entry<String, Object> valEntry : map.entrySet()) {
+                if (valEntry.getKey().equals("key")) {
+                    key = (String) valEntry.getValue();
+                } else if (valEntry.getKey().startsWith("value.")) {
+                    value.put(valEntry.getKey().substring(6) /* Strips out the value prefix */, valEntry.getValue().toString());
+                }
+            }
+            return new ComplexTextTypeComponent(key, value);
         }
 
-        public void setKey(final String key) {
+        @Override
+        public String getKey() {
+            return this._key;
+        }
+
+        public void setKey(String key) {
             Preconditions.checkArgument((key != null) && !key.isEmpty(), "The key must be specified.");
-            _key = key;
+            this._key = key;
         }
 
         public Map<String, String> getValue() {
-            return _value;
+            return this._value;
         }
 
-        public void setValue(final Map<String, String> value) {
+        public void setValue(Map<String, String> value) {
             Preconditions.checkArgument(value != null, "The value must be specified.");
-            _value = value;
+            this._value = value;
         }
 
-        private String _key;
-        private Map<String, String> _value;
-
         @Override
         public TextualComponent clone() throws CloneNotSupportedException {
             // Since this is a private and final class, we can just reinstantiate this class instead of casting super.clone
@@ -178,10 +272,10 @@ public abstract class TextualComponent implements Cloneable {
         }
 
         @Override
-        public void writeJson(final JsonWriter writer) throws IOException {
+        public void writeJson(JsonWriter writer) throws IOException {
             writer.name(getKey());
             writer.beginObject();
-            for (final Map.Entry<String, String> jsonPair : _value.entrySet()) {
+            for (Map.Entry<String, String> jsonPair : this._value.entrySet()) {
                 writer.name(jsonPair.getKey()).value(jsonPair.getValue());
             }
             writer.endObject();
@@ -193,101 +287,16 @@ public abstract class TextualComponent implements Cloneable {
             return new java.util.HashMap<String, Object>() {
                 {
                     put("key", getKey());
-                    for (final Map.Entry<String, String> valEntry : getValue().entrySet()) {
+                    for (Map.Entry<String, String> valEntry : getValue().entrySet()) {
                         put("value." + valEntry.getKey(), valEntry.getValue());
                     }
                 }
             };
         }
 
-        public static ComplexTextTypeComponent deserialize(final Map<String, Object> map) {
-            String key = null;
-            final Map<String, String> value = new HashMap<String, String>();
-            for (final Map.Entry<String, Object> valEntry : map.entrySet()) {
-                if (valEntry.getKey().equals("key")) {
-                    key = (String) valEntry.getValue();
-                } else if (valEntry.getKey().startsWith("value.")) {
-                    value.put(valEntry.getKey().substring(6) /* Strips out the value prefix */, valEntry.getValue().toString());
-                }
-            }
-            return new ComplexTextTypeComponent(key, value);
-        }
-
         @Override
         public String getReadableString() {
             return getKey();
         }
     }
-
-    /**
-     * Create a textual component representing a string literal.
-     * This is the default type of textual component when a single string literal is given to a method.
-     * @param textValue The text which will be represented.
-     * @return The text component representing the specified literal text.
-     */
-    public static TextualComponent rawText(final String textValue) {
-        return new ArbitraryTextTypeComponent("text", textValue);
-    }
-
-    /**
-     * Create a textual component representing a localized string.
-     * The client will see this text component as their localized version of the specified string <em>key</em>, which can be overridden by a resource pack.
-     * <p>
-     * If the specified translation key is not present on the client resource pack, the translation key will be displayed as a string literal to the client.
-     * </p>
-     * @param translateKey The string key which maps to localized text.
-     * @return The text component representing the specified localized text.
-     */
-    public static TextualComponent localizedText(final String translateKey) {
-        return new ArbitraryTextTypeComponent("translate", translateKey);
-    }
-
-    private static void throwUnsupportedSnapshot() {
-        throw new UnsupportedOperationException("This feature is only supported in snapshot releases.");
-    }
-
-    /**
-     * Create a textual component representing a scoreboard value.
-     * The client will see their own score for the specified objective as the text represented by this component.
-     * <p>
-     * <b>This method is currently guaranteed to throw an {@code UnsupportedOperationException} as it is only supported on snapshot clients.</b>
-     * </p>
-     * @param scoreboardObjective The name of the objective for which to display the score.
-     * @return The text component representing the specified scoreboard score (for the viewing player), or {@code null} if an error occurs during JSON serialization.
-     */
-    public static TextualComponent objectiveScore(final String scoreboardObjective) {
-        return objectiveScore("*", scoreboardObjective);
-    }
-
-    /**
-     * Create a textual component representing a scoreboard value.
-     * The client will see the score of the specified player for the specified objective as the text represented by this component.
-     * <p>
-     * <b>This method is currently guaranteed to throw an {@code UnsupportedOperationException} as it is only supported on snapshot clients.</b>
-     * </p>
-     * @param playerName The name of the player whos score will be shown. If this string represents the single-character sequence "*", the viewing player's score will be displayed.
-     * Standard minecraft selectors (@a, @p, etc) are <em>not</em> supported.
-     * @param scoreboardObjective The name of the objective for which to display the score.
-     * @return The text component representing the specified scoreboard score for the specified player, or {@code null} if an error occurs during JSON serialization.
-     */
-    public static TextualComponent objectiveScore(final String playerName, final String scoreboardObjective) {
-        throwUnsupportedSnapshot(); // Remove this line when the feature is released to non-snapshot versions, in addition to updating ALL THE OVERLOADS documentation accordingly
-
-        return new ComplexTextTypeComponent("score", ImmutableMap.<String, String> builder().put("name", playerName).put("objective", scoreboardObjective).build());
-    }
-
-    /**
-     * Create a textual component representing a player name, retrievable by using a standard minecraft selector.
-     * The client will see the players or entities captured by the specified selector as the text represented by this component.
-     * <p>
-     * <b>This method is currently guaranteed to throw an {@code UnsupportedOperationException} as it is only supported on snapshot clients.</b>
-     * </p>
-     * @param selector The minecraft player or entity selector which will capture the entities whose string representations will be displayed in the place of this text component.
-     * @return The text component representing the name of the entities captured by the selector.
-     */
-    public static TextualComponent selector(final String selector) {
-        throwUnsupportedSnapshot(); // Remove this line when the feature is released to non-snapshot versions, in addition to updating ALL THE OVERLOADS documentation accordingly
-        
-        return new ArbitraryTextTypeComponent("selector", selector);
-    }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/commands/DebugUUID.java

@@ -1,23 +1,3 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.commands;
 
 import com.intellectualcrafters.plot.PS;
@@ -56,23 +36,23 @@ import java.util.Map.Entry;
 import java.util.UUID;
 
 @CommandDeclaration(
-command = "uuidconvert",
+        command = "uuidconvert",
-permission = "plots.admin",
+        permission = "plots.admin",
-description = "Debug UUID conversion",
+        description = "Debug UUID conversion",
-usage = "/plot uuidconvert <lower|offline|online>",
+        usage = "/plot uuidconvert <lower|offline|online>",
-requiredType = RequiredType.CONSOLE,
+        requiredType = RequiredType.CONSOLE,
-category = CommandCategory.DEBUG)
+        category = CommandCategory.DEBUG)
 public class DebugUUID extends SubCommand {
-    
+
     public DebugUUID() {
-        requiredArguments = new Argument[] { Argument.String };
+        super(Argument.String);
     }
-    
+
     @Override
-    public boolean onCommand(final PlotPlayer player, final String[] args) {
+    public boolean onCommand(final PlotPlayer player, String[] args) {
         final UUIDWrapper currentUUIDWrapper = UUIDHandler.getUUIDWrapper();
         final UUIDWrapper newWrapper;
-        
+
         switch (args[0].toLowerCase()) {
             case "lower":
                 newWrapper = new LowerOfflineUUIDWrapper();
@@ -85,7 +65,7 @@ public class DebugUUID extends SubCommand {
                 break;
             default:
                 try {
-                    final Class<?> clazz = Class.forName(args[0]);
+                    Class<?> clazz = Class.forName(args[0]);
                     newWrapper = (UUIDWrapper) clazz.newInstance();
                 } catch (ClassNotFoundException | IllegalAccessException | InstantiationException e) {
                     MainUtil.sendMessage(player, C.COMMAND_SYNTAX, "/plot uuidconvert <lower|offline|online>");
@@ -104,7 +84,7 @@ public class DebugUUID extends SubCommand {
             MainUtil.sendMessage(player, "&7Retype the command with the override parameter when ready :)");
             return false;
         }
-        
+
         if (currentUUIDWrapper.getClass().getCanonicalName().equals(newWrapper.getClass().getCanonicalName())) {
             MainUtil.sendMessage(player, "&cUUID mode already in use!");
             return false;
@@ -114,69 +94,70 @@ public class DebugUUID extends SubCommand {
         for (Entry<String, PlotPlayer> entry : UUIDHandler.getPlayers().entrySet()) {
             entry.getValue().kick("PlotSquared UUID conversion has been initiated. You may reconnect when finished.");
         }
-        
+
         MainUtil.sendMessage(player, "&7 - Initializing map");
 
         final HashMap<UUID, UUID> uCMap = new HashMap<>();
         final HashMap<UUID, UUID> uCReverse = new HashMap<>();
-        
+
         MainUtil.sendMessage(player, "&7 - Collecting playerdata");
-        
+
-        final HashSet<String> worlds = new HashSet<>();
+        HashSet<String> worlds = new HashSet<>();
         worlds.add(WorldUtil.IMP.getMainWorld());
         worlds.add("world");
-        final HashSet<UUID> uuids = new HashSet<>();
+        HashSet<UUID> uuids = new HashSet<>();
-        final HashSet<String> names = new HashSet<>();
+        HashSet<String> names = new HashSet<>();
-        for (final String worldname : worlds) {
+        for (String worldName : worlds) {
-            final File playerdataFolder = new File(worldname + File.separator + "playerdata");
+            File playerDataFolder = new File(worldName + File.separator + "playerdata");
-            String[] dat = playerdataFolder.list(new FilenameFilter() {
+            String[] dat = playerDataFolder.list(new FilenameFilter() {
                 @Override
-                public boolean accept(final File f, final String s) {
+                public boolean accept(File f, String s) {
-                    return s.endsWith(".dat");
-                }
-            });
-            if (dat != null)
-                for (final String current : dat) {
-                    final String s = current.replaceAll(".dat$", "");
-                    try {
-                        final UUID uuid = UUID.fromString(s);
-                        uuids.add(uuid);
-                    } catch (final Exception e) {
-                        MainUtil.sendMessage(player, C.PREFIX.s() + "Invalid playerdata: " + current);
-                    }
-                }
-            final File playersFolder = new File(worldname + File.separator + "players");
-            dat = playersFolder.list(new FilenameFilter() {
-                @Override
-                public boolean accept(final File f, final String s) {
                     return s.endsWith(".dat");
                 }
             });
             if (dat != null) {
-                for (final String current : dat) {
+                for (String current : dat) {
+                    String s = current.replaceAll(".dat$", "");
+                    try {
+                        UUID uuid = UUID.fromString(s);
+                        uuids.add(uuid);
+                    } catch (Exception e) {
+                        MainUtil.sendMessage(player, C.PREFIX + "Invalid playerdata: " + current);
+                    }
+                }
+            }
+            File playersFolder = new File(worldName + File.separator + "players");
+            dat = playersFolder.list(new FilenameFilter() {
+                @Override
+                public boolean accept(File f, String s) {
+                    return s.endsWith(".dat");
+                }
+            });
+            if (dat != null) {
+                for (String current : dat) {
                     names.add(current.replaceAll(".dat$", ""));
                 }
             }
         }
-        
+
         MainUtil.sendMessage(player, "&7 - Populating map");
         UUID uuid2;
-        final UUIDWrapper wrapper = new DefaultUUIDWrapper();
+        UUIDWrapper wrapper = new DefaultUUIDWrapper();
         for (UUID uuid : uuids) {
             try {
-                final OfflinePlotPlayer op = wrapper.getOfflinePlayer(uuid);
+                OfflinePlotPlayer op = wrapper.getOfflinePlayer(uuid);
                 uuid = currentUUIDWrapper.getUUID(op);
                 uuid2 = newWrapper.getUUID(op);
                 if (!uuid.equals(uuid2) && !uCMap.containsKey(uuid) && !uCReverse.containsKey(uuid2)) {
                     uCMap.put(uuid, uuid2);
                     uCReverse.put(uuid2, uuid);
                 }
-            } catch (final Throwable e) {
+            } catch (Throwable e) {
-                MainUtil.sendMessage(player, C.PREFIX.s() + "&6Invalid playerdata: " + uuid.toString() + ".dat");
+                MainUtil.sendMessage(player, C.PREFIX + "&6Invalid playerdata: " + uuid.toString() + ".dat");
             }
         }
-        for (final String name : names) {
+        for (String name : names) {
-            final UUID uuid = currentUUIDWrapper.getUUID(name);
+            UUID uuid = currentUUIDWrapper.getUUID(name);
             uuid2 = newWrapper.getUUID(name);
             if (!uuid.equals(uuid2)) {
                 uCMap.put(uuid, uuid2);
@@ -185,11 +166,11 @@ public class DebugUUID extends SubCommand {
         }
         if (uCMap.isEmpty()) {
             MainUtil.sendMessage(player, "&c - Error! Attempting to repopulate");
-            for (final OfflinePlotPlayer op : currentUUIDWrapper.getOfflinePlayers()) {
+            for (OfflinePlotPlayer op : currentUUIDWrapper.getOfflinePlayers()) {
                 if (op.getLastPlayed() != 0) {
                     //                    String name = op.getName();
                     //                    StringWrapper wrap = new StringWrapper(name);
-                    final UUID uuid = currentUUIDWrapper.getUUID(op);
+                    UUID uuid = currentUUIDWrapper.getUUID(op);
                     uuid2 = newWrapper.getUUID(op);
                     if (!uuid.equals(uuid2)) {
                         uCMap.put(uuid, uuid2);
@@ -204,24 +185,24 @@ public class DebugUUID extends SubCommand {
                 MainUtil.sendMessage(player, "&a - Successfully repopulated");
             }
         }
-        
+
         MainUtil.sendMessage(player, "&7 - Replacing cache");
         TaskManager.runTaskAsync(new Runnable() {
             @Override
             public void run() {
-                for (final Entry<UUID, UUID> entry : uCMap.entrySet()) {
+                for (Entry<UUID, UUID> entry : uCMap.entrySet()) {
-                    final String name = UUIDHandler.getName(entry.getKey());
+                    String name = UUIDHandler.getName(entry.getKey());
                     if (name != null) {
                         UUIDHandler.add(new StringWrapper(name), entry.getValue());
                     }
                 }
-                
+
                 MainUtil.sendMessage(player, "&7 - Scanning for applicable files (uuids.txt)");
-                
+
-                final File file = new File(PS.get().IMP.getDirectory(), "uuids.txt");
+                File file = new File(PS.get().IMP.getDirectory(), "uuids.txt");
                 if (file.exists()) {
                     try {
-                        final List<String> lines = Files.readAllLines(file.toPath(), StandardCharsets.UTF_8);
+                        List<String> lines = Files.readAllLines(file.toPath(), StandardCharsets.UTF_8);
                         for (String line : lines) {
                             try {
                                 line = line.trim();
@@ -229,35 +210,35 @@ public class DebugUUID extends SubCommand {
                                     continue;
                                 }
                                 line = line.replaceAll("[\\|][0-9]+[\\|][0-9]+[\\|]", "");
-                                final String[] split = line.split("\\|");
+                                String[] split = line.split("\\|");
-                                final String name = split[0];
+                                String name = split[0];
                                 if (name.isEmpty() || name.length() > 16 || !StringMan.isAlphanumericUnd(name)) {
                                     continue;
                                 }
-                                final UUID old = currentUUIDWrapper.getUUID(name);
+                                UUID old = currentUUIDWrapper.getUUID(name);
                                 if (old == null) {
                                     continue;
                                 }
-                                final UUID now = newWrapper.getUUID(name);
+                                UUID now = newWrapper.getUUID(name);
                                 UUIDHandler.add(new StringWrapper(name), now);
                                 uCMap.put(old, now);
                                 uCReverse.put(now, old);
-                            } catch (final Exception e2) {
+                            } catch (Exception e2) {
                                 e2.printStackTrace();
                             }
                         }
-                    } catch (final IOException e) {
+                    } catch (IOException e) {
                         e.printStackTrace();
                     }
                 }
-                
+
                 MainUtil.sendMessage(player, "&7 - Replacing wrapper");
                 UUIDHandler.setUUIDWrapper(newWrapper);
-                
+
                 MainUtil.sendMessage(player, "&7 - Updating plot objects");
-                
+
-                for (final Plot plot : PS.get().getPlots()) {
+                for (Plot plot : PS.get().getPlots()) {
-                    final UUID value = uCMap.get(plot.owner);
+                    UUID value = uCMap.get(plot.owner);
                     if (value != null) {
                         plot.owner = value;
                     }
@@ -265,19 +246,19 @@ public class DebugUUID extends SubCommand {
                     plot.getMembers().clear();
                     plot.getDenied().clear();
                 }
-                
+
                 MainUtil.sendMessage(player, "&7 - Deleting database");
                 final AbstractDB database = DBFunc.dbManager;
-                final boolean result = database.deleteTables();
+                boolean result = database.deleteTables();
-                
+
                 MainUtil.sendMessage(player, "&7 - Creating tables");
-                
+
                 try {
                     database.createTables();
                     if (!result) {
                         MainUtil.sendMessage(player, "&cConversion failed! Attempting recovery");
-                        for (final Plot plot : PS.get().getPlots()) {
+                        for (Plot plot : PS.get().getPlots()) {
-                            final UUID value = uCReverse.get(plot.owner);
+                            UUID value = uCReverse.get(plot.owner);
                             if (value != null) {
                                 plot.owner = value;
                             }
@@ -290,11 +271,11 @@ public class DebugUUID extends SubCommand {
                         });
                         return;
                     }
-                } catch (final Exception e) {
+                } catch (Exception e) {
                     e.printStackTrace();
                     return;
                 }
-                
+
                 if (newWrapper instanceof OfflineUUIDWrapper) {
                     PS.get().config.set("UUID.force-lowercase", false);
                     PS.get().config.set("UUID.offline", true);
@@ -305,15 +286,15 @@ public class DebugUUID extends SubCommand {
                 try {
                     PS.get().config.save(PS.get().configFile);
                 } catch (IOException e) {
-                    MainUtil.sendMessage(player, "Could not save configuration. It will need to be manuall set!");
+                    MainUtil.sendMessage(player, "Could not save configuration. It will need to be manual set!");
                 }
-                
+
                 MainUtil.sendMessage(player, "&7 - Populating tables");
-                
+
                 TaskManager.runTaskAsync(new Runnable() {
                     @Override
                     public void run() {
-                        final ArrayList<Plot> plots = new ArrayList<>(PS.get().getPlots());
+                        ArrayList<Plot> plots = new ArrayList<>(PS.get().getPlots());
                         database.createPlotsAndData(plots, new Runnable() {
                             @Override
                             public void run() {
@@ -322,7 +303,7 @@ public class DebugUUID extends SubCommand {
                         });
                     }
                 });
-                
+
                 MainUtil.sendMessage(player, "&aIt is now safe for players to join");
                 MainUtil.sendMessage(player, "&cConversion is still in progress, you will be notified when it is complete");
             }

Bukkit/src/main/java/com/plotsquared/bukkit/database/plotme/APlotMeConnector.java

@@ -1,103 +1,84 @@
 package com.plotsquared.bukkit.database.plotme;
 
-import java.sql.Connection;
-import java.sql.SQLException;
-import java.util.Collections;
-import java.util.HashMap;
-
-import org.bukkit.Bukkit;
-import org.bukkit.World;
-
 import com.intellectualcrafters.configuration.file.FileConfiguration;
 import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.object.Location;
 import com.intellectualcrafters.plot.object.Plot;
 import com.intellectualcrafters.plot.object.PlotId;
+import org.bukkit.Bukkit;
+import org.bukkit.World;
 
-public abstract class APlotMeConnector {
+import java.sql.Connection;
-    public abstract Connection getPlotMeConnection(final String plugin, final FileConfiguration plotConfig, final String dataFolder);
+import java.sql.SQLException;
-    
+import java.util.Collections;
-    public abstract HashMap<String, HashMap<PlotId, Plot>> getPlotMePlots(final Connection connection) throws SQLException;
+import java.util.HashMap;
-    
+
-    public abstract boolean accepts(final String version);
+abstract class APlotMeConnector {
-    
+
-    public String getWorld(final String world) {
+    public abstract Connection getPlotMeConnection(String plugin, FileConfiguration plotConfig, String dataFolder);
-        for (final World newworld : Bukkit.getWorlds()) {
+
-            if (newworld.getName().equalsIgnoreCase(world)) {
+    public abstract HashMap<String, HashMap<PlotId, Plot>> getPlotMePlots(Connection connection) throws SQLException;
-                return newworld.getName();
+
+    public abstract boolean accepts(String version);
+
+    public String getWorld(String world) {
+        for (World newWorld : Bukkit.getWorlds()) {
+            if (newWorld.getName().equalsIgnoreCase(world)) {
+                return newWorld.getName();
             }
         }
         return world;
     }
-    
+
-    public boolean isValidConnection(final Connection connection) {
+    public boolean isValidConnection(Connection connection) {
         return connection != null;
     }
-    
+
-    public void copyConfig(final FileConfiguration plotConfig, final String world, final String actualWorldName) {
+    public void copyConfig(FileConfiguration plotConfig, String world, String actualWorldName) {
-        final Integer pathwidth = plotConfig.getInt("worlds." + world + ".PathWidth"); //
+        int pathWidth = plotConfig.getInt("worlds." + world + ".PathWidth"); //
-        PS.get().config.set("worlds." + actualWorldName + ".road.width", pathwidth);
+        PS.get().config.set("worlds." + actualWorldName + ".road.width", pathWidth);
-        final Integer plotsize = plotConfig.getInt("worlds." + world + ".PlotSize"); //
+        int plotSize = plotConfig.getInt("worlds." + world + ".PlotSize"); //
-        PS.get().config.set("worlds." + actualWorldName + ".plot.size", plotsize);
+        PS.get().config.set("worlds." + actualWorldName + ".plot.size", plotSize);
-        final String wallblock = plotConfig.getString("worlds." + world + ".WallBlockId"); //
+        String wallBlock = plotConfig.getString("worlds." + world + ".WallBlockId"); //
-        PS.get().config.set("worlds." + actualWorldName + ".wall.block", wallblock);
+        PS.get().config.set("worlds." + actualWorldName + ".wall.block", wallBlock);
-        final String floor = plotConfig.getString("worlds." + world + ".PlotFloorBlockId"); //
+        String floor = plotConfig.getString("worlds." + world + ".PlotFloorBlockId"); //
         PS.get().config.set("worlds." + actualWorldName + ".plot.floor", Collections.singletonList(floor));
-        final String filling = plotConfig.getString("worlds." + world + ".PlotFillingBlockId"); //
+        String filling = plotConfig.getString("worlds." + world + ".PlotFillingBlockId"); //
         PS.get().config.set("worlds." + actualWorldName + ".plot.filling", Collections.singletonList(filling));
-        final String road = plotConfig.getString("worlds." + world + ".RoadMainBlockId");
+        String road = plotConfig.getString("worlds." + world + ".RoadMainBlockId");
         PS.get().config.set("worlds." + actualWorldName + ".road.block", road);
-        Integer height = plotConfig.getInt("worlds." + world + ".RoadHeight"); //
+        int height = plotConfig.getInt("worlds." + world + ".RoadHeight"); //
         PS.get().config.set("worlds." + actualWorldName + ".road.height", height);
+        PS.get().config.set("worlds." + actualWorldName + ".plot.height", height);
+        PS.get().config.set("worlds." + actualWorldName + ".wall.height", height);
     }
-    
+
-    public Location getPlotTopLocAbs(final int path, final int plot, final PlotId plotid) {
+    public Location getPlotTopLocAbs(int path, int plot, PlotId plotid) {
-        final int px = plotid.x;
+        int px = plotid.x;
-        final int pz = plotid.y;
+        int pz = plotid.y;
-        final int x = (px * (path + plot)) - ((int) Math.floor(path / 2)) - 1;
+        int x = px * (path + plot) - (int) Math.floor(path / 2) - 1;
-        final int z = (pz * (path + plot)) - ((int) Math.floor(path / 2)) - 1;
+        int z = pz * (path + plot) - (int) Math.floor(path / 2) - 1;
         return new Location(null, x, 256, z);
     }
-    
+
-    public Location getPlotBottomLocAbs(final int path, final int plot, final PlotId plotid) {
+    public Location getPlotBottomLocAbs(int path, int plot, PlotId plotid) {
-        final int px = plotid.x;
+        int px = plotid.x;
-        final int pz = plotid.y;
+        int pz = plotid.y;
-        final int x = (px * (path + plot)) - plot - ((int) Math.floor(path / 2)) - 1;
+        int x = px * (path + plot) - plot - (int) Math.floor(path / 2) - 1;
-        final int z = (pz * (path + plot)) - plot - ((int) Math.floor(path / 2)) - 1;
+        int z = pz * (path + plot) - plot - (int) Math.floor(path / 2) - 1;
         return new Location(null, x, 1, z);
     }
-    
+
-    public void setMerged(final HashMap<String, HashMap<PlotId, boolean[]>> merges, final String world, final PlotId id, final int direction) {
+    public void setMerged(HashMap<String, HashMap<PlotId, boolean[]>> merges, String world, PlotId id, int direction) {
-        final HashMap<PlotId, boolean[]> plots = merges.get(world);
+        HashMap<PlotId, boolean[]> plots = merges.get(world);
-        PlotId id2;
+        PlotId id2 = new PlotId(id.x, id.y);
-        switch (direction) {
-            case 0: {
-                id2 = new PlotId(id.x, id.y);
-                break;
-            }
-            case 1: {
-                id2 = new PlotId(id.x, id.y);
-                break;
-            }
-            case 2: {
-                id2 = new PlotId(id.x, id.y);
-                break;
-            }
-            case 3: {
-                id2 = new PlotId(id.x, id.y);
-                break;
-            }
-            default: {
-                return;
-            }
-        }
         boolean[] merge1;
-        boolean[] merge2;
         if (plots.containsKey(id)) {
             merge1 = plots.get(id);
         } else {
             merge1 = new boolean[] { false, false, false, false };
         }
+        boolean[] merge2;
         if (plots.containsKey(id2)) {
             merge2 = plots.get(id2);
         } else {

Bukkit/src/main/java/com/plotsquared/bukkit/database/plotme/ClassicPlotMeConnector.java

@@ -25,73 +25,72 @@ import java.util.Map.Entry;
 import java.util.UUID;
 
 public class ClassicPlotMeConnector extends APlotMeConnector {
-    
+
     private String plugin;
     private String prefix;
-    
+
     @Override
-    public Connection getPlotMeConnection(final String plugin, final FileConfiguration plotConfig, final String dataFolder) {
+    public Connection getPlotMeConnection(String plugin, FileConfiguration plotConfig, String dataFolder) {
         this.plugin = plugin.toLowerCase();
-        prefix = plotConfig.getString("mySQLprefix");
+        this.prefix = plotConfig.getString("mySQLprefix", plugin.toLowerCase());
-        if (prefix == null) {
-            prefix = plugin.toLowerCase();
-        }
         try {
             if (plotConfig.getBoolean("usemySQL")) {
-                final String user = plotConfig.getString("mySQLuname");
+                String user = plotConfig.getString("mySQLuname");
-                final String password = plotConfig.getString("mySQLpass");
+                String password = plotConfig.getString("mySQLpass");
-                final String con = plotConfig.getString("mySQLconn");
+                String con = plotConfig.getString("mySQLconn");
                 return DriverManager.getConnection(con, user, password);
                 //                return new MySQL(plotsquared, hostname, port, database, username, password)
             } else {
                 return new SQLite(dataFolder + File.separator + "plots.db").openConnection();
             }
         } catch (SQLException | ClassNotFoundException ignored) {
+            //ignored
+            ignored.printStackTrace();
         }
         return null;
     }
-    
+
     @Override
-    public HashMap<String, HashMap<PlotId, Plot>> getPlotMePlots(final Connection connection) throws SQLException {
+    public HashMap<String, HashMap<PlotId, Plot>> getPlotMePlots(Connection connection) throws SQLException {
-        final HashMap<String, Integer> plotWidth = new HashMap<>();
+        HashMap<String, Integer> plotWidth = new HashMap<>();
-        final HashMap<String, Integer> roadWidth = new HashMap<>();
+        HashMap<String, Integer> roadWidth = new HashMap<>();
-        final HashMap<String, HashMap<PlotId, Plot>> plots = new HashMap<>();
+        HashMap<String, HashMap<PlotId, Plot>> plots = new HashMap<>();
-        final HashMap<String, HashMap<PlotId, boolean[]>> merges = new HashMap<>();
+        HashMap<String, HashMap<PlotId, boolean[]>> merges = new HashMap<>();
-        PreparedStatement stmt = connection.prepareStatement("SELECT * FROM `" + prefix + "Plots`");
+        PreparedStatement statement = connection.prepareStatement("SELECT * FROM `" + this.prefix + "Plots`");
-        ResultSet r = stmt.executeQuery();
+        ResultSet resultSet = statement.executeQuery();
         String column = null;
-        final boolean checkUUID = DBFunc.hasColumn(r, "ownerid");
+        boolean checkUUID = DBFunc.hasColumn(resultSet, "ownerid");
-        final boolean checkUUID2 = DBFunc.hasColumn(r, "ownerId");
+        boolean checkUUID2 = DBFunc.hasColumn(resultSet, "ownerId");
         if (checkUUID) {
             column = "ownerid";
         } else if (checkUUID2) {
             column = "ownerId";
         }
-        final boolean merge = !"plotme".equalsIgnoreCase(plugin) && Settings.CONVERT_PLOTME;
+        boolean merge = !"plotme".equalsIgnoreCase(this.plugin) && Settings.CONVERT_PLOTME;
         int missing = 0;
-        while (r.next()) {
+        while (resultSet.next()) {
-            final PlotId id = new PlotId(r.getInt("idX"), r.getInt("idZ"));
+            PlotId id = new PlotId(resultSet.getInt("idX"), resultSet.getInt("idZ"));
-            final String name = r.getString("owner");
+            String name = resultSet.getString("owner");
-            final String world = LikePlotMeConverter.getWorld(r.getString("world"));
+            String world = LikePlotMeConverter.getWorld(resultSet.getString("world"));
             if (!plots.containsKey(world)) {
                 plots.put(world, new HashMap<PlotId, Plot>());
                 if (merge) {
-                    final int plot = PS.get().config.getInt("worlds." + world + ".plot.size");
+                    int plot = PS.get().config.getInt("worlds." + world + ".plot.size");
-                    final int path = PS.get().config.getInt("worlds." + world + ".road.width");
+                    int path = PS.get().config.getInt("worlds." + world + ".road.width");
                     plotWidth.put(world, plot);
                     roadWidth.put(world, path);
                     merges.put(world, new HashMap<PlotId, boolean[]>());
                 }
             }
             if (merge) {
-                final int tx = r.getInt("topX");
+                int tx = resultSet.getInt("topX");
-                final int tz = r.getInt("topZ");
+                int tz = resultSet.getInt("topZ");
-                final int bx = r.getInt("bottomX") - 1;
+                int bx = resultSet.getInt("bottomX") - 1;
-                final int bz = r.getInt("bottomZ") - 1;
+                int bz = resultSet.getInt("bottomZ") - 1;
-                final int path = roadWidth.get(world);
+                int path = roadWidth.get(world);
-                final int plot = plotWidth.get(world);
+                int plot = plotWidth.get(world);
-                final Location top = getPlotTopLocAbs(path, plot, id);
+                Location top = getPlotTopLocAbs(path, plot, id);
-                final Location bot = getPlotBottomLocAbs(path, plot, id);
+                Location bot = getPlotBottomLocAbs(path, plot, id);
                 if (tx > top.getX()) {
                     setMerged(merges, world, id, 1);
                 }
@@ -112,14 +111,14 @@ public class ClassicPlotMeConnector extends APlotMeConnector {
                 } else {
                     if (checkUUID || checkUUID2) {
                         try {
-                            final byte[] bytes = r.getBytes(column);
+                            byte[] bytes = resultSet.getBytes(column);
                             if (bytes != null) {
                                 try {
-                                    final ByteBuffer bb = ByteBuffer.wrap(bytes);
+                                    ByteBuffer bb = ByteBuffer.wrap(bytes);
-                                    final long high = bb.getLong();
+                                    long high = bb.getLong();
-                                    final long low = bb.getLong();
+                                    long low = bb.getLong();
                                     owner = new UUID(high, low);
-                                } catch (final Exception e) {
+                                } catch (Exception e) {
                                     e.printStackTrace();
                                     owner = UUID.nameUUIDFromBytes(bytes);
                                 }
@@ -130,74 +129,73 @@ public class ClassicPlotMeConnector extends APlotMeConnector {
                         }
                     }
                     if (owner == null) {
-                        if (!name.isEmpty()) {
+                        if (name.isEmpty()) {
-                            owner = UUID.nameUUIDFromBytes(("OfflinePlayer:" + name.toLowerCase()).getBytes(Charsets.UTF_8));
+                            PS.log("&cCould not identify owner for plot: " + id + " -> '" + name + "'");
+                            missing++;
+                            continue;
                         }
-                        PS.log("&cCould not identify owner for plot: " + id + " -> '" + name + "'");
+                        owner = UUID.nameUUIDFromBytes(("OfflinePlayer:" + name.toLowerCase()).getBytes(Charsets.UTF_8));
-                        missing++;
-                        continue;
                     }
                 }
             } else {
                 UUIDHandler.add(new StringWrapper(name), owner);
             }
-            final Plot plot = new Plot(PlotArea.createGeneric(world), id, owner);
+            Plot plot = new Plot(PlotArea.createGeneric(world), id, owner);
             plots.get(world).put(id, plot);
         }
         if (missing > 0) {
             PS.log("&cSome names could not be identified:");
             PS.log("&7 - Empty quotes mean PlotMe just stored an unowned plot in the database");
             PS.log("&7 - Names you have never seen before could be from people mistyping commands");
-            PS.log("&7 - Converting from a non-uuid version of PlotMe can't identify owners if the playerdata files are deleted (these plots will remain unknown until the player connects)");
+            PS.log("&7 - Converting from a non-uuid version of PlotMe can't identify owners if the playerdata files are deleted (these plots will "
+                    + "remain unknown until the player connects)");
         }
-        
+
-        for (final Entry<String, HashMap<PlotId, boolean[]>> entry : merges.entrySet()) {
+        for (Entry<String, HashMap<PlotId, boolean[]>> entry : merges.entrySet()) {
-            final String world = entry.getKey();
+            String world = entry.getKey();
-            for (final Entry<PlotId, boolean[]> entry2 : entry.getValue().entrySet()) {
+            for (Entry<PlotId, boolean[]> entry2 : entry.getValue().entrySet()) {
-                final HashMap<PlotId, Plot> newplots = plots.get(world);
+                HashMap<PlotId, Plot> newPlots = plots.get(world);
-                final Plot plot = newplots.get(entry2.getKey());
+                Plot plot = newPlots.get(entry2.getKey());
                 if (plot != null) {
                     plot.setMerged(entry2.getValue());
                 }
             }
         }
-        
+
-        r.close();
+        resultSet.close();
-        stmt.close();
+        statement.close();
 
         try {
 
-            PS.log(" - " + prefix + "Denied");
+            PS.log(" - " + this.prefix + "Denied");
-            stmt = connection.prepareStatement("SELECT * FROM `" + prefix + "Denied`");
+            statement = connection.prepareStatement("SELECT * FROM `" + this.prefix + "Denied`");
-            r = stmt.executeQuery();
+            resultSet = statement.executeQuery();
 
-            while (r.next()) {
+            while (resultSet.next()) {
-                final PlotId id = new PlotId(r.getInt("idX"), r.getInt("idZ"));
+                PlotId id = new PlotId(resultSet.getInt("idX"), resultSet.getInt("idZ"));
-                final String name = r.getString("player");
+                String name = resultSet.getString("player");
-                final String world = LikePlotMeConverter.getWorld(r.getString("world"));
+                String world = LikePlotMeConverter.getWorld(resultSet.getString("world"));
                 UUID denied = UUIDHandler.getUUID(name, null);
                 if (denied == null) {
                     if ("*".equals(name)) {
                         denied = DBFunc.everyone;
-                    } else {
+                    } else if (DBFunc.hasColumn(resultSet, "playerid")) {
-                        if (DBFunc.hasColumn(r, "playerid")) {
+                        try {
-                            try {
+                            byte[] bytes = resultSet.getBytes("playerid");
-                                final byte[] bytes = r.getBytes("playerid");
+                            if (bytes != null) {
-                                if (bytes != null) {
+                                try {
-                                    try {
+                                    ByteBuffer bb = ByteBuffer.wrap(bytes);
-                                        final ByteBuffer bb = ByteBuffer.wrap(bytes);
+                                    long high = bb.getLong();
-                                        final long high = bb.getLong();
+                                    long low = bb.getLong();
-                                        final long low = bb.getLong();
+                                    denied = new UUID(high, low);
-                                        denied = new UUID(high, low);
+                                } catch (Exception e) {
-                                    } catch (final Exception e) {
+                                    e.printStackTrace();
-                                        e.printStackTrace();
+                                    denied = UUID.nameUUIDFromBytes(bytes);
-                                        denied = UUID.nameUUIDFromBytes(bytes);
-                                    }
-                                    UUIDHandler.add(new StringWrapper(name), denied);
                                 }
-                            } catch (SQLException e) {
+                                UUIDHandler.add(new StringWrapper(name), denied);
-                                e.printStackTrace();
                             }
+                        } catch (SQLException e) {
+                            e.printStackTrace();
                         }
                     }
                     if (denied == null) {
@@ -205,41 +203,43 @@ public class ClassicPlotMeConnector extends APlotMeConnector {
                         continue;
                     }
                 }
-                if (plots.get(world).containsKey(id)) {
+                HashMap<PlotId, Plot> worldMap = plots.get(world);
-                    plots.get(world).get(id).getDenied().add(denied);
+                if (worldMap != null) {
+                    Plot plot = worldMap.get(id);
+                    if (plot != null) {
+                        plot.getDenied().add(denied);
+                    }
                 }
             }
 
-            stmt = connection.prepareStatement("SELECT * FROM `" + plugin + "Allowed`");
+            statement = connection.prepareStatement("SELECT * FROM `" + this.plugin + "Allowed`");
-            r = stmt.executeQuery();
+            resultSet = statement.executeQuery();
 
-            while (r.next()) {
+            while (resultSet.next()) {
-                final PlotId id = new PlotId(r.getInt("idX"), r.getInt("idZ"));
+                PlotId id = new PlotId(resultSet.getInt("idX"), resultSet.getInt("idZ"));
-                final String name = r.getString("player");
+                String name = resultSet.getString("player");
-                final String world = LikePlotMeConverter.getWorld(r.getString("world"));
+                String world = LikePlotMeConverter.getWorld(resultSet.getString("world"));
                 UUID helper = UUIDHandler.getUUID(name, null);
                 if (helper == null) {
                     if ("*".equals(name)) {
                         helper = DBFunc.everyone;
-                    } else {
+                    } else if (DBFunc.hasColumn(resultSet, "playerid")) {
-                        if (DBFunc.hasColumn(r, "playerid")) {
+                        try {
-                            try {
+                            byte[] bytes = resultSet.getBytes("playerid");
-                                final byte[] bytes = r.getBytes("playerid");
+                            if (bytes != null) {
-                                if (bytes != null) {
+                                try {
-                                    try {
+                                    ByteBuffer bb = ByteBuffer.wrap(bytes);
-                                        final ByteBuffer bb = ByteBuffer.wrap(bytes);
+                                    long high = bb.getLong();
-                                        final long high = bb.getLong();
+                                    long low = bb.getLong();
-                                        final long low = bb.getLong();
+                                    helper = new UUID(high, low);
-                                        helper = new UUID(high, low);
+                                } catch (Exception e) {
-                                    } catch (final Exception e) {
+                                    e.printStackTrace();
-                                        e.printStackTrace();
+                                    helper = UUID.nameUUIDFromBytes(bytes);
-                                        helper = UUID.nameUUIDFromBytes(bytes);
-                                    }
-                                    UUIDHandler.add(new StringWrapper(name), helper);
                                 }
-                            } catch (SQLException e) {
+                                UUIDHandler.add(new StringWrapper(name), helper);
-                                e.printStackTrace();
                             }
+                        } catch (SQLException e) {
+                            e.printStackTrace();
                         }
                     }
                     if (helper == null) {
@@ -247,21 +247,26 @@ public class ClassicPlotMeConnector extends APlotMeConnector {
                         continue;
                     }
                 }
-                if (plots.get(world).containsKey(id)) {
+                HashMap<PlotId, Plot> worldMap = plots.get(world);
-                    plots.get(world).get(id).getTrusted().add(helper);
+                if (worldMap != null) {
+                    Plot plot = worldMap.get(id);
+                    if (plot != null) {
+                        plot.getTrusted().add(helper);
+                    }
                 }
             }
 
-            r.close();
+            resultSet.close();
-            stmt.close();
+            statement.close();
 
-        } catch (SQLException e) {
+        } catch (SQLException ignored) {
+            //ignored
         }
         return plots;
     }
-    
+
     @Override
-    public boolean accepts(final String version) {
+    public boolean accepts(String version) {
         return version == null || PS.get().canUpdate(version, "0.17.0") || PS.get().canUpdate("0.999.999", version);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/database/plotme/LikePlotMeConverter.java

@@ -1,23 +1,3 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.database.plotme;
 
 import com.intellectualcrafters.configuration.MemorySection;
@@ -35,10 +15,10 @@ import com.plotsquared.bukkit.generator.BukkitPlotGenerator;
 import org.bukkit.Bukkit;
 import org.bukkit.World;
 import org.bukkit.WorldCreator;
+import org.bukkit.command.CommandException;
 
 import java.io.File;
 import java.io.IOException;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -51,60 +31,56 @@ import java.util.Map.Entry;
 import java.util.Set;
 import java.util.concurrent.atomic.AtomicBoolean;
 
-/**
- * Created 2014-08-17 for PlotSquared
- *
-
-
- */
 public class LikePlotMeConverter {
+
     private final String plugin;
-    
+
     /**
-     * Constructor
+     * Constructor.
      *
      * @param plugin Plugin Used to run the converter
      */
-    public LikePlotMeConverter(final String plugin) {
+    public LikePlotMeConverter(String plugin) {
         this.plugin = plugin;
     }
-    
+
-    public static String getWorld(final String world) {
+    public static String getWorld(String world) {
-        for (final World newworld : Bukkit.getWorlds()) {
+        for (World newWorld : Bukkit.getWorlds()) {
-            if (newworld.getName().equalsIgnoreCase(world)) {
+            if (newWorld.getName().equalsIgnoreCase(world)) {
-                return newworld.getName();
+                return newWorld.getName();
             }
         }
         return world;
     }
-    
+
-    private void sendMessage(final String message) {
+    private void sendMessage(String message) {
         PS.debug("&3PlotMe&8->&3PlotSquared&8: &7" + message);
     }
-    
+
     public String getPlotMePath() {
-        return new File(".").getAbsolutePath() + File.separator + "plugins" + File.separator + plugin + File.separator;
+        return new File(".").getAbsolutePath() + File.separator + "plugins" + File.separator + this.plugin + File.separator;
     }
-    
+
     public String getAthionPlotsPath() {
-        return new File(".").getAbsolutePath() + File.separator + "plugins" + File.separator + plugin + File.separator;
+        return new File(".").getAbsolutePath() + File.separator + "plugins" + File.separator + this.plugin + File.separator;
     }
-    
+
-    public FileConfiguration getPlotMeConfig(final String dataFolder) {
+    public FileConfiguration getPlotMeConfig(String dataFolder) {
-        final File plotMeFile = new File(dataFolder + "config.yml");
+        File plotMeFile = new File(dataFolder + "config.yml");
         if (!plotMeFile.exists()) {
             return null;
         }
         return YamlConfiguration.loadConfiguration(plotMeFile);
     }
-    
+
-    public Set<String> getPlotMeWorlds(final FileConfiguration plotConfig) {
+    public Set<String> getPlotMeWorlds(FileConfiguration plotConfig) {
         return plotConfig.getConfigurationSection("worlds").getKeys(false);
     }
-    
+
-    public void mergeWorldYml(final String plugin, FileConfiguration plotConfig) {
+    public void mergeWorldYml(String plugin, FileConfiguration plotConfig) {
         try {
-            File genConfig = new File("plugins" + File.separator + plugin + File.separator + "PlotMe-DefaultGenerator" + File.separator + "config.yml");
+            File genConfig =
+                    new File("plugins" + File.separator + plugin + File.separator + "PlotMe-DefaultGenerator" + File.separator + "config.yml");
             if (genConfig.exists()) {
                 YamlConfiguration yml = YamlConfiguration.loadConfiguration(genConfig);
                 for (String key : yml.getKeys(true)) {
@@ -116,36 +92,35 @@ public class LikePlotMeConverter {
                     }
                 }
             }
-        }
+        } catch (Exception e) {
-        catch (Exception e) {
             e.printStackTrace();
         }
     }
-    
+
-    public void updateWorldYml(final String plugin, final String location) {
+    public void updateWorldYml(String plugin, String location) {
         try {
-            final Path path = Paths.get(location);
+            Path path = Paths.get(location);
-            final File file = new File(location);
+            File file = new File(location);
             if (!file.exists()) {
                 return;
             }
-            final Charset charset = StandardCharsets.UTF_8;
+            String content = new String(Files.readAllBytes(path), StandardCharsets.UTF_8);
-            String content = new String(Files.readAllBytes(path), charset);
             content = content.replaceAll("PlotMe-DefaultGenerator", "PlotSquared");
             content = content.replaceAll(plugin, "PlotSquared");
-            Files.write(path, content.getBytes(charset));
+            Files.write(path, content.getBytes(StandardCharsets.UTF_8));
-        } catch (IOException e) {
+        } catch (IOException ignored) {
+            //ignored
         }
     }
-    
+
-    public boolean run(final APlotMeConnector connector) {
+    public boolean run(APlotMeConnector connector) {
         try {
-            final String dataFolder = getPlotMePath();
+            String dataFolder = getPlotMePath();
-            final FileConfiguration plotConfig = getPlotMeConfig(dataFolder);
+            FileConfiguration plotConfig = getPlotMeConfig(dataFolder);
             if (plotConfig == null) {
                 return false;
             }
-            
+
             String version = plotConfig.getString("Version");
             if (version == null) {
                 version = plotConfig.getString("version");
@@ -153,66 +128,67 @@ public class LikePlotMeConverter {
             if (!connector.accepts(version)) {
                 return false;
             }
-            
+
             PS.debug("&3Using connector: " + connector.getClass().getCanonicalName());
-            
+
-            final Connection connection = connector.getPlotMeConnection(plugin, plotConfig, dataFolder);
+            Connection connection = connector.getPlotMeConnection(this.plugin, plotConfig, dataFolder);
-            
+
             if (!connector.isValidConnection(connection)) {
                 sendMessage("Cannot connect to PlotMe DB. Conversion process will not continue");
                 return false;
             }
-            
+
-            sendMessage(plugin + " conversion has started. To disable this, please set 'plotme-convert.enabled' to false in the 'settings.yml'");
+            sendMessage(this.plugin + " conversion has started. To disable this, please set 'plotme-convert.enabled' to false in the 'settings.yml'");
-            
+
-            mergeWorldYml(plugin, plotConfig);
+            mergeWorldYml(this.plugin, plotConfig);
-            
+
-            sendMessage("Connecting to " + plugin + " DB");
+            sendMessage("Connecting to " + this.plugin + " DB");
-            
+
-            int plotCount = 0;
+            ArrayList<Plot> createdPlots = new ArrayList<>();
-            final ArrayList<Plot> createdPlots = new ArrayList<>();
+
-            
             sendMessage("Collecting plot data");
-            
+
-            final String dbPrefix = plugin.toLowerCase();
+            String dbPrefix = this.plugin.toLowerCase();
             sendMessage(" - " + dbPrefix + "Plots");
             final Set<String> worlds = getPlotMeWorlds(plotConfig);
-            
+
             if (Settings.CONVERT_PLOTME) {
                 sendMessage("Updating bukkit.yml");
-                updateWorldYml(plugin, "bukkit.yml");
+                updateWorldYml(this.plugin, "bukkit.yml");
-                updateWorldYml(plugin, "plugins/Multiverse-Core/worlds.yml");
+                updateWorldYml(this.plugin, "plugins/Multiverse-Core/worlds.yml");
-                for (final String world : plotConfig.getConfigurationSection("worlds").getKeys(false)) {
+                for (String world : plotConfig.getConfigurationSection("worlds").getKeys(false)) {
                     sendMessage("Copying config for: " + world);
                     try {
-                        final String actualWorldName = getWorld(world);
+                        String actualWorldName = getWorld(world);
                         connector.copyConfig(plotConfig, world, actualWorldName);
                         PS.get().config.save(PS.get().configFile);
-                    } catch (final Exception e) {
+                    } catch (IOException e) {
                         e.printStackTrace();
-                        sendMessage("&c-- &lFailed to save configuration for world '" + world + "'\nThis will need to be done using the setup command, or manually");
+                        sendMessage("&c-- &lFailed to save configuration for world '" + world
+                                + "'\nThis will need to be done using the setup command, or manually");
                     }
                 }
             }
-            final HashMap<String, HashMap<PlotId, Plot>> plots = connector.getPlotMePlots(connection);
+            HashMap<String, HashMap<PlotId, Plot>> plots = connector.getPlotMePlots(connection);
-            for (final Entry<String, HashMap<PlotId, Plot>> entry : plots.entrySet()) {
+            int plotCount = 0;
+            for (Entry<String, HashMap<PlotId, Plot>> entry : plots.entrySet()) {
                 plotCount += entry.getValue().size();
             }
             if (!Settings.CONVERT_PLOTME) {
                 return false;
             }
-            
+
             sendMessage(" - " + dbPrefix + "Allowed");
-            
+
             sendMessage("Collected " + plotCount + " plots from PlotMe");
-            final File PLOTME_DG_FILE = new File(dataFolder + File.separator + "PlotMe-DefaultGenerator" + File.separator + "config.yml");
+            File plotmeDgFile = new File(dataFolder + File.separator + "PlotMe-DefaultGenerator" + File.separator + "config.yml");
-            if (PLOTME_DG_FILE.exists()) {
+            if (plotmeDgFile.exists()) {
-                final YamlConfiguration PLOTME_DG_YML = YamlConfiguration.loadConfiguration(PLOTME_DG_FILE);
+                YamlConfiguration plotmeDgYml = YamlConfiguration.loadConfiguration(plotmeDgFile);
                 try {
-                    for (final String world : plots.keySet()) {
+                    for (String world : plots.keySet()) {
-                        final String actualWorldName = getWorld(world);
+                        String actualWorldName = getWorld(world);
-                        final String plotMeWorldName = world.toLowerCase();
+                        String plotMeWorldName = world.toLowerCase();
-                        Integer pathwidth = PLOTME_DG_YML.getInt("worlds." + plotMeWorldName + ".PathWidth"); //
+                        Integer pathwidth = plotmeDgYml.getInt("worlds." + plotMeWorldName + ".PathWidth"); //
                         /*
                          * TODO: dead code
                          * 
@@ -222,41 +198,29 @@ public class LikePlotMeConverter {
                         */
                         PS.get().config.set("worlds." + world + ".road.width", pathwidth);
 
-                        Integer pathheight = PLOTME_DG_YML.getInt("worlds." + plotMeWorldName + ".RoadHeight"); //
+                        Integer pathheight = plotmeDgYml.getInt("worlds." + plotMeWorldName + ".RoadHeight"); //
                         if (pathheight == 0) {
                             pathheight = 64;
                         }
                         PS.get().config.set("worlds." + world + ".road.height", pathheight);
                         PS.get().config.set("worlds." + world + ".wall.height", pathheight);
                         PS.get().config.set("worlds." + world + ".plot.height", pathheight);
-                        Integer plotsize = PLOTME_DG_YML.getInt("worlds." + plotMeWorldName + ".PlotSize"); //
+                        Integer plotSize = plotmeDgYml.getInt("worlds." + plotMeWorldName + ".PlotSize"); //
-                        if (plotsize == 0) {
+                        if (plotSize == 0) {
-                            plotsize = 32;
+                            plotSize = 32;
-                        }
-                        PS.get().config.set("worlds." + world + ".plot.size", plotsize);
-                        String wallblock = PLOTME_DG_YML.getString("worlds." + plotMeWorldName + ".WallBlock"); //
-                        if (wallblock == null) {
-                            wallblock = "44";
                         }
+                        PS.get().config.set("worlds." + world + ".plot.size", plotSize);
+                        String wallblock = plotmeDgYml.getString("worlds." + plotMeWorldName + ".WallBlock", "44"); //
                         PS.get().config.set("worlds." + world + ".wall.block", wallblock);
-                        String floor = PLOTME_DG_YML.getString("worlds." + plotMeWorldName + ".PlotFloorBlock"); //
+                        String floor = plotmeDgYml.getString("worlds." + plotMeWorldName + ".PlotFloorBlock", "2"); //
-                        if (floor == null) {
-                            floor = "2";
-                        }
                         PS.get().config.set("worlds." + world + ".plot.floor", Collections.singletonList(floor));
-                        String filling = PLOTME_DG_YML.getString("worlds." + plotMeWorldName + ".FillBlock"); //
+                        String filling = plotmeDgYml.getString("worlds." + plotMeWorldName + ".FillBlock", "3"); //
-                        if (filling == null) {
-                            filling = "3";
-                        }
                         PS.get().config.set("worlds." + world + ".plot.filling", Collections.singletonList(filling));
-                        String road = PLOTME_DG_YML.getString("worlds." + plotMeWorldName + ".RoadMainBlock");
+                        String road = plotmeDgYml.getString("worlds." + plotMeWorldName + ".RoadMainBlock", "5");
-                        if (road == null) {
-                            road = "5";
-                        }
                         PS.get().config.set("worlds." + world + ".road.block", road);
-                        Integer height = PLOTME_DG_YML.getInt("worlds." + plotMeWorldName + ".RoadHeight"); //
+                        Integer height = plotmeDgYml.getInt("worlds." + plotMeWorldName + ".RoadHeight"); //
                         if (height == 0) {
-                            height = PLOTME_DG_YML.getInt("worlds." + plotMeWorldName + ".GroundHeight"); //
+                            height = plotmeDgYml.getInt("worlds." + plotMeWorldName + ".GroundHeight"); //
                             if (height == 0) {
                                 height = 64;
                             }
@@ -266,7 +230,8 @@ public class LikePlotMeConverter {
                         PS.get().config.set("worlds." + actualWorldName + ".wall.height", height);
                         PS.get().config.save(PS.get().configFile);
                     }
-                } catch (IOException e) {
+                } catch (IOException ignored) {
+                    //ignored
                 }
             }
             for (Entry<String, HashMap<PlotId, Plot>> entry : plots.entrySet()) {
@@ -282,7 +247,8 @@ public class LikePlotMeConverter {
                         }
                     }
                     if (duplicate > 0) {
-                        PS.debug("&c[WARNING] Found " + duplicate + " duplicate plots already in DB for world: '" + world + "'. Have you run the converter already?");
+                        PS.debug("&c[WARNING] Found " + duplicate + " duplicate plots already in DB for world: '" + world
+                                + "'. Have you run the converter already?");
                     }
                 } else {
                     if (PS.get().plots_tmp != null) {
@@ -296,7 +262,8 @@ public class LikePlotMeConverter {
                                 }
                             }
                             if (duplicate > 0) {
-                                PS.debug("&c[WARNING] Found " + duplicate + " duplicate plots already in DB for world: '" + world + "'. Have you run the converter already?");
+                                PS.debug("&c[WARNING] Found " + duplicate + " duplicate plots already in DB for world: '" + world
+                                        + "'. Have you run the converter already?");
                             }
                             continue;
                         }
@@ -327,57 +294,61 @@ public class LikePlotMeConverter {
             sendMessage("Saving configuration...");
             try {
                 PS.get().config.save(PS.get().configFile);
-            } catch (final IOException e) {
+            } catch (IOException e) {
                 sendMessage(" - &cFailed to save configuration.");
             }
             TaskManager.runTask(new Runnable() {
                 @Override
                 public void run() {
                     try {
-                        boolean MV = false;
+                        boolean mv = false;
-                        boolean MW = false;
+                        boolean mw = false;
-                        if ((Bukkit.getPluginManager().getPlugin("Multiverse-Core") != null) && Bukkit.getPluginManager().getPlugin("Multiverse-Core").isEnabled()) {
+                        if ((Bukkit.getPluginManager().getPlugin("Multiverse-Core") != null) && Bukkit.getPluginManager().getPlugin("Multiverse-Core")
-                            MV = true;
+                                .isEnabled()) {
-                        } else if ((Bukkit.getPluginManager().getPlugin("MultiWorld") != null) && Bukkit.getPluginManager().getPlugin("MultiWorld").isEnabled()) {
+                            mv = true;
-                            MW = true;
+                        } else if ((Bukkit.getPluginManager().getPlugin("MultiWorld") != null) && Bukkit.getPluginManager().getPlugin("MultiWorld")
+                                .isEnabled()) {
+                            mw = true;
                         }
-                        for (final String worldname : worlds) {
+                        for (String worldName : worlds) {
-                            final World world = Bukkit.getWorld(getWorld(worldname));
+                            World world = Bukkit.getWorld(getWorld(worldName));
                             if (world == null) {
-                                sendMessage("&cInvalid world in PlotMe configuration: " + worldname);
+                                sendMessage("&cInvalid world in PlotMe configuration: " + worldName);
                             }
-                            final String actualWorldName = world.getName();
+                            String actualWorldName = world.getName();
                             sendMessage("Reloading generator for world: '" + actualWorldName + "'...");
                             PS.get().removePlotAreas(actualWorldName);
-                            if (MV) {
+                            if (mv) {
                                 // unload world with MV
                                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mv unload " + actualWorldName);
                                 try {
                                     Thread.sleep(1000);
-                                } catch (final InterruptedException ex) {
+                                } catch (InterruptedException ex) {
                                     Thread.currentThread().interrupt();
                                 }
                                 // load world with MV
-                                Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mv import " + actualWorldName + " normal -g PlotSquared");
+                                Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(),
-                            } else if (MW) {
+                                        "mv import " + actualWorldName + " normal -g PlotSquared");
+                            } else if (mw) {
                                 // unload world with MW
                                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mw unload " + actualWorldName);
                                 try {
                                     Thread.sleep(1000);
-                                } catch (final InterruptedException ex) {
+                                } catch (InterruptedException ex) {
                                     Thread.currentThread().interrupt();
                                 }
                                 // load world with MW
-                                Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mw create " + actualWorldName + " plugin:PlotSquared");
+                                Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(),
+                                        "mw create " + actualWorldName + " plugin:PlotSquared");
                             } else {
                                 // Load using Bukkit API
                                 // - User must set generator manually
                                 Bukkit.getServer().unloadWorld(world, true);
-                                final World myworld = WorldCreator.name(actualWorldName).generator(new BukkitPlotGenerator(new HybridGen())).createWorld();
+                                World myWorld = WorldCreator.name(actualWorldName).generator(new BukkitPlotGenerator(new HybridGen())).createWorld();
-                                myworld.save();
+                                myWorld.save();
                             }
                         }
-                    } catch (final Exception e) {
+                    } catch (CommandException e) {
                         e.printStackTrace();
                     }
                     if (done.get()) {
@@ -393,13 +364,13 @@ public class LikePlotMeConverter {
                     }
                 }
             });
-        } catch (final Exception e) {
+        } catch (Exception e) {
             e.printStackTrace();
             PS.debug("&/end/");
         }
         return true;
     }
-    
+
     public void done() {
         PS.get().setPlots(DBFunc.getPlots());
     }

Bukkit/src/main/java/com/plotsquared/bukkit/database/plotme/PlotMeConnector_017.java

@@ -23,39 +23,43 @@ import java.util.Map.Entry;
 import java.util.UUID;
 
 public class PlotMeConnector_017 extends APlotMeConnector {
+
     private String plugin;
 
     @Override
-    public Connection getPlotMeConnection(final String plugin, final FileConfiguration plotConfig, final String dataFolder) {
+    public Connection getPlotMeConnection(String plugin, FileConfiguration plotConfig, String dataFolder) {
         this.plugin = plugin.toLowerCase();
         try {
             if (plotConfig.getBoolean("usemySQL")) {
-                final String user = plotConfig.getString("mySQLuname");
+                String user = plotConfig.getString("mySQLuname");
-                final String password = plotConfig.getString("mySQLpass");
+                String password = plotConfig.getString("mySQLpass");
-                final String con = plotConfig.getString("mySQLconn");
+                String con = plotConfig.getString("mySQLconn");
                 return DriverManager.getConnection(con, user, password);
             } else {
-                final File file = new File(dataFolder + File.separator + "plotmecore.db");
+                File file = new File(dataFolder + File.separator + "plotmecore.db");
                 if (file.exists()) {
                     return new SQLite(dataFolder + File.separator + "plotmecore.db").openConnection();
                 }
                 return new SQLite(dataFolder + File.separator + "plots.db").openConnection();
             }
-        } catch (SQLException | ClassNotFoundException e) {}
+        } catch (SQLException | ClassNotFoundException ignored) {
+            //ignored
+            ignored.printStackTrace();
+        }
         return null;
     }
-    
+
     @Override
-    public HashMap<String, HashMap<PlotId, Plot>> getPlotMePlots(final Connection connection) throws SQLException {
+    public HashMap<String, HashMap<PlotId, Plot>> getPlotMePlots(Connection connection) throws SQLException {
-        ResultSet r;
+        ResultSet resultSet;
-        PreparedStatement stmt;
+        PreparedStatement statement;
-        final HashMap<String, Integer> plotWidth = new HashMap<>();
+        HashMap<String, Integer> plotWidth = new HashMap<>();
-        final HashMap<String, Integer> roadWidth = new HashMap<>();
+        HashMap<String, Integer> roadWidth = new HashMap<>();
-        final HashMap<Integer, Plot> plots = new HashMap<>();
+        HashMap<Integer, Plot> plots = new HashMap<>();
-        final HashMap<String, HashMap<PlotId, boolean[]>> merges = new HashMap<>();
+        HashMap<String, HashMap<PlotId, boolean[]>> merges = new HashMap<>();
         try {
-            stmt = connection.prepareStatement("SELECT * FROM `" + plugin + "core_plots`");
+            statement = connection.prepareStatement("SELECT * FROM `" + this.plugin + "core_plots`");
-            r = stmt.executeQuery();
+            resultSet = statement.executeQuery();
         } catch (SQLException e) {
             PS.debug("========= Table does not exist =========");
             e.printStackTrace();
@@ -64,31 +68,29 @@ public class PlotMeConnector_017 extends APlotMeConnector {
             PS.debug("&8 - &7Please correct this, or if you are unsure, the most common is 0.16.3");
             return null;
         }
-        final boolean checkUUID = DBFunc.hasColumn(r, "ownerID");
+        boolean checkUUID = DBFunc.hasColumn(resultSet, "ownerID");
-        final boolean merge = !plugin.equals("plotme") && Settings.CONVERT_PLOTME;
+        boolean merge = !this.plugin.equals("plotme") && Settings.CONVERT_PLOTME;
-        while (r.next()) {
+        while (resultSet.next()) {
-            final int key = r.getInt("plot_id");
+            int key = resultSet.getInt("plot_id");
-            final PlotId id = new PlotId(r.getInt("plotX"), r.getInt("plotZ"));
+            PlotId id = new PlotId(resultSet.getInt("plotX"), resultSet.getInt("plotZ"));
-            final String name = r.getString("owner");
+            String name = resultSet.getString("owner");
-            final String world = LikePlotMeConverter.getWorld(r.getString("world"));
+            String world = LikePlotMeConverter.getWorld(resultSet.getString("world"));
-            if (!plots.containsKey(world)) {
+            if (!plots.containsKey(world) && merge) {
-                if (merge) {
+                int plot = PS.get().config.getInt("worlds." + world + ".plot.size");
-                    final int plot = PS.get().config.getInt("worlds." + world + ".plot.size");
+                int path = PS.get().config.getInt("worlds." + world + ".road.width");
-                    final int path = PS.get().config.getInt("worlds." + world + ".road.width");
+                plotWidth.put(world, plot);
-                    plotWidth.put(world, plot);
+                roadWidth.put(world, path);
-                    roadWidth.put(world, path);
+                merges.put(world, new HashMap<PlotId, boolean[]>());
-                    merges.put(world, new HashMap<PlotId, boolean[]>());
-                }
             }
             if (merge) {
-                final int tx = r.getInt("topX");
+                int tx = resultSet.getInt("topX");
-                final int tz = r.getInt("topZ");
+                int tz = resultSet.getInt("topZ");
-                final int bx = r.getInt("bottomX") - 1;
+                int bx = resultSet.getInt("bottomX") - 1;
-                final int bz = r.getInt("bottomZ") - 1;
+                int bz = resultSet.getInt("bottomZ") - 1;
-                final int path = roadWidth.get(world);
+                int path = roadWidth.get(world);
-                final int plot = plotWidth.get(world);
+                int plot = plotWidth.get(world);
-                final Location top = getPlotTopLocAbs(path, plot, id);
+                Location top = getPlotTopLocAbs(path, plot, id);
-                final Location bot = getPlotBottomLocAbs(path, plot, id);
+                Location bot = getPlotBottomLocAbs(path, plot, id);
                 if (tx > top.getX()) {
                     setMerged(merges, world, id, 1);
                 }
@@ -109,12 +111,12 @@ public class PlotMeConnector_017 extends APlotMeConnector {
                 } else {
                     if (checkUUID) {
                         try {
-                            final byte[] bytes = r.getBytes("ownerid");
+                            byte[] bytes = resultSet.getBytes("ownerid");
                             if (bytes != null) {
                                 owner = UUID.nameUUIDFromBytes(bytes);
                                 UUIDHandler.add(new StringWrapper(name), owner);
                             }
-                        } catch (final Exception e) {
+                        } catch (Exception e) {
                             e.printStackTrace();
                         }
                     }
@@ -126,60 +128,60 @@ public class PlotMeConnector_017 extends APlotMeConnector {
             } else {
                 UUIDHandler.add(new StringWrapper(name), owner);
             }
-            final Plot plot = new Plot(PlotArea.createGeneric(world), id, owner);
+            Plot plot = new Plot(PlotArea.createGeneric(world), id, owner);
             plots.put(key, plot);
         }
-        for (final Entry<Integer, Plot> entry : plots.entrySet()) {
+        for (Entry<Integer, Plot> entry : plots.entrySet()) {
-            final Plot plot = entry.getValue();
+            Plot plot = entry.getValue();
-            final HashMap<PlotId, boolean[]> mergeMap = merges.get(plot.getArea().worldname);
+            HashMap<PlotId, boolean[]> mergeMap = merges.get(plot.getArea().worldname);
             if (mergeMap != null) {
                 if (mergeMap.containsKey(plot.getId())) {
                     plot.setMerged(mergeMap.get(plot.getId()));
                 }
             }
         }
-        r.close();
+        resultSet.close();
-        stmt.close();
+        statement.close();
         try {
-            PS.log(" - " + plugin + "core_denied");
+            PS.log(" - " + this.plugin + "core_denied");
-            stmt = connection.prepareStatement("SELECT * FROM `" + plugin + "core_denied`");
+            statement = connection.prepareStatement("SELECT * FROM `" + this.plugin + "core_denied`");
-            r = stmt.executeQuery();
+            resultSet = statement.executeQuery();
 
-            while (r.next()) {
+            while (resultSet.next()) {
-                final int key = r.getInt("plot_id");
+                int key = resultSet.getInt("plot_id");
-                final Plot plot = plots.get(key);
+                Plot plot = plots.get(key);
                 if (plot == null) {
                     PS.log("&6Denied (" + key + ") references deleted plot; ignoring entry.");
                     continue;
                 }
-                final UUID denied = UUID.fromString(r.getString("player"));
+                UUID denied = UUID.fromString(resultSet.getString("player"));
                 plot.getDenied().add(denied);
             }
 
-            PS.log(" - " + plugin + "core_allowed");
+            PS.log(" - " + this.plugin + "core_allowed");
-            stmt = connection.prepareStatement("SELECT * FROM `" + plugin + "core_allowed`");
+            statement = connection.prepareStatement("SELECT * FROM `" + this.plugin + "core_allowed`");
-            r = stmt.executeQuery();
+            resultSet = statement.executeQuery();
 
-            while (r.next()) {
+            while (resultSet.next()) {
-                final int key = r.getInt("plot_id");
+                int key = resultSet.getInt("plot_id");
-                final Plot plot = plots.get(key);
+                Plot plot = plots.get(key);
                 if (plot == null) {
                     PS.log("&6Allowed (" + key + ") references deleted plot; ignoring entry.");
                     continue;
                 }
-                final UUID allowed = UUID.fromString(r.getString("player"));
+                UUID allowed = UUID.fromString(resultSet.getString("player"));
                 plot.getTrusted().add(allowed);
             }
-            r.close();
+            resultSet.close();
-            stmt.close();
+            statement.close();
 
         } catch (SQLException e) {
             e.printStackTrace();
         }
-        final HashMap<String, HashMap<PlotId, Plot>> processed = new HashMap<>();
+        HashMap<String, HashMap<PlotId, Plot>> processed = new HashMap<>();
-        
+
-        for (final Entry<Integer, Plot> entry : plots.entrySet()) {
+        for (Entry<Integer, Plot> entry : plots.entrySet()) {
-            final Plot plot = entry.getValue();
+            Plot plot = entry.getValue();
             HashMap<PlotId, Plot> map = processed.get(plot.getArea().worldname);
             if (map == null) {
                 map = new HashMap<>();
@@ -189,9 +191,9 @@ public class PlotMeConnector_017 extends APlotMeConnector {
         }
         return processed;
     }
-    
+
     @Override
-    public boolean accepts(final String version) {
+    public boolean accepts(String version) {
         if (version == null) {
             return false;
         }

Bukkit/src/main/java/com/plotsquared/bukkit/events/ClusterFlagRemoveEvent.java

@@ -1,89 +1,66 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
+import com.intellectualcrafters.plot.flag.Flag;
+import com.intellectualcrafters.plot.object.PlotCluster;
 import org.bukkit.event.Cancellable;
 import org.bukkit.event.Event;
 import org.bukkit.event.HandlerList;
 
-import com.intellectualcrafters.plot.flag.Flag;
-import com.intellectualcrafters.plot.object.PlotCluster;
-
 /**
- * Called when a flag is removed from a plot
+ * Called when a flag is removed from a plot.
- *
-
-
  */
 public class ClusterFlagRemoveEvent extends Event implements Cancellable {
-    private static HandlerList handlers = new HandlerList();
+
+    private static final HandlerList handlers = new HandlerList();
     private final PlotCluster cluster;
     private final Flag flag;
     private boolean cancelled;
-    
+
     /**
-     * PlotFlagRemoveEvent: Called when a flag is removed from a plot
+     * PlotFlagRemoveEvent: Called when a flag is removed from a plot.
      *
      * @param flag Flag that was removed
      * @param cluster PlotCluster from which the flag was removed
      */
-    public ClusterFlagRemoveEvent(final Flag flag, final PlotCluster cluster) {
+    public ClusterFlagRemoveEvent(Flag flag, PlotCluster cluster) {
         this.cluster = cluster;
         this.flag = flag;
     }
-    
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-    
+
     /**
-     * Get the cluster involved
+     * Get the cluster involved.
      *
      * @return PlotCluster
      */
     public PlotCluster getCluster() {
-        return cluster;
+        return this.cluster;
     }
-    
+
     /**
-     * Get the flag involved
+     * Get the flag involved.
      *
      * @return Flag
      */
     public Flag getFlag() {
-        return flag;
+        return this.flag;
     }
-    
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-    
+
     @Override
     public boolean isCancelled() {
-        return cancelled;
+        return this.cancelled;
     }
-    
+
     @Override
-    public void setCancelled(final boolean b) {
+    public void setCancelled(boolean b) {
-        cancelled = b;
+        this.cancelled = b;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerClaimPlotEvent.java

@@ -1,84 +1,62 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
+import com.intellectualcrafters.plot.object.Plot;
 import org.bukkit.entity.Player;
 import org.bukkit.event.Cancellable;
 import org.bukkit.event.HandlerList;
 import org.bukkit.event.player.PlayerEvent;
 
-import com.intellectualcrafters.plot.object.Plot;
-
-/**
-
 public class PlayerClaimPlotEvent extends PlayerEvent implements Cancellable {
- */
+
+    private static final HandlerList handlers = new HandlerList();
     private final Plot plot;
     private final boolean auto;
     private boolean cancelled;
-    private final boolean auto;
+
     /**
-    
+     * PlayerClaimPlotEvent: Called when a plot is claimed.
      *
      * @param player Player that claimed the plot
      * @param plot   Plot that was claimed
      */
-     * @param plot   Plot that was claimed
+    public PlayerClaimPlotEvent(Player player, Plot plot, boolean auto) {
         super(player);
         this.plot = plot;
         this.auto = auto;
     }
-        this.auto = auto;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
      * Get the plot involved
      *
      * @return Plot
      */
     public Plot getPlot() {
-     */
+        return this.plot;
     }
-        return plot;
+
     /**
      * @return true if it was an automated claim, else false
      */
     public boolean wasAuto() {
-     */
+        return this.auto;
     }
-        return auto;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-        return handlers;
+
     @Override
     public boolean isCancelled() {
-    @Override
+        return this.cancelled;
     }
-        return cancelled;
+
     @Override
-    
+    public void setCancelled(boolean b) {
-    @Override
+        this.cancelled = b;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerEnterPlotEvent.java

@@ -1,61 +1,39 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
+import com.intellectualcrafters.plot.object.Plot;
 import org.bukkit.entity.Player;
 import org.bukkit.event.HandlerList;
 import org.bukkit.event.player.PlayerEvent;
 
-import com.intellectualcrafters.plot.object.Plot;
-
-/**
-
 public class PlayerEnterPlotEvent extends PlayerEvent {
- */
+
+    private static final HandlerList handlers = new HandlerList();
     private final Plot plot;
-    private static HandlerList handlers = new HandlerList();
+
     /**
-    
+     * Called when a player leaves a plot.
      *
      * @param player Player that entered the plot
      * @param plot   Plot that was entered
      */
-     * @param plot   Plot that was entered
+    public PlayerEnterPlotEvent(Player player, Plot plot) {
         super(player);
         this.plot = plot;
     }
-        this.plot = plot;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
-    
+     * Get the plot involved.
      *
      * @return Plot
      */
     public Plot getPlot() {
-     */
+        return this.plot;
     }
-        return plot;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerLeavePlotEvent.java

@@ -1,62 +1,43 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
+import com.intellectualcrafters.plot.object.Plot;
 import org.bukkit.entity.Player;
 import org.bukkit.event.HandlerList;
 import org.bukkit.event.player.PlayerEvent;
 
-import com.intellectualcrafters.plot.object.Plot;
+/**
+
 
-/**
  */
 public class PlayerLeavePlotEvent extends PlayerEvent {
- */
+
-public class PlayerLeavePlotEvent extends PlayerEvent {
+    private static final HandlerList handlers = new HandlerList();
     private final Plot plot;
-    private static HandlerList handlers = new HandlerList();
+
     /**
      * PlayerLeavePlotEvent: Called when a player leaves a plot
      *
      * @param player Player that left the plot
      * @param plot   Plot that was left
      */
-     * @param plot   Plot that was left
+    public PlayerLeavePlotEvent(Player player, Plot plot) {
         super(player);
         this.plot = plot;
     }
-        this.plot = plot;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
      * Get the plot involved
      *
      * @return Plot
      */
     public Plot getPlot() {
-     */
+        return this.plot;
     }
-        return plot;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerPlotDeniedEvent.java

@@ -1,87 +1,64 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import java.util.UUID;
+import com.intellectualcrafters.plot.object.Plot;
-
 import org.bukkit.entity.Player;
 import org.bukkit.event.HandlerList;
 
-import com.intellectualcrafters.plot.object.Plot;
+import java.util.UUID;
 
-/**
-
 public class PlayerPlotDeniedEvent extends PlotEvent {
- */
+
-public class PlayerPlotDeniedEvent extends PlotEvent {
+    private static final HandlerList handlers = new HandlerList();
     private final Player initiator;
     private final boolean added;
     private final UUID player;
-    private final boolean added;
+
     /**
-    
+     * PlayerPlotDeniedEvent: Called when the denied UUID list is modified for a plot.
      *
      * @param initiator Player that initiated the event
      * @param plot      Plot in which the event occurred
      * @param player    Player that was denied/un-denied
      * @param added     true of add to deny list, false if removed
      */
-     * @param added     true of add to deny list, false if removed
+    public PlayerPlotDeniedEvent(Player initiator, Plot plot, UUID player, boolean added) {
         super(plot);
         this.initiator = initiator;
         this.added = added;
         this.player = player;
     }
-        this.player = player;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
-    
+     * If a user was added.
      *
      * @return boolean
      */
     public boolean wasAdded() {
-     */
+        return this.added;
     }
-        return added;
+
     /**
-    
+     * The player added/removed.
      *
      * @return UUID
      */
     public UUID getPlayer() {
-     */
+        return this.player;
     }
-        return player;
+
     /**
-    
+     * The player initiating the action.
      *
      * @return Player
      */
     public Player getInitiator() {
-     */
+        return this.initiator;
     }
-        return initiator;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerPlotHelperEvent.java

@@ -1,41 +1,22 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import java.util.UUID;
+import com.intellectualcrafters.plot.object.Plot;
-
 import org.bukkit.entity.Player;
 import org.bukkit.event.HandlerList;
 
-import com.intellectualcrafters.plot.object.Plot;
+import java.util.UUID;
+
+/**
+
 
-/**
  */
 public class PlayerPlotHelperEvent extends PlotEvent {
- */
+
-public class PlayerPlotHelperEvent extends PlotEvent {
+    private static final HandlerList handlers = new HandlerList();
     private final Player initiator;
     private final boolean added;
     private final UUID player;
-    private final boolean added;
+
     /**
      * PlayerPlotHelperEvent: Called when a plot helper is added/removed
      *
@@ -44,44 +25,44 @@ public class PlayerPlotHelperEvent extends PlotEvent {
      * @param player    Player that was added/removed from the helper list
      * @param added     true of the player was added, false if the player was removed
      */
-     * @param added     true of the player was added, false if the player was removed
+    public PlayerPlotHelperEvent(Player initiator, Plot plot, UUID player, boolean added) {
         super(plot);
         this.initiator = initiator;
         this.added = added;
         this.player = player;
     }
-        this.player = player;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
      * If a player was added
      *
      * @return boolean
      */
     public boolean wasAdded() {
-     */
+        return this.added;
     }
-        return added;
+
     /**
      * The UUID added/removed
      *
      * @return UUID
      */
     public UUID getPlayer() {
-     */
+        return this.player;
     }
-        return player;
+
     /**
      * The player initiating the action
      *
      * @return Player
      */
     public Player getInitiator() {
-     */
+        return this.initiator;
     }
-        return initiator;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerPlotTrustedEvent.java

@@ -1,41 +1,22 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import java.util.UUID;
+import com.intellectualcrafters.plot.object.Plot;
-
 import org.bukkit.entity.Player;
 import org.bukkit.event.HandlerList;
 
-import com.intellectualcrafters.plot.object.Plot;
+import java.util.UUID;
+
+/**
+
 
-/**
  */
 public class PlayerPlotTrustedEvent extends PlotEvent {
- */
+
-public class PlayerPlotTrustedEvent extends PlotEvent {
+    private static final HandlerList handlers = new HandlerList();
     private final Player initiator;
     private final boolean added;
     private final UUID player;
-    private final boolean added;
+
     /**
      * PlayerPlotTrustedEvent: Called when a plot trusted user is added/removed
      *
@@ -44,44 +25,44 @@ public class PlayerPlotTrustedEvent extends PlotEvent {
      * @param player    Player that was added/removed from the trusted list
      * @param added     true of the player was added, false if the player was removed
      */
-     * @param added     true of the player was added, false if the player was removed
+    public PlayerPlotTrustedEvent(Player initiator, Plot plot, UUID player, boolean added) {
         super(plot);
         this.initiator = initiator;
         this.added = added;
         this.player = player;
     }
-        this.player = player;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
      * If a player was added
      *
      * @return boolean
      */
     public boolean wasAdded() {
-     */
+        return this.added;
     }
-        return added;
+
     /**
      * The UUID added/removed
      *
      * @return UUID
      */
     public UUID getPlayer() {
-     */
+        return this.player;
     }
-        return player;
+
     /**
      * The player initiating the action
      *
      * @return Player
      */
     public Player getInitiator() {
-     */
+        return this.initiator;
     }
-        return initiator;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlayerTeleportToPlotEvent.java

@@ -1,43 +1,25 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
+import com.intellectualcrafters.plot.object.Location;
+import com.intellectualcrafters.plot.object.Plot;
 import org.bukkit.entity.Player;
 import org.bukkit.event.Cancellable;
 import org.bukkit.event.HandlerList;
 import org.bukkit.event.player.PlayerEvent;
 
-import com.intellectualcrafters.plot.object.Location;
-import com.intellectualcrafters.plot.object.Plot;
-
 /**
  * Called when a player teleports to a plot
- *
+ *
+
+
  */
 public class PlayerTeleportToPlotEvent extends PlayerEvent implements Cancellable {
+
     private static final HandlerList handlers = new HandlerList();
     private final Location from;
     private final Plot plot;
     private boolean cancelled;
-    private final Plot plot;
+
     /**
      * PlayerTeleportToPlotEvent: Called when a player teleports to a plot
      *
@@ -45,46 +27,46 @@ public class PlayerTeleportToPlotEvent extends PlayerEvent implements Cancellabl
      * @param from   Start location
      * @param plot   Plot to which the player was teleported
      */
-     * @param plot   Plot to which the player was teleported
+    public PlayerTeleportToPlotEvent(Player player, Location from, Plot plot) {
         super(player);
         this.from = from;
         this.plot = plot;
     }
-        this.plot = plot;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-        return handlers;
+
     /**
      * Get the from location
      *
      * @return Location
      */
     public Location getFrom() {
-     */
+        return this.from;
     }
-        return from;
+
     /**
      * Get the plot involved
      *
      * @return Plot
      */
     public Plot getPlot() {
-     */
+        return this.plot;
     }
-        return plot;
+
     @Override
     public boolean isCancelled() {
-    @Override
+        return this.cancelled;
     }
-        return cancelled;
+
     @Override
-    
+    public void setCancelled(boolean cancelled) {
         this.cancelled = cancelled;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotClearEvent.java

@@ -1,77 +1,56 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import org.bukkit.event.Cancellable;
-import org.bukkit.event.HandlerList;
-
 import com.intellectualcrafters.plot.object.Plot;
 import com.intellectualcrafters.plot.object.PlotId;
+import org.bukkit.event.Cancellable;
+import org.bukkit.event.HandlerList;
 
 /**
  * Called when a plot is cleared
- *
+ *
  */
 public class PlotClearEvent extends PlotEvent implements Cancellable {
+
+    private static final HandlerList handlers = new HandlerList();
+    private boolean cancelled;
     public PlotClearEvent(Plot plot) {
         super(plot);
     }
 
-    }
-
-    private static HandlerList handlers = new HandlerList();
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
-    
+     * Get the PlotId.
      *
      * @return PlotId
      */
     public PlotId getPlotId() {
         return getPlot().getId();
     }
-        return getPlot().getId();
+
     /**
-    
+     * Get the world name.
      *
      * @return String
      */
     public String getWorld() {
         return getPlot().getArea().worldname;
     }
-        return getPlot().getArea().worldname;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-        return handlers;
+
     @Override
     public boolean isCancelled() {
-    @Override
+        return this.cancelled;
     }
-        return cancelled;
+
     @Override
-    
+    public void setCancelled(boolean b) {
-    @Override
+        this.cancelled = b;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotDeleteEvent.java

@@ -1,45 +1,25 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import org.bukkit.event.HandlerList;
-
 import com.intellectualcrafters.plot.object.Plot;
 import com.intellectualcrafters.plot.object.PlotId;
+import org.bukkit.event.HandlerList;
 
 /**
  * Called when a plot is deleted
- *
+ *
  */
 public class PlotDeleteEvent extends PlotEvent {
+
+    private static final HandlerList handlers = new HandlerList();
+
     public PlotDeleteEvent(Plot plot) {
         super(plot);
     }
 
-    }
-
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
      * Get the PlotId
      *
@@ -48,7 +28,7 @@ public class PlotDeleteEvent extends PlotEvent {
     public PlotId getPlotId() {
         return getPlot().getId();
     }
-        return getPlot().getId();
+
     /**
      * Get the world name
      *
@@ -57,7 +37,7 @@ public class PlotDeleteEvent extends PlotEvent {
     public String getWorld() {
         return getPlot().getArea().worldname;
     }
-        return getPlot().getArea().worldname;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotEvent.java

@@ -1,19 +1,18 @@
 package com.plotsquared.bukkit.events;
 
+import com.intellectualcrafters.plot.object.Plot;
 import org.bukkit.event.Event;
 
-import com.intellectualcrafters.plot.object.Plot;
-
 public abstract class PlotEvent extends Event {
-    
+
     private final Plot plot;
-    
+
-    public PlotEvent(final Plot plot) {
+    public PlotEvent(Plot plot) {
         this.plot = plot;
     }
-    
+
     public final Plot getPlot() {
-        return plot;
+        return this.plot;
     }
-    
+
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotFlagAddEvent.java

@@ -1,77 +1,56 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import org.bukkit.event.Cancellable;
-import org.bukkit.event.HandlerList;
-
 import com.intellectualcrafters.plot.flag.Flag;
 import com.intellectualcrafters.plot.object.Plot;
+import org.bukkit.event.Cancellable;
+import org.bukkit.event.HandlerList;
 
 /**
- * Called when a Flag is added to a plot
+ * Called when a Flag is added to a plot.
- *
+ *
  */
 public class PlotFlagAddEvent extends PlotEvent implements Cancellable {
- */
+
-public class PlotFlagAddEvent extends PlotEvent implements Cancellable {
+    private static final HandlerList handlers = new HandlerList();
     private final Flag flag;
     private boolean cancelled;
-    private final Flag flag;
+
     /**
-    
+     * PlotFlagAddEvent: Called when a Flag is added to a plot.
      *
      * @param flag Flag that was added
      * @param plot Plot to which the flag was added
      */
-     * @param plot Plot to which the flag was added
+    public PlotFlagAddEvent(Flag flag, Plot plot) {
         super(plot);
         this.flag = flag;
     }
-        this.flag = flag;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
-    
+     * Get the flag involved.
      *
      * @return Flag
      */
     public Flag getFlag() {
-     */
+        return this.flag;
     }
-        return flag;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-        return handlers;
+
     @Override
     public final boolean isCancelled() {
-    @Override
+        return this.cancelled;
     }
-        return cancelled;
+
     @Override
-    
+    public final void setCancelled(boolean cancelled) {
         this.cancelled = cancelled;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotFlagRemoveEvent.java

@@ -1,77 +1,56 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import org.bukkit.event.Cancellable;
-import org.bukkit.event.HandlerList;
-
 import com.intellectualcrafters.plot.flag.Flag;
 import com.intellectualcrafters.plot.object.Plot;
+import org.bukkit.event.Cancellable;
+import org.bukkit.event.HandlerList;
 
 /**
  * Called when a flag is removed from a plot
- *
+ *
  */
 public class PlotFlagRemoveEvent extends PlotEvent implements Cancellable {
- */
+
-public class PlotFlagRemoveEvent extends PlotEvent implements Cancellable {
+    private static final HandlerList handlers = new HandlerList();
     private final Flag flag;
     private boolean cancelled;
-    private final Flag flag;
+
     /**
      * PlotFlagRemoveEvent: Called when a flag is removed from a plot
      *
      * @param flag Flag that was removed
      * @param plot Plot from which the flag was removed
      */
-     * @param plot Plot from which the flag was removed
+    public PlotFlagRemoveEvent(Flag flag, Plot plot) {
         super(plot);
         this.flag = flag;
     }
-        this.flag = flag;
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-        return handlers;
+
     /**
      * Get the flag involved
      *
      * @return Flag
      */
     public Flag getFlag() {
-     */
+        return this.flag;
     }
-        return flag;
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-        return handlers;
+
     @Override
     public final boolean isCancelled() {
-    @Override
+        return this.cancelled;
     }
-        return cancelled;
+
     @Override
-    
+    public final void setCancelled(boolean cancelled) {
         this.cancelled = cancelled;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotMergeEvent.java

@@ -1,44 +1,20 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import java.util.ArrayList;
-
-import org.bukkit.World;
-import org.bukkit.event.Cancellable;
-import org.bukkit.event.Event;
-import org.bukkit.event.HandlerList;
-
 import com.intellectualcrafters.plot.object.Plot;
 import com.intellectualcrafters.plot.object.PlotId;
+import org.bukkit.World;
+import org.bukkit.event.Cancellable;
+import org.bukkit.event.HandlerList;
 
-/**
+import java.util.ArrayList;
-
+
- */
+public class PlotMergeEvent extends PlotEvent implements Cancellable {
-public class PlotMergeEvent extends Event implements Cancellable {
+
+    private static final HandlerList handlers = new HandlerList();
     private final ArrayList<PlotId> plots;
+    private final World world;
     private boolean cancelled;
-    private boolean cancelled;
+
-    private Plot plot;
-    private World world;
     /**
      * PlotMergeEvent: Called when plots are merged
      *
@@ -46,48 +22,41 @@ public class PlotMergeEvent extends Event implements Cancellable {
      * @param plot  Plot that was merged
      * @param plots A list of plots involved in the event
      */
-     */
+    public PlotMergeEvent(World world, Plot plot, ArrayList<PlotId> plots) {
+        super(plot);
+        this.world = world;
         this.plots = plots;
     }
-    }
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-    }
+
     /**
-    /**
+     * Get the plots being added.
      *
      * @return Plot
      */
     public ArrayList<PlotId> getPlots() {
-    public ArrayList<PlotId> getPlots() {
+        return this.plots;
     }
-    }
+
-    
-    /**
-     * Get the main plot
-     *
-     * @return Plot
-     */
-    public Plot getPlot() {
-        return plot;
-    }
     public World getWorld() {
-    public World getWorld() {
+        return this.world;
     }
-    }
+
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-    }
+
     @Override
     public boolean isCancelled() {
-    public boolean isCancelled() {
+        return this.cancelled;
     }
-    }
+
     @Override
-    @Override
+    public void setCancelled(boolean b) {
-    public void setCancelled(final boolean b) {
+        this.cancelled = b;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotRateEvent.java

@@ -1,46 +1,41 @@
 package com.plotsquared.bukkit.events;
 
-import org.bukkit.event.HandlerList;
-
 import com.intellectualcrafters.plot.object.Plot;
 import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.intellectualcrafters.plot.object.Rating;
+import org.bukkit.event.HandlerList;
 
-/**
- * Created 2015-07-13 for PlotSquaredGit
- *
-
 public class PlotRateEvent extends PlotEvent {
-public class PlotRateEvent extends PlotEvent {
+
-    
+    private static final HandlerList handlers = new HandlerList();
     private final PlotPlayer rater;
     private Rating rating;
-    private Rating rating;
+
-    
+    public PlotRateEvent(PlotPlayer rater, Rating rating, Plot plot) {
         super(plot);
         this.rater = rater;
         this.rating = rating;
     }
-    }
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-    }
+
     public PlotPlayer getRater() {
-    public PlotPlayer getRater() {
+        return this.rater;
     }
-    }
+
-    
+    public Rating getRating() {
+        return this.rating;
+    }
+
+    public void setRating(Rating rating) {
         this.rating = rating;
     }
-    }
+
-    
-    public Rating getRating() {
-        return rating;
-    }
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-    }
+
 }

Bukkit/src/main/java/com/plotsquared/bukkit/events/PlotUnlinkEvent.java

@@ -1,89 +1,67 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.events;
 
-import java.util.ArrayList;
+import com.intellectualcrafters.plot.object.PlotArea;
-
+import com.intellectualcrafters.plot.object.PlotId;
 import org.bukkit.World;
 import org.bukkit.event.Cancellable;
 import org.bukkit.event.Event;
 import org.bukkit.event.HandlerList;
 
-import com.intellectualcrafters.plot.object.PlotArea;
+import java.util.ArrayList;
-import com.intellectualcrafters.plot.object.PlotId;
 
-/**
-
 public class PlotUnlinkEvent extends Event implements Cancellable {
-public class PlotUnlinkEvent extends Event implements Cancellable {
+
+    private static final HandlerList handlers = new HandlerList();
     private final ArrayList<PlotId> plots;
     private final World world;
-    private final World world;
     private final PlotArea area;
-    private final PlotArea area;
+    private boolean cancelled;
+
     /**
      * Called when a mega-plot is unlinked.
      *
      * @param world World in which the event occurred
      * @param plots Plots that are involved in the event
      */
-     */
+    public PlotUnlinkEvent(World world, PlotArea area, ArrayList<PlotId> plots) {
         this.plots = plots;
         this.world = world;
         this.area = area;
     }
-    }
+
     public static HandlerList getHandlerList() {
         return handlers;
     }
-    }
+
     /**
-    /**
+     * Get the plots involved.
      *
-     *
+     * @return The {@link PlotId}'s of the plots involved
      */
     public ArrayList<PlotId> getPlots() {
-    public ArrayList<PlotId> getPlots() {
+        return this.plots;
     }
-    }
+
     public World getWorld() {
-    public World getWorld() {
+        return this.world;
     }
-    }
+
     public PlotArea getArea() {
-    public PlotArea getArea() {
+        return this.area;
     }
 
     @Override
     public HandlerList getHandlers() {
         return handlers;
     }
-    }
+
     @Override
     public boolean isCancelled() {
-    public boolean isCancelled() {
+        return this.cancelled;
     }
-    }
+
     @Override
-    @Override
+    public void setCancelled(boolean b) {
-    public void setCancelled(final boolean b) {
+        this.cancelled = b;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/generator/BukkitAugmentedGenerator.java

@@ -10,8 +10,6 @@ import java.util.Random;
 public class BukkitAugmentedGenerator extends BlockPopulator {
     
     private static BukkitAugmentedGenerator generator;
-    
-    private BukkitAugmentedGenerator() {}
 
     public static BukkitAugmentedGenerator get(World world) {
         for (BlockPopulator populator : world.getPopulators()) {
@@ -27,7 +25,7 @@ public class BukkitAugmentedGenerator extends BlockPopulator {
     }
 
     @Override
-    public void populate(final World world, Random r, final Chunk chunk) {
+    public void populate(World world, Random r, Chunk chunk) {
         AugmentedUtils.generate(world.getName(), chunk.getX(), chunk.getZ(), null);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/generator/BukkitPlotGenerator.java

@@ -1,69 +1,47 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.generator;
 
 import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.generator.GeneratorWrapper;
 import com.intellectualcrafters.plot.generator.HybridGen;
 import com.intellectualcrafters.plot.generator.IndependentPlotGenerator;
-import com.intellectualcrafters.plot.object.*;
+import com.intellectualcrafters.plot.object.PlotArea;
+import com.intellectualcrafters.plot.object.PlotId;
+import com.intellectualcrafters.plot.object.PlotManager;
+import com.intellectualcrafters.plot.object.PseudoRandom;
+import com.intellectualcrafters.plot.object.SetupObject;
 import com.intellectualcrafters.plot.util.ChunkManager;
 import com.intellectualcrafters.plot.util.MainUtil;
 import com.intellectualcrafters.plot.util.PlotChunk;
 import com.intellectualcrafters.plot.util.SetQueue;
 import com.plotsquared.bukkit.util.BukkitUtil;
 import com.plotsquared.bukkit.util.block.GenChunk;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Set;
 import org.bukkit.Chunk;
 import org.bukkit.World;
 import org.bukkit.block.Biome;
 import org.bukkit.generator.BlockPopulator;
 import org.bukkit.generator.ChunkGenerator;
 
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Random;
-import java.util.Set;
-
 public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrapper<ChunkGenerator> {
     
     private final PlotChunk<Chunk> chunkSetter;
     private final PseudoRandom random = new PseudoRandom();
     private final IndependentPlotGenerator plotGenerator;
     private final List<BlockPopulator> populators = new ArrayList<>();
+    private final ChunkGenerator platformGenerator;
+    private final boolean full;
     private boolean loaded = false;
-    private ChunkGenerator platformGenerator;
-    private boolean full;
 
     public BukkitPlotGenerator(IndependentPlotGenerator generator) {
         this.plotGenerator = generator;
         this.platformGenerator = this;
-        populators.add(new BlockPopulator() {
+        this.populators.add(new BlockPopulator() {
             @Override
             public void populate(World world, Random r, Chunk c) {
-                if (!(chunkSetter instanceof GenChunk)) {
+                GenChunk result = (GenChunk) BukkitPlotGenerator.this.chunkSetter;
-                    PS.debug("Current PlotChunk is not relevant to population?");
-                    PS.stacktrace();
-                    return;
-                }
-                GenChunk result = (GenChunk) chunkSetter;
                 if (result.result_data != null) {
                     for (int i = 0; i < result.result_data.length; i++) {
                         byte[] section = result.result_data[i];
@@ -78,9 +56,16 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
                         }
                     }
                 }
+                random.state = c.getX() << 16 | c.getZ() & 0xFFFF;
+                PlotArea area = PS.get().getPlotArea(world.getName(), null);
+                SetQueue.ChunkWrapper wrap = SetQueue.IMP.new ChunkWrapper(area.worldname, c.getX(), c.getZ());
+                PlotChunk<?> chunk = SetQueue.IMP.queue.getChunk(wrap);
+                if (plotGenerator.populateChunk(chunk, area, random)) {
+                    chunk.addToQueue();
+                }
             }
         });
-        chunkSetter = new GenChunk(null, null);
+        this.chunkSetter = new GenChunk(null, null);
         this.full = true;
         MainUtil.initCache();
     }
@@ -90,9 +75,9 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
             throw new IllegalArgumentException("ChunkGenerator: " + cg.getClass().getName() + " is already a BukkitPlotGenerator!");
         }
         this.full = false;
-        PS.get().debug("BukkitPlotGenerator does not fully support: " + cg);
+        PS.debug("BukkitPlotGenerator does not fully support: " + cg);
-        platformGenerator = cg;
+        this.platformGenerator = cg;
-        plotGenerator = new IndependentPlotGenerator() {
+        this.plotGenerator = new IndependentPlotGenerator() {
             @Override
             public void processSetup(SetupObject setup) {}
             
@@ -115,7 +100,7 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
             }
             
             @Override
-            public void generateChunk(final PlotChunk<?> result, final PlotArea settings, final PseudoRandom random) {
+            public void generateChunk(final PlotChunk<?> result, PlotArea settings, PseudoRandom random) {
                 World w = BukkitUtil.getWorld(world);
                 Random r = new Random(result.getChunkWrapper().hashCode());
                 BiomeGrid grid = new BiomeGrid() {
@@ -135,8 +120,9 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
                     if (data != null) {
                         return;
                     }
+                } catch (Throwable e) {
+                    //ignored
                 }
-                catch (Throwable e) {}
                 // Populator spillage
                 short[][] tmp = cg.generateExtBlockSections(w, r, result.getX(), result.getZ(), grid);
                 if (tmp != null) {
@@ -167,9 +153,9 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
                 }
             }
         };
-        chunkSetter = new GenChunk(null, SetQueue.IMP.new ChunkWrapper(world, 0, 0));
+        this.chunkSetter = new GenChunk(null, SetQueue.IMP.new ChunkWrapper(world, 0, 0));
         if (cg != null) {
-            populators.addAll(cg.getDefaultPopulators(BukkitUtil.getWorld(world)));
+            this.populators.addAll(cg.getDefaultPopulators(BukkitUtil.getWorld(world)));
         }
         MainUtil.initCache();
     }
@@ -181,24 +167,26 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
     
     @Override
     public boolean isFull() {
-        return full;
+        return this.full;
     }
     
     @Override
     public IndependentPlotGenerator getPlotGenerator() {
-        return plotGenerator;
+        return this.plotGenerator;
     }
     
     @Override
     public ChunkGenerator getPlatformGenerator() {
-        return platformGenerator;
+        return this.platformGenerator;
     }
 
+
+
     @Override
-    public List<BlockPopulator> getDefaultPopulators(final World world) {
+    public List<BlockPopulator> getDefaultPopulators(World world) {
         try {
-            if (!loaded) {
+            if (!this.loaded) {
-                final String name = world.getName();
+                String name = world.getName();
                 PS.get().loadWorld(name, this);
                 Set<PlotArea> areas = PS.get().getPlotAreas(name);
                 if (!areas.isEmpty()) {
@@ -219,32 +207,39 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
                         world.setWaterAnimalSpawnLimit(-1);
                     }
                 }
-                loaded = true;
+                this.loaded = true;
             }
-        } catch (final Exception e) {
+        } catch (Exception e) {
             e.printStackTrace();
         }
-        return populators;
+        if (world == null) {
+            return populators;
+        }
+        ArrayList<BlockPopulator> toAdd = new ArrayList<BlockPopulator>();
+        List<BlockPopulator> existing = world.getPopulators();
+        for (BlockPopulator populator : populators) {
+            if (!existing.contains(populator)) {
+                toAdd.add(populator);
+            }
+        }
+        return toAdd;
     }
-    
+
     @Override
     public ChunkData generateChunkData(World world, Random random, int cx, int cz, BiomeGrid grid) {
-        if (!(chunkSetter instanceof GenChunk)) {
+        GenChunk result = (GenChunk) this.chunkSetter;
-            PS.debug("Current PlotChunk is not relevant to generation?");
-            PS.stacktrace();
-            return null;
-        }
-        GenChunk result = (GenChunk) chunkSetter;
         // Set the chunk location
         result.setChunkWrapper(SetQueue.IMP.new ChunkWrapper(world.getName(), cx, cz));
         // Set the result data
         result.cd = createChunkData(world);
         result.grid = grid;
-        // Catch any exceptions (as exceptions usually thrown 
+        result.result = null;
+        result.result_data = null;
+        // Catch any exceptions (as exceptions usually thrown)
         try {
             // Fill the result data if necessary
-            if (platformGenerator != this) {
+            if (this.platformGenerator != this) {
-                return platformGenerator.generateChunkData(world, random, cx, cz, grid);
+                return this.platformGenerator.generateChunkData(world, random, cx, cz, grid);
             } else {
                 generate(world, cx, cz, result);
             }
@@ -257,43 +252,37 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
     
     public void generate(World world, int cx, int cz, GenChunk result) {
         // Load if improperly loaded
-        if (!loaded) {
+        if (!this.loaded) {
-            final String name = world.getName();
+            String name = world.getName();
             PS.get().loadWorld(name, this);
-            loaded = true;
+            this.loaded = true;
         }
         // Set random seed
-        this.random.state = (cx << 16) | (cz & 0xFFFF);
+        this.random.state = cx << 16 | cz & 0xFFFF;
         // Process the chunk
-        result.modified = false;
+        if (ChunkManager.preProcessChunk(result)) {
-        ChunkManager.preProcessChunk(result);
-        if (result.modified) {
             return;
         }
         PlotArea area = PS.get().getPlotArea(world.getName(), null);
-        plotGenerator.generateChunk(chunkSetter, area, this.random);
+        this.plotGenerator.generateChunk(this.chunkSetter, area, this.random);
         ChunkManager.postProcessChunk(result);
-        return;
     }
     
     @Override
-    public short[][] generateExtBlockSections(final World world, final Random r, final int cx, final int cz, final BiomeGrid grid) {
+    public short[][] generateExtBlockSections(World world, Random r, int cx, int cz, BiomeGrid grid) {
-        if (!(chunkSetter instanceof GenChunk)) {
+        GenChunk result = (GenChunk) this.chunkSetter;
-            PS.stacktrace();
-            return new short[16][];
-        }
-        GenChunk result = (GenChunk) chunkSetter;
         // Set the chunk location
         result.setChunkWrapper(SetQueue.IMP.new ChunkWrapper(world.getName(), cx, cz));
         // Set the result data
         result.result = new short[16][];
         result.result_data = new byte[16][];
         result.grid = grid;
-        // Catch any exceptions (as exceptions usually thrown 
+        result.cd = null;
+        // Catch any exceptions (as exceptions usually thrown)
         try {
             // Fill the result data
-            if (platformGenerator != this) {
+            if (this.platformGenerator != this) {
-                return platformGenerator.generateExtBlockSections(world, r, cx, cz, grid);
+                return this.platformGenerator.generateExtBlockSections(world, r, cx, cz, grid);
             } else {
                 generate(world, cx, cz, result);
             }
@@ -305,19 +294,27 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
     }
     
     /**
-     * Allow spawning everywhere
+     * Allow spawning everywhere.
+     * @param world Ignored
+     * @param x Ignored
+     * @param z Ignored
+     * @return always true
      */
     @Override
-    public boolean canSpawn(final World world, final int x, final int z) {
+    public boolean canSpawn(World world, int x, int z) {
         return true;
     }
     
     @Override
     public String toString() {
-        if (platformGenerator == this) {
+        if (this.platformGenerator == this) {
-            return "" + plotGenerator;
+            return "" + this.plotGenerator;
+        }
+        if (this.platformGenerator == null) {
+            return "null";
+        } else {
+            return this.platformGenerator.getClass().getName();
         }
-        return platformGenerator == null ? "null" : platformGenerator.getClass().getName();
     }
     
     @Override
@@ -325,6 +322,6 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
         if (obj == null) {
             return false;
         }
-        return (toString().equals(obj.toString()) || toString().equals(obj.getClass().getName()));
+        return toString().equals(obj.toString()) || toString().equals(obj.getClass().getName());
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/ChunkListener.java

@@ -36,36 +36,37 @@ import java.util.HashMap;
 import java.util.Map.Entry;
 
 public class ChunkListener implements Listener {
-    
+
-    private final RefClass classChunk = getRefClass("{nms}.Chunk");
-    private final RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
-    private final RefField mustSave = classChunk.getField("mustSave");
-    private Chunk lastChunk = null;
     private RefMethod methodGetHandleChunk;
-    
+    private RefField mustSave;
+    private Chunk lastChunk;
+
     
     public ChunkListener() {
-        RefMethod method;
+        if (Settings.CHUNK_PROCESSOR_GC || Settings.CHUNK_PROCESSOR_TRIM_ON_SAVE) {
-        try {
+            try {
-            method = classCraftChunk.getMethod("getHandle");
+                RefClass classChunk = getRefClass("{nms}.Chunk");
-        } catch (final Exception e) {
+                RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
-            method = null;
+                this.mustSave = classChunk.getField("mustSave");
-            e.printStackTrace();
+                this.methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
+            } catch (Throwable e) {
+                PS.debug("PlotSquared/Server not compatible for chunk processor trim/gc");
+                Settings.CHUNK_PROCESSOR_GC = false;
+                Settings.CHUNK_PROCESSOR_TRIM_ON_SAVE = false;
+            }
         }
-        methodGetHandleChunk = method;
-        
         if (!Settings.CHUNK_PROCESSOR_GC) {
             return;
         }
         TaskManager.runTask(new Runnable() {
             @Override
             public void run() {
-                final int distance = Bukkit.getViewDistance() + 2;
+                int distance = Bukkit.getViewDistance() + 2;
-                final HashMap<String, HashMap<ChunkLoc, Integer>> players = new HashMap<>();
+                HashMap<String, HashMap<ChunkLoc, Integer>> players = new HashMap<>();
-                for (final Entry<String, PlotPlayer> entry : UUIDHandler.getPlayers().entrySet()) {
+                for (Entry<String, PlotPlayer> entry : UUIDHandler.getPlayers().entrySet()) {
-                    final PlotPlayer pp = entry.getValue();
+                    PlotPlayer pp = entry.getValue();
-                    final Location loc = pp.getLocation();
+                    Location location = pp.getLocation();
-                    final String world = loc.getWorld();
+                    String world = location.getWorld();
                     if (!PS.get().hasPlotArea(world)) {
                         continue;
                     }
@@ -74,7 +75,7 @@ public class ChunkListener implements Listener {
                         map = new HashMap<>();
                         players.put(world, map);
                     }
-                    final ChunkLoc origin = new ChunkLoc(loc.getX() >> 4, loc.getZ() >> 4);
+                    ChunkLoc origin = new ChunkLoc(location.getX() >> 4, location.getZ() >> 4);
                     Integer val = map.get(origin);
                     int check;
                     if (val != null) {
@@ -94,8 +95,8 @@ public class ChunkListener implements Listener {
                             if (z >= check || -z >= check) {
                                 continue;
                             }
-                            final int weight = distance - Math.max(Math.abs(x), Math.abs(z));
+                            int weight = distance - Math.max(Math.abs(x), Math.abs(z));
-                            final ChunkLoc chunk = new ChunkLoc(x + origin.x, z + origin.z);
+                            ChunkLoc chunk = new ChunkLoc(x + origin.x, z + origin.z);
                             val = map.get(chunk);
                             if (val == null || val < weight) {
                                 map.put(chunk, weight);
@@ -105,24 +106,24 @@ public class ChunkListener implements Listener {
                     }
                 }
                 int time = 300;
-                for (final World world : Bukkit.getWorlds()) {
+                for (World world : Bukkit.getWorlds()) {
-                    final String name = world.getName();
+                    String name = world.getName();
                     if (!PS.get().hasPlotArea(name)) {
                         continue;
                     }
-                    final boolean autosave = world.isAutoSave();
+                    boolean autoSave = world.isAutoSave();
-                    if (autosave) {
+                    if (autoSave) {
                         world.setAutoSave(false);
                     }
-                    final HashMap<ChunkLoc, Integer> map = players.get(name);
+                    HashMap<ChunkLoc, Integer> map = players.get(name);
                     if (map == null || map.isEmpty()) {
                         continue;
                     }
                     Chunk[] chunks = world.getLoadedChunks();
                     ArrayDeque<Chunk> toUnload = new ArrayDeque<>();
-                    for (final Chunk chunk : chunks) {
+                    for (Chunk chunk : chunks) {
-                        final int x = chunk.getX();
+                        int x = chunk.getX();
-                        final int z = chunk.getZ();
+                        int z = chunk.getZ();
                         if (!map.containsKey(new ChunkLoc(x, z))) {
                             toUnload.add(chunk);
                         }
@@ -141,7 +142,7 @@ public class ChunkListener implements Listener {
                             time = 1;
                         }
                     }
-                    if (!Settings.CHUNK_PROCESSOR_TRIM_ON_SAVE && autosave) {
+                    if (!Settings.CHUNK_PROCESSOR_TRIM_ON_SAVE && autoSave) {
                         world.setAutoSave(true);
                     }
                 }
@@ -149,14 +150,14 @@ public class ChunkListener implements Listener {
             }
         });
     }
-    
+
-    public boolean unloadChunk(final String world, final Chunk chunk) {
+    public boolean unloadChunk(String world, Chunk chunk) {
-        final int X = chunk.getX();
+        int X = chunk.getX();
-        final int Z = chunk.getZ();
+        int Z = chunk.getZ();
-        final int x = X << 4;
+        int x = X << 4;
-        final int z = Z << 4;
+        int z = Z << 4;
-        final int x2 = x + 15;
+        int x2 = x + 15;
-        final int z2 = z + 15;
+        int z2 = z + 15;
         Plot plot = new Location(world, x, 1, z).getOwnedPlotAbs();
         if (plot != null && plot.hasOwner()) {
             return false;
@@ -177,8 +178,8 @@ public class ChunkListener implements Listener {
         if (plot != null && plot.hasOwner()) {
             return false;
         }
-        final Object c = methodGetHandleChunk.of(chunk).call();
+        Object c = this.methodGetHandleChunk.of(chunk).call();
-        mustSave.of(c).set(false);
+        this.mustSave.of(c).set(false);
         if (chunk.isLoaded()) {
             chunk.unload(false, false);
         }
@@ -186,10 +187,10 @@ public class ChunkListener implements Listener {
     }
     
     @EventHandler
-    public void onChunkUnload(final ChunkUnloadEvent event) {
+    public void onChunkUnload(ChunkUnloadEvent event) {
         if (Settings.CHUNK_PROCESSOR_TRIM_ON_SAVE) {
-            final Chunk chunk = event.getChunk();
+            Chunk chunk = event.getChunk();
-            final String world = chunk.getWorld().getName();
+            String world = chunk.getWorld().getName();
             if (PS.get().hasPlotArea(world)) {
                 if (unloadChunk(world, chunk)) {
                     return;
@@ -202,15 +203,15 @@ public class ChunkListener implements Listener {
     }
     
     @EventHandler
-    public void onChunkLoad(final ChunkLoadEvent event) {
+    public void onChunkLoad(ChunkLoadEvent event) {
         processChunk(event.getChunk(), false);
     }
     
     @EventHandler(priority = EventPriority.LOWEST)
-    public void onItemSpawn(final ItemSpawnEvent event) {
+    public void onItemSpawn(ItemSpawnEvent event) {
-        final Item entity = event.getEntity();
+        Item entity = event.getEntity();
-        final Chunk chunk = entity.getLocation().getChunk();
+        Chunk chunk = entity.getLocation().getChunk();
-        if (chunk == lastChunk) {
+        if (chunk == this.lastChunk) {
             event.getEntity().remove();
             event.setCancelled(true);
             return;
@@ -218,28 +219,28 @@ public class ChunkListener implements Listener {
         if (!PS.get().hasPlotArea(chunk.getWorld().getName())) {
             return;
         }
-        final Entity[] entities = chunk.getEntities();
+        Entity[] entities = chunk.getEntities();
         if (entities.length > Settings.CHUNK_PROCESSOR_MAX_ENTITIES) {
             event.getEntity().remove();
             event.setCancelled(true);
-            lastChunk = chunk;
+            this.lastChunk = chunk;
         } else {
-            lastChunk = null;
+            this.lastChunk = null;
         }
     }
     
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onBlockPhysics(final BlockPhysicsEvent event) {
+    public void onBlockPhysics(BlockPhysicsEvent event) {
         if (Settings.CHUNK_PROCESSOR_DISABLE_PHYSICS) {
             event.setCancelled(true);
         }
     }
     
     @EventHandler(priority = EventPriority.LOWEST)
-    public void onEntitySpawn(final CreatureSpawnEvent event) {
+    public void onEntitySpawn(CreatureSpawnEvent event) {
-        final LivingEntity entity = event.getEntity();
+        LivingEntity entity = event.getEntity();
-        final Chunk chunk = entity.getLocation().getChunk();
+        Chunk chunk = entity.getLocation().getChunk();
-        if (chunk == lastChunk) {
+        if (chunk == this.lastChunk) {
             event.getEntity().remove();
             event.setCancelled(true);
             return;
@@ -247,20 +248,20 @@ public class ChunkListener implements Listener {
         if (!PS.get().hasPlotArea(chunk.getWorld().getName())) {
             return;
         }
-        final Entity[] entities = chunk.getEntities();
+        Entity[] entities = chunk.getEntities();
         if (entities.length > Settings.CHUNK_PROCESSOR_MAX_ENTITIES) {
             event.getEntity().remove();
             event.setCancelled(true);
-            lastChunk = chunk;
+            this.lastChunk = chunk;
         } else {
-            lastChunk = null;
+            this.lastChunk = null;
         }
     }
-    
+
-    public void cleanChunk(final Chunk chunk) {
+    private void cleanChunk(final Chunk chunk) {
         TaskManager.index.incrementAndGet();
         final Integer currentIndex = TaskManager.index.get();
-        final Integer task = TaskManager.runTaskRepeat(new Runnable() {
+        Integer task = TaskManager.runTaskRepeat(new Runnable() {
             @Override
             public void run() {
                 if (!chunk.isLoaded()) {
@@ -270,7 +271,7 @@ public class ChunkListener implements Listener {
                     chunk.unload(true, true);
                     return;
                 }
-                final BlockState[] tiles = chunk.getTileEntities();
+                BlockState[] tiles = chunk.getTileEntities();
                 if (tiles.length == 0) {
                     Bukkit.getScheduler().cancelTask(TaskManager.tasks.get(currentIndex));
                     TaskManager.tasks.remove(currentIndex);
@@ -278,7 +279,7 @@ public class ChunkListener implements Listener {
                     chunk.unload(true, true);
                     return;
                 }
-                final long start = System.currentTimeMillis();
+                long start = System.currentTimeMillis();
                 int i = 0;
                 while (System.currentTimeMillis() - start < 250) {
                     if (i >= tiles.length) {
@@ -295,15 +296,15 @@ public class ChunkListener implements Listener {
         }, 5);
         TaskManager.tasks.put(currentIndex, task);
     }
-    
+
-    public boolean processChunk(final Chunk chunk, final boolean unload) {
+    public boolean processChunk(Chunk chunk, boolean unload) {
         if (!PS.get().hasPlotArea(chunk.getWorld().getName())) {
             return false;
         }
-        final Entity[] entities = chunk.getEntities();
+        Entity[] entities = chunk.getEntities();
-        final BlockState[] tiles = chunk.getTileEntities();
+        BlockState[] tiles = chunk.getTileEntities();
         if (entities.length > Settings.CHUNK_PROCESSOR_MAX_ENTITIES) {
-            for (final Entity ent : entities) {
+            for (Entity ent : entities) {
                 if (!(ent instanceof Player)) {
                     ent.remove();
                 }
@@ -316,7 +317,7 @@ public class ChunkListener implements Listener {
                 cleanChunk(chunk);
                 return true;
             }
-            for (final BlockState tile : tiles) {
+            for (BlockState tile : tiles) {
                 tile.getBlock().setType(Material.AIR, false);
             }
         }

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/ForceFieldListener.java

@@ -1,35 +1,5 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.listeners;
 
-import java.util.HashSet;
-import java.util.Set;
-import java.util.UUID;
-
-import org.bukkit.entity.Entity;
-import org.bukkit.entity.Player;
-import org.bukkit.event.EventHandler;
-import org.bukkit.event.Listener;
-import org.bukkit.util.Vector;
-
 import com.intellectualcrafters.plot.flag.FlagManager;
 import com.intellectualcrafters.plot.object.Location;
 import com.intellectualcrafters.plot.object.Plot;
@@ -37,14 +7,22 @@ import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.plotsquared.bukkit.events.PlayerEnterPlotEvent;
 import com.plotsquared.bukkit.object.BukkitPlayer;
 import com.plotsquared.bukkit.util.BukkitUtil;
+import org.bukkit.entity.Entity;
+import org.bukkit.entity.Player;
+import org.bukkit.event.EventHandler;
+import org.bukkit.event.Listener;
+import org.bukkit.util.Vector;
+
+import java.util.HashSet;
+import java.util.Set;
+import java.util.UUID;
 
-/**
-
 public class ForceFieldListener implements Listener {
-public class ForceFieldListener implements Listener {
+
-    private Set<PlotPlayer> getNearbyPlayers(final Player player, final Plot plot) {
+    private Set<PlotPlayer> getNearbyPlayers(Player player, Plot plot) {
-        final Set<PlotPlayer> players = new HashSet<>();
+        Set<PlotPlayer> players = new HashSet<>();
-        PlotPlayer pp;
+        for (Entity entity : player.getNearbyEntities(5d, 5d, 5d)) {
+            PlotPlayer pp;
             if (!(entity instanceof Player) || ((pp = BukkitUtil.getPlayer((Player) entity)) == null) || !plot.equals(pp.getCurrentPlot())) {
                 continue;
             }
@@ -54,10 +32,10 @@ public class ForceFieldListener implements Listener {
         }
         return players;
     }
-    }
+
-    
+    private PlotPlayer hasNearbyPermitted(Player player, Plot plot) {
-    private PlotPlayer hasNearbyPermitted(final Player player, final Plot plot) {
+        for (Entity entity : player.getNearbyEntities(5d, 5d, 5d)) {
-        PlotPlayer pp;
+            PlotPlayer pp;
             if (!(entity instanceof Player) || ((pp = BukkitUtil.getPlayer((Player) entity)) == null) || !plot.equals(pp.getCurrentPlot())) {
                 continue;
             }
@@ -67,23 +45,29 @@ public class ForceFieldListener implements Listener {
         }
         return null;
     }
-    }
+
-    
+    public Vector calculateVelocity(PlotPlayer pp, PlotPlayer e) {
         Location playerLocation = pp.getLocationFull();
         Location oPlayerLocation = e.getLocation();
-        Location oPlayerLocation = e.getLocation();
+        double playerX = playerLocation.getX();
-        final double playerX = playerLocation.getX(), playerY = playerLocation.getY(), playerZ = playerLocation.getZ(), oPlayerX = oPlayerLocation.getX(), oPlayerY = oPlayerLocation.getY(), oPlayerZ = oPlayerLocation
+        double playerY = playerLocation.getY();
-        .getZ();
+        double playerZ = playerLocation.getZ();
+        double oPlayerX = oPlayerLocation.getX();
+        double oPlayerY = oPlayerLocation.getY();
+        double oPlayerZ = oPlayerLocation.getZ();
+        double x = 0d;
         if (playerX < oPlayerX) {
             x = 1.0d;
         } else if (playerX > oPlayerX) {
             x = -1.0d;
         }
+        double y = 0d;
         if (playerY < oPlayerY) {
             y = 0.5d;
         } else if (playerY > oPlayerY) {
             y = -0.5d;
         }
+        double z = 0d;
         if (playerZ < oPlayerZ) {
             z = 1.0d;
         } else if (playerZ > oPlayerZ) {
@@ -91,25 +75,25 @@ public class ForceFieldListener implements Listener {
         }
         return new Vector(x, y, z);
     }
-    }
+
     @EventHandler
-    @EventHandler
+    public void onPlotEntry(PlayerEnterPlotEvent event) {
-    public void onPlotEntry(final PlayerEnterPlotEvent event) {
+        Player player = event.getPlayer();
-        final Player player = event.getPlayer();
+        PlotPlayer pp = BukkitUtil.getPlayer(player);
-        final PlotPlayer pp = BukkitUtil.getPlayer(player);
+        Plot plot = event.getPlot();
         if (plot == null) {
             return;
         }
         if ((FlagManager.getPlotFlagRaw(plot, "forcefield") != null) && FlagManager.getPlotFlagRaw(plot, "forcefield").getValue().equals("true")) {
             if (!FlagManager.isBooleanFlag(plot, "forcefield", false)) {
-            if (!FlagManager.isBooleanFlag(plot, "forcefield", false)) {
+                UUID uuid = pp.getUUID();
                 if (plot.isAdded(uuid)) {
-                if (plot.isAdded(uuid)) {
+                    Set<PlotPlayer> players = getNearbyPlayers(player, plot);
-                    final Set<PlotPlayer> players = getNearbyPlayers(player, plot);
+                    for (PlotPlayer oPlayer : players) {
                         ((BukkitPlayer) oPlayer).player.setVelocity(calculateVelocity(pp, oPlayer));
                     }
                 } else {
-                } else {
+                    PlotPlayer oPlayer = hasNearbyPermitted(player, plot);
                     if (oPlayer == null) {
                         return;
                     }

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlayerEvents183.java

@@ -14,22 +14,22 @@ import org.bukkit.event.block.BlockExplodeEvent;
 
 import java.util.Iterator;
 
-public class PlayerEvents_1_8_3 implements Listener {
+public class PlayerEvents183 implements Listener {
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onBigBoom(final BlockExplodeEvent event) {
+    public void onBigBoom(BlockExplodeEvent event) {
-        final Block block = event.getBlock();
+        Block block = event.getBlock();
         Location loc = BukkitUtil.getLocation(block.getLocation());
-        final String world = loc.getWorld();
+        String world = loc.getWorld();
         if (!PS.get().hasPlotArea(world)) {
             return;
         }
         PlotArea area = loc.getPlotArea();
         if (area == null) {
-            final Iterator<Block> iter = event.blockList().iterator();
+            Iterator<Block> iterator = event.blockList().iterator();
-            while (iter.hasNext()) {
+            while (iterator.hasNext()) {
-                loc = BukkitUtil.getLocation(iter.next().getLocation());
+                loc = BukkitUtil.getLocation(iterator.next().getLocation());
                 if (loc.getPlotArea() != null) {
-                    iter.remove();
+                    iterator.remove();
                 }
             }
             return;
@@ -38,13 +38,12 @@ public class PlayerEvents_1_8_3 implements Listener {
         if (plot == null || !FlagManager.isPlotFlagTrue(plot, "explosion")) {
             event.setCancelled(true);
         }
-        final Iterator<Block> iter = event.blockList().iterator();
+        Iterator<Block> iterator = event.blockList().iterator();
-        while (iter.hasNext()) {
+        while (iterator.hasNext()) {
-            final Block b = iter.next();
+            Block b = iterator.next();
             if (!plot.equals(area.getOwnedPlot(BukkitUtil.getLocation(b.getLocation())))) {
-                iter.remove();
+                iterator.remove();
             }
         }
-        return;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlayerEvents_1_8.java

@@ -1,9 +1,15 @@
 package com.plotsquared.bukkit.listeners;
 
-import java.util.HashSet;
+import com.intellectualcrafters.plot.PS;
-import java.util.List;
+import com.intellectualcrafters.plot.config.C;
-import java.util.UUID;
+import com.intellectualcrafters.plot.object.Location;
-
+import com.intellectualcrafters.plot.object.Plot;
+import com.intellectualcrafters.plot.object.PlotArea;
+import com.intellectualcrafters.plot.object.PlotPlayer;
+import com.intellectualcrafters.plot.util.MainUtil;
+import com.intellectualcrafters.plot.util.Permissions;
+import com.plotsquared.bukkit.util.BukkitUtil;
+import com.plotsquared.listener.PlotListener;
 import org.bukkit.block.Block;
 import org.bukkit.block.BlockState;
 import org.bukkit.entity.ArmorStand;
@@ -20,48 +26,41 @@ import org.bukkit.inventory.ItemStack;
 import org.bukkit.inventory.PlayerInventory;
 import org.bukkit.inventory.meta.ItemMeta;
 
-import com.intellectualcrafters.plot.PS;
+import java.util.HashSet;
-import com.intellectualcrafters.plot.config.C;
+import java.util.List;
-import com.intellectualcrafters.plot.object.Location;
+import java.util.UUID;
-import com.intellectualcrafters.plot.object.Plot;
-import com.intellectualcrafters.plot.object.PlotArea;
-import com.intellectualcrafters.plot.object.PlotPlayer;
-import com.intellectualcrafters.plot.util.MainUtil;
-import com.intellectualcrafters.plot.util.Permissions;
-import com.plotsquared.bukkit.util.BukkitUtil;
-import com.plotsquared.listener.PlotListener;
 
 public class PlayerEvents_1_8 extends PlotListener implements Listener {
     
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onInventoryClick(final InventoryClickEvent event) {
+    public void onInventoryClick(InventoryClickEvent event) {
         if (!event.isLeftClick() || (event.getAction() != InventoryAction.PLACE_ALL) || event.isShiftClick()) {
             return;
         }
-        final HumanEntity entity = event.getWhoClicked();
+        HumanEntity entity = event.getWhoClicked();
         if (!(entity instanceof Player) || !PS.get().hasPlotArea(entity.getWorld().getName())) {
             return;
         }
-        final Player player = (Player) entity;
+        Player player = (Player) entity;
-        final PlayerInventory inv = player.getInventory();
+        PlayerInventory inv = player.getInventory();
-        final int slot = inv.getHeldItemSlot();
+        int slot = inv.getHeldItemSlot();
         if ((slot != event.getSlot()) || (slot > 8) || !event.getEventName().equals("InventoryCreativeEvent")) {
             return;
         }
-        final ItemStack current = inv.getItemInHand();
+        ItemStack current = inv.getItemInHand();
-        final ItemStack newItem = event.getCursor();
+        ItemStack newItem = event.getCursor();
-        final ItemMeta newMeta = newItem.getItemMeta();
+        ItemMeta newMeta = newItem.getItemMeta();
-        final ItemMeta oldMeta = newItem.getItemMeta();
+        ItemMeta oldMeta = newItem.getItemMeta();
         String newLore = "";
         if (newMeta != null) {
-            final List<String> lore = newMeta.getLore();
+            List<String> lore = newMeta.getLore();
             if (lore != null) {
                 newLore = lore.toString();
             }
         }
         String oldLore = "";
         if (oldMeta != null) {
-            final List<String> lore = oldMeta.getLore();
+            List<String> lore = oldMeta.getLore();
             if (lore != null) {
                 oldLore = lore.toString();
             }
@@ -69,86 +68,82 @@ public class PlayerEvents_1_8 extends PlotListener implements Listener {
         if (!newLore.equals("[(+NBT)]") || (current.equals(newItem) && newLore.equals(oldLore))) {
             return;
         }
-        final HashSet<Byte> blocks = null;
+        HashSet<Byte> blocks = null;
-        final Block block = player.getTargetBlock(blocks, 7);
+        Block block = player.getTargetBlock(blocks, 7);
-        final BlockState state = block.getState();
+        BlockState state = block.getState();
         if (state == null) {
             return;
         }
         if (state.getType() != newItem.getType()) {
             return;
         }
-        final Location l = BukkitUtil.getLocation(state.getLocation());
+        Location l = BukkitUtil.getLocation(state.getLocation());
         PlotArea area = l.getPlotArea();
         if (area == null) {
             return;
         }
-        final Plot plot = area.getPlotAbs(l);
+        Plot plot = area.getPlotAbs(l);
-        final PlotPlayer pp = BukkitUtil.getPlayer(player);
+        PlotPlayer pp = BukkitUtil.getPlayer(player);
         boolean cancelled = false;
         if (plot == null) {
             if (!Permissions.hasPermission(pp, "plots.admin.interact.road")) {
                 MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.road");
                 cancelled = true;
             }
+        } else if (!plot.hasOwner()) {
+            if (!Permissions.hasPermission(pp, "plots.admin.interact.unowned")) {
+                MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.unowned");
+                cancelled = true;
+            }
         } else {
-            if (!plot.hasOwner()) {
+            UUID uuid = pp.getUUID();
-                if (!Permissions.hasPermission(pp, "plots.admin.interact.unowned")) {
+            if (!plot.isAdded(uuid)) {
-                    MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.unowned");
+                if (!Permissions.hasPermission(pp, "plots.admin.interact.other")) {
+                    MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.other");
                     cancelled = true;
                 }
-            } else {
-                final UUID uuid = pp.getUUID();
-                if (!plot.isAdded(uuid)) {
-                    if (!Permissions.hasPermission(pp, "plots.admin.interact.other")) {
-                        MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.other");
-                        cancelled = true;
-                    }
-                }
             }
         }
         if (cancelled) {
-            if ((current.getTypeId() == newItem.getTypeId()) && (current.getDurability() == newItem.getDurability())) {
+            if ((current.getType() == newItem.getType()) && (current.getDurability() == newItem.getDurability())) {
-                event.setCursor(new ItemStack(newItem.getTypeId(), newItem.getAmount(), newItem.getDurability()));
+                event.setCursor(new ItemStack(newItem.getType(), newItem.getAmount(), newItem.getDurability()));
                 event.setCancelled(true);
                 return;
             }
-            event.setCursor(new ItemStack(newItem.getTypeId(), newItem.getAmount(), newItem.getDurability()));
+            event.setCursor(new ItemStack(newItem.getType(), newItem.getAmount(), newItem.getDurability()));
         }
     }
     
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onInteract(final PlayerInteractAtEntityEvent e) {
+    public void onInteract(PlayerInteractAtEntityEvent e) {
-        final Entity entity = e.getRightClicked();
+        Entity entity = e.getRightClicked();
         if (!(entity instanceof ArmorStand)) {
             return;
         }
-        final Location l = BukkitUtil.getLocation(e.getRightClicked().getLocation());
+        Location l = BukkitUtil.getLocation(e.getRightClicked().getLocation());
-        final PlotArea area = l.getPlotArea();
+        PlotArea area = l.getPlotArea();
         if (area == null) {
             return;
         }
-        final Plot plot = area.getPlotAbs(l);
+        Plot plot = area.getPlotAbs(l);
-        final PlotPlayer pp = BukkitUtil.getPlayer(e.getPlayer());
+        PlotPlayer pp = BukkitUtil.getPlayer(e.getPlayer());
         if (plot == null) {
             if (!Permissions.hasPermission(pp, "plots.admin.interact.road")) {
                 MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.road");
                 e.setCancelled(true);
             }
+        } else if (!plot.hasOwner()) {
+            if (!Permissions.hasPermission(pp, "plots.admin.interact.unowned")) {
+                MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.unowned");
+                e.setCancelled(true);
+            }
         } else {
-            if (!plot.hasOwner()) {
+            UUID uuid = pp.getUUID();
-                if (!Permissions.hasPermission(pp, "plots.admin.interact.unowned")) {
+            if (!plot.isAdded(uuid)) {
-                    MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.unowned");
+                if (!Permissions.hasPermission(pp, "plots.admin.interact.other")) {
+                    MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.other");
                     e.setCancelled(true);
                 }
-            } else {
-                final UUID uuid = pp.getUUID();
-                if (!plot.isAdded(uuid)) {
-                    if (!Permissions.hasPermission(pp, "plots.admin.interact.other")) {
-                        MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.interact.other");
-                        e.setCancelled(true);
-                    }
-                }
             }
         }
     }

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlayerEvents_1_9.java

@@ -0,0 +1,34 @@
+package com.plotsquared.bukkit.listeners;
+
+import com.intellectualcrafters.plot.PS;
+import com.intellectualcrafters.plot.object.Location;
+import com.plotsquared.bukkit.util.BukkitUtil;
+import org.bukkit.entity.LingeringPotion;
+import org.bukkit.event.EventHandler;
+import org.bukkit.event.EventPriority;
+import org.bukkit.event.Listener;
+import org.bukkit.event.entity.LingeringPotionSplashEvent;
+
+/**
+ * Created by Jesse on 3/30/2016.
+ */
+public class PlayerEvents_1_9 implements Listener {
+
+    private final PlayerEvents parent;
+
+    public PlayerEvents_1_9(PlayerEvents parent) {
+        this.parent = parent;
+    }
+
+    @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
+    public void onPotionSplash(LingeringPotionSplashEvent event) {
+        LingeringPotion entity = event.getEntity();
+        Location l = BukkitUtil.getLocation(entity);
+        if (!PS.get().hasPlotArea(l.getWorld())) {
+            return;
+        }
+        if (!parent.onProjectileHit(event)) {
+            event.setCancelled(true);
+        }
+    }
+}

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlotPlusListener.java

@@ -1,23 +1,3 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.listeners;
 
 import com.intellectualcrafters.plot.flag.Flag;
@@ -30,55 +10,45 @@ import com.plotsquared.bukkit.util.BukkitUtil;
 import com.plotsquared.listener.PlotListener;
 import org.bukkit.Bukkit;
 import org.bukkit.GameMode;
-import org.bukkit.Material;
-import org.bukkit.block.BlockState;
 import org.bukkit.entity.EntityType;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.Listener;
 import org.bukkit.event.block.BlockDamageEvent;
-import org.bukkit.event.block.BlockFadeEvent;
 import org.bukkit.event.entity.EntityDamageEvent;
 import org.bukkit.event.player.PlayerDropItemEvent;
 import org.bukkit.event.player.PlayerPickupItemEvent;
 import org.bukkit.event.player.PlayerQuitEvent;
 import org.bukkit.plugin.java.JavaPlugin;
 
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Iterator;
-import java.util.List;
 import java.util.Map.Entry;
 import java.util.UUID;
 
-/**
- * Created 2014-10-30 for PlotSquared
- *
-
- */
-@SuppressWarnings({ "deprecation" })
 public class PlotPlusListener extends PlotListener implements Listener {
-    private final static HashMap<String, Interval> feedRunnable = new HashMap<>();
+
-    private final static HashMap<String, Interval> healRunnable = new HashMap<>();
+    private static final HashMap<String, Interval> feedRunnable = new HashMap<>();
-    
+    private static final HashMap<String, Interval> healRunnable = new HashMap<>();
-    public static void startRunnable(final JavaPlugin plugin) {
+
+    public static void startRunnable(JavaPlugin plugin) {
         plugin.getServer().getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable() {
             @Override
             public void run() {
                 if (!healRunnable.isEmpty()) {
-                    for (final Iterator<Entry<String, Interval>> iter = healRunnable.entrySet().iterator(); iter.hasNext();) {
+                    for (Iterator<Entry<String, Interval>> iterator = healRunnable.entrySet().iterator(); iterator.hasNext(); ) {
-                        final Entry<String, Interval> entry = iter.next();
+                        Entry<String, Interval> entry = iterator.next();
-                        final Interval value = entry.getValue();
+                        Interval value = entry.getValue();
                         ++value.count;
                         if (value.count == value.interval) {
                             value.count = 0;
-                            final Player player = Bukkit.getPlayer(entry.getKey());
+                            Player player = Bukkit.getPlayer(entry.getKey());
                             if (player == null) {
-                                iter.remove();
+                                iterator.remove();
                                 continue;
                             }
-                            final double level = player.getHealth();
+                            double level = player.getHealth();
                             if (level != value.max) {
                                 player.setHealth(Math.min(level + value.amount, value.max));
                             }
@@ -86,18 +56,18 @@ public class PlotPlusListener extends PlotListener implements Listener {
                     }
                 }
                 if (!feedRunnable.isEmpty()) {
-                    for (final Iterator<Entry<String, Interval>> iter = feedRunnable.entrySet().iterator(); iter.hasNext();) {
+                    for (Iterator<Entry<String, Interval>> iterator = feedRunnable.entrySet().iterator(); iterator.hasNext(); ) {
-                        final Entry<String, Interval> entry = iter.next();
+                        Entry<String, Interval> entry = iterator.next();
-                        final Interval value = entry.getValue();
+                        Interval value = entry.getValue();
                         ++value.count;
                         if (value.count == value.interval) {
                             value.count = 0;
-                            final Player player = Bukkit.getPlayer(entry.getKey());
+                            Player player = Bukkit.getPlayer(entry.getKey());
                             if (player == null) {
-                                iter.remove();
+                                iterator.remove();
                                 continue;
                             }
-                            final int level = player.getFoodLevel();
+                            int level = player.getFoodLevel();
                             if (level != value.max) {
                                 player.setFoodLevel(Math.min(level + value.amount, value.max));
                             }
@@ -105,32 +75,16 @@ public class PlotPlusListener extends PlotListener implements Listener {
                     }
                 }
             }
-        }, 0l, 20l);
+        }, 0L, 20L);
     }
 
     @EventHandler(priority = EventPriority.HIGH)
-    public void onMelt(final BlockFadeEvent event) {
+    public void onInteract(BlockDamageEvent event) {
-        final BlockState state = event.getNewState();
+        Player player = event.getPlayer();
-
-        if (state.getType() != Material.WATER && state.getType() != Material.STATIONARY_WATER) {
-            return;
-        }
-        final Plot plot = BukkitUtil.getLocation(state.getLocation()).getOwnedPlot();
-        if (plot == null) {
-            return;
-        }
-        if (!FlagManager.isBooleanFlag(plot, "ice-melt", false)) {
-            event.setCancelled(true);
-        }
-    }
-
-    @EventHandler(priority = EventPriority.HIGH)
-    public void onInteract(final BlockDamageEvent event) {
-        final Player player = event.getPlayer();
         if (player.getGameMode() != GameMode.SURVIVAL) {
             return;
         }
-        final Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
+        Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
         if (plot == null) {
             return;
         }
@@ -140,12 +94,12 @@ public class PlotPlusListener extends PlotListener implements Listener {
     }
     
     @EventHandler(priority = EventPriority.HIGH)
-    public void onDamage(final EntityDamageEvent event) {
+    public void onDamage(EntityDamageEvent event) {
         if (event.getEntityType() != EntityType.PLAYER) {
             return;
         }
-        final Player player = (Player) event.getEntity();
+        Player player = (Player) event.getEntity();
-        final Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
+        Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
         if (plot == null) {
             return;
         }
@@ -155,115 +109,82 @@ public class PlotPlusListener extends PlotListener implements Listener {
     }
     
     @EventHandler
-    public void onItemPickup(final PlayerPickupItemEvent event) {
+    public void onItemPickup(PlayerPickupItemEvent event) {
-        final Player player = event.getPlayer();
+        Player player = event.getPlayer();
-        final PlotPlayer pp = BukkitUtil.getPlayer(player);
+        PlotPlayer pp = BukkitUtil.getPlayer(player);
-        final Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
+        Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
         if (plot == null) {
             return;
         }
-        final UUID uuid = pp.getUUID();
+        UUID uuid = pp.getUUID();
         if (plot.isAdded(uuid) && FlagManager.isBooleanFlag(plot, "drop-protection", false)) {
             event.setCancelled(true);
         }
     }
     
     @EventHandler
-    public void onItemDrop(final PlayerDropItemEvent event) {
+    public void onItemDrop(PlayerDropItemEvent event) {
-        final Player player = event.getPlayer();
+        Player player = event.getPlayer();
-        final PlotPlayer pp = BukkitUtil.getPlayer(player);
+        PlotPlayer pp = BukkitUtil.getPlayer(player);
-        final Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
+        Plot plot = BukkitUtil.getLocation(player).getOwnedPlot();
         if (plot == null) {
             return;
         }
-        final UUID uuid = pp.getUUID();
+        UUID uuid = pp.getUUID();
         if (plot.isAdded(uuid) && FlagManager.isBooleanFlag(plot, "item-drop", false)) {
             event.setCancelled(true);
         }
     }
     
     @EventHandler
-    public void onPlotEnter(final PlayerEnterPlotEvent event) {
+    public void onPlotEnter(PlayerEnterPlotEvent event) {
-        final Player player = event.getPlayer();
+        Player player = event.getPlayer();
-        final Plot plot = event.getPlot();
+        Plot plot = event.getPlot();
-        final Flag feed = FlagManager.getPlotFlagRaw(plot, "feed");
+        Flag feed = FlagManager.getPlotFlagRaw(plot, "feed");
         if (feed != null) {
-            final Integer[] value = (Integer[]) feed.getValue();
+            Integer[] value = (Integer[]) feed.getValue();
             feedRunnable.put(player.getName(), new Interval(value[0], value[1], 20));
         }
-        final Flag heal = FlagManager.getPlotFlagRaw(plot, "heal");
+        Flag heal = FlagManager.getPlotFlagRaw(plot, "heal");
         if (heal != null) {
-            final Integer[] value = (Integer[]) heal.getValue();
+            Integer[] value = (Integer[]) heal.getValue();
             healRunnable.put(player.getName(), new Interval(value[0], value[1], 20));
         }
     }
     
     @EventHandler
-    public void onPlayerQuit(final PlayerQuitEvent event) {
+    public void onPlayerQuit(PlayerQuitEvent event) {
-        final Player player = event.getPlayer();
+        Player player = event.getPlayer();
-        final String name = player.getName();
+        String name = player.getName();
         feedRunnable.remove(name);
         healRunnable.remove(name);
     }
     
     @EventHandler
-    public void onPlotLeave(final PlayerLeavePlotEvent event) {
+    public void onPlotLeave(PlayerLeavePlotEvent event) {
-        final Player leaver = event.getPlayer();
+        Player leaver = event.getPlayer();
-        final Plot plot = event.getPlot();
+        Plot plot = event.getPlot();
         if (!plot.hasOwner()) {
             return;
         }
         BukkitUtil.getPlayer(leaver);
-        final String name = leaver.getName();
+        String name = leaver.getName();
         feedRunnable.remove(name);
         healRunnable.remove(name);
     }
-    
+
-    public static class Interval {
+    private static class Interval {
-        public final int interval;
+
-        public final int amount;
+        final int interval;
-        public final int max;
+        final int amount;
+        final int max;
         public int count = 0;
-        
+
-        public Interval(final int interval, final int amount, final int max) {
+        Interval(int interval, int amount, int max) {
             this.interval = interval;
             this.amount = amount;
             this.max = max;
         }
     }
-    
-    /**
-     * Record Meta Class
-     *
 
-     */
-    public static class RecordMeta {
-        public final static List<RecordMeta> metaList = new ArrayList<>();
-        static {
-            for (int x = 3; x < 12; x++) {
-                metaList.add(new RecordMeta(x + "", Material.valueOf("RECORD_" + x)));
-            }
-        }
-        private final String name;
-        private final Material material;
-        
-        public RecordMeta(final String name, final Material material) {
-            this.name = name;
-            this.material = material;
-        }
-        
-        @Override
-        public String toString() {
-            return name;
-        }
-        
-        @Override
-        public int hashCode() {
-            return name.hashCode();
-        }
-        
-        public Material getMaterial() {
-            return material;
-        }
-    }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/WorldEvents.java

@@ -1,5 +1,8 @@
 package com.plotsquared.bukkit.listeners;
 
+import com.intellectualcrafters.plot.PS;
+import com.intellectualcrafters.plot.generator.GeneratorWrapper;
+import com.plotsquared.bukkit.generator.BukkitPlotGenerator;
 import org.bukkit.World;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
@@ -7,17 +10,13 @@ import org.bukkit.event.Listener;
 import org.bukkit.event.world.WorldInitEvent;
 import org.bukkit.generator.ChunkGenerator;
 
-import com.intellectualcrafters.plot.PS;
-import com.intellectualcrafters.plot.generator.GeneratorWrapper;
-import com.plotsquared.bukkit.generator.BukkitPlotGenerator;
-
 public class WorldEvents implements Listener {
     
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public static void onWorldInit(final WorldInitEvent event) {
+    public void onWorldInit(WorldInitEvent event) {
-        final World world = event.getWorld();
+        World world = event.getWorld();
-        final String name = world.getName();
+        String name = world.getName();
-        final ChunkGenerator gen = world.getGenerator();
+        ChunkGenerator gen = world.getGenerator();
         if (gen instanceof GeneratorWrapper) {
             PS.get().loadWorld(name, (GeneratorWrapper<?>) gen);
         } else {

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/worldedit/WEListener.java

@@ -1,19 +1,5 @@
 package com.plotsquared.bukkit.listeners.worldedit;
 
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.List;
-
-import org.bukkit.Bukkit;
-import org.bukkit.entity.Player;
-import org.bukkit.event.Cancellable;
-import org.bukkit.event.EventHandler;
-import org.bukkit.event.EventPriority;
-import org.bukkit.event.HandlerList;
-import org.bukkit.event.Listener;
-import org.bukkit.event.player.PlayerCommandPreprocessEvent;
-
 import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.config.C;
 import com.intellectualcrafters.plot.config.Settings;
@@ -29,35 +15,39 @@ import com.plotsquared.listener.WEManager;
 import com.sk89q.worldedit.BlockVector;
 import com.sk89q.worldedit.bukkit.WorldEditPlugin;
 import com.sk89q.worldedit.bukkit.selections.Selection;
+import org.bukkit.Bukkit;
+import org.bukkit.entity.Player;
+import org.bukkit.event.Cancellable;
+import org.bukkit.event.EventHandler;
+import org.bukkit.event.EventPriority;
+import org.bukkit.event.HandlerList;
+import org.bukkit.event.Listener;
+import org.bukkit.event.player.PlayerCommandPreprocessEvent;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
 
 public class WEListener implements Listener {
-    
+
-    public final HashSet<String> rad1 = new HashSet<>(Arrays.asList("forestgen", "pumpkins", "drain", "fixwater", "fixlava", "replacenear", "snow", "thaw", "ex", "butcher", "size"));
+    public final HashSet<String> rad1 = new HashSet<>(
+            Arrays.asList("forestgen", "pumpkins", "drain", "fixwater", "fixlava", "replacenear", "snow", "thaw", "ex", "butcher", "size"));
     public final HashSet<String> rad2 = new HashSet<>(Arrays.asList("fill", "fillr", "removenear", "remove"));
     public final HashSet<String> rad2_1 = new HashSet<>(Arrays.asList("hcyl", "cyl"));
     public final HashSet<String> rad2_2 = new HashSet<>(Arrays.asList("sphere", "pyramid"));
     public final HashSet<String> rad2_3 = new HashSet<>(Collections.singletonList("brush smooth"));
     public final HashSet<String> rad3_1 = new HashSet<>(Collections.singletonList("brush gravity"));
     public final HashSet<String> rad3_2 = new HashSet<>(Arrays.asList("brush sphere", "brush cylinder"));
-    
+
-    public final HashSet<String> region = new HashSet<>(Arrays.asList("move", "set", "replace", "overlay", "walls", "outline", "deform", "hollow", "smooth", "naturalize", "paste", "count", "distr",
+    public final HashSet<String> region = new HashSet<>(
-    "regen", "copy", "cut", "green", "setbiome"));
+            Arrays.asList("move", "set", "replace", "overlay", "walls", "outline", "deform", "hollow", "smooth", "naturalize", "paste", "count",
+                    "distr",
+                    "regen", "copy", "cut", "green", "setbiome"));
     public final HashSet<String> regionExtend = new HashSet<>(Collections.singletonList("stack"));
-    public final HashSet<String> unregioned = new HashSet<>(Arrays.asList("paste", "redo", "undo", "rotate", "flip", "generate", "schematic", "schem"));
-    public final HashSet<String> unsafe1 = new HashSet<>(Arrays.asList("cs", ".s", "restore", "snapshot", "delchunks", "listchunks"));
     public final HashSet<String> restricted = new HashSet<>(Collections.singletonList("up"));
     public final HashSet<String> other = new HashSet<>(Arrays.asList("undo", "redo"));
-    
+
-    public boolean checkCommand(final List<String> list, final String cmd) {
+    public String reduceCmd(String cmd, boolean single) {
-        for (final String identifier : list) {
-            if (("/" + identifier).equals(cmd) || ("//" + identifier).equals(cmd) || ("/worldedit:/" + identifier).equals(cmd) || ("/worldedit:" + identifier).equals(cmd)) {
-                return true;
-            }
-        }
-        return false;
-    }
-    
-    public String reduceCmd(final String cmd, final boolean single) {
         if (cmd.startsWith("/worldedit:/")) {
             return cmd.substring(12);
         }
@@ -72,24 +62,24 @@ public class WEListener implements Listener {
         }
         return cmd;
     }
-    
+
-    public int getInt(final String s) {
+    public int getInt(String s) {
         try {
             int max = 0;
-            final String[] split = s.split(",");
+            String[] split = s.split(",");
-            for (final String rad : split) {
+            for (String rad : split) {
-                final int val = Integer.parseInt(rad);
+                int val = Integer.parseInt(rad);
                 if (val > max) {
                     max = val;
                 }
             }
             return max;
-        } catch (final NumberFormatException e) {
+        } catch (NumberFormatException e) {
             return 0;
         }
     }
-    
+
-    public boolean checkVolume(final PlotPlayer player, final long volume, final long max, final Cancellable e) {
+    public boolean checkVolume(PlotPlayer player, long volume, long max, Cancellable e) {
         if (volume > max) {
             MainUtil.sendMessage(player, C.WORLDEDIT_VOLUME.s().replaceAll("%current%", volume + "").replaceAll("%max%", max + ""));
             e.setCancelled(true);
@@ -99,16 +89,16 @@ public class WEListener implements Listener {
         }
         return true;
     }
-    
+
-    public boolean checkSelection(final Player p, final PlotPlayer pp, final int modifier, final long max, final Cancellable e) {
+    public boolean checkSelection(Player p, PlotPlayer pp, int modifier, long max, Cancellable e) {
-        final Selection selection = BukkitMain.worldEdit.getSelection(p);
+        Selection selection = BukkitMain.worldEdit.getSelection(p);
         if (selection == null) {
             return true;
         }
-        final BlockVector pos1 = selection.getNativeMinimumPoint().toBlockVector();
+        BlockVector pos1 = selection.getNativeMinimumPoint().toBlockVector();
-        final BlockVector pos2 = selection.getNativeMaximumPoint().toBlockVector();
+        BlockVector pos2 = selection.getNativeMaximumPoint().toBlockVector();
-        final HashSet<RegionWrapper> mask = WEManager.getMask(pp);
+        HashSet<RegionWrapper> mask = WEManager.getMask(pp);
-        final RegionWrapper region = new RegionWrapper(pos1.getBlockX(), pos2.getBlockX(), pos1.getBlockZ(), pos2.getBlockZ());
+        RegionWrapper region = new RegionWrapper(pos1.getBlockX(), pos2.getBlockX(), pos1.getBlockZ(), pos2.getBlockZ());
         if (Settings.REQUIRE_SELECTION) {
             String arg = null;
             if (!WEManager.regionContains(region, mask)) {
@@ -135,15 +125,16 @@ public class WEListener implements Listener {
                 return true;
             }
         }
-        final long volume = Math.abs((pos1.getBlockX() - pos2.getBlockX()) * (pos1.getBlockY() - pos2.getBlockY()) * (pos1.getBlockZ() - pos2.getBlockZ())) * modifier;
+        long volume = Math.abs((pos1.getBlockX() - pos2.getBlockX()) * (pos1.getBlockY() - pos2.getBlockY()) * (pos1.getBlockZ() - pos2.getBlockZ()))
+                * modifier;
         return checkVolume(pp, volume, max, e);
     }
 
-    public boolean delay(final Player player, final String command, final boolean delayed) {
+    public boolean delay(final Player player, final String command, boolean delayed) {
         if (!Settings.QUEUE_COMMANDS || !Settings.EXPERIMENTAL_FAST_ASYNC_WORLDEDIT) {
             return false;
         }
-        final boolean free = SetQueue.IMP.addTask(null);
+        boolean free = SetQueue.IMP.addTask(null);
         if (free) {
             if (delayed) {
                 MainUtil.sendMessage(BukkitUtil.getPlayer(player), C.WORLDEDIT_RUN, command);
@@ -164,84 +155,85 @@ public class WEListener implements Listener {
         }
         return true;
     }
-    
+
     @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)
-    public boolean onPlayerCommand(final PlayerCommandPreprocessEvent e) {
+    public boolean onPlayerCommand(PlayerCommandPreprocessEvent e) {
-        final WorldEditPlugin worldedit = BukkitMain.worldEdit;
+        WorldEditPlugin worldedit = BukkitMain.worldEdit;
         if (worldedit == null) {
             HandlerList.unregisterAll(this);
             return true;
         }
-        final Player p = e.getPlayer();
+        Player p = e.getPlayer();
-        final PlotPlayer pp = BukkitUtil.getPlayer(p);
+        PlotPlayer pp = BukkitUtil.getPlayer(p);
         if (!PS.get().hasPlotArea(p.getWorld().getName())) {
             return true;
         }
-        final String message = e.getMessage();
+        String message = e.getMessage();
-        final String cmd = message.toLowerCase();
+        String cmd = message.toLowerCase();
-        final boolean single = true;
+        String[] split = cmd.split(" ");
-        final String[] split = cmd.split(" ");
+
-        
+        long maxVolume = Settings.WE_MAX_VOLUME;
-        final long maxVolume = Settings.WE_MAX_VOLUME;
+        long maxIterations = Settings.WE_MAX_ITERATIONS;
-        final long maxIterations = Settings.WE_MAX_ITERATIONS;
         if (pp.getAttribute("worldedit")) {
             return true;
         }
+        boolean single = true;
         if (split.length >= 2) {
-            final String reduced = reduceCmd(split[0], single);
+            String reduced = reduceCmd(split[0], single);
-            final String reduced2 = reduceCmd(split[0] + " " + split[1], single);
+            String reduced2 = reduceCmd(split[0] + " " + split[1], single);
-            if (rad1.contains(reduced)) {
+            if (this.rad1.contains(reduced)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
                 }
-                final long volume = getInt(split[1]) * 256;
+                long volume = getInt(split[1]) * 256;
                 return checkVolume(pp, volume, maxVolume, e);
             }
-            if (rad2.contains(reduced)) {
+            if (this.rad2.contains(reduced)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
                 }
                 if (split.length >= 3) {
-                    final long volume = getInt(split[2]) * 256;
+                    long volume = getInt(split[2]) * 256;
                     return checkVolume(pp, volume, maxVolume, e);
                 }
                 return true;
             }
-            if (rad2_1.contains(reduced)) {
+            if (this.rad2_1.contains(reduced)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
                 }
                 if (split.length >= 4) {
-                    final long volume = getInt(split[2]) * getInt(split[3]);
+                    long volume = getInt(split[2]) * getInt(split[3]);
                     return checkVolume(pp, volume, maxVolume, e);
                 }
                 return true;
             }
-            if (rad2_2.contains(reduced)) {
+            if (this.rad2_2.contains(reduced)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
                 }
                 if (split.length >= 3) {
-                    final long radius = getInt(split[2]);
+                    long radius = getInt(split[2]);
-                    final long volume = radius * radius;
+                    long volume = radius * radius;
                     return checkVolume(pp, volume, maxVolume, e);
                 }
                 return true;
             }
-            if (rad2_3.contains(reduced2)) {
+            if (this.rad2_3.contains(reduced2)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
                 }
                 if (split.length >= 3) {
                     if (split.length == 4) {
-                        final int iterations = getInt(split[3]);
+                        int iterations = getInt(split[3]);
                         if (iterations > maxIterations) {
-                            MainUtil.sendMessage(pp, C.WORLDEDIT_ITERATIONS.s().replaceAll("%current%", iterations + "").replaceAll("%max%", maxIterations + ""));
+                            MainUtil.sendMessage(pp,
+                                    C.WORLDEDIT_ITERATIONS.s().replaceAll("%current%", iterations + "").replaceAll("%max%", maxIterations + ""));
                             e.setCancelled(true);
                             if (Permissions.hasPermission(pp, "plots.worldedit.bypass")) {
                                 MainUtil.sendMessage(pp, C.WORLDEDIT_BYPASS);
@@ -249,13 +241,13 @@ public class WEListener implements Listener {
                             return true;
                         }
                     }
-                    final long radius = getInt(split[2]);
+                    long radius = getInt(split[2]);
-                    final long volume = radius * radius;
+                    long volume = radius * radius;
                     return checkVolume(pp, volume, maxVolume, e);
                 }
                 return true;
             }
-            if (rad3_1.contains(reduced2)) {
+            if (this.rad3_1.contains(reduced2)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
@@ -265,13 +257,13 @@ public class WEListener implements Listener {
                     if (split[i].equalsIgnoreCase("-h")) {
                         i = 3;
                     }
-                    final long radius = getInt(split[i]);
+                    long radius = getInt(split[i]);
-                    final long volume = radius * radius;
+                    long volume = radius * radius;
                     return checkVolume(pp, volume, maxVolume, e);
                 }
                 return true;
             }
-            if (rad3_2.contains(reduced2)) {
+            if (this.rad3_2.contains(reduced2)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
@@ -281,13 +273,13 @@ public class WEListener implements Listener {
                     if (split[i].equalsIgnoreCase("-h")) {
                         i = 4;
                     }
-                    final long radius = getInt(split[i]);
+                    long radius = getInt(split[i]);
-                    final long volume = radius * radius;
+                    long volume = radius * radius;
                     return checkVolume(pp, volume, maxVolume, e);
                 }
                 return true;
             }
-            if (regionExtend.contains(reduced)) {
+            if (this.regionExtend.contains(reduced)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
                     return true;
@@ -295,7 +287,7 @@ public class WEListener implements Listener {
                 return checkSelection(p, pp, getInt(split[1]), maxVolume, e);
             }
         }
-        final String reduced = reduceCmd(split[0], single);
+        String reduced = reduceCmd(split[0], single);
         if (Settings.WE_BLACKLIST.contains(reduced)) {
             MainUtil.sendMessage(pp, C.WORLDEDIT_UNSAFE);
             e.setCancelled(true);
@@ -303,8 +295,8 @@ public class WEListener implements Listener {
                 MainUtil.sendMessage(pp, C.WORLDEDIT_BYPASS);
             }
         }
-        if (restricted.contains(reduced)) {
+        if (this.restricted.contains(reduced)) {
-            final Plot plot = pp.getCurrentPlot();
+            Plot plot = pp.getCurrentPlot();
             if ((plot != null) && plot.isAdded(pp.getUUID())) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
@@ -319,14 +311,14 @@ public class WEListener implements Listener {
             }
             return true;
         }
-        if (region.contains(reduced)) {
+        if (this.region.contains(reduced)) {
             if (delay(p, message, false)) {
                 e.setCancelled(true);
                 return true;
             }
             return checkSelection(p, pp, 1, maxVolume, e);
         }
-        if (other.contains(reduced)) {
+        if (this.other.contains(reduced)) {
             if (delay(p, message, false)) {
                 e.setCancelled(true);
                 return true;

Bukkit/src/main/java/com/plotsquared/bukkit/object/BukkitLazyBlock.java

@@ -1,40 +1,39 @@
 package com.plotsquared.bukkit.object;
 
-import org.bukkit.block.Block;
-
 import com.intellectualcrafters.plot.object.LazyBlock;
 import com.intellectualcrafters.plot.object.PlotBlock;
+import org.bukkit.block.Block;
 
 public class BukkitLazyBlock extends LazyBlock {
-    
+
     private int id;
     private Block block;
     private PlotBlock pb;
-    
+
-    public BukkitLazyBlock(final int id, final Block block) {
+    public BukkitLazyBlock(int id, Block block) {
         this.id = id;
         this.block = block;
     }
-    
+
-    public BukkitLazyBlock(final PlotBlock pb) {
+    public BukkitLazyBlock(PlotBlock pb) {
-        id = pb.id;
+        this.id = pb.id;
         this.pb = pb;
     }
-    
+
-    public BukkitLazyBlock(final Block block) {
+    public BukkitLazyBlock(Block block) {
         this.block = block;
     }
-    
+
     @Override
     public PlotBlock getPlotBlock() {
-        if (pb != null) {
+        if (this.pb != null) {
-            return pb;
+            return this.pb;
         }
-        if (id == 0) {
+        if (this.id == 0) {
-            id = block.getTypeId();
+            this.id = this.block.getTypeId();
         }
         byte data;
-        switch (id) {
+        switch (this.id) {
             case 0:
             case 2:
             case 4:
@@ -120,20 +119,20 @@ public class BukkitLazyBlock extends LazyBlock {
                 data = 0;
                 break;
             default:
-                data = block.getData();
+                data = this.block.getData();
                 break;
         }
-        pb = new PlotBlock((short) id, data);
+        this.pb = new PlotBlock((short) this.id, data);
-        return pb;
+        return this.pb;
-        
+
     }
-    
+
     @Override
     public int getId() {
-        if (id == 0) {
+        if (this.id == 0) {
-            id = block.getTypeId();
+            this.id = this.block.getTypeId();
         }
-        return id;
+        return this.id;
     }
-    
+
 }

Bukkit/src/main/java/com/plotsquared/bukkit/object/BukkitOfflinePlayer.java

@@ -1,40 +1,41 @@
 package com.plotsquared.bukkit.object;
 
+import com.intellectualcrafters.plot.object.OfflinePlotPlayer;
+import org.bukkit.OfflinePlayer;
+
 import java.util.UUID;
 
-import org.bukkit.OfflinePlayer;
-
-import com.intellectualcrafters.plot.object.OfflinePlotPlayer;
-
 public class BukkitOfflinePlayer implements OfflinePlotPlayer {
-    
+
     public final OfflinePlayer player;
-    
+
     /**
-     * Please do not use this method. Instead use BukkitUtil.getPlayer(Player), as it caches player objects.
+     * <p>Please do not use this method. Instead use BukkitUtil.getPlayer(Player),
+     * as it caches player objects.</p>
+     *
      * @param player
      */
-    public BukkitOfflinePlayer(final OfflinePlayer player) {
+    public BukkitOfflinePlayer(OfflinePlayer player) {
         this.player = player;
     }
-    
+
     @Override
     public UUID getUUID() {
-        return player.getUniqueId();
+        return this.player.getUniqueId();
     }
-    
+
     @Override
     public long getLastPlayed() {
-        return player.getLastPlayed();
+        return this.player.getLastPlayed();
     }
-    
+
     @Override
     public boolean isOnline() {
-        return player.isOnline();
+        return this.player.isOnline();
     }
-    
+
     @Override
     public String getName() {
-        return player.getName();
+        return this.player.getName();
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/object/BukkitPlayer.java

@@ -1,21 +1,17 @@
 package com.plotsquared.bukkit.object;
 
-import com.intellectualcrafters.plot.config.C;
 import com.intellectualcrafters.plot.object.Location;
 import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.intellectualcrafters.plot.util.EconHandler;
-import com.intellectualcrafters.plot.util.PlotGamemode;
+import com.intellectualcrafters.plot.util.PlotGameMode;
 import com.intellectualcrafters.plot.util.PlotWeather;
 import com.intellectualcrafters.plot.util.UUIDHandler;
 import com.plotsquared.bukkit.util.BukkitUtil;
-import org.bukkit.Bukkit;
 import org.bukkit.Effect;
 import org.bukkit.GameMode;
 import org.bukkit.WeatherType;
 import org.bukkit.entity.Player;
 import org.bukkit.event.player.PlayerTeleportEvent.TeleportCause;
-import org.bukkit.permissions.Permission;
-import org.bukkit.plugin.PluginManager;
 
 import java.util.UUID;
 
@@ -28,15 +24,16 @@ public class BukkitPlayer extends PlotPlayer {
     private long last = 0;
     
     /**
-     * Please do not use this method. Instead use BukkitUtil.getPlayer(Player), as it caches player objects.
+     * <p>Please do not use this method. Instead use
+     * BukkitUtil.getPlayer(Player), as it caches player objects.</p>
      * @param player
      */
-    public BukkitPlayer(final Player player) {
+    public BukkitPlayer(Player player) {
         this.player = player;
         super.populatePersistentMetaMap();
     }
-    
+
-    public BukkitPlayer(final Player player, final boolean offline) {
+    public BukkitPlayer(Player player, boolean offline) {
         this.player = player;
         this.offline = offline;
         super.populatePersistentMetaMap();
@@ -44,186 +41,161 @@ public class BukkitPlayer extends PlotPlayer {
     
     @Override
     public long getPreviousLogin() {
-        if (last == 0) {
+        if (this.last == 0) {
-            last = player.getLastPlayed();
+            this.last = this.player.getLastPlayed();
         }
-        return last;
+        return this.last;
     }
     
     @Override
     public Location getLocation() {
-        final Location loc = super.getLocation();
+        Location location = super.getLocation();
-        return loc == null ? BukkitUtil.getLocation(player) : loc;
+        return location == null ? BukkitUtil.getLocation(this.player) : location;
     }
     
     @Override
     public UUID getUUID() {
-        if (uuid == null) {
+        if (this.uuid == null) {
-            uuid = UUIDHandler.getUUID(this);
+            this.uuid = UUIDHandler.getUUID(this);
         }
-        return uuid;
+        return this.uuid;
     }
     
     @Override
-    public boolean hasPermission(final String node) {
+    public boolean hasPermission(String permission) {
-        if (offline && EconHandler.manager != null) {
+        if (this.offline && EconHandler.manager != null) {
-            return EconHandler.manager.hasPermission(getName(), node);
+            return EconHandler.manager.hasPermission(getName(), permission);
         }
-        return player.hasPermission(node);
+        return this.player.hasPermission(permission);
     }
-    
+
-    public Permission getPermission(final String node) {
+    @Override
-        final PluginManager manager = Bukkit.getPluginManager();
+    public void sendMessage(String message) {
-        Permission perm = manager.getPermission(node);
+        this.player.sendMessage(message);
-        if (perm == null) {
-            final String[] nodes = node.split("\\.");
-            perm = new Permission(node);
-            final StringBuilder n = new StringBuilder();
-            for (int i = 0; i < nodes.length - 1; i++) {
-                n.append(nodes[i]).append(".");
-                if (!node.equals(n + C.PERMISSION_STAR.s())) {
-                    final Permission parent = getPermission(n + C.PERMISSION_STAR.s());
-                    if (parent != null) {
-                        perm.addParent(parent, true);
-                    }
-                }
-            }
-            manager.addPermission(perm);
-        }
-        manager.recalculatePermissionDefaults(perm);
-        perm.recalculatePermissibles();
-        return perm;
     }
     
     @Override
-    public void sendMessage(final String message) {
+    public void teleport(Location location) {
-        player.sendMessage(message);
+        if (Math.abs(location.getX()) >= 30000000 || Math.abs(location.getZ()) >= 30000000) {
-    }
-    
-    @Override
-    public void teleport(final Location loc) {
-        if (Math.abs(loc.getX()) >= 30000000 || Math.abs(loc.getZ()) >= 30000000) {
             return;
         }
-        player.teleport(new org.bukkit.Location(BukkitUtil.getWorld(loc.getWorld()), loc.getX() + 0.5, loc.getY(), loc.getZ() + 0.5, loc.getYaw(), loc.getPitch()), TeleportCause.COMMAND);
+        this.player.teleport(
+                new org.bukkit.Location(BukkitUtil.getWorld(location.getWorld()), location.getX() + 0.5, location.getY(), location.getZ() + 0.5,
+                        location.getYaw(), location.getPitch()), TeleportCause.COMMAND);
     }
     
     @Override
     public String getName() {
-        if (name == null) {
+        if (this.name == null) {
-            name = player.getName();
+            this.name = this.player.getName();
         }
-        return name;
+        return this.name;
     }
     
     @Override
     public boolean isOnline() {
-        return !offline && player.isOnline();
+        return !this.offline && this.player.isOnline();
     }
     
     @Override
-    public void setCompassTarget(final Location loc) {
+    public void setCompassTarget(Location location) {
-        player.setCompassTarget(new org.bukkit.Location(BukkitUtil.getWorld(loc.getWorld()), loc.getX(), loc.getY(), loc.getZ()));
+        this.player.setCompassTarget(
+                new org.bukkit.Location(BukkitUtil.getWorld(location.getWorld()), location.getX(), location.getY(), location.getZ()));
         
     }
     
     @Override
     public Location getLocationFull() {
-        return BukkitUtil.getLocationFull(player);
+        return BukkitUtil.getLocationFull(this.player);
     }
-    
+
     @Override
-    public void loadData() {
+    public void setWeather(PlotWeather weather) {
-        if (!player.isOnline()) {
-            player.loadData();
-        }
-    }
-    
-    @Override
-    public void saveData() {
-        player.saveData();
-    }
-    
-    @Override
-    public void setWeather(final PlotWeather weather) {
         switch (weather) {
             case CLEAR:
-                player.setPlayerWeather(WeatherType.CLEAR);
+                this.player.setPlayerWeather(WeatherType.CLEAR);
-                return;
+                break;
             case RAIN:
-                player.setPlayerWeather(WeatherType.DOWNFALL);
+                this.player.setPlayerWeather(WeatherType.DOWNFALL);
-                return;
+                break;
             case RESET:
-                player.resetPlayerWeather();
+                this.player.resetPlayerWeather();
-                return;
+                break;
+            default:
+                this.player.resetPlayerWeather();
+                break;
         }
     }
     
     @Override
-    public PlotGamemode getGamemode() {
+    public PlotGameMode getGameMode() {
-        switch (player.getGameMode()) {
+        switch (this.player.getGameMode()) {
             case ADVENTURE:
-                return PlotGamemode.ADVENTURE;
+                return PlotGameMode.ADVENTURE;
             case CREATIVE:
-                return PlotGamemode.CREATIVE;
+                return PlotGameMode.CREATIVE;
             case SPECTATOR:
-                return PlotGamemode.SPECTATOR;
+                return PlotGameMode.SPECTATOR;
             case SURVIVAL:
-                return PlotGamemode.SURVIVAL;
+                return PlotGameMode.SURVIVAL;
+            default:
+                return PlotGameMode.NOT_SET;
         }
-        return null;
     }
     
     @Override
-    public void setGamemode(final PlotGamemode gamemode) {
+    public void setGameMode(PlotGameMode gameMode) {
-        switch (gamemode) {
+        switch (gameMode) {
             case ADVENTURE:
-                player.setGameMode(GameMode.ADVENTURE);
+                this.player.setGameMode(GameMode.ADVENTURE);
-                return;
+                break;
             case CREATIVE:
-                player.setGameMode(GameMode.CREATIVE);
+                this.player.setGameMode(GameMode.CREATIVE);
-                return;
+                break;
             case SPECTATOR:
-                player.setGameMode(GameMode.SPECTATOR);
+                this.player.setGameMode(GameMode.SPECTATOR);
-                return;
+                break;
             case SURVIVAL:
-                player.setGameMode(GameMode.SURVIVAL);
+                this.player.setGameMode(GameMode.SURVIVAL);
-                return;
+                break;
+            default:
+                this.player.setGameMode(GameMode.SURVIVAL);
+                break;
         }
     }
     
     @Override
-    public void setTime(final long time) {
+    public void setTime(long time) {
         if (time != Long.MAX_VALUE) {
-            player.setPlayerTime(time, false);
+            this.player.setPlayerTime(time, false);
         } else {
-            player.resetPlayerTime();
+            this.player.resetPlayerTime();
         }
     }
     
     @Override
-    public void setFlight(final boolean fly) {
+    public void setFlight(boolean fly) {
-        player.setAllowFlight(fly);
+        this.player.setAllowFlight(fly);
     }
     
     @Override
-    public void playMusic(final Location loc, final int id) {
+    public void playMusic(Location location, int id) {
-        player.playEffect(BukkitUtil.getLocation(loc), Effect.RECORD_PLAY, id);
+        this.player.playEffect(BukkitUtil.getLocation(location), Effect.RECORD_PLAY, id);
     }
     
     @Override
-    public void kick(final String message) {
+    public void kick(String message) {
-        player.kickPlayer(message);
+        this.player.kickPlayer(message);
     }
 
     @Override public void stopSpectating() {
-        if (getGamemode() == PlotGamemode.SPECTATOR) {
+        if (getGameMode() == PlotGameMode.SPECTATOR) {
-            player.setSpectatorTarget(null);
+            this.player.setSpectatorTarget(null);
         }
     }
 
     @Override
     public boolean isBanned() {
-        return player.isBanned();
+        return this.player.isBanned();
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/object/entity/ArmorStandStats.java

@@ -1,12 +1,13 @@
 package com.plotsquared.bukkit.object.entity;
 
 public class ArmorStandStats {
-    public float[] head = new float[3];
+
-    public float[] body = new float[3];
+    public final float[] head = new float[3];
-    public float[] leftLeg = new float[3];
+    public final float[] body = new float[3];
-    public float[] rightLeg = new float[3];
+    public final float[] leftLeg = new float[3];
-    public float[] leftArm = new float[3];
+    public final float[] rightLeg = new float[3];
-    public float[] rightArm = new float[3];
+    public final float[] leftArm = new float[3];
+    public final float[] rightArm = new float[3];
     public boolean arms;
     public boolean noplate;
     public boolean nogravity;

Bukkit/src/main/java/com/plotsquared/bukkit/object/entity/EntityWrapper.java

@@ -34,6 +34,7 @@ import org.bukkit.util.Vector;
 
 public class EntityWrapper {
 
+    private final int hash;
     public EntityType type;
     public float yaw;
     public float pitch;
@@ -54,34 +55,32 @@ public class EntityWrapper {
     private HorseStats horse;
     private ArmorStandStats stand;
     
-    private int hash;
-    
     @SuppressWarnings("deprecation")
-    public EntityWrapper(final org.bukkit.entity.Entity entity, final short depth) {
+    public EntityWrapper(Entity entity, short depth) {
-        hash = entity.getEntityId();
+        this.hash = entity.getEntityId();
         this.depth = depth;
-        final Location loc = entity.getLocation();
+        Location loc = entity.getLocation();
-        yaw = loc.getYaw();
+        this.yaw = loc.getYaw();
-        pitch = loc.getPitch();
+        this.pitch = loc.getPitch();
-        x = loc.getX();
+        this.x = loc.getX();
-        y = loc.getY();
+        this.y = loc.getY();
-        z = loc.getZ();
+        this.z = loc.getZ();
-        type = entity.getType();
+        this.type = entity.getType();
         if (depth == 0) {
             return;
         }
-        base = new EntityBaseStats();
+        this.base = new EntityBaseStats();
-        final Entity p = entity.getPassenger();
+        Entity p = entity.getPassenger();
         if (p != null) {
-            base.passenger = new EntityWrapper(p, depth);
+            this.base.passenger = new EntityWrapper(p, depth);
         }
-        base.fall = entity.getFallDistance();
+        this.base.fall = entity.getFallDistance();
-        base.fire = (short) entity.getFireTicks();
+        this.base.fire = (short) entity.getFireTicks();
-        base.age = entity.getTicksLived();
+        this.base.age = entity.getTicksLived();
-        final Vector velocity = entity.getVelocity();
+        Vector velocity = entity.getVelocity();
-        base.v_x = velocity.getX();
+        this.base.v_x = velocity.getX();
-        base.v_y = velocity.getY();
+        this.base.v_y = velocity.getY();
-        base.v_z = velocity.getZ();
+        this.base.v_z = velocity.getZ();
         if (depth == 1) {
             return;
         }
@@ -114,58 +113,55 @@ public class EntityWrapper {
             case THROWN_EXP_BOTTLE:
             case WEATHER:
             case WITHER_SKULL:
-            case UNKNOWN: {
+            case UNKNOWN:
+            case TIPPED_ARROW:
+            case SPECTRAL_ARROW:
+            case SHULKER_BULLET:
+            case DRAGON_FIREBALL:
+            case LINGERING_POTION:
+            case AREA_EFFECT_CLOUD:
                 // Do this stuff later
                 return;
-            }
+            default:
-            default: {
                 PS.debug("&cCOULD NOT IDENTIFY ENTITY: " + entity.getType());
                 return;
-            }
             // MISC //
-            case DROPPED_ITEM: {
+            case DROPPED_ITEM:
-                final Item item = (Item) entity;
+                Item item = (Item) entity;
-                stack = item.getItemStack();
+                this.stack = item.getItemStack();
                 return;
-            }
+            case ITEM_FRAME:
-            case ITEM_FRAME: {
+                ItemFrame itemframe = (ItemFrame) entity;
-                final ItemFrame itemframe = (ItemFrame) entity;
+                this.x = Math.floor(this.x);
-                x = Math.floor(x);
+                this.y = Math.floor(this.y);
-                y = Math.floor(y);
+                this.z = Math.floor(this.z);
-                z = Math.floor(z);
+                this.dataByte = getOrdinal(Rotation.values(), itemframe.getRotation());
-                dataByte = getOrdinal(Rotation.values(), itemframe.getRotation());
+                this.stack = itemframe.getItem().clone();
-                stack = itemframe.getItem().clone();
                 return;
-            }
+            case PAINTING:
-            case PAINTING: {
+                Painting painting = (Painting) entity;
-                final Painting painting = (Painting) entity;
+                this.x = Math.floor(this.x);
-                x = Math.floor(x);
+                this.y = Math.floor(this.y);
-                y = Math.floor(y);
+                this.z = Math.floor(this.z);
-                z = Math.floor(z);
+                Art a = painting.getArt();
-                final Art a = painting.getArt();
+                this.dataByte = getOrdinal(BlockFace.values(), painting.getFacing());
-                dataByte = getOrdinal(BlockFace.values(), painting.getFacing());
+                int h = a.getBlockHeight();
-                final int h = a.getBlockHeight();
+                if (h % 2 == 0) {
-                if ((h % 2) == 0) {
+                    this.y -= 1;
-                    y -= 1;
                 }
-                dataString = a.name();
+                this.dataString = a.name();
                 return;
-            }
             // END MISC //
             // INVENTORY HOLDER //
-            case MINECART_CHEST: {
+            case MINECART_CHEST:
+            case MINECART_HOPPER:
                 storeInventory((InventoryHolder) entity);
                 return;
-            }
-            case MINECART_HOPPER: {
-                storeInventory((InventoryHolder) entity);
-                return;
-            }
             // START LIVING ENTITY //
             // START AGEABLE //
             // START TAMEABLE //
-            case HORSE: {
+            case HORSE:
-                final Horse horse = (Horse) entity;
+                Horse horse = (Horse) entity;
                 this.horse = new HorseStats();
                 this.horse.jump = horse.getJumpStrength();
                 this.horse.chest = horse.isCarryingChest();
@@ -177,83 +173,77 @@ public class EntityWrapper {
                 storeLiving((LivingEntity) entity);
                 storeInventory((InventoryHolder) entity);
                 return;
-            }
             // END INVENTORY HOLDER //
             case WOLF:
-            case OCELOT: {
+            case OCELOT:
                 storeTameable((Tameable) entity);
                 storeAgeable((Ageable) entity);
                 storeLiving((LivingEntity) entity);
                 return;
-            }
+            // END TAMEABLE //
-            // END AMEABLE //
+            case SHEEP:
-            case SHEEP: {
+                Sheep sheep = (Sheep) entity;
-                final Sheep sheep = (Sheep) entity;
+                this.dataByte = (byte) (sheep.isSheared() ? 1 : 0);
-                dataByte = (byte) ((sheep).isSheared() ? 1 : 0);
+                this.dataByte2 = sheep.getColor().getDyeData();
-                dataByte2 = sheep.getColor().getDyeData();
                 storeAgeable((Ageable) entity);
                 storeLiving((LivingEntity) entity);
                 return;
-            }
             case VILLAGER:
             case CHICKEN:
             case COW:
             case MUSHROOM_COW:
-            case PIG: {
+            case PIG:
+                storeAgeable((Ageable) entity);
+                storeLiving((LivingEntity) entity);
+                return;
+            case RABBIT:  // NEW
+                this.dataByte = getOrdinal(Type.values(), ((Rabbit) entity).getRabbitType());
                 storeAgeable((Ageable) entity);
                 storeLiving((LivingEntity) entity);
                 return;
-            }
             // END AGEABLE //
-            case RABBIT: { // NEW
+            case GUARDIAN:  // NEW
-                dataByte = getOrdinal(Type.values(), ((Rabbit) entity).getRabbitType());
+                this.dataByte = (byte) (((Guardian) entity).isElder() ? 1 : 0);
-                storeAgeable((Ageable) entity);
                 storeLiving((LivingEntity) entity);
                 return;
-            }
+            case SKELETON:  // NEW
-            case GUARDIAN: { // NEW
+                this.dataByte = (byte) ((Skeleton) entity).getSkeletonType().getId();
-                dataByte = (byte) (((Guardian) entity).isElder() ? 1 : 0);
                 storeLiving((LivingEntity) entity);
                 return;
-            }
+            case ARMOR_STAND:  // NEW
-            case SKELETON: { // NEW
+                // CHECK positions
-                dataByte = (byte) ((Skeleton) entity).getSkeletonType().getId();
+                ArmorStand stand = (ArmorStand) entity;
-                storeLiving((LivingEntity) entity);
+                this.inventory = new ItemStack[]{stand.getItemInHand().clone(), stand.getHelmet().clone(), stand.getChestplate().clone(),
-                return;
+                        stand.getLeggings().clone(), stand.getBoots().clone()};
-            }
-            case ARMOR_STAND: { // NEW
-                                // CHECK positions
-                final ArmorStand stand = (ArmorStand) entity;
-                inventory = new ItemStack[] { stand.getItemInHand().clone(), stand.getHelmet().clone(), stand.getChestplate().clone(), stand.getLeggings().clone(), stand.getBoots().clone() };
                 storeLiving((LivingEntity) entity);
                 this.stand = new ArmorStandStats();
 
-                final EulerAngle head = stand.getHeadPose();
+                EulerAngle head = stand.getHeadPose();
                 this.stand.head[0] = (float) head.getX();
                 this.stand.head[1] = (float) head.getY();
                 this.stand.head[2] = (float) head.getZ();
 
-                final EulerAngle body = stand.getBodyPose();
+                EulerAngle body = stand.getBodyPose();
                 this.stand.body[0] = (float) body.getX();
                 this.stand.body[1] = (float) body.getY();
                 this.stand.body[2] = (float) body.getZ();
 
-                final EulerAngle leftLeg = stand.getLeftLegPose();
+                EulerAngle leftLeg = stand.getLeftLegPose();
                 this.stand.leftLeg[0] = (float) leftLeg.getX();
                 this.stand.leftLeg[1] = (float) leftLeg.getY();
                 this.stand.leftLeg[2] = (float) leftLeg.getZ();
 
-                final EulerAngle rightLeg = stand.getRightLegPose();
+                EulerAngle rightLeg = stand.getRightLegPose();
                 this.stand.rightLeg[0] = (float) rightLeg.getX();
                 this.stand.rightLeg[1] = (float) rightLeg.getY();
                 this.stand.rightLeg[2] = (float) rightLeg.getZ();
 
-                final EulerAngle leftArm = stand.getLeftArmPose();
+                EulerAngle leftArm = stand.getLeftArmPose();
                 this.stand.leftArm[0] = (float) leftArm.getX();
                 this.stand.leftArm[1] = (float) leftArm.getY();
                 this.stand.leftArm[2] = (float) leftArm.getZ();
 
-                final EulerAngle rightArm = stand.getRightArmPose();
+                EulerAngle rightArm = stand.getRightArmPose();
                 this.stand.rightArm[0] = (float) rightArm.getX();
                 this.stand.rightArm[1] = (float) rightArm.getY();
                 this.stand.rightArm[2] = (float) rightArm.getZ();
@@ -274,7 +264,6 @@ public class EntityWrapper {
                     this.stand.small = true;
                 }
                 return;
-            }
             case ENDERMITE: // NEW
             case BAT:
             case ENDER_DRAGON:
@@ -292,49 +281,48 @@ public class EntityWrapper {
             case ENDERMAN:
             case CREEPER:
             case BLAZE:
+            case SHULKER:
             case SNOWMAN:
-            case IRON_GOLEM: {
+            case IRON_GOLEM:
                 storeLiving((LivingEntity) entity);
-                return;
+                // END LIVING //
-            }
-            // END LIVING //
         }
     }
 
     @Override
-    public boolean equals(final Object obj) {
+    public boolean equals(Object obj) {
-        return hash == obj.hashCode();
+        return this.hash == obj.hashCode();
     }
 
     @Override
     public int hashCode() {
-        return hash;
+        return this.hash;
     }
 
-    public void storeInventory(final InventoryHolder held) {
+    public void storeInventory(InventoryHolder held) {
-        inventory = held.getInventory().getContents().clone();
+        this.inventory = held.getInventory().getContents().clone();
     }
 
-    private void restoreLiving(final LivingEntity entity) {
+    private void restoreLiving(LivingEntity entity) {
-        entity.setCanPickupItems(lived.loot);
+        entity.setCanPickupItems(this.lived.loot);
-        if (lived.name != null) {
+        if (this.lived.name != null) {
-            entity.setCustomName(lived.name);
+            entity.setCustomName(this.lived.name);
-            entity.setCustomNameVisible(lived.visible);
+            entity.setCustomNameVisible(this.lived.visible);
         }
-        if ((lived.potions != null) && (!lived.potions.isEmpty())) {
+        if (this.lived.potions != null && !this.lived.potions.isEmpty()) {
-            entity.addPotionEffects(lived.potions);
+            entity.addPotionEffects(this.lived.potions);
         }
-        entity.setRemainingAir(lived.air);
+        entity.setRemainingAir(this.lived.air);
-        entity.setRemoveWhenFarAway(lived.persistent);
+        entity.setRemoveWhenFarAway(this.lived.persistent);
-        if (lived.equipped) {
+        if (this.lived.equipped) {
-            final EntityEquipment equipment = entity.getEquipment();
+            EntityEquipment equipment = entity.getEquipment();
-            equipment.setItemInHand(lived.hands);
+            equipment.setItemInHand(this.lived.hands);
-            equipment.setHelmet(lived.helmet);
+            equipment.setHelmet(this.lived.helmet);
-            equipment.setChestplate(lived.chestplate);
+            equipment.setChestplate(this.lived.chestplate);
-            equipment.setLeggings(lived.leggings);
+            equipment.setLeggings(this.lived.leggings);
-            equipment.setBoots(lived.boots);
+            equipment.setBoots(this.lived.boots);
         }
-        if (lived.leashed) {
+        if (this.lived.leashed) {
             // TODO leashes
             //            World world = entity.getWorld();
             //            Entity leash = world.spawnEntity(new Location(world, Math.floor(x) + lived.leash_x, Math.floor(y) + lived.leash_y, Math
@@ -343,11 +331,11 @@ public class EntityWrapper {
         }
     }
 
-    private void restoreInventory(final InventoryHolder entity) {
+    private void restoreInventory(InventoryHolder entity) {
-        entity.getInventory().setContents(inventory);
+        entity.getInventory().setContents(this.inventory);
     }
 
-    public void storeLiving(final LivingEntity lived) {
+    public void storeLiving(LivingEntity lived) {
         this.lived = new LivingEntityStats();
         this.lived.potions = lived.getActivePotionEffects();
         this.lived.loot = lived.getCanPickupItems();
@@ -358,12 +346,12 @@ public class EntityWrapper {
         this.lived.persistent = lived.getRemoveWhenFarAway();
         this.lived.leashed = lived.isLeashed();
         if (this.lived.leashed) {
-            final Location loc = lived.getLeashHolder().getLocation();
+            Location loc = lived.getLeashHolder().getLocation();
-            this.lived.leash_x = (short) (x - loc.getBlockX());
+            this.lived.leash_x = (short) (this.x - loc.getBlockX());
-            this.lived.leash_y = (short) (y - loc.getBlockY());
+            this.lived.leash_y = (short) (this.y - loc.getBlockY());
-            this.lived.leash_z = (short) (z - loc.getBlockZ());
+            this.lived.leash_z = (short) (this.z - loc.getBlockZ());
         }
-        final EntityEquipment equipment = lived.getEquipment();
+        EntityEquipment equipment = lived.getEquipment();
         this.lived.equipped = equipment != null;
         if (this.lived.equipped) {
             this.lived.hands = equipment.getItemInHand().clone();
@@ -374,86 +362,83 @@ public class EntityWrapper {
         }
     }
 
-    private void restoreTameable(final Tameable entity) {
+    private void restoreTameable(Tameable entity) {
-        if (tamed.tamed) {
+        if (this.tamed.tamed) {
-            if (tamed.owner != null) {
+            if (this.tamed.owner != null) {
                 entity.setTamed(true);
-                entity.setOwner(tamed.owner);
+                entity.setOwner(this.tamed.owner);
             }
         }
     }
 
-    private void restoreAgeable(final Ageable entity) {
+    private void restoreAgeable(Ageable entity) {
-        if (!aged.adult) {
+        if (!this.aged.adult) {
             entity.setBaby();
         }
-        entity.setAgeLock(aged.locked);
+        entity.setAgeLock(this.aged.locked);
-        if (aged.age > 0) {
+        if (this.aged.age > 0) {
-            entity.setAge(aged.age);
+            entity.setAge(this.aged.age);
         }
     }
 
-    public void storeAgeable(final Ageable aged) {
+    public void storeAgeable(Ageable aged) {
         this.aged = new AgeableStats();
         this.aged.age = aged.getAge();
         this.aged.locked = aged.getAgeLock();
         this.aged.adult = aged.isAdult();
     }
 
-    public void storeTameable(final Tameable tamed) {
+    public void storeTameable(Tameable tamed) {
         this.tamed = new TameableStats();
         this.tamed.owner = tamed.getOwner();
         this.tamed.tamed = tamed.isTamed();
     }
 
     @SuppressWarnings("deprecation")
-    public Entity spawn(final World world, final int x_offset, final int z_offset) {
+    public Entity spawn(World world, int x_offset, int z_offset) {
-        final Location loc = new Location(world, x + x_offset, y, z + z_offset);
+        Location loc = new Location(world, this.x + x_offset, this.y, this.z + z_offset);
-        loc.setYaw(yaw);
+        loc.setYaw(this.yaw);
-        loc.setPitch(pitch);
+        loc.setPitch(this.pitch);
-        if (type.isSpawnable()) {
+        if (!this.type.isSpawnable()) {
             return null;
         }
         Entity entity;
-        switch (type) {
+        switch (this.type) {
-            case DROPPED_ITEM: {
+            case DROPPED_ITEM:
-                return world.dropItem(loc, stack);
+                return world.dropItem(loc, this.stack);
-            }
             case PLAYER:
-            case LEASH_HITCH: {
+            case LEASH_HITCH:
                 return null;
-            }
+            case ITEM_FRAME:
-            case ITEM_FRAME: {
                 entity = world.spawn(loc, ItemFrame.class);
                 break;
-            }
+            case PAINTING:
-            case PAINTING: {
                 entity = world.spawn(loc, Painting.class);
                 break;
-            }
             default:
-                entity = world.spawnEntity(loc, type);
+                entity = world.spawnEntity(loc, this.type);
                 break;
         }
-        if (depth == 0) {
+        if (this.depth == 0) {
             return entity;
         }
-        if (base.passenger != null) {
+        if (this.base.passenger != null) {
             try {
-                entity.setPassenger(base.passenger.spawn(world, x_offset, z_offset));
+                entity.setPassenger(this.base.passenger.spawn(world, x_offset, z_offset));
-            } catch (final Exception e) {}
+            } catch (Exception e) {
+            }
         }
-        if (base.fall != 0) {
+        if (this.base.fall != 0) {
-            entity.setFallDistance(base.fall);
+            entity.setFallDistance(this.base.fall);
         }
-        if (base.fire != 0) {
+        if (this.base.fire != 0) {
-            entity.setFireTicks(base.fire);
+            entity.setFireTicks(this.base.fire);
         }
-        if (base.age != 0) {
+        if (this.base.age != 0) {
-            entity.setTicksLived(base.age);
+            entity.setTicksLived(this.base.age);
         }
-        entity.setVelocity(new Vector(base.v_x, base.v_y, base.v_z));
+        entity.setVelocity(new Vector(this.base.v_x, this.base.v_y, this.base.v_z));
-        if (depth == 1) {
+        if (this.depth == 1) {
             return entity;
         }
         switch (entity.getType()) {
@@ -485,42 +470,34 @@ public class EntityWrapper {
             case WEATHER:
             case WITHER_SKULL:
             case MINECART_FURNACE:
-            case UNKNOWN: {
+            case UNKNOWN:
                 // Do this stuff later
                 return entity;
-            }
+            default:
-            default: {
                 PS.debug("&cCOULD NOT IDENTIFY ENTITY: " + entity.getType());
                 return entity;
-            }
             // MISC //
-            case ITEM_FRAME: {
+            case ITEM_FRAME:
-                final ItemFrame itemframe = (ItemFrame) entity;
+                ItemFrame itemframe = (ItemFrame) entity;
-                itemframe.setRotation(Rotation.values()[dataByte]);
+                itemframe.setRotation(Rotation.values()[this.dataByte]);
-                itemframe.setItem(stack);
+                itemframe.setItem(this.stack);
                 return entity;
-            }
+            case PAINTING:
-            case PAINTING: {
+                Painting painting = (Painting) entity;
-                final Painting painting = (Painting) entity;
+                painting.setFacingDirection(BlockFace.values()[this.dataByte], true);
-                painting.setFacingDirection(BlockFace.values()[dataByte], true);
+                painting.setArt(Art.getByName(this.dataString), true);
-                painting.setArt(Art.getByName(dataString), true);
                 return entity;
-            }
             // END MISC //
             // INVENTORY HOLDER //
-            case MINECART_CHEST: {
+            case MINECART_CHEST:
+            case MINECART_HOPPER:
                 restoreInventory((InventoryHolder) entity);
                 return entity;
-            }
-            case MINECART_HOPPER: {
-                restoreInventory((InventoryHolder) entity);
-                return entity;
-            }
             // START LIVING ENTITY //
             // START AGEABLE //
             // START TAMEABLE //
-            case HORSE: {
+            case HORSE:
-                final Horse horse = (Horse) entity;
+                Horse horse = (Horse) entity;
                 horse.setJumpStrength(this.horse.jump);
                 horse.setCarryingChest(this.horse.chest);
                 horse.setVariant(Variant.values()[this.horse.variant]);
@@ -531,100 +508,93 @@ public class EntityWrapper {
                 restoreLiving((LivingEntity) entity);
                 restoreInventory((InventoryHolder) entity);
                 return entity;
-            }
             // END INVENTORY HOLDER //
             case WOLF:
-            case OCELOT: {
+            case OCELOT:
                 restoreTameable((Tameable) entity);
                 restoreAgeable((Ageable) entity);
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
             // END AGEABLE //
-            case SHEEP: {
+            case SHEEP:
-                final Sheep sheep = (Sheep) entity;
+                Sheep sheep = (Sheep) entity;
-                if (dataByte == 1) {
+                if (this.dataByte == 1) {
                     sheep.setSheared(true);
                 }
-                if (dataByte2 != 0) {
+                if (this.dataByte2 != 0) {
-                    sheep.setColor(DyeColor.getByDyeData(dataByte2));
+                    sheep.setColor(DyeColor.getByDyeData(this.dataByte2));
                 }
                 restoreAgeable((Ageable) entity);
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
             case VILLAGER:
             case CHICKEN:
             case COW:
             case MUSHROOM_COW:
-            case PIG: {
+            case PIG:
                 restoreAgeable((Ageable) entity);
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
             // END AGEABLE //
-            case RABBIT: { // NEW
+            case RABBIT:  // NEW
-                if (dataByte != 0) {
+                if (this.dataByte != 0) {
-                    ((Rabbit) entity).setRabbitType(Type.values()[dataByte]);
+                    ((Rabbit) entity).setRabbitType(Type.values()[this.dataByte]);
                 }
                 restoreAgeable((Ageable) entity);
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
+            case GUARDIAN:  // NEW
-            case GUARDIAN: { // NEW
+                if (this.dataByte != 0) {
-                if (dataByte != 0) {
                     ((Guardian) entity).setElder(true);
                 }
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
+            case SKELETON:  // NEW
-            case SKELETON: { // NEW
+                if (this.dataByte != 0) {
-                if (dataByte != 0) {
+                    ((Skeleton) entity).setSkeletonType(SkeletonType.values()[this.dataByte]);
-                    ((Skeleton) entity).setSkeletonType(SkeletonType.values()[dataByte]);
                 }
                 storeLiving((LivingEntity) entity);
                 return entity;
-            }
+            case ARMOR_STAND:  // NEW
-            case ARMOR_STAND: { // NEW
+                // CHECK positions
-                                // CHECK positions
+                ArmorStand stand = (ArmorStand) entity;
-                final ArmorStand stand = (ArmorStand) entity;
+                if (this.inventory[0] != null) {
-                if (inventory[0] != null) {
+                    stand.setItemInHand(this.inventory[0]);
-                    stand.setItemInHand(inventory[0]);
                 }
-                if (inventory[1] != null) {
+                if (this.inventory[1] != null) {
-                    stand.setHelmet(inventory[1]);
+                    stand.setHelmet(this.inventory[1]);
                 }
-                if (inventory[2] != null) {
+                if (this.inventory[2] != null) {
-                    stand.setChestplate(inventory[2]);
+                    stand.setChestplate(this.inventory[2]);
                 }
-                if (inventory[3] != null) {
+                if (this.inventory[3] != null) {
-                    stand.setLeggings(inventory[3]);
+                    stand.setLeggings(this.inventory[3]);
                 }
-                if (inventory[4] != null) {
+                if (this.inventory[4] != null) {
-                    stand.setBoots(inventory[4]);
+                    stand.setBoots(this.inventory[4]);
                 }
-                if ((this.stand.head[0] != 0) || (this.stand.head[1] != 0) || (this.stand.head[2] != 0)) {
+                if (this.stand.head[0] != 0 || this.stand.head[1] != 0 || this.stand.head[2] != 0) {
-                    final EulerAngle pose = new EulerAngle(this.stand.head[0], this.stand.head[1], this.stand.head[2]);
+                    EulerAngle pose = new EulerAngle(this.stand.head[0], this.stand.head[1], this.stand.head[2]);
                     stand.setHeadPose(pose);
                 }
-                if ((this.stand.body[0] != 0) || (this.stand.body[1] != 0) || (this.stand.body[2] != 0)) {
+                if (this.stand.body[0] != 0 || this.stand.body[1] != 0 || this.stand.body[2] != 0) {
-                    final EulerAngle pose = new EulerAngle(this.stand.body[0], this.stand.body[1], this.stand.body[2]);
+                    EulerAngle pose = new EulerAngle(this.stand.body[0], this.stand.body[1], this.stand.body[2]);
                     stand.setBodyPose(pose);
                 }
-                if ((this.stand.leftLeg[0] != 0) || (this.stand.leftLeg[1] != 0) || (this.stand.leftLeg[2] != 0)) {
+                if (this.stand.leftLeg[0] != 0 || this.stand.leftLeg[1] != 0 || this.stand.leftLeg[2] != 0) {
-                    final EulerAngle pose = new EulerAngle(this.stand.leftLeg[0], this.stand.leftLeg[1], this.stand.leftLeg[2]);
+                    EulerAngle pose = new EulerAngle(this.stand.leftLeg[0], this.stand.leftLeg[1], this.stand.leftLeg[2]);
                     stand.setLeftLegPose(pose);
                 }
-                if ((this.stand.rightLeg[0] != 0) || (this.stand.rightLeg[1] != 0) || (this.stand.rightLeg[2] != 0)) {
+                if (this.stand.rightLeg[0] != 0 || this.stand.rightLeg[1] != 0 || this.stand.rightLeg[2] != 0) {
-                    final EulerAngle pose = new EulerAngle(this.stand.rightLeg[0], this.stand.rightLeg[1], this.stand.rightLeg[2]);
+                    EulerAngle pose = new EulerAngle(this.stand.rightLeg[0], this.stand.rightLeg[1], this.stand.rightLeg[2]);
                     stand.setRightLegPose(pose);
                 }
-                if ((this.stand.leftArm[0] != 0) || (this.stand.leftArm[1] != 0) || (this.stand.leftArm[2] != 0)) {
+                if (this.stand.leftArm[0] != 0 || this.stand.leftArm[1] != 0 || this.stand.leftArm[2] != 0) {
-                    final EulerAngle pose = new EulerAngle(this.stand.leftArm[0], this.stand.leftArm[1], this.stand.leftArm[2]);
+                    EulerAngle pose = new EulerAngle(this.stand.leftArm[0], this.stand.leftArm[1], this.stand.leftArm[2]);
                     stand.setLeftArmPose(pose);
                 }
-                if ((this.stand.rightArm[0] != 0) || (this.stand.rightArm[1] != 0) || (this.stand.rightArm[2] != 0)) {
+                if (this.stand.rightArm[0] != 0 || this.stand.rightArm[1] != 0 || this.stand.rightArm[2] != 0) {
-                    final EulerAngle pose = new EulerAngle(this.stand.rightArm[0], this.stand.rightArm[1], this.stand.rightArm[2]);
+                    EulerAngle pose = new EulerAngle(this.stand.rightArm[0], this.stand.rightArm[1], this.stand.rightArm[2]);
                     stand.setRightArmPose(pose);
                 }
                 if (this.stand.invisible) {
@@ -644,7 +614,6 @@ public class EntityWrapper {
                 }
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
             case ENDERMITE: // NEW
             case BAT:
             case ENDER_DRAGON:
@@ -663,15 +632,14 @@ public class EntityWrapper {
             case CREEPER:
             case BLAZE:
             case SNOWMAN:
-            case IRON_GOLEM: {
+            case IRON_GOLEM:
                 restoreLiving((LivingEntity) entity);
                 return entity;
-            }
             // END LIVING //
         }
     }
-    
+
-    private byte getOrdinal(final Object[] list, final Object value) {
+    private byte getOrdinal(Object[] list, Object value) {
         for (byte i = 0; i < list.length; i++) {
             if (list[i].equals(value)) {
                 return i;

Bukkit/src/main/java/com/plotsquared/bukkit/object/schematic/StateWrapper.java

@@ -1,90 +1,110 @@
 package com.plotsquared.bukkit.object.schematic;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
-
-import org.bukkit.block.BlockState;
-import org.bukkit.enchantments.Enchantment;
-import org.bukkit.inventory.InventoryHolder;
-import org.bukkit.inventory.ItemStack;
-
 import com.intellectualcrafters.jnbt.ByteTag;
 import com.intellectualcrafters.jnbt.CompoundTag;
 import com.intellectualcrafters.jnbt.ListTag;
 import com.intellectualcrafters.jnbt.ShortTag;
 import com.intellectualcrafters.jnbt.Tag;
 import com.intellectualcrafters.plot.object.schematic.ItemType;
-import com.intellectualcrafters.plot.object.schematic.PlotItem;
 import com.intellectualcrafters.plot.util.MathMan;
-import com.intellectualcrafters.plot.util.SchematicHandler.Schematic;
+import com.plotsquared.bukkit.util.BukkitUtil;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import org.bukkit.World;
+import org.bukkit.block.Block;
+import org.bukkit.block.BlockState;
+import org.bukkit.enchantments.Enchantment;
+import org.bukkit.inventory.Inventory;
+import org.bukkit.inventory.InventoryHolder;
+import org.bukkit.inventory.ItemStack;
 
 public class StateWrapper {
-    
+
     public BlockState state = null;
     public CompoundTag tag = null;
-    
+
-    public StateWrapper(final BlockState state) {
+    public StateWrapper(BlockState state) {
         this.state = state;
     }
-    
+
-    public StateWrapper(final CompoundTag tag) {
+    public StateWrapper(CompoundTag tag) {
         this.tag = tag;
     }
-    
+
-    public boolean restoreTag(final short x, final short y, final short z, final Schematic schematic) {
+    public boolean restoreTag(String worldName, int x, int y, int z) {
-        if (tag == null) {
+        if (this.tag == null) {
             return false;
         }
-        final List<Tag> itemsTag = tag.getListTag("Items").getValue();
+        switch (tag.getString("id").toLowerCase()) {
-        final int length = itemsTag.size();
+            case "chest": {
-        final short[] ids = new short[length];
+                List<Tag> itemsTag = this.tag.getListTag("Items").getValue();
-        final byte[] datas = new byte[length];
+                int length = itemsTag.size();
-        final byte[] amounts = new byte[length];
+                short[] ids = new short[length];
-        for (int i = 0; i < length; i++) {
+                byte[] datas = new byte[length];
-            final Tag itemTag = itemsTag.get(i);
+                byte[] amounts = new byte[length];
-            final CompoundTag itemComp = (CompoundTag) itemTag;
+                byte[] slots = new byte[length];
-            short id = itemComp.getShort("id");
+                for (int i = 0; i < length; i++) {
-            String idStr = itemComp.getString("id");
+                    Tag itemTag = itemsTag.get(i);
-            if (idStr != null && !MathMan.isInteger(idStr)) {
+                    CompoundTag itemComp = (CompoundTag) itemTag;
-                idStr = idStr.split(":")[0].toLowerCase();
+                    short id = itemComp.getShort("id");
-                id = (short) ItemType.getId(idStr);
+                    String idStr = itemComp.getString("id");
+                    if (idStr != null && !MathMan.isInteger(idStr)) {
+                        idStr = idStr.split(":")[1].toLowerCase();
+                        id = (short) ItemType.getId(idStr);
+                    }
+                    ids[i] = id;
+                    datas[i] = (byte) itemComp.getShort("Damage");
+                    amounts[i] = itemComp.getByte("Count");
+                    slots[i] = itemComp.getByte("Slot");
+                }
+                World world = BukkitUtil.getWorld(worldName);
+                Block block = world.getBlockAt(x, y, z);
+                if (block == null) {
+                    return false;
+                }
+                BlockState state = block.getState();
+                if (state instanceof InventoryHolder) {
+                    InventoryHolder holder = (InventoryHolder) state;
+                    Inventory inv = holder.getInventory();
+                    for (int i = 0; i < ids.length; i++) {
+                        ItemStack item = new ItemStack(ids[i], amounts[i], datas[i]);
+                        inv.addItem(item);
+                    }
+                    state.update(true);
+                    return true;
+                } else {
+                }
             }
-            ids[i] = id;
-            datas[i] = (byte) itemComp.getShort("Damage");
-            amounts[i] = itemComp.getByte("Count");
         }
-        if (length != 0) {
+        return false;
-            schematic.addItem(new PlotItem(x, y, z, ids, datas, amounts));
-        }
-        return true;
     }
-    
+
     public CompoundTag getTag() {
-        if (tag != null) {
+        if (this.tag != null) {
-            return tag;
+            return this.tag;
         }
-        if (state instanceof InventoryHolder) {
+        if (this.state instanceof InventoryHolder) {
-            final InventoryHolder inv = (InventoryHolder) state;
+            InventoryHolder inv = (InventoryHolder) this.state;
-            final ItemStack[] contents = inv.getInventory().getContents();
+            ItemStack[] contents = inv.getInventory().getContents();
-            final Map<String, Tag> values = new HashMap<>();
+            Map<String, Tag> values = new HashMap<>();
             values.put("Items", new ListTag("Items", CompoundTag.class, serializeInventory(contents)));
             return new CompoundTag(values);
         }
         return null;
     }
-    
+
     public String getId() {
         return "Chest";
     }
-    
+
-    public List<CompoundTag> serializeInventory(final ItemStack[] items) {
+    public List<CompoundTag> serializeInventory(ItemStack[] items) {
-        final List<CompoundTag> tags = new ArrayList<>();
+        List<CompoundTag> tags = new ArrayList<>();
         for (int i = 0; i < items.length; ++i) {
             if (items[i] != null) {
-                final Map<String, Tag> tagData = serializeItem(items[i]);
+                Map<String, Tag> tagData = serializeItem(items[i]);
                 tagData.put("Slot", new ByteTag("Slot", (byte) i));
                 tags.add(new CompoundTag(tagData));
             }
@@ -103,21 +123,21 @@ public class StateWrapper {
         return data;
     }
     */
-    
+
-    public Map<String, Tag> serializeItem(final ItemStack item) {
+    public Map<String, Tag> serializeItem(ItemStack item) {
-        final Map<String, Tag> data = new HashMap<>();
+        Map<String, Tag> data = new HashMap<>();
         data.put("id", new ShortTag("id", (short) item.getTypeId()));
         data.put("Damage", new ShortTag("Damage", item.getDurability()));
         data.put("Count", new ByteTag("Count", (byte) item.getAmount()));
         if (!item.getEnchantments().isEmpty()) {
-            final List<CompoundTag> enchantmentList = new ArrayList<>();
+            List<CompoundTag> enchantmentList = new ArrayList<>();
-            for (final Entry<Enchantment, Integer> entry : item.getEnchantments().entrySet()) {
+            for (Entry<Enchantment, Integer> entry : item.getEnchantments().entrySet()) {
-                final Map<String, Tag> enchantment = new HashMap<>();
+                Map<String, Tag> enchantment = new HashMap<>();
                 enchantment.put("id", new ShortTag("id", (short) entry.getKey().getId()));
                 enchantment.put("lvl", new ShortTag("lvl", entry.getValue().shortValue()));
                 enchantmentList.add(new CompoundTag(enchantment));
             }
-            final Map<String, Tag> auxData = new HashMap<>();
+            Map<String, Tag> auxData = new HashMap<>();
             auxData.put("ench", new ListTag("ench", CompoundTag.class, enchantmentList));
             data.put("tag", new CompoundTag("tag", auxData));
         }

Bukkit/src/main/java/com/plotsquared/bukkit/titles/DefaultTitle.java

@@ -4,17 +4,14 @@ import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.intellectualcrafters.plot.util.AbstractTitle;
 import com.plotsquared.bukkit.object.BukkitPlayer;
 
-import java.lang.reflect.InvocationTargetException;
-
 public class DefaultTitle extends AbstractTitle {
 
     @Override
-    public void sendTitle(final PlotPlayer player, final String head, final String sub, final int in, final int delay, final int out) {
+    public void sendTitle(PlotPlayer player, String head, String sub, int in, int delay, int out) {
         try {
-            final DefaultTitleManager title = new DefaultTitleManager(head, sub, in, delay, out);
+            DefaultTitleManager title = new DefaultTitleManager(head, sub, in, delay, out);
             title.send(((BukkitPlayer) player).player);
-        } catch (ClassNotFoundException | InvocationTargetException | SecurityException | NoSuchMethodException | InstantiationException |
+        } catch (Throwable e) {
-                IllegalArgumentException | IllegalAccessException e) {
             AbstractTitle.TITLE_CLASS = new DefaultTitle_183();
             AbstractTitle.TITLE_CLASS.sendTitle(player, head, sub, in, delay, out);
         }

Bukkit/src/main/java/com/plotsquared/bukkit/titles/DefaultTitleManager.java

@@ -1,5 +1,6 @@
 package com.plotsquared.bukkit.titles;
 
+import com.plotsquared.bukkit.chat.Reflection;
 import org.bukkit.Bukkit;
 import org.bukkit.ChatColor;
 import org.bukkit.entity.Player;
@@ -13,7 +14,6 @@ import java.util.Map;
 /**
  * [ PlotSquared DefaultTitleManager by Maxim Van de Wynckel ]
  *
- * @version 1.1.0
  * @author Maxim Van de Wynckel
  *
  */
@@ -40,68 +40,59 @@ public class DefaultTitleManager {
     private boolean ticks = false;
 
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title
-     *            Title
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager(final String title) throws ClassNotFoundException {
+    public DefaultTitleManager(String title) throws ClassNotFoundException {
         this.title = title;
         loadClasses();
     }
 
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title text
-     *            Title text
+     * @param subtitle Subtitle text
-     * @param subtitle
-     *            Subtitle text
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager(final String title, final String subtitle) throws ClassNotFoundException {
+    public DefaultTitleManager(String title, String subtitle) throws ClassNotFoundException {
         this.title = title;
         this.subtitle = subtitle;
         loadClasses();
     }
 
     /**
-     * Copy 1.8 title
+     * Copy 1.8 title.
      *
-     * @param title
+     * @param title Title
-     *            Title
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager(final DefaultTitleManager title) throws ClassNotFoundException {
+    public DefaultTitleManager(DefaultTitleManager title) throws ClassNotFoundException {
         // Copy title
         this.title = title.title;
-        subtitle = title.subtitle;
+        this.subtitle = title.subtitle;
-        titleColor = title.titleColor;
+        this.titleColor = title.titleColor;
-        subtitleColor = title.subtitleColor;
+        this.subtitleColor = title.subtitleColor;
-        fadeInTime = title.fadeInTime;
+        this.fadeInTime = title.fadeInTime;
-        fadeOutTime = title.fadeOutTime;
+        this.fadeOutTime = title.fadeOutTime;
-        stayTime = title.stayTime;
+        this.stayTime = title.stayTime;
-        ticks = title.ticks;
+        this.ticks = title.ticks;
         loadClasses();
     }
 
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title text
-     *            Title text
+     * @param subtitle Subtitle text
-     * @param subtitle
+     * @param fadeInTime Fade in time
-     *            Subtitle text
+     * @param stayTime Stay on screen time
-     * @param fadeInTime
+     * @param fadeOutTime Fade out time
-     *            Fade in time
-     * @param stayTime
-     *            Stay on screen time
-     * @param fadeOutTime
-     *            Fade out time
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager(final String title, final String subtitle, final int fadeInTime, final int stayTime, final int fadeOutTime)
+    public DefaultTitleManager(String title, String subtitle, int fadeInTime, int stayTime, int fadeOutTime)
             throws ClassNotFoundException {
         this.title = title;
         this.subtitle = subtitle;
@@ -111,7 +102,7 @@ public class DefaultTitleManager {
         loadClasses();
     }
 
-    private static boolean equalsTypeArray(final Class<?>[] a, final Class<?>[] o) {
+    private static boolean equalsTypeArray(Class<?>[] a, Class<?>[] o) {
         if (a.length != o.length) {
             return false;
         }
@@ -124,225 +115,205 @@ public class DefaultTitleManager {
     }
 
     /**
-     * Load spigot and NMS classes
+     * Load spigot and NMS classes.
-     * @throws ClassNotFoundException
      */
-    private void loadClasses() throws ClassNotFoundException {
+    private void loadClasses() {
-        packetTitle = getNMSClass("PacketPlayOutTitle");
+        this.packetTitle = Reflection.getNMSClass("PacketPlayOutTitle");
-        packetActions = getNMSClass("EnumTitleAction");
+        this.packetActions = Reflection.getNMSClass("EnumTitleAction");
-        chatBaseComponent = getNMSClass("IChatBaseComponent");
+        this.chatBaseComponent = Reflection.getNMSClass("IChatBaseComponent");
-        nmsChatSerializer = getNMSClass("ChatSerializer");
+        this.nmsChatSerializer = Reflection.getNMSClass("ChatSerializer");
     }
 
     /**
-     * Get title text
+     * Get title text.
      *
      * @return Title text
      */
     public String getTitle() {
-        return title;
+        return this.title;
     }
 
     /**
-     * Set title text
+     * Set title text.
      *
-     * @param title
+     * @param title Title
-     *            Title
      */
-    public void setTitle(final String title) {
+    public void setTitle(String title) {
         this.title = title;
     }
 
     /**
-     * Get subtitle text
+     * Get subtitle text.
      *
      * @return Subtitle text
      */
     public String getSubtitle() {
-        return subtitle;
+        return this.subtitle;
     }
 
     /**
-     * Set subtitle text
+     * Set subtitle text.
      *
-     * @param subtitle
+     * @param subtitle Subtitle text
-     *            Subtitle text
      */
-    public void setSubtitle(final String subtitle) {
+    public void setSubtitle(String subtitle) {
         this.subtitle = subtitle;
     }
 
     /**
-     * Set the title color
+     * Set the title color.
      *
-     * @param color
+     * @param color Chat color
-     *            Chat color
      */
-    public void setTitleColor(final ChatColor color) {
+    public void setTitleColor(ChatColor color) {
-        titleColor = color;
+        this.titleColor = color;
     }
 
     /**
-     * Set the subtitle color
+     * Set the subtitle color.
      *
-     * @param color
+     * @param color Chat color
-     *            Chat color
      */
-    public void setSubtitleColor(final ChatColor color) {
+    public void setSubtitleColor(ChatColor color) {
-        subtitleColor = color;
+        this.subtitleColor = color;
     }
 
     /**
-     * Set title fade in time
+     * Set title fade in time.
      *
-     * @param time
+     * @param time Time
-     *            Time
      */
-    public void setFadeInTime(final int time) {
+    public void setFadeInTime(int time) {
-        fadeInTime = time;
+        this.fadeInTime = time;
     }
 
     /**
-     * Set title fade out time
+     * Set title fade out time.
      *
-     * @param time
+     * @param time Time
-     *            Time
      */
-    public void setFadeOutTime(final int time) {
+    public void setFadeOutTime(int time) {
-        fadeOutTime = time;
+        this.fadeOutTime = time;
     }
 
     /**
-     * Set title stay time
+     * Set title stay time.
      *
-     * @param time
+     * @param time Time
-     *            Time
      */
-    public void setStayTime(final int time) {
+    public void setStayTime(int time) {
-        stayTime = time;
+        this.stayTime = time;
     }
 
     /**
-     * Set timings to ticks
+     * Set timings to ticks.
      */
     public void setTimingsToTicks() {
-        ticks = true;
+        this.ticks = true;
     }
 
     /**
-     * Set timings to seconds
+     * Set timings to seconds.
      */
     public void setTimingsToSeconds() {
-        ticks = false;
+        this.ticks = false;
     }
 
     /**
-     * Send the title to a player
+     * Send the title to a player.
      *
-     * @param player
+     * @param player Player
-     *            Player
+     * @throws Exception
-     * @throws InvocationTargetException
-     * @throws IllegalArgumentException
-     * @throws IllegalAccessException
      */
-    public void send(final Player player)
+    public void send(Player player) throws Exception {
-            throws IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException, NoSuchMethodException,
+        if (this.packetTitle != null) {
-            SecurityException {
-        if (packetTitle != null) {
             // First reset previous settings
             resetTitle(player);
             // Send timings first
-            final Object handle = getHandle(player);
+            Object handle = getHandle(player);
-            final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+            Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-            final Object[] actions = packetActions.getEnumConstants();
+            Object[] actions = this.packetActions.getEnumConstants();
-            final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+            Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-            Object packet = packetTitle.getConstructor(packetActions, chatBaseComponent, Integer.TYPE, Integer.TYPE, Integer.TYPE)
+            Object packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent, Integer.TYPE, Integer.TYPE, Integer.TYPE)
-                    .newInstance(actions[2], null, fadeInTime * (ticks ? 1 : 20),
+                    .newInstance(actions[2], null, this.fadeInTime * (this.ticks ? 1 : 20),
-                            stayTime * (ticks ? 1 : 20), fadeOutTime * (ticks ? 1 : 20));
+                            this.stayTime * (this.ticks ? 1 : 20), this.fadeOutTime * (this.ticks ? 1 : 20));
             // Send if set
-            if (fadeInTime != -1 && fadeOutTime != -1 && stayTime != -1) {
+            if (this.fadeInTime != -1 && this.fadeOutTime != -1 && this.stayTime != -1) {
                 sendPacket.invoke(connection, packet);
             }
             // Send title
-            Object serialized = getMethod(nmsChatSerializer, "a", String.class).invoke(null,
+            Object serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
-                    "{text:\"" + ChatColor.translateAlternateColorCodes('&', title) + "\",color:" + titleColor.name().toLowerCase() + "}");
+                    "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.title) + "\",color:" + this.titleColor.name().toLowerCase() + "}");
-            packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[0], serialized);
+            packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[0], serialized);
             sendPacket.invoke(connection, packet);
-            if (!subtitle.isEmpty()) {
+            if (!this.subtitle.isEmpty()) {
                 // Send subtitle if present
-                serialized = getMethod(nmsChatSerializer, "a", String.class).invoke(null,
+                serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
-                        "{text:\"" + ChatColor.translateAlternateColorCodes('&', subtitle) + "\",color:" + subtitleColor.name().toLowerCase() + "}");
+                        "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.subtitle) + "\",color:" + this.subtitleColor.name()
-                packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[1], serialized);
+                                .toLowerCase() + "}");
+                packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[1], serialized);
                 sendPacket.invoke(connection, packet);
             }
         }
     }
 
     /**
-     * Broadcast the title to all players
+     * Broadcast the title to all players.
-     * @throws IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException, NoSuchMethodException,
+     *
-    SecurityException
+     * @throws Exception
      */
-    public void broadcast()
+    public void broadcast() throws Exception {
-            throws IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException, NoSuchMethodException,
+        for (Player p : Bukkit.getOnlinePlayers()) {
-            SecurityException {
-        for (final Player p : Bukkit.getOnlinePlayers()) {
             send(p);
         }
     }
 
     /**
-     * Clear the title
+     * Clear the title.
      *
-     * @param player
+     * @param player Player
-     *            Player
+     * @throws Exception
-     * @throws IllegalAccessException
-     * @throws IllegalArgumentException
      */
-    public void clearTitle(final Player player)
+    public void clearTitle(Player player) throws Exception {
-            throws IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException, NoSuchMethodException,
-            SecurityException {
         // Send timings first
-        final Object handle = getHandle(player);
+        Object handle = getHandle(player);
-        final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+        Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-        final Object[] actions = packetActions.getEnumConstants();
+        Object[] actions = this.packetActions.getEnumConstants();
-        final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+        Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-        final Object packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[3], null);
+        Object packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[3], null);
         sendPacket.invoke(connection, packet);
     }
 
     /**
-     * Reset the title settings
+     * Reset the title settings.
      *
-     * @param player
+     * @param player Player
-     *            Player
+     * @throws Exception
      */
-    public void resetTitle(final Player player)
+    public void resetTitle(Player player) throws Exception {
-            throws IllegalArgumentException, IllegalAccessException, InstantiationException, InvocationTargetException, NoSuchMethodException,
-            SecurityException {
         // Send timings first
-        final Object handle = getHandle(player);
+        Object handle = getHandle(player);
-        final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+        Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-        final Object[] actions = packetActions.getEnumConstants();
+        Object[] actions = this.packetActions.getEnumConstants();
-        final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+        Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-        final Object packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[4], null);
+        Object packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[4], null);
         sendPacket.invoke(connection, packet);
     }
 
-    private Class<?> getPrimitiveType(final Class<?> clazz) {
+    private Class<?> getPrimitiveType(Class<?> clazz) {
         return CORRESPONDING_TYPES.containsKey(clazz) ? CORRESPONDING_TYPES.get(clazz) : clazz;
     }
 
-    private Class<?>[] toPrimitiveTypeArray(final Class<?>[] classes) {
+    private Class<?>[] toPrimitiveTypeArray(Class<?>[] classes) {
-        final int a = classes != null ? classes.length : 0;
+        int a = classes != null ? classes.length : 0;
-        final Class<?>[] types = new Class<?>[a];
+        Class<?>[] types = new Class<?>[a];
         for (int i = 0; i < a; i++) {
             types[i] = getPrimitiveType(classes[i]);
         }
         return types;
     }
 
-    private Object getHandle(final Object obj) {
+    private Object getHandle(Object obj) {
         try {
             return getMethod("getHandle", obj.getClass()).invoke(obj);
         } catch (IllegalAccessException e) {
@@ -357,10 +328,10 @@ public class DefaultTitleManager {
         }
     }
 
-    private Method getMethod(final String name, final Class<?> clazz, final Class<?>... paramTypes) {
+    private Method getMethod(String name, Class<?> clazz, Class<?>... paramTypes) {
-        final Class<?>[] t = toPrimitiveTypeArray(paramTypes);
+        Class<?>[] t = toPrimitiveTypeArray(paramTypes);
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
-            final Class<?>[] types = toPrimitiveTypeArray(m.getParameterTypes());
+            Class<?>[] types = toPrimitiveTypeArray(m.getParameterTypes());
             if (m.getName().equals(name) && equalsTypeArray(types, t)) {
                 return m;
             }
@@ -368,19 +339,9 @@ public class DefaultTitleManager {
         return null;
     }
 
-    private String getVersion() {
+    private Field getField(Class<?> clazz, String name) {
-        final String name = Bukkit.getServer().getClass().getPackage().getName();
-        return name.substring(name.lastIndexOf('.') + 1) + ".";
-    }
-
-    private Class<?> getNMSClass(final String className) throws ClassNotFoundException {
-        final String fullName = "net.minecraft.server." + getVersion() + className;
-        return Class.forName(fullName);
-    }
-
-    private Field getField(final Class<?> clazz, final String name) {
         try {
-            final Field field = clazz.getDeclaredField(name);
+            Field field = clazz.getDeclaredField(name);
             field.setAccessible(true);
             return field;
         } catch (NoSuchFieldException e) {
@@ -392,8 +353,8 @@ public class DefaultTitleManager {
         }
     }
 
-    private Method getMethod(final Class<?> clazz, final String name, final Class<?>... args) {
+    private Method getMethod(Class<?> clazz, String name, Class<?>... args) {
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
             if (m.getName().equals(name) && (args.length == 0 || ClassListEqual(args, m.getParameterTypes()))) {
                 m.setAccessible(true);
                 return m;
@@ -402,7 +363,7 @@ public class DefaultTitleManager {
         return null;
     }
 
-    private boolean ClassListEqual(final Class<?>[] l1, final Class<?>[] l2) {
+    private boolean ClassListEqual(Class<?>[] l1, Class<?>[] l2) {
         if (l1.length != l2.length) {
             return false;
         }

Bukkit/src/main/java/com/plotsquared/bukkit/titles/DefaultTitleManager_183.java

@@ -1,11 +1,11 @@
 package com.plotsquared.bukkit.titles;
 
+import com.plotsquared.bukkit.chat.Reflection;
 import org.bukkit.Bukkit;
 import org.bukkit.ChatColor;
 import org.bukkit.entity.Player;
 
 import java.lang.reflect.Field;
-import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.HashMap;
 import java.util.Map;
@@ -18,6 +18,8 @@ import java.util.Map;
  *
  */
 public class DefaultTitleManager_183 {
+
+    private static final Map<Class<?>, Class<?>> CORRESPONDING_TYPES = new HashMap<>();
     /* Title packet */
     private Class<?> packetTitle;
     /* Title packet actions ENUM */
@@ -36,8 +38,7 @@ public class DefaultTitleManager_183 {
     private int stayTime = -1;
     private int fadeOutTime = -1;
     private boolean ticks = false;
-    private static final Map<Class<?>, Class<?>> CORRESPONDING_TYPES = new HashMap<>();
+
-    
     /**
      * Create a new 1.8 title
      *
@@ -45,62 +46,54 @@ public class DefaultTitleManager_183 {
      *            Title
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager_183(final String title) throws ClassNotFoundException {
+    public DefaultTitleManager_183(String title) throws ClassNotFoundException {
         this.title = title;
         loadClasses();
     }
-    
+
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title text
-     *            Title text
+     * @param subtitle Subtitle text
-     * @param subtitle
-     *            Subtitle text
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager_183(final String title, final String subtitle) throws ClassNotFoundException {
+    public DefaultTitleManager_183(String title, String subtitle) throws ClassNotFoundException {
         this.title = title;
         this.subtitle = subtitle;
         loadClasses();
     }
-    
+
     /**
-     * Copy 1.8 title
+     * Copy 1.8 title.
      *
-     * @param title
+     * @param title Title
-     *            Title
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager_183(final DefaultTitleManager_183 title) throws ClassNotFoundException {
+    public DefaultTitleManager_183(DefaultTitleManager_183 title) throws ClassNotFoundException {
         // Copy title
         this.title = title.title;
-        subtitle = title.subtitle;
+        this.subtitle = title.subtitle;
-        titleColor = title.titleColor;
+        this.titleColor = title.titleColor;
-        subtitleColor = title.subtitleColor;
+        this.subtitleColor = title.subtitleColor;
-        fadeInTime = title.fadeInTime;
+        this.fadeInTime = title.fadeInTime;
-        fadeOutTime = title.fadeOutTime;
+        this.fadeOutTime = title.fadeOutTime;
-        stayTime = title.stayTime;
+        this.stayTime = title.stayTime;
-        ticks = title.ticks;
+        this.ticks = title.ticks;
         loadClasses();
     }
-    
+
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title text
-     *            Title text
+     * @param subtitle Subtitle text
-     * @param subtitle
+     * @param fadeInTime Fade in time
-     *            Subtitle text
+     * @param stayTime Stay on screen time
-     * @param fadeInTime
+     * @param fadeOutTime Fade out time
-     *            Fade in time
-     * @param stayTime
-     *            Stay on screen time
-     * @param fadeOutTime
-     *            Fade out time
      * @throws ClassNotFoundException
      */
-    public DefaultTitleManager_183(final String title, final String subtitle, final int fadeInTime, final int stayTime, final int fadeOutTime) throws ClassNotFoundException {
+    public DefaultTitleManager_183(String title, String subtitle, int fadeInTime, int stayTime, int fadeOutTime) throws ClassNotFoundException {
         this.title = title;
         this.subtitle = subtitle;
         this.fadeInTime = fadeInTime;
@@ -108,224 +101,8 @@ public class DefaultTitleManager_183 {
         this.fadeOutTime = fadeOutTime;
         loadClasses();
     }
-    
+
-    /**
+    private static boolean equalsTypeArray(Class<?>[] a, Class<?>[] o) {
-     * Load spigot and NMS classes
-     * @throws ClassNotFoundException
-     */
-    private void loadClasses() throws ClassNotFoundException {
-        packetTitle = getNMSClass("PacketPlayOutTitle");
-        chatBaseComponent = getNMSClass("IChatBaseComponent");
-        packetActions = getNMSClass("PacketPlayOutTitle$EnumTitleAction");
-        nmsChatSerializer = getNMSClass("IChatBaseComponent$ChatSerializer");
-        
-    }
-    
-    /**
-     * Set title text
-     *
-     * @param title
-     *            Title
-     */
-    public void setTitle(final String title) {
-        this.title = title;
-    }
-    
-    /**
-     * Get title text
-     *
-     * @return Title text
-     */
-    public String getTitle() {
-        return title;
-    }
-    
-    /**
-     * Set subtitle text
-     *
-     * @param subtitle
-     *            Subtitle text
-     */
-    public void setSubtitle(final String subtitle) {
-        this.subtitle = subtitle;
-    }
-    
-    /**
-     * Get subtitle text
-     *
-     * @return Subtitle text
-     */
-    public String getSubtitle() {
-        return subtitle;
-    }
-    
-    /**
-     * Set the title color
-     *
-     * @param color
-     *            Chat color
-     */
-    public void setTitleColor(final ChatColor color) {
-        titleColor = color;
-    }
-    
-    /**
-     * Set the subtitle color
-     *
-     * @param color
-     *            Chat color
-     */
-    public void setSubtitleColor(final ChatColor color) {
-        subtitleColor = color;
-    }
-    
-    /**
-     * Set title fade in time
-     *
-     * @param time
-     *            Time
-     */
-    public void setFadeInTime(final int time) {
-        fadeInTime = time;
-    }
-    
-    /**
-     * Set title fade out time
-     *
-     * @param time
-     *            Time
-     */
-    public void setFadeOutTime(final int time) {
-        fadeOutTime = time;
-    }
-    
-    /**
-     * Set title stay time
-     *
-     * @param time
-     *            Time
-     */
-    public void setStayTime(final int time) {
-        stayTime = time;
-    }
-    
-    /**
-     * Set timings to ticks
-     */
-    public void setTimingsToTicks() {
-        ticks = true;
-    }
-    
-    /**
-     * Set timings to seconds
-     */
-    public void setTimingsToSeconds() {
-        ticks = false;
-    }
-    
-    /**
-     * Send the title to a player
-     *
-     * @param player
-     *            Player
-     * @throws InvocationTargetException
-     * @throws IllegalArgumentException
-     * @throws IllegalAccessException
-     */
-    public void send(final Player player) throws Exception {
-        if (packetTitle != null) {
-            // First reset previous settings
-            resetTitle(player);
-            // Send timings first
-            final Object handle = getHandle(player);
-            final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-            final Object[] actions = packetActions.getEnumConstants();
-            final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-            Object packet = packetTitle.getConstructor(packetActions, chatBaseComponent, Integer.TYPE, Integer.TYPE, Integer.TYPE).newInstance(actions[2], null, fadeInTime * (ticks ? 1 : 20),
-            stayTime * (ticks ? 1 : 20), fadeOutTime * (ticks ? 1 : 20));
-            // Send if set
-            if ((fadeInTime != -1) && (fadeOutTime != -1) && (stayTime != -1)) {
-                sendPacket.invoke(connection, packet);
-            }
-            // Send title
-            Object serialized = getMethod(nmsChatSerializer, "a", String.class).invoke(null,
-            "{text:\"" + ChatColor.translateAlternateColorCodes('&', title) + "\",color:" + titleColor.name().toLowerCase() + "}");
-            packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[0], serialized);
-            sendPacket.invoke(connection, packet);
-            if (!subtitle.isEmpty()) {
-                // Send subtitle if present
-                serialized = getMethod(nmsChatSerializer, "a", String.class).invoke(null,
-                "{text:\"" + ChatColor.translateAlternateColorCodes('&', subtitle) + "\",color:" + subtitleColor.name().toLowerCase() + "}");
-                packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[1], serialized);
-                sendPacket.invoke(connection, packet);
-            }
-        }
-    }
-    
-    /**
-     * Broadcast the title to all players
-     * @throws Exception
-     */
-    public void broadcast() throws Exception {
-        for (final Player p : Bukkit.getOnlinePlayers()) {
-            send(p);
-        }
-    }
-    
-    /**
-     * Clear the title
-     *
-     * @param player
-     *            Player
-     * @throws IllegalAccessException
-     * @throws IllegalArgumentException
-     */
-    public void clearTitle(final Player player) throws Exception {
-        // Send timings first
-        final Object handle = getHandle(player);
-        final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-        final Object[] actions = packetActions.getEnumConstants();
-        final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-        final Object packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[3], null);
-        sendPacket.invoke(connection, packet);
-    }
-    
-    /**
-     * Reset the title settings
-     *
-     * @param player
-     *            Player
-     * @throws SecurityException
-     * @throws NoSuchMethodException
-     * @throws InvocationTargetException
-     * @throws IllegalArgumentException
-     * @throws IllegalAccessException
-     * @throws InstantiationException
-     */
-    public void resetTitle(final Player player) throws Exception {
-        // Send timings first
-        final Object handle = getHandle(player);
-        final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-        final Object[] actions = packetActions.getEnumConstants();
-        final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-        final Object packet = packetTitle.getConstructor(packetActions, chatBaseComponent).newInstance(actions[4], null);
-        sendPacket.invoke(connection, packet);
-    }
-    
-    private Class<?> getPrimitiveType(final Class<?> clazz) {
-        return CORRESPONDING_TYPES.containsKey(clazz) ? CORRESPONDING_TYPES.get(clazz) : clazz;
-    }
-    
-    private Class<?>[] toPrimitiveTypeArray(final Class<?>[] classes) {
-        final int a = classes != null ? classes.length : 0;
-        final Class<?>[] types = new Class<?>[a];
-        for (int i = 0; i < a; i++) {
-            types[i] = getPrimitiveType(classes[i]);
-        }
-        return types;
-    }
-    
-    private static boolean equalsTypeArray(final Class<?>[] a, final Class<?>[] o) {
         if (a.length != o.length) {
             return false;
         }
@@ -336,51 +113,242 @@ public class DefaultTitleManager_183 {
         }
         return true;
     }
-    
+
-    private Object getHandle(final Object obj) {
+    /**
+     * Load spigot and NMS classes.
+     */
+    private void loadClasses() {
+        this.packetTitle = Reflection.getNMSClass("PacketPlayOutTitle");
+        this.chatBaseComponent = Reflection.getNMSClass("IChatBaseComponent");
+        this.packetActions = Reflection.getNMSClass("PacketPlayOutTitle$EnumTitleAction");
+        this.nmsChatSerializer = Reflection.getNMSClass("IChatBaseComponent$ChatSerializer");
+
+    }
+
+    /**
+     * Get title text.
+     *
+     * @return Title text
+     */
+    public String getTitle() {
+        return this.title;
+    }
+
+    /**
+     * Set title text.
+     *
+     * @param title Title
+     */
+    public void setTitle(String title) {
+        this.title = title;
+    }
+
+    /**
+     * Get subtitle text.
+     *
+     * @return Subtitle text
+     */
+    public String getSubtitle() {
+        return this.subtitle;
+    }
+
+    /**
+     * Set subtitle text.
+     *
+     * @param subtitle Subtitle text
+     */
+    public void setSubtitle(String subtitle) {
+        this.subtitle = subtitle;
+    }
+
+    /**
+     * Set the title color.
+     *
+     * @param color Chat color
+     */
+    public void setTitleColor(ChatColor color) {
+        this.titleColor = color;
+    }
+
+    /**
+     * Set the subtitle color.
+     *
+     * @param color Chat color
+     */
+    public void setSubtitleColor(ChatColor color) {
+        this.subtitleColor = color;
+    }
+
+    /**
+     * Set title fade in time.
+     *
+     * @param time
+     *            Time
+     */
+    public void setFadeInTime(int time) {
+        this.fadeInTime = time;
+    }
+
+    /**
+     * Set title fade out time.
+     *
+     * @param time Time
+     */
+    public void setFadeOutTime(int time) {
+        this.fadeOutTime = time;
+    }
+
+    /**
+     * Set title stay time.
+     *
+     * @param time Time
+     */
+    public void setStayTime(int time) {
+        this.stayTime = time;
+    }
+
+    /**
+     * Set timings to ticks.
+     */
+    public void setTimingsToTicks() {
+        this.ticks = true;
+    }
+
+    /**
+     * Set timings to seconds.
+     */
+    public void setTimingsToSeconds() {
+        this.ticks = false;
+    }
+
+    /**
+     * Send the title to a player.
+     *
+     * @param player Player
+     * @throws Exception
+     */
+    public void send(Player player) throws Exception {
+        if (this.packetTitle != null) {
+            // First reset previous settings
+            resetTitle(player);
+            // Send timings first
+            Object handle = getHandle(player);
+            Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+            Object[] actions = this.packetActions.getEnumConstants();
+            Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+            Object packet = this.packetTitle
+                    .getConstructor(this.packetActions, this.chatBaseComponent, Integer.TYPE, Integer.TYPE, Integer.TYPE)
+                    .newInstance(actions[2], null,
+                            this.fadeInTime * (this.ticks ? 1 : 20),
+                            this.stayTime * (this.ticks ? 1 : 20), this.fadeOutTime * (this.ticks ? 1 : 20));
+            // Send if set
+            if ((this.fadeInTime != -1) && (this.fadeOutTime != -1) && (this.stayTime != -1)) {
+                sendPacket.invoke(connection, packet);
+            }
+            // Send title
+            Object serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
+                    "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.title) + "\",color:" + this.titleColor.name().toLowerCase() + "}");
+            packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[0], serialized);
+            sendPacket.invoke(connection, packet);
+            if (!this.subtitle.isEmpty()) {
+                // Send subtitle if present
+                serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
+                        "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.subtitle) + "\",color:" + this.subtitleColor.name()
+                                .toLowerCase() + "}");
+                packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[1], serialized);
+                sendPacket.invoke(connection, packet);
+            }
+        }
+    }
+
+    /**
+     * Broadcast the title to all players.
+     * @throws Exception
+     */
+    public void broadcast() throws Exception {
+        for (Player p : Bukkit.getOnlinePlayers()) {
+            send(p);
+        }
+    }
+
+    /**
+     * Clear the title.
+     *
+     * @param player Player
+     * @throws Exception
+     */
+    public void clearTitle(Player player) throws Exception {
+        // Send timings first
+        Object handle = getHandle(player);
+        Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+        Object[] actions = this.packetActions.getEnumConstants();
+        Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+        Object packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[3], null);
+        sendPacket.invoke(connection, packet);
+    }
+
+    /**
+     * Reset the title settings.
+     *
+     * @param player Player
+     * @throws Exception
+     */
+    public void resetTitle(Player player) throws Exception {
+        // Send timings first
+        Object handle = getHandle(player);
+        Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+        Object[] actions = this.packetActions.getEnumConstants();
+        Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+        Object packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[4], null);
+        sendPacket.invoke(connection, packet);
+    }
+
+    private Class<?> getPrimitiveType(Class<?> clazz) {
+        return CORRESPONDING_TYPES.containsKey(clazz) ? CORRESPONDING_TYPES.get(clazz) : clazz;
+    }
+
+    private Class<?>[] toPrimitiveTypeArray(Class<?>[] classes) {
+        int a = classes != null ? classes.length : 0;
+        Class<?>[] types = new Class<?>[a];
+        for (int i = 0; i < a; i++) {
+            types[i] = getPrimitiveType(classes[i]);
+        }
+        return types;
+    }
+
+    private Object getHandle(Object obj) {
         try {
             return getMethod("getHandle", obj.getClass()).invoke(obj);
-        } catch (final Exception e) {
+        } catch (Exception e) {
             e.printStackTrace();
             return null;
         }
     }
-    
+
-    private Method getMethod(final String name, final Class<?> clazz, final Class<?>... paramTypes) {
+    private Method getMethod(String name, Class<?> clazz, Class<?>... paramTypes) {
-        final Class<?>[] t = toPrimitiveTypeArray(paramTypes);
+        Class<?>[] t = toPrimitiveTypeArray(paramTypes);
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
-            final Class<?>[] types = toPrimitiveTypeArray(m.getParameterTypes());
+            Class<?>[] types = toPrimitiveTypeArray(m.getParameterTypes());
             if (m.getName().equals(name) && equalsTypeArray(types, t)) {
                 return m;
             }
         }
         return null;
     }
-    
+
-    private String getVersion() {
+    private Field getField(Class<?> clazz, String name) {
-        final String name = Bukkit.getServer().getClass().getPackage().getName();
-        final String version = name.substring(name.lastIndexOf('.') + 1) + ".";
-        return version;
-    }
-    
-    private Class<?> getNMSClass(final String className) throws ClassNotFoundException {
-        final String fullName = "net.minecraft.server." + getVersion() + className;
-        return Class.forName(fullName);
-    }
-    
-    private Field getField(final Class<?> clazz, final String name) {
         try {
-            final Field field = clazz.getDeclaredField(name);
+            Field field = clazz.getDeclaredField(name);
             field.setAccessible(true);
             return field;
-        } catch (final Exception e) {
+        } catch (NoSuchFieldException | SecurityException e) {
             e.printStackTrace();
             return null;
         }
     }
-    
+
-    private Method getMethod(final Class<?> clazz, final String name, final Class<?>... args) {
+    private Method getMethod(Class<?> clazz, String name, Class<?>... args) {
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
             if (m.getName().equals(name) && ((args.length == 0) || ClassListEqual(args, m.getParameterTypes()))) {
                 m.setAccessible(true);
                 return m;
@@ -388,8 +356,8 @@ public class DefaultTitleManager_183 {
         }
         return null;
     }
-    
+
-    private boolean ClassListEqual(final Class<?>[] l1, final Class<?>[] l2) {
+    private boolean ClassListEqual(Class<?>[] l1, Class<?>[] l2) {
         if (l1.length != l2.length) {
             return false;
         }

Bukkit/src/main/java/com/plotsquared/bukkit/titles/DefaultTitle_183.java

@@ -5,12 +5,13 @@ import com.intellectualcrafters.plot.util.AbstractTitle;
 import com.plotsquared.bukkit.object.BukkitPlayer;
 
 public class DefaultTitle_183 extends AbstractTitle {
+
     @Override
-    public void sendTitle(final PlotPlayer player, final String head, final String sub, final int in, final int delay, final int out) {
+    public void sendTitle(PlotPlayer player, String head, String sub, int in, int delay, int out) {
         try {
-            final DefaultTitleManager_183 title = new DefaultTitleManager_183(head, sub, in, delay, out);
+            DefaultTitleManager_183 title = new DefaultTitleManager_183(head, sub, in, delay, out);
             title.send(((BukkitPlayer) player).player);
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             AbstractTitle.TITLE_CLASS = new HackTitle();
             AbstractTitle.TITLE_CLASS.sendTitle(player, head, sub, in, delay, out);
         }

Bukkit/src/main/java/com/plotsquared/bukkit/titles/DefaultTitle_19.java

@@ -0,0 +1,27 @@
+package com.plotsquared.bukkit.titles;
+
+import com.intellectualcrafters.plot.object.PlotPlayer;
+import com.intellectualcrafters.plot.util.AbstractTitle;
+import com.intellectualcrafters.plot.util.TaskManager;
+import com.plotsquared.bukkit.object.BukkitPlayer;
+import org.bukkit.entity.Player;
+
+public class DefaultTitle_19 extends AbstractTitle {
+
+    @Override
+    public void sendTitle(PlotPlayer player, String head, String sub, int in, int delay, int out) {
+        try {
+            final Player playerObj = ((BukkitPlayer) player).player;
+            playerObj.sendTitle(head, sub);
+            TaskManager.runTaskLater(new Runnable() {
+                @Override
+                public void run() {
+                    playerObj.sendTitle("", "");
+                }
+            }, delay * 20);
+        } catch (Throwable e) {
+            AbstractTitle.TITLE_CLASS = new DefaultTitle();
+            AbstractTitle.TITLE_CLASS.sendTitle(player, head, sub, in, delay, out);
+        }
+    }
+}

Bukkit/src/main/java/com/plotsquared/bukkit/titles/HackTitle.java

@@ -7,12 +7,13 @@ import com.intellectualcrafters.plot.util.AbstractTitle;
 import com.plotsquared.bukkit.object.BukkitPlayer;
 
 public class HackTitle extends AbstractTitle {
+
     @Override
-    public void sendTitle(final PlotPlayer player, final String head, final String sub, final int in, final int delay, final int out) {
+    public void sendTitle(PlotPlayer player, String head, String sub, int in, int delay, int out) {
         try {
-            final HackTitleManager title = new HackTitleManager(head, sub, in, delay, out);
+            HackTitleManager title = new HackTitleManager(head, sub, in, delay, out);
             title.send(((BukkitPlayer) player).player);
-        } catch (Exception e) {
+        } catch (Throwable e) {
             PS.debug("&cYour server version does not support titles!");
             Settings.TITLES = false;
             AbstractTitle.TITLE_CLASS = null;

Bukkit/src/main/java/com/plotsquared/bukkit/titles/HackTitleManager.java

@@ -1,5 +1,6 @@
 package com.plotsquared.bukkit.titles;
 
+import com.plotsquared.bukkit.chat.Reflection;
 import org.bukkit.Bukkit;
 import org.bukkit.ChatColor;
 import org.bukkit.entity.Player;
@@ -11,12 +12,14 @@ import java.util.HashMap;
 import java.util.Map;
 
 /**
- * Minecraft 1.8 Title
+ * Minecraft 1.8 Title.
  *
  * @version 1.0.4
  * @author Maxim Van de Wynckel
  */
 public class HackTitleManager {
+
+    private static final Map<Class<?>, Class<?>> CORRESPONDING_TYPES = new HashMap<>();
     /* Title packet */
     private Class<?> packetTitle;
     /* Title packet actions ENUM */
@@ -29,76 +32,66 @@ public class HackTitleManager {
     /* Subtitle text and color */
     private String subtitle = "";
     private ChatColor subtitleColor = ChatColor.WHITE;
-    /* Title timings */
+    /* Title timings. */
     private int fadeInTime = -1;
     private int stayTime = -1;
     private int fadeOutTime = -1;
     private boolean ticks = false;
-    private static final Map<Class<?>, Class<?>> CORRESPONDING_TYPES = new HashMap<>();
+
-    
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title
-     *            Title
+     * @throws ClassNotFoundException NMS Error.
-     * @throws ClassNotFoundException
      */
-    public HackTitleManager(final String title) throws ClassNotFoundException {
+    public HackTitleManager(String title) throws ClassNotFoundException {
         this.title = title;
         loadClasses();
     }
-    
+
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title text
-     *            Title text
+     * @param subtitle Subtitle text
-     * @param subtitle
+     * @throws ClassNotFoundException NMS Error
-     *            Subtitle text
-     * @throws ClassNotFoundException
      */
-    public HackTitleManager(final String title, final String subtitle) throws ClassNotFoundException {
+    public HackTitleManager(String title, String subtitle) throws ClassNotFoundException {
         this.title = title;
         this.subtitle = subtitle;
         loadClasses();
     }
-    
+
     /**
-     * Copy 1.8 title
+     * Copy 1.8 title.
      *
-     * @param title
+     * @param title Title
-     *            Title
+     * @throws ClassNotFoundException NMS Error
-     * @throws ClassNotFoundException
      */
-    public HackTitleManager(final HackTitleManager title) throws ClassNotFoundException {
+    public HackTitleManager(HackTitleManager title) throws ClassNotFoundException {
         // Copy title
         this.title = title.title;
-        subtitle = title.subtitle;
+        this.subtitle = title.subtitle;
-        titleColor = title.titleColor;
+        this.titleColor = title.titleColor;
-        subtitleColor = title.subtitleColor;
+        this.subtitleColor = title.subtitleColor;
-        fadeInTime = title.fadeInTime;
+        this.fadeInTime = title.fadeInTime;
-        fadeOutTime = title.fadeOutTime;
+        this.fadeOutTime = title.fadeOutTime;
-        stayTime = title.stayTime;
+        this.stayTime = title.stayTime;
-        ticks = title.ticks;
+        this.ticks = title.ticks;
         loadClasses();
     }
-    
+
     /**
-     * Create a new 1.8 title
+     * Create a new 1.8 title.
      *
-     * @param title
+     * @param title Title text
-     *            Title text
+     * @param subtitle Subtitle text
-     * @param subtitle
+     * @param fadeInTime Fade in time
-     *            Subtitle text
+     * @param stayTime Stay on screen time
-     * @param fadeInTime
+     * @param fadeOutTime Fade out time
-     *            Fade in time
+     * @throws ClassNotFoundException NMS error
-     * @param stayTime
-     *            Stay on screen time
-     * @param fadeOutTime
-     *            Fade out time
-     * @throws ClassNotFoundException
      */
-    public HackTitleManager(final String title, final String subtitle, final int fadeInTime, final int stayTime, final int fadeOutTime) throws ClassNotFoundException {
+    public HackTitleManager(String title, String subtitle, int fadeInTime, int stayTime, int fadeOutTime) throws ClassNotFoundException {
         this.title = title;
         this.subtitle = subtitle;
         this.fadeInTime = fadeInTime;
@@ -106,265 +99,8 @@ public class HackTitleManager {
         this.fadeOutTime = fadeOutTime;
         loadClasses();
     }
-    
+
-    /**
+    private static boolean equalsTypeArray(Class<?>[] a, Class<?>[] o) {
-     * Load spigot and NMS classes
-     * @throws ClassNotFoundException
-     */
-    private void loadClasses() throws ClassNotFoundException {
-        packetTitle = getClass("org.spigotmc.ProtocolInjector$PacketTitle");
-        packetActions = getClass("org.spigotmc.ProtocolInjector$PacketTitle$Action");
-        nmsChatSerializer = getNMSClass("ChatSerializer");
-    }
-    
-    /**
-     * Set title text
-     *
-     * @param title
-     *            Title
-     */
-    public void setTitle(final String title) {
-        this.title = title;
-    }
-    
-    /**
-     * Get title text
-     *
-     * @return Title text
-     */
-    public String getTitle() {
-        return title;
-    }
-    
-    /**
-     * Set subtitle text
-     *
-     * @param subtitle
-     *            Subtitle text
-     */
-    public void setSubtitle(final String subtitle) {
-        this.subtitle = subtitle;
-    }
-    
-    /**
-     * Get subtitle text
-     *
-     * @return Subtitle text
-     */
-    public String getSubtitle() {
-        return subtitle;
-    }
-    
-    /**
-     * Set the title color
-     *
-     * @param color
-     *            Chat color
-     */
-    public void setTitleColor(final ChatColor color) {
-        titleColor = color;
-    }
-    
-    /**
-     * Set the subtitle color
-     *
-     * @param color
-     *            Chat color
-     */
-    public void setSubtitleColor(final ChatColor color) {
-        subtitleColor = color;
-    }
-    
-    /**
-     * Set title fade in time
-     *
-     * @param time
-     *            Time
-     */
-    public void setFadeInTime(final int time) {
-        fadeInTime = time;
-    }
-    
-    /**
-     * Set title fade out time
-     *
-     * @param time
-     *            Time
-     */
-    public void setFadeOutTime(final int time) {
-        fadeOutTime = time;
-    }
-    
-    /**
-     * Set title stay time
-     *
-     * @param time
-     *            Time
-     */
-    public void setStayTime(final int time) {
-        stayTime = time;
-    }
-    
-    /**
-     * Set timings to ticks
-     */
-    public void setTimingsToTicks() {
-        ticks = true;
-    }
-    
-    /**
-     * Set timings to seconds
-     */
-    public void setTimingsToSeconds() {
-        ticks = false;
-    }
-    
-    /**
-     * Send the title to a player
-     *
-     * @param player
-     *            Player
-     */
-    public void send(final Player player) throws Exception {
-        if ((getProtocolVersion(player) >= 47) && isSpigot() && (packetTitle != null)) {
-            // First reset previous settings
-            resetTitle(player);
-            // Send timings first
-            final Object handle = getHandle(player);
-            final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-            final Object[] actions = packetActions.getEnumConstants();
-            final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-            Object packet = packetTitle.getConstructor(packetActions, Integer.TYPE, Integer.TYPE, Integer.TYPE).newInstance(actions[2], fadeInTime * (ticks ? 1 : 20), stayTime * (ticks ? 1 : 20),
-            fadeOutTime * (ticks ? 1 : 20));
-            // Send if set
-            if ((fadeInTime != -1) && (fadeOutTime != -1) && (stayTime != -1)) {
-                sendPacket.invoke(connection, packet);
-            }
-            // Send title
-            Object serialized = getMethod(nmsChatSerializer, "a", String.class).invoke(null,
-            "{text:\"" + ChatColor.translateAlternateColorCodes('&', title) + "\",color:" + titleColor.name().toLowerCase() + "}");
-            packet = packetTitle.getConstructor(packetActions, getNMSClass("IChatBaseComponent")).newInstance(actions[0], serialized);
-            sendPacket.invoke(connection, packet);
-            if (!subtitle.isEmpty()) {
-                // Send subtitle if present
-                serialized = getMethod(nmsChatSerializer, "a", String.class).invoke(null,
-                "{text:\"" + ChatColor.translateAlternateColorCodes('&', subtitle) + "\",color:" + subtitleColor.name().toLowerCase() + "}");
-                packet = packetTitle.getConstructor(packetActions, getNMSClass("IChatBaseComponent")).newInstance(actions[1], serialized);
-                sendPacket.invoke(connection, packet);
-            }
-        }
-    }
-    
-    /**
-     * Broadcast the title to all players
-     */
-    public void broadcast() throws Exception {
-        for (final Player p : Bukkit.getOnlinePlayers()) {
-            send(p);
-        }
-    }
-    
-    /**
-     * Clear the title
-     *
-     * @param player
-     *            Player
-     * @throws Exception
-     */
-    public void clearTitle(final Player player) throws Exception {
-        if ((getProtocolVersion(player) >= 47) && isSpigot()) {
-            // Send timings first
-            final Object handle = getHandle(player);
-            final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-            final Object[] actions = packetActions.getEnumConstants();
-            final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-            final Object packet = packetTitle.getConstructor(packetActions).newInstance(actions[3]);
-            sendPacket.invoke(connection, packet);
-        }
-    }
-    
-    /**
-     * Reset the title settings
-     *
-     * @param player
-     *            Player
-     * @throws Exception
-     */
-    public void resetTitle(final Player player) throws Exception {
-        if ((getProtocolVersion(player) >= 47) && isSpigot()) {
-            // Send timings first
-            final Object handle = getHandle(player);
-            final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-            final Object[] actions = packetActions.getEnumConstants();
-            final Method sendPacket = getMethod(connection.getClass(), "sendPacket");
-            final Object packet = packetTitle.getConstructor(packetActions).newInstance(actions[4]);
-            sendPacket.invoke(connection, packet);
-        }
-    }
-    
-    /**
-     * Get the protocol version of the player
-     *
-     * @param player
-     *            Player
-     * @return Protocol version
-     * @throws Exception
-     */
-    private int getProtocolVersion(final Player player) throws Exception {
-        final Object handle = getHandle(player);
-        final Object connection = getField(handle.getClass(), "playerConnection").get(handle);
-        final Object networkManager = getValue("networkManager", connection);
-        return (Integer) getMethod("getVersion", networkManager.getClass()).invoke(networkManager);
-    }
-    
-    /**
-     * Check if running spigot
-     *
-     * @return Spigot
-     */
-    private boolean isSpigot() {
-        return Bukkit.getVersion().contains("Spigot");
-    }
-    
-    /**
-     * Get class by url
-     *
-     * @param namespace
-     *            Namespace url
-     * @return Class
-     */
-    private Class<?> getClass(final String namespace) {
-        try {
-            return Class.forName(namespace);
-        } catch (ClassNotFoundException e) {
-        }
-        return null;
-    }
-    
-    private Field getField(final String name, final Class<?> clazz) throws Exception {
-        return clazz.getDeclaredField(name);
-    }
-    
-    private Object getValue(final String name, final Object obj) throws Exception {
-        final Field f = getField(name, obj.getClass());
-        f.setAccessible(true);
-        return f.get(obj);
-    }
-    
-    private Class<?> getPrimitiveType(final Class<?> clazz) {
-        return CORRESPONDING_TYPES.containsKey(clazz) ? CORRESPONDING_TYPES.get(clazz) : clazz;
-    }
-    
-    private Class<?>[] toPrimitiveTypeArray(final Class<?>[] classes) {
-        final int a = classes != null ? classes.length : 0;
-        final Class<?>[] types = new Class<?>[a];
-        for (int i = 0; i < a; i++) {
-            types[i] = getPrimitiveType(classes[i]);
-        }
-        return types;
-    }
-    
-    private static boolean equalsTypeArray(final Class<?>[] a, final Class<?>[] o) {
         if (a.length != o.length) {
             return false;
         }
@@ -375,8 +111,259 @@ public class HackTitleManager {
         }
         return true;
     }
-    
+
-    private Object getHandle(final Object obj) {
+    /**
+     * Load spigot and NMS classes.
+     */
+    private void loadClasses() {
+        this.packetTitle = getClass("org.spigotmc.ProtocolInjector$PacketTitle");
+        this.packetActions = getClass("org.spigotmc.ProtocolInjector$PacketTitle$Action");
+        this.nmsChatSerializer = Reflection.getNMSClass("ChatSerializer");
+    }
+
+    /**
+     * Get title text.
+     *
+     * @return Title text
+     */
+    public String getTitle() {
+        return this.title;
+    }
+
+    /**
+     * Set title text.
+     *
+     * @param title Title
+     */
+    public void setTitle(String title) {
+        this.title = title;
+    }
+
+    /**
+     * Get subtitle text.
+     *
+     * @return Subtitle text
+     */
+    public String getSubtitle() {
+        return this.subtitle;
+    }
+
+    /**
+     * Set subtitle text.
+     *
+     * @param subtitle Subtitle text
+     */
+    public void setSubtitle(String subtitle) {
+        this.subtitle = subtitle;
+    }
+
+    /**
+     * Set the title color.
+     *
+     * @param color Chat color
+     */
+    public void setTitleColor(ChatColor color) {
+        this.titleColor = color;
+    }
+
+    /**
+     * Set the subtitle color.
+     *
+     * @param color Chat color
+     */
+    public void setSubtitleColor(ChatColor color) {
+        this.subtitleColor = color;
+    }
+
+    /**
+     * Set title fade in time.
+     *
+     * @param time Time
+     */
+    public void setFadeInTime(int time) {
+        this.fadeInTime = time;
+    }
+
+    /**
+     * Set title fade out time.
+     *
+     * @param time Time
+     */
+    public void setFadeOutTime(int time) {
+        this.fadeOutTime = time;
+    }
+
+    /**
+     * Set title stay time.
+     *
+     * @param time Time
+     */
+    public void setStayTime(int time) {
+        this.stayTime = time;
+    }
+
+    /**
+     * Set timings to ticks.
+     */
+    public void setTimingsToTicks() {
+        this.ticks = true;
+    }
+
+    /**
+     * Set timings to seconds.
+     */
+    public void setTimingsToSeconds() {
+        this.ticks = false;
+    }
+
+    /**
+     * Send the title to a player.
+     *
+     * @param player Player
+     * @throws Exception on NMS error
+     */
+    public void send(Player player) throws Exception {
+        if ((getProtocolVersion(player) >= 47) && isSpigot() && (this.packetTitle != null)) {
+            // First reset previous settings
+            resetTitle(player);
+            // Send timings first
+            Object handle = getHandle(player);
+            Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+            Object[] actions = this.packetActions.getEnumConstants();
+            Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+            Object packet = this.packetTitle.getConstructor(this.packetActions, Integer.TYPE, Integer.TYPE, Integer.TYPE).newInstance(actions[2],
+                    this.fadeInTime * (this.ticks ? 1 : 20),
+                    this.stayTime * (this.ticks ? 1 : 20),
+                    this.fadeOutTime * (this.ticks ? 1 : 20));
+            // Send if set
+            if ((this.fadeInTime != -1) && (this.fadeOutTime != -1) && (this.stayTime != -1)) {
+                sendPacket.invoke(connection, packet);
+            }
+            // Send title
+            Object serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
+                    "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.title) + "\",color:" + this.titleColor.name().toLowerCase() + "}");
+            packet = this.packetTitle.getConstructor(this.packetActions, Reflection.getNMSClass("IChatBaseComponent"))
+                    .newInstance(actions[0], serialized);
+            sendPacket.invoke(connection, packet);
+            if (!this.subtitle.isEmpty()) {
+                // Send subtitle if present
+                serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
+                        "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.subtitle) + "\",color:" + this.subtitleColor.name()
+                                .toLowerCase() + "}");
+                packet = this.packetTitle.getConstructor(this.packetActions, Reflection.getNMSClass("IChatBaseComponent"))
+                        .newInstance(actions[1], serialized);
+                sendPacket.invoke(connection, packet);
+            }
+        }
+    }
+
+    /**
+     * Broadcast the title to all players.
+     * @throws Exception on NMS Error
+     */
+    public void broadcast() throws Exception {
+        for (Player p : Bukkit.getOnlinePlayers()) {
+            send(p);
+        }
+    }
+
+    /**
+     * Clear the title.
+     *
+     * @param player Player
+     * @throws Exception on NMS Error
+     */
+    public void clearTitle(Player player) throws Exception {
+        if ((getProtocolVersion(player) >= 47) && isSpigot()) {
+            // Send timings first
+            Object handle = getHandle(player);
+            Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+            Object[] actions = this.packetActions.getEnumConstants();
+            Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+            Object packet = this.packetTitle.getConstructor(this.packetActions).newInstance(actions[3]);
+            sendPacket.invoke(connection, packet);
+        }
+    }
+
+    /**
+     * Reset the title settings.
+     *
+     * @param player Player
+     * @throws Exception on NMS error.
+     */
+    public void resetTitle(Player player) throws Exception {
+        if ((getProtocolVersion(player) >= 47) && isSpigot()) {
+            // Send timings first
+            Object handle = getHandle(player);
+            Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+            Object[] actions = this.packetActions.getEnumConstants();
+            Method sendPacket = getMethod(connection.getClass(), "sendPacket");
+            Object packet = this.packetTitle.getConstructor(this.packetActions).newInstance(actions[4]);
+            sendPacket.invoke(connection, packet);
+        }
+    }
+
+    /**
+     * Get the protocol version of the player.
+     *
+     * @param player Player
+     * @return Protocol version
+     * @throws Exception on NMS Error
+     */
+    private int getProtocolVersion(Player player) throws Exception {
+        Object handle = getHandle(player);
+        Object connection = getField(handle.getClass(), "playerConnection").get(handle);
+        Object networkManager = getValue("networkManager", connection);
+        return (Integer) getMethod("getVersion", networkManager.getClass()).invoke(networkManager);
+    }
+
+    /**
+     * Check if running spigot.
+     *
+     * @return Spigot
+     */
+    private boolean isSpigot() {
+        return Bukkit.getVersion().contains("Spigot");
+    }
+
+    /**
+     * Get class by url.
+     *
+     * @param namespace Namespace url
+     * @return Class
+     */
+    private Class<?> getClass(String namespace) {
+        try {
+            return Class.forName(namespace);
+        } catch (ClassNotFoundException ignored) {
+        }
+        return null;
+    }
+
+    private Field getField(String name, Class<?> clazz) throws Exception {
+        return clazz.getDeclaredField(name);
+    }
+
+    private Object getValue(String name, Object obj) throws Exception {
+        Field f = getField(name, obj.getClass());
+        f.setAccessible(true);
+        return f.get(obj);
+    }
+
+    private Class<?> getPrimitiveType(Class<?> clazz) {
+        return CORRESPONDING_TYPES.containsKey(clazz) ? CORRESPONDING_TYPES.get(clazz) : clazz;
+    }
+
+    private Class<?>[] toPrimitiveTypeArray(Class<?>[] classes) {
+        int a = classes != null ? classes.length : 0;
+        Class<?>[] types = new Class<?>[a];
+        for (int i = 0; i < a; i++) {
+            types[i] = getPrimitiveType(classes[i]);
+        }
+        return types;
+    }
+
+    private Object getHandle(Object obj) {
         try {
             return getMethod("getHandle", obj.getClass()).invoke(obj);
         } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
@@ -384,31 +371,21 @@ public class HackTitleManager {
             return null;
         }
     }
-    
+
-    private Method getMethod(final String name, final Class<?> clazz, final Class<?>... paramTypes) {
+    private Method getMethod(String name, Class<?> clazz, Class<?>... paramTypes) {
-        final Class<?>[] t = toPrimitiveTypeArray(paramTypes);
+        Class<?>[] t = toPrimitiveTypeArray(paramTypes);
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
-            final Class<?>[] types = toPrimitiveTypeArray(m.getParameterTypes());
+            Class<?>[] types = toPrimitiveTypeArray(m.getParameterTypes());
             if (m.getName().equals(name) && equalsTypeArray(types, t)) {
                 return m;
             }
         }
         return null;
     }
-    
+
-    private String getVersion() {
+    private Field getField(Class<?> clazz, String name) {
-        final String name = Bukkit.getServer().getClass().getPackage().getName();
-        return name.substring(name.lastIndexOf('.') + 1) + ".";
-    }
-    
-    private Class<?> getNMSClass(final String className) throws ClassNotFoundException {
-        final String fullName = "net.minecraft.server." + getVersion() + className;
-        return Class.forName(fullName);
-    }
-    
-    private Field getField(final Class<?> clazz, final String name) {
         try {
-            final Field field = clazz.getDeclaredField(name);
+            Field field = clazz.getDeclaredField(name);
             field.setAccessible(true);
             return field;
         } catch (SecurityException | NoSuchFieldException e) {
@@ -416,18 +393,18 @@ public class HackTitleManager {
             return null;
         }
     }
-    
+
-    private Method getMethod(final Class<?> clazz, final String name, final Class<?>... args) {
+    private Method getMethod(Class<?> clazz, String name, Class<?>... args) {
-        for (final Method m : clazz.getMethods()) {
+        for (Method m : clazz.getMethods()) {
-            if (m.getName().equals(name) && ((args.length == 0) || ClassListEqual(args, m.getParameterTypes()))) {
+            if (m.getName().equals(name) && ((args.length == 0) || classListEqual(args, m.getParameterTypes()))) {
                 m.setAccessible(true);
                 return m;
             }
         }
         return null;
     }
-    
+
-    private boolean ClassListEqual(final Class<?>[] l1, final Class<?>[] l2) {
+    private boolean classListEqual(Class<?>[] l1, Class<?>[] l2) {
         if (l1.length != l2.length) {
             return false;
         }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitChatManager.java

@@ -20,31 +20,31 @@ public class BukkitChatManager extends ChatManager<FancyMessage> {
     }
 
     @Override
-    public void color(final PlotMessage m, final String color) {
+    public void color(PlotMessage m, String color) {
         m.$(this).color(ChatColor.getByChar(C.color(color).substring(1)));
     }
 
     @Override
-    public void tooltip(final PlotMessage m, final PlotMessage... tooltips) {
+    public void tooltip(PlotMessage m, PlotMessage... tooltips) {
-        final List<FancyMessage> lines = new ArrayList<>();
+        List<FancyMessage> lines = new ArrayList<>();
-        for (final PlotMessage tooltip : tooltips) {
+        for (PlotMessage tooltip : tooltips) {
             lines.add(tooltip.$(this));
         }
         m.$(this).formattedTooltip(lines);
     }
 
     @Override
-    public void command(final PlotMessage m, final String command) {
+    public void command(PlotMessage m, String command) {
         m.$(this).command(command);
     }
 
     @Override
-    public void text(final PlotMessage m, final String text) {
+    public void text(PlotMessage m, String text) {
         m.$(this).then(ChatColor.stripColor(text));
     }
 
     @Override
-    public void send(final PlotMessage m, final PlotPlayer player) {
+    public void send(PlotMessage m, PlotPlayer player) {
         if (ConsolePlayer.isConsole(player)) {
             player.sendMessage(m.$(this).toOldMessageFormat());
         } else {
@@ -53,7 +53,7 @@ public class BukkitChatManager extends ChatManager<FancyMessage> {
     }
 
     @Override
-    public void suggest(final PlotMessage m, final String command) {
+    public void suggest(PlotMessage m, String command) {
         m.$(this).suggest(command);
     }
 

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitCommand.java

@@ -3,10 +3,7 @@ package com.plotsquared.bukkit.util;
 import com.intellectualcrafters.plot.commands.MainCommand;
 import com.intellectualcrafters.plot.object.ConsolePlayer;
 import com.intellectualcrafters.plot.object.PlotPlayer;
-import com.intellectualcrafters.plot.util.Permissions;
-import com.intellectualcrafters.plot.util.StringComparison;
 import com.plotsquared.bukkit.commands.DebugUUID;
-import com.plotsquared.general.commands.Command;
 import org.bukkit.Bukkit;
 import org.bukkit.command.CommandExecutor;
 import org.bukkit.command.CommandSender;
@@ -14,30 +11,23 @@ import org.bukkit.command.TabCompleter;
 import org.bukkit.entity.Player;
 
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
-import java.util.HashSet;
 import java.util.List;
-import java.util.Set;
 
-/**
- * Created 2015-02-20 for PlotSquared
- *
-
- */
 public class BukkitCommand implements CommandExecutor, TabCompleter {
 
     public BukkitCommand() {
-        MainCommand.getInstance().addCommand(new DebugUUID());
+        new DebugUUID();
     }
 
     @Override
-    public boolean onCommand(final CommandSender commandSender, final org.bukkit.command.Command command, final String commandLabel,
+    public boolean onCommand(final CommandSender commandSender, org.bukkit.command.Command command, final String commandLabel, String[] args) {
-            final String[] args) {
         if (commandSender instanceof Player) {
-            return MainCommand.onCommand(BukkitUtil.getPlayer((Player) commandSender), commandLabel, args);
+            return MainCommand.onCommand(BukkitUtil.getPlayer((Player) commandSender), args);
         }
-        if (commandSender == null || commandSender.getClass() == Bukkit.getConsoleSender().getClass()) {
+        if (commandSender.getClass() == Bukkit.getConsoleSender().getClass()) {
-            return MainCommand.onCommand(ConsolePlayer.getConsole(), commandLabel, args);
+            return MainCommand.onCommand(ConsolePlayer.getConsole(), args);
         }
         @SuppressWarnings("deprecation")
         ConsolePlayer sender = new ConsolePlayer() {
@@ -47,7 +37,7 @@ public class BukkitCommand implements CommandExecutor, TabCompleter {
             }
 
             @Override
-            public boolean hasPermission(String perm) {
+            public boolean hasPermission(String permission) {
                 return commandSender.hasPermission(commandLabel);
             }
 
@@ -60,49 +50,28 @@ public class BukkitCommand implements CommandExecutor, TabCompleter {
             }
         };
         sender.teleport(ConsolePlayer.getConsole().getLocationFull());
-        boolean result = MainCommand.onCommand(sender, commandLabel, args);
+        boolean result = MainCommand.onCommand(sender, args);
         ConsolePlayer.getConsole().teleport(sender.getLocationFull());
         return result;
     }
 
     @Override
-    public List<String> onTabComplete(final CommandSender commandSender, final org.bukkit.command.Command command, final String s,
+    public List<String> onTabComplete(CommandSender commandSender, org.bukkit.command.Command command, String s, String[] args) {
-            final String[] strings) {
         if (!(commandSender instanceof Player)) {
             return null;
         }
-        final PlotPlayer player = BukkitUtil.getPlayer((Player) commandSender);
+        PlotPlayer player = BukkitUtil.getPlayer((Player) commandSender);
-        if (strings.length < 1) {
+        if (args.length == 0) {
-            if ((strings.length == 0) || "plots".startsWith(s)) {
+            return Collections.singletonList("plots");
-                return Collections.singletonList("plots");
-            }
         }
-        if (strings.length > 1) {
+        Collection objects = MainCommand.getInstance().tab(player, args, s.endsWith(" "));
+        if (objects == null) {
             return null;
         }
-        final Set<String> tabOptions = new HashSet<>();
+        List<String> result = new ArrayList<>();
-        final String arg = strings[0].toLowerCase();
+        for (Object o : objects) {
-        ArrayList<String> labels = new ArrayList<>();
+            result.add(o.toString());
-        for (final Command<PlotPlayer> cmd : MainCommand.getInstance().getCommands()) {
-            final String label = cmd.getCommand();
-            HashSet<String> aliases = new HashSet<>(cmd.getAliases());
-            aliases.add(label);
-            for (String alias : aliases) {
-                labels.add(alias);
-                if (alias.startsWith(arg)) {
-                    if (Permissions.hasPermission(player, cmd.getPermission())) {
-                        tabOptions.add(label);
-                    } else {
-                        break;
-                    }
-                }
-            }
         }
-        String best = new StringComparison<>(arg, labels).getBestMatch();
+        return result.size() == 0 ? null : result;
-        tabOptions.add(best);
-        if (!tabOptions.isEmpty()) {
-            return new ArrayList<>(tabOptions);
-        }
-        return null;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitEconHandler.java

@@ -1,16 +1,14 @@
 package com.plotsquared.bukkit.util;
 
-import net.milkbowl.vault.economy.Economy;
-import net.milkbowl.vault.permission.Permission;
-
-import org.bukkit.Bukkit;
-import org.bukkit.plugin.RegisteredServiceProvider;
-
 import com.intellectualcrafters.plot.object.OfflinePlotPlayer;
 import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.intellectualcrafters.plot.util.EconHandler;
 import com.plotsquared.bukkit.object.BukkitOfflinePlayer;
 import com.plotsquared.bukkit.object.BukkitPlayer;
+import net.milkbowl.vault.economy.Economy;
+import net.milkbowl.vault.permission.Permission;
+import org.bukkit.Bukkit;
+import org.bukkit.plugin.RegisteredServiceProvider;
 
 public class BukkitEconHandler extends EconHandler {
 
@@ -19,80 +17,72 @@ public class BukkitEconHandler extends EconHandler {
 
     public Economy getEconomy() {
         init();
-        return econ;
+        return this.econ;
     }
 
     public Permission getPermissions() {
         init();
-        return perms;
+        return this.perms;
     }
 
     public boolean init() {
-        if (econ == null || perms == null) {
+        if (this.econ == null || this.perms == null) {
             setupPermissions();
             setupEconomy();
         }
-        return econ != null && perms != null;
+        return this.econ != null && this.perms != null;
     }
 
     private boolean setupPermissions() {
-        final RegisteredServiceProvider<Permission> permissionProvider =
+        RegisteredServiceProvider<Permission> permissionProvider = Bukkit.getServer().getServicesManager().getRegistration(Permission.class);
-                Bukkit.getServer().getServicesManager().getRegistration(net.milkbowl.vault.permission.Permission.class);
         if (permissionProvider != null) {
-            perms = permissionProvider.getProvider();
+            this.perms = permissionProvider.getProvider();
         }
-        return perms != null;
+        return this.perms != null;
     }
 
     private boolean setupEconomy() {
-        final RegisteredServiceProvider<Economy> economyProvider =
+        if (Bukkit.getServer().getPluginManager().getPlugin("Vault") == null) {
-                Bukkit.getServer().getServicesManager().getRegistration(net.milkbowl.vault.economy.Economy.class);
+            return false;
-        if (economyProvider != null) {
-            econ = economyProvider.getProvider();
         }
-        return econ != null;
+        RegisteredServiceProvider<Economy> economyProvider = Bukkit.getServer().getServicesManager().getRegistration(Economy.class);
+        if (economyProvider != null) {
+            this.econ = economyProvider.getProvider();
+        }
+        return this.econ != null;
     }
 
     @Override
-    public double getMoney(final PlotPlayer player) {
+    public double getMoney(PlotPlayer player) {
-        final double bal = super.getMoney(player);
+        double bal = super.getMoney(player);
         if (Double.isNaN(bal)) {
-            return econ.getBalance(((BukkitPlayer) player).player);
+            return this.econ.getBalance(((BukkitPlayer) player).player);
         }
         return bal;
     }
 
     @Override
-    public void withdrawMoney(final PlotPlayer player, final double amount) {
+    public void withdrawMoney(PlotPlayer player, double amount) {
-        econ.withdrawPlayer(((BukkitPlayer) player).player, amount);
+        this.econ.withdrawPlayer(((BukkitPlayer) player).player, amount);
     }
 
     @Override
-    public void depositMoney(final PlotPlayer player, final double amount) {
+    public void depositMoney(PlotPlayer player, double amount) {
-        econ.depositPlayer(((BukkitPlayer) player).player, amount);
+        this.econ.depositPlayer(((BukkitPlayer) player).player, amount);
     }
 
     @Override
-    public void depositMoney(final OfflinePlotPlayer player, final double amount) {
+    public void depositMoney(OfflinePlotPlayer player, double amount) {
-        econ.depositPlayer(((BukkitOfflinePlayer) player).player, amount);
+        this.econ.depositPlayer(((BukkitOfflinePlayer) player).player, amount);
     }
 
     @Override
-    public void setPermission(final String world, final String player, final String perm, final boolean value) {
+    public boolean hasPermission(String world, String player, String perm) {
-        if (value) {
+        return this.perms.playerHas(world, Bukkit.getOfflinePlayer(player), perm);
-            perms.playerAdd(world, player, perm);
-        } else {
-            perms.playerRemove(world, player, perm);
-        }
     }
 
-    @Override
-    public boolean hasPermission(final String world, final String player, final String perm) {
-        return perms.playerHas(world, Bukkit.getOfflinePlayer(player), perm);
-    }
-    
     @Override
     public double getBalance(PlotPlayer player) {
-        return econ.getBalance(player.getName());
+        return this.econ.getBalance(player.getName());
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitEventUtil.java

@@ -35,91 +35,91 @@ import java.util.UUID;
 
 public class BukkitEventUtil extends EventUtil {
 
-    public Player getPlayer(final PlotPlayer player) {
+    public Player getPlayer(PlotPlayer player) {
         if (player instanceof BukkitPlayer) {
             return ((BukkitPlayer) player).player;
         }
         return null;
     }
 
-    public boolean callEvent(final Event event) {
+    public boolean callEvent(Event event) {
         Bukkit.getServer().getPluginManager().callEvent(event);
         return !(event instanceof Cancellable) || !((Cancellable) event).isCancelled();
     }
 
     @Override
-    public boolean callClaim(final PlotPlayer player, final Plot plot, final boolean auto) {
+    public boolean callClaim(PlotPlayer player, Plot plot, boolean auto) {
         return callEvent(new PlayerClaimPlotEvent(getPlayer(player), plot, auto));
     }
 
     @Override
-    public boolean callTeleport(final PlotPlayer player, final Location from, final Plot plot) {
+    public boolean callTeleport(PlotPlayer player, Location from, Plot plot) {
         return callEvent(new PlayerTeleportToPlotEvent(getPlayer(player), from, plot));
     }
 
     @Override
-    public boolean callClear(final Plot plot) {
+    public boolean callClear(Plot plot) {
         return callEvent(new PlotClearEvent(plot));
     }
 
     @Override
-    public void callDelete(final Plot plot) {
+    public void callDelete(Plot plot) {
         callEvent(new PlotDeleteEvent(plot));
     }
 
     @Override
-    public boolean callFlagAdd(final Flag flag, final Plot plot) {
+    public boolean callFlagAdd(Flag flag, Plot plot) {
         return callEvent(new PlotFlagAddEvent(flag, plot));
     }
 
     @Override
-    public boolean callFlagRemove(final Flag flag, final Plot plot) {
+    public boolean callFlagRemove(Flag flag, Plot plot) {
         return callEvent(new PlotFlagRemoveEvent(flag, plot));
     }
 
     @Override
-    public boolean callMerge(final Plot plot, final ArrayList<PlotId> plots) {
+    public boolean callMerge(Plot plot, ArrayList<PlotId> plots) {
         return callEvent(new PlotMergeEvent(BukkitUtil.getWorld(plot.getArea().worldname), plot, plots));
     }
 
     @Override
-    public boolean callUnlink(final PlotArea area, final ArrayList<PlotId> plots) {
+    public boolean callUnlink(PlotArea area, ArrayList<PlotId> plots) {
         return callEvent(new PlotUnlinkEvent(BukkitUtil.getWorld(area.worldname), area, plots));
     }
 
     @Override
-    public void callEntry(final PlotPlayer player, final Plot plot) {
+    public void callEntry(PlotPlayer player, Plot plot) {
         callEvent(new PlayerEnterPlotEvent(getPlayer(player), plot));
     }
 
     @Override
-    public void callLeave(final PlotPlayer player, final Plot plot) {
+    public void callLeave(PlotPlayer player, Plot plot) {
         callEvent(new PlayerLeavePlotEvent(getPlayer(player), plot));
     }
 
     @Override
-    public void callDenied(final PlotPlayer initiator, final Plot plot, final UUID player, final boolean added) {
+    public void callDenied(PlotPlayer initiator, Plot plot, UUID player, boolean added) {
         callEvent(new PlayerPlotDeniedEvent(getPlayer(initiator), plot, player, added));
     }
 
     @Override
-    public void callTrusted(final PlotPlayer initiator, final Plot plot, final UUID player, final boolean added) {
+    public void callTrusted(PlotPlayer initiator, Plot plot, UUID player, boolean added) {
         callEvent(new PlayerPlotHelperEvent(getPlayer(initiator), plot, player, added));
     }
 
     @Override
-    public void callMember(final PlotPlayer initiator, final Plot plot, final UUID player, final boolean added) {
+    public void callMember(PlotPlayer initiator, Plot plot, UUID player, boolean added) {
         callEvent(new PlayerPlotTrustedEvent(getPlayer(initiator), plot, player, added));
     }
 
     @Override
-    public boolean callFlagRemove(final Flag flag, final PlotCluster cluster) {
+    public boolean callFlagRemove(Flag flag, PlotCluster cluster) {
         return callEvent(new ClusterFlagRemoveEvent(flag, cluster));
     }
 
     @Override
-    public Rating callRating(final PlotPlayer player, final Plot plot, final Rating rating) {
+    public Rating callRating(PlotPlayer player, Plot plot, Rating rating) {
-        final PlotRateEvent event = new PlotRateEvent(player, rating, plot);
+        PlotRateEvent event = new PlotRateEvent(player, rating, plot);
         Bukkit.getServer().getPluginManager().callEvent(event);
         return event.getRating();
     }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitHybridUtils.java

@@ -1,18 +1,5 @@
 package com.plotsquared.bukkit.util;
 
-import java.util.HashSet;
-import java.util.Random;
-
-import org.bukkit.Bukkit;
-import org.bukkit.Material;
-import org.bukkit.World;
-import org.bukkit.block.Biome;
-import org.bukkit.block.Block;
-import org.bukkit.generator.ChunkGenerator;
-import org.bukkit.generator.ChunkGenerator.BiomeGrid;
-import org.bukkit.material.Directional;
-import org.bukkit.material.MaterialData;
-
 import com.intellectualcrafters.plot.generator.HybridUtils;
 import com.intellectualcrafters.plot.object.Location;
 import com.intellectualcrafters.plot.object.PlotAnalysis;
@@ -23,6 +10,18 @@ import com.intellectualcrafters.plot.util.ChunkManager;
 import com.intellectualcrafters.plot.util.MainUtil;
 import com.intellectualcrafters.plot.util.MathMan;
 import com.intellectualcrafters.plot.util.TaskManager;
+import org.bukkit.Bukkit;
+import org.bukkit.Material;
+import org.bukkit.World;
+import org.bukkit.block.Biome;
+import org.bukkit.block.Block;
+import org.bukkit.generator.ChunkGenerator;
+import org.bukkit.generator.ChunkGenerator.BiomeGrid;
+import org.bukkit.material.Directional;
+import org.bukkit.material.MaterialData;
+
+import java.util.HashSet;
+import java.util.Random;
 
 public class BukkitHybridUtils extends HybridUtils {
 
@@ -50,11 +49,11 @@ public class BukkitHybridUtils extends HybridUtils {
                 }
                 final BiomeGrid nullBiomeGrid = new BiomeGrid() {
                     @Override
-                    public void setBiome(final int a, final int b, final Biome c) {
+                    public void setBiome(int a, int b, Biome c) {
                     }
 
                     @Override
-                    public Biome getBiome(final int a, final int b) {
+                    public Biome getBiome(int a, int b) {
                         return null;
                     }
                 };
@@ -72,13 +71,13 @@ public class BukkitHybridUtils extends HybridUtils {
                 final int ctz = tz >> 4;
                 final Random r = new Random();
                 MainUtil.initCache();
-                final int width = (tx - bx) + 1;
+                final int width = tx - bx + 1;
-                final int length = (tz - bz) + 1;
+                final int length = tz - bz + 1;
 
                 System.gc();
                 System.gc();
-                final short[][][] oldblocks = new short[256][width][length];
+                final short[][][] oldBlocks = new short[256][width][length];
-                final short[][][] newblocks = new short[256][width][length];
+                final short[][][] newBlocks = new short[256][width][length];
 
                 final Runnable run = new Runnable() {
                     @Override
@@ -87,38 +86,38 @@ public class BukkitHybridUtils extends HybridUtils {
                             @Override
                             public void run(int[] value) {
                                 // [chunkx, chunkz, pos1x, pos1z, pos2x, pos2z, isedge]
-                                final int X = value[0];
+                                int X = value[0];
-                                final int Z = value[1];
+                                int Z = value[1];
-                                final short[][] result = gen.generateExtBlockSections(worldObj, r, X, Z, nullBiomeGrid);
+                                short[][] result = gen.generateExtBlockSections(worldObj, r, X, Z, nullBiomeGrid);
-                                final int xb = ((X) << 4) - bx;
+                                int xb = (X << 4) - bx;
-                                final int zb = ((Z) << 4) - bz;
+                                int zb = (Z << 4) - bz;
                                 for (int i = 0; i < result.length; i++) {
                                     if (result[i] == null) {
                                         for (int j = 0; j < 4096; j++) {
-                                            final int x = MainUtil.x_loc[i][j] + xb;
+                                            int x = MainUtil.x_loc[i][j] + xb;
-                                            if ((x < 0) || (x >= width)) {
+                                            if (x < 0 || x >= width) {
                                                 continue;
                                             }
-                                            final int z = MainUtil.z_loc[i][j] + zb;
+                                            int z = MainUtil.z_loc[i][j] + zb;
-                                            if ((z < 0) || (z >= length)) {
+                                            if (z < 0 || z >= length) {
                                                 continue;
                                             }
-                                            final int y = MainUtil.y_loc[i][j];
+                                            int y = MainUtil.y_loc[i][j];
-                                            oldblocks[y][x][z] = 0;
+                                            oldBlocks[y][x][z] = 0;
                                         }
                                         continue;
                                     }
                                     for (int j = 0; j < result[i].length; j++) {
-                                        final int x = MainUtil.x_loc[i][j] + xb;
+                                        int x = MainUtil.x_loc[i][j] + xb;
-                                        if ((x < 0) || (x >= width)) {
+                                        if (x < 0 || x >= width) {
                                             continue;
                                         }
-                                        final int z = MainUtil.z_loc[i][j] + zb;
+                                        int z = MainUtil.z_loc[i][j] + zb;
-                                        if ((z < 0) || (z >= length)) {
+                                        if (z < 0 || z >= length) {
                                             continue;
                                         }
-                                        final int y = MainUtil.y_loc[i][j];
+                                        int y = MainUtil.y_loc[i][j];
-                                        oldblocks[y][x][z] = result[i][j];
+                                        oldBlocks[y][x][z] = result[i][j];
                                     }
                                 }
 
@@ -129,19 +128,19 @@ public class BukkitHybridUtils extends HybridUtils {
                                 TaskManager.runTaskAsync(new Runnable() {
                                     @Override
                                     public void run() {
-                                        final int size = width * length;
+                                        int size = width * length;
-                                        final int[] changes = new int[size];
+                                        int[] changes = new int[size];
-                                        final int[] faces = new int[size];
+                                        int[] faces = new int[size];
-                                        final int[] data = new int[size];
+                                        int[] data = new int[size];
-                                        final int[] air = new int[size];
+                                        int[] air = new int[size];
-                                        final int[] variety = new int[size];
+                                        int[] variety = new int[size];
                                         int i = 0;
                                         for (int x = 0; x < width; x++) {
                                             for (int z = 0; z < length; z++) {
-                                                final HashSet<Short> types = new HashSet<>();
+                                                HashSet<Short> types = new HashSet<>();
                                                 for (int y = 0; y < 256; y++) {
-                                                    final short old = oldblocks[y][x][z];
+                                                    short old = oldBlocks[y][x][z];
-                                                    final short now = newblocks[y][x][z];
+                                                    short now = newBlocks[y][x][z];
                                                     if (old != now) {
                                                         changes[i]++;
                                                     }
@@ -150,29 +149,29 @@ public class BukkitHybridUtils extends HybridUtils {
                                                     } else {
                                                         // check vertices
                                                         // modifications_adjacent
-                                                        if ((x > 0) && (z > 0) && (y > 0) && (x < (width - 1)) && (z < (length - 1)) && (y < 255)) {
+                                                        if (x > 0 && z > 0 && y > 0 && x < width - 1 && z < length - 1 && y < 255) {
-                                                            if (newblocks[y - 1][x][z] == 0) {
+                                                            if (newBlocks[y - 1][x][z] == 0) {
                                                                 faces[i]++;
                                                             }
-                                                            if (newblocks[y][x - 1][z] == 0) {
+                                                            if (newBlocks[y][x - 1][z] == 0) {
                                                                 faces[i]++;
                                                             }
-                                                            if (newblocks[y][x][z - 1] == 0) {
+                                                            if (newBlocks[y][x][z - 1] == 0) {
                                                                 faces[i]++;
                                                             }
-                                                            if (newblocks[y + 1][x][z] == 0) {
+                                                            if (newBlocks[y + 1][x][z] == 0) {
                                                                 faces[i]++;
                                                             }
-                                                            if (newblocks[y][x + 1][z] == 0) {
+                                                            if (newBlocks[y][x + 1][z] == 0) {
                                                                 faces[i]++;
                                                             }
-                                                            if (newblocks[y][x][z + 1] == 0) {
+                                                            if (newBlocks[y][x][z + 1] == 0) {
                                                                 faces[i]++;
                                                             }
                                                         }
 
-                                                        final Material material = Material.getMaterial(now);
+                                                        Material material = Material.getMaterial(now);
-                                                        final Class<? extends MaterialData> md = material.getData();
+                                                        Class<? extends MaterialData> md = material.getData();
                                                         if (md.equals(Directional.class)) {
                                                             data[i] += 8;
                                                         } else if (!md.equals(MaterialData.class)) {
@@ -189,18 +188,18 @@ public class BukkitHybridUtils extends HybridUtils {
                                         // put in analysis obj
 
                                         // run whenDone
-                                        final PlotAnalysis analysis = new PlotAnalysis();
+                                        PlotAnalysis analysis = new PlotAnalysis();
                                         analysis.changes = (int) (MathMan.getMean(changes) * 100);
                                         analysis.faces = (int) (MathMan.getMean(faces) * 100);
                                         analysis.data = (int) (MathMan.getMean(data) * 100);
                                         analysis.air = (int) (MathMan.getMean(air) * 100);
                                         analysis.variety = (int) (MathMan.getMean(variety) * 100);
 
-                                        analysis.changes_sd = (int) (MathMan.getSD(changes, analysis.changes));
+                                        analysis.changes_sd = (int) MathMan.getSD(changes, analysis.changes);
-                                        analysis.faces_sd = (int) (MathMan.getSD(faces, analysis.faces));
+                                        analysis.faces_sd = (int) MathMan.getSD(faces, analysis.faces);
-                                        analysis.data_sd = (int) (MathMan.getSD(data, analysis.data));
+                                        analysis.data_sd = (int) MathMan.getSD(data, analysis.data);
-                                        analysis.air_sd = (int) (MathMan.getSD(air, analysis.air));
+                                        analysis.air_sd = (int) MathMan.getSD(air, analysis.air);
-                                        analysis.variety_sd = (int) (MathMan.getSD(variety, analysis.variety));
+                                        analysis.variety_sd = (int) MathMan.getSD(variety, analysis.variety);
                                         System.gc();
                                         System.gc();
                                         whenDone.value = analysis;
@@ -218,48 +217,48 @@ public class BukkitHybridUtils extends HybridUtils {
 
                     @Override
                     public void run(int[] value) {
-                        final int X = value[0];
+                        int X = value[0];
-                        final int Z = value[1];
+                        int Z = value[1];
                         worldObj.loadChunk(X, Z);
                         int minX;
-                        int minZ;
-                        int maxX;
-                        int maxZ;
                         if (X == cbx) {
                             minX = bx & 15;
                         } else {
                             minX = 0;
                         }
+                        int minZ;
                         if (Z == cbz) {
                             minZ = bz & 15;
                         } else {
                             minZ = 0;
                         }
+                        int maxX;
                         if (X == ctx) {
                             maxX = tx & 15;
                         } else {
                             maxX = 16;
                         }
+                        int maxZ;
                         if (Z == ctz) {
                             maxZ = tz & 15;
                         } else {
                             maxZ = 16;
                         }
 
-                        final int cbx = X << 4;
+                        int cbx = X << 4;
-                        final int cbz = Z << 4;
+                        int cbz = Z << 4;
 
-                        final int xb = (cbx) - bx;
+                        int xb = cbx - bx;
-                        final int zb = (cbz) - bz;
+                        int zb = cbz - bz;
                         for (int x = minX; x <= maxX; x++) {
-                            final int xx = cbx + x;
+                            int xx = cbx + x;
                             for (int z = minZ; z <= maxZ; z++) {
-                                final int zz = cbz + z;
+                                int zz = cbz + z;
                                 for (int y = 0; y < 256; y++) {
-                                    final Block block = worldObj.getBlockAt(xx, y, zz);
+                                    Block block = worldObj.getBlockAt(xx, y, zz);
-                                    final int xr = xb + x;
+                                    int xr = xb + x;
-                                    final int zr = zb + z;
+                                    int zr = zb + z;
-                                    newblocks[y][xr][zr] = (short) block.getTypeId();
+                                    newBlocks[y][xr][zr] = (short) block.getTypeId();
                                 }
                             }
                         }
@@ -276,17 +275,17 @@ public class BukkitHybridUtils extends HybridUtils {
     }
 
     @Override
-    public int checkModified(final String worldname, final int x1, final int x2, final int y1, final int y2, final int z1, final int z2,
+    public int checkModified(String worldName, int x1, int x2, int y1, int y2, int z1, int z2,
-            final PlotBlock[] blocks) {
+            PlotBlock[] blocks) {
-        final World world = BukkitUtil.getWorld(worldname);
+        World world = BukkitUtil.getWorld(worldName);
         int count = 0;
         for (int y = y1; y <= y2; y++) {
             for (int x = x1; x <= x2; x++) {
                 for (int z = z1; z <= z2; z++) {
-                    final Block block = world.getBlockAt(x, y, z);
+                    Block block = world.getBlockAt(x, y, z);
-                    final int id = block.getTypeId();
+                    int id = block.getTypeId();
                     boolean same = false;
-                    for (final PlotBlock p : blocks) {
+                    for (PlotBlock p : blocks) {
                         if (id == p.id) {
                             same = true;
                             break;
@@ -302,16 +301,16 @@ public class BukkitHybridUtils extends HybridUtils {
     }
 
     @Override
-    public int get_ey(final String worldname, final int sx, final int ex, final int sz, final int ez, final int sy) {
+    public int get_ey(String worldName, int sx, int ex, int sz, int ez, int sy) {
-        final World world = BukkitUtil.getWorld(worldname);
+        World world = BukkitUtil.getWorld(worldName);
-        final int maxY = world.getMaxHeight();
+        int maxY = world.getMaxHeight();
         int ey = sy;
         for (int x = sx; x <= ex; x++) {
             for (int z = sz; z <= ez; z++) {
                 for (int y = sy; y < maxY; y++) {
                     if (y > ey) {
-                        final Block block = world.getBlockAt(x, y, z);
+                        Block block = world.getBlockAt(x, y, z);
-                        if (block.getTypeId() != 0) {
+                        if (!block.getType().equals(Material.AIR)) {
                             ey = y;
                         }
                     }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitInventoryUtil.java

@@ -19,11 +19,11 @@ import java.util.List;
 
 public class BukkitInventoryUtil extends InventoryUtil {
 
-    public static ItemStack getItem(final PlotItemStack item) {
+    public static ItemStack getItem(PlotItemStack item) {
         if (item == null) {
             return null;
         }
-        final ItemStack stack = new ItemStack(item.id, item.amount, item.data);
+        ItemStack stack = new ItemStack(item.id, item.amount, item.data);
         ItemMeta meta = null;
         if (item.name != null) {
             meta = stack.getItemMeta();
@@ -33,8 +33,8 @@ public class BukkitInventoryUtil extends InventoryUtil {
             if (meta == null) {
                 meta = stack.getItemMeta();
             }
-            final List<String> lore = new ArrayList<>();
+            List<String> lore = new ArrayList<>();
-            for (final String entry : item.lore) {
+            for (String entry : item.lore) {
                 lore.add(ChatColor.translateAlternateColorCodes('&', entry));
             }
             meta.setLore(lore);
@@ -46,12 +46,12 @@ public class BukkitInventoryUtil extends InventoryUtil {
     }
 
     @Override
-    public void open(final PlotInventory inv) {
+    public void open(PlotInventory inv) {
-        final BukkitPlayer bp = (BukkitPlayer) inv.player;
+        BukkitPlayer bp = (BukkitPlayer) inv.player;
-        final Inventory inventory = Bukkit.createInventory(null, inv.size * 9, inv.getTitle());
+        Inventory inventory = Bukkit.createInventory(null, inv.size * 9, inv.getTitle());
-        final PlotItemStack[] items = inv.getItems();
+        PlotItemStack[] items = inv.getItems();
         for (int i = 0; i < inv.size * 9; i++) {
-            final PlotItemStack item = items[i];
+            PlotItemStack item = items[i];
             if (item != null) {
                 inventory.setItem(i, getItem(item));
             }
@@ -61,19 +61,19 @@ public class BukkitInventoryUtil extends InventoryUtil {
     }
 
     @Override
-    public void close(final PlotInventory inv) {
+    public void close(PlotInventory inv) {
         if (!inv.isOpen()) {
             return;
         }
         inv.player.deleteMeta("inventory");
-        final BukkitPlayer bp = (BukkitPlayer) inv.player;
+        BukkitPlayer bp = (BukkitPlayer) inv.player;
         bp.player.closeInventory();
     }
 
     @Override
-    public void setItem(final PlotInventory inv, final int index, final PlotItemStack item) {
+    public void setItem(PlotInventory inv, int index, PlotItemStack item) {
-        final BukkitPlayer bp = (BukkitPlayer) inv.player;
+        BukkitPlayer bp = (BukkitPlayer) inv.player;
-        final InventoryView opened = bp.player.getOpenInventory();
+        InventoryView opened = bp.player.getOpenInventory();
         if (!inv.isOpen()) {
             return;
         }
@@ -81,22 +81,22 @@ public class BukkitInventoryUtil extends InventoryUtil {
         bp.player.updateInventory();
     }
 
-    public PlotItemStack getItem(final ItemStack item) {
+    public PlotItemStack getItem(ItemStack item) {
         if (item == null) {
             return null;
         }
-        final int id = item.getTypeId();
+        int id = item.getTypeId();
-        final short data = item.getDurability();
+        short data = item.getDurability();
-        final int amount = item.getAmount();
+        int amount = item.getAmount();
         String name = null;
         String[] lore = null;
         if (item.hasItemMeta()) {
-            final ItemMeta meta = item.getItemMeta();
+            ItemMeta meta = item.getItemMeta();
             if (meta.hasDisplayName()) {
                 name = meta.getDisplayName();
             }
             if (meta.hasLore()) {
-                final List<String> itemLore = meta.getLore();
+                List<String> itemLore = meta.getLore();
                 lore = itemLore.toArray(new String[itemLore.size()]);
             }
         }
@@ -104,10 +104,10 @@ public class BukkitInventoryUtil extends InventoryUtil {
     }
 
     @Override
-    public PlotItemStack[] getItems(final PlotPlayer player) {
+    public PlotItemStack[] getItems(PlotPlayer player) {
-        final BukkitPlayer bp = (BukkitPlayer) player;
+        BukkitPlayer bp = (BukkitPlayer) player;
-        final PlayerInventory inv = bp.player.getInventory();
+        PlayerInventory inv = bp.player.getInventory();
-        final PlotItemStack[] items = new PlotItemStack[36];
+        PlotItemStack[] items = new PlotItemStack[36];
         for (int i = 0; i < 36; i++) {
             items[i] = getItem(inv.getItem(i));
         }
@@ -115,12 +115,12 @@ public class BukkitInventoryUtil extends InventoryUtil {
     }
 
     @Override
-    public boolean isOpen(final PlotInventory inv) {
+    public boolean isOpen(PlotInventory inv) {
         if (!inv.isOpen()) {
             return false;
         }
-        final BukkitPlayer bp = (BukkitPlayer) inv.player;
+        BukkitPlayer bp = (BukkitPlayer) inv.player;
-        final InventoryView opened = bp.player.getOpenInventory();
+        InventoryView opened = bp.player.getOpenInventory();
         return inv.isOpen() && opened.getType() == InventoryType.CRAFTING && opened.getTitle() == null;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitPlainChatManager.java

@@ -16,35 +16,35 @@ public class BukkitPlainChatManager extends ChatManager<List<StringBuilder>> {
     }
 
     @Override
-    public void color(final PlotMessage m, final String color) {
+    public void color(PlotMessage m, String color) {
-        final List<StringBuilder> parts = m.$(this);
+        List<StringBuilder> parts = m.$(this);
         parts.get(parts.size() - 1).insert(0, color);
     }
 
     @Override
-    public void tooltip(final PlotMessage m, final PlotMessage... tooltips) {
+    public void tooltip(PlotMessage m, PlotMessage... tooltips) {
     }
 
     @Override
-    public void command(final PlotMessage m, final String command) {
+    public void command(PlotMessage m, String command) {
     }
 
     @Override
-    public void text(final PlotMessage m, final String text) {
+    public void text(PlotMessage m, String text) {
         m.$(this).add(new StringBuilder(ChatColor.stripColor(text)));
     }
 
     @Override
-    public void send(final PlotMessage m, final PlotPlayer player) {
+    public void send(PlotMessage m, PlotPlayer player) {
-        final StringBuilder built = new StringBuilder();
+        StringBuilder built = new StringBuilder();
-        for (final StringBuilder sb : m.$(this)) {
+        for (StringBuilder sb : m.$(this)) {
             built.append(sb);
         }
         player.sendMessage(built.toString());
     }
 
     @Override
-    public void suggest(final PlotMessage m, final String command) {
+    public void suggest(PlotMessage m, String command) {
     }
 
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitSchematicHandler.java

@@ -1,39 +1,5 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.util;
 
-import java.util.ArrayDeque;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
-import java.util.Set;
-
-import org.bukkit.Bukkit;
-import org.bukkit.Chunk;
-import org.bukkit.World;
-import org.bukkit.block.Block;
-import org.bukkit.block.BlockState;
-
 import com.intellectualcrafters.jnbt.ByteArrayTag;
 import com.intellectualcrafters.jnbt.CompoundTag;
 import com.intellectualcrafters.jnbt.IntTag;
@@ -49,12 +15,21 @@ import com.intellectualcrafters.plot.util.MainUtil;
 import com.intellectualcrafters.plot.util.SchematicHandler;
 import com.intellectualcrafters.plot.util.TaskManager;
 import com.plotsquared.bukkit.object.schematic.StateWrapper;
+import org.bukkit.Bukkit;
+import org.bukkit.Chunk;
+import org.bukkit.World;
+import org.bukkit.block.Block;
+import org.bukkit.block.BlockState;
+
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
 
 /**
- * Schematic Handler
+ * Schematic Handler.
- *
-
-
  */
 public class BukkitSchematicHandler extends SchematicHandler {
 
@@ -67,11 +42,11 @@ public class BukkitSchematicHandler extends SchematicHandler {
                 // Main positions
                 Location[] corners = MainUtil.getCorners(world, regions);
                 final Location bot = corners[0];
-                final Location top = corners[1];
+                Location top = corners[1];
 
-                final int width = (top.getX() - bot.getX()) + 1;
+                final int width = top.getX() - bot.getX() + 1;
-                final int height = (top.getY() - bot.getY()) + 1;
+                int height = top.getY() - bot.getY() + 1;
-                final int length = (top.getZ() - bot.getZ()) + 1;
+                final int length = top.getZ() - bot.getZ() + 1;
                 // Main Schematic tag
                 final HashMap<String, Tag> schematic = new HashMap<>();
                 schematic.put("Width", new ShortTag("Width", (short) width));
@@ -85,7 +60,7 @@ public class BukkitSchematicHandler extends SchematicHandler {
                 schematic.put("WEOffsetY", new IntTag("WEOffsetY", 0));
                 schematic.put("WEOffsetZ", new IntTag("WEOffsetZ", 0));
                 // Arrays of data types
-                final List<Tag> tileEntities = new ArrayList<>();
+                final List<CompoundTag> tileEntities = new ArrayList<>();
                 final byte[] blocks = new byte[width * height * length];
                 final byte[] blockData = new byte[width * height * length];
                 // Queue
@@ -137,16 +112,16 @@ public class BukkitSchematicHandler extends SchematicHandler {
                         TaskManager.runTask(new Runnable() {
                             @Override
                             public void run() {
-                                final long start = System.currentTimeMillis();
+                                long start = System.currentTimeMillis();
-                                while ((!chunks.isEmpty()) && ((System.currentTimeMillis() - start) < 20)) {
+                                while (!chunks.isEmpty() && System.currentTimeMillis() - start < 20) {
                                     // save schematics
-                                    final ChunkLoc chunk = chunks.remove(0);
+                                    ChunkLoc chunk = chunks.remove(0);
-                                    final Chunk bc = worldObj.getChunkAt(chunk.x, chunk.z);
+                                    Chunk bc = worldObj.getChunkAt(chunk.x, chunk.z);
                                     if (!bc.load(false)) {
                                         continue;
                                     }
-                                    final int X = chunk.x;
+                                    int X = chunk.x;
-                                    final int Z = chunk.z;
+                                    int Z = chunk.z;
                                     int xxb = X << 4;
                                     int zzb = Z << 4;
                                     int xxt = xxb + 15;
@@ -165,16 +140,16 @@ public class BukkitSchematicHandler extends SchematicHandler {
                                         zzt = p2z;
                                     }
                                     for (int y = sy; y <= Math.min(255, ey); y++) {
-                                        final int ry = y - sy;
+                                        int ry = y - sy;
-                                        final int i1 = (ry * width * length);
+                                        int i1 = ry * width * length;
                                         for (int z = zzb; z <= zzt; z++) {
-                                            final int rz = z - bz;
+                                            int rz = z - bz;
-                                            final int i2 = i1 + (rz * width);
+                                            int i2 = i1 + rz * width;
                                             for (int x = xxb; x <= xxt; x++) {
-                                                final int rx = x - bx;
+                                                int rx = x - bx;
-                                                final int index = i2 + rx;
+                                                int index = i2 + rx;
-                                                final Block block = worldObj.getBlockAt(x, y, z);
+                                                Block block = worldObj.getBlockAt(x, y, z);
-                                                final int id = block.getTypeId();
+                                                int id = block.getTypeId();
                                                 switch (id) {
                                                     case 0:
                                                     case 2:
@@ -243,9 +218,8 @@ public class BukkitSchematicHandler extends SchematicHandler {
                                                     case 189:
                                                     case 190:
                                                     case 191:
-                                                    case 192: {
+                                                    case 192:
                                                         break;
-                                                    }
                                                     case 54:
                                                     case 130:
                                                     case 142:
@@ -280,29 +254,24 @@ public class BukkitSchematicHandler extends SchematicHandler {
                                                     case 29:
                                                     case 33:
                                                     case 151:
-                                                    case 178: {
+                                                    case 178:
                                                         // TODO implement fully
-                                                        final BlockState state = block.getState();
+                                                        BlockState state = block.getState();
                                                         if (state != null) {
-                                                            final StateWrapper wrapper = new StateWrapper(state);
+                                                            StateWrapper wrapper = new StateWrapper(state);
-                                                            final CompoundTag rawTag = wrapper.getTag();
+                                                            CompoundTag rawTag = wrapper.getTag();
                                                             if (rawTag != null) {
-                                                                final Map<String, Tag> values = new HashMap<String, Tag>();
+                                                                Map<String, Tag> values = new HashMap<>(rawTag.getValue());
-                                                                for (final Entry<String, Tag> entry : rawTag.getValue().entrySet()) {
-                                                                    values.put(entry.getKey(), entry.getValue());
-                                                                }
                                                                 values.put("id", new StringTag("id", wrapper.getId()));
                                                                 values.put("x", new IntTag("x", x));
                                                                 values.put("y", new IntTag("y", y));
                                                                 values.put("z", new IntTag("z", z));
-                                                                final CompoundTag tileEntityTag = new CompoundTag(values);
+                                                                CompoundTag tileEntityTag = new CompoundTag(values);
                                                                 tileEntities.add(tileEntityTag);
                                                             }
                                                         }
-                                                    }
+                                                    default:
-                                                    default: {
                                                         blockData[index] = block.getData();
-                                                    }
                                                 }
                                                 // For optimization reasons, we are not supporting custom data types
                                                 // Especially since the most likely reason beyond  this range is modded servers in which the blocks
@@ -334,7 +303,7 @@ public class BukkitSchematicHandler extends SchematicHandler {
     }
 
     @Override
-    public void restoreTag(CompoundTag ct, short x, short y, short z, Schematic schem) {
+    public void restoreTile(String world, CompoundTag ct, int x, int y, int z) {
-        new StateWrapper(ct).restoreTag(x, y, z, schem);
+        new StateWrapper(ct).restoreTag(world, x, y, z);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitSetupUtils.java

@@ -29,13 +29,13 @@ public class BukkitSetupUtils extends SetupUtils {
         if (!SetupUtils.generators.isEmpty()) {
             return;
         }
-        final String testWorld = "CheckingPlotSquaredGenerator";
+        String testWorld = "CheckingPlotSquaredGenerator";
-        for (final Plugin plugin : Bukkit.getPluginManager().getPlugins()) {
+        for (Plugin plugin : Bukkit.getPluginManager().getPlugins()) {
             if (plugin.isEnabled()) {
-                final ChunkGenerator generator = plugin.getDefaultWorldGenerator(testWorld, "");
+                ChunkGenerator generator = plugin.getDefaultWorldGenerator(testWorld, "");
                 if (generator != null) {
                     PS.get().removePlotAreas(testWorld);
-                    final String name = plugin.getDescription().getName();
+                    String name = plugin.getDescription().getName();
                     GeneratorWrapper<?> wrapped;
                     if (generator instanceof GeneratorWrapper<?>) {
                         wrapped = (GeneratorWrapper<?>) generator;
@@ -49,10 +49,10 @@ public class BukkitSetupUtils extends SetupUtils {
     }
 
     @Override
-    public String setupWorld(final SetupObject object) {
+    public String setupWorld(SetupObject object) {
         SetupUtils.manager.updateGenerators();
         ConfigurationNode[] steps = object.step == null ? new ConfigurationNode[0] : object.step;
-        final String world = object.world;
+        String world = object.world;
         int type = object.type;
         String worldPath = "worlds." + object.world;
         if (!PS.get().config.contains(worldPath)) {
@@ -62,20 +62,20 @@ public class BukkitSetupUtils extends SetupUtils {
         switch (type) {
             case 2: {
                 if (object.id != null) {
-                    String areaname = object.id + "-" + object.min + "-" + object.max;
+                    String areaName = object.id + "-" + object.min + "-" + object.max;
-                    String areaPath = "areas." + areaname;
+                    String areaPath = "areas." + areaName;
                     if (!worldSection.contains(areaPath)) {
                         worldSection.createSection(areaPath);
                     }
                     ConfigurationSection areaSection = worldSection.getConfigurationSection(areaPath);
                     HashMap<String, Object> options = new HashMap<>();
-                    for (final ConfigurationNode step : steps) {
+                    for (ConfigurationNode step : steps) {
                         options.put(step.getConstant(), step.getValue());
                     }
                     options.put("generator.type", object.type);
                     options.put("generator.terrain", object.terrain);
                     options.put("generator.plugin", object.plotManager);
-                    if ((object.setupGenerator != null) && !object.setupGenerator.equals(object.plotManager)) {
+                    if (object.setupGenerator != null && !object.setupGenerator.equals(object.plotManager)) {
                         options.put("generator.init", object.setupGenerator);
                     }
                     for (Entry<String, Object> entry : options.entrySet()) {
@@ -91,42 +91,40 @@ public class BukkitSetupUtils extends SetupUtils {
                         }
                     }
                 }
-                GeneratorWrapper<?> gen = generators.get(object.setupGenerator);
+                GeneratorWrapper<?> gen = SetupUtils.generators.get(object.setupGenerator);
-                if ((gen != null) && gen.isFull()) {
+                if (gen != null && gen.isFull()) {
                     object.setupGenerator = null;
                 }
                 break;
             }
-            case 1: {
+            case 1:
-                for (final ConfigurationNode step : steps) {
+                for (ConfigurationNode step : steps) {
                     worldSection.set(step.getConstant(), step.getValue());
                 }
                 PS.get().config.set("worlds." + world + "." + "generator.type", object.type);
                 PS.get().config.set("worlds." + world + "." + "generator.terrain", object.terrain);
                 PS.get().config.set("worlds." + world + "." + "generator.plugin", object.plotManager);
-                if ((object.setupGenerator != null) && !object.setupGenerator.equals(object.plotManager)) {
+                if (object.setupGenerator != null && !object.setupGenerator.equals(object.plotManager)) {
                     PS.get().config.set("worlds." + world + "." + "generator.init", object.setupGenerator);
                 }
-                GeneratorWrapper<?> gen = generators.get(object.setupGenerator);
+                GeneratorWrapper<?> gen = SetupUtils.generators.get(object.setupGenerator);
-                if ((gen != null) && gen.isFull()) {
+                if (gen != null && gen.isFull()) {
                     object.setupGenerator = null;
                 }
                 break;
-            }
+            case 0:
-            case 0: {
+                for (ConfigurationNode step : steps) {
-                for (final ConfigurationNode step : steps) {
                     worldSection.set(step.getConstant(), step.getValue());
                 }
                 break;
-            }
         }
         try {
             PS.get().config.save(PS.get().configFile);
-        } catch (final IOException e) {
+        } catch (IOException e) {
             e.printStackTrace();
         }
         if (object.setupGenerator != null) {
-            if ((Bukkit.getPluginManager().getPlugin("Multiverse-Core") != null) && Bukkit.getPluginManager().getPlugin("Multiverse-Core")
+            if (Bukkit.getPluginManager().getPlugin("Multiverse-Core") != null && Bukkit.getPluginManager().getPlugin("Multiverse-Core")
                     .isEnabled()) {
                 Bukkit.getServer()
                         .dispatchCommand(Bukkit.getServer().getConsoleSender(), "mv create " + world + " normal -g " + object.setupGenerator);
@@ -135,27 +133,27 @@ public class BukkitSetupUtils extends SetupUtils {
                     return world;
                 }
             }
-            if ((Bukkit.getPluginManager().getPlugin("MultiWorld") != null) && Bukkit.getPluginManager().getPlugin("MultiWorld").isEnabled()) {
+            if (Bukkit.getPluginManager().getPlugin("MultiWorld") != null && Bukkit.getPluginManager().getPlugin("MultiWorld").isEnabled()) {
                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mw create " + world + " plugin:" + object.setupGenerator);
                 setGenerator(world, object.setupGenerator);
                 if (Bukkit.getWorld(world) != null) {
                     return world;
                 }
             }
-            final WorldCreator wc = new WorldCreator(object.world);
+            WorldCreator wc = new WorldCreator(object.world);
             wc.generator(object.setupGenerator);
             wc.environment(Environment.NORMAL);
             Bukkit.createWorld(wc);
             setGenerator(world, object.setupGenerator);
         } else {
-            if ((Bukkit.getPluginManager().getPlugin("Multiverse-Core") != null) && Bukkit.getPluginManager().getPlugin("Multiverse-Core")
+            if (Bukkit.getPluginManager().getPlugin("Multiverse-Core") != null && Bukkit.getPluginManager().getPlugin("Multiverse-Core")
                     .isEnabled()) {
                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mv create " + world + " normal");
                 if (Bukkit.getWorld(world) != null) {
                     return world;
                 }
             }
-            if ((Bukkit.getPluginManager().getPlugin("MultiWorld") != null) && Bukkit.getPluginManager().getPlugin("MultiWorld").isEnabled()) {
+            if (Bukkit.getPluginManager().getPlugin("MultiWorld") != null && Bukkit.getPluginManager().getPlugin("MultiWorld").isEnabled()) {
                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mw create " + world);
                 if (Bukkit.getWorld(world) != null) {
                     return world;
@@ -166,34 +164,34 @@ public class BukkitSetupUtils extends SetupUtils {
         return object.world;
     }
 
-    public void setGenerator(final String world, final String generator) {
+    public void setGenerator(String world, String generator) {
-        if ((Bukkit.getWorlds().isEmpty()) || !Bukkit.getWorlds().get(0).getName().equals(world)) {
+        if (Bukkit.getWorlds().isEmpty() || !Bukkit.getWorlds().get(0).getName().equals(world)) {
             return;
         }
-        final File file = new File("bukkit.yml").getAbsoluteFile();
+        File file = new File("bukkit.yml").getAbsoluteFile();
-        final YamlConfiguration yml = YamlConfiguration.loadConfiguration(file);
+        YamlConfiguration yml = YamlConfiguration.loadConfiguration(file);
         yml.set("worlds." + world + ".generator", generator);
         try {
             yml.save(file);
-        } catch (final IOException e) {
+        } catch (IOException e) {
             e.printStackTrace();
         }
     }
 
     @Override
-    public String getGenerator(final PlotArea plotworld) {
+    public String getGenerator(PlotArea plotworld) {
         if (SetupUtils.generators.isEmpty()) {
             updateGenerators();
         }
-        final World world = Bukkit.getWorld(plotworld.worldname);
+        World world = Bukkit.getWorld(plotworld.worldname);
         if (world == null) {
             return null;
         }
-        final ChunkGenerator generator = world.getGenerator();
+        ChunkGenerator generator = world.getGenerator();
         if (!(generator instanceof BukkitPlotGenerator)) {
             return null;
         }
-        for (final Entry<String, GeneratorWrapper<?>> entry : generators.entrySet()) {
+        for (Entry<String, GeneratorWrapper<?>> entry : SetupUtils.generators.entrySet()) {
             GeneratorWrapper<?> current = entry.getValue();
             if (current.equals(generator)) {
                 return entry.getKey();

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitTaskManager.java

@@ -7,37 +7,38 @@ import org.bukkit.Bukkit;
 public class BukkitTaskManager extends TaskManager {
 
     @Override
-    public int taskRepeat(final Runnable r, final int interval) {
+    public int taskRepeat(Runnable runnable, int interval) {
-        return BukkitMain.THIS.getServer().getScheduler().scheduleSyncRepeatingTask(BukkitMain.THIS, r, interval, interval);
+        return BukkitMain.THIS.getServer().getScheduler().scheduleSyncRepeatingTask(BukkitMain.THIS, runnable, interval, interval);
     }
 
-    @SuppressWarnings("deprecation") @Override
+    @SuppressWarnings("deprecation")
-    public int taskRepeatAsync(final Runnable r, final int interval) {
+    @Override
-        return BukkitMain.THIS.getServer().getScheduler().scheduleAsyncRepeatingTask(BukkitMain.THIS, r, interval, interval);
+    public int taskRepeatAsync(Runnable runnable, int interval) {
+        return BukkitMain.THIS.getServer().getScheduler().scheduleAsyncRepeatingTask(BukkitMain.THIS, runnable, interval, interval);
     }
 
     @Override
-    public void taskAsync(final Runnable r) {
+    public void taskAsync(Runnable runnable) {
-        BukkitMain.THIS.getServer().getScheduler().runTaskAsynchronously(BukkitMain.THIS, r).getTaskId();
+        BukkitMain.THIS.getServer().getScheduler().runTaskAsynchronously(BukkitMain.THIS, runnable).getTaskId();
     }
 
     @Override
-    public void task(final Runnable r) {
+    public void task(Runnable runnable) {
-        BukkitMain.THIS.getServer().getScheduler().runTask(BukkitMain.THIS, r).getTaskId();
+        BukkitMain.THIS.getServer().getScheduler().runTask(BukkitMain.THIS, runnable).getTaskId();
     }
 
     @Override
-    public void taskLater(final Runnable r, final int delay) {
+    public void taskLater(Runnable runnable, int delay) {
-        BukkitMain.THIS.getServer().getScheduler().runTaskLater(BukkitMain.THIS, r, delay).getTaskId();
+        BukkitMain.THIS.getServer().getScheduler().runTaskLater(BukkitMain.THIS, runnable, delay).getTaskId();
     }
 
     @Override
-    public void taskLaterAsync(final Runnable r, final int delay) {
+    public void taskLaterAsync(Runnable runnable, int delay) {
-        BukkitMain.THIS.getServer().getScheduler().runTaskLaterAsynchronously(BukkitMain.THIS, r, delay);
+        BukkitMain.THIS.getServer().getScheduler().runTaskLaterAsynchronously(BukkitMain.THIS, runnable, delay);
     }
 
     @Override
-    public void cancelTask(final int task) {
+    public void cancelTask(int task) {
         if (task != -1) {
             Bukkit.getScheduler().cancelTask(task);
         }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitUtil.java

@@ -5,9 +5,19 @@ import com.intellectualcrafters.plot.object.PlotBlock;
 import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.intellectualcrafters.plot.object.RegionWrapper;
 import com.intellectualcrafters.plot.object.schematic.PlotItem;
-import com.intellectualcrafters.plot.util.*;
+import com.intellectualcrafters.plot.util.MathMan;
+import com.intellectualcrafters.plot.util.StringComparison;
+import com.intellectualcrafters.plot.util.StringMan;
+import com.intellectualcrafters.plot.util.TaskManager;
+import com.intellectualcrafters.plot.util.UUIDHandler;
+import com.intellectualcrafters.plot.util.WorldUtil;
 import com.plotsquared.bukkit.object.BukkitPlayer;
-import org.bukkit.*;
+import java.util.Arrays;
+import java.util.List;
+import org.bukkit.Bukkit;
+import org.bukkit.Material;
+import org.bukkit.OfflinePlayer;
+import org.bukkit.World;
 import org.bukkit.block.Biome;
 import org.bukkit.block.Block;
 import org.bukkit.block.BlockState;
@@ -17,10 +27,12 @@ import org.bukkit.entity.Player;
 import org.bukkit.inventory.Inventory;
 import org.bukkit.inventory.InventoryHolder;
 import org.bukkit.inventory.ItemStack;
-import org.bukkit.material.*;
+import org.bukkit.material.MaterialData;
-
+import org.bukkit.material.Sandstone;
-import java.util.Arrays;
+import org.bukkit.material.Step;
-import java.util.List;
+import org.bukkit.material.Tree;
+import org.bukkit.material.WoodenStep;
+import org.bukkit.material.Wool;
 
 public class BukkitUtil extends WorldUtil {
 
@@ -30,26 +42,26 @@ public class BukkitUtil extends WorldUtil {
     private static Player lastPlayer = null;
     private static PlotPlayer lastPlotPlayer = null;
 
-    public static void removePlayer(final String plr) {
+    public static void removePlayer(String plr) {
         lastPlayer = null;
         lastPlotPlayer = null;
     }
 
-    public static PlotPlayer getPlayer(final OfflinePlayer op) {
+    public static PlotPlayer getPlayer(OfflinePlayer op) {
         if (op.isOnline()) {
             return getPlayer(op.getPlayer());
         }
-        final Player player = OfflinePlayerUtil.loadPlayer(op);
+        Player player = OfflinePlayerUtil.loadPlayer(op);
         player.loadData();
         return new BukkitPlayer(player, true);
     }
 
-    public static PlotPlayer getPlayer(final Player player) {
+    public static PlotPlayer getPlayer(Player player) {
         if (player == lastPlayer) {
             return lastPlotPlayer;
         }
-        final String name = player.getName();
+        String name = player.getName();
-        final PlotPlayer pp = UUIDHandler.getPlayer(name);
+        PlotPlayer pp = UUIDHandler.getPlayer(name);
         if (pp != null) {
             return pp;
         }
@@ -59,63 +71,64 @@ public class BukkitUtil extends WorldUtil {
         return lastPlotPlayer;
     }
 
-    public static Location getLocation(final org.bukkit.Location loc) {
+    public static Location getLocation(org.bukkit.Location location) {
-        return new Location(loc.getWorld().getName(), MathMan.roundInt(loc.getX()), MathMan.roundInt(loc.getY()), MathMan.roundInt(loc.getZ()));
+        return new Location(location.getWorld().getName(), MathMan.roundInt(location.getX()), MathMan.roundInt(location.getY()),
+                MathMan.roundInt(location.getZ()));
     }
 
-    public static org.bukkit.Location getLocation(final Location loc) {
+    public static org.bukkit.Location getLocation(Location location) {
-        return new org.bukkit.Location(getWorld(loc.getWorld()), loc.getX(), loc.getY(), loc.getZ());
+        return new org.bukkit.Location(getWorld(location.getWorld()), location.getX(), location.getY(), location.getZ());
     }
 
-    public static World getWorld(final String string) {
+    public static World getWorld(String string) {
         if (StringMan.isEqual(string, lastString)) {
             if (lastWorld != null) {
                 return lastWorld;
             }
         }
-        final World world = Bukkit.getWorld(string);
+        World world = Bukkit.getWorld(string);
         lastString = string;
         lastWorld = world;
         return world;
     }
 
-    public static String getWorld(final Entity entity) {
+    public static String getWorld(Entity entity) {
         return entity.getWorld().getName();
     }
 
-    public static List<Entity> getEntities(final String worldname) {
+    public static List<Entity> getEntities(String worldName) {
-        return getWorld(worldname).getEntities();
+        return getWorld(worldName).getEntities();
     }
 
-    public static Location getLocation(final Entity entity) {
+    public static Location getLocation(Entity entity) {
-        final org.bukkit.Location loc = entity.getLocation();
+        org.bukkit.Location loc = entity.getLocation();
-        final String world = loc.getWorld().getName();
+        String world = loc.getWorld().getName();
         return new Location(world, loc.getBlockX(), loc.getBlockY(), loc.getBlockZ());
     }
 
-    public static Location getLocationFull(final Entity entity) {
+    public static Location getLocationFull(Entity entity) {
-        final org.bukkit.Location loc = entity.getLocation();
+        org.bukkit.Location loc = entity.getLocation();
         return new Location(loc.getWorld().getName(), MathMan.roundInt(loc.getX()), MathMan.roundInt(loc.getY()), MathMan.roundInt(loc.getZ()),
                 loc.getYaw(), loc.getPitch());
     }
 
     @Override
-    public boolean isWorld(final String world) {
+    public boolean isWorld(String worldName) {
-        return getWorld(world) != null;
+        return getWorld(worldName) != null;
     }
 
     @Override
-    public String getBiome(final String world, final int x, final int z) {
+    public String getBiome(String world, int x, int z) {
         return getWorld(world).getBiome(x, z).name();
     }
 
     @Override
-    public void setSign(final String worldname, final int x, final int y, final int z, final String[] lines) {
+    public void setSign(String worldName, int x, int y, int z, String[] lines) {
-        final World world = getWorld(worldname);
+        World world = getWorld(worldName);
-        final Block block = world.getBlockAt(x, y, z);
+        Block block = world.getBlockAt(x, y, z);
         //        block.setType(Material.AIR);
         block.setTypeIdAndData(Material.WALL_SIGN.getId(), (byte) 2, false);
-        final BlockState blockstate = block.getState();
+        BlockState blockstate = block.getState();
         if (blockstate instanceof Sign) {
             final Sign sign = (Sign) blockstate;
             for (int i = 0; i < lines.length; i++) {
@@ -132,11 +145,11 @@ public class BukkitUtil extends WorldUtil {
     }
 
     @Override
-    public String[] getSign(final Location loc) {
+    public String[] getSign(Location location) {
-        final Block block = getWorld(loc.getWorld()).getBlockAt(loc.getX(), loc.getY(), loc.getZ());
+        Block block = getWorld(location.getWorld()).getBlockAt(location.getX(), location.getY(), location.getZ());
         if (block != null) {
             if (block.getState() instanceof Sign) {
-                final Sign sign = (Sign) block.getState();
+                Sign sign = (Sign) block.getState();
                 return sign.getLines();
             }
         }
@@ -144,30 +157,51 @@ public class BukkitUtil extends WorldUtil {
     }
 
     @Override
-    public Location getSpawn(final String world) {
+    public Location getSpawn(PlotPlayer pp) {
-        final org.bukkit.Location temp = getWorld(world).getSpawnLocation();
+        return getLocation(((BukkitPlayer) pp).player.getBedSpawnLocation());
+    }
+
+    @Override
+    public Location getSpawn(String world) {
+        org.bukkit.Location temp = getWorld(world).getSpawnLocation();
         return new Location(world, temp.getBlockX(), temp.getBlockY(), temp.getBlockZ(), temp.getYaw(), temp.getPitch());
     }
 
     @Override
-    public int getHighestBlock(final String world, final int x, final int z) {
+    public void setSpawn(Location location) {
+        World world = getWorld(location.getWorld());
+        if (world != null) {
+            world.setSpawnLocation(location.getX(), location.getY(), location.getZ());
+        }
+    }
+
+    @Override
+    public void saveWorld(String worldName) {
+        World world = getWorld(worldName);
+        if (world != null) {
+            world.save();
+        }
+    }
+
+    @Override
+    public int getHighestBlock(String world, int x, int z) {
         return getWorld(world).getHighestBlockAt(x, z).getY();
     }
 
     @Override
-    public int getBiomeFromString(final String biomeStr) {
+    public int getBiomeFromString(String biomeStr) {
         try {
-            final Biome biome = Biome.valueOf(biomeStr.toUpperCase());
+            Biome biome = Biome.valueOf(biomeStr.toUpperCase());
             return Arrays.asList(Biome.values()).indexOf(biome);
-        } catch (final IllegalArgumentException e) {
+        } catch (IllegalArgumentException e) {
             return -1;
         }
     }
 
     @Override
     public String[] getBiomeList() {
-        final Biome[] biomes = Biome.values();
+        Biome[] biomes = Biome.values();
-        final String[] list = new String[biomes.length];
+        String[] list = new String[biomes.length];
         for (int i = 0; i < biomes.length; i++) {
             list[i] = biomes[i].name();
         }
@@ -175,18 +209,18 @@ public class BukkitUtil extends WorldUtil {
     }
 
     @Override
-    public boolean addItems(final String worldname, final PlotItem items) {
+    public boolean addItems(String worldName, PlotItem items) {
-        final World world = getWorld(worldname);
+        World world = getWorld(worldName);
-        final Block block = world.getBlockAt(items.x, items.y, items.z);
+        Block block = world.getBlockAt(items.x, items.y, items.z);
         if (block == null) {
             return false;
         }
-        final BlockState state = block.getState();
+        BlockState state = block.getState();
         if (state instanceof InventoryHolder) {
-            final InventoryHolder holder = (InventoryHolder) state;
+            InventoryHolder holder = (InventoryHolder) state;
-            final Inventory inv = holder.getInventory();
+            Inventory inv = holder.getInventory();
             for (int i = 0; i < items.id.length; i++) {
-                final ItemStack item = new ItemStack(items.id[i], items.amount[i], items.data[i]);
+                ItemStack item = new ItemStack(items.id[i], items.amount[i], items.data[i]);
                 inv.addItem(item);
             }
             state.update(true);
@@ -196,11 +230,11 @@ public class BukkitUtil extends WorldUtil {
     }
 
     @Override
-    public boolean isBlockSolid(final PlotBlock block) {
+    public boolean isBlockSolid(PlotBlock block) {
         try {
-            final Material material = Material.getMaterial(block.id);
+            Material material = Material.getMaterial(block.id);
             if (material.isBlock() && material.isSolid() && !material.hasGravity()) {
-                final Class<? extends MaterialData> data = material.getData();
+                Class<? extends MaterialData> data = material.getData();
                 if (data.equals(MaterialData.class) && !material.isTransparent() && material.isOccluding()
                         || data.equals(Tree.class)
                         || data.equals(Sandstone.class)
@@ -217,16 +251,16 @@ public class BukkitUtil extends WorldUtil {
                 }
             }
             return false;
-        } catch (final Exception e) {
+        } catch (Exception e) {
             return false;
         }
     }
 
     @Override
-    public String getClosestMatchingName(final PlotBlock block) {
+    public String getClosestMatchingName(PlotBlock block) {
         try {
             return Material.getMaterial(block.id).name();
-        } catch (final Exception e) {
+        } catch (Exception e) {
             return null;
         }
     }
@@ -234,13 +268,14 @@ public class BukkitUtil extends WorldUtil {
     @Override
     public StringComparison<PlotBlock>.ComparisonResult getClosestBlock(String name) {
         try {
-            final Material material = Material.valueOf(name.toUpperCase());
+            Material material = Material.valueOf(name.toUpperCase());
             return new StringComparison<PlotBlock>().new ComparisonResult(0, new PlotBlock((short) material.getId(), (byte) 0));
         } catch (IllegalArgumentException e) {
+            //ignored
         }
         try {
             byte data;
-            final String[] split = name.split(":");
+            String[] split = name.split(":");
             if (split.length == 2) {
                 data = Byte.parseByte(split[1]);
                 name = split[0];
@@ -253,23 +288,24 @@ public class BukkitUtil extends WorldUtil {
                 id = Short.parseShort(split[0]);
                 match = 0;
             } else {
-                final StringComparison<Material>.ComparisonResult comparison = new StringComparison<>(name, Material.values()).getBestMatchAdvanced();
+                StringComparison<Material>.ComparisonResult comparison = new StringComparison<>(name, Material.values()).getBestMatchAdvanced();
                 match = comparison.match;
                 id = (short) comparison.best.getId();
             }
-            final PlotBlock block = new PlotBlock(id, data);
+            PlotBlock block = new PlotBlock(id, data);
-            final StringComparison<PlotBlock> outer = new StringComparison<>();
+            StringComparison<PlotBlock> outer = new StringComparison<>();
             return outer.new ComparisonResult(match, block);
 
         } catch (NumberFormatException e) {
+            //ignored
         }
         return null;
     }
 
     @Override
-    public void setBiomes(final String worldname, RegionWrapper region, final String biomeStr) {
+    public void setBiomes(String worldName, RegionWrapper region, String biomeStr) {
-        final World world = getWorld(worldname);
+        World world = getWorld(worldName);
-        final Biome biome = Biome.valueOf(biomeStr.toUpperCase());
+        Biome biome = Biome.valueOf(biomeStr.toUpperCase());
         for (int x = region.minX; x <= region.maxX; x++) {
             for (int z = region.minZ; z <= region.maxZ; z++) {
                 world.setBiome(x, z, biome);
@@ -278,11 +314,11 @@ public class BukkitUtil extends WorldUtil {
     }
 
     @Override
-    public PlotBlock getBlock(final Location loc) {
+    public PlotBlock getBlock(Location location) {
-        final World world = getWorld(loc.getWorld());
+        World world = getWorld(location.getWorld());
-        final Block block = world.getBlockAt(loc.getX(), loc.getY(), loc.getZ());
+        Block block = world.getBlockAt(location.getX(), location.getY(), location.getZ());
         if (block == null) {
-            return new PlotBlock((short) 0, (byte) 0);
+            return PlotBlock.EVERYTHING;
         }
         return new PlotBlock((short) block.getTypeId(), block.getData());
     }

Bukkit/src/main/java/com/plotsquared/bukkit/util/Metrics.java

@@ -1,25 +1,12 @@
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// PlotSquared - A plot manager and world generator for the Bukkit API                             /
-// Copyright (c) 2014 IntellectualSites/IntellectualCrafters                                       /
-//                                                                                                 /
-// This program is free software; you can redistribute it and/or modify                            /
-// it under the terms of the GNU General Public License as published by                            /
-// the Free Software Foundation; either version 3 of the License, or                               /
-// (at your option) any later version.                                                             /
-//                                                                                                 /
-// This program is distributed in the hope that it will be useful,                                 /
-// but WITHOUT ANY WARRANTY; without even the implied warranty of                                  /
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the                                   /
-// GNU General Public License for more details.                                                    /
-//                                                                                                 /
-// You should have received a copy of the GNU General Public License                               /
-// along with this program; if not, write to the Free Software Foundation,                         /
-// Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA                               /
-//                                                                                                 /
-// You can contact us via: support@intellectualsites.com                                           /
-////////////////////////////////////////////////////////////////////////////////////////////////////
 package com.plotsquared.bukkit.util;
 
+import com.intellectualcrafters.plot.PS;
+import org.bukkit.Bukkit;
+import org.bukkit.entity.Player;
+import org.bukkit.plugin.Plugin;
+import org.bukkit.plugin.PluginDescriptionFile;
+import org.bukkit.scheduler.BukkitTask;
+
 import java.io.BufferedReader;
 import java.io.ByteArrayOutputStream;
 import java.io.File;
@@ -41,109 +28,74 @@ import java.util.UUID;
 import java.util.logging.Level;
 import java.util.zip.GZIPOutputStream;
 
-import org.bukkit.Bukkit;
-import org.bukkit.entity.Player;
-import org.bukkit.plugin.Plugin;
-import org.bukkit.plugin.PluginDescriptionFile;
-import org.bukkit.scheduler.BukkitTask;
-
-import com.intellectualcrafters.configuration.InvalidConfigurationException;
-import com.intellectualcrafters.configuration.file.YamlConfiguration;
-import com.intellectualcrafters.plot.PS;
-
 public class Metrics {
 
     /**
-     * The current revision number
+     * The current revision number.
      */
-    private final static int REVISION = 7;
+    private static final int REVISION = 7;
     /**
-     * The base url of the metrics domain
+     * The base url of the metrics domain.
      */
     private static final String BASE_URL = "http://report.mcstats.org";
     /**
-     * The url used to report a server's status
+     * The url used to report a server's status.
      */
     private static final String REPORT_URL = "/plugin/%s";
     /**
-     * Interval of time to ping (in minutes)
+     * Interval of time to ping (in minutes).
      */
     private static final int PING_INTERVAL = 15;
     /**
-     * The plugin this metrics submits for
+     * The plugin this metrics submits for.
      */
     private final Plugin plugin;
     /**
-     * All of the custom graphs to submit to metrics
+     * All of the custom graphs to submit to metrics.
      */
     private final Set<Graph> graphs = Collections.synchronizedSet(new HashSet<Graph>());
     /**
-     * The plugin configuration file
+     * Unique server id.
-     */
-    private final YamlConfiguration configuration;
-    /**
-     * The plugin configuration file
-     */
-    private final File configurationFile;
-    /**
-     * Unique server id
      */
     private final String guid;
     /**
-     * Debug mode
+     * Debug mode.
      */
     private final boolean debug;
     /**
-     * Lock for synchronization
+     * The scheduled task.
-     */
-    private final Object optOutLock = new Object();
-    /**
-     * The scheduled task
      */
     private volatile BukkitTask task = null;
 
-    public Metrics(final Plugin plugin) throws IOException {
+    public Metrics(Plugin plugin) {
         if (plugin == null) {
             throw new IllegalArgumentException("Plugin cannot be null");
         }
         this.plugin = plugin;
-        // load the config
+        this.guid = UUID.randomUUID().toString();
-        configurationFile = getConfigFile();
+        this.debug = false;
-        configuration = YamlConfiguration.loadConfiguration(configurationFile);
-        // add some defaults
-        configuration.addDefault("opt-out", false);
-        configuration.addDefault("guid", UUID.randomUUID().toString());
-        configuration.addDefault("debug", false);
-        // Do we need to create the file?
-        if (configuration.get("guid", null) == null) {
-            configuration.options().header("http://mcstats.org").copyDefaults(true);
-            configuration.save(configurationFile);
-        }
-        // Load the guid then
-        guid = configuration.getString("guid");
-        debug = configuration.getBoolean("debug", false);
     }
 
     /**
-     * GZip compress a string of bytes
+     * GZip compress a string of bytes.
      *
      * @param input
      *
      * @return byte[] the file as a byte array
      */
-    public static byte[] gzip(final String input) {
+    public static byte[] gzip(String input) {
-        final ByteArrayOutputStream baos = new ByteArrayOutputStream();
+        ByteArrayOutputStream baos = new ByteArrayOutputStream();
         GZIPOutputStream gzos = null;
         try {
             gzos = new GZIPOutputStream(baos);
             gzos.write(input.getBytes("UTF-8"));
-        } catch (final IOException e) {
+        } catch (IOException e) {
             e.printStackTrace();
         } finally {
             if (gzos != null) {
                 try {
                     gzos.close();
-                } catch (final IOException ignore) {
+                } catch (IOException ignore) {
                 }
             }
         }
@@ -157,16 +109,15 @@ public class Metrics {
      * @param key
      * @param value
      *
-     * @throws UnsupportedEncodingException
      */
-    private static void appendJSONPair(final StringBuilder json, final String key, final String value) {
+    private static void appendJSONPair(StringBuilder json, String key, String value) {
         boolean isValueNumeric = false;
         try {
             if (value.equals("0") || !value.endsWith("0")) {
                 Double.parseDouble(value);
                 isValueNumeric = true;
             }
-        } catch (final NumberFormatException e) {
+        } catch (NumberFormatException e) {
             isValueNumeric = false;
         }
         if (json.charAt(json.length() - 1) != '{') {
@@ -188,11 +139,11 @@ public class Metrics {
      *
      * @return String
      */
-    private static String escapeJSON(final String text) {
+    private static String escapeJSON(String text) {
-        final StringBuilder builder = new StringBuilder();
+        StringBuilder builder = new StringBuilder();
         builder.append('"');
         for (int index = 0; index < text.length(); index++) {
-            final char chr = text.charAt(index);
+            char chr = text.charAt(index);
             switch (chr) {
                 case '"':
                 case '\\':
@@ -213,7 +164,7 @@ public class Metrics {
                     break;
                 default:
                     if (chr < ' ') {
-                        final String t = "000" + Integer.toHexString(chr);
+                        String t = "000" + Integer.toHexString(chr);
                         builder.append("\\u" + t.substring(t.length() - 4));
                     } else {
                         builder.append(chr);
@@ -232,7 +183,7 @@ public class Metrics {
      *
      * @return the encoded text, as UTF-8
      */
-    private static String urlEncode(final String text) throws UnsupportedEncodingException {
+    private static String urlEncode(String text) throws UnsupportedEncodingException {
         return URLEncoder.encode(text, "UTF-8");
     }
 
@@ -244,14 +195,14 @@ public class Metrics {
      *
      * @return Graph object created. Will never return NULL under normal circumstances unless bad parameters are given
      */
-    public Graph createGraph(final String name) {
+    public Graph createGraph(String name) {
         if (name == null) {
             throw new IllegalArgumentException("Graph name cannot be null");
         }
         // Construct the graph object
-        final Graph graph = new Graph(name);
+        Graph graph = new Graph(name);
         // Now we can add our graph
-        graphs.add(graph);
+        this.graphs.add(graph);
         // and return back
         return graph;
     }
@@ -261,11 +212,11 @@ public class Metrics {
      *
      * @param graph The name of the graph
      */
-    public void addGraph(final Graph graph) {
+    public void addGraph(Graph graph) {
         if (graph == null) {
             throw new IllegalArgumentException("Graph cannot be null");
         }
-        graphs.add(graph);
+        this.graphs.add(graph);
     }
 
     /**
@@ -276,86 +227,31 @@ public class Metrics {
      * @return True if statistics measuring is running, otherwise false.
      */
     public boolean start() {
-        synchronized (optOutLock) {
+        // Is metrics already running?
-            // Did we opt out?
+        if (this.task != null) {
-            if (isOptOut()) {
-                return false;
-            }
-            // Is metrics already running?
-            if (task != null) {
-                return true;
-            }
-            // Begin hitting the server with glorious data
-            task = plugin.getServer().getScheduler().runTaskTimerAsynchronously(plugin, new Runnable() {
-                private boolean firstPost = true;
-
-                @Override
-                public void run() {
-                    try {
-                        // This has to be synchronized or it can collide
-                        // with
-                        // the disable method.
-                        synchronized (optOutLock) {
-                            // Disable Task, if it is running and the
-                            // server
-                            // owner decided to opt-out
-                            if (isOptOut() && task != null) {
-                                task.cancel();
-                                task = null;
-                                // Tell all plotters to stop gathering
-                                // information.
-                                for (final Graph graph : graphs) {
-                                    graph.onOptOut();
-                                }
-                            }
-                        }
-                        // We use the inverse of firstPost because if it
-                        // is the
-                        // first time we are posting,
-                        // it is not a interval ping, so it evaluates to
-                        // FALSE
-                        // Each time thereafter it will evaluate to
-                        // TRUE, i.e
-                        // PING!
-                        postPlugin(!firstPost);
-                        // After the first post we set firstPost to
-                        // false
-                        // Each post thereafter will be a ping
-                        firstPost = false;
-                    } catch (final IOException e) {
-                        if (debug) {
-                            Bukkit.getLogger().log(Level.INFO, "[Metrics] " + e.getMessage());
-                        }
-                    }
-                }
-            }, 0, PING_INTERVAL * 1200);
             return true;
         }
-    }
+        // Begin hitting the server with glorious data
+        this.task = this.plugin.getServer().getScheduler().runTaskTimerAsynchronously(this.plugin, new Runnable() {
+            private boolean firstPost = true;
 
-    /**
+            @Override
-     * Has the server owner denied plugin metrics?
+            public void run() {
-     *
+                try {
-     * @return true if metrics should be opted out of it
+                    postPlugin(!this.firstPost);
-     */
+                    // After the first post we set firstPost to
-    public boolean isOptOut() {
+                    // false
-        synchronized (optOutLock) {
+                    // Each post thereafter will be a ping
-            try {
+                    this.firstPost = false;
-                // Reload the metrics file
+                } catch (IOException e) {
-                configuration.load(getConfigFile());
+                    e.printStackTrace();
-            } catch (final IOException ex) {
+                    if (Metrics.this.debug) {
-                if (debug) {
+                        Bukkit.getLogger().log(Level.INFO, "[Metrics] " + e.getMessage());
-                    Bukkit.getLogger().log(Level.INFO, "[Metrics] " + ex.getMessage());
+                    }
                 }
-                return true;
-            } catch (final InvalidConfigurationException ex) {
-                if (debug) {
-                    Bukkit.getLogger().log(Level.INFO, "[Metrics] " + ex.getMessage());
-                }
-                return true;
             }
-            return configuration.getBoolean("opt-out", false);
+        }, 0, PING_INTERVAL * 1200);
-        }
+        return true;
     }
 
     /**
@@ -363,48 +259,28 @@ public class Metrics {
      *
      * @throws java.io.IOException
      */
-    public void enable() throws IOException {
+    public void enable() {
-        // This has to be synchronized or it can collide with the check in the
+        // Enable Task, if it is not running
-        // task.
+        if (this.task == null) {
-        synchronized (optOutLock) {
+            start();
-            // Check if the server owner has already set opt-out, if not, set
-            // it.
-            if (isOptOut()) {
-                configuration.set("opt-out", false);
-                configuration.save(configurationFile);
-            }
-            // Enable Task, if it is not running
-            if (task == null) {
-                start();
-            }
         }
     }
 
     /**
      * Disables metrics for the server by setting "opt-out" to true in the config file and canceling the metrics task.
      *
-     * @throws java.io.IOException
      */
-    public void disable() throws IOException {
+    public void disable() {
-        // This has to be synchronized or it can collide with the check in the
+        // Disable Task, if it is running
-        // task.
+        if (this.task != null) {
-        synchronized (optOutLock) {
+            this.task.cancel();
-            // Check if the server owner has already set opt-out, if not, set
+            this.task = null;
-            // it.
-            if (!isOptOut()) {
-                configuration.set("opt-out", true);
-                configuration.save(configurationFile);
-            }
-            // Disable Task, if it is running
-            if (task != null) {
-                task.cancel();
-                task = null;
-            }
         }
     }
 
     /**
-     * Gets the File object of the config file that should be used to store data such as the GUID and opt-out status
+     * Gets the File object of the config file that should be used to store
+     * data such as the GUID and opt-out status.
      *
      * @return the File object for the config file
      */
@@ -415,26 +291,21 @@ public class Metrics {
         // plugin.getDataFolder() => base/plugins/PluginA/
         // pluginsFolder => base/plugins/
         // The base is not necessarily relative to the startup directory.
-        final File pluginsFolder = plugin.getDataFolder().getParentFile();
+        File pluginsFolder = this.plugin.getDataFolder().getParentFile();
         // return => base/plugins/PluginMetrics/config.yml
         return new File(new File(pluginsFolder, "PluginMetrics"), "config.yml");
     }
 
     /**
-     * Generic method that posts a plugin to the metrics website
+     * Generic method that posts a plugin to the metrics website.
      */
-    private void postPlugin(final boolean isPing) throws IOException {
+    private void postPlugin(boolean isPing) throws IOException {
         // Server software specific section
-        final PluginDescriptionFile description = plugin.getDescription();
+        PluginDescriptionFile description = this.plugin.getDescription();
-        final String pluginName = description.getName();
+        String pluginName = description.getName();
-        final boolean onlineMode = Bukkit.getServer().getOnlineMode(); // TRUE
+        boolean onlineMode = Bukkit.getServer().getOnlineMode(); // TRUE if online mode is enabled
-        // if
+        String pluginVersion = description.getVersion();
-        // online
+        String serverVersion = Bukkit.getVersion();
-        // mode
-        // is
-        // enabled
-        final String pluginVersion = description.getVersion();
-        final String serverVersion = Bukkit.getVersion();
         int playersOnline = 0;
         try {
             if (Bukkit.class.getMethod("getOnlinePlayers", new Class<?>[0]).getReturnType() == Collection.class) {
@@ -443,24 +314,24 @@ public class Metrics {
                 playersOnline = ((Player[]) Bukkit.class.getMethod("getOnlinePlayers", new Class<?>[0]).invoke(null)).length;
             }
         } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException ex) {
+            ex.printStackTrace();
         }
         // END server software specific section -- all code below does not use
         // any code outside of this class / Java
         // Construct the post data
-        final StringBuilder json = new StringBuilder(1024);
+        StringBuilder json = new StringBuilder(1024);
         json.append('{');
-        // The plugin's description file containg all of the plugin data such as
+        // The plugin's description file containing all of the plugin data such as name, version, author, etc
-        // name, version, author, etc
+        appendJSONPair(json, "guid", this.guid);
-        appendJSONPair(json, "guid", guid);
         appendJSONPair(json, "plugin_version", pluginVersion);
         appendJSONPair(json, "server_version", serverVersion);
         appendJSONPair(json, "players_online", Integer.toString(playersOnline));
         // New data as of R6
-        final String osname = System.getProperty("os.name");
+        String osname = System.getProperty("os.name");
         String osarch = System.getProperty("os.arch");
-        final String osversion = System.getProperty("os.version");
+        String osversion = System.getProperty("os.version");
-        final String java_version = System.getProperty("java.version");
+        String java_version = System.getProperty("java.version");
-        final int coreCount = Runtime.getRuntime().availableProcessors();
+        int coreCount = Runtime.getRuntime().availableProcessors();
         // normalize os arch .. amd64 -> x86_64
         if (osarch.equals("amd64")) {
             osarch = "x86_64";
@@ -475,8 +346,8 @@ public class Metrics {
         if (isPing) {
             appendJSONPair(json, "ping", "1");
         }
-        if (!graphs.isEmpty()) {
+        if (!this.graphs.isEmpty()) {
-            synchronized (graphs) {
+            synchronized (this.graphs) {
                 json.append(',');
                 json.append('"');
                 json.append("graphs");
@@ -484,10 +355,10 @@ public class Metrics {
                 json.append(':');
                 json.append('{');
                 boolean firstGraph = true;
-                for (final Graph graph : graphs) {
+                for (Graph graph : this.graphs) {
-                    final StringBuilder graphJson = new StringBuilder();
+                    StringBuilder graphJson = new StringBuilder();
                     graphJson.append('{');
-                    for (final Plotter plotter : graph.getPlotters()) {
+                    for (Plotter plotter : graph.getPlotters()) {
                         appendJSONPair(graphJson, plotter.getColumnName(), Integer.toString(plotter.getValue()));
                     }
                     graphJson.append('}');
@@ -505,7 +376,7 @@ public class Metrics {
         // close json
         json.append('}');
         // Create the url
-        final URL url = new URL(BASE_URL + String.format(REPORT_URL, urlEncode(pluginName)));
+        URL url = new URL(BASE_URL + String.format(REPORT_URL, urlEncode(pluginName)));
         // Connect to the website
         URLConnection connection;
         // Mineshafter creates a socks proxy, so we can safely bypass it
@@ -515,8 +386,8 @@ public class Metrics {
         } else {
             connection = url.openConnection();
         }
-        final byte[] uncompressed = json.toString().getBytes();
+        byte[] uncompressed = json.toString().getBytes();
-        final byte[] compressed = gzip(json.toString());
+        byte[] compressed = gzip(json.toString());
         // Headers
         connection.addRequestProperty("User-Agent", "MCStats/" + REVISION);
         connection.addRequestProperty("Content-Type", "application/json");
@@ -525,36 +396,44 @@ public class Metrics {
         connection.addRequestProperty("Accept", "application/json");
         connection.addRequestProperty("Connection", "close");
         connection.setDoOutput(true);
-        if (debug) {
+        if (this.debug) {
             PS.debug("[Metrics] Prepared request for " + pluginName + " uncompressed=" + uncompressed.length + " compressed=" + compressed.length);
         }
-        // Write the data
+        try {
-        String response;
+            try (OutputStream os = connection.getOutputStream()) {
-        try (OutputStream os = connection.getOutputStream();
+                os.write(compressed);
-                BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {
+                os.flush();
-            os.write(compressed);
-            os.flush();
-            // Now read the response
-            response = reader.readLine();
-        }
-        if (response == null || response.startsWith("ERR") || response.startsWith("7")) {
-            if (response == null) {
-                response = "null";
-            } else if (response.startsWith("7")) {
-                response = response.substring(response.startsWith("7,") ? 2 : 1);
             }
-            throw new IOException(response);
+            String response;
-        } else {
+            try (BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {
-            // Is this the first update this hour?
+                response = reader.readLine();
-            if ("1".equals(response) || response.contains("This is your first update this hour")) {
+                if (this.debug) {
-                synchronized (graphs) {
+                    PS.debug("[Metrics] Response for " + pluginName + ": " + response);
-                    for (final Graph graph : graphs) {
+                }
-                        for (final Plotter plotter : graph.getPlotters()) {
+            }
-                            plotter.reset();
+            if (response == null || response.startsWith("ERR") || response.startsWith("7")) {
+                if (response == null) {
+                    response = "null";
+                } else if (response.startsWith("7")) {
+                    response = response.substring(response.startsWith("7,") ? 2 : 1);
+                }
+                throw new IOException(response);
+            } else {
+                // Is this the first update this hour?
+                if ("1".equals(response) || response.contains("This is your first update this hour")) {
+                    synchronized (this.graphs) {
+                        for (Graph graph : this.graphs) {
+                            for (Plotter plotter : graph.getPlotters()) {
+                                plotter.reset();
+                            }
                         }
                     }
                 }
             }
+        } catch (Exception e) {
+            if (this.debug) {
+                e.printStackTrace();
+            }
         }
     }
 
@@ -587,7 +466,7 @@ public class Metrics {
          */
         private final Set<Plotter> plotters = new LinkedHashSet<>();
 
-        private Graph(final String name) {
+        private Graph(String name) {
             this.name = name;
         }
 
@@ -597,7 +476,7 @@ public class Metrics {
          * @return the Graph's name
          */
         public String getName() {
-            return name;
+            return this.name;
         }
 
         /**
@@ -605,8 +484,8 @@ public class Metrics {
          *
          * @param plotter the plotter to add to the graph
          */
-        public void addPlotter(final Plotter plotter) {
+        public void addPlotter(Plotter plotter) {
-            plotters.add(plotter);
+            this.plotters.add(plotter);
         }
 
         /**
@@ -614,8 +493,8 @@ public class Metrics {
          *
          * @param plotter the plotter to remove from the graph
          */
-        public void removePlotter(final Plotter plotter) {
+        public void removePlotter(Plotter plotter) {
-            plotters.remove(plotter);
+            this.plotters.remove(plotter);
         }
 
         /**
@@ -624,21 +503,21 @@ public class Metrics {
          * @return an unmodifiable {@link java.util.Set} of the plotter objects
          */
         public Set<Plotter> getPlotters() {
-            return Collections.unmodifiableSet(plotters);
+            return Collections.unmodifiableSet(this.plotters);
         }
 
         @Override
         public int hashCode() {
-            return name.hashCode();
+            return this.name.hashCode();
         }
 
         @Override
-        public boolean equals(final Object object) {
+        public boolean equals(Object object) {
             if (!(object instanceof Graph)) {
                 return false;
             }
-            final Graph graph = (Graph) object;
+            Graph graph = (Graph) object;
-            return graph.name.equals(name);
+            return graph.name.equals(this.name);
         }
 
         /**
@@ -651,7 +530,7 @@ public class Metrics {
     /**
      * Interface used to collect custom data for a plugin
      */
-    public static abstract class Plotter {
+    public abstract static class Plotter {
 
         /**
          * The plot's name
@@ -670,7 +549,7 @@ public class Metrics {
          *
          * @param name the name of the plotter to use, which will show up on the website
          */
-        public Plotter(final String name) {
+        public Plotter(String name) {
             this.name = name;
         }
 
@@ -689,7 +568,7 @@ public class Metrics {
          * @return the plotted point's column name
          */
         public String getColumnName() {
-            return name;
+            return this.name;
         }
 
         /**
@@ -704,12 +583,12 @@ public class Metrics {
         }
 
         @Override
-        public boolean equals(final Object object) {
+        public boolean equals(Object object) {
             if (!(object instanceof Plotter)) {
                 return false;
             }
-            final Plotter plotter = (Plotter) object;
+            Plotter plotter = (Plotter) object;
-            return plotter.name.equals(name) && plotter.getValue() == getValue();
+            return plotter.name.equals(this.name) && plotter.getValue() == getValue();
         }
     }
-}
+}

Bukkit/src/main/java/com/plotsquared/bukkit/util/NbtFactory.java

@@ -15,12 +15,27 @@ import org.bukkit.Material;
 import org.bukkit.Server;
 import org.bukkit.inventory.ItemStack;
 
-import java.io.*;
+import java.io.BufferedInputStream;
+import java.io.DataInput;
+import java.io.DataInputStream;
+import java.io.DataOutput;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
-import java.util.*;
+import java.util.AbstractList;
+import java.util.AbstractMap;
+import java.util.AbstractSet;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
 import java.util.concurrent.ConcurrentMap;
 import java.util.zip.GZIPInputStream;
 import java.util.zip.GZIPOutputStream;
@@ -48,39 +63,43 @@ public class NbtFactory {
     // Loading/saving compounds
     private LoadCompoundMethod LOAD_COMPOUND;
     private Method SAVE_COMPOUND;
+
     /**
      * Construct an instance of the NBT factory by deducing the class of NBTBase.
      */
     private NbtFactory() {
-        if (BASE_CLASS == null) {
+        if (this.BASE_CLASS == null) {
             try {
                 // Keep in mind that I do use hard-coded field names - but it's okay as long as we're dealing
                 // with CraftBukkit or its derivatives. This does not work in MCPC+ however.
-                final ClassLoader loader = NbtFactory.class.getClassLoader();
+                ClassLoader loader = NbtFactory.class.getClassLoader();
 
-                final String packageName = getPackageName();
+                String packageName = getPackageName();
-                final Class<?> offlinePlayer = loader.loadClass(packageName + ".CraftOfflinePlayer");
+                Class<?> offlinePlayer = loader.loadClass(packageName + ".CraftOfflinePlayer");
 
                 // Prepare NBT
-                COMPOUND_CLASS = getMethod(0, Modifier.STATIC, offlinePlayer, "getData").getReturnType();
+                this.COMPOUND_CLASS = getMethod(0, Modifier.STATIC, offlinePlayer, "getData").getReturnType();
-                BASE_CLASS = COMPOUND_CLASS.getSuperclass();
+                this.BASE_CLASS = this.COMPOUND_CLASS.getSuperclass();
-                NBT_GET_TYPE = getMethod(0, Modifier.STATIC, BASE_CLASS, "getTypeId");
+                this.NBT_GET_TYPE = getMethod(0, Modifier.STATIC, this.BASE_CLASS, "getTypeId");
-                NBT_CREATE_TAG = getMethod(Modifier.STATIC, 0, BASE_CLASS, "createTag", byte.class);
+                this.NBT_CREATE_TAG = getMethod(Modifier.STATIC, 0, this.BASE_CLASS, "createTag", byte.class);
 
                 // Prepare CraftItemStack
-                CRAFT_STACK = loader.loadClass(packageName + ".inventory.CraftItemStack");
+                this.CRAFT_STACK = loader.loadClass(packageName + ".inventory.CraftItemStack");
-                CRAFT_HANDLE = getField(null, CRAFT_STACK, "handle");
+                this.CRAFT_HANDLE = getField(null, this.CRAFT_STACK, "handle");
-                STACK_TAG = getField(null, CRAFT_HANDLE.getType(), "tag");
+                this.STACK_TAG = getField(null, this.CRAFT_HANDLE.getType(), "tag");
 
                 // Loading/saving
-                final String nmsPackage = BASE_CLASS.getPackage().getName();
+                String nmsPackage = this.BASE_CLASS.getPackage().getName();
                 initializeNMS(loader, nmsPackage);
 
-                LOAD_COMPOUND = READ_LIMITER_CLASS != null ? new LoadMethodSkinUpdate(STREAM_TOOLS, READ_LIMITER_CLASS) :
+                if (this.READ_LIMITER_CLASS != null) {
-                        new LoadMethodWorldUpdate(STREAM_TOOLS);
+                    this.LOAD_COMPOUND = new LoadMethodSkinUpdate(this.STREAM_TOOLS, this.READ_LIMITER_CLASS);
-                SAVE_COMPOUND = getMethod(Modifier.STATIC, 0, STREAM_TOOLS, null, BASE_CLASS, DataOutput.class);
+                } else {
+                    this.LOAD_COMPOUND = new LoadMethodWorldUpdate(this.STREAM_TOOLS);
+                }
+                this.SAVE_COMPOUND = getMethod(Modifier.STATIC, 0, this.STREAM_TOOLS, null, this.BASE_CLASS, DataOutput.class);
 
-            } catch (final ClassNotFoundException e) {
+            } catch (ClassNotFoundException e) {
                 throw new IllegalStateException("Unable to find offline player.", e);
             }
         }
@@ -101,7 +120,7 @@ public class NbtFactory {
      * Construct a new NBT list of an unspecified type.
      * @return The NBT list.
      */
-    public static NbtList createList(final Object... content) {
+    public static NbtList createList(Object... content) {
         return createList(Arrays.asList(content));
     }
 
@@ -109,11 +128,11 @@ public class NbtFactory {
      * Construct a new NBT list of an unspecified type.
      * @return The NBT list.
      */
-    public static NbtList createList(final Iterable<? extends Object> iterable) {
+    public static NbtList createList(Iterable<? extends Object> iterable) {
-        final NbtList list = get().new NbtList(INSTANCE.createNbtTag(NbtType.TAG_LIST, null));
+        NbtList list = get().new NbtList(INSTANCE.createNbtTag(NbtType.TAG_LIST, null));
 
         // Add the content as well
-        for (final Object obj : iterable) {
+        for (Object obj : iterable) {
             list.add(obj);
         }
         return list;
@@ -121,7 +140,6 @@ public class NbtFactory {
 
     /**
      * Construct a new NBT compound.
-     * <p>
      *
      * @return The NBT compound.
      */
@@ -134,29 +152,33 @@ public class NbtFactory {
      * @param nmsList - the NBT list.
      * @return The wrapper.
      */
-    public static NbtList fromList(final Object nmsList) {
+    public static NbtList fromList(Object nmsList) {
         return get().new NbtList(nmsList);
     }
 
     /**
      * Load the content of a file from a stream.
-     * <p>
+     *
      * Use {@link Files#newInputStreamSupplier(java.io.File)} to provide a stream from a file.
      * @param stream - the stream supplier.
      * @param option - whether or not to decompress the input stream.
      * @return The decoded NBT compound.
      * @throws IOException If anything went wrong.
      */
-    public static NbtCompound fromStream(final InputSupplier<? extends InputStream> stream, final StreamOptions option) throws IOException {
+    public static NbtCompound fromStream(InputSupplier<? extends InputStream> stream, StreamOptions option) throws IOException {
         InputStream input = null;
         DataInputStream data = null;
         boolean suppress = true;
 
         try {
             input = stream.getInput();
-            data = new DataInputStream(new BufferedInputStream(option == StreamOptions.GZIP_COMPRESSION ? new GZIPInputStream(input) : input));
+            if (option == StreamOptions.GZIP_COMPRESSION) {
+                data = new DataInputStream(new BufferedInputStream(new GZIPInputStream(input)));
+            } else {
+                data = new DataInputStream(new BufferedInputStream(input));
+            }
 
-            final NbtCompound result = fromCompound(get().LOAD_COMPOUND.loadNbt(data));
+            NbtCompound result = fromCompound(get().LOAD_COMPOUND.loadNbt(data));
             suppress = false;
             return result;
 
@@ -171,14 +193,14 @@ public class NbtFactory {
 
     /**
      * Save the content of a NBT compound to a stream.
-     * <p>
+     *
      * Use {@link Files#newOutputStreamSupplier(java.io.File)} to provide a stream supplier to a file.
      * @param source - the NBT compound to save.
      * @param stream - the stream.
      * @param option - whether or not to compress the output.
      * @throws IOException If anything went wrong.
      */
-    public static void saveStream(final NbtCompound source, final ByteSink stream, final StreamOptions option) throws IOException {
+    public static void saveStream(NbtCompound source, ByteSink stream, StreamOptions option) throws IOException {
         OutputStream output = null;
         DataOutputStream data = null;
         boolean suppress = true;
@@ -201,10 +223,10 @@ public class NbtFactory {
 
     /**
      * Construct a new NBT wrapper from a compound.
-     * @param nmsCompound - the NBT compund.
+     * @param nmsCompound - the NBT compound.
      * @return The wrapper.
      */
-    public static NbtCompound fromCompound(final Object nmsCompound) {
+    public static NbtCompound fromCompound(Object nmsCompound) {
         return get().new NbtCompound(nmsCompound);
     }
 
@@ -215,9 +237,9 @@ public class NbtFactory {
      * @param compound - the new NBT compound, or NULL to remove it.
      * @throws IllegalArgumentException If the stack is not a CraftItemStack, or it represents air.
      */
-    public static void setItemTag(final ItemStack stack, final NbtCompound compound) {
+    public static void setItemTag(ItemStack stack, NbtCompound compound) {
         checkItemStack(stack);
-        final Object nms = getFieldValue(get().CRAFT_HANDLE, stack);
+        Object nms = getFieldValue(get().CRAFT_HANDLE, stack);
 
         // Now update the tag compound
         setFieldValue(get().STACK_TAG, nms, compound.getHandle());
@@ -225,21 +247,21 @@ public class NbtFactory {
 
     /**
      * Construct a wrapper for an NBT tag stored (in memory) in an item stack. This is where
-     * auxillary data such as enchanting, name and lore is stored. It does not include items
+     * auxiliary data such as enchanting, name and lore is stored. It does not include items
      * material, damage value or count.
      * <p>
      * The item stack must be a wrapper for a CraftItemStack.
      * @param stack - the item stack.
      * @return A wrapper for its NBT tag.
      */
-    public static NbtCompound fromItemTag(final ItemStack stack) {
+    public static NbtCompound fromItemTag(ItemStack stack) {
         checkItemStack(stack);
-        final Object nms = getFieldValue(get().CRAFT_HANDLE, stack);
+        Object nms = getFieldValue(get().CRAFT_HANDLE, stack);
-        final Object tag = getFieldValue(get().STACK_TAG, nms);
+        Object tag = getFieldValue(get().STACK_TAG, nms);
 
         // Create the tag if it doesn't exist
         if (tag == null) {
-            final NbtCompound compound = createCompound();
+            NbtCompound compound = createCompound();
             setItemTag(stack, compound);
             return compound;
         }
@@ -251,17 +273,17 @@ public class NbtFactory {
      * @param stack - the stack to convert.
      * @return The CraftItemStack version.
      */
-    public static ItemStack getCraftItemStack(final ItemStack stack) {
+    public static ItemStack getCraftItemStack(ItemStack stack) {
         // Any need to convert?
         if ((stack == null) || get().CRAFT_STACK.isAssignableFrom(stack.getClass())) {
             return stack;
         }
         try {
             // Call the private constructor
-            final Constructor<?> caller = INSTANCE.CRAFT_STACK.getDeclaredConstructor(ItemStack.class);
+            Constructor<?> caller = INSTANCE.CRAFT_STACK.getDeclaredConstructor(ItemStack.class);
             caller.setAccessible(true);
             return (ItemStack) caller.newInstance(stack);
-        } catch (final Exception e) {
+        } catch (Exception e) {
             throw new IllegalStateException("Unable to convert " + stack + " + to a CraftItemStack.");
         }
     }
@@ -270,7 +292,7 @@ public class NbtFactory {
      * Ensure that the given stack can store arbitrary NBT information.
      * @param stack - the stack to check.
      */
-    private static void checkItemStack(final ItemStack stack) {
+    private static void checkItemStack(ItemStack stack) {
         if (stack == null) {
             throw new IllegalArgumentException("Stack cannot be NULL.");
         }
@@ -289,32 +311,32 @@ public class NbtFactory {
      * @param params - the parameters to supply.
      * @return The result of the method.
      */
-    private static Object invokeMethod(final Method method, final Object target, final Object... params) {
+    private static Object invokeMethod(Method method, Object target, Object... params) {
         try {
             return method.invoke(target, params);
-        } catch (final Exception e) {
+        } catch (Exception e) {
             throw new RuntimeException("Unable to invoke method " + method + " for " + target, e);
         }
     }
 
-    private static void setFieldValue(final Field field, final Object target, final Object value) {
+    private static void setFieldValue(Field field, Object target, Object value) {
         try {
             field.set(target, value);
-        } catch (final Exception e) {
+        } catch (Exception e) {
             throw new RuntimeException("Unable to set " + field + " for " + target, e);
         }
     }
 
-    private static Object getFieldValue(final Field field, final Object target) {
+    private static Object getFieldValue(Field field, Object target) {
         try {
             return field.get(target);
-        } catch (final Exception e) {
+        } catch (Exception e) {
             throw new RuntimeException("Unable to retrieve " + field + " for " + target, e);
         }
     }
 
     /**
-     * Search for the first publically and privately defined method of the given name and parameter count.
+     * Search for the first publicly and privately defined method of the given name and parameter count.
      * @param requireMod - modifiers that are required.
      * @param bannedMod - modifiers that are banned.
      * @param clazz - a class to start with.
@@ -323,9 +345,9 @@ public class NbtFactory {
      * @return The first method by this name.
      * @throws IllegalStateException If we cannot find this method.
      */
-    private static Method getMethod(final int requireMod, final int bannedMod, final Class<?> clazz, final String methodName,
+    private static Method getMethod(int requireMod, int bannedMod, Class<?> clazz, String methodName,
-            final Class<?>... params) {
+            Class<?>... params) {
-        for (final Method method : clazz.getDeclaredMethods()) {
+        for (Method method : clazz.getDeclaredMethods()) {
             // Limitation: Doesn't handle overloads
             if (((method.getModifiers() & requireMod) == requireMod)
                     && ((method.getModifiers() & bannedMod) == 0)
@@ -344,19 +366,19 @@ public class NbtFactory {
     }
 
     /**
-     * Search for the first publically and privately defined field of the given name.
+     * Search for the first publicly and privately defined field of the given name.
      * @param instance - an instance of the class with the field.
      * @param clazz - an optional class to start with, or NULL to deduce it from instance.
      * @param fieldName - the field name.
      * @return The first field by this name.
      * @throws IllegalStateException If we cannot find this field.
      */
-    private static Field getField(final Object instance, Class<?> clazz, final String fieldName) {
+    private static Field getField(Object instance, Class<?> clazz, String fieldName) {
         if (clazz == null) {
             clazz = instance.getClass();
         }
         // Ignore access rules
-        for (final Field field : clazz.getDeclaredFields()) {
+        for (Field field : clazz.getDeclaredFields()) {
             if (field.getName().equals(fieldName)) {
                 field.setAccessible(true);
                 return field;
@@ -369,18 +391,18 @@ public class NbtFactory {
         throw new IllegalStateException("Unable to find field " + fieldName + " in " + instance);
     }
 
-    private void initializeNMS(final ClassLoader loader, final String nmsPackage) {
+    private void initializeNMS(ClassLoader loader, String nmsPackage) {
         try {
-            STREAM_TOOLS = loader.loadClass(nmsPackage + ".NBTCompressedStreamTools");
+            this.STREAM_TOOLS = loader.loadClass(nmsPackage + ".NBTCompressedStreamTools");
-            READ_LIMITER_CLASS = loader.loadClass(nmsPackage + ".NBTReadLimiter");
+            this.READ_LIMITER_CLASS = loader.loadClass(nmsPackage + ".NBTReadLimiter");
-        } catch (final ClassNotFoundException e) {
+        } catch (ClassNotFoundException e) {
             // Ignore - we will detect this later
         }
     }
 
     private String getPackageName() {
-        final Server server = Bukkit.getServer();
+        Server server = Bukkit.getServer();
-        final String name = server != null ? server.getClass().getPackage().getName() : null;
+        String name = server != null ? server.getClass().getPackage().getName() : null;
 
         if ((name != null) && name.contains("craftbukkit")) {
             return name;
@@ -391,12 +413,12 @@ public class NbtFactory {
     }
 
     @SuppressWarnings("unchecked")
-    private Map<String, Object> getDataMap(final Object handle) {
+    private Map<String, Object> getDataMap(Object handle) {
         return (Map<String, Object>) getFieldValue(getDataField(NbtType.TAG_COMPOUND, handle), handle);
     }
 
     @SuppressWarnings("unchecked")
-    private List<Object> getDataList(final Object handle) {
+    private List<Object> getDataList(Object handle) {
         return (List<Object>) getFieldValue(getDataField(NbtType.TAG_LIST, handle), handle);
     }
 
@@ -405,7 +427,7 @@ public class NbtFactory {
      * @param value - the value of the element to create. Can be a List or a Map.
      * @return The NBT element.
      */
-    private Object unwrapValue(final Object value) {
+    private Object unwrapValue(Object value) {
         if (value == null) {
             return null;
         }
@@ -430,13 +452,13 @@ public class NbtFactory {
      * @param nms - the NBT element.
      * @return The wrapper equivalent.
      */
-    private Object wrapNative(final Object nms) {
+    private Object wrapNative(Object nms) {
         if (nms == null) {
             return null;
         }
 
-        if (BASE_CLASS.isAssignableFrom(nms.getClass())) {
+        if (this.BASE_CLASS.isAssignableFrom(nms.getClass())) {
-            final NbtType type = getNbtType(nms);
+            NbtType type = getNbtType(nms);
 
             // Handle the different types
             switch (type) {
@@ -457,8 +479,8 @@ public class NbtFactory {
      * @param value - the value, or NULL to keep the original value.
      * @return The created tag.
      */
-    private Object createNbtTag(final NbtType type, final Object value) {
+    private Object createNbtTag(NbtType type, Object value) {
-        final Object tag = invokeMethod(NBT_CREATE_TAG, null, (byte) type.id);
+        Object tag = invokeMethod(this.NBT_CREATE_TAG, null, (byte) type.id);
 
         if (value != null) {
             setFieldValue(getDataField(type, tag), tag, value);
@@ -472,11 +494,11 @@ public class NbtFactory {
      * @param nms - the NBT class instance.
      * @return The corresponding field.
      */
-    private Field getDataField(final NbtType type, final Object nms) {
+    private Field getDataField(NbtType type, Object nms) {
-        if (DATA_FIELD[type.id] == null) {
+        if (this.DATA_FIELD[type.id] == null) {
-            DATA_FIELD[type.id] = getField(nms, null, type.getFieldName());
+            this.DATA_FIELD[type.id] = getField(nms, null, type.getFieldName());
         }
-        return DATA_FIELD[type.id];
+        return this.DATA_FIELD[type.id];
     }
 
     /**
@@ -484,8 +506,8 @@ public class NbtFactory {
      * @param nms - the native NBT tag.
      * @return The corresponding type.
      */
-    private NbtType getNbtType(final Object nms) {
+    private NbtType getNbtType(Object nms) {
-        final int type = (Byte) invokeMethod(NBT_GET_TYPE, nms);
+        int type = (Byte) invokeMethod(this.NBT_GET_TYPE, nms);
         return NBT_ENUM.get(type);
     }
 
@@ -494,8 +516,8 @@ public class NbtFactory {
      * @param primitive - the primitive type.
      * @return The corresponding type.
      */
-    private NbtType getPrimitiveType(final Object primitive) {
+    private NbtType getPrimitiveType(Object primitive) {
-        final NbtType type = NBT_ENUM.get(NBT_CLASS.inverse().get(Primitives.unwrap(primitive.getClass())));
+        NbtType type = NBT_ENUM.get(NBT_CLASS.inverse().get(Primitives.unwrap(primitive.getClass())));
 
         // Display the illegal value at least
         if (type == null) {
@@ -529,7 +551,7 @@ public class NbtFactory {
         // Unique NBT type
         public final int id;
 
-        NbtType(final int id, final Class<?> type) {
+        NbtType(int id, Class<?> type) {
             this.id = id;
             NBT_CLASS.put(id, type);
             NBT_ENUM.put(id, this);
@@ -567,9 +589,9 @@ public class NbtFactory {
 
         protected Method staticMethod;
 
-        protected void setMethod(final Method method) {
+        protected void setMethod(Method method) {
-            staticMethod = method;
+            this.staticMethod = method;
-            staticMethod.setAccessible(true);
+            this.staticMethod.setAccessible(true);
         }
 
         /**
@@ -577,7 +599,7 @@ public class NbtFactory {
          * @param input - the input stream.
          * @return The loaded NBT compound.
          */
-        public abstract Object loadNbt(final DataInput input);
+        public abstract Object loadNbt(DataInput input);
     }
 
     /**
@@ -585,13 +607,13 @@ public class NbtFactory {
      */
     private static class LoadMethodWorldUpdate extends LoadCompoundMethod {
 
-        public LoadMethodWorldUpdate(final Class<?> streamClass) {
+        public LoadMethodWorldUpdate(Class<?> streamClass) {
             setMethod(getMethod(Modifier.STATIC, 0, streamClass, null, DataInput.class));
         }
 
         @Override
-        public Object loadNbt(final DataInput input) {
+        public Object loadNbt(DataInput input) {
-            return invokeMethod(staticMethod, null, input);
+            return invokeMethod(this.staticMethod, null, input);
         }
     }
 
@@ -602,15 +624,15 @@ public class NbtFactory {
 
         private Object readLimiter;
 
-        public LoadMethodSkinUpdate(final Class<?> streamClass, final Class<?> readLimiterClass) {
+        public LoadMethodSkinUpdate(Class<?> streamClass, Class<?> readLimiterClass) {
             setMethod(getMethod(Modifier.STATIC, 0, streamClass, null, DataInput.class, readLimiterClass));
 
             // Find the unlimited read limiter
-            for (final Field field : readLimiterClass.getDeclaredFields()) {
+            for (Field field : readLimiterClass.getDeclaredFields()) {
                 if (readLimiterClass.isAssignableFrom(field.getType())) {
                     try {
-                        readLimiter = field.get(null);
+                        this.readLimiter = field.get(null);
-                    } catch (final Exception e) {
+                    } catch (Exception e) {
                         throw new RuntimeException("Cannot retrieve read limiter.", e);
                     }
                 }
@@ -618,8 +640,8 @@ public class NbtFactory {
         }
 
         @Override
-        public Object loadNbt(final DataInput input) {
+        public Object loadNbt(DataInput input) {
-            return invokeMethod(staticMethod, null, input, readLimiter);
+            return invokeMethod(this.staticMethod, null, input, this.readLimiter);
         }
     }
 
@@ -643,44 +665,44 @@ public class NbtFactory {
      */
     public final class NbtCompound extends ConvertedMap {
 
-        private NbtCompound(final Object handle) {
+        private NbtCompound(Object handle) {
             super(handle, getDataMap(handle));
         }
 
-        // Simplifiying access to each value
+        // Simplifying access to each value
-        public Byte getByte(final String key, final Byte defaultValue) {
+        public Byte getByte(String key, Byte defaultValue) {
             return containsKey(key) ? (Byte) get(key) : defaultValue;
         }
 
-        public Short getShort(final String key, final Short defaultValue) {
+        public Short getShort(String key, Short defaultValue) {
             return containsKey(key) ? (Short) get(key) : defaultValue;
         }
 
-        public Integer getInteger(final String key, final Integer defaultValue) {
+        public Integer getInteger(String key, Integer defaultValue) {
             return containsKey(key) ? (Integer) get(key) : defaultValue;
         }
 
-        public Long getLong(final String key, final Long defaultValue) {
+        public Long getLong(String key, Long defaultValue) {
             return containsKey(key) ? (Long) get(key) : defaultValue;
         }
 
-        public Float getFloat(final String key, final Float defaultValue) {
+        public Float getFloat(String key, Float defaultValue) {
             return containsKey(key) ? (Float) get(key) : defaultValue;
         }
 
-        public Double getDouble(final String key, final Double defaultValue) {
+        public Double getDouble(String key, Double defaultValue) {
             return containsKey(key) ? (Double) get(key) : defaultValue;
         }
 
-        public String getString(final String key, final String defaultValue) {
+        public String getString(String key, String defaultValue) {
             return containsKey(key) ? (String) get(key) : defaultValue;
         }
 
-        public byte[] getByteArray(final String key, final byte[] defaultValue) {
+        public byte[] getByteArray(String key, byte[] defaultValue) {
             return containsKey(key) ? (byte[]) get(key) : defaultValue;
         }
 
-        public int[] getIntegerArray(final String key, final int[] defaultValue) {
+        public int[] getIntegerArray(String key, int[] defaultValue) {
             return containsKey(key) ? (int[]) get(key) : defaultValue;
         }
 
@@ -690,7 +712,7 @@ public class NbtFactory {
          * @param createNew - whether or not to create a new list if its missing.
          * @return An existing list, a new list or NULL.
          */
-        public NbtList getList(final String key, final boolean createNew) {
+        public NbtList getList(String key, boolean createNew) {
             NbtList list = (NbtList) get(key);
 
             if ((list == null) && createNew) {
@@ -705,7 +727,7 @@ public class NbtFactory {
          * @param createNew - whether or not to create a new map if its missing.
          * @return An existing map, a new map or NULL.
          */
-        public NbtCompound getMap(final String key, final boolean createNew) {
+        public NbtCompound getMap(String key, boolean createNew) {
             return getMap(Collections.singletonList(key), createNew);
         }
 
@@ -720,9 +742,9 @@ public class NbtFactory {
          * @param value - the new value of this entry.
          * @return This compound, for chaining.
          */
-        public NbtCompound putPath(final String path, final Object value) {
+        public NbtCompound putPath(String path, Object value) {
-            final List<String> entries = getPathElements(path);
+            List<String> entries = getPathElements(path);
-            final Map<String, Object> map = getMap(entries.subList(0, entries.size() - 1), true);
+            Map<String, Object> map = getMap(entries.subList(0, entries.size() - 1), true);
 
             map.put(entries.get(entries.size() - 1), value);
             return this;
@@ -737,9 +759,9 @@ public class NbtFactory {
          * @return The value, or NULL if not found.
          */
         @SuppressWarnings("unchecked")
-        public <T> T getPath(final String path) {
+        public <T> T getPath(String path) {
-            final List<String> entries = getPathElements(path);
+            List<String> entries = getPathElements(path);
-            final NbtCompound map = getMap(entries.subList(0, entries.size() - 1), false);
+            NbtCompound map = getMap(entries.subList(0, entries.size() - 1), false);
 
             if (map != null) {
                 return (T) map.get(entries.get(entries.size() - 1));
@@ -755,7 +777,7 @@ public class NbtFactory {
          * @param option - whether or not to compress the output.
          * @throws IOException If anything went wrong.
          */
-        public void saveTo(final ByteSink stream, final StreamOptions option) throws IOException {
+        public void saveTo(ByteSink stream, StreamOptions option) throws IOException {
             saveStream(this, stream, option);
         }
 
@@ -765,10 +787,10 @@ public class NbtFactory {
          * @param createNew - whether or not to create new compounds on the way.
          * @return The map at this location.
          */
-        private NbtCompound getMap(final Iterable<String> path, final boolean createNew) {
+        private NbtCompound getMap(Iterable<String> path, boolean createNew) {
             NbtCompound current = this;
 
-            for (final String entry : path) {
+            for (String entry : path) {
                 NbtCompound child = (NbtCompound) current.get(entry);
 
                 if (child == null) {
@@ -787,7 +809,7 @@ public class NbtFactory {
          * @param path - the path to split.
          * @return The elements.
          */
-        private List<String> getPathElements(final String path) {
+        private List<String> getPathElements(String path) {
             return Lists.newArrayList(Splitter.on(".").omitEmptyStrings().split(path));
         }
     }
@@ -803,7 +825,7 @@ public class NbtFactory {
      */
     public final class NbtList extends ConvertedList {
 
-        private NbtList(final Object handle) {
+        private NbtList(Object handle) {
             super(handle, getDataList(handle));
         }
     }
@@ -817,15 +839,15 @@ public class NbtFactory {
         // Don't recreate wrapper objects
         private final ConcurrentMap<Object, Object> cache = new MapMaker().weakKeys().makeMap();
 
-        public Object wrap(final Object value) {
+        public Object wrap(Object value) {
-            Object current = cache.get(value);
+            Object current = this.cache.get(value);
 
             if (current == null) {
                 current = wrapNative(value);
 
                 // Only cache composite objects
                 if ((current instanceof ConvertedMap) || (current instanceof ConvertedList)) {
-                    cache.put(value, current);
+                    this.cache.put(value, current);
                 }
             }
             return current;
@@ -844,57 +866,57 @@ public class NbtFactory {
 
         private final CachedNativeWrapper cache = new CachedNativeWrapper();
 
-        public ConvertedMap(final Object handle, final Map<String, Object> original) {
+        public ConvertedMap(Object handle, Map<String, Object> original) {
             this.handle = handle;
             this.original = original;
         }
 
         // For converting back and forth
-        protected Object wrapOutgoing(final Object value) {
+        protected Object wrapOutgoing(Object value) {
-            return cache.wrap(value);
+            return this.cache.wrap(value);
         }
 
-        protected Object unwrapIncoming(final Object wrapped) {
+        protected Object unwrapIncoming(Object wrapped) {
             return unwrapValue(wrapped);
         }
 
         // Modification
         @Override
-        public Object put(final String key, final Object value) {
+        public Object put(String key, Object value) {
-            return wrapOutgoing(original.put(key, unwrapIncoming(value)));
+            return wrapOutgoing(this.original.put(key, unwrapIncoming(value)));
         }
 
         // Performance
         @Override
-        public Object get(final Object key) {
+        public Object get(Object key) {
-            return wrapOutgoing(original.get(key));
+            return wrapOutgoing(this.original.get(key));
         }
 
         @Override
-        public Object remove(final Object key) {
+        public Object remove(Object key) {
-            return wrapOutgoing(original.remove(key));
+            return wrapOutgoing(this.original.remove(key));
         }
 
         @Override
-        public boolean containsKey(final Object key) {
+        public boolean containsKey(Object key) {
-            return original.containsKey(key);
+            return this.original.containsKey(key);
         }
 
         @Override
         public Set<Entry<String, Object>> entrySet() {
             return new AbstractSet<Entry<String, Object>>() {
                 @Override
-                public boolean add(final Entry<String, Object> e) {
+                public boolean add(Entry<String, Object> e) {
-                    final String key = e.getKey();
+                    String key = e.getKey();
-                    final Object value = e.getValue();
+                    Object value = e.getValue();
 
-                    original.put(key, unwrapIncoming(value));
+                    ConvertedMap.this.original.put(key, unwrapIncoming(value));
                     return true;
                 }
 
                 @Override
                 public int size() {
-                    return original.size();
+                    return ConvertedMap.this.original.size();
                 }
 
                 @Override
@@ -905,7 +927,7 @@ public class NbtFactory {
         }
 
         private Iterator<Entry<String, Object>> iterator() {
-            final Iterator<Entry<String, Object>> proxy = original.entrySet().iterator();
+            final Iterator<Entry<String, Object>> proxy = this.original.entrySet().iterator();
 
             return new Iterator<Entry<String, Object>>() {
                 @Override
@@ -915,7 +937,7 @@ public class NbtFactory {
 
                 @Override
                 public Entry<String, Object> next() {
-                    final Entry<String, Object> entry = proxy.next();
+                    Entry<String, Object> entry = proxy.next();
 
                     return new SimpleEntry<String, Object>(entry.getKey(), wrapOutgoing(entry.getValue()));
                 }
@@ -929,7 +951,7 @@ public class NbtFactory {
 
         @Override
         public Object getHandle() {
-            return handle;
+            return this.handle;
         }
     }
 
@@ -945,61 +967,61 @@ public class NbtFactory {
         private final List<Object> original;
         private final CachedNativeWrapper cache = new CachedNativeWrapper();
 
-        public ConvertedList(final Object handle, final List<Object> original) {
+        public ConvertedList(Object handle, List<Object> original) {
-            if (NBT_LIST_TYPE == null) {
+            if (NbtFactory.this.NBT_LIST_TYPE == null) {
-                NBT_LIST_TYPE = getField(handle, null, "type");
+                NbtFactory.this.NBT_LIST_TYPE = getField(handle, null, "type");
             }
             this.handle = handle;
             this.original = original;
         }
 
-        protected Object wrapOutgoing(final Object value) {
+        protected Object wrapOutgoing(Object value) {
-            return cache.wrap(value);
+            return this.cache.wrap(value);
         }
 
-        protected Object unwrapIncoming(final Object wrapped) {
+        protected Object unwrapIncoming(Object wrapped) {
             return unwrapValue(wrapped);
         }
 
         @Override
-        public Object get(final int index) {
+        public Object get(int index) {
-            return wrapOutgoing(original.get(index));
+            return wrapOutgoing(this.original.get(index));
         }
 
         @Override
         public int size() {
-            return original.size();
+            return this.original.size();
         }
 
         @Override
-        public Object set(final int index, final Object element) {
+        public Object set(int index, Object element) {
-            return wrapOutgoing(original.set(index, unwrapIncoming(element)));
+            return wrapOutgoing(this.original.set(index, unwrapIncoming(element)));
         }
 
         @Override
-        public void add(final int index, final Object element) {
+        public void add(int index, Object element) {
-            final Object nbt = unwrapIncoming(element);
+            Object nbt = unwrapIncoming(element);
 
             // Set the list type if its the first element
             if (size() == 0) {
-                setFieldValue(NBT_LIST_TYPE, handle, (byte) getNbtType(nbt).id);
+                setFieldValue(NbtFactory.this.NBT_LIST_TYPE, this.handle, (byte) getNbtType(nbt).id);
             }
-            original.add(index, nbt);
+            this.original.add(index, nbt);
         }
 
         @Override
-        public Object remove(final int index) {
+        public Object remove(int index) {
-            return wrapOutgoing(original.remove(index));
+            return wrapOutgoing(this.original.remove(index));
         }
 
         @Override
-        public boolean remove(final Object o) {
+        public boolean remove(Object o) {
-            return original.remove(unwrapIncoming(o));
+            return this.original.remove(unwrapIncoming(o));
         }
 
         @Override
         public Object getHandle() {
-            return handle;
+            return this.handle;
         }
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/OfflinePlayerUtil.java

@@ -19,15 +19,15 @@ import java.util.UUID;
 
 public class OfflinePlayerUtil {
 
-    public static Player loadPlayer(final String name) {
+    public static Player loadPlayer(String name) {
         return loadPlayer(Bukkit.getOfflinePlayer(name));
     }
 
-    public static Player loadPlayer(final UUID id) {
+    public static Player loadPlayer(UUID id) {
         return loadPlayer(Bukkit.getOfflinePlayer(id));
     }
 
-    public static Player loadPlayer(final OfflinePlayer player) {
+    public static Player loadPlayer(OfflinePlayer player) {
         if (player == null) {
             return null;
         }
@@ -37,26 +37,26 @@ public class OfflinePlayerUtil {
         return loadPlayer(player.getUniqueId(), player.getName());
     }
 
-    private static Player loadPlayer(final UUID id, final String name) {
+    private static Player loadPlayer(UUID id, String name) {
-        final Object server = getMinecraftServer();
+        Object server = getMinecraftServer();
-        final Object interactManager = newPlayerInteractManager();
+        Object interactManager = newPlayerInteractManager();
-        final Object worldServer = getWorldServer();
+        Object worldServer = getWorldServer();
-        final Object profile = newGameProfile(id, name);
+        Object profile = newGameProfile(id, name);
-        final Class<?> entityPlayerClass = getNmsClass("EntityPlayer");
+        Class<?> entityPlayerClass = getNmsClass("EntityPlayer");
-        final Constructor entityPlayerConstructor = makeConstructor(entityPlayerClass, getNmsClass("MinecraftServer"), getNmsClass("WorldServer"),
+        Constructor entityPlayerConstructor = makeConstructor(entityPlayerClass, getNmsClass("MinecraftServer"), getNmsClass("WorldServer"),
                 getUtilClass("com.mojang.authlib.GameProfile"),
                 getNmsClass("PlayerInteractManager"));
-        final Object entityPlayer = callConstructor(entityPlayerConstructor, server, worldServer, profile, interactManager);
+        Object entityPlayer = callConstructor(entityPlayerConstructor, server, worldServer, profile, interactManager);
         return (Player) getBukkitEntity(entityPlayer);
     }
 
-    private static Object newGameProfile(final UUID id, final String name) {
+    private static Object newGameProfile(UUID id, String name) {
-        final Class<?> gameProfileClass = getUtilClass("com.mojang.authlib.GameProfile");
+        Class<?> gameProfileClass = getUtilClass("com.mojang.authlib.GameProfile");
         if (gameProfileClass == null) { //Before uuids
             return name;
         }
         Constructor gameProfileConstructor = makeConstructor(gameProfileClass, UUID.class, String.class);
-        if (gameProfileConstructor == null) { //Verson has string constructor
+        if (gameProfileConstructor == null) { //Version has string constructor
             gameProfileConstructor = makeConstructor(gameProfileClass, String.class, String.class);
             return callConstructor(gameProfileConstructor, id.toString(), name);
         } else { //Version has uuid constructor
@@ -65,17 +65,17 @@ public class OfflinePlayerUtil {
     }
 
     private static Object newPlayerInteractManager() {
-        final Object worldServer = getWorldServer();
+        Object worldServer = getWorldServer();
-        final Class<?> playerInteractClass = getNmsClass("PlayerInteractManager");
+        Class<?> playerInteractClass = getNmsClass("PlayerInteractManager");
-        final Class<?> worldClass = getNmsClass("World");
+        Class<?> worldClass = getNmsClass("World");
-        final Constructor c = makeConstructor(playerInteractClass, worldClass);
+        Constructor c = makeConstructor(playerInteractClass, worldClass);
         return callConstructor(c, worldServer);
     }
 
     private static Object getWorldServer() {
-        final Object server = getMinecraftServer();
+        Object server = getMinecraftServer();
-        final Class<?> minecraftServerClass = getNmsClass("MinecraftServer");
+        Class<?> minecraftServerClass = getNmsClass("MinecraftServer");
-        final Method getWorldServer = makeMethod(minecraftServerClass, "getWorldServer", int.class);
+        Method getWorldServer = makeMethod(minecraftServerClass, "getWorldServer", int.class);
         return callMethod(getWorldServer, server, 0);
     }
 
@@ -85,8 +85,8 @@ public class OfflinePlayerUtil {
         return callMethod(makeMethod(getCbClass("CraftServer"), "getServer"), Bukkit.getServer());
     }
 
-    private static Entity getBukkitEntity(final Object o) {
+    private static Entity getBukkitEntity(Object o) {
-        final Method getBukkitEntity = makeMethod(o.getClass(), "getBukkitEntity");
+        Method getBukkitEntity = makeMethod(o.getClass(), "getBukkitEntity");
         return callMethod(getBukkitEntity, o);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/SendChunk.java

@@ -1,5 +1,7 @@
 package com.plotsquared.bukkit.util;
 
+import static com.intellectualcrafters.plot.util.ReflectionUtils.getRefClass;
+
 import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.object.ChunkLoc;
 import com.intellectualcrafters.plot.object.Location;
@@ -17,11 +19,12 @@ import org.bukkit.Chunk;
 import org.bukkit.World;
 import org.bukkit.entity.Player;
 
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Map.Entry;
 
-import static com.intellectualcrafters.plot.util.ReflectionUtils.getRefClass;
-
 /**
  * An utility that can be used to send chunks, rather than using bukkit code to do so (uses heavy NMS)
  *
@@ -29,17 +32,9 @@ import static com.intellectualcrafters.plot.util.ReflectionUtils.getRefClass;
  */
 public class SendChunk {
 
-    //    // Ref Class
-    private final RefClass classEntityPlayer = getRefClass("{nms}.EntityPlayer");
-    private final RefClass classMapChunk = getRefClass("{nms}.PacketPlayOutMapChunk");
-    private final RefClass classPacket = getRefClass("{nms}.Packet");
-    private final RefClass classConnection = getRefClass("{nms}.PlayerConnection");
-    private final RefClass classChunk = getRefClass("{nms}.Chunk");
-    private final RefClass classCraftPlayer = getRefClass("{cb}.entity.CraftPlayer");
-    private final RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
     private final RefMethod methodGetHandlePlayer;
     private final RefMethod methodGetHandleChunk;
-    private final RefConstructor MapChunk;
+    private final RefConstructor mapChunk;
     private final RefField connection;
     private final RefMethod send;
     private final RefMethod methodInitLighting;
@@ -48,32 +43,39 @@ public class SendChunk {
      * Constructor
      */
     public SendChunk() {
-        methodGetHandlePlayer = classCraftPlayer.getMethod("getHandle");
+        RefClass classCraftPlayer = getRefClass("{cb}.entity.CraftPlayer");
-        methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
+        this.methodGetHandlePlayer = classCraftPlayer.getMethod("getHandle");
-        methodInitLighting = classChunk.getMethod("initLighting");
+        RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
-        MapChunk = classMapChunk.getConstructor(classChunk.getRealClass(), boolean.class, int.class);
+        this.methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
-        connection = classEntityPlayer.getField("playerConnection");
+        RefClass classChunk = getRefClass("{nms}.Chunk");
-        send = classConnection.getMethod("sendPacket", classPacket.getRealClass());
+        this.methodInitLighting = classChunk.getMethod("initLighting");
+        RefClass classMapChunk = getRefClass("{nms}.PacketPlayOutMapChunk");
+        this.mapChunk = classMapChunk.getConstructor(classChunk.getRealClass(), boolean.class, int.class);
+        RefClass classEntityPlayer = getRefClass("{nms}.EntityPlayer");
+        this.connection = classEntityPlayer.getField("playerConnection");
+        RefClass classPacket = getRefClass("{nms}.Packet");
+        RefClass classConnection = getRefClass("{nms}.PlayerConnection");
+        this.send = classConnection.getMethod("sendPacket", classPacket.getRealClass());
     }
 
-    public void sendChunk(final Collection<Chunk> input) {
+    public void sendChunk(Collection<Chunk> input) {
-        final HashSet<Chunk> chunks = new HashSet<Chunk>(input);
+        HashSet<Chunk> chunks = new HashSet<Chunk>(input);
-        final HashMap<String, ArrayList<Chunk>> map = new HashMap<>();
+        HashMap<String, ArrayList<Chunk>> map = new HashMap<>();
-        final int view = Bukkit.getServer().getViewDistance();
+        int view = Bukkit.getServer().getViewDistance();
-        for (final Chunk chunk : chunks) {
+        for (Chunk chunk : chunks) {
-            final String world = chunk.getWorld().getName();
+            String world = chunk.getWorld().getName();
             ArrayList<Chunk> list = map.get(world);
             if (list == null) {
                 list = new ArrayList<>();
                 map.put(world, list);
             }
             list.add(chunk);
-            final Object c = methodGetHandleChunk.of(chunk).call();
+            Object c = this.methodGetHandleChunk.of(chunk).call();
-            methodInitLighting.of(c).call();
+            this.methodInitLighting.of(c).call();
         }
         for (Entry<String, PlotPlayer> entry : UUIDHandler.getPlayers().entrySet()) {
             PlotPlayer pp = entry.getValue();
-            final Plot plot = pp.getCurrentPlot();
+            Plot plot = pp.getCurrentPlot();
             Location loc = null;
             String world;
             if (plot != null) {
@@ -82,29 +84,29 @@ public class SendChunk {
                 loc = pp.getLocation();
                 world = loc.getWorld();
             }
-            final ArrayList<Chunk> list = map.get(world);
+            ArrayList<Chunk> list = map.get(world);
             if (list == null) {
                 continue;
             }
             if (loc == null) {
                 loc = pp.getLocation();
             }
-            final int cx = loc.getX() >> 4;
+            int cx = loc.getX() >> 4;
-            final int cz = loc.getZ() >> 4;
+            int cz = loc.getZ() >> 4;
-            final Player player = ((BukkitPlayer) pp).player;
+            Player player = ((BukkitPlayer) pp).player;
-            final Object entity = methodGetHandlePlayer.of(player).call();
+            Object entity = this.methodGetHandlePlayer.of(player).call();
 
-            for (final Chunk chunk : list) {
+            for (Chunk chunk : list) {
-                final int dx = Math.abs(cx - chunk.getX());
+                int dx = Math.abs(cx - chunk.getX());
-                final int dz = Math.abs(cz - chunk.getZ());
+                int dz = Math.abs(cz - chunk.getZ());
                 if ((dx > view) || (dz > view)) {
                     continue;
                 }
-                final Object c = methodGetHandleChunk.of(chunk).call();
+                Object c = this.methodGetHandleChunk.of(chunk).call();
                 chunks.remove(chunk);
-                final Object con = connection.of(entity).get();
+                Object con = this.connection.of(entity).get();
-                final Object packet = MapChunk.create(c, true, 65535);
+                Object packet = this.mapChunk.create(c, true, 65535);
-                send.of(con).call(packet);
+                this.send.of(con).call(packet);
             }
         }
         for (final Chunk chunk : chunks) {
@@ -113,11 +115,11 @@ public class SendChunk {
                 public void run() {
                     try {
                         chunk.unload(true, false);
-                    } catch (final Throwable e) {
+                    } catch (Throwable e) {
-                        final String worldname = chunk.getWorld().getName();
+                        String worldName = chunk.getWorld().getName();
-                        PS.debug("$4Could not save chunk: " + worldname + ";" + chunk.getX() + ";" + chunk.getZ());
+                        PS.debug("$4Could not save chunk: " + worldName + ";" + chunk.getX() + ";" + chunk.getZ());
                         PS.debug("$3 - $4File may be open in another process (e.g. MCEdit)");
-                        PS.debug("$3 - $4" + worldname + "/level.dat or " + worldname
+                        PS.debug("$3 - $4" + worldName + "/level.dat or " + worldName
                                 + "/level_old.dat may be corrupt (try repairing or removing these)");
                     }
                 }
@@ -125,12 +127,12 @@ public class SendChunk {
         }
     }
 
-    public void sendChunk(final String worldname, final List<ChunkLoc> locs) {
+    public void sendChunk(String worldName, Collection<ChunkLoc> chunkLocations) {
-        final World myworld = Bukkit.getWorld(worldname);
+        World myWorld = Bukkit.getWorld(worldName);
-        final ArrayList<Chunk> chunks = new ArrayList<>();
+        ArrayList<Chunk> chunks = new ArrayList<>();
-        for (final ChunkLoc loc : locs) {
+        for (ChunkLoc loc : chunkLocations) {
-            if (myworld.isChunkLoaded(loc.x, loc.z)) {
+            if (myWorld.isChunkLoaded(loc.x, loc.z)) {
-                chunks.add(myworld.getChunkAt(loc.x, loc.z));
+                chunks.add(myWorld.getChunkAt(loc.x, loc.z));
             }
         }
         sendChunk(chunks);

Bukkit/src/main/java/com/plotsquared/bukkit/util/SetGenCB.java

@@ -14,24 +14,24 @@ import java.util.Iterator;
 
 public class SetGenCB {
 
-    public static void setGenerator(final World world) throws Exception {
+    public static void setGenerator(World world) throws Exception {
         SetupUtils.manager.updateGenerators();
         PS.get().removePlotAreas(world.getName());
-        final ChunkGenerator gen = world.getGenerator();
+        ChunkGenerator gen = world.getGenerator();
         if (gen == null) {
             return;
         }
-        final String name = gen.getClass().getCanonicalName();
+        String name = gen.getClass().getCanonicalName();
         boolean set = false;
-        for (final GeneratorWrapper<?> wrapper : SetupUtils.generators.values()) {
+        for (GeneratorWrapper<?> wrapper : SetupUtils.generators.values()) {
             ChunkGenerator newGen = (ChunkGenerator) wrapper.getPlatformGenerator();
             if (newGen == null) {
                 newGen = (ChunkGenerator) wrapper;
             }
             if (newGen.getClass().getCanonicalName().equals(name)) {
                 // set generator
-                final Field generator = world.getClass().getDeclaredField("generator");
+                Field generator = world.getClass().getDeclaredField("generator");
-                final Field populators = world.getClass().getDeclaredField("populators");
+                Field populators = world.getClass().getDeclaredField("populators");
                 generator.setAccessible(true);
                 populators.setAccessible(true);
                 // Set populators (just in case)
@@ -45,10 +45,10 @@ public class SetGenCB {
             }
         }
         if (!set) {
-            final Iterator<BlockPopulator> iter = world.getPopulators().iterator();
+            Iterator<BlockPopulator> iterator = world.getPopulators().iterator();
-            while (iter.hasNext()) {
+            while (iterator.hasNext()) {
-                if (iter.next() instanceof BukkitAugmentedGenerator) {
+                if (iterator.next() instanceof BukkitAugmentedGenerator) {
-                    iter.remove();
+                    iterator.remove();
                 }
             }
         }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastChunk_1_8_3.java

@@ -17,12 +17,13 @@ public class FastChunk_1_8_3 extends PlotChunk<Chunk> {
     public short[] relight;
     public int[][] biomes;
     public Chunk chunk;
-    public FastChunk_1_8_3(final ChunkWrapper chunk) {
+
+    public FastChunk_1_8_3(ChunkWrapper chunk) {
         super(chunk);
-        ids = new char[16][];
+        this.ids = new char[16][];
-        count = new short[16];
+        this.count = new short[16];
-        air = new short[16];
+        this.air = new short[16];
-        relight = new short[16];
+        this.relight = new short[16];
     }
 
     @Override
@@ -33,89 +34,89 @@ public class FastChunk_1_8_3 extends PlotChunk<Chunk> {
 
     @Override
     public Chunk getChunk() {
-        if (chunk == null) {
+        if (this.chunk == null) {
-            final ChunkWrapper cl = getChunkWrapper();
+            ChunkWrapper cl = getChunkWrapper();
-            chunk = Bukkit.getWorld(cl.world).getChunkAt(cl.x, cl.z);
+            this.chunk = Bukkit.getWorld(cl.world).getChunkAt(cl.x, cl.z);
         }
-        return chunk;
+        return this.chunk;
     }
 
     @Override
-    public void setChunkWrapper(final ChunkWrapper loc) {
+    public void setChunkWrapper(ChunkWrapper loc) {
         super.setChunkWrapper(loc);
-        chunk = null;
+        this.chunk = null;
     }
 
     /**
-     * Get the number of block changes in a specified section
+     * Get the number of block changes in a specified section.
      * @param i
      * @return
      */
-    public int getCount(final int i) {
+    public int getCount(int i) {
-        return count[i];
+        return this.count[i];
     }
 
-    public int getAir(final int i) {
+    public int getAir(int i) {
-        return air[i];
+        return this.air[i];
     }
 
     public void setCount(int i, short value) {
-        count[i] = value;
+        this.count[i] = value;
     }
 
     /**
-     * Get the number of block changes in a specified section
+     * Get the number of block changes in a specified section.
      * @param i
      * @return
      */
-    public int getRelight(final int i) {
+    public int getRelight(int i) {
-        return relight[i];
+        return this.relight[i];
     }
 
     public int getTotalCount() {
         int total = 0;
         for (int i = 0; i < 16; i++) {
-            total += count[i];
+            total += this.count[i];
         }
         return total;
     }
 
     public int getTotalRelight() {
         if (getTotalCount() == 0) {
-            Arrays.fill(count, (short) 1);
+            Arrays.fill(this.count, (short) 1);
-            Arrays.fill(relight, Short.MAX_VALUE);
+            Arrays.fill(this.relight, Short.MAX_VALUE);
             return Short.MAX_VALUE;
         }
         int total = 0;
         for (int i = 0; i < 16; i++) {
-            total += relight[i];
+            total += this.relight[i];
         }
         return total;
     }
 
     /**
-     * Get the raw data for a section
+     * Get the raw data for a section.
      * @param i
      * @return
      */
-    public char[] getIdArray(final int i) {
+    public char[] getIdArray(int i) {
-        return ids[i];
+        return this.ids[i];
     }
 
     @Override
-    public void setBlock(final int x, final int y, final int z, final int id, byte data) {
+    public void setBlock(int x, int y, int z, int id, byte data) {
-        final int i = MainUtil.CACHE_I[y][x][z];
+        int i = MainUtil.CACHE_I[y][x][z];
-        final int j = MainUtil.CACHE_J[y][x][z];
+        int j = MainUtil.CACHE_J[y][x][z];
-        char[] vs = ids[i];
+        char[] vs = this.ids[i];
         if (vs == null) {
-            vs = ids[i] = new char[4096];
+            vs = this.ids[i] = new char[4096];
-            count[i]++;
+            this.count[i]++;
         } else if (vs[j] == 0) {
-            count[i]++;
+            this.count[i]++;
         }
         switch (id) {
             case 0:
-                air[i]++;
+                this.air[i]++;
                 vs[j] = (char) 1;
                 return;
             case 10:
@@ -129,7 +130,7 @@ public class FastChunk_1_8_3 extends PlotChunk<Chunk> {
             case 124:
             case 138:
             case 169:
-                relight[i]++;
+                this.relight[i]++;
             case 2:
             case 4:
             case 13:
@@ -193,7 +194,7 @@ public class FastChunk_1_8_3 extends PlotChunk<Chunk> {
             case 130:
             case 76:
             case 62:
-                relight[i]++;
+                this.relight[i]++;
             case 54:
             case 146:
             case 61:
@@ -212,12 +213,12 @@ public class FastChunk_1_8_3 extends PlotChunk<Chunk> {
     @Override
     public PlotChunk clone() {
         FastChunk_1_8_3 toReturn = new FastChunk_1_8_3(getChunkWrapper());
-        toReturn.air = air.clone();
+        toReturn.air = this.air.clone();
-        toReturn.count = count.clone();
+        toReturn.count = this.count.clone();
-        toReturn.relight = relight.clone();
+        toReturn.relight = this.relight.clone();
-        toReturn.ids = new char[ids.length][];
+        toReturn.ids = new char[this.ids.length][];
-        for (int i = 0; i < ids.length; i++) {
+        for (int i = 0; i < this.ids.length; i++) {
-            char[] matrix = ids[i];
+            char[] matrix = this.ids[i];
             if (matrix != null) {
                 toReturn.ids[i] = new char[matrix.length];
                 System.arraycopy(matrix, 0, toReturn.ids[i], 0, matrix.length);
@@ -229,18 +230,18 @@ public class FastChunk_1_8_3 extends PlotChunk<Chunk> {
     @Override
     public PlotChunk shallowClone() {
         FastChunk_1_8_3 toReturn = new FastChunk_1_8_3(getChunkWrapper());
-        toReturn.air = air;
+        toReturn.air = this.air;
-        toReturn.count = count;
+        toReturn.count = this.count;
-        toReturn.relight = relight;
+        toReturn.relight = this.relight;
-        toReturn.ids = ids;
+        toReturn.ids = this.ids;
         return toReturn;
     }
 
     @Override
     public void setBiome(int x, int z, int biome) {
-        if (biomes == null) {
+        if (this.biomes == null) {
-            biomes = new int[16][16];
+            this.biomes = new int[16][16];
         }
-        biomes[x][z] = biome;
+        this.biomes[x][z] = biome;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastChunk_1_9.java

@@ -1,35 +1,251 @@
 package com.plotsquared.bukkit.util.block;
 
+import com.intellectualcrafters.plot.util.MainUtil;
 import com.intellectualcrafters.plot.util.PlotChunk;
-import com.intellectualcrafters.plot.util.SetQueue;
+import com.intellectualcrafters.plot.util.SetQueue.ChunkWrapper;
 import com.plotsquared.bukkit.util.BukkitUtil;
+import org.bukkit.Bukkit;
 import org.bukkit.Chunk;
 
+import java.util.Arrays;
+
 public class FastChunk_1_9 extends PlotChunk<Chunk> {
 
-    public FastChunk_1_9(SetQueue.ChunkWrapper wrap) {
+    public int[][] ids;
-        super(wrap);
+    public short[] count;
+    public short[] air;
+    public short[] relight;
+    public int[][] biomes;
+    public Chunk chunk;
+
+    public FastChunk_1_9(ChunkWrapper chunk) {
+        super(chunk);
+        this.ids = new int[16][];
+        this.count = new short[16];
+        this.air = new short[16];
+        this.relight = new short[16];
     }
 
     @Override
     public Chunk getChunkAbs() {
-        SetQueue.ChunkWrapper loc = getChunkWrapper();
+        ChunkWrapper loc = getChunkWrapper();
         return BukkitUtil.getWorld(loc.world).getChunkAt(loc.x, loc.z);
     }
 
-    @Override public void setBlock(int x, int y, int z, int id, byte data) {
+    @Override
-
+    public Chunk getChunk() {
+        if (this.chunk == null) {
+            ChunkWrapper cl = getChunkWrapper();
+            this.chunk = Bukkit.getWorld(cl.world).getChunkAt(cl.x, cl.z);
+        }
+        return this.chunk;
     }
 
-    @Override public void setBiome(int x, int z, int biome) {
+    @Override
-
+    public void setChunkWrapper(ChunkWrapper loc) {
+        super.setChunkWrapper(loc);
+        this.chunk = null;
     }
 
-    @Override public PlotChunk clone() {
+    /**
-        return null;
+     * Get the number of block changes in a specified section.
+     * @param i
+     * @return
+     */
+    public int getCount(int i) {
+        return this.count[i];
     }
 
-    @Override public PlotChunk shallowClone() {
+    public int getAir(int i) {
-        return null;
+        return this.air[i];
+    }
+
+    public void setCount(int i, short value) {
+        this.count[i] = value;
+    }
+
+    /**
+     * Get the number of block changes in a specified section.
+     * @param i
+     * @return
+     */
+    public int getRelight(int i) {
+        return this.relight[i];
+    }
+
+    public int getTotalCount() {
+        int total = 0;
+        for (int i = 0; i < 16; i++) {
+            total += this.count[i];
+        }
+        return total;
+    }
+
+    public int getTotalRelight() {
+        if (getTotalCount() == 0) {
+            Arrays.fill(this.count, (short) 1);
+            Arrays.fill(this.relight, Short.MAX_VALUE);
+            return Short.MAX_VALUE;
+        }
+        int total = 0;
+        for (int i = 0; i < 16; i++) {
+            total += this.relight[i];
+        }
+        return total;
+    }
+
+    /**
+     * Get the raw data for a section.
+     * @param i
+     * @return
+     */
+    public int[] getIdArray(int i) {
+        return this.ids[i];
+    }
+
+    public int[][] getIdArrays() {
+        return this.ids;
+    }
+
+    @Override
+    public void setBlock(int x, int y, int z, int id, byte data) {
+        int i = MainUtil.CACHE_I[y][x][z];
+        int j = MainUtil.CACHE_J[y][x][z];
+        int[] vs = this.ids[i];
+        if (vs == null) {
+            vs = this.ids[i] = new int[4096];
+            this.count[i]++;
+        } else if (vs[j] == 0) {
+            this.count[i]++;
+        }
+        switch (id) {
+            case 0:
+                this.air[i]++;
+                vs[j] = -1;
+                return;
+            case 10:
+            case 11:
+            case 39:
+            case 40:
+            case 51:
+            case 74:
+            case 89:
+            case 122:
+            case 124:
+            case 138:
+            case 169:
+                this.relight[i]++;
+            case 2:
+            case 4:
+            case 13:
+            case 14:
+            case 15:
+            case 20:
+            case 21:
+            case 22:
+            case 30:
+            case 32:
+            case 37:
+            case 41:
+            case 42:
+            case 45:
+            case 46:
+            case 47:
+            case 48:
+            case 49:
+            case 55:
+            case 56:
+            case 57:
+            case 58:
+            case 60:
+            case 7:
+            case 8:
+            case 9:
+            case 73:
+            case 78:
+            case 79:
+            case 80:
+            case 81:
+            case 82:
+            case 83:
+            case 85:
+            case 87:
+            case 88:
+            case 101:
+            case 102:
+            case 103:
+            case 110:
+            case 112:
+            case 113:
+            case 121:
+            case 129:
+            case 133:
+            case 165:
+            case 166:
+            case 170:
+            case 172:
+            case 173:
+            case 174:
+            case 181:
+            case 182:
+            case 188:
+            case 189:
+            case 190:
+            case 191:
+            case 192:
+                vs[j] = id;
+                return;
+            case 130:
+            case 76:
+            case 62:
+                this.relight[i]++;
+            case 54:
+            case 146:
+            case 61:
+            case 65:
+            case 68:
+            case 50:
+                if (data < 2) {
+                    data = 2;
+                }
+            default:
+                vs[j] = id + (data << 12);
+                return;
+        }
+    }
+
+    @Override
+    public PlotChunk clone() {
+        FastChunk_1_9 toReturn = new FastChunk_1_9(getChunkWrapper());
+        toReturn.air = this.air.clone();
+        toReturn.count = this.count.clone();
+        toReturn.relight = this.relight.clone();
+        toReturn.ids = new int[this.ids.length][];
+        for (int i = 0; i < this.ids.length; i++) {
+            int[] matrix = this.ids[i];
+            if (matrix != null) {
+                toReturn.ids[i] = new int[matrix.length];
+                System.arraycopy(matrix, 0, toReturn.ids[i], 0, matrix.length);
+            }
+        }
+        return toReturn;
+    }
+
+    @Override
+    public PlotChunk shallowClone() {
+        FastChunk_1_9 toReturn = new FastChunk_1_9(getChunkWrapper());
+        toReturn.air = this.air;
+        toReturn.count = this.count;
+        toReturn.relight = this.relight;
+        toReturn.ids = this.ids;
+        return toReturn;
+    }
+
+    @Override
+    public void setBiome(int x, int z, int biome) {
+        if (this.biomes == null) {
+            this.biomes = new int[16][16];
+        }
+        this.biomes[x][z] = biome;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_7.java

@@ -25,36 +25,35 @@ import java.util.Map.Entry;
 
 public class FastQueue_1_7 extends SlowQueue {
 
-    public final RefClass classBlock = getRefClass("{nms}.Block");
+    private final RefClass classBlock = getRefClass("{nms}.Block");
-    public final RefClass classChunk = getRefClass("{nms}.Chunk");
+    private final RefClass classChunk = getRefClass("{nms}.Chunk");
-    public final RefClass classWorld = getRefClass("{nms}.World");
+    private final RefClass classWorld = getRefClass("{nms}.World");
-    public final RefClass classCraftWorld = getRefClass("{cb}.CraftWorld");
+    private final RefClass classCraftWorld = getRefClass("{cb}.CraftWorld");
-    public final RefMethod methodGetHandle;
+    private final RefMethod methodGetHandle;
-    public final RefMethod methodGetChunkAt;
+    private final RefMethod methodGetChunkAt;
-    public final RefMethod methodA;
+    private final RefMethod methodA;
-    public final RefMethod methodGetById;
+    private final RefMethod methodGetById;
-    public final RefMethod methodInitLighting;
+    private final RefMethod methodInitLighting;
+    private final SendChunk sendChunk;
 
-    public final SendChunk chunksender;
+    private final HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
 
-    public HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
+    public FastQueue_1_7() throws RuntimeException {
-
+        this.methodGetHandle = this.classCraftWorld.getMethod("getHandle");
-    public FastQueue_1_7() throws NoSuchMethodException, RuntimeException {
+        this.methodGetChunkAt = this.classWorld.getMethod("getChunkAt", int.class, int.class);
-        methodGetHandle = classCraftWorld.getMethod("getHandle");
+        this.methodA = this.classChunk.getMethod("a", int.class, int.class, int.class, this.classBlock, int.class);
-        methodGetChunkAt = classWorld.getMethod("getChunkAt", int.class, int.class);
+        this.methodGetById = this.classBlock.getMethod("getById", int.class);
-        methodA = classChunk.getMethod("a", int.class, int.class, int.class, classBlock, int.class);
+        this.methodInitLighting = this.classChunk.getMethod("initLighting");
-        methodGetById = classBlock.getMethod("getById", int.class);
+        this.sendChunk = new SendChunk();
-        methodInitLighting = classChunk.getMethod("initLighting");
-        chunksender = new SendChunk();
         TaskManager.runTaskRepeat(new Runnable() {
             @Override
             public void run() {
-                if (toUpdate.isEmpty()) {
+                if (FastQueue_1_7.this.toUpdate.isEmpty()) {
                     return;
                 }
                 int count = 0;
-                final ArrayList<Chunk> chunks = new ArrayList<>();
+                ArrayList<Chunk> chunks = new ArrayList<>();
-                final Iterator<Entry<ChunkWrapper, Chunk>> i = toUpdate.entrySet().iterator();
+                Iterator<Entry<ChunkWrapper, Chunk>> i = FastQueue_1_7.this.toUpdate.entrySet().iterator();
                 while (i.hasNext() && (count < 128)) {
                     chunks.add(i.next().getValue());
                     i.remove();
@@ -69,12 +68,12 @@ public class FastQueue_1_7 extends SlowQueue {
         MainUtil.initCache();
     }
 
-    public void update(final Collection<Chunk> chunks) {
+    public void update(Collection<Chunk> chunks) {
         if (chunks.isEmpty()) {
             return;
         }
         if (!MainUtil.canSendChunk) {
-            for (final Chunk chunk : chunks) {
+            for (Chunk chunk : chunks) {
                 chunk.getWorld().refreshChunk(chunk.getX(), chunk.getZ());
                 chunk.unload(true, false);
                 chunk.load();
@@ -82,8 +81,8 @@ public class FastQueue_1_7 extends SlowQueue {
             return;
         }
         try {
-            chunksender.sendChunk(chunks);
+            this.sendChunk.sendChunk(chunks);
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
             MainUtil.canSendChunk = false;
         }
@@ -91,36 +90,36 @@ public class FastQueue_1_7 extends SlowQueue {
 
     /**
      * This should be overridden by any specialized queues
-     * @param pc
+     * @param plotChunk
      */
     @Override
-    public void execute(PlotChunk<Chunk> pc) {
+    public void execute(PlotChunk<Chunk> plotChunk) {
-        SlowChunk sc = (SlowChunk) pc;
+        SlowChunk sc = (SlowChunk) plotChunk;
-        Chunk chunk = pc.getChunk();
+        Chunk chunk = plotChunk.getChunk();
-        ChunkWrapper wrapper = pc.getChunkWrapper();
+        ChunkWrapper wrapper = plotChunk.getChunkWrapper();
-        if (!toUpdate.containsKey(wrapper)) {
+        if (!this.toUpdate.containsKey(wrapper)) {
-            toUpdate.put(wrapper, chunk);
+            this.toUpdate.put(wrapper, chunk);
         }
         chunk.load(true);
         World world = chunk.getWorld();
-        final Object w = methodGetHandle.of(world).call();
+        Object w = this.methodGetHandle.of(world).call();
-        final Object c = methodGetChunkAt.of(w).call(wrapper.x, wrapper.z);
+        Object c = this.methodGetChunkAt.of(w).call(wrapper.x, wrapper.z);
         for (int i = 0; i < sc.result.length; i++) {
             PlotBlock[] result2 = sc.result[i];
             if (result2 == null) {
                 continue;
             }
             for (int j = 0; j < 4096; j++) {
-                final int x = MainUtil.x_loc[i][j];
+                int x = MainUtil.x_loc[i][j];
-                final int y = MainUtil.y_loc[i][j];
+                int y = MainUtil.y_loc[i][j];
-                final int z = MainUtil.z_loc[i][j];
+                int z = MainUtil.z_loc[i][j];
                 PlotBlock newBlock = result2[j];
                 if (newBlock.id == -1) {
                     chunk.getBlock(x, y, z).setData(newBlock.data, false);
                     continue;
                 }
-                final Object block = methodGetById.call(newBlock.id);
+                Object block = this.methodGetById.call(newBlock.id);
-                methodA.of(c).call(x, y, z, block, newBlock.data);
+                this.methodA.of(c).call(x, y, z, block, newBlock.data);
             }
         }
         int[][] biomes = sc.biomes;
@@ -152,30 +151,29 @@ public class FastQueue_1_7 extends SlowQueue {
     }
 
     /**
-     * This should be overriden by any specialized queues 
+     * This should be overridden by any specialized queues
      * @param chunk
      * @param fixAll
      */
     @Override
     public boolean fixLighting(PlotChunk<Chunk> chunk, boolean fixAll) {
-        Object c = methodGetHandle.of(chunk.getChunk()).call();
+        Object c = this.methodGetHandle.of(chunk.getChunk()).call();
-        methodInitLighting.of(c).call();
+        this.methodInitLighting.of(c).call();
         return true;
     }
 
     /**
      * This should be overridden by any specialized queues
      * @param world
-     * @param locs
+     * @param locations
      */
     @Override
-    public void sendChunk(String world, Collection<ChunkLoc> locs) {
+    public void sendChunk(String world, Collection<ChunkLoc> locations) {
         World worldObj = BukkitUtil.getWorld(world);
-        for (ChunkLoc loc : locs) {
+        for (ChunkLoc loc : locations) {
             ChunkWrapper wrapper = SetQueue.IMP.new ChunkWrapper(world, loc.x, loc.z);
-            if (!toUpdate.containsKey(wrapper)) {
+            this.toUpdate.remove(wrapper);
-                toUpdate.put(wrapper, worldObj.getChunkAt(loc.x, loc.z));
-            }
         }
+        this.sendChunk.sendChunk(world, locations);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_8.java

@@ -27,39 +27,39 @@ import java.util.Map.Entry;
 
 public class FastQueue_1_8 extends SlowQueue {
 
-    public final RefMethod methodInitLighting;
+    private final RefMethod methodInitLighting;
     private final RefClass classBlock = getRefClass("{nms}.Block");
     private final RefClass classBlockPosition = getRefClass("{nms}.BlockPosition");
     private final RefClass classIBlockData = getRefClass("{nms}.IBlockData");
     private final RefClass classChunk = getRefClass("{nms}.Chunk");
     private final RefClass classWorld = getRefClass("{nms}.World");
     private final RefClass classCraftWorld = getRefClass("{cb}.CraftWorld");
-    public HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
+    private final HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
-    private RefMethod methodGetHandle;
+    private final RefMethod methodGetHandle;
-    private RefMethod methodGetChunkAt;
+    private final RefMethod methodGetChunkAt;
-    private RefMethod methodA;
+    private final RefMethod methodA;
-    private RefMethod methodGetByCombinedId;
+    private final RefMethod methodGetByCombinedId;
-    private RefConstructor constructorBlockPosition;
+    private final RefConstructor constructorBlockPosition;
-    private SendChunk chunksender;
+    private final SendChunk sendChunk;
 
-    public FastQueue_1_8() throws NoSuchMethodException, RuntimeException {
+    public FastQueue_1_8() throws RuntimeException {
-        methodInitLighting = classChunk.getMethod("initLighting");
+        this.methodInitLighting = this.classChunk.getMethod("initLighting");
-        constructorBlockPosition = classBlockPosition.getConstructor(int.class, int.class, int.class);
+        this.constructorBlockPosition = this.classBlockPosition.getConstructor(int.class, int.class, int.class);
-        methodGetByCombinedId = classBlock.getMethod("getByCombinedId", int.class);
+        this.methodGetByCombinedId = this.classBlock.getMethod("getByCombinedId", int.class);
-        methodGetHandle = classCraftWorld.getMethod("getHandle");
+        this.methodGetHandle = this.classCraftWorld.getMethod("getHandle");
-        methodGetChunkAt = classWorld.getMethod("getChunkAt", int.class, int.class);
+        this.methodGetChunkAt = this.classWorld.getMethod("getChunkAt", int.class, int.class);
-        methodA = classChunk.getMethod("a", classBlockPosition, classIBlockData);
+        this.methodA = this.classChunk.getMethod("a", this.classBlockPosition, this.classIBlockData);
-        chunksender = new SendChunk();
+        this.sendChunk = new SendChunk();
         TaskManager.runTaskRepeat(new Runnable() {
             @Override
             public void run() {
-                if (toUpdate.isEmpty()) {
+                if (FastQueue_1_8.this.toUpdate.isEmpty()) {
                     return;
                 }
                 int count = 0;
-                final ArrayList<Chunk> chunks = new ArrayList<Chunk>();
+                ArrayList<Chunk> chunks = new ArrayList<Chunk>();
-                final Iterator<Entry<ChunkWrapper, Chunk>> i = toUpdate.entrySet().iterator();
+                Iterator<Entry<ChunkWrapper, Chunk>> i = FastQueue_1_8.this.toUpdate.entrySet().iterator();
-                while (i.hasNext() && (count < 128)) {
+                while (i.hasNext() && count < 128) {
                     chunks.add(i.next().getValue());
                     i.remove();
                     count++;
@@ -73,12 +73,12 @@ public class FastQueue_1_8 extends SlowQueue {
         MainUtil.initCache();
     }
 
-    public void update(final Collection<Chunk> chunks) {
+    public void update(Collection<Chunk> chunks) {
         if (chunks.isEmpty()) {
             return;
         }
         if (!MainUtil.canSendChunk) {
-            for (final Chunk chunk : chunks) {
+            for (Chunk chunk : chunks) {
                 chunk.getWorld().refreshChunk(chunk.getX(), chunk.getZ());
                 chunk.unload(true, false);
                 chunk.load();
@@ -86,38 +86,38 @@ public class FastQueue_1_8 extends SlowQueue {
             return;
         }
         try {
-            chunksender.sendChunk(chunks);
+            this.sendChunk.sendChunk(chunks);
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
             MainUtil.canSendChunk = false;
         }
     }
 
     /**
-     * This should be overriden by any specialized queues 
+     * This should be overridden by any specialized queues.
-     * @param pc
+     * @param plotChunk
      */
     @Override
-    public void execute(PlotChunk<Chunk> pc) {
+    public void execute(PlotChunk<Chunk> plotChunk) {
-        SlowChunk sc = (SlowChunk) pc;
+        SlowChunk sc = (SlowChunk) plotChunk;
-        Chunk chunk = pc.getChunk();
+        Chunk chunk = plotChunk.getChunk();
-        ChunkWrapper wrapper = pc.getChunkWrapper();
+        ChunkWrapper wrapper = plotChunk.getChunkWrapper();
-        if (!toUpdate.containsKey(wrapper)) {
+        if (!this.toUpdate.containsKey(wrapper)) {
-            toUpdate.put(wrapper, chunk);
+            this.toUpdate.put(wrapper, chunk);
         }
         chunk.load(true);
         World world = chunk.getWorld();
-        final Object w = methodGetHandle.of(world).call();
+        Object w = this.methodGetHandle.of(world).call();
-        final Object c = methodGetChunkAt.of(w).call(wrapper.x, wrapper.z);
+        Object c = this.methodGetChunkAt.of(w).call(wrapper.x, wrapper.z);
         for (int i = 0; i < sc.result.length; i++) {
             PlotBlock[] result2 = sc.result[i];
             if (result2 == null) {
                 continue;
             }
             for (int j = 0; j < 4096; j++) {
-                final int x = MainUtil.x_loc[i][j];
+                int x = MainUtil.x_loc[i][j];
-                final int y = MainUtil.y_loc[i][j];
+                int y = MainUtil.y_loc[i][j];
-                final int z = MainUtil.z_loc[i][j];
+                int z = MainUtil.z_loc[i][j];
                 PlotBlock newBlock = result2[j];
                 if (newBlock.id == -1) {
                     chunk.getBlock(x, y, z).setData(newBlock.data, false);
@@ -161,8 +161,8 @@ public class FastQueue_1_8 extends SlowQueue {
                     case 29:
                     case 33:
                     case 151:
-                    case 178: {
+                    case 178:
-                        final Block block = world.getBlockAt(x, y, z);
+                        Block block = world.getBlockAt(x, y, z);
                         if (block.getData() == newBlock.data) {
                             if (block.getTypeId() != newBlock.id) {
                                 block.setTypeId(newBlock.id, false);
@@ -175,12 +175,11 @@ public class FastQueue_1_8 extends SlowQueue {
                             }
                         }
                         continue;
-                    }
                 }
 
                 // Start data value shortcut
-                final Block block = world.getBlockAt(x, y, z);
+                Block block = world.getBlockAt(x, y, z);
-                final int currentId = block.getTypeId();
+                int currentId = block.getTypeId();
                 if (currentId == newBlock.id) {
                     switch (newBlock.id) {
                         case 0:
@@ -263,9 +262,8 @@ public class FastQueue_1_8 extends SlowQueue {
                         case 189:
                         case 190:
                         case 191:
-                        case 192: {
+                        case 192:
                             continue;
-                        }
                     }
                     if (block.getData() == newBlock.data) {
                         return;
@@ -311,21 +309,20 @@ public class FastQueue_1_8 extends SlowQueue {
                     case 29:
                     case 33:
                     case 151:
-                    case 178: {
+                    case 178:
                         if (block.getData() == newBlock.data) {
                             block.setTypeId(newBlock.id, false);
                         } else {
                             block.setTypeIdAndData(newBlock.id, newBlock.data, false);
                         }
                         continue;
-                    }
                 }
                 // End blockstate workaround //
 
                 // check sign
-                final Object pos = constructorBlockPosition.create(x, y, z);
+                Object pos = this.constructorBlockPosition.create(x, y, z);
-                final Object combined = methodGetByCombinedId.call(newBlock.id + (newBlock.data << 12));
+                Object combined = this.methodGetByCombinedId.call(newBlock.id + (newBlock.data << 12));
-                methodA.of(chunk).call(pos, combined);
+                this.methodA.of(chunk).call(pos, combined);
             }
         }
         int[][] biomes = sc.biomes;
@@ -348,7 +345,7 @@ public class FastQueue_1_8 extends SlowQueue {
     }
 
     /**
-     * This should be overridden by any specialized queues
+     * This should be overridden by any specialized queues.
      * @param wrap
      */
     @Override
@@ -357,28 +354,27 @@ public class FastQueue_1_8 extends SlowQueue {
     }
 
     /**
-     * This should be overridden by any specialized queues
+     * This should be overridden by any specialized queues.
      * @param fixAll
      */
     @Override
     public boolean fixLighting(PlotChunk<Chunk> chunk, boolean fixAll) {
-        Object c = methodGetHandle.of(chunk.getChunk()).call();
+        Object c = this.methodGetHandle.of(chunk.getChunk()).call();
-        methodInitLighting.of(c).call();
+        this.methodInitLighting.of(c).call();
         return true;
     }
 
     /**
-     * This should be overridden by any specialized queues
+     * This should be overridden by any specialized queues.
-     * @param locs
+     * @param locations
      */
     @Override
-    public void sendChunk(String world, Collection<ChunkLoc> locs) {
+    public void sendChunk(String world, Collection<ChunkLoc> locations) {
         World worldObj = BukkitUtil.getWorld(world);
-        for (ChunkLoc loc : locs) {
+        for (ChunkLoc loc : locations) {
             ChunkWrapper wrapper = SetQueue.IMP.new ChunkWrapper(world, loc.x, loc.z);
-            if (!toUpdate.containsKey(wrapper)) {
+            this.toUpdate.remove(wrapper);
-                toUpdate.put(wrapper, worldObj.getChunkAt(loc.x, loc.z));
-            }
         }
+        this.sendChunk.sendChunk(world, locations);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_8_3.java

@@ -1,7 +1,5 @@
 package com.plotsquared.bukkit.util.block;
 
-import static com.intellectualcrafters.plot.util.ReflectionUtils.getRefClass;
-
 import com.intellectualcrafters.plot.object.ChunkLoc;
 import com.intellectualcrafters.plot.object.PseudoRandom;
 import com.intellectualcrafters.plot.util.ChunkManager;
@@ -15,14 +13,7 @@ import com.intellectualcrafters.plot.util.ReflectionUtils.RefMethod.RefExecutor;
 import com.intellectualcrafters.plot.util.SetQueue;
 import com.intellectualcrafters.plot.util.SetQueue.ChunkWrapper;
 import com.intellectualcrafters.plot.util.TaskManager;
-import com.plotsquared.bukkit.util.BukkitUtil;
 import com.plotsquared.bukkit.util.SendChunk;
-import org.bukkit.Chunk;
-import org.bukkit.Material;
-import org.bukkit.World;
-import org.bukkit.World.Environment;
-import org.bukkit.block.Biome;
-
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
@@ -30,58 +21,61 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Iterator;
-import java.util.List;
 import java.util.Map.Entry;
 import java.util.Set;
+import org.bukkit.Chunk;
+import org.bukkit.Material;
+import org.bukkit.World;
+import org.bukkit.World.Environment;
+import org.bukkit.block.Biome;
+
+
+import static com.intellectualcrafters.plot.util.ReflectionUtils.getRefClass;
 
 public class FastQueue_1_8_3 extends SlowQueue {
 
-    public final SendChunk chunksender;
+    private final SendChunk sendChunk;
-    private final RefClass classEntityPlayer = getRefClass("{nms}.EntityPlayer");
+    private final HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
-    private final RefClass classMapChunk = getRefClass("{nms}.PacketPlayOutMapChunk");
+    private final RefMethod methodGetHandleChunk;
-    private final RefClass classPacket = getRefClass("{nms}.Packet");
+    private final RefMethod methodInitLighting;
-    private final RefClass classConnection = getRefClass("{nms}.PlayerConnection");
+    private final RefConstructor classBlockPositionConstructor;
-    private final RefClass classChunk = getRefClass("{nms}.Chunk");
+    private final RefConstructor classChunkSectionConstructor;
-    private final RefClass classCraftPlayer = getRefClass("{cb}.entity.CraftPlayer");
+    private final RefMethod methodX;
-    private final RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
+    private final RefMethod methodAreNeighborsLoaded;
-    private final RefClass classWorld = getRefClass("{nms}.World");
+    private final RefField fieldSections;
-    private final RefField mustSave = classChunk.getField("mustSave");
+    private final RefField fieldWorld;
-    private final RefClass classBlockPosition = getRefClass("{nms}.BlockPosition");
+    private final RefMethod methodGetIdArray;
-    private final RefClass classChunkSection = getRefClass("{nms}.ChunkSection");
+    private final RefMethod methodGetWorld;
-    public HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
+    private final RefField tileEntityListTick;
-    private RefMethod methodGetHandleChunk;
-    private RefConstructor MapChunk;
-    private RefMethod methodInitLighting;
-    private RefConstructor classBlockPositionConstructor;
-    private RefConstructor classChunkSectionConstructor;
-    private RefMethod methodX;
-    private RefMethod methodAreNeighborsLoaded;
-    private RefField fieldSections;
-    private RefField fieldWorld;
-    private RefMethod methodGetIdArray;
 
-    public FastQueue_1_8_3() throws NoSuchMethodException, RuntimeException {
+    public FastQueue_1_8_3() throws RuntimeException {
-        methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
+        RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
-        methodInitLighting = classChunk.getMethod("initLighting");
+        this.methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
-        MapChunk = classMapChunk.getConstructor(classChunk.getRealClass(), boolean.class, int.class);
+        RefClass classChunk = getRefClass("{nms}.Chunk");
-        classBlockPositionConstructor = classBlockPosition.getConstructor(int.class, int.class, int.class);
+        this.methodInitLighting = classChunk.getMethod("initLighting");
-        methodX = classWorld.getMethod("x", classBlockPosition.getRealClass());
+        RefClass classBlockPosition = getRefClass("{nms}.BlockPosition");
-        fieldSections = classChunk.getField("sections");
+        this.classBlockPositionConstructor = classBlockPosition.getConstructor(int.class, int.class, int.class);
-        fieldWorld = classChunk.getField("world");
+        RefClass classWorld = getRefClass("{nms}.World");
-        methodGetIdArray = classChunkSection.getMethod("getIdArray");
+        this.methodX = classWorld.getMethod("x", classBlockPosition.getRealClass());
-        methodAreNeighborsLoaded = classChunk.getMethod("areNeighborsLoaded", int.class);
+        this.fieldSections = classChunk.getField("sections");
-        classChunkSectionConstructor = classChunkSection.getConstructor(int.class, boolean.class, char[].class);
+        this.fieldWorld = classChunk.getField("world");
-        chunksender = new SendChunk();
+        RefClass classChunkSection = getRefClass("{nms}.ChunkSection");
+        this.methodGetIdArray = classChunkSection.getMethod("getIdArray");
+        this.methodAreNeighborsLoaded = classChunk.getMethod("areNeighborsLoaded", int.class);
+        this.classChunkSectionConstructor = classChunkSection.getConstructor(int.class, boolean.class, char[].class);
+        this.tileEntityListTick = classWorld.getField("tileEntityList");
+        this.methodGetWorld = classChunk.getMethod("getWorld");
+        this.sendChunk = new SendChunk();
         TaskManager.runTaskRepeat(new Runnable() {
             @Override
             public void run() {
-                if (toUpdate.isEmpty()) {
+                if (FastQueue_1_8_3.this.toUpdate.isEmpty()) {
                     return;
                 }
                 int count = 0;
-                final ArrayList<Chunk> chunks = new ArrayList<Chunk>();
+                ArrayList<Chunk> chunks = new ArrayList<>();
-                final Iterator<Entry<ChunkWrapper, Chunk>> i = toUpdate.entrySet().iterator();
+                Iterator<Entry<ChunkWrapper, Chunk>> i = FastQueue_1_8_3.this.toUpdate.entrySet().iterator();
-                while (i.hasNext() && (count < 128)) {
+                while (i.hasNext() && count < 128) {
                     chunks.add(i.next().getValue());
                     i.remove();
                     count++;
@@ -95,12 +89,12 @@ public class FastQueue_1_8_3 extends SlowQueue {
         MainUtil.initCache();
     }
 
-    public void update(final Collection<Chunk> chunks) {
+    public void update(Collection<Chunk> chunks) {
         if (chunks.isEmpty()) {
             return;
         }
         if (!MainUtil.canSendChunk) {
-            for (final Chunk chunk : chunks) {
+            for (Chunk chunk : chunks) {
                 chunk.getWorld().refreshChunk(chunk.getX(), chunk.getZ());
                 chunk.unload(true, false);
                 chunk.load();
@@ -108,72 +102,77 @@ public class FastQueue_1_8_3 extends SlowQueue {
             return;
         }
         try {
-            chunksender.sendChunk(chunks);
+            this.sendChunk.sendChunk(chunks);
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
             MainUtil.canSendChunk = false;
         }
     }
 
     /**
-     * This should be overridden by any specialized queues
+     * This should be overridden by any specialized queues.
-     * @param pc
+     * @param plotChunk
      */
     @Override
-    public void execute(PlotChunk<Chunk> pc) {
+    public void execute(PlotChunk<Chunk> plotChunk) {
-        FastChunk_1_8_3 fs = (FastChunk_1_8_3) pc;
+        FastChunk_1_8_3 fs = (FastChunk_1_8_3) plotChunk;
-        Chunk chunk = pc.getChunk();
+        Chunk chunk = plotChunk.getChunk();
-        final World world = chunk.getWorld();
+        World world = chunk.getWorld();
-        ChunkWrapper wrapper = pc.getChunkWrapper();
+        ChunkWrapper wrapper = plotChunk.getChunkWrapper();
-        if (!toUpdate.containsKey(wrapper)) {
+        if (!this.toUpdate.containsKey(wrapper)) {
-            toUpdate.put(wrapper, chunk);
+            this.toUpdate.put(wrapper, chunk);
         }
         chunk.load(true);
         try {
-            final boolean flag = world.getEnvironment() == Environment.NORMAL;
+            boolean flag = world.getEnvironment() == Environment.NORMAL;
 
             // Sections
-            final Method getHandele = chunk.getClass().getDeclaredMethod("getHandle");
+            Method getHandle = chunk.getClass().getDeclaredMethod("getHandle");
-            final Object c = getHandele.invoke(chunk);
+            Object c = getHandle.invoke(chunk);
-            final Class<? extends Object> clazz = c.getClass();
+            Object w = this.methodGetWorld.of(c).call();
-            final Field sf = clazz.getDeclaredField("sections");
+            Class<? extends Object> clazz = c.getClass();
-            sf.setAccessible(true);
+            Field sections1 = clazz.getDeclaredField("sections");
-            final Field tf = clazz.getDeclaredField("tileEntities");
+            sections1.setAccessible(true);
-            final Field ef = clazz.getDeclaredField("entitySlices");
+            Field tileEntities = clazz.getDeclaredField("tileEntities");
+            Field entitySlices = clazz.getDeclaredField("entitySlices");
+            Object[] sections = (Object[]) sections1.get(c);
+            HashMap<?, ?> tiles = (HashMap<?, ?>) tileEntities.get(c);
+            Collection<?>[] entities = (Collection<?>[]) entitySlices.get(c);
 
-            final Object[] sections = (Object[]) sf.get(c);
+            Method getX = null;
-            final HashMap<?, ?> tiles = (HashMap<?, ?>) tf.get(c);
+            Method getY = null;
-            final List<?>[] entities = (List<?>[]) ef.get(c);
+            Method getZ = null;
-
-            Method xm = null;
-            Method ym = null;
-            Method zm = null;
 
             // Trim tiles
-            final Set<Entry<?, ?>> entryset = (Set<Entry<?, ?>>) (Set<?>) tiles.entrySet();
+            boolean removed = false;
-            final Iterator<Entry<?, ?>> iter = entryset.iterator();
+            Set<Entry<?, ?>> entrySet = (Set<Entry<?, ?>>) (Set<?>) tiles.entrySet();
-            while (iter.hasNext()) {
+            Iterator<Entry<?, ?>> iterator = entrySet.iterator();
-                final Entry<?, ?> tile = iter.next();
+            while (iterator.hasNext()) {
-                final Object pos = tile.getKey();
+                Entry<?, ?> tile = iterator.next();
-                if (xm == null) {
+                Object pos = tile.getKey();
-                    final Class<? extends Object> clazz2 = pos.getClass().getSuperclass();
+                if (getX == null) {
-                    xm = clazz2.getDeclaredMethod("getX");
+                    Class<? extends Object> clazz2 = pos.getClass().getSuperclass();
-                    ym = clazz2.getDeclaredMethod("getY");
+                    getX = clazz2.getDeclaredMethod("getX");
-                    zm = clazz2.getDeclaredMethod("getZ");
+                    getY = clazz2.getDeclaredMethod("getY");
+                    getZ = clazz2.getDeclaredMethod("getZ");
                 }
-                final int lx = (int) xm.invoke(pos) & 15;
+                int lx = (int) getX.invoke(pos) & 15;
-                final int ly = (int) ym.invoke(pos);
+                int ly = (int) getY.invoke(pos);
-                final int lz = (int) zm.invoke(pos) & 15;
+                int lz = (int) getZ.invoke(pos) & 15;
-                final int j = MainUtil.CACHE_I[ly][lx][lz];
+                int j = MainUtil.CACHE_I[ly][lx][lz];
-                final int k = MainUtil.CACHE_J[ly][lx][lz];
+                int k = MainUtil.CACHE_J[ly][lx][lz];
-                final char[] array = fs.getIdArray(j);
+                char[] array = fs.getIdArray(j);
                 if (array == null) {
                     continue;
                 }
                 if (array[k] != 0) {
-                    iter.remove();
+                    removed = true;
+                    iterator.remove();
                 }
             }
+            if (removed) {
+                ((Collection) this.tileEntityListTick.of(w).get()).clear();
+            }
 
             // Trim entities
             for (int i = 0; i < 16; i++) {
@@ -187,7 +186,7 @@ public class FastQueue_1_8_3 extends SlowQueue {
                 if (fs.getCount(j) == 0) {
                     continue;
                 }
-                final char[] newArray = fs.getIdArray(j);
+                char[] newArray = fs.getIdArray(j);
                 if (newArray == null) {
                     continue;
                 }
@@ -196,10 +195,10 @@ public class FastQueue_1_8_3 extends SlowQueue {
                     section = sections[j] = newChunkSection(j << 4, flag, newArray);
                     continue;
                 }
-                final char[] currentArray = getIdArray(section);
+                char[] currentArray = getIdArray(section);
                 boolean fill = true;
                 for (int k = 0; k < newArray.length; k++) {
-                    final char n = newArray[k];
+                    char n = newArray[k];
                     switch (n) {
                         case 0:
                             fill = false;
@@ -218,8 +217,8 @@ public class FastQueue_1_8_3 extends SlowQueue {
                 }
             }
             // Clear
-        } catch (IllegalAccessException | IllegalArgumentException | NoSuchMethodException | SecurityException | InvocationTargetException |
+        } catch (IllegalAccessException | IllegalArgumentException | NoSuchMethodException | SecurityException | InvocationTargetException
-                NoSuchFieldException e) {
+                | NoSuchFieldException e) {
             e.printStackTrace();
         }
         int[][] biomes = fs.biomes;
@@ -241,16 +240,16 @@ public class FastQueue_1_8_3 extends SlowQueue {
         }
     }
 
-    public Object newChunkSection(final int i, final boolean flag, final char[] ids) {
+    public Object newChunkSection(int i, boolean flag, char[] ids) {
-        return classChunkSectionConstructor.create(i, flag, ids);
+        return this.classChunkSectionConstructor.create(i, flag, ids);
     }
 
-    public char[] getIdArray(final Object obj) {
+    public char[] getIdArray(Object obj) {
-        return (char[]) methodGetIdArray.of(obj).call();
+        return (char[]) this.methodGetIdArray.of(obj).call();
     }
 
     /**
-     * This should be overridden by any specialized queues
+     * This should be overridden by any specialized queues.
      * @param wrap
      */
     @Override
@@ -260,13 +259,13 @@ public class FastQueue_1_8_3 extends SlowQueue {
 
     /**
      * This should be overridden by any specialized queues
-     * @param pc
+     * @param plotChunk
      */
     @Override
-    public boolean fixLighting(PlotChunk<Chunk> pc, boolean fixAll) {
+    public boolean fixLighting(PlotChunk<Chunk> plotChunk, boolean fixAll) {
         try {
-            FastChunk_1_8_3 bc = (FastChunk_1_8_3) pc;
+            FastChunk_1_8_3 bc = (FastChunk_1_8_3) plotChunk;
-            final Chunk chunk = bc.getChunk();
+            Chunk chunk = bc.getChunk();
             if (!chunk.isLoaded()) {
                 chunk.load(false);
             } else {
@@ -275,12 +274,12 @@ public class FastQueue_1_8_3 extends SlowQueue {
             }
 
             // Initialize lighting
-            final Object c = methodGetHandleChunk.of(chunk).call();
+            Object c = this.methodGetHandleChunk.of(chunk).call();
 
-            if (fixAll && !(boolean) methodAreNeighborsLoaded.of(c).call(1)) {
+            if (fixAll && !(boolean) this.methodAreNeighborsLoaded.of(c).call(1)) {
                 World world = chunk.getWorld();
                 ChunkWrapper wrapper = bc.getChunkWrapper();
-                String worldname = wrapper.world;
+                String worldName = wrapper.world;
                 for (int x = wrapper.x - 1; x <= wrapper.x + 1; x++) {
                     for (int z = wrapper.z - 1; z <= wrapper.z + 1; z++) {
                         if (x != 0 && z != 0) {
@@ -288,44 +287,46 @@ public class FastQueue_1_8_3 extends SlowQueue {
                             while (!other.isLoaded()) {
                                 other.load(true);
                             }
-                            ChunkManager.manager.loadChunk(worldname, new ChunkLoc(x, z), true);
+                            ChunkManager.manager.loadChunk(worldName, new ChunkLoc(x, z), true);
                         }
                     }
                 }
+/*
                 if (!(boolean) methodAreNeighborsLoaded.of(c).call(1)) {
                     return false;
                 }
+*/
             }
 
-            methodInitLighting.of(c).call();
+            this.methodInitLighting.of(c).call();
 
-            if ((bc.getTotalRelight() == 0 && !fixAll)) {
+            if (bc.getTotalRelight() == 0 && !fixAll) {
                 return true;
             }
 
-            final Object[] sections = (Object[]) fieldSections.of(c).get();
+            Object[] sections = (Object[]) this.fieldSections.of(c).get();
-            final Object w = fieldWorld.of(c).get();
+            Object w = this.fieldWorld.of(c).get();
 
-            final int X = chunk.getX() << 4;
+            int X = chunk.getX() << 4;
-            final int Z = chunk.getZ() << 4;
+            int Z = chunk.getZ() << 4;
 
-            RefExecutor relight = methodX.of(w);
+            RefExecutor relight = this.methodX.of(w);
             for (int j = 0; j < sections.length; j++) {
-                final Object section = sections[j];
+                Object section = sections[j];
                 if (section == null) {
                     continue;
                 }
                 if ((bc.getRelight(j) == 0 && !fixAll) || bc.getCount(j) == 0 || (bc.getCount(j) >= 4096 && bc.getAir(j) == 0)) {
                     continue;
                 }
-                final char[] array = getIdArray(section);
+                char[] array = getIdArray(section);
                 int l = PseudoRandom.random.random(2);
                 for (int k = 0; k < array.length; k++) {
-                    final int i = array[k];
+                    int i = array[k];
                     if (i < 16) {
                         continue;
                     }
-                    final short id = (short) (i >> 4);
+                    short id = (short) (i >> 4);
                     switch (id) { // Lighting
                         default:
                             if (!fixAll) {
@@ -350,19 +351,19 @@ public class FastQueue_1_8_3 extends SlowQueue {
                         case 130:
                         case 138:
                         case 169:
-                            final int x = MainUtil.x_loc[j][k];
+                            int x = MainUtil.x_loc[j][k];
-                            final int y = MainUtil.y_loc[j][k];
+                            int y = MainUtil.y_loc[j][k];
-                            final int z = MainUtil.z_loc[j][k];
+                            int z = MainUtil.z_loc[j][k];
                             if (isSurrounded(sections, x, y, z)) {
                                 continue;
                             }
-                            final Object pos = classBlockPositionConstructor.create(X + x, y, Z + z);
+                            Object pos = this.classBlockPositionConstructor.create(X + x, y, Z + z);
                             relight.call(pos);
                     }
                 }
             }
             return true;
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
         }
         return false;
@@ -398,18 +399,16 @@ public class FastQueue_1_8_3 extends SlowQueue {
     }
 
     /**
-     * This should be overridden by any specialized queues
+     * This should be overridden by any specialized queues.
      * @param world
-     * @param locs
+     * @param locations
      */
     @Override
-    public void sendChunk(String world, Collection<ChunkLoc> locs) {
+    public void sendChunk(String world, Collection<ChunkLoc> locations) {
-        World worldObj = BukkitUtil.getWorld(world);
+        for (ChunkLoc loc : locations) {
-        for (ChunkLoc loc : locs) {
             ChunkWrapper wrapper = SetQueue.IMP.new ChunkWrapper(world, loc.x, loc.z);
-            if (!toUpdate.containsKey(wrapper)) {
+            this.toUpdate.remove(wrapper);
-                toUpdate.put(wrapper, worldObj.getChunkAt(loc.x, loc.z));
-            }
         }
+        this.sendChunk.sendChunk(world, locations);
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_9.java

@@ -1,12 +1,422 @@
 package com.plotsquared.bukkit.util.block;
 
+import com.intellectualcrafters.plot.object.ChunkLoc;
+import com.intellectualcrafters.plot.object.PseudoRandom;
+import com.intellectualcrafters.plot.util.ChunkManager;
+import com.intellectualcrafters.plot.util.MainUtil;
 import com.intellectualcrafters.plot.util.PlotChunk;
-import com.intellectualcrafters.plot.util.SetQueue;
+import com.intellectualcrafters.plot.util.ReflectionUtils.RefClass;
+import com.intellectualcrafters.plot.util.ReflectionUtils.RefConstructor;
+import com.intellectualcrafters.plot.util.ReflectionUtils.RefField;
+import com.intellectualcrafters.plot.util.ReflectionUtils.RefMethod;
+import com.intellectualcrafters.plot.util.ReflectionUtils.RefMethod.RefExecutor;
+import com.intellectualcrafters.plot.util.SetQueue.ChunkWrapper;
+import com.intellectualcrafters.plot.util.TaskManager;
+import com.plotsquared.bukkit.util.BukkitUtil;
+import java.lang.reflect.Field;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map.Entry;
+import java.util.Set;
 import org.bukkit.Chunk;
+import org.bukkit.Material;
+import org.bukkit.World;
+import org.bukkit.World.Environment;
+import org.bukkit.block.Biome;
+
+
+import static com.intellectualcrafters.plot.util.ReflectionUtils.getRefClass;
 
 public class FastQueue_1_9 extends SlowQueue {
 
-    @Override public PlotChunk<Chunk> getChunk(SetQueue.ChunkWrapper wrap) {
+    private final Object air;
+//    private final HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
+    private final RefMethod methodGetHandleChunk;
+    private final RefMethod methodInitLighting;
+    private final RefConstructor classBlockPositionConstructor;
+    private final RefConstructor classChunkSectionConstructor;
+    private final RefMethod methodW;
+    private final RefMethod methodAreNeighborsLoaded;
+    private final RefField fieldSections;
+    private final RefField fieldWorld;
+    private final RefMethod methodGetBlocks;
+    private final RefMethod methodGetType;
+    private final RefMethod methodSetType;
+    private final RefMethod methodGetCombinedId;
+    private final RefMethod methodGetByCombinedId;
+    private final RefMethod methodGetWorld;
+
+    private final RefField tileEntityListTick;
+
+
+    public FastQueue_1_9() throws RuntimeException {
+        RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
+        this.methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
+        RefClass classChunk = getRefClass("{nms}.Chunk");
+        this.methodInitLighting = classChunk.getMethod("initLighting");
+        RefClass classBlockPosition = getRefClass("{nms}.BlockPosition");
+        this.classBlockPositionConstructor = classBlockPosition.getConstructor(int.class, int.class, int.class);
+        RefClass classWorld = getRefClass("{nms}.World");
+        this.tileEntityListTick = classWorld.getField("tileEntityListTick");
+        this.methodGetWorld = classChunk.getMethod("getWorld");
+        this.methodW = classWorld.getMethod("w", classBlockPosition.getRealClass());
+        this.fieldSections = classChunk.getField("sections");
+        this.fieldWorld = classChunk.getField("world");
+        RefClass classBlock = getRefClass("{nms}.Block");
+        RefClass classIBlockData = getRefClass("{nms}.IBlockData");
+        this.methodGetCombinedId = classBlock.getMethod("getCombinedId", classIBlockData.getRealClass());
+        this.methodGetByCombinedId = classBlock.getMethod("getByCombinedId", int.class);
+        RefClass classChunkSection = getRefClass("{nms}.ChunkSection");
+        this.methodGetBlocks = classChunkSection.getMethod("getBlocks");
+        this.methodGetType = classChunkSection.getMethod("getType", int.class, int.class, int.class);
+        this.methodSetType = classChunkSection.getMethod("setType", int.class, int.class, int.class, classIBlockData.getRealClass());
+        this.methodAreNeighborsLoaded = classChunk.getMethod("areNeighborsLoaded", int.class);
+        this.classChunkSectionConstructor = classChunkSection.getConstructor(int.class, boolean.class, char[].class);
+        this.air = this.methodGetByCombinedId.call(0);
+        MainUtil.initCache();
+    }
+
+    /**
+     * This should be overridden by any specialized queues
+     * @param plotChunk
+     */
+    @Override
+    public void execute(final PlotChunk<Chunk> plotChunk) {
+        final FastChunk_1_9 fs = (FastChunk_1_9) plotChunk;
+        Chunk chunk = plotChunk.getChunk();
+        World world = chunk.getWorld();
+        ChunkWrapper wrapper = plotChunk.getChunkWrapper();
+        chunk.load(true);
+        try {
+            boolean flag = world.getEnvironment() == Environment.NORMAL;
+
+            // Sections
+            Method getHandle = chunk.getClass().getDeclaredMethod("getHandle");
+            Object c = getHandle.invoke(chunk);
+            Object w = this.methodGetWorld.of(c).call();
+            Class<? extends Object> clazz = c.getClass();
+            Field sf = clazz.getDeclaredField("sections");
+            sf.setAccessible(true);
+            Field tf = clazz.getDeclaredField("tileEntities");
+            Field entitySlices = clazz.getDeclaredField("entitySlices");
+            Object[] sections = (Object[]) sf.get(c);
+            HashMap<?, ?> tiles = (HashMap<?, ?>) tf.get(c);
+            Collection<?>[] entities = (Collection<?>[]) entitySlices.get(c);
+
+            Method xm = null;
+            Method ym = null;
+            Method zm = null;
+            // Trim tiles
+            boolean removed = false;
+            Set<Entry<?, ?>> entrySet = (Set<Entry<?, ?>>) (Set<?>) tiles.entrySet();
+            Iterator<Entry<?, ?>> iterator = entrySet.iterator();
+            while (iterator.hasNext()) {
+                Entry<?, ?> tile = iterator.next();
+                Object pos = tile.getKey();
+                if (xm == null) {
+                    Class<? extends Object> clazz2 = pos.getClass().getSuperclass();
+                    xm = clazz2.getDeclaredMethod("getX");
+                    ym = clazz2.getDeclaredMethod("getY");
+                    zm = clazz2.getDeclaredMethod("getZ");
+                }
+                int lx = (int) xm.invoke(pos) & 15;
+                int ly = (int) ym.invoke(pos);
+                int lz = (int) zm.invoke(pos) & 15;
+                int j = MainUtil.CACHE_I[ly][lx][lz];
+                int k = MainUtil.CACHE_J[ly][lx][lz];
+                int[] array = fs.getIdArray(j);
+                if (array == null) {
+                    continue;
+                }
+                if (array[k] != 0) {
+                    removed = true;
+                    iterator.remove();
+                }
+            }
+            if (removed) {
+                ((Collection) this.tileEntityListTick.of(w).get()).clear();
+            }
+
+            // Trim entities
+            for (int i = 0; i < 16; i++) {
+                if (entities[i] != null && fs.getCount(i) >= 4096) {
+                    entities[i].clear();
+                }
+            }
+
+            // Efficiently merge sections
+            for (int j = 0; j < sections.length; j++) {
+                if (fs.getCount(j) == 0) {
+                    continue;
+                }
+                int[] newArray = fs.getIdArray(j);
+                if (newArray == null) {
+                    continue;
+                }
+                Object section = sections[j];
+                if (section == null || fs.getCount(j) >= 4096) {
+                    char[] array = new char[4096];
+                    for (int i = 0; i < newArray.length; i++) {
+                        int combined = newArray[i];
+                        int id = combined & 4095;
+                        int data = combined >> 12;
+                        array[i] = (char) ((id << 4) + data);
+                    }
+                    section = sections[j] = newChunkSection(j << 4, flag, array);
+                    continue;
+                }
+                Object currentArray = getBlocks(section);
+                RefExecutor setType = this.methodSetType.of(section);
+                boolean fill = true;
+                for (int k = 0; k < newArray.length; k++) {
+                    int n = newArray[k];
+                    switch (n) {
+                        case 0:
+                            fill = false;
+                            continue;
+                        case -1: {
+                            fill = false;
+                            int x = MainUtil.x_loc[j][k];
+                            int y = MainUtil.y_loc[j][k];
+                            int z = MainUtil.z_loc[j][k];
+                            setType.call(x, y & 15, z, this.air);
+                            continue;
+                        }
+                        default:
+                            int x = MainUtil.x_loc[j][k];
+                            int y = MainUtil.y_loc[j][k];
+                            int z = MainUtil.z_loc[j][k];
+                            Object iBlock = this.methodGetByCombinedId.call((int) n);
+                            setType.call(x, y & 15, z, iBlock);
+                    }
+                }
+                if (fill) {
+                    fs.setCount(j, Short.MAX_VALUE);
+                }
+            }
+            // Clear
+        } catch (IllegalAccessException | IllegalArgumentException | NoSuchMethodException | SecurityException | InvocationTargetException |
+                NoSuchFieldException e) {
+            e.printStackTrace();
+        }
+        int[][] biomes = fs.biomes;
+        Biome[] values = Biome.values();
+        if (biomes != null) {
+            for (int x = 0; x < 16; x++) {
+                int[] array = biomes[x];
+                if (array == null) {
+                    continue;
+                }
+                for (int z = 0; z < 16; z++) {
+                    int biome = array[z];
+                    if (biome == 0) {
+                        continue;
+                    }
+                    chunk.getBlock(x, 0, z).setBiome(values[biome]);
+                }
+            }
+        }
+        TaskManager.runTaskLater(new Runnable() {
+            @Override
+            public void run() {
+                sendChunk(fs.getChunkWrapper().world, Arrays.asList(new ChunkLoc(fs.getX(), fs.getZ())));
+            }
+        }, 1);
+    }
+
+    public Object newChunkSection(int i, boolean flag, char[] ids) {
+        return this.classChunkSectionConstructor.create(i, flag, ids);
+    }
+
+    public Object getBlocks(Object obj) {
+        return this.methodGetBlocks.of(obj).call();
+    }
+
+    /**
+     * This should be overridden by any specialized queues
+     * @param wrap
+     */
+    @Override
+    public PlotChunk<Chunk> getChunk(ChunkWrapper wrap) {
         return new FastChunk_1_9(wrap);
     }
+
+    /**
+     * This should be overridden by any specialized queues
+     * @param pc
+     */
+    @Override
+    public boolean fixLighting(PlotChunk<Chunk> pc, boolean fixAll) {
+        try {
+            FastChunk_1_9 bc = (FastChunk_1_9) pc;
+            Chunk chunk = bc.getChunk();
+            if (!chunk.isLoaded()) {
+                chunk.load(false);
+            } else {
+                chunk.unload(true, true);
+                chunk.load(false);
+            }
+
+            // Initialize lighting
+            Object c = this.methodGetHandleChunk.of(chunk).call();
+
+            if (fixAll && !(boolean) this.methodAreNeighborsLoaded.of(c).call(1)) {
+                World world = chunk.getWorld();
+                ChunkWrapper wrapper = bc.getChunkWrapper();
+                String worldName = wrapper.world;
+                for (int x = wrapper.x - 1; x <= wrapper.x + 1; x++) {
+                    for (int z = wrapper.z - 1; z <= wrapper.z + 1; z++) {
+                        if (x != 0 && z != 0) {
+                            Chunk other = world.getChunkAt(x, z);
+                            while (!other.isLoaded()) {
+                                other.load(true);
+                            }
+                            ChunkManager.manager.loadChunk(worldName, new ChunkLoc(x, z), true);
+                        }
+                    }
+                }
+            }
+
+            this.methodInitLighting.of(c).call();
+
+            if (bc.getTotalRelight() == 0 && !fixAll) {
+                return true;
+            }
+
+            Object[] sections = (Object[]) this.fieldSections.of(c).get();
+            Object w = this.fieldWorld.of(c).get();
+
+            int X = chunk.getX() << 4;
+            int Z = chunk.getZ() << 4;
+
+            RefExecutor relight = this.methodW.of(w);
+            for (int j = 0; j < sections.length; j++) {
+                Object section = sections[j];
+                if (section == null) {
+                    continue;
+                }
+                if (bc.getRelight(j) == 0 && !fixAll || bc.getCount(j) == 0 || bc.getCount(j) >= 4096 && bc.getAir(j) == 0) {
+                    continue;
+                }
+                int[] array = bc.getIdArray(j);
+                if (array != null) {
+                    int l = PseudoRandom.random.random(2);
+                    for (int k = 0; k < array.length; k++) {
+                        int i = array[k];
+                        if (i < 16) {
+                            continue;
+                        }
+                        short id = (short) (i >> 4);
+                        switch (id) { // Lighting
+                            default:
+                                if (!fixAll) {
+                                    continue;
+                                }
+                                if ((k & 1) == l) {
+                                    l = 1 - l;
+                                    continue;
+                                }
+                            case 10:
+                            case 11:
+                            case 39:
+                            case 40:
+                            case 50:
+                            case 51:
+                            case 62:
+                            case 74:
+                            case 76:
+                            case 89:
+                            case 122:
+                            case 124:
+                            case 130:
+                            case 138:
+                            case 169:
+                                int x = MainUtil.x_loc[j][k];
+                                int y = MainUtil.y_loc[j][k];
+                                int z = MainUtil.z_loc[j][k];
+                                if (isSurrounded(bc.getIdArrays(), x, y, z)) {
+                                    continue;
+                                }
+                                Object pos = this.classBlockPositionConstructor.create(X + x, y, Z + z);
+                                relight.call(pos);
+                        }
+                    }
+                }
+            }
+            return true;
+        } catch (Throwable e) {
+            e.printStackTrace();
+        }
+        return false;
+    }
+
+    public boolean isSurrounded(int[][] sections, int x, int y, int z) {
+        return isSolid(getId(sections, x, y + 1, z))
+                && isSolid(getId(sections, x + 1, y - 1, z))
+                && isSolid(getId(sections, x - 1, y, z))
+                && isSolid(getId(sections, x, y, z + 1))
+                && isSolid(getId(sections, x, y, z - 1));
+    }
+
+    public boolean isSolid(int i) {
+        if (i != 0) {
+            Material material = Material.getMaterial(i);
+            return material != null && Material.getMaterial(i).isOccluding();
+        }
+        return false;
+    }
+
+    public int getId(int[][] sections, int x, int y, int z) {
+        if (x < 0 || x > 15 || z < 0 || z > 15) {
+            return 1;
+        }
+        if (y < 0 || y > 255) {
+            return 1;
+        }
+        int i = MainUtil.CACHE_I[y][x][z];
+        int[] section = sections[i];
+        if (section == null) {
+            return 0;
+        }
+        int j = MainUtil.CACHE_J[y][x][z];
+        return section[j];
+    }
+
+    public int getId(Object section, int x, int y, int z) {
+        int j = MainUtil.CACHE_J[y][x][z];
+        Object iBlock = this.methodGetType.of(section).call(x, y & 15, z);
+        return (int) this.methodGetCombinedId.call(iBlock);
+    }
+
+    public int getId(Object[] sections, int x, int y, int z) {
+        if (x < 0 || x > 15 || z < 0 || z > 15) {
+            return 1;
+        }
+        if (y < 0 || y > 255) {
+            return 1;
+        }
+        int i = MainUtil.CACHE_I[y][x][z];
+        Object section = sections[i];
+        if (section == null) {
+            return 0;
+        }
+        return getId(section, x, y, z);
+    }
+
+    /**
+     * This should be overridden by any specialized queues
+     * @param world
+     * @param locations
+     */
+    @Override
+    public void sendChunk(final String world, final Collection<ChunkLoc> locations) {
+        World worldObj = BukkitUtil.getWorld(world);
+        for (ChunkLoc loc : locations) {
+            worldObj.refreshChunk(loc.x, loc.z);
+        }
+    }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/GenChunk.java

@@ -17,7 +17,6 @@ public class GenChunk extends PlotChunk<Chunk> {
     public short[][] result;
     public byte[][] result_data;
     public ChunkData cd;
-    public boolean modified = false;
     public BiomeGrid grid;
 
     public GenChunk(Chunk chunk, ChunkWrapper wrap) {
@@ -34,43 +33,40 @@ public class GenChunk extends PlotChunk<Chunk> {
     @Override
     public Chunk getChunkAbs() {
         ChunkWrapper wrap = getChunkWrapper();
-        if (chunk == null || wrap.x != chunk.getX() || wrap.z != chunk.getZ()) {
+        if (this.chunk == null || wrap.x != this.chunk.getX() || wrap.z != this.chunk.getZ()) {
-            chunk = BukkitUtil.getWorld(wrap.world).getChunkAt(wrap.x, wrap.z);
+            this.chunk = BukkitUtil.getWorld(wrap.world).getChunkAt(wrap.x, wrap.z);
         }
-        return chunk;
+        return this.chunk;
     }
 
     @Override
     public void setBiome(int x, int z, int biome) {
-        modified = true;
+        this.grid.setBiome(x, z, this.biomes[biome]);
-        grid.setBiome(x, z, biomes[biome]);
     }
 
     public void setBiome(int x, int z, Biome biome) {
-        if (grid != null) {
+        if (this.grid != null) {
-            grid.setBiome(x, z, biome);
+            this.grid.setBiome(x, z, biome);
         }
     }
 
     @Override
     public void setBlock(int x, int y, int z, int id, byte data) {
-        if (result == null) {
+        if (this.result == null) {
-            modified = true;
+            this.cd.setBlock(x, y, z, id, data);
-            cd.setBlock(x, y, z, id, data);
             return;
         }
         int i = MainUtil.CACHE_I[y][x][z];
-        short[] v = result[i];
+        short[] v = this.result[i];
         if (v == null) {
-            modified = true;
+            this.result[i] = v = new short[4096];
-            result[i] = v = new short[4096];
         }
         int j = MainUtil.CACHE_J[y][x][z];
         v[j] = (short) id;
         if (data != 0) {
-            byte[] vd = result_data[i];
+            byte[] vd = this.result_data[i];
             if (vd == null) {
-                result_data[i] = vd = new byte[4096];
+                this.result_data[i] = vd = new byte[4096];
             }
             vd[j] = data;
         }
@@ -79,32 +75,32 @@ public class GenChunk extends PlotChunk<Chunk> {
     @Override
     public PlotChunk clone() {
         GenChunk toReturn = new GenChunk(getChunkAbs(), getChunkWrapper());
-        if (result != null) {
+        if (this.result != null) {
-            for (int i = 0; i < result.length; i++) {
+            for (int i = 0; i < this.result.length; i++) {
-                short[] matrix = result[i];
+                short[] matrix = this.result[i];
                 if (matrix != null) {
                     toReturn.result[i] = new short[matrix.length];
                     System.arraycopy(matrix, 0, toReturn.result[i], 0, matrix.length);
                 }
             }
-            for (int i = 0; i < result_data.length; i++) {
+            for (int i = 0; i < this.result_data.length; i++) {
-                byte[] matrix = result_data[i];
+                byte[] matrix = this.result_data[i];
                 if (matrix != null) {
                     toReturn.result_data[i] = new byte[matrix.length];
                     System.arraycopy(matrix, 0, toReturn.result_data[i], 0, matrix.length);
                 }
             }
         }
-        toReturn.cd = cd;
+        toReturn.cd = this.cd;
         return toReturn;
     }
 
     @Override
     public PlotChunk shallowClone() {
         GenChunk toReturn = new GenChunk(getChunkAbs(), getChunkWrapper());
-        toReturn.result = result;
+        toReturn.result = this.result;
-        toReturn.result_data = result_data;
+        toReturn.result_data = this.result_data;
-        toReturn.cd = cd;
+        toReturn.cd = this.cd;
         return toReturn;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/SlowChunk.java

@@ -11,6 +11,7 @@ public class SlowChunk extends PlotChunk<Chunk> {
 
     public PlotBlock[][] result = new PlotBlock[16][];
     public int[][] biomes;
+
     public SlowChunk(ChunkWrapper chunk) {
         super(chunk);
     }
@@ -23,25 +24,25 @@ public class SlowChunk extends PlotChunk<Chunk> {
 
     @Override
     public void setBiome(int x, int z, int biome) {
-        if (biomes == null) {
+        if (this.biomes == null) {
-            biomes = new int[16][16];
+            this.biomes = new int[16][16];
         }
-        biomes[x][z] = biome;
+        this.biomes[x][z] = biome;
     }
 
     @Override
     public void setBlock(int x, int y, int z, int id, byte data) {
-        if (result[y >> 4] == null) {
+        if (this.result[y >> 4] == null) {
-            result[y >> 4] = new PlotBlock[4096];
+            this.result[y >> 4] = new PlotBlock[4096];
         }
-        result[MainUtil.CACHE_I[y][x][z]][MainUtil.CACHE_J[y][x][z]] = new PlotBlock((short) id, data);
+        this.result[MainUtil.CACHE_I[y][x][z]][MainUtil.CACHE_J[y][x][z]] = new PlotBlock((short) id, data);
     }
 
     @Override
     public PlotChunk clone() {
         SlowChunk toReturn = new SlowChunk(getChunkWrapper());
-        for (int i = 0; i < result.length; i++) {
+        for (int i = 0; i < this.result.length; i++) {
-            PlotBlock[] matrix = result[i];
+            PlotBlock[] matrix = this.result[i];
             if (matrix != null) {
                 toReturn.result[i] = new PlotBlock[matrix.length];
                 System.arraycopy(matrix, 0, toReturn.result[i], 0, matrix.length);
@@ -53,7 +54,7 @@ public class SlowChunk extends PlotChunk<Chunk> {
     @Override
     public PlotChunk shallowClone() {
         SlowChunk toReturn = new SlowChunk(getChunkWrapper());
-        toReturn.result = result;
+        toReturn.result = this.result;
         return toReturn;
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/SlowQueue.java

@@ -8,14 +8,13 @@ import com.intellectualcrafters.plot.util.PlotChunk;
 import com.intellectualcrafters.plot.util.PlotQueue;
 import com.intellectualcrafters.plot.util.SetQueue;
 import com.intellectualcrafters.plot.util.SetQueue.ChunkWrapper;
-import org.bukkit.Chunk;
-import org.bukkit.block.Biome;
-import org.bukkit.block.Block;
-
 import java.util.Collection;
 import java.util.Iterator;
 import java.util.Map.Entry;
 import java.util.concurrent.ConcurrentHashMap;
+import org.bukkit.Chunk;
+import org.bukkit.block.Biome;
+import org.bukkit.block.Block;
 
 public class SlowQueue implements PlotQueue<Chunk> {
 
@@ -30,18 +29,18 @@ public class SlowQueue implements PlotQueue<Chunk> {
         if (y > 255 || y < 0) {
             return false;
         }
-        final ChunkWrapper wrap = SetQueue.IMP.new ChunkWrapper(world, x >> 4, z >> 4);
+        ChunkWrapper wrap = SetQueue.IMP.new ChunkWrapper(world, x >> 4, z >> 4);
         x = x & 15;
         z = z & 15;
-        PlotChunk<Chunk> result = blocks.get(wrap);
+        PlotChunk<Chunk> result = this.blocks.get(wrap);
         if (result == null) {
             result = getChunk(wrap);
             result.setBlock(x, y, z, id, data);
-            final PlotChunk<Chunk> previous = blocks.put(wrap, result);
+            PlotChunk<Chunk> previous = this.blocks.put(wrap, result);
             if (previous == null) {
                 return true;
             }
-            blocks.put(wrap, previous);
+            this.blocks.put(wrap, previous);
             result = previous;
         }
         result.setBlock(x, y, z, id, data);
@@ -50,7 +49,7 @@ public class SlowQueue implements PlotQueue<Chunk> {
 
     @Override
     public void setChunk(PlotChunk<Chunk> chunk) {
-        blocks.put(chunk.getChunkWrapper(), chunk);
+        this.blocks.put(chunk.getChunkWrapper(), chunk);
     }
 
     @Override
@@ -59,19 +58,19 @@ public class SlowQueue implements PlotQueue<Chunk> {
             throw new IllegalStateException("Must be called from main thread!");
         }
         try {
-            if (blocks.isEmpty()) {
+            if (this.blocks.isEmpty()) {
                 return null;
             }
-            final Iterator<Entry<ChunkWrapper, PlotChunk<Chunk>>> iter = blocks.entrySet().iterator();
+            Iterator<Entry<ChunkWrapper, PlotChunk<Chunk>>> iterator = this.blocks.entrySet().iterator();
-            final PlotChunk<Chunk> toReturn = iter.next().getValue();
+            PlotChunk<Chunk> toReturn = iterator.next().getValue();
             if (SetQueue.IMP.isWaiting()) {
                 return null;
             }
-            iter.remove();
+            iterator.remove();
             execute(toReturn);
             fixLighting(toReturn, true);
             return toReturn;
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
             return null;
         }
@@ -83,17 +82,17 @@ public class SlowQueue implements PlotQueue<Chunk> {
             throw new IllegalStateException("Must be called from main thread!");
         }
         try {
-            if (blocks.isEmpty()) {
+            if (this.blocks.isEmpty()) {
                 return null;
             }
-            final PlotChunk<Chunk> toReturn = blocks.remove(wrap);
+            PlotChunk<Chunk> toReturn = this.blocks.remove(wrap);
             if (toReturn == null) {
                 return null;
             }
             execute(toReturn);
             fixLighting(toReturn, fixLighting);
             return toReturn;
-        } catch (final Throwable e) {
+        } catch (Throwable e) {
             e.printStackTrace();
             return null;
         }
@@ -101,16 +100,16 @@ public class SlowQueue implements PlotQueue<Chunk> {
 
     @Override
     public void clear() {
-        blocks.clear();
+        this.blocks.clear();
     }
 
     /**
-     * This should be overriden by any specialized queues 
+     * This should be overridden by any specialized queues.
-     * @param pc
+     * @param plotChunk
      */
-    public void execute(PlotChunk<Chunk> pc) {
+    public void execute(PlotChunk<Chunk> plotChunk) {
-        SlowChunk sc = (SlowChunk) pc;
+        SlowChunk sc = (SlowChunk) plotChunk;
-        Chunk chunk = pc.getChunk();
+        Chunk chunk = plotChunk.getChunk();
         chunk.load(true);
         for (int i = 0; i < sc.result.length; i++) {
             PlotBlock[] result2 = sc.result[i];
@@ -118,9 +117,9 @@ public class SlowQueue implements PlotQueue<Chunk> {
                 continue;
             }
             for (int j = 0; j < 4096; j++) {
-                final int x = MainUtil.x_loc[i][j];
+                int x = MainUtil.x_loc[i][j];
-                final int y = MainUtil.y_loc[i][j];
+                int y = MainUtil.y_loc[i][j];
-                final int z = MainUtil.z_loc[i][j];
+                int z = MainUtil.z_loc[i][j];
                 Block block = chunk.getBlock(x, y, z);
                 PlotBlock newBlock = result2[j];
                 if (newBlock == null) {
@@ -252,7 +251,7 @@ public class SlowQueue implements PlotQueue<Chunk> {
     }
 
     /**
-     * This should be overriden by any specialized queues 
+     * This should be overridden by any specialized queues.
      * @param wrap
      */
     @Override
@@ -261,7 +260,7 @@ public class SlowQueue implements PlotQueue<Chunk> {
     }
 
     /**
-     * This should be overriden by any specialized queues 
+     * This should be overridden by any specialized queues.
      * @param fixAll
      */
     @Override
@@ -271,11 +270,11 @@ public class SlowQueue implements PlotQueue<Chunk> {
     }
 
     /**
-     * This should be overriden by any specialized queues 
+     * This should be overridden by any specialized queues.
-     * @param locs
+     * @param locations
      */
     @Override
-    public void sendChunk(String world, Collection<ChunkLoc> locs) {
+    public void sendChunk(String world, Collection<ChunkLoc> locations) {
         // Do nothing
     }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/DefaultUUIDWrapper.java

@@ -1,47 +1,47 @@
 package com.plotsquared.bukkit.uuid;
 
-import java.util.UUID;
-
-import org.bukkit.Bukkit;
-import org.bukkit.OfflinePlayer;
-
 import com.intellectualcrafters.plot.object.OfflinePlotPlayer;
 import com.intellectualcrafters.plot.object.PlotPlayer;
 import com.intellectualcrafters.plot.uuid.UUIDWrapper;
 import com.plotsquared.bukkit.object.BukkitOfflinePlayer;
 import com.plotsquared.bukkit.object.BukkitPlayer;
+import org.bukkit.Bukkit;
+import org.bukkit.OfflinePlayer;
+
+import java.util.UUID;
 
 public class DefaultUUIDWrapper extends UUIDWrapper {
+
     @Override
-    public UUID getUUID(final PlotPlayer player) {
+    public UUID getUUID(PlotPlayer player) {
         return ((BukkitPlayer) player).player.getUniqueId();
     }
-    
+
     @Override
-    public UUID getUUID(final OfflinePlotPlayer player) {
+    public UUID getUUID(OfflinePlotPlayer player) {
         return player.getUUID();
     }
-    
+
     @Override
-    public OfflinePlotPlayer getOfflinePlayer(final UUID uuid) {
+    public OfflinePlotPlayer getOfflinePlayer(UUID uuid) {
         return new BukkitOfflinePlayer(Bukkit.getOfflinePlayer(uuid));
     }
-    
+
     @Override
-    public UUID getUUID(final String name) {
+    public UUID getUUID(String name) {
         return Bukkit.getOfflinePlayer(name).getUniqueId();
     }
-    
+
     @Override
     public OfflinePlotPlayer[] getOfflinePlayers() {
-        final OfflinePlayer[] ops = Bukkit.getOfflinePlayers();
+        OfflinePlayer[] ops = Bukkit.getOfflinePlayers();
-        final BukkitOfflinePlayer[] toReturn = new BukkitOfflinePlayer[ops.length];
+        BukkitOfflinePlayer[] toReturn = new BukkitOfflinePlayer[ops.length];
         for (int i = 0; i < ops.length; i++) {
             toReturn[i] = new BukkitOfflinePlayer(ops[i]);
         }
         return toReturn;
     }
-    
+
     @Override
     public OfflinePlotPlayer getOfflinePlayer(String name) {
         return new BukkitOfflinePlayer(Bukkit.getOfflinePlayer(name));

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/FileUUIDHandler.java

@@ -10,7 +10,11 @@ import com.intellectualcrafters.plot.database.DBFunc;
 import com.intellectualcrafters.plot.object.OfflinePlotPlayer;
 import com.intellectualcrafters.plot.object.RunnableVal;
 import com.intellectualcrafters.plot.object.StringWrapper;
-import com.intellectualcrafters.plot.util.*;
+import com.intellectualcrafters.plot.util.ExpireManager;
+import com.intellectualcrafters.plot.util.StringMan;
+import com.intellectualcrafters.plot.util.TaskManager;
+import com.intellectualcrafters.plot.util.UUIDHandler;
+import com.intellectualcrafters.plot.util.UUIDHandlerImplementation;
 import com.intellectualcrafters.plot.uuid.UUIDWrapper;
 import com.plotsquared.bukkit.util.NbtFactory;
 import org.bukkit.Bukkit;
@@ -28,19 +32,19 @@ import java.util.List;
 import java.util.UUID;
 
 public class FileUUIDHandler extends UUIDHandlerImplementation {
-    
+
-    public FileUUIDHandler(final UUIDWrapper wrapper) {
+    public FileUUIDHandler(UUIDWrapper wrapper) {
         super(wrapper);
     }
-    
+
     @Override
-    public boolean startCaching(final Runnable whenDone) {
+    public boolean startCaching(Runnable whenDone) {
         return super.startCaching(whenDone) && cache(whenDone);
     }
-    
+
     public boolean cache(final Runnable whenDone) {
         final File container = Bukkit.getWorldContainer();
-        final List<World> worlds = Bukkit.getWorlds();
+        List<World> worlds = Bukkit.getWorlds();
         final String world;
         if (worlds.isEmpty()) {
             world = "world";
@@ -50,11 +54,11 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
         TaskManager.runTaskAsync(new Runnable() {
             @Override
             public void run() {
-                PS.debug(C.PREFIX.s() + "&6Starting player data caching for: " + world);
+                PS.debug(C.PREFIX + "&6Starting player data caching for: " + world);
-                final File uuidfile = new File(PS.get().IMP.getDirectory(), "uuids.txt");
+                File uuidFile = new File(PS.get().IMP.getDirectory(), "uuids.txt");
-                if (uuidfile.exists()) {
+                if (uuidFile.exists()) {
                     try {
-                        final List<String> lines = Files.readAllLines(uuidfile.toPath(), StandardCharsets.UTF_8);
+                        List<String> lines = Files.readAllLines(uuidFile.toPath(), StandardCharsets.UTF_8);
                         for (String line : lines) {
                             try {
                                 line = line.trim();
@@ -62,57 +66,57 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                                     continue;
                                 }
                                 line = line.replaceAll("[\\|][0-9]+[\\|][0-9]+[\\|]", "");
-                                final String[] split = line.split("\\|");
+                                String[] split = line.split("\\|");
-                                final String name = split[0];
+                                String name = split[0];
-                                if ((name.isEmpty()) || (name.length() > 16) || !StringMan.isAlphanumericUnd(name)) {
+                                if (name.isEmpty() || (name.length() > 16) || !StringMan.isAlphanumericUnd(name)) {
                                     continue;
                                 }
-                                final UUID uuid = uuidWrapper.getUUID(name);
+                                UUID uuid = FileUUIDHandler.this.uuidWrapper.getUUID(name);
                                 if (uuid == null) {
                                     continue;
                                 }
                                 UUIDHandler.add(new StringWrapper(name), uuid);
-                            } catch (final Exception e2) {
+                            } catch (Exception e2) {
                                 e2.printStackTrace();
                             }
                         }
-                    } catch (final IOException e) {
+                    } catch (IOException e) {
                         e.printStackTrace();
                     }
                 }
                 if (Settings.TWIN_MODE_UUID) {
-                    final HashBiMap<StringWrapper, UUID> toAdd = HashBiMap.create(new HashMap<StringWrapper, UUID>());
+                    HashBiMap<StringWrapper, UUID> toAdd = HashBiMap.create(new HashMap<StringWrapper, UUID>());
                     toAdd.put(new StringWrapper("*"), DBFunc.everyone);
-                    final HashSet<UUID> all = UUIDHandler.getAllUUIDS();
+                    HashSet<UUID> all = UUIDHandler.getAllUUIDS();
                     PS.debug("&aFast mode UUID caching enabled!");
-                    final File playerdataFolder = new File(container, world + File.separator + "playerdata");
+                    File playerDataFolder = new File(container, world + File.separator + "playerdata");
-                    final String[] dat = playerdataFolder.list(new FilenameFilter() {
+                    String[] dat = playerDataFolder.list(new FilenameFilter() {
                         @Override
-                        public boolean accept(final File f, final String s) {
+                        public boolean accept(File f, String s) {
                             return s.endsWith(".dat");
                         }
                     });
-                    final boolean check = all.isEmpty();
+                    boolean check = all.isEmpty();
                     if (dat != null) {
-                        for (final String current : dat) {
+                        for (String current : dat) {
-                            final String s = current.replaceAll(".dat$", "");
+                            String s = current.replaceAll(".dat$", "");
                             try {
-                                final UUID uuid = UUID.fromString(s);
+                                UUID uuid = UUID.fromString(s);
                                 if (check || all.remove(uuid)) {
-                                    final File file = new File(playerdataFolder + File.separator + current);
+                                    File file = new File(playerDataFolder + File.separator + current);
-                                    final InputSupplier<FileInputStream> is = com.google.common.io.Files.newInputStreamSupplier(file);
+                                    InputSupplier<FileInputStream> is = com.google.common.io.Files.newInputStreamSupplier(file);
-                                    final NbtFactory.NbtCompound compound = NbtFactory.fromStream(is, NbtFactory.StreamOptions.GZIP_COMPRESSION);
+                                    NbtFactory.NbtCompound compound = NbtFactory.fromStream(is, NbtFactory.StreamOptions.GZIP_COMPRESSION);
-                                    final NbtFactory.NbtCompound bukkit = (NbtFactory.NbtCompound) compound.get("bukkit");
+                                    NbtFactory.NbtCompound bukkit = (NbtFactory.NbtCompound) compound.get("bukkit");
-                                    final String name = (String) bukkit.get("lastKnownName");
+                                    String name = (String) bukkit.get("lastKnownName");
-                                    final long last = (long) bukkit.get("lastPlayed");
+                                    long last = (long) bukkit.get("lastPlayed");
                                     if (ExpireManager.IMP != null) {
                                         ExpireManager.IMP.storeDate(uuid, last);
                                     }
                                     toAdd.put(new StringWrapper(name), uuid);
                                 }
-                            } catch (final Exception e) {
+                            } catch (Exception e) {
                                 e.printStackTrace();
-                                PS.debug(C.PREFIX.s() + "Invalid playerdata: " + current);
+                                PS.debug(C.PREFIX + "Invalid playerdata: " + current);
                             }
                         }
                     }
@@ -126,45 +130,45 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                         PS.debug("Failed to cache: " + all.size() + " uuids - slowly processing all files");
                     }
                 }
-                final HashBiMap<StringWrapper, UUID> toAdd = HashBiMap.create(new HashMap<StringWrapper, UUID>());
+                HashBiMap<StringWrapper, UUID> toAdd = HashBiMap.create(new HashMap<StringWrapper, UUID>());
                 toAdd.put(new StringWrapper("*"), DBFunc.everyone);
-                final HashSet<String> worlds = new HashSet<>();
+                HashSet<String> worlds = new HashSet<>();
                 worlds.add(world);
                 worlds.add("world");
-                final HashSet<UUID> uuids = new HashSet<>();
+                HashSet<UUID> uuids = new HashSet<>();
-                final HashSet<String> names = new HashSet<>();
+                HashSet<String> names = new HashSet<>();
-                File playerdataFolder = null;
+                File playerDataFolder = null;
-                for (final String worldname : worlds) {
+                for (String worldName : worlds) {
                     // Getting UUIDs
-                    playerdataFolder = new File(container, worldname + File.separator + "playerdata");
+                    playerDataFolder = new File(container, worldName + File.separator + "playerdata");
-                    String[] dat = playerdataFolder.list(new FilenameFilter() {
+                    String[] dat = playerDataFolder.list(new FilenameFilter() {
                         @Override
-                        public boolean accept(final File f, final String s) {
+                        public boolean accept(File f, String s) {
                             return s.endsWith(".dat");
                         }
                     });
                     if ((dat != null) && (dat.length != 0)) {
-                        for (final String current : dat) {
+                        for (String current : dat) {
-                            final String s = current.replaceAll(".dat$", "");
+                            String s = current.replaceAll(".dat$", "");
                             try {
-                                final UUID uuid = UUID.fromString(s);
+                                UUID uuid = UUID.fromString(s);
                                 uuids.add(uuid);
-                            } catch (final Exception e) {
+                            } catch (Exception e) {
-                                PS.debug(C.PREFIX.s() + "Invalid playerdata: " + current);
+                                PS.debug(C.PREFIX + "Invalid PlayerData: " + current);
                             }
                         }
                         break;
                     }
                     // Getting names
-                    final File playersFolder = new File(worldname + File.separator + "players");
+                    File playersFolder = new File(worldName + File.separator + "players");
                     dat = playersFolder.list(new FilenameFilter() {
                         @Override
-                        public boolean accept(final File f, final String s) {
+                        public boolean accept(File f, String s) {
                             return s.endsWith(".dat");
                         }
                     });
                     if ((dat != null) && (dat.length != 0)) {
-                        for (final String current : dat) {
+                        for (String current : dat) {
                             names.add(current.replaceAll(".dat$", ""));
                         }
                         break;
@@ -172,21 +176,21 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                 }
                 for (UUID uuid : uuids) {
                     try {
-                        final File file = new File(playerdataFolder + File.separator + uuid.toString() + ".dat");
+                        File file = new File(playerDataFolder + File.separator + uuid.toString() + ".dat");
                         if (!file.exists()) {
                             continue;
                         }
-                        final ByteSource is = com.google.common.io.Files.asByteSource(file);
+                        ByteSource is = com.google.common.io.Files.asByteSource(file);
-                        final NbtFactory.NbtCompound compound = NbtFactory.fromStream(is, NbtFactory.StreamOptions.GZIP_COMPRESSION);
+                        NbtFactory.NbtCompound compound = NbtFactory.fromStream(is, NbtFactory.StreamOptions.GZIP_COMPRESSION);
-                        final NbtFactory.NbtCompound bukkit = (NbtFactory.NbtCompound) compound.get("bukkit");
+                        NbtFactory.NbtCompound bukkit = (NbtFactory.NbtCompound) compound.get("bukkit");
-                        final String name = (String) bukkit.get("lastKnownName");
+                        String name = (String) bukkit.get("lastKnownName");
-                        final long last = (long) bukkit.get("lastPlayed");
+                        long last = (long) bukkit.get("lastPlayed");
                         if (Settings.OFFLINE_MODE) {
                             if (Settings.UUID_LOWERCASE && !name.toLowerCase().equals(name)) {
-                                uuid = uuidWrapper.getUUID(name);
+                                uuid = FileUUIDHandler.this.uuidWrapper.getUUID(name);
                             } else {
-                                final long most = (long) compound.get("UUIDMost");
+                                long most = (long) compound.get("UUIDMost");
-                                final long least = (long) compound.get("UUIDLeast");
+                                long least = (long) compound.get("UUIDLeast");
                                 uuid = new UUID(most, least);
                             }
                         }
@@ -194,23 +198,23 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                             ExpireManager.IMP.storeDate(uuid, last);
                         }
                         toAdd.put(new StringWrapper(name), uuid);
-                    } catch (final Throwable e) {
+                    } catch (Throwable e) {
-                        PS.debug(C.PREFIX.s() + "&6Invalid playerdata: " + uuid.toString() + ".dat");
+                        PS.debug(C.PREFIX + "&6Invalid PlayerData: " + uuid.toString() + ".dat");
                     }
                 }
-                for (final String name : names) {
+                for (String name : names) {
-                    final UUID uuid = uuidWrapper.getUUID(name);
+                    UUID uuid = FileUUIDHandler.this.uuidWrapper.getUUID(name);
-                    final StringWrapper nameWrap = new StringWrapper(name);
+                    StringWrapper nameWrap = new StringWrapper(name);
                     toAdd.put(nameWrap, uuid);
                 }
 
                 if (getUUIDMap().isEmpty()) {
-                    for (final OfflinePlotPlayer op : uuidWrapper.getOfflinePlayers()) {
+                    for (OfflinePlotPlayer op : FileUUIDHandler.this.uuidWrapper.getOfflinePlayers()) {
-                        final long last = op.getLastPlayed();
+                        long last = op.getLastPlayed();
                         if (last != 0) {
-                            final String name = op.getName();
+                            String name = op.getName();
-                            final StringWrapper wrap = new StringWrapper(name);
+                            StringWrapper wrap = new StringWrapper(name);
-                            final UUID uuid = uuidWrapper.getUUID(op);
+                            UUID uuid = FileUUIDHandler.this.uuidWrapper.getUUID(op);
                             toAdd.put(wrap, uuid);
                             if (ExpireManager.IMP != null) {
                                 ExpireManager.IMP.storeDate(uuid, last);
@@ -226,13 +230,13 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
         });
         return true;
     }
-    
+
     @Override
     public void fetchUUID(final String name, final RunnableVal<UUID> ifFetch) {
         TaskManager.runTaskAsync(new Runnable() {
             @Override
             public void run() {
-                ifFetch.value = uuidWrapper.getUUID(name);
+                ifFetch.value = FileUUIDHandler.this.uuidWrapper.getUUID(name);
                 TaskManager.runTask(ifFetch);
             }
         });

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/LowerOfflineUUIDWrapper.java

@@ -1,108 +1,32 @@
 package com.plotsquared.bukkit.uuid;
 
-import java.lang.reflect.Method;
-import java.util.Collection;
-import java.util.UUID;
-
-import org.bukkit.Bukkit;
-import org.bukkit.OfflinePlayer;
-import org.bukkit.Server;
-import org.bukkit.entity.Player;
-
 import com.google.common.base.Charsets;
-import com.google.common.collect.BiMap;
-import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.object.OfflinePlotPlayer;
 import com.intellectualcrafters.plot.object.PlotPlayer;
-import com.intellectualcrafters.plot.object.StringWrapper;
+import org.bukkit.OfflinePlayer;
-import com.intellectualcrafters.plot.util.UUIDHandler;
+
-import com.plotsquared.bukkit.object.BukkitOfflinePlayer;
+import java.util.UUID;
 
 public class LowerOfflineUUIDWrapper extends OfflineUUIDWrapper {
-    private Method getOnline = null;
+
-    private final Object[] arg = new Object[0];
-    
-    public LowerOfflineUUIDWrapper() {
-        try {
-            getOnline = Server.class.getMethod("getOnlinePlayers");
-        } catch (final NoSuchMethodException | SecurityException e) {
-            e.printStackTrace();
-        }
-    }
-    
     @Override
-    public UUID getUUID(final PlotPlayer player) {
+    public UUID getUUID(PlotPlayer player) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + player.getName().toLowerCase()).getBytes(Charsets.UTF_8));
     }
-    
+
     @Override
-    public UUID getUUID(final OfflinePlotPlayer player) {
+    public UUID getUUID(OfflinePlotPlayer player) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + player.getName().toLowerCase()).getBytes(Charsets.UTF_8));
     }
-    
+
     @Override
-    public UUID getUUID(final OfflinePlayer player) {
+    public UUID getUUID(OfflinePlayer player) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + player.getName().toLowerCase()).getBytes(Charsets.UTF_8));
     }
-    
+
     @Override
-    public OfflinePlotPlayer getOfflinePlayer(final UUID uuid) {
+    public UUID getUUID(String name) {
-        final BiMap<UUID, StringWrapper> map = UUIDHandler.getUuidMap().inverse();
-        String name;
-        try {
-            name = map.get(uuid).value;
-        } catch (final NullPointerException e) {
-            name = null;
-        }
-        if (name != null) {
-            final OfflinePlayer op = Bukkit.getOfflinePlayer(name);
-            if (op.hasPlayedBefore()) {
-                return new BukkitOfflinePlayer(op);
-            }
-        }
-        for (final OfflinePlayer player : Bukkit.getOfflinePlayers()) {
-            if (getUUID(player).equals(uuid)) {
-                return new BukkitOfflinePlayer(player);
-            }
-        }
-        return null;
-    }
-    
-    @Override
-    public Player[] getOnlinePlayers() {
-        if (getOnline == null) {
-            Collection<? extends Player> onlinePlayers = Bukkit.getOnlinePlayers();
-            return onlinePlayers.toArray(new Player[onlinePlayers.size()]);
-        }
-        try {
-            final Object players = getOnline.invoke(Bukkit.getServer(), arg);
-            if (players instanceof Player[]) {
-                return (Player[]) players;
-            } else {
-                @SuppressWarnings("unchecked")
-                final Collection<? extends Player> p = (Collection<? extends Player>) players;
-                return p.toArray(new Player[p.size()]);
-            }
-        } catch (final Exception e) {
-            PS.debug("Failed to resolve online players");
-            getOnline = null;
-            Collection<? extends Player> onlinePlayers = Bukkit.getOnlinePlayers();
-            return onlinePlayers.toArray(new Player[onlinePlayers.size()]);
-        }
-    }
-    
-    @Override
-    public UUID getUUID(final String name) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + name.toLowerCase()).getBytes(Charsets.UTF_8));
     }
-    
+
-    @Override
-    public OfflinePlotPlayer[] getOfflinePlayers() {
-        final OfflinePlayer[] ops = Bukkit.getOfflinePlayers();
-        final BukkitOfflinePlayer[] toReturn = new BukkitOfflinePlayer[ops.length];
-        for (int i = 0; i < ops.length; i++) {
-            toReturn[i] = new BukkitOfflinePlayer(ops[i]);
-        }
-        return toReturn;
-    }
 }

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/OfflineUUIDWrapper.java

@@ -1,14 +1,5 @@
 package com.plotsquared.bukkit.uuid;
 
-import java.lang.reflect.Method;
-import java.util.Collection;
-import java.util.UUID;
-
-import org.bukkit.Bukkit;
-import org.bukkit.OfflinePlayer;
-import org.bukkit.Server;
-import org.bukkit.entity.Player;
-
 import com.google.common.base.Charsets;
 import com.google.common.collect.BiMap;
 import com.intellectualcrafters.plot.PS;
@@ -18,93 +9,101 @@ import com.intellectualcrafters.plot.object.StringWrapper;
 import com.intellectualcrafters.plot.util.UUIDHandler;
 import com.intellectualcrafters.plot.uuid.UUIDWrapper;
 import com.plotsquared.bukkit.object.BukkitOfflinePlayer;
+import org.bukkit.Bukkit;
+import org.bukkit.OfflinePlayer;
+import org.bukkit.Server;
+import org.bukkit.entity.Player;
+
+import java.lang.reflect.Method;
+import java.util.Collection;
+import java.util.UUID;
 
 public class OfflineUUIDWrapper extends UUIDWrapper {
-    private Method getOnline = null;
+
     private final Object[] arg = new Object[0];
-    
+    private Method getOnline = null;
+
     public OfflineUUIDWrapper() {
         try {
-            getOnline = Server.class.getMethod("getOnlinePlayers");
+            this.getOnline = Server.class.getMethod("getOnlinePlayers");
-        } catch (final NoSuchMethodException | SecurityException e) {
+        } catch (NoSuchMethodException | SecurityException e) {
             e.printStackTrace();
         }
     }
-    
+
     @Override
-    public UUID getUUID(final PlotPlayer player) {
+    public UUID getUUID(PlotPlayer player) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + player.getName()).getBytes(Charsets.UTF_8));
     }
-    
+
     @Override
-    public UUID getUUID(final OfflinePlotPlayer player) {
+    public UUID getUUID(OfflinePlotPlayer player) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + player.getName()).getBytes(Charsets.UTF_8));
     }
-    
+
-    public UUID getUUID(final OfflinePlayer player) {
+    public UUID getUUID(OfflinePlayer player) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + player.getName()).getBytes(Charsets.UTF_8));
     }
-    
+
     @Override
-    public OfflinePlotPlayer getOfflinePlayer(final UUID uuid) {
+    public OfflinePlotPlayer getOfflinePlayer(UUID uuid) {
-        final BiMap<UUID, StringWrapper> map = UUIDHandler.getUuidMap().inverse();
+        BiMap<UUID, StringWrapper> map = UUIDHandler.getUuidMap().inverse();
         String name;
         try {
             name = map.get(uuid).value;
-        } catch (final NullPointerException e) {
+        } catch (NullPointerException e) {
             name = null;
         }
         if (name != null) {
-            final OfflinePlayer op = Bukkit.getOfflinePlayer(name);
+            OfflinePlayer op = Bukkit.getOfflinePlayer(name);
             if (op.hasPlayedBefore()) {
                 return new BukkitOfflinePlayer(op);
             }
         }
-        for (final OfflinePlayer player : Bukkit.getOfflinePlayers()) {
+        for (OfflinePlayer player : Bukkit.getOfflinePlayers()) {
             if (getUUID(player).equals(uuid)) {
                 return new BukkitOfflinePlayer(player);
             }
         }
         return null;
     }
-    
+
     public Player[] getOnlinePlayers() {
-        if (getOnline == null) {
+        if (this.getOnline == null) {
             Collection<? extends Player> onlinePlayers = Bukkit.getOnlinePlayers();
             return onlinePlayers.toArray(new Player[onlinePlayers.size()]);
         }
         try {
-            final Object players = getOnline.invoke(Bukkit.getServer(), arg);
+            Object players = this.getOnline.invoke(Bukkit.getServer(), this.arg);
             if (players instanceof Player[]) {
                 return (Player[]) players;
             } else {
-                @SuppressWarnings("unchecked")
+                @SuppressWarnings("unchecked") Collection<? extends Player> p = (Collection<? extends Player>) players;
-                final Collection<? extends Player> p = (Collection<? extends Player>) players;
                 return p.toArray(new Player[p.size()]);
             }
-        } catch (final Exception e) {
+        } catch (Exception e) {
             PS.debug("Failed to resolve online players");
-            getOnline = null;
+            this.getOnline = null;
             Collection<? extends Player> onlinePlayers = Bukkit.getOnlinePlayers();
             return onlinePlayers.toArray(new Player[onlinePlayers.size()]);
         }
     }
-    
+
     @Override
-    public UUID getUUID(final String name) {
+    public UUID getUUID(String name) {
         return UUID.nameUUIDFromBytes(("OfflinePlayer:" + name).getBytes(Charsets.UTF_8));
     }
-    
+
     @Override
     public OfflinePlotPlayer[] getOfflinePlayers() {
-        final OfflinePlayer[] ops = Bukkit.getOfflinePlayers();
+        OfflinePlayer[] ops = Bukkit.getOfflinePlayers();
-        final BukkitOfflinePlayer[] toReturn = new BukkitOfflinePlayer[ops.length];
+        BukkitOfflinePlayer[] toReturn = new BukkitOfflinePlayer[ops.length];
         for (int i = 0; i < ops.length; i++) {
             toReturn[i] = new BukkitOfflinePlayer(ops[i]);
         }
         return toReturn;
     }
-    
+
     @Override
     public OfflinePlotPlayer getOfflinePlayer(String name) {
         return new BukkitOfflinePlayer(Bukkit.getOfflinePlayer(name));

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/SQLUUIDHandler.java

@@ -1,22 +1,5 @@
 package com.plotsquared.bukkit.uuid;
 
-import java.io.InputStreamReader;
-import java.io.OutputStream;
-import java.net.HttpURLConnection;
-import java.net.URL;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.ArrayDeque;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.UUID;
-
-import org.json.simple.JSONArray;
-import org.json.simple.JSONObject;
-import org.json.simple.parser.JSONParser;
-
 import com.google.common.collect.HashBiMap;
 import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.config.C;
@@ -29,41 +12,58 @@ import com.intellectualcrafters.plot.util.TaskManager;
 import com.intellectualcrafters.plot.util.UUIDHandler;
 import com.intellectualcrafters.plot.util.UUIDHandlerImplementation;
 import com.intellectualcrafters.plot.uuid.UUIDWrapper;
+import org.json.simple.JSONArray;
+import org.json.simple.JSONObject;
+import org.json.simple.parser.JSONParser;
+import org.json.simple.parser.ParseException;
+
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayDeque;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.UUID;
 
 public class SQLUUIDHandler extends UUIDHandlerImplementation {
-    
-    final String PROFILE_URL = "https://sessionserver.mojang.com/session/minecraft/profile/";
-    final int MAX_REQUESTS = 500;
-    final int INTERVAL = 12000;
-    final JSONParser jsonParser = new JSONParser();
-    private final SQLite _sqLite;
 
-    public SQLUUIDHandler(final UUIDWrapper wrapper) {
+    final int MAX_REQUESTS = 500;
+    private final String PROFILE_URL = "https://sessionserver.mojang.com/session/minecraft/profile/";
+    private final int INTERVAL = 12000;
+    private final JSONParser jsonParser = new JSONParser();
+    private final SQLite sqlite;
+
+    public SQLUUIDHandler(UUIDWrapper wrapper) {
         super(wrapper);
-        _sqLite = new SQLite("./plugins/PlotSquared/usercache.db");
+        this.sqlite = new SQLite("./plugins/PlotSquared/usercache.db");
         try {
-            _sqLite.openConnection();
+            this.sqlite.openConnection();
-        } catch (final Exception e) {
+        } catch (ClassNotFoundException | SQLException e) {
             e.printStackTrace();
         }
 
-        try {
+        try (PreparedStatement stmt = getConnection().prepareStatement(
-            final PreparedStatement stmt = getConnection().prepareStatement(
+                "CREATE TABLE IF NOT EXISTS `usercache` (uuid VARCHAR(32) NOT NULL, username VARCHAR(32) NOT NULL, PRIMARY KEY (uuid, username)"
-            "CREATE TABLE IF NOT EXISTS `usercache` (uuid VARCHAR(32) NOT NULL, username VARCHAR(32) NOT NULL, PRIMARY KEY (uuid, username))");
+                        + ")")) {
             stmt.execute();
-            stmt.close();
+        } catch (SQLException e) {
-        } catch (final SQLException e) {
             e.printStackTrace();
         }
         startCaching(null);
     }
-    
+
     private Connection getConnection() {
-        synchronized (_sqLite) {
+        synchronized (this.sqlite) {
-            return _sqLite.getConnection();
+            return this.sqlite.getConnection();
         }
     }
-    
+
     @Override
     public boolean startCaching(final Runnable whenDone) {
         if (!super.startCaching(whenDone)) {
@@ -73,14 +73,12 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
             @Override
             public void run() {
                 try {
-                    final HashBiMap<StringWrapper, UUID> toAdd = HashBiMap.create(new HashMap<StringWrapper, UUID>());
+                    HashBiMap<StringWrapper, UUID> toAdd = HashBiMap.create(new HashMap<StringWrapper, UUID>());
-                    final PreparedStatement statement = getConnection().prepareStatement("SELECT `uuid`, `username` FROM `usercache`");
+                    PreparedStatement statement = getConnection().prepareStatement("SELECT `uuid`, `username` FROM `usercache`");
-                    final ResultSet resultSet = statement.executeQuery();
+                    ResultSet resultSet = statement.executeQuery();
-                    StringWrapper username;
-                    UUID uuid;
                     while (resultSet.next()) {
-                        username = new StringWrapper(resultSet.getString("username"));
+                        StringWrapper username = new StringWrapper(resultSet.getString("username"));
-                        uuid = UUID.fromString(resultSet.getString("uuid"));
+                        UUID uuid = UUID.fromString(resultSet.getString("uuid"));
                         toAdd.put(new StringWrapper(username.value), uuid);
                     }
                     statement.close();
@@ -89,7 +87,7 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
 
                     // This should be called as long as there are some unknown plots
                     final ArrayDeque<UUID> toFetch = new ArrayDeque<>();
-                    for (final UUID u : UUIDHandler.getAllUUIDS()) {
+                    for (UUID u : UUIDHandler.getAllUUIDS()) {
                         if (!uuidExists(u)) {
                             toFetch.add(u);
                         }
@@ -100,7 +98,7 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
                         }
                         return;
                     }
-                    final FileUUIDHandler fileHandler = new FileUUIDHandler(SQLUUIDHandler.this.uuidWrapper);
+                    FileUUIDHandler fileHandler = new FileUUIDHandler(SQLUUIDHandler.this.uuidWrapper);
                     fileHandler.startCaching(new Runnable() {
                         @Override
                         public void run() {
@@ -125,80 +123,35 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
                                         }
                                         for (int i = 0; i < Math.min(500, toFetch.size()); i++) {
                                             UUID uuid = toFetch.pop();
-                                            HttpURLConnection connection = (HttpURLConnection) new URL(PROFILE_URL + uuid.toString().replace("-", "")).openConnection();
+                                            HttpURLConnection connection =
+                                                    (HttpURLConnection) new URL(SQLUUIDHandler.this.PROFILE_URL + uuid.toString().replace("-", ""))
+                                                            .openConnection();
                                             InputStreamReader reader = new InputStreamReader(connection.getInputStream());
-                                            JSONObject response = (JSONObject) jsonParser.parse(reader);
+                                            JSONObject response = (JSONObject) SQLUUIDHandler.this.jsonParser.parse(reader);
                                             String name = (String) response.get("name");
                                             if (name != null) {
                                                 add(new StringWrapper(name), uuid);
                                             }
                                         }
-                                    } catch (Exception e) {
+                                    } catch (IOException | ParseException e) {
                                         e.printStackTrace();
                                     }
-                                    TaskManager.runTaskLaterAsync(this, INTERVAL);
+                                    TaskManager.runTaskLaterAsync(this, SQLUUIDHandler.this.INTERVAL);
                                 }
                             });
-                            /*
-                             * This API is no longer accessible.
-                             */
-                            //                            if (!Settings.OFFLINE_MODE) {
-                            //                                PS.debug(C.PREFIX.s() + "&cWill fetch &6" + toFetch.size() + "&c from mojang!");
-                            //
-                            //                                int i = 0;
-                            //                                final Iterator<UUID> iterator = toFetch.iterator();
-                            //                                while (iterator.hasNext()) {
-                            //                                    final StringBuilder url = new StringBuilder("http://api.intellectualsites.com/uuid/?user=");
-                            //                                    final List<UUID> currentIteration = new ArrayList<>();
-                            //                                    while ((i++ <= 15) && iterator.hasNext()) {
-                            //                                        final UUID _uuid = iterator.next();
-                            //                                        url.append(_uuid.toString());
-                            //                                        if (iterator.hasNext()) {
-                            //                                            url.append(",");
-                            //                                        }
-                            //                                        currentIteration.add(_uuid);
-                            //                                    }
-                            //                                    PS.debug(C.PREFIX.s() + "&cWill attempt to fetch &6" + currentIteration.size() + "&c uuids from: &6" + url.toString());
-                            //                                    try {
-                            //                                        final HttpURLConnection connection = (HttpURLConnection) new URL(url.toString()).openConnection();
-                            //                                        connection.setRequestProperty("User-Agent", "Mozilla/5.0");
-                            //                                        final BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
-                            //                                        String line;
-                            //                                        final StringBuilder rawJSON = new StringBuilder();
-                            //                                        while ((line = reader.readLine()) != null) {
-                            //                                            rawJSON.append(line);
-                            //                                        }
-                            //                                        reader.close();
-                            //                                        final JSONObject object = new JSONObject(rawJSON.toString());
-                            //                                        for (final UUID _u : currentIteration) {
-                            //                                            final Object o = object.getJSONObject(_u.toString().replace("-", "")).get("username");
-                            //                                            if ((o == null) || !(o instanceof String)) {
-                            //                                                continue;
-                            //                                            }
-                            //                                            add(new StringWrapper(o.toString()), _u);
-                            //                                        }
-                            //                                    } catch (final Exception e) {
-                            //                                        e.printStackTrace();
-                            //                                    }
-                            //                                    i = 0;
-                            //                                }
-                            //                            }
-                            //                            if (whenDone != null) {
-                            //                                whenDone.run();
-                            //                            }
                         }
                     });
-                } catch (final SQLException e) {
+                } catch (SQLException e) {
                     throw new SQLUUIDHandlerException("Couldn't select :s", e);
                 }
             }
         });
         return true;
     }
-    
+
     @Override
     public void fetchUUID(final String name, final RunnableVal<UUID> ifFetch) {
-        PS.debug(C.PREFIX.s() + "UUID for '" + name + "' was null. We'll cache this from the mojang servers!");
+        PS.debug(C.PREFIX + "UUID for '" + name + "' was null. We'll cache this from the Mojang servers!");
         if (ifFetch == null) {
             return;
         }
@@ -206,7 +159,7 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
             @Override
             public void run() {
                 try {
-                    URL url = new URL(PROFILE_URL);
+                    URL url = new URL(SQLUUIDHandler.this.PROFILE_URL);
                     HttpURLConnection connection = (HttpURLConnection) url.openConnection();
                     connection.setRequestMethod("POST");
                     connection.setRequestProperty("Content-Type", "application/json");
@@ -218,29 +171,31 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
                     stream.write(body.getBytes());
                     stream.flush();
                     stream.close();
-                    JSONArray array = (JSONArray) jsonParser.parse(new InputStreamReader(connection.getInputStream()));
+                    JSONArray array = (JSONArray) SQLUUIDHandler.this.jsonParser.parse(new InputStreamReader(connection.getInputStream()));
                     JSONObject jsonProfile = (JSONObject) array.get(0);
                     String id = (String) jsonProfile.get("id");
                     String name = (String) jsonProfile.get("name");
-                    ifFetch.value = UUID.fromString(id.substring(0, 8) + "-" + id.substring(8, 12) + "-" + id.substring(12, 16) + "-" + id.substring(16, 20) + "-" + id.substring(20, 32));
+                    ifFetch.value = UUID.fromString(
-                } catch (Exception e) {
+                            id.substring(0, 8) + "-" + id.substring(8, 12) + "-" + id.substring(12, 16) + "-" + id.substring(16, 20) + "-" + id
+                                    .substring(20, 32));
+                } catch (IOException | ParseException e) {
                     e.printStackTrace();
                 }
                 TaskManager.runTask(ifFetch);
             }
         });
     }
-    
+
     @Override
     public void handleShutdown() {
         super.handleShutdown();
         try {
             getConnection().close();
-        } catch (final SQLException e) {
+        } catch (SQLException e) {
             throw new SQLUUIDHandlerException("Couldn't close database connection", e);
         }
     }
-    
+
     @Override
     public boolean add(final StringWrapper name, final UUID uuid) {
         // Ignoring duplicates
@@ -248,13 +203,12 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
             TaskManager.runTaskAsync(new Runnable() {
                 @Override
                 public void run() {
-                    try {
+                    try (PreparedStatement statement = getConnection().prepareStatement("REPLACE INTO usercache (`uuid`, `username`) VALUES(?, ?)")) {
-                        final PreparedStatement statement = getConnection().prepareStatement("REPLACE INTO usercache (`uuid`, `username`) VALUES(?, ?)");
                         statement.setString(1, uuid.toString());
                         statement.setString(2, name.toString());
                         statement.execute();
-                        PS.debug(C.PREFIX.s() + "&cAdded '&6" + uuid + "&c' - '&6" + name + "&c'");
+                        PS.debug(C.PREFIX + "&cAdded '&6" + uuid + "&c' - '&6" + name + "&c'");
-                    } catch (final SQLException e) {
+                    } catch (SQLException e) {
                         e.printStackTrace();
                     }
                 }
@@ -263,7 +217,7 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
         }
         return false;
     }
-    
+
     /**
      * This is useful for name changes
      */
@@ -273,13 +227,12 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
         TaskManager.runTaskAsync(new Runnable() {
             @Override
             public void run() {
-                try {
+                try (PreparedStatement statement = getConnection().prepareStatement("UPDATE usercache SET `username`=? WHERE `uuid`=?")) {
-                    final PreparedStatement statement = getConnection().prepareStatement("UPDATE usercache SET `username`=? WHERE `uuid`=?");
                     statement.setString(1, name.value);
                     statement.setString(2, uuid.toString());
                     statement.execute();
-                    PS.debug(C.PREFIX.s() + "Name change for '" + uuid + "' to '" + name.value + "'");
+                    PS.debug(C.PREFIX + "Name change for '" + uuid + "' to '" + name.value + "'");
-                } catch (final SQLException e) {
+                } catch (SQLException e) {
                     e.printStackTrace();
                 }
             }
@@ -288,7 +241,7 @@ public class SQLUUIDHandler extends UUIDHandlerImplementation {
 
     private class SQLUUIDHandlerException extends RuntimeException {
 
-        SQLUUIDHandlerException(final String s, final Throwable c) {
+        SQLUUIDHandlerException(String s, Throwable c) {
             super("SQLUUIDHandler caused an exception: " + s, c);
         }
     }

Bukkit/src/main/resources/plugin.yml

@@ -150,4 +150,6 @@ permissions:
   plots.worldedit.bypass:
     default: false
   plots.gamemode.bypass:
-    default: op
+    default: op
+  plots.confirm.bypass:
+    default: false

Core/src/main/java/com/intellectualcrafters/configuration/ConfigurationSection.java

@@ -8,6 +8,7 @@ import java.util.Set;
  * Represents a section of a {@link Configuration}
  */
 public interface ConfigurationSection {
+
     /**
      * Gets a set containing all keys in this section.
      * <p>
@@ -22,8 +23,8 @@ public interface ConfigurationSection {
      *     list.
      * @return Set of keys contained within this ConfigurationSection.
      */
-    Set<String> getKeys(final boolean deep);
+    Set<String> getKeys(boolean deep);
-    
+
     /**
      * Gets a Map containing all keys and their values for this section.
      * <p>
@@ -38,8 +39,8 @@ public interface ConfigurationSection {
      *     list.
      * @return Map of keys and values of this section.
      */
-    Map<String, Object> getValues(final boolean deep);
+    Map<String, Object> getValues(boolean deep);
-    
+
     /**
      * Checks if this {@link ConfigurationSection} contains the given path.
      * <p>
@@ -51,8 +52,8 @@ public interface ConfigurationSection {
      *     default or being set.
      * @throws IllegalArgumentException Thrown when path is null.
      */
-    boolean contains(final String path);
+    boolean contains(String path);
-    
+
     /**
      * Checks if this {@link ConfigurationSection} has a value set for the
      * given path.
@@ -65,8 +66,8 @@ public interface ConfigurationSection {
      *     having a default.
      * @throws IllegalArgumentException Thrown when path is null.
      */
-    boolean isSet(final String path);
+    boolean isSet(String path);
-    
+
     /**
      * Gets the path of this {@link ConfigurationSection} from its root {@link
      * Configuration}
@@ -83,7 +84,7 @@ public interface ConfigurationSection {
      * @return Path of this section relative to its root
      */
     String getCurrentPath();
-    
+
     /**
      * Gets the name of this individual {@link ConfigurationSection}, in the
      * path.
@@ -94,7 +95,7 @@ public interface ConfigurationSection {
      * @return Name of this section
      */
     String getName();
-    
+
     /**
      * Gets the root {@link Configuration} that contains this {@link
      * ConfigurationSection}
@@ -108,7 +109,7 @@ public interface ConfigurationSection {
      * @return Root configuration containing this section.
      */
     Configuration getRoot();
-    
+
     /**
      * Gets the parent {@link ConfigurationSection} that directly contains
      * this {@link ConfigurationSection}.
@@ -121,7 +122,7 @@ public interface ConfigurationSection {
      * @return Parent section containing this section.
      */
     ConfigurationSection getParent();
-    
+
     /**
      * Gets the requested Object by path.
      * <p>
@@ -132,8 +133,8 @@ public interface ConfigurationSection {
      * @param path Path of the Object to get.
      * @return Requested Object.
      */
-    Object get(final String path);
+    Object get(String path);
-    
+
     /**
      * Gets the requested Object by path, returning a default value if not
      * found.
@@ -146,8 +147,8 @@ public interface ConfigurationSection {
      * @param def The default value to return if the path is not found.
      * @return Requested Object.
      */
-    Object get(final String path, final Object def);
+    Object get(String path, Object def);
-    
+
     /**
      * Sets the specified path to the given value.
      * <p>
@@ -162,8 +163,8 @@ public interface ConfigurationSection {
      * @param path Path of the object to set.
      * @param value New value to set the path to.
      */
-    void set(final String path, final Object value);
+    void set(String path, Object value);
-    
+
     /**
      * Creates an empty {@link ConfigurationSection} at the specified path.
      * <p>
@@ -174,8 +175,8 @@ public interface ConfigurationSection {
      * @param path Path to create the section at.
      * @return Newly created section
      */
-    ConfigurationSection createSection(final String path);
+    ConfigurationSection createSection(String path);
-    
+
     /**
      * Creates a {@link ConfigurationSection} at the specified path, with
      * specified values.
@@ -188,9 +189,10 @@ public interface ConfigurationSection {
      * @param map The values to used.
      * @return Newly created section
      */
-    ConfigurationSection createSection(final String path, final Map<?, ?> map);
+    ConfigurationSection createSection(String path, Map<?, ?> map);
-    
+
     // Primitives
+
     /**
      * Gets the requested String by path.
      * <p>
@@ -201,8 +203,8 @@ public interface ConfigurationSection {
      * @param path Path of the String to get.
      * @return Requested String.
      */
-    String getString(final String path);
+    String getString(String path);
-    
+
     /**
      * Gets the requested String by path, returning a default value if not
      * found.
@@ -216,60 +218,60 @@ public interface ConfigurationSection {
      *     not a String.
      * @return Requested String.
      */
-    String getString(final String path, final String def);
+    String getString(String path, String def);
-    
+
     /**
      * Checks if the specified path is a String.
-     * <p>
+     *
-     * If the path exists but is not a String, this will return false. If the
+     * <p> If the path exists but is not a String, this will return false. If the
      * path does not exist, this will return false. If the path does not exist
      * but a default value has been specified, this will check if that default
-     * value is a String and return appropriately.
+     * value is a String and return appropriately.</p>
      *
      * @param path Path of the String to check.
      * @return Whether or not the specified path is a String.
      */
-    boolean isString(final String path);
+    boolean isString(String path);
-    
+
     /**
      * Gets the requested int by path.
-     * <p>
+     *
-     * If the int does not exist but a default value has been specified, this
+     * <p>If the int does not exist but a default value has been specified, this
      * will return the default value. If the int does not exist and no default
-     * value was specified, this will return 0.
+     * value was specified, this will return 0.</p>
      *
      * @param path Path of the int to get.
      * @return Requested int.
      */
-    int getInt(final String path);
+    int getInt(String path);
-    
+
     /**
      * Gets the requested int by path, returning a default value if not found.
-     * <p>
+     *
-     * If the int does not exist then the specified default value will
+     * <p>If the int does not exist then the specified default value will
      * returned regardless of if a default has been identified in the root
-     * {@link Configuration}.
+     * {@link Configuration}.</p>
      *
      * @param path Path of the int to get.
      * @param def The default value to return if the path is not found or is
      *     not an int.
      * @return Requested int.
      */
-    int getInt(final String path, final int def);
+    int getInt(String path, int def);
-    
+
     /**
      * Checks if the specified path is an int.
-     * <p>
+     *
-     * If the path exists but is not a int, this will return false. If the
+     * <p>If the path exists but is not a int, this will return false. If the
      * path does not exist, this will return false. If the path does not exist
      * but a default value has been specified, this will check if that default
-     * value is a int and return appropriately.
+     * value is a int and return appropriately.</p>
      *
      * @param path Path of the int to check.
      * @return Whether or not the specified path is an int.
      */
-    boolean isInt(final String path);
+    boolean isInt(String path);
-    
+
     /**
      * Gets the requested boolean by path.
      * <p>
@@ -280,8 +282,8 @@ public interface ConfigurationSection {
      * @param path Path of the boolean to get.
      * @return Requested boolean.
      */
-    boolean getBoolean(final String path);
+    boolean getBoolean(String path);
-    
+
     /**
      * Gets the requested boolean by path, returning a default value if not
      * found.
@@ -295,8 +297,8 @@ public interface ConfigurationSection {
      *     not a boolean.
      * @return Requested boolean.
      */
-    boolean getBoolean(final String path, final boolean def);
+    boolean getBoolean(String path, boolean def);
-    
+
     /**
      * Checks if the specified path is a boolean.
      * <p>
@@ -308,8 +310,8 @@ public interface ConfigurationSection {
      * @param path Path of the boolean to check.
      * @return Whether or not the specified path is a boolean.
      */
-    boolean isBoolean(final String path);
+    boolean isBoolean(String path);
-    
+
     /**
      * Gets the requested double by path.
      * <p>
@@ -320,8 +322,8 @@ public interface ConfigurationSection {
      * @param path Path of the double to get.
      * @return Requested double.
      */
-    double getDouble(final String path);
+    double getDouble(String path);
-    
+
     /**
      * Gets the requested double by path, returning a default value if not
      * found.
@@ -335,8 +337,8 @@ public interface ConfigurationSection {
      *     not a double.
      * @return Requested double.
      */
-    double getDouble(final String path, final double def);
+    double getDouble(String path, double def);
-    
+
     /**
      * Checks if the specified path is a double.
      * <p>
@@ -348,8 +350,8 @@ public interface ConfigurationSection {
      * @param path Path of the double to check.
      * @return Whether or not the specified path is a double.
      */
-    boolean isDouble(final String path);
+    boolean isDouble(String path);
-    
+
     /**
      * Gets the requested long by path.
      * <p>
@@ -360,8 +362,8 @@ public interface ConfigurationSection {
      * @param path Path of the long to get.
      * @return Requested long.
      */
-    long getLong(final String path);
+    long getLong(String path);
-    
+
     /**
      * Gets the requested long by path, returning a default value if not
      * found.
@@ -375,8 +377,8 @@ public interface ConfigurationSection {
      *     not a long.
      * @return Requested long.
      */
-    long getLong(final String path, final long def);
+    long getLong(String path, long def);
-    
+
     /**
      * Checks if the specified path is a long.
      * <p>
@@ -388,9 +390,10 @@ public interface ConfigurationSection {
      * @param path Path of the long to check.
      * @return Whether or not the specified path is a long.
      */
-    boolean isLong(final String path);
+    boolean isLong(String path);
-    
+
     // Java
+
     /**
      * Gets the requested List by path.
      * <p>
@@ -401,8 +404,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List.
      */
-    List<?> getList(final String path);
+    List<?> getList(String path);
-    
+
     /**
      * Gets the requested List by path, returning a default value if not
      * found.
@@ -416,8 +419,8 @@ public interface ConfigurationSection {
      *     not a List.
      * @return Requested List.
      */
-    List<?> getList(final String path, final List<?> def);
+    List<?> getList(String path, List<?> def);
-    
+
     /**
      * Checks if the specified path is a List.
      * <p>
@@ -429,8 +432,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to check.
      * @return Whether or not the specified path is a List.
      */
-    boolean isList(final String path);
+    boolean isList(String path);
-    
+
     /**
      * Gets the requested List of String by path.
      * <p>
@@ -444,8 +447,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of String.
      */
-    List<String> getStringList(final String path);
+    List<String> getStringList(String path);
-    
+
     /**
      * Gets the requested List of Integer by path.
      * <p>
@@ -459,8 +462,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Integer.
      */
-    List<Integer> getIntegerList(final String path);
+    List<Integer> getIntegerList(String path);
-    
+
     /**
      * Gets the requested List of Boolean by path.
      * <p>
@@ -474,8 +477,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Boolean.
      */
-    List<Boolean> getBooleanList(final String path);
+    List<Boolean> getBooleanList(String path);
-    
+
     /**
      * Gets the requested List of Double by path.
      * <p>
@@ -489,8 +492,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Double.
      */
-    List<Double> getDoubleList(final String path);
+    List<Double> getDoubleList(String path);
-    
+
     /**
      * Gets the requested List of Float by path.
      * <p>
@@ -504,8 +507,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Float.
      */
-    List<Float> getFloatList(final String path);
+    List<Float> getFloatList(String path);
-    
+
     /**
      * Gets the requested List of Long by path.
      * <p>
@@ -519,8 +522,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Long.
      */
-    List<Long> getLongList(final String path);
+    List<Long> getLongList(String path);
-    
+
     /**
      * Gets the requested List of Byte by path.
      * <p>
@@ -534,8 +537,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Byte.
      */
-    List<Byte> getByteList(final String path);
+    List<Byte> getByteList(String path);
-    
+
     /**
      * Gets the requested List of Character by path.
      * <p>
@@ -549,8 +552,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Character.
      */
-    List<Character> getCharacterList(final String path);
+    List<Character> getCharacterList(String path);
-    
+
     /**
      * Gets the requested List of Short by path.
      * <p>
@@ -564,8 +567,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Short.
      */
-    List<Short> getShortList(final String path);
+    List<Short> getShortList(String path);
-    
+
     /**
      * Gets the requested List of Maps by path.
      * <p>
@@ -579,8 +582,8 @@ public interface ConfigurationSection {
      * @param path Path of the List to get.
      * @return Requested List of Maps.
      */
-    List<Map<?, ?>> getMapList(final String path);
+    List<Map<?, ?>> getMapList(String path);
-    
+
     /**
      * Gets the requested ConfigurationSection by path.
      * <p>
@@ -592,8 +595,8 @@ public interface ConfigurationSection {
      * @param path Path of the ConfigurationSection to get.
      * @return Requested ConfigurationSection.
      */
-    ConfigurationSection getConfigurationSection(final String path);
+    ConfigurationSection getConfigurationSection(String path);
-    
+
     /**
      * Checks if the specified path is a ConfigurationSection.
      * <p>
@@ -606,8 +609,8 @@ public interface ConfigurationSection {
      * @param path Path of the ConfigurationSection to check.
      * @return Whether or not the specified path is a ConfigurationSection.
      */
-    boolean isConfigurationSection(final String path);
+    boolean isConfigurationSection(String path);
-    
+
     /**
      * Gets the equivalent {@link ConfigurationSection} from the default
      * {@link Configuration} defined in {@link #getRoot()}.
@@ -619,7 +622,7 @@ public interface ConfigurationSection {
      * @return Equivalent section in root configuration
      */
     ConfigurationSection getDefaultSection();
-    
+
     /**
      * Sets the default value in the root at the given path as provided.
      * <p>
@@ -638,5 +641,5 @@ public interface ConfigurationSection {
      * @param value Value to set the default to.
      * @throws IllegalArgumentException Thrown if path is null.
      */
-    void addDefault(final String path, final Object value);
+    void addDefault(String path, Object value);
 }

Core/src/main/java/com/intellectualcrafters/configuration/MemorySection.java

@@ -11,6 +11,7 @@ import java.util.Set;
  * A type of {@link ConfigurationSection} that is stored in memory.
  */
 public class MemorySection implements ConfigurationSection {
+
     protected final Map<String, Object> map = new LinkedHashMap<>();
     private final Configuration root;
     private final ConfigurationSection parent;
@@ -32,10 +33,10 @@ public class MemorySection implements ConfigurationSection {
             throw new IllegalStateException("Cannot construct a root MemorySection when not a Configuration");
         }
 
-        path = "";
+        this.path = "";
-        fullPath = "";
+        this.fullPath = "";
-        parent = null;
+        this.parent = null;
-        root = (Configuration) this;
+        this.root = (Configuration) this;
     }
 
     /**
@@ -47,7 +48,7 @@ public class MemorySection implements ConfigurationSection {
      * @throws IllegalArgumentException Thrown is parent or path is null, or
      *     if parent contains no root Configuration.
      */
-    protected MemorySection(final ConfigurationSection parent, final String path) {
+    protected MemorySection(ConfigurationSection parent, String path) {
         if (parent == null) {
             throw new NullPointerException("Parent may not be null");
         }
@@ -57,16 +58,16 @@ public class MemorySection implements ConfigurationSection {
 
         this.path = path;
         this.parent = parent;
-        root = parent.getRoot();
+        this.root = parent.getRoot();
 
-        if (root == null) {
+        if (this.root == null) {
             throw new NullPointerException("Path may not be orphaned");
         }
 
-        fullPath = createPath(parent, path);
+        this.fullPath = createPath(parent, path);
     }
 
-    public static double toDouble(final Object obj, final double def) {
+    public static double toDouble(Object obj, double def) {
         if (obj instanceof Number) {
             return ((Number) obj).doubleValue();
         }
@@ -76,15 +77,15 @@ public class MemorySection implements ConfigurationSection {
             } catch (NumberFormatException ignored) {
             }
         } else if (obj instanceof List) {
-            final List<?> val = ((List<?>) obj);
+            List<?> val = (List<?>) obj;
             if (!val.isEmpty()) {
                 return toDouble(val.get(0), def);
             }
         }
         return def;
     }
-    
+
-    public static int toInt(final Object obj, final int def) {
+    public static int toInt(Object obj, int def) {
         if (obj instanceof Number) {
             return ((Number) obj).intValue();
         }
@@ -94,15 +95,15 @@ public class MemorySection implements ConfigurationSection {
             } catch (NumberFormatException ignored) {
             }
         } else if (obj instanceof List) {
-            final List<?> val = ((List<?>) obj);
+            List<?> val = (List<?>) obj;
             if (!val.isEmpty()) {
                 return toInt(val.get(0), def);
             }
         }
         return def;
     }
-    
+
-    public static long toLong(final Object obj, final long def) {
+    public static long toLong(Object obj, long def) {
         if (obj instanceof Number) {
             return ((Number) obj).longValue();
         }
@@ -112,14 +113,14 @@ public class MemorySection implements ConfigurationSection {
             } catch (NumberFormatException ignored) {
             }
         } else if (obj instanceof List) {
-            final List<?> val = ((List<?>) obj);
+            List<?> val = (List<?>) obj;
             if (!val.isEmpty()) {
                 return toLong(val.get(0), def);
             }
         }
         return def;
     }
-    
+
     /**
      * Creates a full path to the given {@link ConfigurationSection} from its
      * root {@link Configuration}.
@@ -131,10 +132,10 @@ public class MemorySection implements ConfigurationSection {
      * @param key Name of the specified section.
      * @return Full path of the section from its root.
      */
-    public static String createPath(final ConfigurationSection section, final String key) {
+    public static String createPath(ConfigurationSection section, String key) {
         return createPath(section, key, (section == null) ? null : section.getRoot());
     }
-    
+
     /**
      * Creates a relative path to the given {@link ConfigurationSection} from
      * the given relative section.
@@ -147,17 +148,17 @@ public class MemorySection implements ConfigurationSection {
      * @param relativeTo Section to create the path relative to.
      * @return Full path of the section from its root.
      */
-    public static String createPath(final ConfigurationSection section, final String key, final ConfigurationSection relativeTo) {
+    public static String createPath(ConfigurationSection section, String key, ConfigurationSection relativeTo) {
         if (section == null) {
             throw new NullPointerException("Cannot create path without a section");
         }
-        final Configuration root = section.getRoot();
+        Configuration root = section.getRoot();
         if (root == null) {
             throw new IllegalStateException("Cannot create path without a root");
         }
-        final char separator = root.options().pathSeparator();
+        char separator = root.options().pathSeparator();
 
-        final StringBuilder builder = new StringBuilder();
+        StringBuilder builder = new StringBuilder();
         for (ConfigurationSection parent = section; (parent != null) && (parent != relativeTo); parent = parent.getParent()) {
             if (builder.length() > 0) {
                 builder.insert(0, separator);
@@ -166,7 +167,7 @@ public class MemorySection implements ConfigurationSection {
             builder.insert(0, parent.getName());
         }
 
-        if ((key != null) && (!key.isEmpty())) {
+        if ((key != null) && !key.isEmpty()) {
             if (builder.length() > 0) {
                 builder.append(separator);
             }
@@ -176,14 +177,14 @@ public class MemorySection implements ConfigurationSection {
 
         return builder.toString();
     }
-    
-    @Override
-    public Set<String> getKeys(final boolean deep) {
-        final Set<String> result = new LinkedHashSet<>();
 
-        final Configuration root = getRoot();
+    @Override
+    public Set<String> getKeys(boolean deep) {
+        Set<String> result = new LinkedHashSet<>();
+
+        Configuration root = getRoot();
         if ((root != null) && root.options().copyDefaults()) {
-            final ConfigurationSection defaults = getDefaultSection();
+            ConfigurationSection defaults = getDefaultSection();
 
             if (defaults != null) {
                 result.addAll(defaults.getKeys(deep));
@@ -194,14 +195,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
-    @Override
-    public Map<String, Object> getValues(final boolean deep) {
-        final Map<String, Object> result = new LinkedHashMap<>();
 
-        final Configuration root = getRoot();
+    @Override
+    public Map<String, Object> getValues(boolean deep) {
+        Map<String, Object> result = new LinkedHashMap<>();
+
+        Configuration root = getRoot();
         if ((root != null) && root.options().copyDefaults()) {
-            final ConfigurationSection defaults = getDefaultSection();
+            ConfigurationSection defaults = getDefaultSection();
 
             if (defaults != null) {
                 result.putAll(defaults.getValues(deep));
@@ -212,15 +213,15 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public boolean contains(final String path) {
+    public boolean contains(String path) {
         return get(path) != null;
     }
-    
+
     @Override
-    public boolean isSet(final String path) {
+    public boolean isSet(String path) {
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
         if (root == null) {
             return false;
         }
@@ -229,34 +230,34 @@ public class MemorySection implements ConfigurationSection {
         }
         return get(path, null) != null;
     }
-    
+
     @Override
     public String getCurrentPath() {
-        return fullPath;
+        return this.fullPath;
     }
-    
+
     @Override
     public String getName() {
-        return path;
+        return this.path;
     }
-    
+
     @Override
     public Configuration getRoot() {
-        return root;
+        return this.root;
     }
-    
+
     @Override
     public ConfigurationSection getParent() {
-        return parent;
+        return this.parent;
     }
-    
+
     @Override
-    public void addDefault(final String path, final Object value) {
+    public void addDefault(String path, Object value) {
         if (path == null) {
             throw new NullPointerException("Path cannot be null");
         }
 
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
         if (root == null) {
             throw new IllegalStateException("Cannot add default without root");
         }
@@ -265,11 +266,11 @@ public class MemorySection implements ConfigurationSection {
         }
         root.addDefault(createPath(this, path), value);
     }
-    
+
     @Override
     public ConfigurationSection getDefaultSection() {
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
-        final Configuration defaults = root == null ? null : root.getDefaults();
+        Configuration defaults = root == null ? null : root.getDefaults();
 
         if (defaults != null) {
             if (defaults.isConfigurationSection(getCurrentPath())) {
@@ -279,26 +280,26 @@ public class MemorySection implements ConfigurationSection {
 
         return null;
     }
-    
+
     @Override
-    public void set(final String path, final Object value) {
+    public void set(String path, Object value) {
         if (path == null) {
             throw new NullPointerException("Cannot set to an empty path");
         }
 
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
         if (root == null) {
             throw new IllegalStateException("Cannot use section without a root");
         }
 
-        final char separator = root.options().pathSeparator();
+        char separator = root.options().pathSeparator();
         // i1 is the leading (higher) index
         // i2 is the trailing (lower) index
         int i1 = -1, i2;
         ConfigurationSection section = this;
         while ((i1 = path.indexOf(separator, i2 = i1 + 1)) != -1) {
-            final String node = path.substring(i2, i1);
+            String node = path.substring(i2, i1);
-            final ConfigurationSection subSection = section.getConfigurationSection(node);
+            ConfigurationSection subSection = section.getConfigurationSection(node);
             if (subSection == null) {
                 section = section.createSection(node);
             } else {
@@ -306,25 +307,25 @@ public class MemorySection implements ConfigurationSection {
             }
         }
 
-        final String key = path.substring(i2);
+        String key = path.substring(i2);
         if (section == this) {
             if (value == null) {
-                map.remove(key);
+                this.map.remove(key);
             } else {
-                map.put(key, value);
+                this.map.put(key, value);
             }
         } else {
             section.set(key, value);
         }
     }
-    
+
     @Override
-    public Object get(final String path) {
+    public Object get(String path) {
         return get(path, getDefault(path));
     }
-    
+
     @Override
-    public Object get(final String path, final Object def) {
+    public Object get(String path, Object def) {
         if (path == null) {
             throw new NullPointerException("Path cannot be null");
         }
@@ -333,15 +334,16 @@ public class MemorySection implements ConfigurationSection {
             return this;
         }
 
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
         if (root == null) {
             throw new IllegalStateException("Cannot access section without a root");
         }
 
-        final char separator = root.options().pathSeparator();
+        char separator = root.options().pathSeparator();
         // i1 is the leading (higher) index
         // i2 is the trailing (lower) index
-        int i1 = -1, i2;
+        int i1 = -1;
+        int i2;
         ConfigurationSection section = this;
         while ((i1 = path.indexOf(separator, i2 = i1 + 1)) != -1) {
             section = section.getConfigurationSection(path.substring(i2, i1));
@@ -350,32 +352,36 @@ public class MemorySection implements ConfigurationSection {
             }
         }
 
-        final String key = path.substring(i2);
+        String key = path.substring(i2);
         if (section == this) {
-            final Object result = map.get(key);
+            Object result = this.map.get(key);
-            return (result == null) ? def : result;
+            if (result == null) {
+                return def;
+            } else {
+                return result;
+            }
         }
         return section.get(key, def);
     }
-    
+
     @Override
-    public ConfigurationSection createSection(final String path) {
+    public ConfigurationSection createSection(String path) {
         if (path == null) {
             throw new NullPointerException("Cannot create section at empty path");
         }
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
         if (root == null) {
             throw new IllegalStateException("Cannot create section without a root");
         }
 
-        final char separator = root.options().pathSeparator();
+        char separator = root.options().pathSeparator();
         // i1 is the leading (higher) index
         // i2 is the trailing (lower) index
         int i1 = -1, i2;
         ConfigurationSection section = this;
         while ((i1 = path.indexOf(separator, i2 = i1 + 1)) != -1) {
-            final String node = path.substring(i2, i1);
+            String node = path.substring(i2, i1);
-            final ConfigurationSection subSection = section.getConfigurationSection(node);
+            ConfigurationSection subSection = section.getConfigurationSection(node);
             if (subSection == null) {
                 section = section.createSection(node);
             } else {
@@ -383,20 +389,20 @@ public class MemorySection implements ConfigurationSection {
             }
         }
 
-        final String key = path.substring(i2);
+        String key = path.substring(i2);
         if (section == this) {
-            final ConfigurationSection result = new MemorySection(this, key);
+            ConfigurationSection result = new MemorySection(this, key);
-            map.put(key, result);
+            this.map.put(key, result);
             return result;
         }
         return section.createSection(key);
     }
-    
-    @Override
-    public ConfigurationSection createSection(final String path, final Map<?, ?> map) {
-        final ConfigurationSection section = createSection(path);
 
-        for (final Map.Entry<?, ?> entry : map.entrySet()) {
+    @Override
+    public ConfigurationSection createSection(String path, Map<?, ?> map) {
+        ConfigurationSection section = createSection(path);
+
+        for (Map.Entry<?, ?> entry : map.entrySet()) {
             if (entry.getValue() instanceof Map) {
                 section.createSection(entry.getKey().toString(), (Map<?, ?>) entry.getValue());
             } else {
@@ -406,119 +412,131 @@ public class MemorySection implements ConfigurationSection {
 
         return section;
     }
-    
+
     // Primitives
     @Override
-    public String getString(final String path) {
+    public String getString(String path) {
-        final Object def = getDefault(path);
+        Object def = getDefault(path);
         return getString(path, def != null ? def.toString() : null);
     }
-    
+
     @Override
-    public String getString(final String path, final String def) {
+    public String getString(String path, String def) {
-        final Object val = get(path, def);
+        Object val = get(path, def);
-        return (val != null) ? val.toString() : def;
+        if (val != null) {
+            return val.toString();
+        } else {
+            return def;
+        }
     }
-    
+
     @Override
-    public boolean isString(final String path) {
+    public boolean isString(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof String;
     }
-    
+
     @Override
-    public int getInt(final String path) {
+    public int getInt(String path) {
-        final Object def = getDefault(path);
+        Object def = getDefault(path);
         return getInt(path, toInt(def, 0));
     }
-    
+
     @Override
-    public int getInt(final String path, final int def) {
+    public int getInt(String path, int def) {
-        final Object val = get(path, def);
+        Object val = get(path, def);
         return toInt(val, def);
     }
-    
+
     @Override
-    public boolean isInt(final String path) {
+    public boolean isInt(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof Integer;
     }
-    
+
     @Override
-    public boolean getBoolean(final String path) {
+    public boolean getBoolean(String path) {
-        final Object def = getDefault(path);
+        Object def = getDefault(path);
-        return getBoolean(path, (def instanceof Boolean) ? (Boolean) def : false);
+        if (def instanceof Boolean) {
+            return getBoolean(path, (Boolean) def);
+        } else {
+            return getBoolean(path, false);
+        }
     }
-    
+
     @Override
-    public boolean getBoolean(final String path, final boolean def) {
+    public boolean getBoolean(String path, boolean def) {
-        final Object val = get(path, def);
+        Object val = get(path, def);
-        return (val instanceof Boolean) ? (Boolean) val : def;
+        if (val instanceof Boolean) {
+            return (Boolean) val;
+        } else {
+            return def;
+        }
     }
-    
+
     @Override
-    public boolean isBoolean(final String path) {
+    public boolean isBoolean(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof Boolean;
     }
-    
+
     @Override
-    public double getDouble(final String path) {
+    public double getDouble(String path) {
-        final Object def = getDefault(path);
+        Object def = getDefault(path);
         return getDouble(path, toDouble(def, 0));
     }
-    
+
     @Override
-    public double getDouble(final String path, final double def) {
+    public double getDouble(String path, double def) {
-        final Object val = get(path, def);
+        Object val = get(path, def);
         return toDouble(val, def);
     }
-    
+
     @Override
-    public boolean isDouble(final String path) {
+    public boolean isDouble(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof Double;
     }
-    
+
     @Override
-    public long getLong(final String path) {
+    public long getLong(String path) {
-        final Object def = getDefault(path);
+        Object def = getDefault(path);
         return getLong(path, toLong(def, 0));
     }
-    
+
     @Override
-    public long getLong(final String path, final long def) {
+    public long getLong(String path, long def) {
-        final Object val = get(path, def);
+        Object val = get(path, def);
         return toLong(val, def);
     }
-    
+
     @Override
-    public boolean isLong(final String path) {
+    public boolean isLong(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof Long;
     }
-    
+
     // Java
     @Override
-    public List<?> getList(final String path) {
+    public List<?> getList(String path) {
-        final Object def = getDefault(path);
+        Object def = getDefault(path);
-        return getList(path, (def instanceof List) ? (List<?>) def : null);
+        return getList(path, def instanceof List ? (List<?>) def : null);
     }
-    
+
     @Override
-    public List<?> getList(final String path, final List<?> def) {
+    public List<?> getList(String path, List<?> def) {
-        final Object val = get(path, def);
+        Object val = get(path, def);
         return (List<?>) ((val instanceof List) ? val : def);
     }
-    
+
     @Override
-    public boolean isList(final String path) {
+    public boolean isList(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof List;
     }
-    
+
     @Override
-    public List<String> getStringList(final String path) {
+    public List<String> getStringList(String path) {
         final List<?> list = getList(path);
 
         if (list == null) {
@@ -535,18 +553,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Integer> getIntegerList(final String path) {
+    public List<Integer> getIntegerList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Integer> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Integer> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Integer) {
                 result.add((Integer) object);
             } else if (object instanceof String) {
@@ -563,18 +577,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Boolean> getBooleanList(final String path) {
+    public List<Boolean> getBooleanList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Boolean> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Boolean> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Boolean) {
                 result.add((Boolean) object);
             } else if (object instanceof String) {
@@ -588,18 +598,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Double> getDoubleList(final String path) {
+    public List<Double> getDoubleList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Double> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Double> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Double) {
                 result.add((Double) object);
             } else if (object instanceof String) {
@@ -616,18 +622,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Float> getFloatList(final String path) {
+    public List<Float> getFloatList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Float> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Float> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Float) {
                 result.add((Float) object);
             } else if (object instanceof String) {
@@ -644,18 +646,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Long> getLongList(final String path) {
+    public List<Long> getLongList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Long> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Long> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Long) {
                 result.add((Long) object);
             } else if (object instanceof String) {
@@ -672,18 +670,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Byte> getByteList(final String path) {
+    public List<Byte> getByteList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Byte> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Byte> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Byte) {
                 result.add((Byte) object);
             } else if (object instanceof String) {
@@ -700,22 +694,18 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Character> getCharacterList(final String path) {
+    public List<Character> getCharacterList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Character> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Character> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Character) {
                 result.add((Character) object);
             } else if (object instanceof String) {
-                final String str = (String) object;
+                String str = (String) object;
 
                 if (str.length() == 1) {
                     result.add(str.charAt(0));
@@ -727,18 +717,14 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Short> getShortList(final String path) {
+    public List<Short> getShortList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
 
-        if (list == null) {
+        List<Short> result = new ArrayList<>();
-            return new ArrayList<>(0);
-        }
 
-        final List<Short> result = new ArrayList<>();
+        for (Object object : list) {
-
-        for (final Object object : list) {
             if (object instanceof Short) {
                 result.add((Short) object);
             } else if (object instanceof String) {
@@ -755,17 +741,13 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public List<Map<?, ?>> getMapList(final String path) {
+    public List<Map<?, ?>> getMapList(String path) {
-        final List<?> list = getList(path);
+        List<?> list = getList(path);
-        final List<Map<?, ?>> result = new ArrayList<>();
+        List<Map<?, ?>> result = new ArrayList<>();
 
-        if (list == null) {
+        for (Object object : list) {
-            return result;
-        }
-
-        for (final Object object : list) {
             if (object instanceof Map) {
                 result.add((Map<?, ?>) object);
             }
@@ -773,9 +755,9 @@ public class MemorySection implements ConfigurationSection {
 
         return result;
     }
-    
+
     @Override
-    public ConfigurationSection getConfigurationSection(final String path) {
+    public ConfigurationSection getConfigurationSection(String path) {
         Object val = get(path, null);
         if (val != null) {
             return (val instanceof ConfigurationSection) ? (ConfigurationSection) val : null;
@@ -784,60 +766,60 @@ public class MemorySection implements ConfigurationSection {
         val = get(path, getDefault(path));
         return (val instanceof ConfigurationSection) ? createSection(path) : null;
     }
-    
+
     @Override
-    public boolean isConfigurationSection(final String path) {
+    public boolean isConfigurationSection(String path) {
-        final Object val = get(path);
+        Object val = get(path);
         return val instanceof ConfigurationSection;
     }
-    
+
-    protected boolean isPrimitiveWrapper(final Object input) {
+    protected boolean isPrimitiveWrapper(Object input) {
         return (input instanceof Integer)
-        || (input instanceof Boolean)
+                || (input instanceof Boolean)
-        || (input instanceof Character)
+                || (input instanceof Character)
-        || (input instanceof Byte)
+                || (input instanceof Byte)
-        || (input instanceof Short)
+                || (input instanceof Short)
-        || (input instanceof Double)
+                || (input instanceof Double)
-        || (input instanceof Long)
+                || (input instanceof Long)
-        || (input instanceof Float);
+                || (input instanceof Float);
     }
-    
+
-    protected Object getDefault(final String path) {
+    protected Object getDefault(String path) {
         if (path == null) {
             throw new NullPointerException("Path may not be null");
         }
 
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
-        final Configuration defaults = root == null ? null : root.getDefaults();
+        Configuration defaults = root == null ? null : root.getDefaults();
         return (defaults == null) ? null : defaults.get(createPath(this, path));
     }
-    
-    protected void mapChildrenKeys(final Set<String> output, final ConfigurationSection section, final boolean deep) {
-        if (section instanceof MemorySection) {
-            final MemorySection sec = (MemorySection) section;
 
-            for (final Map.Entry<String, Object> entry : sec.map.entrySet()) {
+    protected void mapChildrenKeys(Set<String> output, ConfigurationSection section, boolean deep) {
+        if (section instanceof MemorySection) {
+            MemorySection sec = (MemorySection) section;
+
+            for (Map.Entry<String, Object> entry : sec.map.entrySet()) {
                 output.add(createPath(section, entry.getKey(), this));
 
-                if ((deep) && (entry.getValue() instanceof ConfigurationSection)) {
+                if (deep && (entry.getValue() instanceof ConfigurationSection)) {
-                    final ConfigurationSection subsection = (ConfigurationSection) entry.getValue();
+                    ConfigurationSection subsection = (ConfigurationSection) entry.getValue();
                     mapChildrenKeys(output, subsection, deep);
                 }
             }
         } else {
-            final Set<String> keys = section.getKeys(deep);
+            Set<String> keys = section.getKeys(deep);
 
-            for (final String key : keys) {
+            for (String key : keys) {
                 output.add(createPath(section, key, this));
             }
         }
     }
-    
-    protected void mapChildrenValues(final Map<String, Object> output, final ConfigurationSection section, final boolean deep) {
-        if (section instanceof MemorySection) {
-            final MemorySection sec = (MemorySection) section;
 
-            for (final Map.Entry<String, Object> entry : sec.map.entrySet()) {
+    protected void mapChildrenValues(Map<String, Object> output, ConfigurationSection section, boolean deep) {
+        if (section instanceof MemorySection) {
+            MemorySection sec = (MemorySection) section;
+
+            for (Map.Entry<String, Object> entry : sec.map.entrySet()) {
                 output.put(createPath(section, entry.getKey(), this), entry.getValue());
 
                 if (entry.getValue() instanceof ConfigurationSection) {
@@ -847,17 +829,17 @@ public class MemorySection implements ConfigurationSection {
                 }
             }
         } else {
-            final Map<String, Object> values = section.getValues(deep);
+            Map<String, Object> values = section.getValues(deep);
 
-            for (final Map.Entry<String, Object> entry : values.entrySet()) {
+            for (Map.Entry<String, Object> entry : values.entrySet()) {
                 output.put(createPath(section, entry.getKey(), this), entry.getValue());
             }
         }
     }
-    
+
     @Override
     public String toString() {
-        final Configuration root = getRoot();
+        Configuration root = getRoot();
         return getClass().getSimpleName() + "[path='" + getCurrentPath() + "', root='" + (root == null ? null : root.getClass().getSimpleName()) +
                 "']";
     }

Core/src/main/java/com/intellectualcrafters/configuration/file/FileConfiguration.java

@@ -26,7 +26,6 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      * Creates an empty {@link FileConfiguration} with no default values.
      */
     public FileConfiguration() {
-        super();
     }
     
     /**
@@ -35,7 +34,7 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *
      * @param defaults Default value provider
      */
-    public FileConfiguration(final Configuration defaults) {
+    public FileConfiguration(Configuration defaults) {
         super(defaults);
     }
     
@@ -54,13 +53,13 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *     any reason.
      * @throws IllegalArgumentException Thrown when file is null.
      */
-    public void save(final File file) throws IOException {
+    public void save(File file) throws IOException {
         if (file == null) {
             throw new NullPointerException("File cannot be null");
         }
         file.getParentFile().mkdirs();
-        
+
-        final String data = saveToString();
+        String data = saveToString();
 
         try (Writer writer = new OutputStreamWriter(new FileOutputStream(file), StandardCharsets.UTF_8)) {
             writer.write(data);
@@ -82,7 +81,7 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *     any reason.
      * @throws IllegalArgumentException Thrown when file is null.
      */
-    public void save(final String file) throws IOException {
+    public void save(String file) throws IOException {
         if (file == null) {
             throw new NullPointerException("File cannot be null");
         }
@@ -116,12 +115,12 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *     a valid Configuration.
      * @throws IllegalArgumentException Thrown when file is null.
      */
-    public void load(final File file) throws IOException, InvalidConfigurationException {
+    public void load(File file) throws IOException, InvalidConfigurationException {
         if (file == null) {
             throw new NullPointerException("File cannot be null");
         }
-        
+
-        final FileInputStream stream = new FileInputStream(file);
+        FileInputStream stream = new FileInputStream(file);
         
         load(new InputStreamReader(stream, StandardCharsets.UTF_8));
     }
@@ -139,9 +138,9 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *      represent a valid Configuration
      * @throws IllegalArgumentException thrown when reader is null
      */
-    public void load(final Reader reader) throws IOException, InvalidConfigurationException {
+    public void load(Reader reader) throws IOException, InvalidConfigurationException {
 
-        final StringBuilder builder = new StringBuilder();
+        StringBuilder builder = new StringBuilder();
 
         try (BufferedReader input = reader instanceof BufferedReader ? (BufferedReader) reader : new BufferedReader(reader)) {
             String line;
@@ -173,7 +172,7 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *     a valid Configuration.
      * @throws IllegalArgumentException Thrown when file is null.
      */
-    public void load(final String file) throws IOException, InvalidConfigurationException {
+    public void load(String file) throws IOException, InvalidConfigurationException {
         if (file == null) {
             throw new NullPointerException("File cannot be null");
         }
@@ -196,7 +195,7 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      *     invalid.
      * @throws IllegalArgumentException Thrown if contents is null.
      */
-    public abstract void loadFromString(final String contents) throws InvalidConfigurationException;
+    public abstract void loadFromString(String contents) throws InvalidConfigurationException;
     
     /**
      * Compiles the header for this {@link FileConfiguration} and returns the
@@ -212,10 +211,10 @@ public abstract class FileConfiguration extends MemoryConfiguration {
     
     @Override
     public FileConfigurationOptions options() {
-        if (options == null) {
+        if (this.options == null) {
-            options = new FileConfigurationOptions(this);
+            this.options = new FileConfigurationOptions(this);
         }
-        
+
-        return (FileConfigurationOptions) options;
+        return (FileConfigurationOptions) this.options;
     }
 }

Core/src/main/java/com/intellectualcrafters/configuration/file/YamlConfiguration.java

@@ -159,7 +159,7 @@ public class YamlConfiguration extends FileConfiguration {
         boolean readingHeader = true;
         boolean foundHeader = false;
 
-        for (int i = 0; (i < lines.length) && (readingHeader); i++) {
+        for (int i = 0; (i < lines.length) && readingHeader; i++) {
             final String line = lines[i];
 
             if (line.startsWith(COMMENT_PREFIX)) {
@@ -172,7 +172,7 @@ public class YamlConfiguration extends FileConfiguration {
                 }
 
                 foundHeader = true;
-            } else if ((foundHeader) && (line.isEmpty())) {
+            } else if (foundHeader && line.isEmpty()) {
                 result.append("\n");
             } else if (foundHeader) {
                 readingHeader = false;
@@ -189,11 +189,11 @@ public class YamlConfiguration extends FileConfiguration {
         if (options().copyHeader()) {
             final Configuration def = getDefaults();
 
-            if ((def != null) && (def instanceof FileConfiguration)) {
+            if (def != null && def instanceof FileConfiguration) {
                 final FileConfiguration filedefaults = (FileConfiguration) def;
                 final String defaultsHeader = filedefaults.buildHeader();
 
-                if ((defaultsHeader != null) && (!defaultsHeader.isEmpty())) {
+                if ((defaultsHeader != null) && !defaultsHeader.isEmpty()) {
                     return defaultsHeader;
                 }
             }
@@ -210,7 +210,7 @@ public class YamlConfiguration extends FileConfiguration {
         for (int i = lines.length - 1; i >= 0; i--) {
             builder.insert(0, "\n");
 
-            if ((startedHeader) || (!lines[i].isEmpty())) {
+            if (startedHeader || !lines[i].isEmpty()) {
                 builder.insert(0, lines[i]);
                 builder.insert(0, COMMENT_PREFIX);
                 startedHeader = true;

Core/src/main/java/com/intellectualcrafters/configuration/file/YamlRepresenter.java

@@ -1,37 +1,38 @@
 package com.intellectualcrafters.configuration.file;
 
-import java.util.LinkedHashMap;
-import java.util.Map;
-
-import org.yaml.snakeyaml.nodes.Node;
-import org.yaml.snakeyaml.representer.Representer;
-
 import com.intellectualcrafters.configuration.ConfigurationSection;
 import com.intellectualcrafters.configuration.serialization.ConfigurationSerializable;
 import com.intellectualcrafters.configuration.serialization.ConfigurationSerialization;
+import org.yaml.snakeyaml.nodes.Node;
+import org.yaml.snakeyaml.representer.Representer;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
 
 public class YamlRepresenter extends Representer {
-    
+
     public YamlRepresenter() {
-        multiRepresenters.put(ConfigurationSection.class, new RepresentConfigurationSection());
+        this.multiRepresenters.put(ConfigurationSection.class, new RepresentConfigurationSection());
-        multiRepresenters.put(ConfigurationSerializable.class, new RepresentConfigurationSerializable());
+        this.multiRepresenters.put(ConfigurationSerializable.class, new RepresentConfigurationSerializable());
     }
-    
+
     private class RepresentConfigurationSection extends RepresentMap {
+
         @Override
-        public Node representData(final Object data) {
+        public Node representData(Object data) {
             return super.representData(((ConfigurationSection) data).getValues(false));
         }
     }
-    
+
     private class RepresentConfigurationSerializable extends RepresentMap {
+
         @Override
-        public Node representData(final Object data) {
+        public Node representData(Object data) {
-            final ConfigurationSerializable serializable = (ConfigurationSerializable) data;
+            ConfigurationSerializable serializable = (ConfigurationSerializable) data;
-            final Map<String, Object> values = new LinkedHashMap<>();
+            Map<String, Object> values = new LinkedHashMap<>();
             values.put(ConfigurationSerialization.SERIALIZED_TYPE_KEY, ConfigurationSerialization.getAlias(serializable.getClass()));
             values.putAll(serializable.serialize());
-            
+
             return super.representData(values);
         }
     }

Core/src/main/java/com/intellectualcrafters/configuration/serialization/ConfigurationSerialization.java

@@ -15,73 +15,224 @@ import java.util.logging.Logger;
  * Utility class for storing and retrieving classes for {@link Configuration}.
  */
 public class ConfigurationSerialization {
+
     public static final String SERIALIZED_TYPE_KEY = "==";
+    private static final Map<String, Class<? extends ConfigurationSerializable>> aliases =
+            new HashMap<String, Class<? extends ConfigurationSerializable>>();
     private final Class<? extends ConfigurationSerializable> clazz;
-    private static Map<String, Class<? extends ConfigurationSerializable>> aliases = new HashMap<String, Class<? extends ConfigurationSerializable>>();
+
-    
+    protected ConfigurationSerialization(Class<? extends ConfigurationSerializable> clazz) {
-    protected ConfigurationSerialization(final Class<? extends ConfigurationSerializable> clazz) {
         this.clazz = clazz;
     }
-    
+
-    protected Method getMethod(final String name, final boolean isStatic) {
+    /**
+     * Attempts to deserialize the given arguments into a new instance of the
+     * given class.
+     *
+     * <p>The class must implement {@link ConfigurationSerializable}, including
+     * the extra methods as specified in the javadoc of
+     * ConfigurationSerializable.</p>
+     *
+     * <p>If a new instance could not be made, an example being the class not
+     * fully implementing the interface, null will be returned.</p>
+     *
+     * @param args Arguments for deserialization
+     * @param clazz Class to deserialize into
+     * @return New instance of the specified class
+     */
+    public static ConfigurationSerializable deserializeObject(Map<String, ?> args, Class<? extends ConfigurationSerializable> clazz) {
+        return new ConfigurationSerialization(clazz).deserialize(args);
+    }
+
+    /**
+     * Attempts to deserialize the given arguments into a new instance of the
+     *
+     * given class.
+     * <p>
+     * The class must implement {@link ConfigurationSerializable}, including
+     * the extra methods as specified in the javadoc of
+     * ConfigurationSerializable.</p>
+     *
+     * <p>
+     * If a new instance could not be made, an example being the class not
+     * fully implementing the interface, null will be returned.</p>
+     *
+     * @param args Arguments for deserialization
+     * @return New instance of the specified class
+     */
+    public static ConfigurationSerializable deserializeObject(Map<String, ?> args) {
+        Class<? extends ConfigurationSerializable> clazz = null;
+
+        if (args.containsKey(SERIALIZED_TYPE_KEY)) {
+            try {
+                String alias = (String) args.get(SERIALIZED_TYPE_KEY);
+
+                if (alias == null) {
+                    throw new IllegalArgumentException("Cannot have null alias");
+                }
+                clazz = getClassByAlias(alias);
+                if (clazz == null) {
+                    throw new IllegalArgumentException("Specified class does not exist ('" + alias + "')");
+                }
+            } catch (ClassCastException ex) {
+                ex.fillInStackTrace();
+                throw ex;
+            }
+        } else {
+            throw new IllegalArgumentException("Args doesn't contain type key ('" + SERIALIZED_TYPE_KEY + "')");
+        }
+
+        return new ConfigurationSerialization(clazz).deserialize(args);
+    }
+
+    /**
+     * Registers the given {@link ConfigurationSerializable} class by its
+     * alias.
+     *
+     * @param clazz Class to register
+     */
+    public static void registerClass(Class<? extends ConfigurationSerializable> clazz) {
+        DelegateDeserialization delegate = clazz.getAnnotation(DelegateDeserialization.class);
+
+        if (delegate == null) {
+            registerClass(clazz, getAlias(clazz));
+            registerClass(clazz, clazz.getName());
+        }
+    }
+
+    /**
+     * Registers the given alias to the specified {@link
+     * ConfigurationSerializable} class.
+     *
+     * @param clazz Class to register
+     * @param alias Alias to register as
+     * @see SerializableAs
+     */
+    public static void registerClass(Class<? extends ConfigurationSerializable> clazz, String alias) {
+        aliases.put(alias, clazz);
+    }
+
+    /**
+     * Unregisters the specified alias to a {@link ConfigurationSerializable}
+     *
+     * @param alias Alias to unregister
+     */
+    public static void unregisterClass(String alias) {
+        aliases.remove(alias);
+    }
+
+    /**
+     * Unregisters any aliases for the specified {@link
+     * ConfigurationSerializable} class.
+     *
+     * @param clazz Class to unregister
+     */
+    public static void unregisterClass(Class<? extends ConfigurationSerializable> clazz) {
+        while (aliases.values().remove(clazz)) {
+        }
+    }
+
+    /**
+     * Attempts to get a registered {@link ConfigurationSerializable} class by
+     * its alias.
+     *
+     * @param alias Alias of the serializable
+     * @return Registered class, or null if not found
+     */
+    public static Class<? extends ConfigurationSerializable> getClassByAlias(String alias) {
+        return aliases.get(alias);
+    }
+
+    /**
+     * Gets the correct alias for the given {@link ConfigurationSerializable}
+     * class.
+     *
+     * @param clazz Class to get alias for
+     * @return Alias to use for the class
+     */
+    public static String getAlias(Class<? extends ConfigurationSerializable> clazz) {
+        DelegateDeserialization delegate = clazz.getAnnotation(DelegateDeserialization.class);
+
+        if (delegate != null) {
+            if ((delegate.value() == null) || (delegate.value() == clazz)) {
+                delegate = null;
+            } else {
+                return getAlias(delegate.value());
+            }
+        }
+
+        SerializableAs alias = clazz.getAnnotation(SerializableAs.class);
+
+        if (alias != null) {
+            return alias.value();
+        }
+
+        return clazz.getName();
+    }
+
+    protected Method getMethod(String name, boolean isStatic) {
         try {
-            final Method method = clazz.getDeclaredMethod(name, Map.class);
+            Method method = this.clazz.getDeclaredMethod(name, Map.class);
-            
+
             if (!ConfigurationSerializable.class.isAssignableFrom(method.getReturnType())) {
                 return null;
             }
             if (Modifier.isStatic(method.getModifiers()) != isStatic) {
                 return null;
             }
-            
+
             return method;
-        } catch (final NoSuchMethodException ex) {
+        } catch (NoSuchMethodException ex) {
             return null;
-        } catch (final SecurityException ex) {
+        } catch (SecurityException ex) {
             return null;
         }
     }
-    
+
     protected Constructor<? extends ConfigurationSerializable> getConstructor() {
         try {
-            return clazz.getConstructor(Map.class);
+            return this.clazz.getConstructor(Map.class);
-        } catch (final NoSuchMethodException ex) {
+        } catch (NoSuchMethodException ex) {
             return null;
-        } catch (final SecurityException ex) {
+        } catch (SecurityException ex) {
             return null;
         }
     }
-    
+
-    protected ConfigurationSerializable deserializeViaMethod(final Method method, final Map<String, ?> args) {
+    protected ConfigurationSerializable deserializeViaMethod(Method method, Map<String, ?> args) {
         try {
-            final ConfigurationSerializable result = (ConfigurationSerializable) method.invoke(null, args);
+            ConfigurationSerializable result = (ConfigurationSerializable) method.invoke(null, args);
-            
+
             if (result == null) {
                 Logger.getLogger(ConfigurationSerialization.class.getName()).log(Level.SEVERE,
-                "Could not call method '" + method.toString() + "' of " + clazz + " for deserialization: method returned null");
+                        "Could not call method '" + method.toString() + "' of " + this.clazz + " for deserialization: method returned null");
             } else {
                 return result;
             }
-        } catch (final Throwable ex) {
+        } catch (Throwable ex) {
-            Logger.getLogger(ConfigurationSerialization.class.getName()).log(Level.SEVERE, "Could not call method '" + method.toString() + "' of " + clazz + " for deserialization",
+            Logger.getLogger(ConfigurationSerialization.class.getName())
-            ex instanceof InvocationTargetException ? ex.getCause() : ex);
+                    .log(Level.SEVERE, "Could not call method '" + method.toString() + "' of " + this.clazz
+                                    + " for deserialization",
+                            ex instanceof InvocationTargetException ? ex.getCause() : ex);
         }
-        
+
         return null;
     }
-    
+
-    protected ConfigurationSerializable deserializeViaCtor(final Constructor<? extends ConfigurationSerializable> ctor, final Map<String, ?> args) {
+    protected ConfigurationSerializable deserializeViaCtor(Constructor<? extends ConfigurationSerializable> ctor, Map<String, ?> args) {
         try {
             return ctor.newInstance(args);
-        } catch (final Throwable ex) {
+        } catch (Throwable ex) {
-            Logger.getLogger(ConfigurationSerialization.class.getName()).log(Level.SEVERE, "Could not call constructor '" + ctor.toString() + "' of " + clazz + " for deserialization",
+            Logger.getLogger(ConfigurationSerialization.class.getName())
-            ex instanceof InvocationTargetException ? ex.getCause() : ex);
+                    .log(Level.SEVERE, "Could not call constructor '" + ctor.toString() + "' of " + this.clazz
+                                    + " for deserialization",
+                            ex instanceof InvocationTargetException ? ex.getCause() : ex);
         }
-        
+
         return null;
     }
-    
+
-    public ConfigurationSerializable deserialize(final Map<String, ?> args) {
+    public ConfigurationSerializable deserialize(Map<String, ?> args) {
         if (args == null) {
             throw new NullPointerException("Args must not be null");
         }
@@ -94,162 +245,20 @@ public class ConfigurationSerialization {
 
         if (result == null) {
             method = getMethod("valueOf", true);
-            
+
             if (method != null) {
                 result = deserializeViaMethod(method, args);
             }
         }
-        
+
         if (result == null) {
-            final Constructor<? extends ConfigurationSerializable> constructor = getConstructor();
+            Constructor<? extends ConfigurationSerializable> constructor = getConstructor();
-            
+
             if (constructor != null) {
                 result = deserializeViaCtor(constructor, args);
             }
         }
-        
+
         return result;
     }
-    
-    /**
-     * Attempts to deserialize the given arguments into a new instance of the
-     * given class.
-     * <p>
-     * The class must implement {@link ConfigurationSerializable}, including
-     * the extra methods as specified in the javadoc of
-     * ConfigurationSerializable.
-     * <p>
-     * If a new instance could not be made, an example being the class not
-     * fully implementing the interface, null will be returned.
-     *
-     * @param args Arguments for deserialization
-     * @param clazz Class to deserialize into
-     * @return New instance of the specified class
-     */
-    public static ConfigurationSerializable deserializeObject(final Map<String, ?> args, final Class<? extends ConfigurationSerializable> clazz) {
-        return new ConfigurationSerialization(clazz).deserialize(args);
-    }
-    
-    /**
-     * Attempts to deserialize the given arguments into a new instance of the
-     * given class.
-     * <p>
-     * The class must implement {@link ConfigurationSerializable}, including
-     * the extra methods as specified in the javadoc of
-     * ConfigurationSerializable.
-     * <p>
-     * If a new instance could not be made, an example being the class not
-     * fully implementing the interface, null will be returned.
-     *
-     * @param args Arguments for deserialization
-     * @return New instance of the specified class
-     */
-    public static ConfigurationSerializable deserializeObject(final Map<String, ?> args) {
-        Class<? extends ConfigurationSerializable> clazz = null;
-        
-        if (args.containsKey(SERIALIZED_TYPE_KEY)) {
-            try {
-                final String alias = (String) args.get(SERIALIZED_TYPE_KEY);
-                
-                if (alias == null) {
-                    throw new IllegalArgumentException("Cannot have null alias");
-                }
-                clazz = getClassByAlias(alias);
-                if (clazz == null) {
-                    throw new IllegalArgumentException("Specified class does not exist ('" + alias + "')");
-                }
-            } catch (final ClassCastException ex) {
-                ex.fillInStackTrace();
-                throw ex;
-            }
-        } else {
-            throw new IllegalArgumentException("Args doesn't contain type key ('" + SERIALIZED_TYPE_KEY + "')");
-        }
-        
-        return new ConfigurationSerialization(clazz).deserialize(args);
-    }
-    
-    /**
-     * Registers the given {@link ConfigurationSerializable} class by its
-     * alias
-     *
-     * @param clazz Class to register
-     */
-    public static void registerClass(final Class<? extends ConfigurationSerializable> clazz) {
-        final DelegateDeserialization delegate = clazz.getAnnotation(DelegateDeserialization.class);
-        
-        if (delegate == null) {
-            registerClass(clazz, getAlias(clazz));
-            registerClass(clazz, clazz.getName());
-        }
-    }
-    
-    /**
-     * Registers the given alias to the specified {@link
-     * ConfigurationSerializable} class
-     *
-     * @param clazz Class to register
-     * @param alias Alias to register as
-     * @see SerializableAs
-     */
-    public static void registerClass(final Class<? extends ConfigurationSerializable> clazz, final String alias) {
-        aliases.put(alias, clazz);
-    }
-    
-    /**
-     * Unregisters the specified alias to a {@link ConfigurationSerializable}
-     *
-     * @param alias Alias to unregister
-     */
-    public static void unregisterClass(final String alias) {
-        aliases.remove(alias);
-    }
-    
-    /**
-     * Unregisters any aliases for the specified {@link
-     * ConfigurationSerializable} class
-     *
-     * @param clazz Class to unregister
-     */
-    public static void unregisterClass(final Class<? extends ConfigurationSerializable> clazz) {
-        while (aliases.values().remove(clazz)) {}
-    }
-    
-    /**
-     * Attempts to get a registered {@link ConfigurationSerializable} class by
-     * its alias
-     *
-     * @param alias Alias of the serializable
-     * @return Registered class, or null if not found
-     */
-    public static Class<? extends ConfigurationSerializable> getClassByAlias(final String alias) {
-        return aliases.get(alias);
-    }
-    
-    /**
-     * Gets the correct alias for the given {@link ConfigurationSerializable}
-     * class
-     *
-     * @param clazz Class to get alias for
-     * @return Alias to use for the class
-     */
-    public static String getAlias(final Class<? extends ConfigurationSerializable> clazz) {
-        DelegateDeserialization delegate = clazz.getAnnotation(DelegateDeserialization.class);
-        
-        if (delegate != null) {
-            if ((delegate.value() == null) || (delegate.value() == clazz)) {
-                delegate = null;
-            } else {
-                return getAlias(delegate.value());
-            }
-        }
-
-        final SerializableAs alias = clazz.getAnnotation(SerializableAs.class);
-
-        if (alias != null) {
-            return alias.value();
-        }
-
-        return clazz.getName();
-    }
 }

Core/src/main/java/com/intellectualcrafters/jnbt/ByteArrayTag.java

@@ -4,47 +4,47 @@ package com.intellectualcrafters.jnbt;
  * The {@code TAG_Byte_Array} tag.
  */
 public final class ByteArrayTag extends Tag {
+
     private final byte[] value;
-    
+
     /**
      * Creates the tag with an empty name.
      *
      * @param value the value of the tag
      */
-    public ByteArrayTag(final byte[] value) {
+    public ByteArrayTag(byte[] value) {
-        super();
         this.value = value;
     }
-    
+
     /**
      * Creates the tag.
      *
      * @param name  the name of the tag
      * @param value the value of the tag
      */
-    public ByteArrayTag(final String name, final byte[] value) {
+    public ByteArrayTag(String name, byte[] value) {
         super(name);
         this.value = value;
     }
-    
+
     @Override
     public byte[] getValue() {
-        return value;
+        return this.value;
     }
-    
+
     @Override
     public String toString() {
-        final StringBuilder hex = new StringBuilder();
+        StringBuilder hex = new StringBuilder();
-        for (final byte b : value) {
+        for (byte b : this.value) {
-            final String hexDigits = Integer.toHexString(b).toUpperCase();
+            String hexDigits = Integer.toHexString(b).toUpperCase();
             if (hexDigits.length() == 1) {
                 hex.append("0");
             }
             hex.append(hexDigits).append(" ");
         }
-        final String name = getName();
+        String name = getName();
         String append = "";
-        if ((name != null) && !name.equals("")) {
+        if (name != null && !name.equals("")) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Byte_Array" + append + ": " + hex;

Core/src/main/java/com/intellectualcrafters/jnbt/ByteTag.java

@@ -4,41 +4,41 @@ package com.intellectualcrafters.jnbt;
  * The {@code TAG_Byte} tag.
  */
 public final class ByteTag extends Tag {
+
     private final byte value;
-    
+
     /**
      * Creates the tag with an empty name.
      *
      * @param value the value of the tag
      */
-    public ByteTag(final byte value) {
+    public ByteTag(byte value) {
-        super();
         this.value = value;
     }
-    
+
     /**
      * Creates the tag.
      *
      * @param name  the name of the tag
      * @param value the value of the tag
      */
-    public ByteTag(final String name, final byte value) {
+    public ByteTag(String name, byte value) {
         super(name);
         this.value = value;
     }
-    
+
     @Override
     public Byte getValue() {
-        return value;
+        return this.value;
     }
-    
+
     @Override
     public String toString() {
-        final String name = getName();
+        String name = getName();
         String append = "";
-        if ((name != null) && !name.equals("")) {
+        if (name != null && !name.equals("")) {
             append = "(\"" + getName() + "\")";
         }
-        return "TAG_Byte" + append + ": " + value;
+        return "TAG_Byte" + append + ": " + this.value;
     }
 }

Core/src/main/java/com/intellectualcrafters/jnbt/CompoundTag.java

@@ -9,29 +9,29 @@ import java.util.Map;
  * The {@code TAG_Compound} tag.
  */
 public final class CompoundTag extends Tag {
+
     private Map<String, Tag> value;
-    
+
     /**
      * Creates the tag with an empty name.
      *
      * @param value the value of the tag
      */
-    public CompoundTag(final Map<String, Tag> value) {
+    public CompoundTag(Map<String, Tag> value) {
-        super();
         this.value = Collections.unmodifiableMap(value);
     }
-    
+
     /**
      * Creates the tag.
      *
      * @param name  the name of the tag
      * @param value the value of the tag
      */
-    public CompoundTag(final String name, final Map<String, Tag> value) {
+    public CompoundTag(String name, Map<String, Tag> value) {
         super(name);
         this.value = Collections.unmodifiableMap(value);
     }
-    
+
     /**
      * Returns whether this compound tag contains the given key.
      *
@@ -39,15 +39,15 @@ public final class CompoundTag extends Tag {
      *
      * @return true if the tag contains the given key
      */
-    public boolean containsKey(final String key) {
+    public boolean containsKey(String key) {
-        return value.containsKey(key);
+        return this.value.containsKey(key);
     }
-    
+
     @Override
     public Map<String, Tag> getValue() {
-        return value;
+        return this.value;
     }
-    
+
     /**
      * Return a new compound tag with the given values.
      *
@@ -55,42 +55,43 @@ public final class CompoundTag extends Tag {
      *
      * @return the new compound tag
      */
-    public CompoundTag setValue(final Map<String, Tag> value) {
+    public CompoundTag setValue(Map<String, Tag> value) {
         if (value == null) {
             this.value = Collections.unmodifiableMap(new HashMap<String, Tag>());
-        }
+        } else {
-        else {
             this.value = Collections.unmodifiableMap(value);
         }
         return this;
     }
-    
+
     /**
      * Create a compound tag builder.
      *
      * @return the builder
      */
     public CompoundTagBuilder createBuilder() {
-        return new CompoundTagBuilder(new HashMap<String, Tag>(value));
+        return new CompoundTagBuilder(new HashMap<String, Tag>(this.value));
     }
-    
+
     /**
-     * Get a byte array named with the given key. <p> If the key does not exist or its value is not a byte array
+     * Get a byte array named with the given key.
+     *
+     * <p> If the key does not exist or its value is not a byte array
      * tag, then an empty byte array will be returned. </p>
      *
      * @param key the key
      *
      * @return a byte array
      */
-    public byte[] getByteArray(final String key) {
+    public byte[] getByteArray(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ByteArrayTag) {
             return ((ByteArrayTag) tag).getValue();
         } else {
             return new byte[0];
         }
     }
-    
+
     /**
      * Get a byte named with the given key.  <p> If the key does not exist or its value is not a byte tag, then
      * {@code 0} will be returned. </p>
@@ -99,15 +100,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a byte
      */
-    public byte getByte(final String key) {
+    public byte getByte(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ByteTag) {
             return ((ByteTag) tag).getValue();
         } else {
             return (byte) 0;
         }
     }
-    
+
     /**
      * Get a double named with the given key. <p> If the key does not exist or its value is not a double tag, then
      * {@code 0} will be returned. </p>
@@ -116,15 +117,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a double
      */
-    public double getDouble(final String key) {
+    public double getDouble(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof DoubleTag) {
             return ((DoubleTag) tag).getValue();
         } else {
             return 0;
         }
     }
-    
+
     /**
      * Get a double named with the given key, even if it's another type of number. <p> If the key does not exist or
      * its value is not a number, then {@code 0} will be returned. </p>
@@ -133,8 +134,8 @@ public final class CompoundTag extends Tag {
      *
      * @return a double
      */
-    public double asDouble(final String key) {
+    public double asDouble(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ByteTag) {
             return ((ByteTag) tag).getValue();
         } else if (tag instanceof ShortTag) {
@@ -151,7 +152,7 @@ public final class CompoundTag extends Tag {
             return 0;
         }
     }
-    
+
     /**
      * Get a float named with the given key.  <p> If the key does not exist or its value is not a float tag, then
      * {@code 0} will be returned. </p>
@@ -160,15 +161,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a float
      */
-    public float getFloat(final String key) {
+    public float getFloat(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof FloatTag) {
             return ((FloatTag) tag).getValue();
         } else {
             return 0;
         }
     }
-    
+
     /**
      * Get a {@code int[]} named with the given key.  <p> If the key does not exist or its value is not an int array
      * tag, then an empty array will be returned. </p>
@@ -177,15 +178,15 @@ public final class CompoundTag extends Tag {
      *
      * @return an int array
      */
-    public int[] getIntArray(final String key) {
+    public int[] getIntArray(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof IntArrayTag) {
             return ((IntArrayTag) tag).getValue();
         } else {
             return new int[0];
         }
     }
-    
+
     /**
      * Get an int named with the given key.  <p> If the key does not exist or its value is not an int tag, then
      * {@code 0} will be returned. </p>
@@ -194,15 +195,15 @@ public final class CompoundTag extends Tag {
      *
      * @return an int
      */
-    public int getInt(final String key) {
+    public int getInt(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof IntTag) {
             return ((IntTag) tag).getValue();
         } else {
             return 0;
         }
     }
-    
+
     /**
      * Get an int named with the given key, even if it's another type of number.  <p> If the key does not exist or
      * its value is not a number, then {@code 0} will be returned. </p>
@@ -211,8 +212,8 @@ public final class CompoundTag extends Tag {
      *
      * @return an int
      */
-    public int asInt(final String key) {
+    public int asInt(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ByteTag) {
             return ((ByteTag) tag).getValue();
         } else if (tag instanceof ShortTag) {
@@ -229,7 +230,7 @@ public final class CompoundTag extends Tag {
             return 0;
         }
     }
-    
+
     /**
      * Get a list of tags named with the given key.  <p> If the key does not exist or its value is not a list tag,
      * then an empty list will be returned. </p>
@@ -238,15 +239,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a list of tags
      */
-    public List<Tag> getList(final String key) {
+    public List<Tag> getList(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ListTag) {
             return ((ListTag) tag).getValue();
         } else {
             return Collections.emptyList();
         }
     }
-    
+
     /**
      * Get a {@code TagList} named with the given key.  <p> If the key does not exist or its value is not a list
      * tag, then an empty tag list will be returned. </p>
@@ -255,15 +256,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a tag list instance
      */
-    public ListTag getListTag(final String key) {
+    public ListTag getListTag(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ListTag) {
             return (ListTag) tag;
         } else {
-            return new ListTag(key, StringTag.class, Collections.<Tag> emptyList());
+            return new ListTag(key, StringTag.class, Collections.<Tag>emptyList());
         }
     }
-    
+
     /**
      * Get a list of tags named with the given key.  <p> If the key does not exist or its value is not a list tag,
      * then an empty list will be returned. If the given key references a list but the list of of a different type, then
@@ -276,10 +277,10 @@ public final class CompoundTag extends Tag {
      * @return a list of tags
      */
     @SuppressWarnings("unchecked")
-    public <T extends Tag> List<T> getList(final String key, final Class<T> listType) {
+    public <T extends Tag> List<T> getList(String key, Class<T> listType) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ListTag) {
-            final ListTag listTag = (ListTag) tag;
+            ListTag listTag = (ListTag) tag;
             if (listTag.getType().equals(listType)) {
                 return (List<T>) listTag.getValue();
             } else {
@@ -289,7 +290,7 @@ public final class CompoundTag extends Tag {
             return Collections.emptyList();
         }
     }
-    
+
     /**
      * Get a long named with the given key.  <p> If the key does not exist or its value is not a long tag, then
      * {@code 0} will be returned. </p>
@@ -298,15 +299,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a long
      */
-    public long getLong(final String key) {
+    public long getLong(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof LongTag) {
             return ((LongTag) tag).getValue();
         } else {
             return 0L;
         }
     }
-    
+
     /**
      * Get a long named with the given key, even if it's another type of number.  <p> If the key does not exist or
      * its value is not a number, then {@code 0} will be returned. </p>
@@ -315,8 +316,8 @@ public final class CompoundTag extends Tag {
      *
      * @return a long
      */
-    public long asLong(final String key) {
+    public long asLong(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ByteTag) {
             return ((ByteTag) tag).getValue();
         } else if (tag instanceof ShortTag) {
@@ -333,7 +334,7 @@ public final class CompoundTag extends Tag {
             return 0L;
         }
     }
-    
+
     /**
      * Get a short named with the given key.  <p> If the key does not exist or its value is not a short tag, then
      * {@code 0} will be returned. </p>
@@ -342,15 +343,15 @@ public final class CompoundTag extends Tag {
      *
      * @return a short
      */
-    public short getShort(final String key) {
+    public short getShort(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof ShortTag) {
             return ((ShortTag) tag).getValue();
         } else {
             return 0;
         }
     }
-    
+
     /**
      * Get a string named with the given key.  <p> If the key does not exist or its value is not a string tag, then
      * {@code ""} will be returned. </p>
@@ -359,25 +360,25 @@ public final class CompoundTag extends Tag {
      *
      * @return a string
      */
-    public String getString(final String key) {
+    public String getString(String key) {
-        final Tag tag = value.get(key);
+        Tag tag = this.value.get(key);
         if (tag instanceof StringTag) {
             return ((StringTag) tag).getValue();
         } else {
             return "";
         }
     }
-    
+
     @Override
     public String toString() {
-        final String name = getName();
+        String name = getName();
         String append = "";
-        if ((name != null) && !name.equals("")) {
+        if (name != null && !name.equals("")) {
             append = "(\"" + getName() + "\")";
         }
-        final StringBuilder bldr = new StringBuilder();
+        StringBuilder bldr = new StringBuilder();
-        bldr.append("TAG_Compound").append(append).append(": ").append(value.size()).append(" entries\r\n{\r\n");
+        bldr.append("TAG_Compound").append(append).append(": ").append(this.value.size()).append(" entries\r\n{\r\n");
-        for (final Map.Entry<String, Tag> entry : value.entrySet()) {
+        for (Map.Entry<String, Tag> entry : this.value.entrySet()) {
             bldr.append("   ").append(entry.getValue().toString().replaceAll("\r\n", "\r\n   ")).append("\r\n");
         }
         bldr.append("}");

Core/src/main/java/com/intellectualcrafters/jnbt/CompoundTagBuilder.java

@@ -9,25 +9,26 @@ import java.util.Map;
  * Helps create compound tags.
  */
 public class CompoundTagBuilder {
+
     private final Map<String, Tag> entries;
-    
+
     /**
      * Create a new instance.
      */
     CompoundTagBuilder() {
-        entries = new HashMap<String, Tag>();
+        this.entries = new HashMap<String, Tag>();
     }
-    
+
     /**
      * Create a new instance and use the given map (which will be modified).
      *
      * @param value the value
      */
-    CompoundTagBuilder(final Map<String, Tag> value) {
+    CompoundTagBuilder(Map<String, Tag> value) {
         checkNotNull(value);
-        entries = value;
+        this.entries = value;
     }
-    
+
     /**
      * Create a new builder instance.
      *
@@ -36,7 +37,7 @@ public class CompoundTagBuilder {
     public static CompoundTagBuilder create() {
         return new CompoundTagBuilder();
     }
-    
+
     /**
      * Put the given key and tag into the compound tag.
      *
@@ -45,13 +46,13 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder put(final String key, final Tag value) {
+    public CompoundTagBuilder put(String key, Tag value) {
         checkNotNull(key);
         checkNotNull(value);
-        entries.put(key, value);
+        this.entries.put(key, value);
         return this;
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code ByteArrayTag}.
      *
@@ -60,10 +61,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putByteArray(final String key, final byte[] value) {
+    public CompoundTagBuilder putByteArray(String key, byte[] value) {
         return put(key, new ByteArrayTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code ByteTag}.
      *
@@ -72,10 +73,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putByte(final String key, final byte value) {
+    public CompoundTagBuilder putByte(String key, byte value) {
         return put(key, new ByteTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code DoubleTag}.
      *
@@ -84,10 +85,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putDouble(final String key, final double value) {
+    public CompoundTagBuilder putDouble(String key, double value) {
         return put(key, new DoubleTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code FloatTag}.
      *
@@ -96,10 +97,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putFloat(final String key, final float value) {
+    public CompoundTagBuilder putFloat(String key, float value) {
         return put(key, new FloatTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code IntArrayTag}.
      *
@@ -108,10 +109,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putIntArray(final String key, final int[] value) {
+    public CompoundTagBuilder putIntArray(String key, int[] value) {
         return put(key, new IntArrayTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as an {@code IntTag}.
      *
@@ -120,10 +121,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putInt(final String key, final int value) {
+    public CompoundTagBuilder putInt(String key, int value) {
         return put(key, new IntTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code LongTag}.
      *
@@ -132,10 +133,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putLong(final String key, final long value) {
+    public CompoundTagBuilder putLong(String key, long value) {
         return put(key, new LongTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code ShortTag}.
      *
@@ -144,10 +145,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putShort(final String key, final short value) {
+    public CompoundTagBuilder putShort(String key, short value) {
         return put(key, new ShortTag(key, value));
     }
-    
+
     /**
      * Put the given key and value into the compound tag as a {@code StringTag}.
      *
@@ -156,10 +157,10 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putString(final String key, final String value) {
+    public CompoundTagBuilder putString(String key, String value) {
         return put(key, new StringTag(key, value));
     }
-    
+
     /**
      * Put all the entries from the given map into this map.
      *
@@ -167,23 +168,23 @@ public class CompoundTagBuilder {
      *
      * @return this object
      */
-    public CompoundTagBuilder putAll(final Map<String, ? extends Tag> value) {
+    public CompoundTagBuilder putAll(Map<String, ? extends Tag> value) {
         checkNotNull(value);
-        for (final Map.Entry<String, ? extends Tag> entry : value.entrySet()) {
+        for (Map.Entry<String, ? extends Tag> entry : value.entrySet()) {
             put(entry.getKey(), entry.getValue());
         }
         return this;
     }
-    
+
     /**
      * Build an unnamed compound tag with this builder's entries.
      *
      * @return the new compound tag
      */
     public CompoundTag build() {
-        return new CompoundTag(new HashMap<String, Tag>(entries));
+        return new CompoundTag(new HashMap<String, Tag>(this.entries));
     }
-    
+
     /**
      * Build a new compound tag with this builder's entries.
      *
@@ -191,7 +192,7 @@ public class CompoundTagBuilder {
      *
      * @return the created compound tag
      */
-    public CompoundTag build(final String name) {
+    public CompoundTag build(String name) {
-        return new CompoundTag(name, new HashMap<String, Tag>(entries));
+        return new CompoundTag(name, new HashMap<String, Tag>(this.entries));
     }
 }

Core/src/main/java/com/intellectualcrafters/jnbt/DoubleTag.java

@@ -4,41 +4,41 @@ package com.intellectualcrafters.jnbt;
  * The {@code TAG_Double} tag.
  */
 public final class DoubleTag extends Tag {
+
     private final double value;
-    
+
     /**
      * Creates the tag with an empty name.
      *
      * @param value the value of the tag
      */
-    public DoubleTag(final double value) {
+    public DoubleTag(double value) {
-        super();
         this.value = value;
     }
-    
+
     /**
      * Creates the tag.
      *
      * @param name  the name of the tag
      * @param value the value of the tag
      */
-    public DoubleTag(final String name, final double value) {
+    public DoubleTag(String name, double value) {
         super(name);
         this.value = value;
     }
-    
+
     @Override
     public Double getValue() {
-        return value;
+        return this.value;
     }
-    
+
     @Override
     public String toString() {
-        final String name = getName();
+        String name = getName();
         String append = "";
-        if ((name != null) && !name.equals("")) {
+        if (name != null && !name.equals("")) {
             append = "(\"" + getName() + "\")";
         }
-        return "TAG_Double" + append + ": " + value;
+        return "TAG_Double" + append + ": " + this.value;
     }
 }

Core/src/main/java/com/intellectualcrafters/jnbt/EndTag.java

@@ -4,18 +4,18 @@ package com.intellectualcrafters.jnbt;
  * The {@code TAG_End} tag.
  */
 public final class EndTag extends Tag {
+
     /**
      * Creates the tag.
      */
     public EndTag() {
-        super();
     }
-    
+
     @Override
     public Object getValue() {
         return null;
     }
-    
+
     @Override
     public String toString() {
         return "TAG_End";