Merge branch 'master' of https://github.com/IntellectualSites/PlotSquared

# Conflicts:

#	Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlayerEvents.java

#	Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_9.java

Bukkit/src/main/java/com/intellectualcrafters/plot/api/PlotAPI.java

@@ -54,8 +54,7 @@ public class PlotAPI {
      * @deprecated Not needed
      */
     @Deprecated
-    public PlotAPI(JavaPlugin plugin) {
-    }
+    public PlotAPI(JavaPlugin plugin) {}
 
     /**
      * Get all plots.

Bukkit/src/main/java/com/plotsquared/bukkit/BukkitMain.java

@@ -141,9 +141,7 @@ public final class BukkitMain extends JavaPlugin implements Listener, IPlotMain
             }
             this.getServer().getConsoleSender().sendMessage(message);
             return;
-        } catch (Throwable ignored) {
-            //ignored
-        }
+        } catch (Throwable ignored) {}
         System.out.println(ConsoleColors.fromString(message));
     }
 
@@ -401,14 +399,14 @@ public final class BukkitMain extends JavaPlugin implements Listener, IPlotMain
         try {
             new SendChunk();
             MainUtil.canSendChunk = true;
-        } catch (Throwable e) {
+        } catch (ClassNotFoundException | NoSuchFieldException | NoSuchMethodException e) {
             e.printStackTrace();
             MainUtil.canSendChunk = false;
         }
         if (PS.get().checkVersion(getServerVersion(), 1, 9, 0)) {
             try {
                 return new FastQueue_1_9();
-            } catch (Throwable e) {
+            } catch (ClassNotFoundException | NoSuchFieldException | NoSuchMethodException e) {
                 e.printStackTrace();
                 return new SlowQueue();
             }
@@ -416,11 +414,11 @@ public final class BukkitMain extends JavaPlugin implements Listener, IPlotMain
         if (PS.get().checkVersion(getServerVersion(), 1, 8, 0)) {
             try {
                 return new FastQueue_1_8_3();
-            } catch (Throwable e) {
+            } catch (NoSuchMethodException | ClassNotFoundException | NoSuchFieldException e) {
                 e.printStackTrace();
                 try {
                     return new FastQueue_1_8();
-                } catch (Throwable e2) {
+                } catch (NoSuchMethodException | NoSuchFieldException | ClassNotFoundException e2) {
                     e2.printStackTrace();
                     return new SlowQueue();
                 }
@@ -428,7 +426,7 @@ public final class BukkitMain extends JavaPlugin implements Listener, IPlotMain
         }
         try {
             return new FastQueue_1_7();
-        } catch (Throwable e) {
+        } catch (ClassNotFoundException | NoSuchFieldException | NoSuchMethodException e) {
             e.printStackTrace();
             return new SlowQueue();
         }
@@ -620,11 +618,14 @@ public final class BukkitMain extends JavaPlugin implements Listener, IPlotMain
     public PlotPlayer wrapPlayer(Object player) {
         if (player instanceof Player) {
             return BukkitUtil.getPlayer((Player) player);
-        } else if (player instanceof OfflinePlayer) {
+        }
+        if (player instanceof OfflinePlayer) {
             return BukkitUtil.getPlayer((OfflinePlayer) player);
-        } else if (player instanceof String) {
+        }
+        if (player instanceof String) {
             return UUIDHandler.getPlayer((String) player);
-        } else if (player instanceof UUID) {
+        }
+        if (player instanceof UUID) {
             return UUIDHandler.getPlayer((UUID) player);
         }
         return null;
@@ -654,7 +655,7 @@ public final class BukkitMain extends JavaPlugin implements Listener, IPlotMain
     public List<String> getPluginIds() {
         ArrayList<String> names = new ArrayList<>();
         for (Plugin plugin : Bukkit.getPluginManager().getPlugins()) {
-            names.add(plugin.getName() + ";" + plugin.getDescription().getVersion() + ":" + plugin.isEnabled());
+            names.add(plugin.getName() + ';' + plugin.getDescription().getVersion() + ':' + plugin.isEnabled());
         }
         return names;
     }

Bukkit/src/main/java/com/plotsquared/bukkit/chat/TextualComponent.java

@@ -192,7 +192,7 @@ public abstract class TextualComponent implements Cloneable {
         }
 
         @Override
-        public TextualComponent clone() throws CloneNotSupportedException {
+        public TextualComponent clone() {
             // Since this is a private and final class, we can just reinstantiate this class instead of casting super.clone
             return new ArbitraryTextTypeComponent(getKey(), getValue());
         }
@@ -266,7 +266,7 @@ public abstract class TextualComponent implements Cloneable {
         }
 
         @Override
-        public TextualComponent clone() throws CloneNotSupportedException {
+        public TextualComponent clone() {
             // Since this is a private and final class, we can just reinstantiate this class instead of casting super.clone
             return new ComplexTextTypeComponent(getKey(), getValue());
         }

Bukkit/src/main/java/com/plotsquared/bukkit/commands/DebugUUID.java

@@ -285,7 +285,7 @@ public class DebugUUID extends SubCommand {
                 }
                 try {
                     PS.get().config.save(PS.get().configFile);
-                } catch (IOException e) {
+                } catch (IOException ignored) {
                     MainUtil.sendMessage(player, "Could not save configuration. It will need to be manual set!");
                 }
 

Bukkit/src/main/java/com/plotsquared/bukkit/database/plotme/ClassicPlotMeConnector.java

@@ -42,9 +42,8 @@ public class ClassicPlotMeConnector extends APlotMeConnector {
             } else {
                 return new SQLite(dataFolder + File.separator + "plots.db").openConnection();
             }
-        } catch (SQLException | ClassNotFoundException ignored) {
-            //ignored
-            ignored.printStackTrace();
+        } catch (SQLException | ClassNotFoundException e) {
+            e.printStackTrace();
         }
         return null;
     }
@@ -229,9 +228,7 @@ public class ClassicPlotMeConnector extends APlotMeConnector {
             resultSet.close();
             statement.close();
 
-        } catch (SQLException ignored) {
-            //ignored
-        }
+        } catch (SQLException ignored) {}
         return plots;
     }
 

Bukkit/src/main/java/com/plotsquared/bukkit/database/plotme/LikePlotMeConverter.java

@@ -200,9 +200,7 @@ public class LikePlotMeConverter {
                         PS.get().config.set("worlds." + actualWorldName + ".wall.height", height);
                         PS.get().config.save(PS.get().configFile);
                     }
-                } catch (IOException ignored) {
-                    //ignored
-                }
+                } catch (IOException ignored) {}
             }
             for (Entry<String, HashMap<PlotId, Plot>> entry : plots.entrySet()) {
                 String world = entry.getKey();
@@ -264,7 +262,7 @@ public class LikePlotMeConverter {
             sendMessage("Saving configuration...");
             try {
                 PS.get().config.save(PS.get().configFile);
-            } catch (IOException e) {
+            } catch (IOException ignored) {
                 sendMessage(" - &cFailed to save configuration.");
             }
             TaskManager.runTask(new Runnable() {
@@ -293,7 +291,7 @@ public class LikePlotMeConverter {
                                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mv unload " + actualWorldName);
                                 try {
                                     Thread.sleep(1000);
-                                } catch (InterruptedException ex) {
+                                } catch (InterruptedException ignored) {
                                     Thread.currentThread().interrupt();
                                 }
                                 // load world with MV
@@ -304,7 +302,7 @@ public class LikePlotMeConverter {
                                 Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mw unload " + actualWorldName);
                                 try {
                                     Thread.sleep(1000);
-                                } catch (InterruptedException ex) {
+                                } catch (InterruptedException ignored) {
                                     Thread.currentThread().interrupt();
                                 }
                                 // load world with MW

Bukkit/src/main/java/com/plotsquared/bukkit/generator/BukkitPlotGenerator.java

@@ -233,7 +233,7 @@ public class BukkitPlotGenerator extends ChunkGenerator implements GeneratorWrap
         } catch (Exception e) {
             e.printStackTrace();
         }
-        ArrayList<BlockPopulator> toAdd = new ArrayList<BlockPopulator>();
+        ArrayList<BlockPopulator> toAdd = new ArrayList<>();
         List<BlockPopulator> existing = world.getPopulators();
         for (BlockPopulator populator : this.populators) {
             if (!existing.contains(populator)) {

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlayerEvents.java

@@ -320,7 +320,8 @@ public class PlayerEvents extends PlotListener implements Listener {
             }
             entity.remove();
             return false;
-        } else if (!(shooter instanceof Entity) && shooter != null) {
+        }
+        if (!(shooter instanceof Entity) && shooter != null) {
             if (plot == null) {
                 entity.remove();
                 return false;
@@ -372,7 +373,7 @@ public class PlayerEvents extends PlotListener implements Listener {
             String c = parts[0];
             if (parts[0].contains(":")) {
                 c = parts[0].split(":")[1];
-                msg = msg.replace(parts[0].split(":")[0] + ":", "");
+                msg = msg.replace(parts[0].split(":")[0] + ':', "");
             }
             String l = c;
             List<String> aliases = new ArrayList<>();
@@ -511,7 +512,8 @@ public class PlayerEvents extends PlotListener implements Listener {
                 player.teleport(event.getTo());
                 MainUtil.sendMessage(pp, C.BORDER);
                 return;
-            } else if (x2 < -border) {
+            }
+            if (x2 < -border) {
                 to.setX(-border + 4);
                 player.teleport(event.getTo());
                 MainUtil.sendMessage(pp, C.BORDER);
@@ -631,7 +633,8 @@ public class PlayerEvents extends PlotListener implements Listener {
                 MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, C.PERMISSION_ADMIN_DESTROY_UNOWNED);
                 event.setCancelled(true);
                 return;
-            } else if (!plot.isAdded(pp.getUUID())) {
+            }
+            if (!plot.isAdded(pp.getUUID())) {
                 Optional<HashSet<PlotBlock>> destroy = plot.getFlag(Flags.BREAK);
                 Block block = event.getBlock();
                 if (destroy.isPresent() && destroy.get()
@@ -778,6 +781,7 @@ public class PlayerEvents extends PlotListener implements Listener {
             return;
         }
         Plot plot = area.getOwnedPlot(location);
+        Optional<Boolean> flag;
         switch (block.getType()) {
             case GRASS:
                 if (Flags.GRASS_GROW.isFalse(plot)) {
@@ -829,10 +833,8 @@ public class PlayerEvents extends PlotListener implements Listener {
             if (!plot.isAdded(pp.getUUID())) {
                 Optional<HashSet<PlotBlock>> destroy = plot.getFlag(Flags.BREAK);
                 Block block = event.getBlock();
-                if (destroy.isPresent() && destroy.get().contains(new PlotBlock((short) block.getTypeId(), block.getData()))) {
-                    return;
-                }
-                if (Permissions.hasPermission(pp, C.PERMISSION_ADMIN_DESTROY_OTHER)) {
+                if (destroy.isPresent() && destroy.get().contains(new PlotBlock((short) block.getTypeId(), block.getData())) || Permissions
+                        .hasPermission(pp, C.PERMISSION_ADMIN_DESTROY_OTHER)) {
                     return;
                 }
                 event.setCancelled(true);
@@ -848,8 +850,8 @@ public class PlayerEvents extends PlotListener implements Listener {
     }
 
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onFade(BlockFadeEvent e) {
-        Block b = e.getBlock();
+    public void onFade(BlockFadeEvent event) {
+        Block b = event.getBlock();
         Location location = BukkitUtil.getLocation(b.getLocation());
         PlotArea area = location.getPlotArea();
         if (area == null) {
@@ -857,23 +859,23 @@ public class PlayerEvents extends PlotListener implements Listener {
         }
         Plot plot = area.getOwnedPlot(location);
         if (plot == null) {
-            e.setCancelled(true);
+            event.setCancelled(true);
             return;
         }
         switch (b.getType()) {
             case ICE:
                 if (Flags.ICE_MELT.isFalse(plot)) {
-                    e.setCancelled(true);
+                    event.setCancelled(true);
                 }
                 break;
             case SNOW:
                 if (Flags.SNOW_MELT.isFalse(plot)) {
-                    e.setCancelled(true);
+                    event.setCancelled(true);
                 }
                 break;
             case SOIL:
                 if (Flags.SOIL_DRY.isFalse(plot)) {
-                    e.setCancelled(true);
+                    event.setCancelled(true);
                 }
                 break;
         }
@@ -891,7 +893,7 @@ public class PlayerEvents extends PlotListener implements Listener {
         Plot plot = area.getOwnedPlot(tLocation);
         Location fLocation = BukkitUtil.getLocation(from.getLocation());
         if (plot != null) {
-            if (plot.getFlag(Flags.DISABLE_PHYSICS, false)) {
+            if (Flags.DISABLE_PHYSICS.isFalse(plot)) {
                 event.setCancelled(true);
             } else if (!area.contains(fLocation.getX(), fLocation.getZ()) || !Objects.equals(plot, area.getOwnedPlot(fLocation))) {
                 event.setCancelled(true);
@@ -966,7 +968,7 @@ public class PlayerEvents extends PlotListener implements Listener {
                             return;
                         }
                     }
-                } catch (Throwable e) {
+                } catch (Throwable ignored) {
                     this.pistonBlocks = false;
                 }
             }
@@ -995,7 +997,7 @@ public class PlayerEvents extends PlotListener implements Listener {
                         return;
                     }
                 }
-            } catch (Throwable e) {
+            } catch (Throwable ignored) {
                 this.pistonBlocks = false;
             }
         }
@@ -1172,7 +1174,8 @@ public class PlayerEvents extends PlotListener implements Listener {
                     eventType = PlayerBlockEventType.INTERACT_BLOCK;
                     lb = new BukkitLazyBlock(0, block);
                     break;
-                } else if (id < 198) {
+                }
+                if (id < 198) {
                     location = BukkitUtil.getLocation(block.getRelative(event.getBlockFace()).getLocation());
                     eventType = PlayerBlockEventType.PLACE_BLOCK;
                     lb = new BukkitLazyBlock(id, block);
@@ -1330,11 +1333,7 @@ public class PlayerEvents extends PlotListener implements Listener {
             return;
         }
         Plot plot = area.getOwnedPlotAbs(location);
-        if (plot == null) {
-            event.setCancelled(true);
-            return;
-        }
-        if (plot.getFlag(Flags.DISABLE_PHYSICS, false)) {
+        if (plot == null || plot.getFlag(Flags.DISABLE_PHYSICS, false)) {
             event.setCancelled(true);
             return;
         }
@@ -1400,7 +1399,7 @@ public class PlayerEvents extends PlotListener implements Listener {
     }
 
     public boolean checkEntity(Entity entity, Plot plot) {
-        if (plot == null || plot.owner == null || plot.getFlags().isEmpty() && plot.getArea().DEFAULT_FLAGS.isEmpty()) {
+        if (plot == null || !plot.hasOwner() || plot.getFlags().isEmpty() && plot.getArea().DEFAULT_FLAGS.isEmpty()) {
             return false;
         }
         switch (entity.getType()) {
@@ -1498,9 +1497,11 @@ public class PlayerEvents extends PlotListener implements Listener {
                     } else {
                         return checkEntity(plot, Flags.ENTITY_CAP, Flags.MOB_CAP);
                     }
-                } else if (entity instanceof Vehicle) {
+                }
+                if (entity instanceof Vehicle) {
                     return checkEntity(plot, Flags.ENTITY_CAP, Flags.VEHICLE_CAP);
-                } else if (entity instanceof Hanging) {
+                }
+                if (entity instanceof Hanging) {
                     return checkEntity(plot, Flags.ENTITY_CAP, Flags.MISC_CAP);
                 }
                 return checkEntity(plot, Flags.ENTITY_CAP);
@@ -1508,8 +1509,8 @@ public class PlayerEvents extends PlotListener implements Listener {
     }
 
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onBlockBurn(BlockBurnEvent e) {
-        Block b = e.getBlock();
+    public void onBlockBurn(BlockBurnEvent event) {
+        Block b = event.getBlock();
         Location location = BukkitUtil.getLocation(b.getLocation());
 
         PlotArea area = location.getPlotArea();
@@ -1519,7 +1520,7 @@ public class PlayerEvents extends PlotListener implements Listener {
 
         Plot plot = location.getOwnedPlot();
         if (plot == null || !plot.getFlag(Flags.BLOCK_BURN, false)) {
-            e.setCancelled(true);
+            event.setCancelled(true);
             return;
         }
 
@@ -1568,59 +1569,44 @@ public class PlayerEvents extends PlotListener implements Listener {
                     MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, C.PERMISSION_ADMIN_BUILD_OTHER);
                     event.setCancelled(true);
                 }
-            } else if (!plot.getFlag(Flags.BLOCK_IGNITION, false)) {
+            } else if (Flags.BLOCK_IGNITION.isFalse(plot)) {
                 event.setCancelled(true);
             }
-        } else if (ignitingEntity != null) {
-            if (plot == null || !plot.getFlag(Flags.BLOCK_IGNITION, false)) {
+        } else {
+            if (plot == null) {
                 event.setCancelled(true);
                 return;
             }
-            if (igniteCause == BlockIgniteEvent.IgniteCause.FIREBALL) {
-                if (ignitingEntity instanceof Fireball) {
-                    Projectile fireball = (Projectile) ignitingEntity;
-                    Location location = null;
-                    if (fireball.getShooter() instanceof Entity) {
-                        Entity shooter = (Entity) fireball.getShooter();
-                        location = BukkitUtil.getLocation(shooter.getLocation());
-                    } else if (fireball.getShooter() instanceof BlockProjectileSource) {
-                        Block shooter = ((BlockProjectileSource) fireball.getShooter()).getBlock();
-                        location = BukkitUtil.getLocation(shooter.getLocation());
-                    }
-                    if (location != null && (location.getPlot() == null || !location.getPlot().equals(plot))) {
-                        event.setCancelled(true);
+            if (ignitingEntity != null) {
+                if (!plot.getFlag(Flags.BLOCK_IGNITION,false)) {
+                    event.setCancelled(true);
+                    return;
+                }
+                if (igniteCause == BlockIgniteEvent.IgniteCause.FIREBALL) {
+                    if (ignitingEntity instanceof Fireball) {
+                        Projectile fireball = (Projectile) ignitingEntity;
+                        Location location = null;
+                        if (fireball.getShooter() instanceof Entity) {
+                            Entity shooter = (Entity) fireball.getShooter();
+                            location = BukkitUtil.getLocation(shooter.getLocation());
+                        } else if (fireball.getShooter() instanceof BlockProjectileSource) {
+                            Block shooter = ((BlockProjectileSource) fireball.getShooter()).getBlock();
+                            location = BukkitUtil.getLocation(shooter.getLocation());
+                        }
+                        if (location != null && !plot.equals(location.getPlot())) {
+                            event.setCancelled(true);
+                        }
                     }
                 }
-            }
 
-        } else if (event.getIgnitingBlock() != null) {
-            Block ignitingBlock = event.getIgnitingBlock();
-            if (igniteCause == BlockIgniteEvent.IgniteCause.FLINT_AND_STEEL) {
-                if (plot == null || !plot.getFlag(Flags.BLOCK_IGNITION, false)) {
+            } else if (event.getIgnitingBlock() != null) {
+                Block ignitingBlock = event.getIgnitingBlock();
+                Plot plotIgnited = BukkitUtil.getLocation(ignitingBlock.getLocation()).getPlot();
+                if (igniteCause == BlockIgniteEvent.IgniteCause.FLINT_AND_STEEL && (!plot.getFlag(Flags.BLOCK_IGNITION,false)
+                        || plotIgnited == null || !plotIgnited.equals(plot))
+                        || (igniteCause == BlockIgniteEvent.IgniteCause.SPREAD || igniteCause == BlockIgniteEvent.IgniteCause.LAVA) && (
+                        !plot.getFlag(Flags.BLOCK_IGNITION).or(false) || plotIgnited == null || !plotIgnited.equals(plot))) {
                     event.setCancelled(true);
-                    return;
-                }
-                if (BukkitUtil.getLocation(ignitingBlock.getLocation()).getPlot() == null) {
-                    event.setCancelled(true);
-                    return;
-                }
-                if (!BukkitUtil.getLocation(ignitingBlock.getLocation()).getPlot().equals(plot)) {
-                    event.setCancelled(true);
-                    return;
-                }
-            }
-            if (igniteCause == BlockIgniteEvent.IgniteCause.SPREAD || igniteCause == BlockIgniteEvent.IgniteCause.LAVA) {
-                if (plot == null || !plot.getFlag(Flags.BLOCK_IGNITION, false)) {
-                    event.setCancelled(true);
-                    return;
-                }
-                if (BukkitUtil.getLocation(ignitingBlock.getLocation()).getPlot() == null) {
-                    event.setCancelled(true);
-                    return;
-                }
-                if (!BukkitUtil.getLocation(ignitingBlock.getLocation()).getPlot().equals(plot)) {
-                    event.setCancelled(true);
-                    return;
                 }
             }
         }
@@ -1920,8 +1906,9 @@ public class PlayerEvents extends PlotListener implements Listener {
                     event.setCancelled(true);
                 }
                 return;
-            } else if (!plot.isAdded(pp.getUUID())) {
-                if (!plot.getFlag(Flags.HANGING_PLACE, false)) {
+            }
+            if (!plot.isAdded(pp.getUUID())) {
+                if (!plot.getFlag(Flags.HANGING_PLACE,false)) {
                     if (!Permissions.hasPermission(pp, C.PERMISSION_ADMIN_BUILD_OTHER)) {
                         MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, C.PERMISSION_ADMIN_BUILD_OTHER);
                         event.setCancelled(true);
@@ -2044,13 +2031,13 @@ public class PlayerEvents extends PlotListener implements Listener {
     }
 
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onVehicleDestroy(VehicleDestroyEvent e) {
-        Location l = BukkitUtil.getLocation(e.getVehicle());
+    public void onVehicleDestroy(VehicleDestroyEvent event) {
+        Location l = BukkitUtil.getLocation(event.getVehicle());
         PlotArea area = l.getPlotArea();
         if (area == null) {
             return;
         }
-        Entity d = e.getAttacker();
+        Entity d = event.getAttacker();
         if (d instanceof Player) {
             Player p = (Player) d;
             PlotPlayer pp = BukkitUtil.getPlayer(p);
@@ -2058,13 +2045,13 @@ public class PlayerEvents extends PlotListener implements Listener {
             if (plot == null) {
                 if (!Permissions.hasPermission(pp, "plots.admin.vehicle.break.road")) {
                     MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.vehicle.break.road");
-                    e.setCancelled(true);
+                    event.setCancelled(true);
                 }
             } else {
                 if (!plot.hasOwner()) {
                     if (!Permissions.hasPermission(pp, "plots.admin.vehicle.break.unowned")) {
                         MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.vehicle.break.unowned");
-                        e.setCancelled(true);
+                        event.setCancelled(true);
                         return;
                     }
                     return;
@@ -2075,7 +2062,7 @@ public class PlayerEvents extends PlotListener implements Listener {
                     }
                     if (!Permissions.hasPermission(pp, "plots.admin.vehicle.break.other")) {
                         MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.vehicle.break.other");
-                        e.setCancelled(true);
+                        event.setCancelled(true);
                     }
                 }
             }
@@ -2102,15 +2089,15 @@ public class PlayerEvents extends PlotListener implements Listener {
     }
 
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onEntityDamageByEntityEvent(EntityDamageByEntityEvent e) {
-        Entity damager = e.getDamager();
+    public void onEntityDamageByEntityEvent(EntityDamageByEntityEvent event) {
+        Entity damager = event.getDamager();
         Location l = BukkitUtil.getLocation(damager);
         if (!PS.get().hasPlotArea(l.getWorld())) {
             return;
         }
-        Entity victim = e.getEntity();
+        Entity victim = event.getEntity();
         if (!entityDamage(damager, victim)) {
-            e.setCancelled(true);
+            event.setCancelled(true);
         }
     }
 
@@ -2253,29 +2240,29 @@ public class PlayerEvents extends PlotListener implements Listener {
     }
 
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
-    public void onPlayerEggThrow(PlayerEggThrowEvent e) {
-        Location l = BukkitUtil.getLocation(e.getEgg().getLocation());
+    public void onPlayerEggThrow(PlayerEggThrowEvent event) {
+        Location l = BukkitUtil.getLocation(event.getEgg().getLocation());
         PlotArea area = l.getPlotArea();
         if (area == null) {
             return;
         }
-        Player p = e.getPlayer();
+        Player p = event.getPlayer();
         PlotPlayer pp = BukkitUtil.getPlayer(p);
         Plot plot = area.getPlot(l);
         if (plot == null) {
             if (!Permissions.hasPermission(pp, "plots.admin.projectile.road")) {
                 MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.projectile.road");
-                e.setHatching(false);
+                event.setHatching(false);
             }
         } else if (!plot.hasOwner()) {
             if (!Permissions.hasPermission(pp, "plots.admin.projectile.unowned")) {
                 MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.projectile.unowned");
-                e.setHatching(false);
+                event.setHatching(false);
             }
         } else if (!plot.isAdded(pp.getUUID())) {
             if (!Permissions.hasPermission(pp, "plots.admin.projectile.other")) {
                 MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, "plots.admin.projectile.other");
-                e.setHatching(false);
+                event.setHatching(false);
             }
         }
     }
@@ -2326,7 +2313,7 @@ public class PlayerEvents extends PlotListener implements Listener {
             if (loc.getY() > area.MAX_BUILD_HEIGHT && loc.getY() < area.MIN_BUILD_HEIGHT && !Permissions
                     .hasPermission(pp, C.PERMISSION_ADMIN_BUILD_HEIGHTLIMIT)) {
                 event.setCancelled(true);
-                MainUtil.sendMessage(pp, C.HEIGHT_LIMIT.s().replace("{limit}", "" + area.MAX_BUILD_HEIGHT));
+                MainUtil.sendMessage(pp, C.HEIGHT_LIMIT.s().replace("{limit}", String.valueOf(area.MAX_BUILD_HEIGHT)));
             }
         } else if (!Permissions.hasPermission(pp, C.PERMISSION_ADMIN_BUILD_OTHER)) {
             MainUtil.sendMessage(pp, C.NO_PERMISSION_EVENT, C.PERMISSION_ADMIN_BUILD_ROAD);

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlayerEvents_1_9.java

@@ -9,9 +9,6 @@ import org.bukkit.event.EventPriority;
 import org.bukkit.event.Listener;
 import org.bukkit.event.entity.LingeringPotionSplashEvent;
 
-/**
- * Created by Jesse on 3/30/2016.
- */
 public class PlayerEvents_1_9 implements Listener {
 
     private final PlayerEvents parent;

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/PlotPlusListener.java

@@ -131,8 +131,11 @@ public class PlotPlusListener extends PlotListener implements Listener {
             return;
         }
         UUID uuid = pp.getUUID();
-        if (plot.isAdded(uuid) && plot.getFlag(Flags.ITEM_DROP).or(false)) {
-            event.setCancelled(true);
+        if (plot.isAdded(uuid)) {
+            Optional<Boolean> flag = plot.getFlag(Flags.ITEM_DROP);
+            if (flag.isPresent() && !flag.get()) {
+                event.setCancelled(true);
+            }
         }
     }
     

Bukkit/src/main/java/com/plotsquared/bukkit/listeners/worldedit/WEListener.java

@@ -27,25 +27,25 @@ import org.bukkit.event.player.PlayerCommandPreprocessEvent;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashSet;
+import java.util.Set;
 
 public class WEListener implements Listener {
 
-    public final HashSet<String> rad1 = new HashSet<>(
+    public final Set<String> other = new HashSet<>(Arrays.asList("undo", "redo"));
+    private final Set<String> rad1 = new HashSet<>(
             Arrays.asList("forestgen", "pumpkins", "drain", "fixwater", "fixlava", "replacenear", "snow", "thaw", "ex", "butcher", "size"));
-    public final HashSet<String> rad2 = new HashSet<>(Arrays.asList("fill", "fillr", "removenear", "remove"));
-    public final HashSet<String> rad2_1 = new HashSet<>(Arrays.asList("hcyl", "cyl"));
-    public final HashSet<String> rad2_2 = new HashSet<>(Arrays.asList("sphere", "pyramid"));
-    public final HashSet<String> rad2_3 = new HashSet<>(Collections.singletonList("brush smooth"));
-    public final HashSet<String> rad3_1 = new HashSet<>(Collections.singletonList("brush gravity"));
-    public final HashSet<String> rad3_2 = new HashSet<>(Arrays.asList("brush sphere", "brush cylinder"));
-
-    public final HashSet<String> region = new HashSet<>(
+    private final Set<String> rad2 = new HashSet<>(Arrays.asList("fill", "fillr", "removenear", "remove"));
+    private final Set<String> rad2_1 = new HashSet<>(Arrays.asList("hcyl", "cyl"));
+    private final Set<String> rad2_2 = new HashSet<>(Arrays.asList("sphere", "pyramid"));
+    private final Set<String> rad2_3 = Collections.singleton("brush smooth");
+    private final Set<String> rad3_1 = Collections.singleton("brush gravity");
+    private final Set<String> rad3_2 = new HashSet<>(Arrays.asList("brush sphere", "brush cylinder"));
+    private final Set<String> region = new HashSet<>(
             Arrays.asList("move", "set", "replace", "overlay", "walls", "outline", "deform", "hollow", "smooth", "naturalize", "paste", "count",
                     "distr",
                     "regen", "copy", "cut", "green", "setbiome"));
-    public final HashSet<String> regionExtend = new HashSet<>(Collections.singletonList("stack"));
-    public final HashSet<String> restricted = new HashSet<>(Collections.singletonList("up"));
-    public final HashSet<String> other = new HashSet<>(Arrays.asList("undo", "redo"));
+    private final Set<String> regionExtend = Collections.singleton("stack");
+    private final Set<String> restricted = Collections.singleton("up");
 
     public String reduceCmd(String cmd, boolean single) {
         if (cmd.startsWith("/worldedit:/")) {
@@ -74,14 +74,14 @@ public class WEListener implements Listener {
                 }
             }
             return max;
-        } catch (NumberFormatException e) {
+        } catch (NumberFormatException ignored) {
             return 0;
         }
     }
 
     public boolean checkVolume(PlotPlayer player, long volume, long max, Cancellable e) {
         if (volume > max) {
-            MainUtil.sendMessage(player, C.WORLDEDIT_VOLUME.s().replaceAll("%current%", volume + "").replaceAll("%max%", max + ""));
+            MainUtil.sendMessage(player, C.WORLDEDIT_VOLUME.s().replaceAll("%current%", String.valueOf(volume)).replaceAll("%max%", String.valueOf(max)));
             e.setCancelled(true);
         }
         if (Permissions.hasPermission(player, "plots.worldedit.bypass")) {
@@ -180,7 +180,7 @@ public class WEListener implements Listener {
         boolean single = true;
         if (split.length >= 2) {
             String reduced = reduceCmd(split[0], single);
-            String reduced2 = reduceCmd(split[0] + " " + split[1], single);
+            String reduced2 = reduceCmd(split[0] + ' ' + split[1], single);
             if (this.rad1.contains(reduced)) {
                 if (delay(p, message, false)) {
                     e.setCancelled(true);
@@ -233,7 +233,8 @@ public class WEListener implements Listener {
                         int iterations = getInt(split[3]);
                         if (iterations > maxIterations) {
                             MainUtil.sendMessage(pp,
-                                    C.WORLDEDIT_ITERATIONS.s().replaceAll("%current%", iterations + "").replaceAll("%max%", maxIterations + ""));
+                                    C.WORLDEDIT_ITERATIONS.s().replaceAll("%current%", String.valueOf(iterations)).replaceAll("%max%",
+                                            String.valueOf(maxIterations)));
                             e.setCancelled(true);
                             if (Permissions.hasPermission(pp, "plots.worldedit.bypass")) {
                                 MainUtil.sendMessage(pp, C.WORLDEDIT_BYPASS);

Bukkit/src/main/java/com/plotsquared/bukkit/object/entity/EntityWrapper.java

@@ -465,8 +465,7 @@ public class EntityWrapper {
         if (this.base.passenger != null) {
             try {
                 entity.setPassenger(this.base.passenger.spawn(world, x_offset, z_offset));
-            } catch (Exception ignored) {
-            }
+            } catch (Exception ignored) {}
         }
         if (this.base.fall != 0) {
             entity.setFallDistance(this.base.fall);

Bukkit/src/main/java/com/plotsquared/bukkit/titles/DefaultTitleManager.java

@@ -57,14 +57,14 @@ public class DefaultTitleManager extends TitleManager {
             // Send title
             Object serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
                     "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.getTitle()) + "\",color:" + this.titleColor.name().toLowerCase()
-                            + "}");
+                            + '}');
             packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[0], serialized);
             sendPacket.invoke(connection, packet);
             if (!this.getSubtitle().isEmpty()) {
                 // Send subtitle if present
                 serialized = getMethod(this.nmsChatSerializer, "a", String.class).invoke(null,
                         "{text:\"" + ChatColor.translateAlternateColorCodes('&', this.getSubtitle()) + "\",color:" + this.subtitleColor.name()
-                                .toLowerCase() + "}");
+                                .toLowerCase() + '}');
                 packet = this.packetTitle.getConstructor(this.packetActions, this.chatBaseComponent).newInstance(actions[1], serialized);
                 sendPacket.invoke(connection, packet);
             }

Bukkit/src/main/java/com/plotsquared/bukkit/titles/HackTitleManager.java

@@ -143,12 +143,11 @@ public class HackTitleManager extends TitleManager {
     private Class<?> getClass(String namespace) {
         try {
             return Class.forName(namespace);
-        } catch (ClassNotFoundException ignored) {
-        }
+        } catch (ClassNotFoundException ignored) {}
         return null;
     }
 
-    private Field getField(String name, Class<?> clazz) throws Exception {
+    private Field getField(String name, Class<?> clazz) throws NoSuchFieldException, SecurityException {
         return clazz.getDeclaredField(name);
     }
 

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitChunkManager.java

@@ -58,6 +58,7 @@ import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
 
@@ -616,25 +617,25 @@ public class BukkitChunkManager extends ChunkManager {
 
     public static class ContentMap {
 
-        public final HashMap<BlockLoc, ItemStack[]> chestContents;
-        public final HashMap<BlockLoc, ItemStack[]> furnaceContents;
-        public final HashMap<BlockLoc, ItemStack[]> dispenserContents;
-        public final HashMap<BlockLoc, ItemStack[]> dropperContents;
-        public final HashMap<BlockLoc, ItemStack[]> brewingStandContents;
-        public final HashMap<BlockLoc, ItemStack[]> beaconContents;
-        public final HashMap<BlockLoc, ItemStack[]> hopperContents;
-        public final HashMap<BlockLoc, Short[]> furnaceTime;
-        public final HashMap<BlockLoc, Object[]> skullData;
-        public final HashMap<BlockLoc, Material> jukeboxDisc;
-        public final HashMap<BlockLoc, Short> brewTime;
-        public final HashMap<BlockLoc, EntityType> spawnerData;
-        public final HashMap<BlockLoc, String> cmdData;
-        public final HashMap<BlockLoc, String[]> signContents;
-        public final HashMap<BlockLoc, Note> noteBlockContents;
-        public final HashMap<BlockLoc, List<Pattern>> bannerPatterns;
-        public final HashMap<BlockLoc, DyeColor> bannerBase;
-        public final HashSet<EntityWrapper> entities;
-        public final HashMap<PlotLoc, PlotBlock[]> allBlocks;
+        public final Map<BlockLoc, ItemStack[]> chestContents;
+        public final Map<BlockLoc, ItemStack[]> furnaceContents;
+        public final Map<BlockLoc, ItemStack[]> dispenserContents;
+        public final Map<BlockLoc, ItemStack[]> dropperContents;
+        public final Map<BlockLoc, ItemStack[]> brewingStandContents;
+        public final Map<BlockLoc, ItemStack[]> beaconContents;
+        public final Map<BlockLoc, ItemStack[]> hopperContents;
+        public final Map<BlockLoc, Short[]> furnaceTime;
+        public final Map<BlockLoc, Object[]> skullData;
+        public final Map<BlockLoc, Material> jukeboxDisc;
+        public final Map<BlockLoc, Short> brewTime;
+        public final Map<BlockLoc, EntityType> spawnerData;
+        public final Map<BlockLoc, String> cmdData;
+        public final Map<BlockLoc, String[]> signContents;
+        public final Map<BlockLoc, Note> noteBlockContents;
+        public final Map<BlockLoc, List<Pattern>> bannerPatterns;
+        public final Map<BlockLoc, DyeColor> bannerBase;
+        public final Set<EntityWrapper> entities;
+        public final Map<PlotLoc, PlotBlock[]> allBlocks;
 
         public ContentMap() {
             this.chestContents = new HashMap<>();
@@ -742,12 +743,12 @@ public class BukkitChunkManager extends ChunkManager {
                         chest.getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate chest: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate chest: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
                 } catch (IllegalArgumentException ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate chest (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to regenerate chest (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, String[]> blockLocEntry : this.signContents.entrySet()) {
@@ -765,14 +766,14 @@ public class BukkitChunkManager extends ChunkManager {
                         state.update(true);
                     } else {
                         PS.debug(
-                                "&c[WARN] Plot clear failed to regenerate sign: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
+                                "&c[WARN] Plot clear failed to regenerate sign: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
                                         .getKey().y
-                                        + "," + (
+                                        + ',' + (
                                         blockLocEntry.getKey().z + zOffset));
                     }
-                } catch (IndexOutOfBoundsException e) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate sign: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry.getKey().y
-                            + "," + (
+                } catch (IndexOutOfBoundsException ignored) {
+                    PS.debug("&c[WARN] Plot clear failed to regenerate sign: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry.getKey().y
+                            + ',' + (
                             blockLocEntry.getKey().z + zOffset));
                 }
             }
@@ -785,12 +786,12 @@ public class BukkitChunkManager extends ChunkManager {
                         ((InventoryHolder) state).getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate dispenser: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate dispenser: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
                 } catch (IllegalArgumentException ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate dispenser (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to regenerate dispenser (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, ItemStack[]> blockLocEntry : this.dropperContents.entrySet()) {
@@ -802,12 +803,12 @@ public class BukkitChunkManager extends ChunkManager {
                         ((InventoryHolder) state).getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate dispenser: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate dispenser: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
                 } catch (IllegalArgumentException ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate dispenser (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to regenerate dispenser (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, ItemStack[]> blockLocEntry : this.beaconContents.entrySet()) {
@@ -819,12 +820,12 @@ public class BukkitChunkManager extends ChunkManager {
                         ((InventoryHolder) state).getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate beacon: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate beacon: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
                 } catch (IllegalArgumentException ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate beacon (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to regenerate beacon (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, Material> blockLocMaterialEntry : this.jukeboxDisc.entrySet()) {
@@ -837,15 +838,15 @@ public class BukkitChunkManager extends ChunkManager {
                         ((Jukebox) state).setPlaying(blockLocMaterialEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to restore jukebox: " + (blockLocMaterialEntry.getKey().x + xOffset) + ","
+                        PS.debug("&c[WARN] Plot clear failed to restore jukebox: " + (blockLocMaterialEntry.getKey().x + xOffset) + ','
                                 + blockLocMaterialEntry
-                                .getKey().y + "," + (
+                                .getKey().y + ',' + (
                                 blockLocMaterialEntry.getKey().z + zOffset));
                     }
                 } catch (Exception ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate jukebox (e): " + (blockLocMaterialEntry.getKey().x + xOffset) + ","
+                    PS.debug("&c[WARN] Plot clear failed to regenerate jukebox (e): " + (blockLocMaterialEntry.getKey().x + xOffset) + ','
                             + blockLocMaterialEntry
-                            .getKey().y + "," + (
+                            .getKey().y + ',' + (
                             blockLocMaterialEntry.getKey().z + zOffset));
                 }
             }
@@ -863,12 +864,12 @@ public class BukkitChunkManager extends ChunkManager {
                         ((Skull) state).setSkullType((SkullType) data[3]);
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to restore skull: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to restore skull: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
                 } catch (Exception e) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate skull (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to regenerate skull (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     e.printStackTrace();
                 }
             }
@@ -881,12 +882,12 @@ public class BukkitChunkManager extends ChunkManager {
                         ((InventoryHolder) state).getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate hopper: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate hopper: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
                 } catch (IllegalArgumentException ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate hopper (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to regenerate hopper (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, Note> blockLocNoteEntry : this.noteBlockContents.entrySet()) {
@@ -898,15 +899,15 @@ public class BukkitChunkManager extends ChunkManager {
                         ((NoteBlock) state).setNote(blockLocNoteEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate note block: " + (blockLocNoteEntry.getKey().x + xOffset) + ","
+                        PS.debug("&c[WARN] Plot clear failed to regenerate note block: " + (blockLocNoteEntry.getKey().x + xOffset) + ','
                                 + blockLocNoteEntry
-                                .getKey().y + "," + (
+                                .getKey().y + ',' + (
                                 blockLocNoteEntry.getKey().z + zOffset));
                     }
                 } catch (Exception ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate note block (e): " + (blockLocNoteEntry.getKey().x + xOffset) + ","
+                    PS.debug("&c[WARN] Plot clear failed to regenerate note block (e): " + (blockLocNoteEntry.getKey().x + xOffset) + ','
                             + blockLocNoteEntry
-                            .getKey().y + "," + (
+                            .getKey().y + ',' + (
                             blockLocNoteEntry.getKey().z + zOffset));
                 }
             }
@@ -918,14 +919,14 @@ public class BukkitChunkManager extends ChunkManager {
                     if (state instanceof BrewingStand) {
                         ((BrewingStand) state).setBrewingTime(blockLocShortEntry.getValue());
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to restore brewing stand cooking: " + (blockLocShortEntry.getKey().x + xOffset) + ","
+                        PS.debug("&c[WARN] Plot clear failed to restore brewing stand cooking: " + (blockLocShortEntry.getKey().x + xOffset) + ','
                                 + blockLocShortEntry
-                                .getKey().y + "," + (
+                                .getKey().y + ',' + (
                                 blockLocShortEntry.getKey().z + zOffset));
                     }
                 } catch (Exception ignored) {
-                    PS.debug("&c[WARN] Plot clear failed to restore brewing stand cooking (e): " + (blockLocShortEntry.getKey().x + xOffset) + ","
-                            + blockLocShortEntry.getKey().y + "," + (blockLocShortEntry.getKey().z + zOffset));
+                    PS.debug("&c[WARN] Plot clear failed to restore brewing stand cooking (e): " + (blockLocShortEntry.getKey().x + xOffset) + ','
+                            + blockLocShortEntry.getKey().y + ',' + (blockLocShortEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, EntityType> blockLocEntityTypeEntry : this.spawnerData.entrySet()) {
@@ -938,14 +939,14 @@ public class BukkitChunkManager extends ChunkManager {
                         ((CreatureSpawner) state).setSpawnedType(blockLocEntityTypeEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to restore spawner type: " + (blockLocEntityTypeEntry.getKey().x + xOffset) + ","
+                        PS.debug("&c[WARN] Plot clear failed to restore spawner type: " + (blockLocEntityTypeEntry.getKey().x + xOffset) + ','
                                 + blockLocEntityTypeEntry
-                                .getKey().y + "," + (
+                                .getKey().y + ',' + (
                                 blockLocEntityTypeEntry.getKey().z + zOffset));
                     }
-                } catch (Exception e) {
-                    PS.debug("&c[WARN] Plot clear failed to restore spawner type (e): " + (blockLocEntityTypeEntry.getKey().x + xOffset) + ","
-                            + blockLocEntityTypeEntry.getKey().y + "," + (blockLocEntityTypeEntry.getKey().z + zOffset));
+                } catch (Exception ignored) {
+                    PS.debug("&c[WARN] Plot clear failed to restore spawner type (e): " + (blockLocEntityTypeEntry.getKey().x + xOffset) + ','
+                            + blockLocEntityTypeEntry.getKey().y + ',' + (blockLocEntityTypeEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, String> blockLocStringEntry : this.cmdData.entrySet()) {
@@ -957,15 +958,15 @@ public class BukkitChunkManager extends ChunkManager {
                         ((CommandBlock) state).setCommand(blockLocStringEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to restore command block: " + (blockLocStringEntry.getKey().x + xOffset) + ","
+                        PS.debug("&c[WARN] Plot clear failed to restore command block: " + (blockLocStringEntry.getKey().x + xOffset) + ','
                                 + blockLocStringEntry
-                                .getKey().y + "," + (
+                                .getKey().y + ',' + (
                                 blockLocStringEntry.getKey().z + zOffset));
                     }
-                } catch (Exception e) {
-                    PS.debug("&c[WARN] Plot clear failed to restore command block (e): " + (blockLocStringEntry.getKey().x + xOffset) + ","
+                } catch (Exception ignored) {
+                    PS.debug("&c[WARN] Plot clear failed to restore command block (e): " + (blockLocStringEntry.getKey().x + xOffset) + ','
                             + blockLocStringEntry
-                            .getKey().y + "," + (
+                            .getKey().y + ',' + (
                             blockLocStringEntry.getKey().z + zOffset));
                 }
             }
@@ -978,15 +979,15 @@ public class BukkitChunkManager extends ChunkManager {
                         ((InventoryHolder) state).getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate brewing stand: " + (blockLocEntry.getKey().x + xOffset) + ","
+                        PS.debug("&c[WARN] Plot clear failed to regenerate brewing stand: " + (blockLocEntry.getKey().x + xOffset) + ','
                                 + blockLocEntry
-                                .getKey().y + "," + (
+                                .getKey().y + ',' + (
                                 blockLocEntry.getKey().z
                                         + zOffset));
                     }
-                } catch (IllegalArgumentException e) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate brewing stand (e): " + (blockLocEntry.getKey().x + xOffset) + ","
-                            + blockLocEntry.getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                } catch (IllegalArgumentException ignored) {
+                    PS.debug("&c[WARN] Plot clear failed to regenerate brewing stand (e): " + (blockLocEntry.getKey().x + xOffset) + ','
+                            + blockLocEntry.getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, Short[]> blockLocEntry : this.furnaceTime.entrySet()) {
@@ -1000,13 +1001,13 @@ public class BukkitChunkManager extends ChunkManager {
                         ((Furnace) state).setCookTime(time[1]);
                     } else {
                         PS.debug(
-                                "&c[WARN] Plot clear failed to restore furnace cooking: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                        .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                                "&c[WARN] Plot clear failed to restore furnace cooking: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                        .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
-                } catch (Exception e) {
+                } catch (Exception ignored) {
                     PS.debug(
-                            "&c[WARN] Plot clear failed to restore furnace cooking (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                    .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                            "&c[WARN] Plot clear failed to restore furnace cooking (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                    .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, ItemStack[]> blockLocEntry : this.furnaceContents.entrySet()) {
@@ -1018,12 +1019,12 @@ public class BukkitChunkManager extends ChunkManager {
                         ((InventoryHolder) state).getInventory().setContents(blockLocEntry.getValue());
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate furnace: " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                                .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate furnace: " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                                .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                     }
-                } catch (IllegalArgumentException e) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate furnace (e): " + (blockLocEntry.getKey().x + xOffset) + "," + blockLocEntry
-                            .getKey().y + "," + (blockLocEntry.getKey().z + zOffset));
+                } catch (IllegalArgumentException ignored) {
+                    PS.debug("&c[WARN] Plot clear failed to regenerate furnace (e): " + (blockLocEntry.getKey().x + xOffset) + ',' + blockLocEntry
+                            .getKey().y + ',' + (blockLocEntry.getKey().z + zOffset));
                 }
             }
             for (Entry<BlockLoc, DyeColor> blockLocByteEntry : this.bannerBase.entrySet()) {
@@ -1039,12 +1040,12 @@ public class BukkitChunkManager extends ChunkManager {
                         banner.setPatterns(patterns);
                         state.update(true);
                     } else {
-                        PS.debug("&c[WARN] Plot clear failed to regenerate banner: " + (blockLocByteEntry.getKey().x + xOffset) + ","
-                                + blockLocByteEntry.getKey().y + "," + (blockLocByteEntry.getKey().z + zOffset));
+                        PS.debug("&c[WARN] Plot clear failed to regenerate banner: " + (blockLocByteEntry.getKey().x + xOffset) + ','
+                                + blockLocByteEntry.getKey().y + ',' + (blockLocByteEntry.getKey().z + zOffset));
                     }
-                } catch (Exception e) {
-                    PS.debug("&c[WARN] Plot clear failed to regenerate banner (e): " + (blockLocByteEntry.getKey().x + xOffset) + ","
-                            + blockLocByteEntry.getKey().y + "," + (blockLocByteEntry.getKey().z + zOffset));
+                } catch (Exception ignored) {
+                    PS.debug("&c[WARN] Plot clear failed to regenerate banner (e): " + (blockLocByteEntry.getKey().x + xOffset) + ','
+                            + blockLocByteEntry.getKey().y + ',' + (blockLocByteEntry.getKey().z + zOffset));
                 }
             }
         }
@@ -1074,33 +1075,42 @@ public class BukkitChunkManager extends ChunkManager {
                         if (block.getState() instanceof InventoryHolder) {
                             InventoryHolder inventoryHolder = (InventoryHolder) block.getState();
                             ItemStack[] inventory = inventoryHolder.getInventory().getContents().clone();
-                            if (id == Material.CHEST) {
-                                this.chestContents.put(bl, inventory);
-                            } else if (id == Material.DISPENSER) {
-                                this.dispenserContents.put(bl, inventory);
-                            } else if (id == Material.BEACON) {
-                                this.beaconContents.put(bl, inventory);
-                            } else if (id == Material.DROPPER) {
-                                this.dropperContents.put(bl, inventory);
-                            } else if (id == Material.HOPPER) {
-                                this.hopperContents.put(bl, inventory);
-                            } else if (id == Material.BREWING_STAND) {
-                                BrewingStand brewingStand = (BrewingStand) inventoryHolder;
-                                short time = (short) brewingStand.getBrewingTime();
-                                if (time > 0) {
-                                    this.brewTime.put(bl, time);
-                                }
-                                ItemStack[] invBre = brewingStand.getInventory().getContents().clone();
-                                this.brewingStandContents.put(bl, invBre);
-                            } else if (id == Material.FURNACE || id == Material.BURNING_FURNACE) {
-                                Furnace furnace = (Furnace) inventoryHolder;
-                                short burn = furnace.getBurnTime();
-                                short cook = furnace.getCookTime();
-                                ItemStack[] invFur = furnace.getInventory().getContents().clone();
-                                this.furnaceContents.put(bl, invFur);
-                                if (cook != 0) {
-                                    this.furnaceTime.put(bl, new Short[]{burn, cook});
-                                }
+                            switch (id) {
+                                case CHEST:
+                                    this.chestContents.put(bl, inventory);
+                                    break;
+                                case DISPENSER:
+                                    this.dispenserContents.put(bl, inventory);
+                                    break;
+                                case BEACON:
+                                    this.beaconContents.put(bl, inventory);
+                                    break;
+                                case DROPPER:
+                                    this.dropperContents.put(bl, inventory);
+                                    break;
+                                case HOPPER:
+                                    this.hopperContents.put(bl, inventory);
+                                    break;
+                                case BREWING_STAND:
+                                    BrewingStand brewingStand = (BrewingStand) inventoryHolder;
+                                    short time = (short) brewingStand.getBrewingTime();
+                                    if (time > 0) {
+                                        this.brewTime.put(bl, time);
+                                    }
+                                    ItemStack[] invBre = brewingStand.getInventory().getContents().clone();
+                                    this.brewingStandContents.put(bl, invBre);
+                                    break;
+                                case FURNACE:
+                                case BURNING_FURNACE:
+                                    Furnace furnace = (Furnace) inventoryHolder;
+                                    short burn = furnace.getBurnTime();
+                                    short cook = furnace.getCookTime();
+                                    ItemStack[] invFur = furnace.getInventory().getContents().clone();
+                                    this.furnaceContents.put(bl, invFur);
+                                    if (cook != 0) {
+                                        this.furnaceTime.put(bl, new Short[]{burn, cook});
+                                    }
+                                    break;
                             }
                         } else if (block.getState() instanceof CreatureSpawner) {
                             CreatureSpawner spawner = (CreatureSpawner) block.getState();

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitHybridUtils.java

@@ -49,8 +49,7 @@ public class BukkitHybridUtils extends HybridUtils {
                 }
                 final BiomeGrid nullBiomeGrid = new BiomeGrid() {
                     @Override
-                    public void setBiome(int a, int b, Biome c) {
-                    }
+                    public void setBiome(int a, int b, Biome c) {}
 
                     @Override
                     public Biome getBiome(int a, int b) {

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitPlainChatManager.java

@@ -22,12 +22,10 @@ public class BukkitPlainChatManager extends ChatManager<List<StringBuilder>> {
     }
 
     @Override
-    public void tooltip(PlotMessage message, PlotMessage... tooltips) {
-    }
+    public void tooltip(PlotMessage message, PlotMessage... tooltips) {}
 
     @Override
-    public void command(PlotMessage message, String command) {
-    }
+    public void command(PlotMessage message, String command) {}
 
     @Override
     public void text(PlotMessage message, String text) {
@@ -44,7 +42,6 @@ public class BukkitPlainChatManager extends ChatManager<List<StringBuilder>> {
     }
 
     @Override
-    public void suggest(PlotMessage plotMessage, String command) {
-    }
+    public void suggest(PlotMessage plotMessage, String command) {}
 
 }

Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitUtil.java

@@ -194,7 +194,7 @@ public class BukkitUtil extends WorldUtil {
         try {
             Biome biome = Biome.valueOf(biomeStr.toUpperCase());
             return Arrays.asList(Biome.values()).indexOf(biome);
-        } catch (IllegalArgumentException e) {
+        } catch (IllegalArgumentException ignored) {
             return -1;
         }
     }
@@ -252,7 +252,7 @@ public class BukkitUtil extends WorldUtil {
                 }
             }
             return false;
-        } catch (Exception e) {
+        } catch (Exception ignored) {
             return false;
         }
     }
@@ -271,9 +271,7 @@ public class BukkitUtil extends WorldUtil {
         try {
             Material material = Material.valueOf(name.toUpperCase());
             return new StringComparison<PlotBlock>().new ComparisonResult(0, new PlotBlock((short) material.getId(), (byte) 0));
-        } catch (IllegalArgumentException e) {
-            //ignored
-        }
+        } catch (IllegalArgumentException ignored) {}
         try {
             byte data;
             String[] split = name.split(":");
@@ -297,9 +295,7 @@ public class BukkitUtil extends WorldUtil {
             StringComparison<PlotBlock> outer = new StringComparison<>();
             return outer.new ComparisonResult(match, block);
 
-        } catch (NumberFormatException e) {
-            //ignored
-        }
+        } catch (NumberFormatException ignored) {}
         return null;
     }
 

Bukkit/src/main/java/com/plotsquared/bukkit/util/Metrics.java

@@ -95,8 +95,7 @@ public class Metrics {
             if (gzos != null) {
                 try {
                     gzos.close();
-                } catch (IOException ignore) {
-                }
+                } catch (IOException ignore) {}
             }
         }
         return baos.toByteArray();
@@ -117,7 +116,7 @@ public class Metrics {
                 Double.parseDouble(value);
                 isValueNumeric = true;
             }
-        } catch (NumberFormatException e) {
+        } catch (NumberFormatException ignored) {
             isValueNumeric = false;
         }
         if (json.charAt(json.length() - 1) != '{') {
@@ -446,7 +445,7 @@ public class Metrics {
         try {
             Class.forName("mineshafter.MineServer");
             return true;
-        } catch (ClassNotFoundException e) {
+        } catch (ClassNotFoundException ignored) {
             return false;
         }
     }
@@ -520,11 +519,6 @@ public class Metrics {
             return graph.name.equals(this.name);
         }
 
-        /**
-         * Called when the server owner decides to opt-out of BukkitMetrics while the server is running.
-         */
-        protected void onOptOut() {
-        }
     }
 
     /**
@@ -574,8 +568,7 @@ public class Metrics {
         /**
          * Called after the website graphs have been updated
          */
-        public void reset() {
-        }
+        public void reset() {}
 
         @Override
         public int hashCode() {

Bukkit/src/main/java/com/plotsquared/bukkit/util/SendChunk.java

@@ -42,7 +42,7 @@ public class SendChunk {
     /**
      * Constructor
      */
-    public SendChunk() {
+    public SendChunk() throws ClassNotFoundException, NoSuchMethodException, NoSuchFieldException {
         RefClass classCraftPlayer = getRefClass("{cb}.entity.CraftPlayer");
         this.methodGetHandlePlayer = classCraftPlayer.getMethod("getHandle");
         RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_7.java

@@ -38,7 +38,7 @@ public class FastQueue_1_7 extends SlowQueue {
 
     private final HashMap<ChunkWrapper, Chunk> toUpdate = new HashMap<>();
 
-    public FastQueue_1_7() throws RuntimeException {
+    public FastQueue_1_7() throws NoSuchMethodException, ClassNotFoundException, NoSuchFieldException {
         this.methodGetHandle = this.classCraftWorld.getMethod("getHandle");
         this.methodGetChunkAt = this.classWorld.getMethod("getChunkAt", int.class, int.class);
         this.methodA = this.classChunk.getMethod("a", int.class, int.class, int.class, this.classBlock, int.class);

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_8.java

@@ -41,7 +41,7 @@ public class FastQueue_1_8 extends SlowQueue {
     private final RefConstructor constructorBlockPosition;
     private final SendChunk sendChunk;
 
-    public FastQueue_1_8() throws RuntimeException {
+    public FastQueue_1_8() throws NoSuchMethodException, ClassNotFoundException, NoSuchFieldException {
         this.methodInitLighting = this.classChunk.getMethod("initLighting");
         this.constructorBlockPosition = this.classBlockPosition.getConstructor(int.class, int.class, int.class);
         this.methodGetByCombinedId = this.classBlock.getMethod("getByCombinedId", int.class);
@@ -56,7 +56,7 @@ public class FastQueue_1_8 extends SlowQueue {
                     return;
                 }
                 int count = 0;
-                ArrayList<Chunk> chunks = new ArrayList<Chunk>();
+                ArrayList<Chunk> chunks = new ArrayList<>();
                 Iterator<Entry<ChunkWrapper, Chunk>> i = FastQueue_1_8.this.toUpdate.entrySet().iterator();
                 while (i.hasNext() && count < 128) {
                     chunks.add(i.next().getValue());

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_8_3.java

@@ -49,7 +49,7 @@ public class FastQueue_1_8_3 extends SlowQueue {
     private final RefMethod methodGetWorld;
     private final RefField tileEntityListTick;
 
-    public FastQueue_1_8_3() throws RuntimeException {
+    public FastQueue_1_8_3() throws NoSuchMethodException, ClassNotFoundException, NoSuchFieldException {
         RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
         RefClass classCraftWorld = getRefClass("{cb}.CraftWorld");
         this.methodGetHandleChunk = classCraftChunk.getMethod("getHandle");

Bukkit/src/main/java/com/plotsquared/bukkit/util/block/FastQueue_1_9.java

@@ -51,7 +51,7 @@ public class FastQueue_1_9 extends SlowQueue {
     private final RefField tileEntityListTick;
 
 
-    public FastQueue_1_9() throws RuntimeException {
+    public FastQueue_1_9() throws NoSuchFieldException, NoSuchMethodException, ClassNotFoundException {
         RefClass classCraftChunk = getRefClass("{cb}.CraftChunk");
         this.methodGetHandleChunk = classCraftChunk.getMethod("getHandle");
         RefClass classChunk = getRefClass("{nms}.Chunk");

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/FileUUIDHandler.java

@@ -114,7 +114,7 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                                     }
                                     toAdd.put(new StringWrapper(name), uuid);
                                 }
-                            } catch (Exception e) {
+                            } catch (IOException e) {
                                 e.printStackTrace();
                                 PS.debug(C.PREFIX + "Invalid playerdata: " + current);
                             }
@@ -153,7 +153,7 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                             try {
                                 UUID uuid = UUID.fromString(s);
                                 uuids.add(uuid);
-                            } catch (Exception e) {
+                            } catch (Exception ignored) {
                                 PS.debug(C.PREFIX + "Invalid PlayerData: " + current);
                             }
                         }
@@ -198,7 +198,7 @@ public class FileUUIDHandler extends UUIDHandlerImplementation {
                             ExpireManager.IMP.storeDate(uuid, last);
                         }
                         toAdd.put(new StringWrapper(name), uuid);
-                    } catch (Throwable e) {
+                    } catch (IOException ignored) {
                         PS.debug(C.PREFIX + "&6Invalid PlayerData: " + uuid.toString() + ".dat");
                     }
                 }

Bukkit/src/main/java/com/plotsquared/bukkit/uuid/OfflineUUIDWrapper.java

@@ -14,6 +14,7 @@ import org.bukkit.OfflinePlayer;
 import org.bukkit.Server;
 import org.bukkit.entity.Player;
 
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.Collection;
 import java.util.UUID;
@@ -48,11 +49,9 @@ public class OfflineUUIDWrapper extends UUIDWrapper {
     @Override
     public OfflinePlotPlayer getOfflinePlayer(UUID uuid) {
         BiMap<UUID, StringWrapper> map = UUIDHandler.getUuidMap().inverse();
-        String name;
-        try {
+        String name = null;
+        if (map.containsKey(uuid)) {
             name = map.get(uuid).value;
-        } catch (NullPointerException e) {
-            name = null;
         }
         if (name != null) {
             OfflinePlayer op = Bukkit.getOfflinePlayer(name);
@@ -81,7 +80,7 @@ public class OfflineUUIDWrapper extends UUIDWrapper {
                 @SuppressWarnings("unchecked") Collection<? extends Player> p = (Collection<? extends Player>) players;
                 return p.toArray(new Player[p.size()]);
             }
-        } catch (Exception e) {
+        } catch (IllegalAccessException | InvocationTargetException | IllegalArgumentException ignored) {
             PS.debug("Failed to resolve online players");
             this.getOnline = null;
             Collection<? extends Player> onlinePlayers = Bukkit.getOnlinePlayers();

Core/src/main/java/com/intellectualcrafters/configuration/ConfigurationOptions.java

@@ -4,10 +4,10 @@ package com.intellectualcrafters.configuration;
  * Various settings for controlling the input and output of a {@link
  * Configuration}
  */
-public class ConfigurationOptions {
+class ConfigurationOptions {
+    private final Configuration configuration;
     private char pathSeparator = '.';
     private boolean copyDefaults = false;
-    private final Configuration configuration;
     
     protected ConfigurationOptions(final Configuration configuration) {
         this.configuration = configuration;

Core/src/main/java/com/intellectualcrafters/configuration/MemorySection.java

@@ -76,8 +76,7 @@ public class MemorySection implements ConfigurationSection {
         if (obj instanceof String) {
             try {
                 return Double.parseDouble((String) obj);
-            } catch (NumberFormatException ignored) {
-            }
+            } catch (NumberFormatException ignored) {}
         } else if (obj instanceof List) {
             List<?> val = (List<?>) obj;
             if (!val.isEmpty()) {
@@ -94,8 +93,7 @@ public class MemorySection implements ConfigurationSection {
         if (obj instanceof String) {
             try {
                 return Integer.parseInt((String) obj);
-            } catch (NumberFormatException ignored) {
-            }
+            } catch (NumberFormatException ignored) {}
         } else if (obj instanceof List) {
             List<?> val = (List<?>) obj;
             if (!val.isEmpty()) {
@@ -112,8 +110,7 @@ public class MemorySection implements ConfigurationSection {
         if (obj instanceof String) {
             try {
                 return Long.parseLong((String) obj);
-            } catch (NumberFormatException ignored) {
-            }
+            } catch (NumberFormatException ignored) {}
         } else if (obj instanceof List) {
             List<?> val = (List<?>) obj;
             if (!val.isEmpty()) {
@@ -569,8 +566,7 @@ public class MemorySection implements ConfigurationSection {
             } else if (object instanceof String) {
                 try {
                     result.add(Integer.valueOf((String) object));
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             } else if (object instanceof Character) {
                 result.add((int) (Character) object);
             } else if (object instanceof Number) {
@@ -614,8 +610,7 @@ public class MemorySection implements ConfigurationSection {
             } else if (object instanceof String) {
                 try {
                     result.add(Double.valueOf((String) object));
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             } else if (object instanceof Character) {
                 result.add((double) (Character) object);
             } else if (object instanceof Number) {
@@ -638,8 +633,7 @@ public class MemorySection implements ConfigurationSection {
             } else if (object instanceof String) {
                 try {
                     result.add(Float.valueOf((String) object));
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             } else if (object instanceof Character) {
                 result.add((float) (Character) object);
             } else if (object instanceof Number) {
@@ -662,8 +656,7 @@ public class MemorySection implements ConfigurationSection {
             } else if (object instanceof String) {
                 try {
                     result.add(Long.valueOf((String) object));
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             } else if (object instanceof Character) {
                 result.add((long) (Character) object);
             } else if (object instanceof Number) {
@@ -686,8 +679,7 @@ public class MemorySection implements ConfigurationSection {
             } else if (object instanceof String) {
                 try {
                     result.add(Byte.valueOf((String) object));
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             } else if (object instanceof Character) {
                 result.add((byte) ((Character) object).charValue());
             } else if (object instanceof Number) {
@@ -733,8 +725,7 @@ public class MemorySection implements ConfigurationSection {
             } else if (object instanceof String) {
                 try {
                     result.add(Short.valueOf((String) object));
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             } else if (object instanceof Character) {
                 result.add((short) ((Character) object).charValue());
             } else if (object instanceof Number) {

Core/src/main/java/com/intellectualcrafters/configuration/file/FileConfiguration.java

@@ -25,8 +25,7 @@ public abstract class FileConfiguration extends MemoryConfiguration {
     /**
      * Creates an empty {@link FileConfiguration} with no default values.
      */
-    public FileConfiguration() {
-    }
+    FileConfiguration() {}
     
     /**
      * Creates an empty {@link FileConfiguration} using the specified {@link
@@ -54,9 +53,6 @@ public abstract class FileConfiguration extends MemoryConfiguration {
      * @throws IllegalArgumentException Thrown when file is null.
      */
     public void save(File file) throws IOException {
-        if (file == null) {
-            throw new NullPointerException("File cannot be null");
-        }
         file.getParentFile().mkdirs();
 
         String data = saveToString();
@@ -66,29 +62,6 @@ public abstract class FileConfiguration extends MemoryConfiguration {
         }
     }
 
-    /**
-     * Saves this {@link FileConfiguration} to the specified location.
-     * <p>
-     * If the file does not exist, it will be created. If already exists, it
-     * will be overwritten. If it cannot be overwritten or created, an
-     * exception will be thrown.
-     * <p>
-     * This method will save using the system default encoding, or possibly
-     * using UTF8.
-     *
-     * @param file File to save to.
-     * @throws IOException Thrown when the given file cannot be written to for
-     *     any reason.
-     * @throws IllegalArgumentException Thrown when file is null.
-     */
-    public void save(String file) throws IOException {
-        if (file == null) {
-            throw new NullPointerException("File cannot be null");
-        }
-        
-        save(new File(file));
-    }
-    
     /**
      * Saves this {@link FileConfiguration} to a string, and returns it.
      *

Core/src/main/java/com/intellectualcrafters/configuration/file/YamlConfiguration.java

@@ -21,8 +21,8 @@ import java.util.Map;
  * Note that this implementation is not synchronized.
  */
 public class YamlConfiguration extends FileConfiguration {
-    protected static final String COMMENT_PREFIX = "# ";
-    protected static final String BLANK_CONFIG = "{}\n";
+    private static final String COMMENT_PREFIX = "# ";
+    private static final String BLANK_CONFIG = "{}\n";
     private final DumperOptions yamlOptions = new DumperOptions();
     private final Representer yamlRepresenter = new YamlRepresenter();
     private final Yaml yaml = new Yaml(new YamlConstructor(), yamlRepresenter, yamlOptions);
@@ -40,7 +40,7 @@ public class YamlConfiguration extends FileConfiguration {
      * @return Resulting configuration
      * @throws IllegalArgumentException Thrown if file is null
      */
-    public static YamlConfiguration loadConfiguration(final File file) {
+    public static YamlConfiguration loadConfiguration(File file) {
         if (file == null) {
             throw new NullPointerException("File cannot be null");
         }
@@ -51,7 +51,6 @@ public class YamlConfiguration extends FileConfiguration {
             config.load(file);
         } catch (InvalidConfigurationException | IOException ex) {
             try {
-                file.getAbsolutePath();
                 File dest = new File(file.getAbsolutePath() + "_broken");
                 int i = 0;
                 while (dest.exists()) {
@@ -126,7 +125,7 @@ public class YamlConfiguration extends FileConfiguration {
             input = (Map<?, ?>) yaml.load(contents);
         } catch (final YAMLException e) {
             throw new InvalidConfigurationException(e);
-        } catch (final ClassCastException e) {
+        } catch (final ClassCastException ignored) {
             throw new InvalidConfigurationException("Top level is not a Map.");
         }
 
@@ -164,7 +163,7 @@ public class YamlConfiguration extends FileConfiguration {
 
             if (line.startsWith(COMMENT_PREFIX)) {
                 if (i > 0) {
-                    result.append("\n");
+                    result.append('\n');
                 }
 
                 if (line.length() > COMMENT_PREFIX.length()) {
@@ -173,7 +172,7 @@ public class YamlConfiguration extends FileConfiguration {
 
                 foundHeader = true;
             } else if (foundHeader && line.isEmpty()) {
-                result.append("\n");
+                result.append('\n');
             } else if (foundHeader) {
                 readingHeader = false;
             }
@@ -189,9 +188,9 @@ public class YamlConfiguration extends FileConfiguration {
         if (options().copyHeader()) {
             final Configuration def = getDefaults();
 
-            if (def != null && def instanceof FileConfiguration) {
-                final FileConfiguration filedefaults = (FileConfiguration) def;
-                final String defaultsHeader = filedefaults.buildHeader();
+            if (def instanceof FileConfiguration) {
+                final FileConfiguration fileDefaults = (FileConfiguration) def;
+                final String defaultsHeader = fileDefaults.buildHeader();
 
                 if ((defaultsHeader != null) && !defaultsHeader.isEmpty()) {
                     return defaultsHeader;
@@ -208,7 +207,7 @@ public class YamlConfiguration extends FileConfiguration {
         boolean startedHeader = false;
 
         for (int i = lines.length - 1; i >= 0; i--) {
-            builder.insert(0, "\n");
+            builder.insert(0, '\n');
 
             if (startedHeader || !lines[i].isEmpty()) {
                 builder.insert(0, lines[i]);

Core/src/main/java/com/intellectualcrafters/configuration/file/YamlConfigurationOptions.java

@@ -7,7 +7,7 @@ package com.intellectualcrafters.configuration.file;
 public class YamlConfigurationOptions extends FileConfigurationOptions {
     private int indent = 2;
     
-    protected YamlConfigurationOptions(final YamlConfiguration configuration) {
+    YamlConfigurationOptions(final YamlConfiguration configuration) {
         super(configuration);
     }
     

Core/src/main/java/com/intellectualcrafters/configuration/file/YamlConstructor.java

@@ -11,7 +11,7 @@ import java.util.Map;
 
 public class YamlConstructor extends SafeConstructor {
     
-    public YamlConstructor() {
+    YamlConstructor() {
         yamlConstructors.put(Tag.MAP, new ConstructCustomObject());
     }
     

Core/src/main/java/com/intellectualcrafters/configuration/file/YamlRepresenter.java

@@ -9,7 +9,7 @@ import org.yaml.snakeyaml.representer.Representer;
 import java.util.LinkedHashMap;
 import java.util.Map;
 
-public class YamlRepresenter extends Representer {
+class YamlRepresenter extends Representer {
 
     public YamlRepresenter() {
         this.multiRepresenters.put(ConfigurationSection.class, new RepresentConfigurationSection());

Core/src/main/java/com/intellectualcrafters/configuration/serialization/ConfigurationSerialization.java

@@ -17,8 +17,7 @@ import java.util.logging.Logger;
 public class ConfigurationSerialization {
 
     public static final String SERIALIZED_TYPE_KEY = "==";
-    private static final Map<String, Class<? extends ConfigurationSerializable>> aliases =
-            new HashMap<String, Class<? extends ConfigurationSerializable>>();
+    private static final Map<String, Class<? extends ConfigurationSerializable>> aliases = new HashMap<>();
     private final Class<? extends ConfigurationSerializable> clazz;
 
     protected ConfigurationSerialization(Class<? extends ConfigurationSerializable> clazz) {
@@ -128,8 +127,7 @@ public class ConfigurationSerialization {
      * @param clazz Class to unregister
      */
     public static void unregisterClass(Class<? extends ConfigurationSerializable> clazz) {
-        while (aliases.values().remove(clazz)) {
-        }
+        while (aliases.values().remove(clazz)) {}
     }
 
     /**
@@ -154,7 +152,7 @@ public class ConfigurationSerialization {
         DelegateDeserialization delegate = clazz.getAnnotation(DelegateDeserialization.class);
 
         if (delegate != null) {
-            if ((delegate.value() == null) || (delegate.value() == clazz)) {
+            if (delegate.value() == clazz) {
                 delegate = null;
             } else {
                 return getAlias(delegate.value());
@@ -182,9 +180,7 @@ public class ConfigurationSerialization {
             }
 
             return method;
-        } catch (NoSuchMethodException ex) {
-            return null;
-        } catch (SecurityException ex) {
+        } catch (NoSuchMethodException | SecurityException ignored) {
             return null;
         }
     }
@@ -192,9 +188,7 @@ public class ConfigurationSerialization {
     protected Constructor<? extends ConfigurationSerializable> getConstructor() {
         try {
             return this.clazz.getConstructor(Map.class);
-        } catch (NoSuchMethodException ex) {
-            return null;
-        } catch (SecurityException ex) {
+        } catch (NoSuchMethodException | SecurityException ignored) {
             return null;
         }
     }
@@ -209,7 +203,7 @@ public class ConfigurationSerialization {
             } else {
                 return result;
             }
-        } catch (Throwable ex) {
+        } catch (IllegalAccessException | InvocationTargetException | IllegalArgumentException ex) {
             Logger.getLogger(ConfigurationSerialization.class.getName())
                     .log(Level.SEVERE, "Could not call method '" + method.toString() + "' of " + this.clazz
                                     + " for deserialization",
@@ -222,7 +216,7 @@ public class ConfigurationSerialization {
     protected ConfigurationSerializable deserializeViaCtor(Constructor<? extends ConfigurationSerializable> ctor, Map<String, ?> args) {
         try {
             return ctor.newInstance(args);
-        } catch (Throwable ex) {
+        } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException | InstantiationException ex) {
             Logger.getLogger(ConfigurationSerialization.class.getName())
                     .log(Level.SEVERE, "Could not call constructor '" + ctor.toString() + "' of " + this.clazz
                                     + " for deserialization",
@@ -238,22 +232,17 @@ public class ConfigurationSerialization {
         }
         ConfigurationSerializable result = null;
         Method method = getMethod("deserialize", true);
-
         if (method != null) {
             result = deserializeViaMethod(method, args);
         }
-
         if (result == null) {
             method = getMethod("valueOf", true);
-
             if (method != null) {
                 result = deserializeViaMethod(method, args);
             }
         }
-
         if (result == null) {
             Constructor<? extends ConfigurationSerializable> constructor = getConstructor();
-
             if (constructor != null) {
                 result = deserializeViaCtor(constructor, args);
             }

Core/src/main/java/com/intellectualcrafters/jnbt/ByteArrayTag.java

@@ -44,7 +44,7 @@ public final class ByteArrayTag extends Tag {
         }
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Byte_Array" + append + ": " + hex;

Core/src/main/java/com/intellectualcrafters/jnbt/ByteTag.java

@@ -36,7 +36,7 @@ public final class ByteTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Byte" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/jnbt/CompoundTag.java

@@ -373,7 +373,7 @@ public final class CompoundTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         StringBuilder bldr = new StringBuilder();

Core/src/main/java/com/intellectualcrafters/jnbt/CompoundTagBuilder.java

@@ -16,7 +16,7 @@ public class CompoundTagBuilder {
      * Create a new instance.
      */
     CompoundTagBuilder() {
-        this.entries = new HashMap<String, Tag>();
+        this.entries = new HashMap<>();
     }
 
     /**

Core/src/main/java/com/intellectualcrafters/jnbt/DoubleTag.java

@@ -36,7 +36,7 @@ public final class DoubleTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Double" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/jnbt/EndTag.java

@@ -8,8 +8,7 @@ public final class EndTag extends Tag {
     /**
      * Creates the tag.
      */
-    public EndTag() {
-    }
+    public EndTag() {}
 
     @Override
     public Object getValue() {

Core/src/main/java/com/intellectualcrafters/jnbt/FloatTag.java

@@ -36,7 +36,7 @@ public final class FloatTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Float" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/jnbt/IntArrayTag.java

@@ -48,7 +48,7 @@ public final class IntArrayTag extends Tag {
         }
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Int_Array" + append + ": " + hex;

Core/src/main/java/com/intellectualcrafters/jnbt/IntTag.java

@@ -36,7 +36,7 @@ public final class IntTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Int" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/jnbt/ListTag.java

@@ -378,7 +378,7 @@ public final class ListTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         StringBuilder bldr = new StringBuilder();

Core/src/main/java/com/intellectualcrafters/jnbt/ListTagBuilder.java

@@ -23,7 +23,7 @@ public class ListTagBuilder {
     ListTagBuilder(Class<? extends Tag> type) {
         checkNotNull(type);
         this.type = type;
-        this.entries = new ArrayList<Tag>();
+        this.entries = new ArrayList<>();
     }
 
     /**

Core/src/main/java/com/intellectualcrafters/jnbt/LongTag.java

@@ -36,7 +36,7 @@ public final class LongTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Long" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/jnbt/NBTConstants.java

@@ -16,8 +16,7 @@ public final class NBTConstants {
     /**
      * Default private constructor.
      */
-    private NBTConstants() {
-    }
+    private NBTConstants() {}
 
     /**
      * Convert a type ID to its corresponding {@link Tag} class.

Core/src/main/java/com/intellectualcrafters/jnbt/NBTUtils.java

@@ -10,8 +10,7 @@ public final class NBTUtils {
     /**
      * Default private constructor.
      */
-    private NBTUtils() {
-    }
+    private NBTUtils() {}
 
     /**
      * Gets the type name of a tag.

Core/src/main/java/com/intellectualcrafters/jnbt/ShortTag.java

@@ -36,7 +36,7 @@ public final class ShortTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_Short" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/jnbt/StringTag.java

@@ -40,7 +40,7 @@ public final class StringTag extends Tag {
     public String toString() {
         String name = getName();
         String append = "";
-        if (name != null && !name.equals("")) {
+        if (name != null && !name.isEmpty()) {
             append = "(\"" + getName() + "\")";
         }
         return "TAG_String" + append + ": " + this.value;

Core/src/main/java/com/intellectualcrafters/json/JSONObject.java

@@ -88,8 +88,7 @@ public class JSONObject {
         for (String name : names) {
             try {
                 putOnce(name, jo.opt(name));
-            } catch (JSONException ignore) {
-            }
+            } catch (JSONException ignore) {}
         }
     }
     
@@ -194,8 +193,7 @@ public class JSONObject {
         for (String name : names) {
             try {
                 putOpt(name, c.getField(name).get(object));
-            } catch (JSONException | SecurityException | NoSuchFieldException | IllegalArgumentException | IllegalAccessException ignore) {
-            }
+            } catch (JSONException | SecurityException | NoSuchFieldException | IllegalArgumentException | IllegalAccessException ignore) {}
         }
     }
     
@@ -461,8 +459,7 @@ public class JSONObject {
                         }
                     }
                 }
-            } catch (NumberFormatException ignore) {
-            }
+            } catch (NumberFormatException ignore) {}
         }
         return string;
     }
@@ -586,7 +583,7 @@ public class JSONObject {
                 return object.toString();
             }
             return new JSONObject(object);
-        } catch (JSONException exception) {
+        } catch (JSONException ignored) {
             return null;
         }
     }
@@ -734,7 +731,7 @@ public class JSONObject {
         Object object = get(key);
         try {
             return object instanceof Number ? ((Number) object).doubleValue() : Double.parseDouble((String) object);
-        } catch (NumberFormatException e) {
+        } catch (NumberFormatException ignored) {
             throw new JSONException("JSONObject[" + quote(key) + "] is not a number.");
         }
     }
@@ -752,7 +749,7 @@ public class JSONObject {
         Object object = get(key);
         try {
             return object instanceof Number ? ((Number) object).intValue() : Integer.parseInt((String) object);
-        } catch (NumberFormatException e) {
+        } catch (NumberFormatException ignored) {
             throw new JSONException("JSONObject[" + quote(key) + "] is not an int.");
         }
     }
@@ -804,7 +801,7 @@ public class JSONObject {
         Object object = get(key);
         try {
             return object instanceof Number ? ((Number) object).longValue() : Long.parseLong((String) object);
-        } catch (NumberFormatException e) {
+        } catch (NumberFormatException ignored) {
             throw new JSONException("JSONObject[" + quote(key) + "] is not a long.");
         }
     }
@@ -953,7 +950,7 @@ public class JSONObject {
     public boolean optBoolean(String key, boolean defaultValue) {
         try {
             return getBoolean(key);
-        } catch (JSONException e) {
+        } catch (JSONException ignored) {
             return defaultValue;
         }
     }
@@ -982,7 +979,7 @@ public class JSONObject {
     public double optDouble(String key, double defaultValue) {
         try {
             return getDouble(key);
-        } catch (JSONException e) {
+        } catch (JSONException ignored) {
             return defaultValue;
         }
     }
@@ -1011,7 +1008,7 @@ public class JSONObject {
     public int optInt(String key, int defaultValue) {
         try {
             return getInt(key);
-        } catch (JSONException e) {
+        } catch (JSONException ignored) {
             return defaultValue;
         }
     }
@@ -1066,7 +1063,7 @@ public class JSONObject {
     public long optLong(String key, long defaultValue) {
         try {
             return getLong(key);
-        } catch (JSONException e) {
+        } catch (JSONException ignored) {
             return defaultValue;
         }
     }
@@ -1127,8 +1124,7 @@ public class JSONObject {
                         }
                     }
                 }
-            } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException ignore) {
-            }
+            } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException ignore) {}
         }
     }
     
@@ -1330,7 +1326,7 @@ public class JSONObject {
                 }
             }
             return true;
-        } catch (Throwable exception) {
+        } catch (JSONException ignored) {
             return false;
         }
     }
@@ -1370,7 +1366,7 @@ public class JSONObject {
     public String toString() {
         try {
             return this.toString(0);
-        } catch (JSONException e) {
+        } catch (JSONException ignored) {
             return null;
         }
     }
@@ -1476,7 +1472,7 @@ public class JSONObject {
         protected final Object clone() {
             try {
                 return super.clone();
-            } catch (CloneNotSupportedException e) {
+            } catch (CloneNotSupportedException ignored) {
                 return this;
             }
         }

Core/src/main/java/com/intellectualcrafters/json/JSONString.java

@@ -12,5 +12,5 @@ public interface JSONString {
      *
      * @return A strictly syntactically correct JSON text.
      */
-    public String toJSONString();
+    String toJSONString();
 }

Core/src/main/java/com/intellectualcrafters/json/JSONTokener.java

@@ -342,7 +342,7 @@ public class JSONTokener {
         }
         back();
         string = sb.toString().trim();
-        if (string != null && string.isEmpty()) {
+        if (string.isEmpty()) {
             throw syntaxError("Missing value");
         }
         return JSONObject.stringToValue(string);
@@ -370,7 +370,7 @@ public class JSONTokener {
                     index = startIndex;
                     character = startCharacter;
                     line = startLine;
-                    return c;
+                    return 0;
                 }
             } while (c != to);
         } catch (final IOException exception) {

Core/src/main/java/com/intellectualcrafters/json/XML.java

@@ -245,8 +245,7 @@ class XML {
                 if (value.toString().equals(string)) {
                     return value;
                 }
-            } catch (NumberFormatException ignored) {
-            }
+            } catch (NumberFormatException ignored) {}
         }
         return string;
     }

Core/src/main/java/com/intellectualcrafters/plot/PS.java

@@ -137,7 +137,7 @@ public class PS {
             try {
                 URL url = PS.class.getProtectionDomain().getCodeSource().getLocation();
                 this.file = new File(new URL(url.toURI().toString().split("\\!")[0].replaceAll("jar:file", "file")).toURI().getPath());
-            } catch (MalformedURLException | URISyntaxException | SecurityException | NullPointerException e) {
+            } catch (MalformedURLException | URISyntaxException | SecurityException e) {
                 e.printStackTrace();
                 this.file = new File(this.IMP.getDirectory().getParentFile(), "PlotSquared.jar");
                 if (!this.file.exists()) {
@@ -489,11 +489,10 @@ public class PS {
             return areas[0];
         } else if (id == null) {
             return null;
-        } else {
-            for (PlotArea area : areas) {
-                if (StringMan.isEqual(id, area.id)) {
-                    return area;
-                }
+        }
+        for (PlotArea area : areas) {
+            if (StringMan.isEqual(id, area.id)) {
+                return area;
             }
         }
         return null;
@@ -830,7 +829,7 @@ public class PS {
         return result;
     }
 
-    public ArrayList<Plot> sortPlotsByTemp(Collection<Plot> plots) {
+    public List<Plot> sortPlotsByTemp(Collection<Plot> plots) {
         int max = 0;
         int overflowCount = 0;
         for (Plot plot : plots) {
@@ -1474,7 +1473,7 @@ public class PS {
                 return;
             }
             if (type == 1) {
-                throw new IllegalArgumentException("Invalid type for multi-area world. Expected `2`, got `" + type + "`");
+                throw new IllegalArgumentException("Invalid type for multi-area world. Expected `2`, got `" + 1 + "`");
             }
             for (String areaId : areasSection.getKeys(false)) {
                 PS.log(C.PREFIX + "&3 - " + areaId);
@@ -1762,7 +1761,7 @@ public class PS {
             // Close the connection
             DBFunc.close();
             UUIDHandler.handleShutdown();
-        } catch (NullPointerException e) {
+        } catch (NullPointerException ignored) {
             PS.log("&cCould not close database connection!");
         }
     }
@@ -2100,7 +2099,7 @@ public class PS {
             }
             this.config = YamlConfiguration.loadConfiguration(this.configFile);
             setupConfig();
-        } catch (IOException err_trans) {
+        } catch (IOException ignored) {
             PS.log("Failed to save settings.yml");
         }
         try {
@@ -2112,7 +2111,7 @@ public class PS {
             }
             this.storage = YamlConfiguration.loadConfiguration(this.storageFile);
             setupStorage();
-        } catch (IOException err_trans) {
+        } catch (IOException ignored) {
             PS.log("Failed to save storage.yml");
         }
         try {
@@ -2124,7 +2123,7 @@ public class PS {
             }
             this.commands = YamlConfiguration.loadConfiguration(this.commandsFile);
             setupStorage();
-        } catch (IOException err_trans) {
+        } catch (IOException ignored) {
             PS.log("Failed to save commands.yml");
         }
         try {

Core/src/main/java/com/intellectualcrafters/plot/commands/Area.java

@@ -112,7 +112,7 @@ public class Area extends SubCommand {
                                 object.plotManager = "PlotSquared";
                                 object.setupGenerator = "PlotSquared";
                                 object.step = area.getSettingNodes();
-                                final String path = "worlds." + area.worldname + ".areas." + area.id + "-" + object.min + "-" + object.max;
+                                final String path = "worlds." + area.worldname + ".areas." + area.id + '-' + object.min + '-' + object.max;
                                 Runnable run = new Runnable() {
                                     @Override
                                     public void run() {
@@ -254,7 +254,7 @@ public class Area extends SubCommand {
                                 }
                             };
                             if (hasConfirmation(player)) {
-                                CmdConfirm.addPending(player, getCommandString() + " " + StringMan.join(args, " "), run);
+                                CmdConfirm.addPending(player, getCommandString() + ' ' + StringMan.join(args, " "), run);
                             } else {
                                 run.run();
                             }
@@ -310,11 +310,11 @@ public class Area extends SubCommand {
                 int claimed = area.getPlotCount();
                 int clusters = area.getClusters().size();
                 String region;
-                String generator = area.getGenerator() + "";
+                String generator = String.valueOf(area.getGenerator());
                 if (area.TYPE == 2) {
                     PlotId min = area.getMin();
                     PlotId max = area.getMax();
-                    name = area.worldname + ";" + area.id + ";" + min + ";" + max;
+                    name = area.worldname + ';' + area.id + ';' + min + ';' + max;
                     int size = (max.x - min.x + 1) * (max.y - min.y + 1);
                     percent = claimed == 0 ? 0 : size / (double) claimed;
                     region = area.getRegion().toString();
@@ -326,7 +326,7 @@ public class Area extends SubCommand {
                 String value = "&r$1NAME: " + name
                         + "\n$1Type: $2" + area.TYPE
                         + "\n$1Terrain: $2" + area.TERRAIN
-                        + "\n$1Usage: $2" + String.format("%.2f", percent) + "%"
+                        + "\n$1Usage: $2" + String.format("%.2f", percent) + '%'
                         + "\n$1Claimed: $2" + claimed
                         + "\n$1Clusters: $2" + clusters
                         + "\n$1Region: $2" + region
@@ -363,11 +363,11 @@ public class Area extends SubCommand {
                         int claimed = area.getPlotCount();
                         int clusters = area.getClusters().size();
                         String region;
-                        String generator = area.getGenerator() + "";
+                        String generator = String.valueOf(area.getGenerator());
                         if (area.TYPE == 2) {
                             PlotId min = area.getMin();
                             PlotId max = area.getMax();
-                            name = area.worldname + ";" + area.id + ";" + min + ";" + max;
+                            name = area.worldname + ';' + area.id + ';' + min + ';' + max;
                             int size = (max.x - min.x + 1) * (max.y - min.y + 1);
                             percent = claimed == 0 ? 0 : size / (double) claimed;
                             region = area.getRegion().toString();
@@ -377,18 +377,18 @@ public class Area extends SubCommand {
                             region = "N/A";
                         }
                         PlotMessage tooltip = new PlotMessage()
-                                .text("Claimed=").color("$1").text("" + claimed).color("$2")
-                                .text("\nUsage=").color("$1").text(String.format("%.2f", percent) + "%").color("$2")
-                                .text("\nClusters=").color("$1").text("" + clusters).color("$2")
+                                .text("Claimed=").color("$1").text(String.valueOf(claimed)).color("$2")
+                                .text("\nUsage=").color("$1").text(String.format("%.2f", percent) + '%').color("$2")
+                                .text("\nClusters=").color("$1").text(String.valueOf(clusters)).color("$2")
                                 .text("\nRegion=").color("$1").text(region).color("$2")
                                 .text("\nGenerator=").color("$1").text(generator).color("$2");
 
                         // type / terrain
                         String visit = "/plot area tp " + area.toString();
                         message.text("[").color("$3")
-                                .text(i + "").command(visit).tooltip(visit).color("$1")
+                                .text(String.valueOf(i)).command(visit).tooltip(visit).color("$1")
                                 .text("]").color("$3")
-                                .text(" " + name).tooltip(tooltip).command(getCommandString() + " info " + area).color("$1").text(" - ")
+                                .text(' ' + name).tooltip(tooltip).command(getCommandString() + " info " + area).color("$1").text(" - ")
                                 .color("$2")
                                 .text(area.TYPE + ":" + area.TERRAIN).color("$3");
                     }

Core/src/main/java/com/intellectualcrafters/plot/commands/Auto.java

@@ -72,7 +72,7 @@ public class Auto extends SubCommand {
                     if (args.length > 1) {
                         schematic = args[1];
                     }
-                } catch (NumberFormatException e) {
+                } catch (NumberFormatException ignored) {
                     size_x = 1;
                     size_z = 1;
                     schematic = args[0];

Core/src/main/java/com/intellectualcrafters/plot/commands/Buy.java

@@ -43,7 +43,7 @@ public class Buy extends SubCommand {
                     return false;
                 }
                 plots = plot.getConnectedPlots();
-            } catch (Exception e) {
+            } catch (Exception ignored) {
                 return sendMessage(plr, C.NOT_VALID_PLOT_ID);
             }
         } else {

Core/src/main/java/com/intellectualcrafters/plot/commands/Continue.java

@@ -27,7 +27,7 @@ public class Continue extends SubCommand {
             MainUtil.sendMessage(plr, C.NO_PLOT_PERMS);
             return false;
         }
-        if (!plot.getFlags().containsKey("done")) {
+        if (!plot.hasFlag(Flags.DONE)) {
             MainUtil.sendMessage(plr, C.DONE_NOT_DONE);
             return false;
         }

Core/src/main/java/com/intellectualcrafters/plot/commands/Database.java

@@ -18,6 +18,7 @@ import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map.Entry;
 
 @CommandDeclaration(
@@ -30,7 +31,7 @@ import java.util.Map.Entry;
         usage = "/plots database [area] <sqlite|mysql|import>")
 public class Database extends SubCommand {
 
-    public static void insertPlots(final SQLManager manager, final ArrayList<Plot> plots, final PlotPlayer player) {
+    public static void insertPlots(final SQLManager manager, final List<Plot> plots, final PlotPlayer player) {
         TaskManager.runTaskAsync(new Runnable() {
             @Override
             public void run() {
@@ -61,7 +62,7 @@ public class Database extends SubCommand {
             MainUtil.sendMessage(player, "/plot database [area] <sqlite|mysql|import>");
             return false;
         }
-        ArrayList<Plot> plots;
+        List<Plot> plots;
         PlotArea area = PS.get().getPlotAreaByString(args[0]);
         if (area != null) {
             plots = PS.get().sortPlotsByTemp(area.getPlots());

Core/src/main/java/com/intellectualcrafters/plot/commands/DebugClaimTest.java

@@ -92,7 +92,7 @@ public class DebugClaimTest extends SubCommand {
                     }
                     if (uuid != null) {
                         MainUtil.sendMessage(plr, " - &aFound plot: " + plot.getId() + " : " + line);
-                        plot.owner = uuid;
+                        plot.setOwner(uuid);
                         plots.add(plot);
                     } else {
                         MainUtil.sendMessage(plr, " - &cInvalid PlayerName: " + plot.getId() + " : " + line);

Core/src/main/java/com/intellectualcrafters/plot/commands/DebugExec.java

@@ -80,8 +80,7 @@ public class DebugExec extends SubCommand {
                     this.engine.eval(script, this.scope);
                 }
             }
-        } catch (IOException | ScriptException ignored) {
-        }
+        } catch (IOException | ScriptException ignored) {}
     }
 
     public ScriptEngine getEngine() {
@@ -360,12 +359,7 @@ public class DebugExec extends SubCommand {
                         @Override
                         public void run(Integer i, File file, PlotMessage message) {
                             String name = file.getName();
-
-                            message.text("[").color("$3")
-                                    .text(i + "").color("$1")
-                                    .text("]").color("$3")
-                                    .text(" " + name).color("$1");
-
+                            message.text("[").color("$3").text(String.valueOf(i)).color("$1").text("]").color("$3").text(' ' + name).color("$1");
                         }
                     }, "/plot debugexec list-scripts", "List of scripts");
                     return true;

Core/src/main/java/com/intellectualcrafters/plot/commands/Delete.java

@@ -12,8 +12,6 @@ import com.intellectualcrafters.plot.util.Permissions;
 import com.intellectualcrafters.plot.util.TaskManager;
 import com.plotsquared.general.commands.CommandDeclaration;
 
-import java.util.HashSet;
-
 @CommandDeclaration(
         command = "delete",
         permission = "plots.delete",
@@ -40,7 +38,7 @@ public class Delete extends SubCommand {
             return !sendMessage(plr, C.NO_PLOT_PERMS);
         }
         final PlotArea plotworld = plot.getArea();
-        final HashSet<Plot> plots = plot.getConnectedPlots();
+        final java.util.Set<Plot> plots = plot.getConnectedPlots();
         Runnable run = new Runnable() {
             @Override
             public void run() {
@@ -57,7 +55,7 @@ public class Delete extends SubCommand {
                             double value = plotworld.PRICES.get("sell") * plots.size();
                             if (value > 0d) {
                                 EconHandler.manager.depositMoney(plr, value);
-                                sendMessage(plr, C.ADDED_BALANCE, value + "");
+                                sendMessage(plr, C.ADDED_BALANCE, String.valueOf(value));
                             }
                         }
                         MainUtil.sendMessage(plr, C.CLEARING_DONE, System.currentTimeMillis() - start);

Core/src/main/java/com/intellectualcrafters/plot/commands/Done.java

@@ -2,8 +2,6 @@ package com.intellectualcrafters.plot.commands;
 
 import com.intellectualcrafters.plot.config.C;
 import com.intellectualcrafters.plot.config.Settings;
-import com.intellectualcrafters.plot.flag.Flag;
-import com.intellectualcrafters.plot.flag.FlagManager;
 import com.intellectualcrafters.plot.flag.Flags;
 import com.intellectualcrafters.plot.generator.HybridUtils;
 import com.intellectualcrafters.plot.object.Location;
@@ -34,7 +32,7 @@ public class Done extends SubCommand {
             MainUtil.sendMessage(plr, C.NO_PLOT_PERMS);
             return false;
         }
-        if (plot.getFlags().containsKey("done")) {
+        if (plot.hasFlag(Flags.DONE)) {
             MainUtil.sendMessage(plr, C.DONE_ALREADY_DONE);
             return false;
         }
@@ -50,8 +48,7 @@ public class Done extends SubCommand {
                 plot.removeRunning();
                 if ((value == null) || (value.getComplexity() >= Settings.CLEAR_THRESHOLD)) {
                     long flagValue = System.currentTimeMillis() / 1000;
-                    Flag flag = Flags.DONE;
-                    FlagManager.addPlotFlag(plot, flag, flagValue);
+                    plot.setFlag(Flags.DONE,flagValue);
                     MainUtil.sendMessage(plr, C.DONE_SUCCESS);
                 } else {
                     MainUtil.sendMessage(plr, C.DONE_INSUFFICIENT_COMPLEXITY);

Core/src/main/java/com/intellectualcrafters/plot/commands/FlagCmd.java

@@ -31,11 +31,6 @@ import java.util.Map;
         permission = "plots.flag")
 public class FlagCmd extends SubCommand {
 
-    @Override
-    public String getUsage() {
-        return super.getUsage();
-    }
-
     @Override
     public boolean onCommand(PlotPlayer player, String[] args) {
 

Core/src/main/java/com/intellectualcrafters/plot/commands/GenerateDocs.java

@@ -5,6 +5,7 @@ import com.intellectualcrafters.plot.util.StringMan;
 import com.plotsquared.general.commands.Command;
 
 import java.io.File;
+import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.util.ArrayList;
@@ -58,7 +59,7 @@ public class GenerateDocs {
             String comment = GenerateDocs.getComments(lines);
 
             GenerateDocs.log("#### Description");
-            GenerateDocs.log("`" + command.getDescription() + "`");
+            GenerateDocs.log('`' + command.getDescription() + '`');
             if (!comment.isEmpty()) {
                 GenerateDocs.log("##### Comments");
                 GenerateDocs.log("``` java");
@@ -76,18 +77,18 @@ public class GenerateDocs {
                 GenerateDocs.log(" - `" + StringMan.join(usages, "`\n - `") + "`    ");
                 GenerateDocs.log("");
             } else {
-                GenerateDocs.log("`" + mainUsage + "`    ");
+                GenerateDocs.log('`' + mainUsage + "`    ");
             }
 
             if (command.getRequiredType() != RequiredType.NONE) {
                 GenerateDocs.log("#### Required callers");
-                GenerateDocs.log("`" + command.getRequiredType().name() + "`");
+                GenerateDocs.log('`' + command.getRequiredType().name() + '`');
             }
 
             List<String> aliases = command.getAliases();
             if (!aliases.isEmpty()) {
                 GenerateDocs.log("#### Aliases");
-                GenerateDocs.log("`" + StringMan.getString(command.getAliases()) + "`");
+                GenerateDocs.log('`' + StringMan.getString(command.getAliases()) + '`');
             }
 
             GenerateDocs.log("#### Permissions");
@@ -96,21 +97,21 @@ public class GenerateDocs {
                 GenerateDocs.log(" - `" + command.getPermission() + "`    ");
                 GenerateDocs.log("");
                 GenerateDocs.log("##### Other");
-                GenerateDocs.log(" - `" + StringMan.join(perms, "`\n - `") + "`");
+                GenerateDocs.log(" - `" + StringMan.join(perms, "`\n - `") + '`');
                 GenerateDocs.log("");
             } else {
-                GenerateDocs.log("`" + command.getPermission() + "`    ");
+                GenerateDocs.log('`' + command.getPermission() + "`    ");
             }
             GenerateDocs.log("***");
             GenerateDocs.log("");
-        } catch (Exception e) {
+        } catch (IOException e) {
             e.printStackTrace();
         }
     }
 
     public static List<String> getUsage(String cmd, List<String> lines) {
         Pattern p = Pattern.compile("\"([^\"]*)\"");
-        HashSet<String> usages = new HashSet<String>();
+        HashSet<String> usages = new HashSet<>();
         for (String line : lines) {
             if (line.contains("COMMAND_SYNTAX") && !line.contains("getUsage()")) {
                 Matcher m = p.matcher(line);
@@ -203,7 +204,7 @@ public class GenerateDocs {
             line = line.trim();
             if (line.startsWith("/** ") || line.startsWith("*/ ") || line.startsWith("* ")) {
                 line = line.replaceAll("/[*][*] ", "").replaceAll("[*]/ ", "").replaceAll("[*] ", "").trim();
-                result.append(line + "\n");
+                result.append(line + '\n');
             }
         }
         return result.toString().trim();

Core/src/main/java/com/intellectualcrafters/plot/commands/ListCmd.java

@@ -101,7 +101,7 @@ public class ListCmd extends SubCommand {
                 if (page < 0) {
                     page = 0;
                 }
-            } catch (Exception e) {
+            } catch (NumberFormatException ignored) {
                 page = -1;
             }
         }
@@ -245,12 +245,10 @@ public class ListCmd extends SubCommand {
                 }
                 plots = new ArrayList<>();
                 for (Plot plot : PS.get().getPlots()) {
-/*
-                    Flag price = FlagManager.getPlotFlagRaw(plot, "price");
-                    if (price != null) {
+                    Optional<Double> price = plot.getFlag(Flags.PRICE);
+                    if (price.isPresent()) {
                         plots.add(plot);
                     }
-*/
                 }
                 break;
             case "unowned":
@@ -315,8 +313,7 @@ public class ListCmd extends SubCommand {
                 if (uuid == null) {
                     try {
                         uuid = UUID.fromString(args[0]);
-                    } catch (Exception ignored) {
-                    }
+                    } catch (Exception ignored) {}
                 }
                 if (uuid != null) {
                     if (!Permissions.hasPermission(plr, "plots.list.player")) {

Core/src/main/java/com/intellectualcrafters/plot/commands/Load.java

@@ -68,14 +68,14 @@ public class Load extends SubCommand {
                 String schematic;
                 try {
                     schematic = schematics.get(Integer.parseInt(args[0]) - 1);
-                } catch (NumberFormatException e) {
+                } catch (NumberFormatException ignored) {
                     // use /plot load <index>
-                    MainUtil.sendMessage(plr, C.NOT_VALID_NUMBER, "(1, " + schematics.size() + ")");
+                    MainUtil.sendMessage(plr, C.NOT_VALID_NUMBER, "(1, " + schematics.size() + ')');
                     return false;
                 }
                 final URL url;
                 try {
-                    url = new URL(Settings.WEB_URL + "saves/" + plr.getUUID() + "/" + schematic + ".schematic");
+                    url = new URL(Settings.WEB_URL + "saves/" + plr.getUUID() + '/' + schematic + ".schematic");
                 } catch (MalformedURLException e) {
                     e.printStackTrace();
                     MainUtil.sendMessage(plr, C.LOAD_FAILED);
@@ -147,7 +147,7 @@ public class Load extends SubCommand {
                 }
                 String time = secToTime((System.currentTimeMillis() / 1000) - Long.parseLong(split[0]));
                 String world = split[1];
-                PlotId id = PlotId.fromString(split[2] + ";" + split[3]);
+                PlotId id = PlotId.fromString(split[2] + ';' + split[3]);
                 String size = split[4];
                 String server = split[5].replaceAll(".schematic", "");
                 String color;
@@ -157,7 +157,7 @@ public class Load extends SubCommand {
                     color = "$1";
                 }
                 MainUtil.sendMessage(player,
-                        "$3[$2" + (i + 1) + "$3] " + color + time + "$3 | " + color + world + ";" + id + "$3 | " + color + size + "x" + size);
+                        "$3[$2" + (i + 1) + "$3] " + color + time + "$3 | " + color + world + ';' + id + "$3 | " + color + size + 'x' + size);
             } catch (Exception e) {
                 e.printStackTrace();
             }

Core/src/main/java/com/intellectualcrafters/plot/commands/Merge.java

@@ -14,7 +14,6 @@ import com.intellectualcrafters.plot.util.StringMan;
 import com.intellectualcrafters.plot.util.UUIDHandler;
 import com.plotsquared.general.commands.CommandDeclaration;
 
-import java.util.HashSet;
 import java.util.UUID;
 
 @CommandDeclaration(command = "merge",
@@ -74,7 +73,7 @@ public class Merge extends SubCommand {
         final PlotArea plotworld = plot.getArea();
         final double price = plotworld.PRICES.containsKey("merge") ? plotworld.PRICES.get("merge") : 0;
         if (EconHandler.manager != null && plotworld.USE_ECONOMY && price > 0d && EconHandler.manager.getMoney(plr) < price) {
-            sendMessage(plr, C.CANNOT_AFFORD_MERGE, price + "");
+            sendMessage(plr, C.CANNOT_AFFORD_MERGE, String.valueOf(price));
             return false;
         }
         final int size = plot.getConnectedPlots().size();
@@ -108,7 +107,7 @@ public class Merge extends SubCommand {
                 if (plot.autoMerge(-1, maxSize, uuid, terrain)) {
                     if (EconHandler.manager != null && plotworld.USE_ECONOMY && price > 0d) {
                         EconHandler.manager.withdrawMoney(plr, price);
-                        sendMessage(plr, C.REMOVED_BALANCE, price + "");
+                        sendMessage(plr, C.REMOVED_BALANCE, String.valueOf(price));
                     }
                     MainUtil.sendMessage(plr, C.SUCCESS_MERGE);
                     return true;
@@ -138,7 +137,7 @@ public class Merge extends SubCommand {
         if (plot.autoMerge(direction, maxSize - size, uuid, terrain)) {
             if (EconHandler.manager != null && plotworld.USE_ECONOMY && price > 0d) {
                 EconHandler.manager.withdrawMoney(plr, price);
-                sendMessage(plr, C.REMOVED_BALANCE, price + "");
+                sendMessage(plr, C.REMOVED_BALANCE, String.valueOf(price));
             }
             MainUtil.sendMessage(plr, C.SUCCESS_MERGE);
             return true;
@@ -152,7 +151,7 @@ public class Merge extends SubCommand {
             MainUtil.sendMessage(plr, C.NO_PERMISSION, C.PERMISSION_MERGE_OTHER);
             return false;
         }
-        HashSet<UUID> uuids = adjacent.getOwners();
+        java.util.Set<UUID> uuids = adjacent.getOwners();
         boolean isOnline = false;
         for (final UUID owner : uuids) {
             final PlotPlayer accepter = UUIDHandler.getPlayer(owner);
@@ -173,11 +172,11 @@ public class Merge extends SubCommand {
                     }
                     if (EconHandler.manager != null && plotworld.USE_ECONOMY && price > 0d) {
                         if (EconHandler.manager.getMoney(plr) < price) {
-                            sendMessage(plr, C.CANNOT_AFFORD_MERGE, price + "");
+                            sendMessage(plr, C.CANNOT_AFFORD_MERGE, String.valueOf(price));
                             return;
                         }
                         EconHandler.manager.withdrawMoney(plr, price);
-                        sendMessage(plr, C.REMOVED_BALANCE, price + "");
+                        sendMessage(plr, C.REMOVED_BALANCE, String.valueOf(price));
                     }
                     MainUtil.sendMessage(plr, C.SUCCESS_MERGE);
                 }

Core/src/main/java/com/intellectualcrafters/plot/commands/Owner.java

@@ -11,7 +11,7 @@ import com.intellectualcrafters.plot.util.TaskManager;
 import com.intellectualcrafters.plot.util.UUIDHandler;
 import com.plotsquared.general.commands.CommandDeclaration;
 
-import java.util.HashSet;
+import java.util.Set;
 import java.util.UUID;
 
 @CommandDeclaration(
@@ -27,15 +27,14 @@ public class Owner extends SetCommand {
 
     @Override
     public boolean set(final PlotPlayer plr, final Plot plot, String value) {
-        HashSet<Plot> plots = plot.getConnectedPlots();
+        Set<Plot> plots = plot.getConnectedPlots();
         UUID uuid = null;
         String name = null;
         if (value.length() == 36) {
             try {
                 uuid = UUID.fromString(value);
                 name = MainUtil.getName(uuid);
-            } catch (Exception ignored) {
-            }
+            } catch (Exception ignored) {}
         } else {
             uuid = UUIDHandler.getUUID(value, null);
             name = UUIDHandler.getName(uuid);
@@ -43,7 +42,7 @@ public class Owner extends SetCommand {
         }
         if (uuid == null) {
             if (value.equalsIgnoreCase("none")) {
-                HashSet<Plot> connected = plot.getConnectedPlots();
+                Set<Plot> connected = plot.getConnectedPlots();
                 plot.unlinkPlot(false, false);
                 for (Plot current : connected) {
                     current.unclaim();

Core/src/main/java/com/intellectualcrafters/plot/commands/Rate.java

@@ -4,6 +4,7 @@ import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.config.C;
 import com.intellectualcrafters.plot.config.Settings;
 import com.intellectualcrafters.plot.database.DBFunc;
+import com.intellectualcrafters.plot.flag.Flags;
 import com.intellectualcrafters.plot.object.Plot;
 import com.intellectualcrafters.plot.object.PlotInventory;
 import com.intellectualcrafters.plot.object.PlotItemStack;
@@ -61,7 +62,7 @@ public class Rate extends SubCommand {
                 });
                 UUID uuid = player.getUUID();
                 for (Plot p : plots) {
-                    if ((!Settings.REQUIRE_DONE || p.getFlags().containsKey("done")) && p.isBasePlot() && (p.hasRatings() || !p.getRatings()
+                    if ((!Settings.REQUIRE_DONE || p.hasFlag(Flags.DONE)) && p.isBasePlot() && (p.hasRatings() || !p.getRatings()
                             .containsKey(uuid)) && !p.isAdded(uuid)) {
                         p.teleportPlayer(player);
                         MainUtil.sendMessage(player, C.RATE_THIS);
@@ -84,7 +85,7 @@ public class Rate extends SubCommand {
             sendMessage(player, C.RATING_NOT_YOUR_OWN);
             return false;
         }
-        if (Settings.REQUIRE_DONE && !plot.getFlags().containsKey("done")) {
+        if (Settings.REQUIRE_DONE && !plot.hasFlag(Flags.DONE)) {
             sendMessage(player, C.RATING_NOT_DONE);
             return false;
         }

Core/src/main/java/com/intellectualcrafters/plot/commands/RegenAllRoads.java

@@ -47,7 +47,7 @@ public class RegenAllRoads extends SubCommand {
         }
         String name = args[0];
         PlotManager manager = area.getPlotManager();
-        if ((manager == null) || !(manager instanceof HybridPlotManager)) {
+        if (!(manager instanceof HybridPlotManager)) {
             MainUtil.sendMessage(plr, C.NOT_VALID_PLOT_WORLD);
             return false;
         }

Core/src/main/java/com/intellectualcrafters/plot/commands/Reload.java

@@ -1,6 +1,7 @@
 package com.intellectualcrafters.plot.commands;
 
 import com.intellectualcrafters.configuration.ConfigurationSection;
+import com.intellectualcrafters.configuration.InvalidConfigurationException;
 import com.intellectualcrafters.configuration.MemorySection;
 import com.intellectualcrafters.configuration.file.YamlConfiguration;
 import com.intellectualcrafters.plot.PS;
@@ -11,6 +12,7 @@ import com.intellectualcrafters.plot.object.RunnableVal;
 import com.intellectualcrafters.plot.util.MainUtil;
 import com.plotsquared.general.commands.CommandDeclaration;
 
+import java.io.IOException;
 import java.util.Objects;
 
 @CommandDeclaration(command = "reload",
@@ -77,7 +79,7 @@ public class Reload extends SubCommand {
             });
             PS.get().config.save(PS.get().configFile);
             MainUtil.sendMessage(plr, C.RELOADED_CONFIGS);
-        } catch (Exception e) {
+        } catch (InvalidConfigurationException | IOException e) {
             e.printStackTrace();
             MainUtil.sendMessage(plr, C.RELOAD_FAILED);
         }

Core/src/main/java/com/intellectualcrafters/plot/commands/Setup.java

@@ -65,8 +65,8 @@ public class Setup extends SubCommand {
                 if (object.setup_index > 0) {
                     object.setup_index--;
                     ConfigurationNode node = object.step[object.setup_index];
-                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1 + "", node.getDescription(), node.getType().getType(),
-                            node.getDefaultValue() + "");
+                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1, node.getDescription(), node.getType().getType(),
+                            String.valueOf(node.getDefaultValue()));
                     return false;
                 } else if (object.current > 0) {
                     object.current--;
@@ -127,8 +127,8 @@ public class Setup extends SubCommand {
                         return true;
                     }
                     ConfigurationNode step = object.step[object.setup_index];
-                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1 + "", step.getDescription(), step.getType().getType(),
-                            step.getDefaultValue() + "");
+                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1, step.getDescription(), step.getType().getType(),
+                            String.valueOf(step.getDefaultValue()));
                 } else {
                     if (gen.isFull()) {
                         object.plotManager = object.setupGenerator;
@@ -216,8 +216,8 @@ public class Setup extends SubCommand {
                             .getNewPlotArea("CheckingPlotSquaredGenerator", null, null, null).getSettingNodes();
                 }
                 ConfigurationNode step = object.step[object.setup_index];
-                sendMessage(plr, C.SETUP_STEP, object.setup_index + 1 + "", step.getDescription(), step.getType().getType(),
-                        step.getDefaultValue() + "");
+                sendMessage(plr, C.SETUP_STEP, object.setup_index + 1, step.getDescription(), step.getType().getType(),
+                        String.valueOf(step.getDefaultValue()));
                 break;
             }
             case 6:  // world setup
@@ -229,8 +229,8 @@ public class Setup extends SubCommand {
                 }
                 ConfigurationNode step = object.step[object.setup_index];
                 if (args.length < 1) {
-                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1 + "", step.getDescription(), step.getType().getType(),
-                            step.getDefaultValue() + "");
+                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1, step.getDescription(), step.getType().getType(),
+                            String.valueOf(step.getDefaultValue()));
                     return false;
                 }
                 boolean valid = step.isValid(args[0]);
@@ -243,13 +243,13 @@ public class Setup extends SubCommand {
                         return false;
                     }
                     step = object.step[object.setup_index];
-                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1 + "", step.getDescription(), step.getType().getType(),
-                            step.getDefaultValue() + "");
+                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1, step.getDescription(), step.getType().getType(),
+                            String.valueOf(step.getDefaultValue()));
                     return false;
                 } else {
                     sendMessage(plr, C.SETUP_INVALID_ARG, args[0], step.getConstant());
-                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1 + "", step.getDescription(), step.getType().getType(),
-                            step.getDefaultValue() + "");
+                    sendMessage(plr, C.SETUP_STEP, object.setup_index + 1, step.getDescription(), step.getType().getType(),
+                            String.valueOf(step.getDefaultValue()));
                     return false;
                 }
             case 7:

Core/src/main/java/com/intellectualcrafters/plot/commands/Trim.java

@@ -52,15 +52,7 @@ public class Trim extends SubCommand {
                     String name = file.getName();
                     if (name.endsWith("mca")) {
                         if (file.getTotalSpace() <= 8192) {
-                            try {
-                                String[] split = name.split("\\.");
-                                int x = Integer.parseInt(split[1]);
-                                int z = Integer.parseInt(split[2]);
-                                ChunkLoc loc = new ChunkLoc(x, z);
-                                empty.add(loc);
-                            } catch (NumberFormatException e) {
-                                PS.debug("INVALID MCA: " + name);
-                            }
+                            checkMca(name);
                         } else {
                             Path path = Paths.get(file.getPath());
                             try {
@@ -69,24 +61,26 @@ public class Trim extends SubCommand {
                                 long modification = file.lastModified();
                                 long diff = Math.abs(creation - modification);
                                 if (diff < 10000) {
-                                    try {
-                                        String[] split = name.split("\\.");
-                                        int x = Integer.parseInt(split[1]);
-                                        int z = Integer.parseInt(split[2]);
-                                        ChunkLoc loc = new ChunkLoc(x, z);
-                                        empty.add(loc);
-                                    } catch (Exception e) {
-                                        PS.debug("INVALID MCA: " + name);
-                                    }
+                                    checkMca(name);
                                 }
-                            } catch (IOException ignored) {
-                            }
+                            } catch (IOException ignored) {}
                         }
                     }
                 }
                 Trim.TASK = false;
                 TaskManager.runTaskAsync(whenDone);
             }
+            private void checkMca(String name) {
+                try {
+                    String[] split = name.split("\\.");
+                    int x = Integer.parseInt(split[1]);
+                    int z = Integer.parseInt(split[2]);
+                    ChunkLoc loc = new ChunkLoc(x, z);
+                    empty.add(loc);
+                } catch (NumberFormatException ignored) {
+                    PS.debug("INVALID MCA: " + name);
+                }
+            }
         });
         Trim.TASK = true;
         return true;

Core/src/main/java/com/intellectualcrafters/plot/commands/Update.java

@@ -41,7 +41,7 @@ public class Update extends SubCommand {
             MainUtil.sendMessage(plr, "&cTo manually specify an update URL: /plot update <url>");
             return false;
         }
-        if (PS.get().update(null, url) && (url == PS.get().update)) {
+        if (PS.get().update(plr, url) && (url == PS.get().update)) {
             PS.get().update = null;
         }
         return true;

Core/src/main/java/com/intellectualcrafters/plot/commands/Visit.java

@@ -92,7 +92,7 @@ public class Visit extends SubCommand {
             sendMessage(player, C.NOT_VALID_NUMBER, "(1, " + unsorted.size() + ")");
             return false;
         }
-        ArrayList<Plot> plots = PS.get().sortPlotsByTemp(unsorted);
+        List<Plot> plots = PS.get().sortPlotsByTemp(unsorted);
         Plot plot = plots.get(page - 1);
         if (!plot.hasOwner()) {
             if (!Permissions.hasPermission(player, "plots.visit.unowned")) {

Core/src/main/java/com/intellectualcrafters/plot/config/C.java

@@ -7,6 +7,7 @@ import com.intellectualcrafters.plot.util.StringMan;
 import com.plotsquared.general.commands.CommandCaller;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -730,7 +731,7 @@ public enum C {
                     if (!split[0].equalsIgnoreCase(caption.category)) {
                         changed = true;
                         yml.set(key, null);
-                        yml.set(caption.category + "." + caption.name().toLowerCase(), value);
+                        yml.set(caption.category + '.' + caption.name().toLowerCase(), value);
                     }
                     captions.add(caption);
                     caption.s = value;
@@ -747,7 +748,7 @@ public enum C {
             // HashMap<String, String> replacements = new HashMap<>();
             replacements.clear();
             for (String style : styles) {
-                replacements.put("$" + style, "\u00a7" + config.getString(style));
+                replacements.put('$' + style, '§' + config.getString(style));
             }
             for (char letter : "1234567890abcdefklmnor".toCharArray()) {
                 replacements.put("&" + letter, "\u00a7" + letter);
@@ -761,14 +762,14 @@ public enum C {
                         continue;
                     }
                     changed = true;
-                    yml.set(caption.category + "." + caption.name().toLowerCase(), caption.def);
+                    yml.set(caption.category + '.' + caption.name().toLowerCase(), caption.def);
                 }
                 caption.s = StringMan.replaceFromMap(caption.s, replacements);
             }
             if (changed) {
                 yml.save(file);
             }
-        } catch (Exception e) {
+        } catch (IOException | IllegalArgumentException e) {
             e.printStackTrace();
         }
     }

Core/src/main/java/com/intellectualcrafters/plot/config/Configuration.java

@@ -41,7 +41,7 @@ public class Configuration {
             try {
                 Integer.parseInt(string);
                 return true;
-            } catch (Exception e) {
+            } catch (NumberFormatException ignored) {
                 return false;
             }
         }
@@ -54,12 +54,8 @@ public class Configuration {
     public static final SettingValue<Boolean> BOOLEAN = new SettingValue<Boolean>("BOOLEAN") {
         @Override
         public boolean validateValue(String string) {
-            try {
-                Boolean.parseBoolean(string);
-                return true;
-            } catch (Exception e) {
-                return false;
-            }
+            Boolean.parseBoolean(string);
+            return true;
         }
 
         @Override
@@ -73,7 +69,7 @@ public class Configuration {
             try {
                 Double.parseDouble(string);
                 return true;
-            } catch (Exception e) {
+            } catch (NumberFormatException ignored) {
                 return false;
             }
         }
@@ -89,7 +85,7 @@ public class Configuration {
             try {
                 int biome = WorldUtil.IMP.getBiomeFromString(string.toUpperCase());
                 return biome != -1;
-            } catch (Exception e) {
+            } catch (Exception ignored) {
                 return false;
             }
         }
@@ -134,7 +130,7 @@ public class Configuration {
                     }
                 }
                 return true;
-            } catch (NumberFormatException e) {
+            } catch (NumberFormatException ignored) {
                 return false;
             }
         }
@@ -166,8 +162,7 @@ public class Configuration {
                     if (result != null && result.match < 2) {
                         values[i] = result.best;
                     }
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             }
             int gcd = gcd(counts);
             for (int i = 0; i < counts.length; i++) {

Core/src/main/java/com/intellectualcrafters/plot/database/AbstractDB.java

@@ -36,7 +36,7 @@ public interface AbstractDB {
      * @param plots Plots for which the default table entries should be created
      * @param whenDone
      */
-    void createPlotsAndData(ArrayList<Plot> plots, Runnable whenDone);
+    void createPlotsAndData(List<Plot> plots, Runnable whenDone);
     
     /**
      * Create a plot

Core/src/main/java/com/intellectualcrafters/plot/database/DBFunc.java

@@ -81,7 +81,7 @@ public class DBFunc {
      *
      * @param plots List containing all plot objects
      */
-    public static void createPlotsAndData(ArrayList<Plot> plots, Runnable whenDone) {
+    public static void createPlotsAndData(List<Plot> plots, Runnable whenDone) {
         DBFunc.dbManager.createPlotsAndData(plots, whenDone);
     }
     

Core/src/main/java/com/intellectualcrafters/plot/database/SQLite.java

@@ -39,7 +39,7 @@ public class SQLite extends Database {
         if (!file.exists()) {
             try {
                 file.createNewFile();
-            } catch (IOException e) {
+            } catch (IOException ignored) {
                 PS.debug("&cUnable to create database!");
             }
         }

Core/src/main/java/com/intellectualcrafters/plot/database/StmtMod.java

@@ -12,9 +12,9 @@ public abstract class StmtMod<T> {
     public String getCreateMySQL(int size, String query, int params) {
         StringBuilder statement = new StringBuilder(query);
         for (int i = 0; i < size - 1; i++) {
-            statement.append("(").append(StringMan.repeat(",?", params).substring(1)).append("),");
+            statement.append('(').append(StringMan.repeat(",?", params).substring(1)).append("),");
         }
-        statement.append("(").append(StringMan.repeat(",?", params).substring(1)).append(")");
+        statement.append('(').append(StringMan.repeat(",?", params).substring(1)).append(')');
         return statement.toString();
     }
 
@@ -22,7 +22,7 @@ public abstract class StmtMod<T> {
         StringBuilder statement = new StringBuilder(query);
         String modParams = StringMan.repeat(",?", params).substring(1);
         for (int i = 0; i < size - 1; i++) {
-            statement.append("UNION SELECT ").append(modParams).append(" ");
+            statement.append("UNION SELECT ").append(modParams).append(' ');
         }
         return statement.toString();
     }

Core/src/main/java/com/intellectualcrafters/plot/flag/Flag.java

@@ -4,7 +4,7 @@ import com.intellectualcrafters.plot.object.Plot;
 
 public class Flag<V> {
 
-    private String name;
+    private final String name;
 
     /**
      * Flag object used to store basic information for a Plot. Flags are a

Core/src/main/java/com/intellectualcrafters/plot/flag/FlagManager.java

@@ -94,9 +94,8 @@ public class FlagManager {
     public static String toString(HashMap<Flag<?>, Object> flags) {
         StringBuilder flag_string = new StringBuilder();
         int i = 0;
-        Flag<?> flag;
         for (Map.Entry<Flag<?>, Object> entry : flags.entrySet()) {
-            flag = entry.getKey();
+            Flag<?> flag = entry.getKey();
             if (i != 0) {
                 flag_string.append(",");
             }
@@ -163,7 +162,7 @@ public class FlagManager {
      * @param plot
      * @return set of flags
      */
-    public static HashMap<Flag<?>, Object> getPlotFlags(Plot plot) {
+    public static Map<Flag<?>, Object> getPlotFlags(Plot plot) {
         if (!plot.hasOwner()) {
             return null;
         }
@@ -189,7 +188,7 @@ public class FlagManager {
         return flags;
     }
 
-    public static HashMap<Flag<?>, Object> getSettingFlags(PlotArea area, PlotSettings settings) {
+    public static Map<Flag<?>, Object> getSettingFlags(PlotArea area, PlotSettings settings) {
         return getPlotFlags(area, settings, false);
     }
 
@@ -258,7 +257,7 @@ public class FlagManager {
      *
      * @param player with permissions
      *
-     * @return List (AbstractFlag)
+     * @return List (Flag)
      */
     public static List<Flag> getFlags(PlotPlayer player) {
         List<Flag> returnFlags = new ArrayList<>();
@@ -271,11 +270,11 @@ public class FlagManager {
     }
 
     /**
-     * Get an AbstractFlag by a string Returns null if flag does not exist
+     * Get an Flag by a String
      *
-     * @param string Flag Key
+     * @param string the flag name
      *
-     * @return AbstractFlag
+     * @return the flag or null if the flag the provided name does not exist
      */
     public static Flag<?> getFlag(String string) {
         for (Flag flag : Flags.getFlags()) {
@@ -289,7 +288,22 @@ public class FlagManager {
         return null;
     }
 
-    public static HashMap<Flag<?>, Object> parseFlags(List<String> flagstrings) {
+    public static Flag<?> getFlag(String string, boolean ignoreReserved) {
+        for (Flag flag : Flags.getFlags()) {
+            if (flag.getName().equalsIgnoreCase(string)) {
+                if (!ignoreReserved) {
+                    if (isReserved(flag)) {
+                        return null;
+                    }
+                }
+                return flag;
+            }
+        }
+        return null;
+    }
+
+
+    public static Map<Flag<?>, Object> parseFlags(List<String> flagstrings) {
         HashMap<Flag<?>, Object> map = new HashMap<>();
 
         for (String key : flagstrings) {

Core/src/main/java/com/intellectualcrafters/plot/generator/AugmentedUtils.java

@@ -127,9 +127,8 @@ public class AugmentedUtils {
                 }
                 if (!has) {
                     continue;
-                } else {
-                    toReturn = true;
                 }
+                toReturn = true;
                 secondaryMask = new PlotChunk<Object>(wrap) {
                     @Override
                     public Object getChunkAbs() {
@@ -144,8 +143,7 @@ public class AugmentedUtils {
                     }
 
                     @Override
-                    public void setBiome(int x, int z, int biome) {
-                    }
+                    public void setBiome(int x, int z, int biome) {}
 
                     @Override
                     public PlotChunk clone() {

Core/src/main/java/com/intellectualcrafters/plot/generator/HybridPlotWorld.java

@@ -158,7 +158,7 @@ public class HybridPlotWorld extends ClassicPlotWorld {
         }
         try {
             setupSchematics();
-        } catch (Exception e) {
+        } catch (Exception ignored) {
             PS.debug("&c - road schematics are disabled for this world.");
         }
     }

Core/src/main/java/com/intellectualcrafters/plot/generator/IndependentPlotGenerator.java

@@ -55,8 +55,7 @@ public abstract class IndependentPlotGenerator {
      *  - e.g. If setup doesn't support some standard options
      * @param setup
      */
-    public void processSetup(SetupObject setup) {
-    }
+    public void processSetup(SetupObject setup) {}
 
     /**
      * It is preferred for the PlotArea object to do most of the initialization necessary.

Core/src/main/java/com/intellectualcrafters/plot/generator/SquarePlotManager.java

@@ -176,7 +176,7 @@ public abstract class SquarePlotManager extends GridPlotManager {
                     return plot.getMerged(7) ? id : null;
             }
             PS.debug("invalid location: " + Arrays.toString(merged));
-        } catch (Exception e) {
+        } catch (Exception ignored) {
             PS.debug("Invalid plot / road width in settings.yml for world: " + plotworld.worldname);
         }
         return null;

Core/src/main/java/com/intellectualcrafters/plot/object/BlockLoc.java

@@ -74,7 +74,7 @@ public class BlockLoc {
         if (this.x == 0 && this.y == 0 && this.z == 0) {
             return "";
         }
-        return this.x + "," + this.y + "," + this.z + "," + this.yaw + "," + this.pitch;
+        return this.x + "," + this.y + ',' + this.z + ',' + this.yaw + ',' + this.pitch;
 
     }
 }

Core/src/main/java/com/intellectualcrafters/plot/object/ConsolePlayer.java

@@ -87,12 +87,10 @@ public class ConsolePlayer extends PlotPlayer {
     }
     
     @Override
-    public void setCompassTarget(Location location) {
-    }
+    public void setCompassTarget(Location location) {}
 
     @Override
-    public void setAttribute(String key) {
-    }
+    public void setAttribute(String key) {}
     
     @Override
     public boolean getAttribute(String key) {
@@ -100,8 +98,7 @@ public class ConsolePlayer extends PlotPlayer {
     }
     
     @Override
-    public void removeAttribute(String key) {
-    }
+    public void removeAttribute(String key) {}
     
     @Override
     public void setMeta(String key, Object value) {
@@ -124,8 +121,7 @@ public class ConsolePlayer extends PlotPlayer {
     }
     
     @Override
-    public void setWeather(PlotWeather weather) {
-    }
+    public void setWeather(PlotWeather weather) {}
     
     @Override
     public PlotGameMode getGameMode() {
@@ -133,24 +129,19 @@ public class ConsolePlayer extends PlotPlayer {
     }
     
     @Override
-    public void setGameMode(PlotGameMode gameMode) {
-    }
+    public void setGameMode(PlotGameMode gameMode) {}
     
     @Override
-    public void setTime(long time) {
-    }
+    public void setTime(long time) {}
     
     @Override
-    public void setFlight(boolean fly) {
-    }
+    public void setFlight(boolean fly) {}
     
     @Override
-    public void playMusic(Location location, int id) {
-    }
+    public void playMusic(Location location, int id) {}
     
     @Override
-    public void kick(String message) {
-    }
+    public void kick(String message) {}
 
     @Override public void stopSpectating() {}
 

Core/src/main/java/com/intellectualcrafters/plot/object/Plot.java

@@ -2,6 +2,7 @@ package com.intellectualcrafters.plot.object;
 
 import com.google.common.base.Optional;
 import com.google.common.collect.BiMap;
+import com.google.common.collect.ImmutableSet;
 import com.intellectualcrafters.jnbt.CompoundTag;
 import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.config.C;
@@ -212,19 +213,19 @@ public class Plot {
         String[] split = string.split(";|,");
         if (split.length == 2) {
             if (defaultArea != null) {
-                PlotId id = PlotId.fromString(split[0] + ";" + split[1]);
+                PlotId id = PlotId.fromString(split[0] + ';' + split[1]);
                 return id != null ? defaultArea.getPlotAbs(id) : null;
             }
         } else if (split.length == 3) {
             PlotArea pa = PS.get().getPlotArea(split[0], null);
             if (pa != null) {
-                PlotId id = PlotId.fromString(split[1] + ";" + split[2]);
+                PlotId id = PlotId.fromString(split[1] + ';' + split[2]);
                 return pa.getPlotAbs(id);
             }
         } else if (split.length == 4) {
             PlotArea pa = PS.get().getPlotArea(split[0], split[1]);
             if (pa != null) {
-                PlotId id = PlotId.fromString(split[1] + ";" + split[2]);
+                PlotId id = PlotId.fromString(split[1] + ';' + split[2]);
                 return pa.getPlotAbs(id);
             }
         }
@@ -334,7 +335,7 @@ public class Plot {
         if (!isMerged()) {
             return false;
         }
-        HashSet<Plot> connected = getConnectedPlots();
+        Set<Plot> connected = getConnectedPlots();
         for (Plot current : connected) {
             if (uuid.equals(current.owner)) {
                 return true;
@@ -348,17 +349,17 @@ public class Plot {
     }
 
     /**
-     * Get a list of owner UUIDs for a plot (supports multi-owner mega-plots).
-     * @return
+     * Get a immutable set of owner UUIDs for a plot (supports multi-owner mega-plots).
+     * @return the Plot owners
      */
-    public HashSet<UUID> getOwners() {
+    public Set<UUID> getOwners() {
         if (this.owner == null) {
-            return new HashSet<>();
+            return Collections.emptySet();
         }
         if (isMerged()) {
-            HashSet<Plot> plots = getConnectedPlots();
+            Set<Plot> plots = getConnectedPlots();
             Plot[] array = plots.toArray(new Plot[plots.size()]);
-            HashSet<UUID> owners = new HashSet<UUID>(1);
+            ImmutableSet.Builder<UUID> owners = ImmutableSet.builder();
             UUID last = this.owner;
             owners.add(this.owner);
             for (Plot current : array) {
@@ -367,9 +368,9 @@ public class Plot {
                     last = current.owner;
                 }
             }
-            return owners;
+            return owners.build();
         }
-        return new HashSet<>(Collections.singletonList(this.owner));
+        return ImmutableSet.of(this.owner);
     }
 
     /**
@@ -380,10 +381,7 @@ public class Plot {
      * @return true if the player is added/trusted or is the owner
      */
     public boolean isAdded(UUID uuid) {
-        if (this.owner == null) {
-            return false;
-        }
-        if (getDenied().contains(uuid)) {
+        if (this.owner == null || getDenied().contains(uuid)) {
             return false;
         }
         if (getTrusted().contains(uuid) || getTrusted().contains(DBFunc.everyone)) {
@@ -749,14 +747,11 @@ public class Plot {
     }
 
     public boolean clear(boolean checkRunning, final boolean isDelete, final Runnable whenDone) {
-        if (checkRunning && this.getRunning() != 0) {
-            return false;
-        }
-        if (!EventUtil.manager.callClear(this)) {
+        if (checkRunning && this.getRunning() != 0 || !EventUtil.manager.callClear(this)) {
             return false;
         }
         final HashSet<RegionWrapper> regions = this.getRegions();
-        final HashSet<Plot> plots = this.getConnectedPlots();
+        final Set<Plot> plots = this.getConnectedPlots();
         final ArrayDeque<Plot> queue = new ArrayDeque<>(plots);
         if (isDelete) {
             this.removeSign();
@@ -843,7 +838,7 @@ public class Plot {
     }
 
     /**
-     * Unlink the plot and all connected plots
+     * Unlink the plot and all connected plots.
      * @param createSign
      * @param createRoad
      * @return
@@ -852,7 +847,7 @@ public class Plot {
         if (!this.isMerged()) {
             return false;
         }
-        HashSet<Plot> plots = this.getConnectedPlots();
+        Set<Plot> plots = this.getConnectedPlots();
         ArrayList<PlotId> ids = new ArrayList<>(plots.size());
         for (Plot current : plots) {
             current.setHome(null);
@@ -984,7 +979,7 @@ public class Plot {
         if (!this.hasOwner()) {
             return false;
         }
-        final HashSet<Plot> plots = this.getConnectedPlots();
+        final Set<Plot> plots = this.getConnectedPlots();
         this.clear(false, true, new Runnable() {
             @Override
             public void run() {
@@ -1064,9 +1059,8 @@ public class Plot {
     }
 
     /**
-     * Unclaim the plot (does not modify terrain)<br>
-     *      - Changes made to this plot will not be reflected in unclaimed plot objects<br>
-     * @return
+     * Unclaim the plot (does not modify terrain). Changes made to this plot will not be reflected in unclaimed plot objects.
+     * @return false if the Plot has no owner, otherwise true.
      */
     public boolean unclaim() {
         if (this.owner == null) {
@@ -1266,9 +1260,7 @@ public class Plot {
         });
     }
 
-    /**
-     * Remove the plot sign if it is set
-     */
+    /** Remove the plot sign if it is set. */
     public void removeSign() {
         PlotManager manager = this.area.getPlotManager();
         if (!this.area.ALLOW_SIGNS) {
@@ -1278,9 +1270,7 @@ public class Plot {
         SetQueue.IMP.setBlock(this.area.worldname, loc.getX(), loc.getY(), loc.getZ(), 0);
     }
 
-    /**
-     * Set the plot sign if plot signs are enabled.
-     */
+    /** Set the plot sign if plot signs are enabled. */
     public void setSign() {
         if (this.owner == null) {
             this.setSign("unknown");
@@ -1742,7 +1732,7 @@ public class Plot {
                     TaskManager.runTaskAsync(new Runnable() {
                         @Override
                         public void run() {
-                            String name = Plot.this.id + "," + Plot.this.area + "," + MainUtil.getName(Plot.this.owner);
+                            String name = Plot.this.id + "," + Plot.this.area + ',' + MainUtil.getName(Plot.this.owner);
                             boolean result =
                                     SchematicHandler.manager.save(value, Settings.SCHEMATIC_SAVE_PATH + File.separator + name + ".schematic");
                             if (whenDone != null) {
@@ -2034,7 +2024,7 @@ public class Plot {
                 this.create();
             }
             return this.owner;
-        } catch (IllegalArgumentException e) {
+        } catch (IllegalArgumentException ignored) {
             return null;
         }
     }
@@ -2078,7 +2068,7 @@ public class Plot {
         }
         HashSet<Plot> visited = new HashSet<>();
         HashSet<PlotId> merged = new HashSet<>();
-        HashSet<Plot> connected = this.getConnectedPlots();
+        Set<Plot> connected = this.getConnectedPlots();
         for (Plot current : connected) {
             merged.add(current.getId());
         }
@@ -2093,8 +2083,7 @@ public class Plot {
             Set<Plot> plots;
             if ((dir == -1 || dir == 0) && !current.getMerged(0)) {
                 Plot other = current.getRelative(0);
-                if (other != null
-                        && other.isOwner(uuid)
+                if (other != null && other.isOwner(uuid)
                         && (other.getBasePlot(false).equals(current.getBasePlot(false))
                         || (plots = other.getConnectedPlots()).size() <= max && frontier.addAll(plots) && (max -= plots.size()) != -1)) {
                     current.mergePlot(other, removeRoads);
@@ -2105,12 +2094,9 @@ public class Plot {
             }
             if (max >= 0 && (dir == -1 || dir == 1) && !current.getMerged(1)) {
                 Plot other = current.getRelative(1);
-                if (other != null
-                        && other.isOwner(uuid)
+                if (other != null && other.isOwner(uuid)
                         && (other.getBasePlot(false).equals(current.getBasePlot(false))
-                        || (plots = other.getConnectedPlots()).size() <= max && frontier.addAll(plots) &&
-
-                        (max -= plots.size()) != -1)) {
+                        || (plots = other.getConnectedPlots()).size() <= max && frontier.addAll(plots) && (max -= plots.size()) != -1)) {
                     current.mergePlot(other, removeRoads);
                     merged.add(current.getId());
                     merged.add(other.getId());
@@ -2245,14 +2231,14 @@ public class Plot {
      *  - This result is cached globally
      * @return
      */
-    public HashSet<Plot> getConnectedPlots() {
+    public Set<Plot> getConnectedPlots() {
         if (this.settings == null) {
-            return new HashSet<>(Collections.singletonList(this));
+            return Collections.singleton(this);
         }
         boolean[] merged = this.getMerged();
         int hash = MainUtil.hash(merged);
         if (hash == 0) {
-            return new HashSet<>(Collections.singletonList(this));
+            return Collections.singleton(this);
         }
         if (connected_cache != null && connected_cache.contains(this)) {
             return connected_cache;
@@ -2388,7 +2374,7 @@ public class Plot {
             regions_cache.add(new RegionWrapper(pos1.getX(), pos2.getX(), pos1.getY(), pos2.getY(), pos1.getZ(), pos2.getZ()));
             return regions_cache;
         }
-        HashSet<Plot> plots = this.getConnectedPlots();
+        Set<Plot> plots = this.getConnectedPlots();
         HashSet<RegionWrapper> regions = regions_cache = new HashSet<>();
         HashSet<PlotId> visited = new HashSet<>();
         for (Plot current : plots) {
@@ -2576,16 +2562,15 @@ public class Plot {
                         return;
                     }
                     TaskManager.TELEPORT_QUEUE.remove(name);
-                    if (!player.isOnline()) {
-                        return;
+                    if (player.isOnline()) {
+                        MainUtil.sendMessage(player, C.TELEPORTED_TO_PLOT);
+                        player.teleport(location);
                     }
-                    MainUtil.sendMessage(player, C.TELEPORTED_TO_PLOT);
-                    player.teleport(location);
                 }
             }, Settings.TELEPORT_DELAY * 20);
             return true;
         }
-        return result;
+        return false;
     }
 
     public boolean isOnline() {
@@ -2715,7 +2700,7 @@ public class Plot {
             return false;
         }
         boolean occupied = false;
-        HashSet<Plot> plots = this.getConnectedPlots();
+        Set<Plot> plots = this.getConnectedPlots();
         for (Plot plot : plots) {
             Plot other = plot.getRelative(destination.getArea(), offset.x, offset.y);
             if (other.hasOwner()) {
@@ -2809,7 +2794,7 @@ public class Plot {
             TaskManager.runTaskLater(whenDone, 1);
             return false;
         }
-        HashSet<Plot> plots = this.getConnectedPlots();
+        Set<Plot> plots = this.getConnectedPlots();
         for (Plot plot : plots) {
             Plot other = plot.getRelative(destination.getArea(), offset.x, offset.y);
             if (other.hasOwner()) {
@@ -2876,6 +2861,6 @@ public class Plot {
     }
 
     public boolean hasFlag(Flag<?> flag) {
-        return false;
+        return getFlags().containsKey(flag);
     }
 }

Core/src/main/java/com/intellectualcrafters/plot/object/PlotAnalysis.java

@@ -515,7 +515,7 @@ public class PlotAnalysis {
         int SIZE = 10;
         List<Integer>[] bucket = new ArrayList[SIZE];
         for (int i = 0; i < bucket.length; i++) {
-            bucket[i] = new ArrayList<Integer>();
+            bucket[i] = new ArrayList<>();
         }
         boolean maxLength = false;
         int placement = 1;

Core/src/main/java/com/intellectualcrafters/plot/object/PlotArea.java

@@ -7,6 +7,7 @@ import com.intellectualcrafters.plot.config.ConfigurationNode;
 import com.intellectualcrafters.plot.config.Settings;
 import com.intellectualcrafters.plot.flag.Flag;
 import com.intellectualcrafters.plot.flag.FlagManager;
+import com.intellectualcrafters.plot.flag.Flags;
 import com.intellectualcrafters.plot.generator.GridPlotWorld;
 import com.intellectualcrafters.plot.generator.IndependentPlotGenerator;
 import com.intellectualcrafters.plot.util.EconHandler;
@@ -53,9 +54,9 @@ public abstract class PlotArea {
     public boolean SCHEMATIC_ON_CLAIM = false;
     public String SCHEMATIC_FILE = "null";
     public List<String> SCHEMATICS = null;
-    public HashMap<Flag<?>, Object> DEFAULT_FLAGS;
+    public Map<Flag<?>, Object> DEFAULT_FLAGS;
     public boolean USE_ECONOMY = false;
-    public HashMap<String, Double> PRICES = new HashMap<>();
+    public Map<String, Double> PRICES = new HashMap<>();
     public boolean SPAWN_EGGS = false;
     public boolean SPAWN_CUSTOM = true;
     public boolean SPAWN_BREEDING = false;
@@ -165,10 +166,7 @@ public abstract class PlotArea {
         if (this == obj) {
             return true;
         }
-        if (obj == null) {
-            return false;
-        }
-        if (getClass() != obj.getClass()) {
+        if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
         PlotArea plotarea = (PlotArea) obj;
@@ -187,11 +185,8 @@ public abstract class PlotArea {
     public boolean isCompatible(PlotArea plotArea) {
         ConfigurationSection section = PS.get().config.getConfigurationSection("worlds");
         for (ConfigurationNode setting : plotArea.getSettingNodes()) {
-            Object constant = section.get(plotArea.worldname + "." + setting.getConstant());
-            if (constant == null) {
-                return false;
-            }
-            if (!constant.equals(section.get(this.worldname + "." + setting.getConstant()))) {
+            Object constant = section.get(plotArea.worldname + '.' + setting.getConstant());
+            if (constant == null || !constant.equals(section.get(this.worldname + '.' + setting.getConstant()))) {
                 return false;
             }
         }
@@ -269,7 +264,7 @@ public abstract class PlotArea {
             try {
                 String[] split = homeDefault.split(",");
                 this.DEFAULT_HOME = new PlotLoc(Integer.parseInt(split[0]), Integer.parseInt(split[1]));
-            } catch (NumberFormatException e) {
+            } catch (NumberFormatException ignored) {
                 this.DEFAULT_HOME = null;
             }
         }
@@ -283,7 +278,7 @@ public abstract class PlotArea {
                 Set<String> keys = section.getKeys(false);
                 for (String key : keys) {
                     if (!"default".equals(key)) {
-                        flags.add(key + ";" + section.get(key));
+                        flags.add(key + ';' + section.get(key));
                     }
                 }
             }
@@ -475,8 +470,8 @@ public abstract class PlotArea {
         return myPlots;
     }
     
-    public Set<Plot> getPlots(UUID uuid) {
-        HashSet<Plot> myplots = new HashSet<>();
+    public Set<Plot> getPlots(final UUID uuid) {
+        final HashSet<Plot> myplots = new HashSet<>();
         for (Plot plot : getPlots()) {
             if (plot.isBasePlot()) {
                 if (plot.isOwner(uuid)) {
@@ -488,7 +483,7 @@ public abstract class PlotArea {
     }
     
     public Set<Plot> getPlots(PlotPlayer player) {
-        return player != null ? getPlots(player.getUUID()) : new HashSet<Plot>();
+        return getPlots(player.getUUID());
     }
     
     public Set<Plot> getPlotsAbs(PlotPlayer player) {
@@ -499,7 +494,7 @@ public abstract class PlotArea {
         int count = 0;
         if (!Settings.DONE_COUNTS_TOWARDS_LIMIT) {
             for (Plot plot : getPlotsAbs(uuid)) {
-                if (!plot.getFlags().containsKey("done")) {
+                if (!plot.hasFlag(Flags.DONE)) {
                     count++;
                 }
             }

Core/src/main/java/com/intellectualcrafters/plot/object/PlotHandler.java

@@ -1,6 +1,6 @@
 package com.intellectualcrafters.plot.object;
 
-import java.util.HashSet;
+import java.util.Set;
 import java.util.UUID;
 
 public class PlotHandler {
@@ -8,7 +8,7 @@ public class PlotHandler {
         if ((plot1.owner == null) || (plot2.owner == null)) {
             return false;
         }
-        final HashSet<UUID> owners = plot1.getOwners();
+        final Set<UUID> owners = plot1.getOwners();
         owners.retainAll(plot2.getOwners());
         return !owners.isEmpty();
     }

Core/src/main/java/com/intellectualcrafters/plot/object/PlotId.java

@@ -42,7 +42,7 @@ public class PlotId {
         try {
             x = Integer.parseInt(parts[0]);
             y = Integer.parseInt(parts[1]);
-        } catch (NumberFormatException e) {
+        } catch (NumberFormatException ignored) {
             return null;
         }
         return new PlotId(x, y);

Core/src/main/java/com/intellectualcrafters/plot/object/PlotPlayer.java

@@ -4,6 +4,7 @@ import com.intellectualcrafters.plot.PS;
 import com.intellectualcrafters.plot.commands.RequiredType;
 import com.intellectualcrafters.plot.config.Settings;
 import com.intellectualcrafters.plot.database.DBFunc;
+import com.intellectualcrafters.plot.flag.Flags;
 import com.intellectualcrafters.plot.util.EventUtil;
 import com.intellectualcrafters.plot.util.ExpireManager;
 import com.intellectualcrafters.plot.util.Permissions;
@@ -145,7 +146,7 @@ public abstract class PlotPlayer implements CommandCaller {
             public void run(PlotArea value) {
                 if (!Settings.DONE_COUNTS_TOWARDS_LIMIT) {
                     for (Plot plot : value.getPlotsAbs(uuid)) {
-                        if (!plot.getFlags().containsKey("done")) {
+                        if (!plot.hasFlag(Flags.DONE)) {
                             count.incrementAndGet();
                         }
                     }
@@ -245,19 +246,6 @@ public abstract class PlotPlayer implements CommandCaller {
      */
     public abstract UUID getUUID();
 
-    /**
-     * Check the player's permissions<br>
-     *  - Will be cached if permission caching is enabled
-     */
-    @Override
-    public abstract boolean hasPermission(String permission);
-
-    /**
-     * Send the player a message
-     */
-    @Override
-    public abstract void sendMessage(String message);
-
     /**
      * Teleport the player to a location
      * @param location

Core/src/main/java/com/intellectualcrafters/plot/util/BO3Handler.java

@@ -254,7 +254,7 @@ public class BO3Handler {
             try (FileOutputStream fos = new FileOutputStream(bo3File)) {
                 write(fos, plot, bo3);
             }
-        } catch (Exception e) {
+        } catch (IOException e) {
             e.printStackTrace();
             return false;
         }

Core/src/main/java/com/intellectualcrafters/plot/util/ChunkManager.java

@@ -222,8 +222,7 @@ public abstract class ChunkManager {
                     int z = Integer.parseInt(split[2]);
                     ChunkLoc loc = new ChunkLoc(x, z);
                     chunks.add(loc);
-                } catch (NumberFormatException ignored) {
-                }
+                } catch (NumberFormatException ignored) {}
             }
         }
         return chunks;