EpicKnarvik97/Blacksmith
EpicKnarvik97/Blacksmith
1
0
Fork 0
Code Issues Pull Requests Projects Releases 8 Wiki Activity

Remove unnecessary options #8

New Issue
Closed
opened 2022-10-12 13:13:14 +02:00 by EpicKnarvik97 · 0 comments
EpicKnarvik97 commented 2022-10-12 13:13:14 +02:00
Owner
Copy Link

The options for disableCoolDown and disableDelay are quite useless. It would be better to trigger their special behavior if the cooldown or delay is <= 0 instead. While it isn't that much of a problem, it really only adds confusion as setting the cool-down to 0 and disabling cool-down has slightly different behavior currently.

The options for disableCoolDown and disableDelay are quite useless. It would be better to trigger their special behavior if the cooldown or delay is <= 0 instead. While it isn't that much of a problem, it really only adds confusion as setting the cool-down to 0 and disabling cool-down has slightly different behavior currently.
EpicKnarvik97 added the
enhancement
 label 2022-10-12 13:13:14 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: EpicKnarvik97/Blacksmith#8
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?