Item salvaging #18

New Issue

EpicKnarvik97 · 2023-01-13T20:31:44+01:00

EpicKnarvik97 commented

2023-01-13 20:31:44 +01:00

It has been suggested to implement a possibility for blacksmiths to salvage items. It should be possible to implement random salvage by using the recipe class to get the items a player should get back. The actual interaction to lead to a salvage requires some thought. There's also a question of whether it should be kind of separate, or basically follow the same rules as reforging.

There is also a question of balancing. For example, for a diamond pick-axe with 2/5 durability remaining, you might end up with two sticks as salvage. One way would be to just don't count sticks when calculating salvage, but that would kind of break salvage for fishing rods.

If the salvage would result in 0 items, the salvage should probably be blocked.
It could be possible to give money instead of items as salvage.
A salvageAbleItems whitelist setting supporting the same presets as reforgeAbleItems would be useful.
Should it cost a sum to salvage items, or should it be free?
Netherite items are not salvageable as giving back the netherite ingot would be too OP, unless it's at full durability.

It could be possible to return enchantment salvage in the form of XP.

It has been suggested to implement a possibility for blacksmiths to salvage items. It should be possible to implement random salvage by using the recipe class to get the items a player should get back. The actual interaction to lead to a salvage requires some thought. There's also a question of whether it should be kind of separate, or basically follow the same rules as reforging. There is also a question of balancing. For example, for a diamond pick-axe with 2/5 durability remaining, you might end up with two sticks as salvage. One way would be to just don't count sticks when calculating salvage, but that would kind of break salvage for fishing rods. If the salvage would result in 0 items, the salvage should probably be blocked. It could be possible to give money instead of items as salvage. A salvageAbleItems whitelist setting supporting the same presets as reforgeAbleItems would be useful. Should it cost a sum to salvage items, or should it be free? Netherite items are not salvageable as giving back the netherite ingot would be too OP, unless it's at full durability. It could be possible to return enchantment salvage in the form of XP.

EpicKnarvik97 added the

enhancement

label 2023-01-13 20:31:44 +01:00

EpicKnarvik97 referenced this issue from a commit

2023-01-13 20:34:39 +01:00

Adds a helper class for calculating random item salvage #18

EpicKnarvik97 commented

2024-05-04 21:16:17 +02:00

This has now been implemented

EpicKnarvik97 closed this issue

2024-05-04 21:16:17 +02:00

Sign in to join this conversation.