Finishes the scrapper implementation
	
		
			
	
		
	
	
		
	
		
			Some checks failed
		
		
	
	
		
			
				
	
				EpicKnarvik97/Blacksmith/pipeline/head There was a failure building this commit
				
			
		
		
	
	
				
					
				
			
		
			Some checks failed
		
		
	
	EpicKnarvik97/Blacksmith/pipeline/head There was a failure building this commit
				
			This commit is contained in:
		@@ -86,7 +86,7 @@ public class ItemHelperTest {
 | 
			
		||||
    @Test
 | 
			
		||||
    public void getAllReforgeAbleMaterialsTest() {
 | 
			
		||||
        List<Material> materials = ItemHelper.getAllReforgeAbleMaterials();
 | 
			
		||||
        assertTrue(materials.size() > 0);
 | 
			
		||||
        assertFalse(materials.isEmpty());
 | 
			
		||||
 | 
			
		||||
        for (Material material : materials) {
 | 
			
		||||
            assertTrue(ItemHelper.getMaxDurability(new ItemStack(material, 1)) > 0);
 | 
			
		||||
 
 | 
			
		||||
@@ -41,14 +41,14 @@ public class SalvageHelperTest {
 | 
			
		||||
    @Test
 | 
			
		||||
    public void getNullForInvalidItemTest() {
 | 
			
		||||
        //Assert that a non-reforge-able item will return null
 | 
			
		||||
        assertNull(SalvageHelper.getSalvage(server, new ItemStack(Material.POTATO, 1), new ArrayList<>()));
 | 
			
		||||
        assertNull(SalvageHelper.getSalvage(server, new ItemStack(Material.POTATO, 1), new ArrayList<>(), false));
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    public void getNullForLessThanOneItemTest() {
 | 
			
		||||
        //Assert that 0 or 1 items will return null
 | 
			
		||||
        assertNull(SalvageHelper.getSalvage(server, new ItemStack(Material.IRON_AXE, 0), new ArrayList<>()));
 | 
			
		||||
        assertNull(SalvageHelper.getSalvage(server, new ItemStack(Material.IRON_SWORD, -1), new ArrayList<>()));
 | 
			
		||||
        assertNull(SalvageHelper.getSalvage(server, new ItemStack(Material.IRON_AXE, 0), new ArrayList<>(), false));
 | 
			
		||||
        assertNull(SalvageHelper.getSalvage(server, new ItemStack(Material.IRON_SWORD, -1), new ArrayList<>(), false));
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
@@ -58,7 +58,7 @@ public class SalvageHelperTest {
 | 
			
		||||
        expectedSalvage.add(new ItemStack(Material.STICK, 2));
 | 
			
		||||
        ItemStack itemToSalvage = new ItemStack(Material.DIAMOND_PICKAXE, 1);
 | 
			
		||||
        //Note: Conversion to sets makes sure the order doesn't matter
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, new ArrayList<>());
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, new ArrayList<>(), false);
 | 
			
		||||
        if (salvage == null) {
 | 
			
		||||
            fail();
 | 
			
		||||
        } else {
 | 
			
		||||
@@ -67,13 +67,13 @@ public class SalvageHelperTest {
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    public void getSeveralFullSalvageTest() {
 | 
			
		||||
    public void getExtendedSalvageTest() {
 | 
			
		||||
        Set<ItemStack> expectedSalvage = new HashSet<>();
 | 
			
		||||
        expectedSalvage.add(new ItemStack(Material.DIAMOND, 21));
 | 
			
		||||
        expectedSalvage.add(new ItemStack(Material.STICK, 14));
 | 
			
		||||
        ItemStack itemToSalvage = new ItemStack(Material.DIAMOND_PICKAXE, 7);
 | 
			
		||||
        expectedSalvage.add(new ItemStack(Material.GUNPOWDER, 5));
 | 
			
		||||
        expectedSalvage.add(new ItemStack(Material.SAND, 4));
 | 
			
		||||
        ItemStack itemToSalvage = new ItemStack(Material.TNT, 1);
 | 
			
		||||
        //Note: Conversion to sets makes sure the order doesn't matter
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, new ArrayList<>());
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, new ArrayList<>(), true);
 | 
			
		||||
        if (salvage == null) {
 | 
			
		||||
            fail();
 | 
			
		||||
        } else {
 | 
			
		||||
@@ -93,7 +93,7 @@ public class SalvageHelperTest {
 | 
			
		||||
            damageable.setDamage(100);
 | 
			
		||||
        }
 | 
			
		||||
        itemToSalvage.setItemMeta(meta);
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, new ArrayList<>());
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, new ArrayList<>(), false);
 | 
			
		||||
        //Assert that some items are given
 | 
			
		||||
        assertNotEquals(salvage, new ArrayList<>());
 | 
			
		||||
        //Assert that a damaged item won't give full salvage
 | 
			
		||||
@@ -113,7 +113,7 @@ public class SalvageHelperTest {
 | 
			
		||||
            damageable.setDamage(100);
 | 
			
		||||
        }
 | 
			
		||||
        itemToSalvage.setItemMeta(meta);
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, ignoredSalvage);
 | 
			
		||||
        List<ItemStack> salvage = SalvageHelper.getSalvage(server, itemToSalvage, ignoredSalvage, false);
 | 
			
		||||
        //Assert that some items are given
 | 
			
		||||
        assertNotEquals(salvage, new ArrayList<>());
 | 
			
		||||
        //Assert that a damaged diamond pickaxe with sticks ignored returns 2 diamonds a salvage
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user