Fixes some savage fail problems
All checks were successful
EpicKnarvik97/Blacksmith/pipeline/head This commit looks good
All checks were successful
EpicKnarvik97/Blacksmith/pipeline/head This commit looks good
Fixes item not being returned when salvage fails Removes some redundancy when giving back items Makes extended salvage return 50% of the salvage (no items if only one item would be returned) Adds a better message when failing to salvage extended salvage items Fixes a bug in the caching of smith presets
This commit is contained in:
@ -127,10 +127,20 @@ public class ScrapperNPCSettings implements TraitSettings<ScrapperSetting> {
|
||||
* @return <p>The salvage fail message</p>
|
||||
*/
|
||||
@NotNull
|
||||
public String getFailMessage() {
|
||||
public String getFailSalvageMessage() {
|
||||
return asString(ScrapperSetting.FAIL_SALVAGE_MESSAGE);
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets the message to display when a scrapper fails to salvage an item without durability
|
||||
*
|
||||
* @return <p>The extended salvage fail message</p>
|
||||
*/
|
||||
@NotNull
|
||||
public String getFailExtendedSalvageMessage() {
|
||||
return asString(ScrapperSetting.FAIL_SALVAGE_EXTENDED_MESSAGE);
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets the message to use for displaying salvage cost
|
||||
*
|
||||
|
@ -146,6 +146,13 @@ public enum ScrapperSetting implements Setting {
|
||||
"next time?", "The message to display when a scrapper fails to salvage an item because of the " +
|
||||
"fail chance.", true, true),
|
||||
|
||||
/**
|
||||
* The message displayed if a salvage of an item without durability is unsuccessful
|
||||
*/
|
||||
FAIL_SALVAGE_EXTENDED_MESSAGE("failExtendedSalvageMessage", SettingValueType.STRING,
|
||||
"&cWhoops! I was unable to extract much, if any, salvage! Maybe next time?",
|
||||
"The message to display when the scrapper fails to salvage an item without durability", true, true),
|
||||
|
||||
/**
|
||||
* The message displayed if a player presents a different item after seeing the price to reforge an item
|
||||
*/
|
||||
|
Reference in New Issue
Block a user